Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?
HI Star, I tried to remove SmbusLib.h from InternalS3SaveState.h., there will be build errors.Smbus related logic exists in S3SaveState.c At 2016-01-21 18:09:41, "Zeng, Star" <star.z...@intel.com> wrote: >It is just to include header file, I believe it could be removed from >InternalS3SaveState.h. >What libraries a driver will link is not determined by source files, but inf >file ( S3SaveStateDxe.inf)? > >Why does S3SaveStateDxe.inf finally link SmbusLib, it is because >S3SaveStateDxe.inf link S3BootScriptLib(I guess you are using >DxeS3BootScriptLib.inf in MdeModulePkg) and S3BootScriptLib link SmbusLib. > >You may could check the PCD usage in your SmbusLib instance. > >Thanks, >Star >From: 王晓峰 [mailto:winggundu...@163.com] >Sent: Thursday, January 21, 2016 5:40 PM >To: edk2-de...@ml01.01.org >Cc: Zeng, Star >Subject: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it >a bug? > >Hi All, >I meet a issue that there is a get PCD assert for S3SaveStateDxe.inf. It > is strange that I seached all the library and their child library in > S3SaveStateDxe.inf , no PCD found related to this issue > >[LibraryClasses] > UefiBootServicesTableLib > MemoryAllocationLib > UefiDriverEntryPoint > BaseMemoryLib > BaseLib > S3BootScriptLib > > Then I found in InternalS3SaveState.h, It directly include SmbusLib > #include > > I am not sure whether it is a bug that SmbusLib should also be in > S3SaveStateDxe.inf . But after I change SmbusLib instance to Null the PCD > issue is solved. It seems build tool for PCD cannot caclulate the PCD > introduced by such way. > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?
Hi All, I meet a issue that there is a get PCD assert for S3SaveStateDxe.inf. It is strange that I seached all the library and their child library in S3SaveStateDxe.inf , no PCD found related to this issue [LibraryClasses] UefiBootServicesTableLib MemoryAllocationLib UefiDriverEntryPoint BaseMemoryLib BaseLib S3BootScriptLib Then I found in InternalS3SaveState.h, It directly include SmbusLib #include I am not sure whether it is a bug that SmbusLib should also be in S3SaveStateDxe.inf . But after I change SmbusLib instance to Null the PCD issue is solved. It seems build tool for PCD cannot caclulate the PCD introduced by such way. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?
Star， Thanks for explanation At 2016-01-22 08:49:08, "Zeng, Star" <star.z...@intel.com> wrote: >Oh, yes, you are right. BootScriptWriteSmbusExecute will use definitions from >Smbus.h and SmbusLib.h, So we could not remove them from >InternalS3SaveState.h. But no SmbusLib interface will be consumed by >S3SaveStateDxe directly, so SmbusLib is not listed in S3SaveStateDxe.inf, that >is expected. > >Thanks, >Star >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 王晓峰 >Sent: Thursday, January 21, 2016 7:48 PM >To: Zeng, Star >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is >it a bug? > >HI Star, > I tried to remove SmbusLib.h from InternalS3SaveState.h., there will be > build errors.Smbus related logic exists in S3SaveState.c > > > > > > > > >At 2016-01-21 18:09:41, "Zeng, Star" <star.z...@intel.com> wrote: >>It is just to include header file, I believe it could be removed from >>InternalS3SaveState.h. >>What libraries a driver will link is not determined by source files, but inf >>file ( S3SaveStateDxe.inf)? >> >>Why does S3SaveStateDxe.inf finally link SmbusLib, it is because >>S3SaveStateDxe.inf link S3BootScriptLib(I guess you are using >>DxeS3BootScriptLib.inf in MdeModulePkg) and S3BootScriptLib link SmbusLib. >> >>You may could check the PCD usage in your SmbusLib instance. >> >>Thanks, >>Star >>From: 王晓峰 [mailto:winggundu...@163.com] >>Sent: Thursday, January 21, 2016 5:40 PM >>To: edk2-de...@ml01.01.org >>Cc: Zeng, Star >>Subject: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it >>a bug? >> >>Hi All, >>I meet a issue that there is a get PCD assert for S3SaveStateDxe.inf. It >> is strange that I seached all the library and their child library in >> S3SaveStateDxe.inf , no PCD found related to this issue >> >>[LibraryClasses] >> UefiBootServicesTableLib >> MemoryAllocationLib >> UefiDriverEntryPoint >> BaseMemoryLib >> BaseLib >> S3BootScriptLib >> >> Then I found in InternalS3SaveState.h, It directly include SmbusLib >> #include >> >> I am not sure whether it is a bug that SmbusLib should also be in >> S3SaveStateDxe.inf . But after I change SmbusLib instance to Null the PCD >> issue is solved. It seems build tool for PCD cannot caclulate the PCD >> introduced by such way. >> >> >___ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] GenFds error to build SMM file in fdf
Hi All,
I tried to build a FFS in fdf with the following statement
FILE DXE_SMM_DRIVER = guid{
SECTION SMM_DEPEX = 1.depex
SECTION PE32 =1.efi
SECTION UI = "1"
}
and build tool return the following error ,anyone knows how to solve it? Is it
a build tool bug?
GenFds...
: error C0DE: Tools code failure
Please send email to edk2-de...@lists.sourceforge.net for help, attachin
g following call stack trace!
Traceback (most recent call last):
File "GenFds.py", line 281, in main
File "GenFds.py", line 396, in GenFd
File "Fd.py", line 93, in GenFd
File "Region.py", line 107, in AddToBuffer
File "Fv.py", line 115, in AddToBuffer
File "FfsFileStatement.py", line 117, in GenFfs
File "GuidSection.py", line 96, in GenSection
File "FvImageSection.py", line 76, in GenSection
File "Fv.py", line 115, in AddToBuffer
File "FfsFileStatement.py", line 133, in GenFfs
File "GenFdsGlobalVariable.py", line 447, in GenerateFfs
TypeError: sequence item 2: expected string, NoneType found
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] Do Edk2 support Secure Hash Algorithm-3 (SHA-3) Standard?
Dear All, NIST released SHA-3 Standard this year, http://www.nist.gov/manuscript-publication-search.cfm?pub_id=919061 Do edk2 plant to support this new algorithm or it has already been done? Thanks in advance ! ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] Why I get assert in PCD\Dxe\Service.c
Dear PCD module owner, I have meet an assert in PCDDXE UDK2014 revision. The Assert happens when PCDdxe initlize. ASSERT e:\code\MdeModulePkg\Universal\PCD\Dxe\Service.c(1137): TokenNumber + 1 < mPcdTotalTokenCount + 1 it seems that build tool automatically generate PEI and DXE token number account , but what's the algorithm for this mPcdTotalTokenCount ? Which part should I check that may be wrong? ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] How Can I add Section VERSION in fdf file?
Thanks Liming
At 2015-08-06 14:51:28, Gao, Liming liming@intel.com wrote:
This is a bug in BaseTools. We will root cause it and provide the patch.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fish
Sent: Thursday, August 06, 2015 1:58 PM
To: 王晓峰
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] How Can I add Section VERSION in fdf file?
On Aug 5, 2015, at 10:17 PM, 王晓峰 winggundu...@163.com wrote:
Hello Every EDK2 developer,
I meet an error when I tried to add section VERSION in fdf file . Please
refer to the following code I written in fdf. Without VERSION section ,the
build can pass. With VERSION section ,the build fails with GenerateSection
Python. However, I checked latest fdf spec , the fdf spec have similar
gramer. So do anyone ever able to add VERSION in fdf file? or it is never
tested before?
Thanks in advance!
FILE PEIM = A55EF9B1-400B-4E06-895E-449F43BAA450 {
SECTION PEI_DEPEX = TestPeim.depex
SECTION PE32 =TestPeim.efi
SECTION UI = TestPeim
SECTION VERSION = TestR062
}
Looks like a bug in the tools. I can make them crash too.
Can you use the standard syntax: INF Path/To/YourDriver.inf
Thanks,
Andrew Fish
Traceback (most recent call last):
File GenFds.py, line 276, in main
File GenFds.py, line 391, in GenFd
File Fd.py, line 93, in GenFd
File Region.py, line 106, in AddToBuffer
File Fv.py, line 114, in AddToBuffer
File FfsFileStatement.py, line 117, in GenFfs
File VerSection.py, line 80, in GenSection
File GenFdsGlobalVariable.py, line 401, in GenerateSection
TypeError: 'NoneType' object is not iterable
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
