Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in IndustryStandard/Smbios.h

2016-07-28 Thread Mudusuru, Giri P 
Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> 

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Wednesday, July 27, 2016 10:11 PM
> To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.t...@intel.com>; Chan, Amy <amy.c...@intel.com>;
> Dong, Eric <eric.d...@intel.com>
> Subject: Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in
> IndustryStandard/Smbios.h
> 
> 
> 
> Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>
> > -Original Message-
> > From: Zeng, Star
> > Sent: Thursday, July 28, 2016 11:04 AM
> > To: edk2-devel@lists.01.org
> > Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Dong,
> > Eric <eric.d...@intel.com>; Tian, Feng <feng.t...@intel.com>; Chan, Amy
> > <amy.c...@intel.com>
> > Subject: [PATCH 2/3] MdeModulePkg UiApp: Use definition in
> > IndustryStandard/Smbios.h
> >
> > Cc: Ruiyu Ni <ruiyu...@intel.com>
> > Cc: Eric Dong <eric.d...@intel.com>
> > Cc: Feng Tian <feng.t...@intel.com>
> > Cc: Amy Chan <amy.c...@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Star Zeng <star.z...@intel.com>
> > ---
> >  MdeModulePkg/Application/UiApp/FrontPage.c | 8 
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> > b/MdeModulePkg/Application/UiApp/FrontPage.c
> > index aef0e79124de..bda5ff9231b9 100644
> > --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> > @@ -579,7 +579,7 @@ UpdateFrontPageBannerStrings (
> >SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
> >Status = Smbios->GetNext (Smbios, , NULL, , NULL);
> >while (!EFI_ERROR(Status)) {
> > -if (Record->Type == EFI_SMBIOS_TYPE_BIOS_INFORMATION) {
> > +if (Record->Type == SMBIOS_TYPE_BIOS_INFORMATION) {
> >Type0Record = (SMBIOS_TABLE_TYPE0 *) Record;
> >StrIndex = Type0Record->BiosVersion;
> >GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type0Record +
> > Type0Record->Hdr.Length), StrIndex, ); @@ -597,7 +597,7 @@
> > UpdateFrontPageBannerStrings (
> >}
> >  }
> >
> > -if (Record->Type == EFI_SMBIOS_TYPE_SYSTEM_INFORMATION) {
> > +if (Record->Type == SMBIOS_TYPE_SYSTEM_INFORMATION) {
> >Type1Record = (SMBIOS_TABLE_TYPE1 *) Record;
> >StrIndex = Type1Record->ProductName;
> >GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type1Record +
> > Type1Record->Hdr.Length), StrIndex, ); @@ -606,7 +606,7 @@
> > UpdateFrontPageBannerStrings (
> >FreePool (NewString);
> >  }
> >
> > -if ((Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION)
> > && !FoundCpu) {
> > +if ((Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) &&
> > + !FoundCpu) {
> >Type4Record = (SMBIOS_TABLE_TYPE4 *) Record;
> >//
> >// The information in the record should be only valid when the CPU
> > Socket is populated.
> > @@ -627,7 +627,7 @@ UpdateFrontPageBannerStrings (
> >}
> >  }
> >
> > -if ( Record->Type ==
> > EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
> > +if ( Record->Type ==
> > SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
> >Type19Record = (SMBIOS_TABLE_TYPE19 *) Record;
> >if (Type19Record->StartingAddress != 0x ) {
> >  InstalledMemory += RShiftU64(Type19Record->EndingAddress -
> > --
> > 2.7.0.windows.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in IndustryStandard/Smbios.h

2016-07-27 Thread Ni, Ruiyu 


Reviewed-by: Ruiyu Ni 
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, July 28, 2016 11:04 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Dong,
> Eric ; Tian, Feng ; Chan, Amy
> 
> Subject: [PATCH 2/3] MdeModulePkg UiApp: Use definition in
> IndustryStandard/Smbios.h
> 
> Cc: Ruiyu Ni 
> Cc: Eric Dong 
> Cc: Feng Tian 
> Cc: Amy Chan 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng 
> ---
>  MdeModulePkg/Application/UiApp/FrontPage.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> b/MdeModulePkg/Application/UiApp/FrontPage.c
> index aef0e79124de..bda5ff9231b9 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> @@ -579,7 +579,7 @@ UpdateFrontPageBannerStrings (
>SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
>Status = Smbios->GetNext (Smbios, , NULL, , NULL);
>while (!EFI_ERROR(Status)) {
> -if (Record->Type == EFI_SMBIOS_TYPE_BIOS_INFORMATION) {
> +if (Record->Type == SMBIOS_TYPE_BIOS_INFORMATION) {
>Type0Record = (SMBIOS_TABLE_TYPE0 *) Record;
>StrIndex = Type0Record->BiosVersion;
>GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type0Record +
> Type0Record->Hdr.Length), StrIndex, ); @@ -597,7 +597,7 @@
> UpdateFrontPageBannerStrings (
>}
>  }
> 
> -if (Record->Type == EFI_SMBIOS_TYPE_SYSTEM_INFORMATION) {
> +if (Record->Type == SMBIOS_TYPE_SYSTEM_INFORMATION) {
>Type1Record = (SMBIOS_TABLE_TYPE1 *) Record;
>StrIndex = Type1Record->ProductName;
>GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type1Record +
> Type1Record->Hdr.Length), StrIndex, ); @@ -606,7 +606,7 @@
> UpdateFrontPageBannerStrings (
>FreePool (NewString);
>  }
> 
> -if ((Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION)
> && !FoundCpu) {
> +if ((Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) &&
> + !FoundCpu) {
>Type4Record = (SMBIOS_TABLE_TYPE4 *) Record;
>//
>// The information in the record should be only valid when the CPU
> Socket is populated.
> @@ -627,7 +627,7 @@ UpdateFrontPageBannerStrings (
>}
>  }
> 
> -if ( Record->Type ==
> EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
> +if ( Record->Type ==
> SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
>Type19Record = (SMBIOS_TABLE_TYPE19 *) Record;
>if (Type19Record->StartingAddress != 0x ) {
>  InstalledMemory += RShiftU64(Type19Record->EndingAddress -
> --
> 2.7.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in IndustryStandard/Smbios.h

2016-07-27 Thread Star Zeng 
Cc: Ruiyu Ni 
Cc: Eric Dong 
Cc: Feng Tian 
Cc: Amy Chan 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng 
---
 MdeModulePkg/Application/UiApp/FrontPage.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c 
b/MdeModulePkg/Application/UiApp/FrontPage.c
index aef0e79124de..bda5ff9231b9 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -579,7 +579,7 @@ UpdateFrontPageBannerStrings (
   SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
   Status = Smbios->GetNext (Smbios, , NULL, , NULL);
   while (!EFI_ERROR(Status)) {
-if (Record->Type == EFI_SMBIOS_TYPE_BIOS_INFORMATION) {
+if (Record->Type == SMBIOS_TYPE_BIOS_INFORMATION) {
   Type0Record = (SMBIOS_TABLE_TYPE0 *) Record;
   StrIndex = Type0Record->BiosVersion;
   GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type0Record + 
Type0Record->Hdr.Length), StrIndex, );
@@ -597,7 +597,7 @@ UpdateFrontPageBannerStrings (
   }
 }
 
-if (Record->Type == EFI_SMBIOS_TYPE_SYSTEM_INFORMATION) {
+if (Record->Type == SMBIOS_TYPE_SYSTEM_INFORMATION) {
   Type1Record = (SMBIOS_TABLE_TYPE1 *) Record;
   StrIndex = Type1Record->ProductName;
   GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type1Record + 
Type1Record->Hdr.Length), StrIndex, );
@@ -606,7 +606,7 @@ UpdateFrontPageBannerStrings (
   FreePool (NewString);
 }
 
-if ((Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION) && !FoundCpu) {
+if ((Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) && !FoundCpu) {
   Type4Record = (SMBIOS_TABLE_TYPE4 *) Record;
   //
   // The information in the record should be only valid when the CPU 
Socket is populated.
@@ -627,7 +627,7 @@ UpdateFrontPageBannerStrings (
   }
 }
 
-if ( Record->Type == EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
+if ( Record->Type == SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) {
   Type19Record = (SMBIOS_TABLE_TYPE19 *) Record;
   if (Type19Record->StartingAddress != 0x ) {
 InstalledMemory += RShiftU64(Type19Record->EndingAddress -
-- 
2.7.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel