Re: [edk2] [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, December 14, 2018 1:54 AM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: Re: [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove
> the unused function CharToUpper
> Importance: High
>
> On 12/14/18 08:56, Shenglei Zhang wrote:
> > CharToUpper is an unused function, so it will be removed.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1399
> >
> > v2:Update the title.
> >
> > Cc: Laszlo Ersek
> > Cc: Jaben Carsey
> > Cc: Ruiyu Ni
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang
> > ---
> > .../UefiShellDebug1CommandsLib.c | 28 ---
> > 1 file changed, 28 deletions(-)
> >
> > diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> > index bd4dfa98f7..480441b0f9 100644
> > ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> > +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> > @@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor (
> >return (EFI_SUCCESS);
> > }
> >
> > -/**
> > - Convert a Unicode character to upper case only if
> > - it maps to a valid small-case ASCII character.
> > -
> > - This internal function only deal with Unicode character
> > - which maps to a valid small-case ASCII character, i.e.
> > - L'a' to L'z'. For other Unicode character, the input character
> > - is returned directly.
> > -
> > - @param Char The character to convert.
> > -
> > - @retval LowerCharacter If the Char is with range L'a' to L'z'.
> > - @retval UnchangedOtherwise.
> > -
> > -
> > - //Stolen from MdePkg Baselib
> > -**/
> > -CHAR16
> > -CharToUpper (
> > - IN CHAR16Char
> > - )
> > -{
> > - if (Char >= L'a' && Char <= L'z') {
> > -return (CHAR16) (Char - (L'a' - L'A'));
> > - }
> > -
> > - return Char;
> > -}
> >
> > /**
> >Function returns a system configuration table that is stored in the
> >
>
> Reviewed-by: Laszlo Ersek
>
> Thanks!
> Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper
On 12/14/18 08:56, Shenglei Zhang wrote:
> CharToUpper is an unused function, so it will be removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1399
>
> v2:Update the title.
>
> Cc: Laszlo Ersek
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang
> ---
> .../UefiShellDebug1CommandsLib.c | 28 ---
> 1 file changed, 28 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
> index bd4dfa98f7..480441b0f9 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
> @@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor (
>return (EFI_SUCCESS);
> }
>
> -/**
> - Convert a Unicode character to upper case only if
> - it maps to a valid small-case ASCII character.
> -
> - This internal function only deal with Unicode character
> - which maps to a valid small-case ASCII character, i.e.
> - L'a' to L'z'. For other Unicode character, the input character
> - is returned directly.
> -
> - @param Char The character to convert.
> -
> - @retval LowerCharacter If the Char is with range L'a' to L'z'.
> - @retval UnchangedOtherwise.
> -
> -
> - //Stolen from MdePkg Baselib
> -**/
> -CHAR16
> -CharToUpper (
> - IN CHAR16Char
> - )
> -{
> - if (Char >= L'a' && Char <= L'z') {
> -return (CHAR16) (Char - (L'a' - L'A'));
> - }
> -
> - return Char;
> -}
>
> /**
>Function returns a system configuration table that is stored in the
>
Reviewed-by: Laszlo Ersek
Thanks!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper
CharToUpper is an unused function, so it will be removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1399
v2:Update the title.
Cc: Laszlo Ersek
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../UefiShellDebug1CommandsLib.c | 28 ---
1 file changed, 28 deletions(-)
diff --git
a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
index bd4dfa98f7..480441b0f9 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
@@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor (
return (EFI_SUCCESS);
}
-/**
- Convert a Unicode character to upper case only if
- it maps to a valid small-case ASCII character.
-
- This internal function only deal with Unicode character
- which maps to a valid small-case ASCII character, i.e.
- L'a' to L'z'. For other Unicode character, the input character
- is returned directly.
-
- @param Char The character to convert.
-
- @retval LowerCharacter If the Char is with range L'a' to L'z'.
- @retval UnchangedOtherwise.
-
-
- //Stolen from MdePkg Baselib
-**/
-CHAR16
-CharToUpper (
- IN CHAR16Char
- )
-{
- if (Char >= L'a' && Char <= L'z') {
-return (CHAR16) (Char - (L'a' - L'A'));
- }
-
- return Char;
-}
/**
Function returns a system configuration table that is stored in the
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
