Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-26 Thread Laszlo Ersek 
On 03/25/19 21:02, Kinney, Michael D wrote:
> Hi Laszlo,
> 
> The review of the content based on the edk2-stable201903
> is intended to make sure there are no mistakes on that
> content so I can adjust for the final patch series.  A
> mistake would be applying new license to files that should
> not be updated, or not applying the license to a file that
> should have been updated.  You provided valuable feedback
> on those two points for OvmfPkg in V1.
> 
> I agree it will be simpler if we can guarantee no file
> add/remove commits occur in a window leading up to 
> April 9, 2019.  So it is not a freeze on all content.
> It would be a freeze on commits that add/remove files.

Good point.

> How does a ~1 week of no commits of file add/remove
> starting April 1 sound?  I can produce a V3 on April 2
> for final review by all package maintainers.

That sounds great. I'd be happy to iterate multiple times during that
freeze, if necessary (so v3 wouldn't have to be the final version even);
what matters is that the reviews should converge.

Thus, considering actions on my end regarding the v2 posting, I'll delay
reviewing v2 (or v3 if you post v3 meanwhile) until April 2.

I'm making a note in my calendar, but please do ping me on April 2 --
I'm the one requesting this freeze, so once it starts, I should be as
responsive as possible.

> I would of course rebase the patch series on April 9 and
> also verify that no files were added/removed.

Thank you!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Wu, Hao A 
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Monday, March 25, 2019 7:22 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Justen, Jordan L
> Subject: Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver
> 
> On 03/25/19 06:28, Hao Wu wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1495
> >
> > There is a plan to remove the IntelFrameworkModulePkg:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1605
> >
> > This patch will a new OVMF Super I/O bus driver which will create the
> > below child devices:
> >
> > * COM 1 UART
> > * COM 2 UART
> > * PS/2 Keyboard
> >
> > and installs the Super I/O Protocol on them.
> >
> > Cc: Jordan Justen 
> > Cc: Laszlo Ersek 
> > Cc: Ard Biesheuvel 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu 
> > ---
> >  OvmfPkg/OvmfPkgIa32.dsc   |   1 +
> >  OvmfPkg/OvmfPkgIa32X64.dsc|   1 +
> >  OvmfPkg/OvmfPkgX64.dsc|   1 +
> >  OvmfPkg/SioBusDxe/SioBusDxe.inf   |  54 ++
> >  OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++
> >  OvmfPkg/SioBusDxe/SioService.h| 221 +++
> >  OvmfPkg/SioBusDxe/ComponentName.c | 167 ++
> >  OvmfPkg/SioBusDxe/SioBusDxe.c | 622 
> >  OvmfPkg/SioBusDxe/SioService.c| 405 +
> >  OvmfPkg/SioBusDxe/SioBusDxe.uni   |  21 +
> >  10 files changed, 1825 insertions(+)
> 
> Acked-by: Laszlo Ersek 
> 
> but please don't push the series before answering my questions under 0/3.

Thanks Laszlo,

I have replied your comments under patch 0/3.

I will wait for your approval, since I saw there is an open with regard
to the file license header for the new files.

Best Regards,
Hao Wu

> 
> Thanks!
> Laszlo
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Kinney, Michael D 
Hi Laszlo,

The review of the content based on the edk2-stable201903
is intended to make sure there are no mistakes on that
content so I can adjust for the final patch series.  A
mistake would be applying new license to files that should
not be updated, or not applying the license to a file that
should have been updated.  You provided valuable feedback
on those two points for OvmfPkg in V1.

I agree it will be simpler if we can guarantee no file
add/remove commits occur in a window leading up to 
April 9, 2019.  So it is not a freeze on all content.
It would be a freeze on commits that add/remove files.

How does a ~1 week of no commits of file add/remove
starting April 1 sound?  I can produce a V3 on April 2
for final review by all package maintainers.

I would of course rebase the patch series on April 9 and
also verify that no files were added/removed.

Thanks,

Mike

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, March 25, 2019 11:33 AM
> To: Kinney, Michael D ; Wu,
> Hao A ; edk2-devel@lists.01.org
> Cc: Justen, Jordan L ; Ard
> Biesheuvel ; Ni, Ray
> 
> Subject: Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus
> driver
> 
> On 03/25/19 18:30, Kinney, Michael D wrote:
> > Hi Laszlo,
> >
> > I do not think content added before April 9, 2019
> > should use the new license type.  We need to let the
> > 30-day review period complete and make sure all
> feedback
> > is resolved.
> 
> Good point.
> 
> > We will handle files added between the edk2-
> stable201903
> > and April 9, 2019 in a final patch series with an easy
> > way for all maintainers to see what has changed
> between
> > those two points.
> 
> Hm. From the reviewer side, this is not optimal. The
> patch set (and the
> individual patches themselves) are pretty big, and doing
> incremental
> reviews on them is taxing. Regardless of whether the
> incremental review
> needs to target an updated "full" patch set, or just an
> incremental
> patch set (for new files), the reviewer needs to re-
> evaluate whether
> something is now missed, after the introduction of new
> files.
> 
> Instead, I'd prefer a "lock" period for OvmfPkg and
> ArmVirtPkg, between
> (a) my next (hopefully, final) review for the license
> conversion
> patches, and (b) the pushing of those patches. For that,
> I see two options:
> 
> - We could delay Hao's work (and all other patches that
> add files to
> OvmfPkg and ArmVirtPkg files) until after April 9. We
> can of course
> collaborate on feature / bugfix patches meanwhile, it's
> just that the
> final versions of *those* should be reposted with
> updated license
> blocks. Incrementally reviewing *those* changes feels a
> lot easier to me.
> 
> - Alternatively, I could delay my next (hopefully,
> final) review of the
> license conversion patches until reasonably close to
> April 9, until
> which "review point" new files could be added freely, to
> OvmfPkg and
> ArmVirtPkg. (This wouldn't eliminate the "lock period",
> just make it
> shorter for contributors.)
> 
> IOW, this is similar to the stabilization period /
> feature freezes, just
> much more intrusive, because everything has to be
> switched at the same
> moment.
> 
> I'd like to reach an understanding on our approach
> before I start
> reviewing "[edk2] [PATCH V2] Change EDK II to BSD+Patent
> License".
> 
> Thanks
> Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek 
On 03/25/19 18:30, Kinney, Michael D wrote:
> Hi Laszlo,
> 
> I do not think content added before April 9, 2019
> should use the new license type.  We need to let the
> 30-day review period complete and make sure all feedback
> is resolved.

Good point.

> We will handle files added between the edk2-stable201903
> and April 9, 2019 in a final patch series with an easy
> way for all maintainers to see what has changed between
> those two points.

Hm. From the reviewer side, this is not optimal. The patch set (and the
individual patches themselves) are pretty big, and doing incremental
reviews on them is taxing. Regardless of whether the incremental review
needs to target an updated "full" patch set, or just an incremental
patch set (for new files), the reviewer needs to re-evaluate whether
something is now missed, after the introduction of new files.

Instead, I'd prefer a "lock" period for OvmfPkg and ArmVirtPkg, between
(a) my next (hopefully, final) review for the license conversion
patches, and (b) the pushing of those patches. For that, I see two options:

- We could delay Hao's work (and all other patches that add files to
OvmfPkg and ArmVirtPkg files) until after April 9. We can of course
collaborate on feature / bugfix patches meanwhile, it's just that the
final versions of *those* should be reposted with updated license
blocks. Incrementally reviewing *those* changes feels a lot easier to me.

- Alternatively, I could delay my next (hopefully, final) review of the
license conversion patches until reasonably close to April 9, until
which "review point" new files could be added freely, to OvmfPkg and
ArmVirtPkg. (This wouldn't eliminate the "lock period", just make it
shorter for contributors.)

IOW, this is similar to the stabilization period / feature freezes, just
much more intrusive, because everything has to be switched at the same
moment.

I'd like to reach an understanding on our approach before I start
reviewing "[edk2] [PATCH V2] Change EDK II to BSD+Patent License".

Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Kinney, Michael D 
Hi Laszlo,

I do not think content added before April 9, 2019
should use the new license type.  We need to let the
30-day review period complete and make sure all feedback
is resolved.

We will handle files added between the edk2-stable201903
and April 9, 2019 in a final patch series with an easy
way for all maintainers to see what has changed between
those two points.

Thanks,

Mike

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, March 25, 2019 5:00 AM
> To: Wu, Hao A ; edk2-
> de...@lists.01.org
> Cc: Justen, Jordan L ; Ard
> Biesheuvel ; Ni, Ray
> ; Kinney, Michael D
> 
> Subject: Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus
> driver
> 
> Hello Hao,
> 
> (+Mike)
> 
> my apologies that I seem unable to collect my thoughts
> in one go... So
> here's another comment:
> 
> On 03/25/19 06:28, Hao Wu wrote:
> 
> > diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf
> b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> > new file mode 100644
> > index 00..5c462f1a8c
> > --- /dev/null
> > +++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> > @@ -0,0 +1,54 @@
> > +## @file
> > +#  The SioBusDxe driver is used to create child
> devices on the ISA bus and
> > +#  installs the Super I/O protocols on them.
> > +#
> > +#  Copyright (c) 2019, Intel Corporation. All rights
> reserved.
> > +#
> > +#  This program and the accompanying materials
> > +#  are licensed and made available under the terms
> and conditions of the BSD License
> > +#  which accompanies this distribution.  The full
> text of the license may be found at
> > +#  http://opensource.org/licenses/bsd-license.php
> > +#
> > +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE
> ON AN "AS IS" BASIS,
> > +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,
> EITHER EXPRESS OR IMPLIED.
> > +#
> > +##
> 
> [...]
> 
> This patch adds 7 new instances of the 2-clause BSDL (in
> expanded form)
> to the edk2 tree. In that it conflicts with Mike's work
> for
> .
> Can you please
> rework this patch so that the new files say
> 
>   SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> instead?
> 
> Thanks,
> Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek 
Hello Hao,

(+Mike)

my apologies that I seem unable to collect my thoughts in one go... So
here's another comment:

On 03/25/19 06:28, Hao Wu wrote:

> diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> new file mode 100644
> index 00..5c462f1a8c
> --- /dev/null
> +++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> @@ -0,0 +1,54 @@
> +## @file
> +#  The SioBusDxe driver is used to create child devices on the ISA bus and
> +#  installs the Super I/O protocols on them.
> +#
> +#  Copyright (c) 2019, Intel Corporation. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD 
> License
> +#  which accompanies this distribution.  The full text of the license may be 
> found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
> IMPLIED.
> +#
> +##

[...]

This patch adds 7 new instances of the 2-clause BSDL (in expanded form)
to the edk2 tree. In that it conflicts with Mike's work for
. Can you please
rework this patch so that the new files say

  SPDX-License-Identifier: BSD-2-Clause-Patent

instead?

Thanks,
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek 
On 03/25/19 06:28, Hao Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1495
> 
> There is a plan to remove the IntelFrameworkModulePkg:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1605
> 
> This patch will a new OVMF Super I/O bus driver which will create the
> below child devices:
> 
> * COM 1 UART
> * COM 2 UART
> * PS/2 Keyboard
> 
> and installs the Super I/O Protocol on them.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Cc: Ray Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu 
> ---
>  OvmfPkg/OvmfPkgIa32.dsc   |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc|   1 +
>  OvmfPkg/OvmfPkgX64.dsc|   1 +
>  OvmfPkg/SioBusDxe/SioBusDxe.inf   |  54 ++
>  OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++
>  OvmfPkg/SioBusDxe/SioService.h| 221 +++
>  OvmfPkg/SioBusDxe/ComponentName.c | 167 ++
>  OvmfPkg/SioBusDxe/SioBusDxe.c | 622 
>  OvmfPkg/SioBusDxe/SioService.c| 405 +
>  OvmfPkg/SioBusDxe/SioBusDxe.uni   |  21 +
>  10 files changed, 1825 insertions(+)

Acked-by: Laszlo Ersek 

but please don't push the series before answering my questions under 0/3.

Thanks!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-24 Thread Hao Wu 
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1495

There is a plan to remove the IntelFrameworkModulePkg:
https://bugzilla.tianocore.org/show_bug.cgi?id=1605

This patch will a new OVMF Super I/O bus driver which will create the
below child devices:

* COM 1 UART
* COM 2 UART
* PS/2 Keyboard

and installs the Super I/O Protocol on them.

Cc: Jordan Justen 
Cc: Laszlo Ersek 
Cc: Ard Biesheuvel 
Cc: Ray Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 OvmfPkg/OvmfPkgIa32.dsc   |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc|   1 +
 OvmfPkg/OvmfPkgX64.dsc|   1 +
 OvmfPkg/SioBusDxe/SioBusDxe.inf   |  54 ++
 OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++
 OvmfPkg/SioBusDxe/SioService.h| 221 +++
 OvmfPkg/SioBusDxe/ComponentName.c | 167 ++
 OvmfPkg/SioBusDxe/SioBusDxe.c | 622 
 OvmfPkg/SioBusDxe/SioService.c| 405 +
 OvmfPkg/SioBusDxe/SioBusDxe.uni   |  21 +
 10 files changed, 1825 insertions(+)

diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 1710ab5a88..3be0314146 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -752,6 +752,7 @@
   #
   # ISA Support
   #
+  OvmfPkg/SioBusDxe/SioBusDxe.inf
   PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/IsaSerialDxe.inf
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 5bceef3116..3b85c2e6af 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -761,6 +761,7 @@
   #
   # ISA Support
   #
+  OvmfPkg/SioBusDxe/SioBusDxe.inf
   PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/IsaSerialDxe.inf
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 3f5d948dbb..104b2e79a5 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -759,6 +759,7 @@
   #
   # ISA Support
   #
+  OvmfPkg/SioBusDxe/SioBusDxe.inf
   PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.inf
   IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/IsaSerialDxe.inf
diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf b/OvmfPkg/SioBusDxe/SioBusDxe.inf
new file mode 100644
index 00..5c462f1a8c
--- /dev/null
+++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf
@@ -0,0 +1,54 @@
+## @file
+#  The SioBusDxe driver is used to create child devices on the ISA bus and
+#  installs the Super I/O protocols on them.
+#
+#  Copyright (c) 2019, Intel Corporation. All rights reserved.
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD 
License
+#  which accompanies this distribution.  The full text of the license may be 
found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
+#
+##
+
+[Defines]
+  INF_VERSION= 0x00010005
+  BASE_NAME  = SioBusDxe
+  MODULE_UNI_FILE= SioBusDxe.uni
+  FILE_GUID  = 864E1CA8-85EB-4D63-9DCC-6E0FC90FFD55
+  MODULE_TYPE= UEFI_DRIVER
+  VERSION_STRING = 1.0
+  ENTRY_POINT= SioBusDxeDriverEntryPoint
+
+#
+# The following information is for reference only and not required by the 
build tools.
+#
+#  VALID_ARCHITECTURES   = IA32 X64 EBC
+#
+
+[Sources]
+  ComponentName.c
+  SioService.c
+  SioService.h
+  SioBusDxe.c
+  SioBusDxe.h
+
+[Packages]
+  MdePkg/MdePkg.dec
+
+[LibraryClasses]
+  UefiDriverEntryPoint
+  UefiLib
+  UefiBootServicesTableLib
+  DebugLib
+  ReportStatusCodeLib
+  MemoryAllocationLib
+  BaseMemoryLib
+  DevicePathLib
+
+[Protocols]
+  gEfiPciIoProtocolGuid## TO_START
+  gEfiSioProtocolGuid  ## BY_START
diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.h b/OvmfPkg/SioBusDxe/SioBusDxe.h
new file mode 100644
index 00..1455c48f63
--- /dev/null
+++ b/OvmfPkg/SioBusDxe/SioBusDxe.h
@@ -0,0 +1,332 @@
+/** @file
+  The SioBusDxe driver is used to create child devices on the ISA bus and
+  installs the Super I/O protocols on them.
+
+  Copyright (c) 2019, Intel Corporation. All rights reserved.
+
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions
+  of the BSD License which accompanies this distribution.  The
+  full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __SIO_BUS_DXE_H__
+#define __SIO_BUS_DXE_H__
+
+#include 
+
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#includ