Re: [edk2] github development process
Thank you! This is much better... -Original Message- From: Bjorge, Erik C [mailto:erik.c.bjo...@intel.com] Sent: Thursday, February 11, 2016 7:14 PM To: Bjorge, Erik C <erik.c.bjo...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Subject: RE: github development process Jordan and I have updated the EDK II Development Process page. Please check and see if this clears up some of the issues. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Thanks, -Erik > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Bjorge, Erik C > Sent: Thursday, February 11, 2016 10:23 AM > To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] github development process > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > Of El-Haj-Mahmoud, Samer > > Sent: Wednesday, February 10, 2016 4:03 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] github development process > > > > So I have been itching to submit patches after the transition to > github, > > when I stumbled across this. It looks like the development process > > described in: > https://github.com/tianocore/tianocore.github.io/wiki/EDK- > > II-Development-Process , does not match the process described in: > > > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contrib > ut > > ions.txt > > > > I followed the process in the wiki, and ended up creating a pull > request > > for tiancore/edk for my contribution > > (https://github.com/tianocore/edk2/pull/55). I was also going to > > send > a > > patch to EDK2 list (as the wiki suggests). Then I quickly realized > that > > the maintainers are still working only with e-mail patches, and not > pull > > requests, as clear from the conversations in closed/rejected pull > > requests: > > > > https://github.com/tianocore/edk2/pull/45 > > https://github.com/tianocore/edk2/pull/51 > > https://github.com/tianocore/edk2/pull/41 > > etc.. > > > > > > I have no problem of sticking with the edk2-devel e-mail patches > > like > we > > have been doing (all of my team from HPE contributes that way). But > > if that is the only/proper way to submit contributions, then the > > wiki > need > > to be updated to drop the pull requests steps. > > I will update the Wiki as you suggest. We were hoping to allow for at > least some form of pull request but it looks like we are not quite > ready for that yet. > > Thanks, > -Erik > > > > > Thanks, > > --Samer > > > > > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] github development process
Justen, Yes I see now that there is duplicate between: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process and https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to-Github-Quick-Start And yes, step "7. Update the master branch (pull or fetch/merge" is what triggered me to create a pull request (that, and my incorrect assumption that we are using github for development process, not just to host the pull requests). Thanks, --Samer -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Wednesday, February 10, 2016 6:32 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Subject: Re: [edk2] github development process On 2016-02-10 16:03:26, El-Haj-Mahmoud, Samer wrote: > So I have been itching to submit patches after the transition to > github, when I stumbled across this. It looks like the development > process described in: > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developme > nt-Process , does not match the process described in: > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contrib > utions.txt > There seems to be duplicated content on https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to-Github-Quick-Start And, I think the EDK-II-Development-Process version was a little older. I updated it to match the other one. Before and after, I only saw one mention of 'pull': "7. Update the master branch (pull or fetch/merge)" Is this what caused the confusion? Or, was there something else that generated a pull request? -Jordan > I followed the process in the wiki, and ended up creating a pull > request for tiancore/edk for my contribution > (https://github.com/tianocore/edk2/pull/55). I was also going to send > a patch to EDK2 list (as the wiki suggests). Then I quickly realized > that the maintainers are still working only with e-mail patches, and > not pull requests, as clear from the conversations in closed/rejected > pull requests: > > https://github.com/tianocore/edk2/pull/45 > https://github.com/tianocore/edk2/pull/51 > https://github.com/tianocore/edk2/pull/41 > etc.. > > > I have no problem of sticking with the edk2-devel e-mail patches like > we have been doing (all of my team from HPE contributes that way). But > if that is the only/proper way to submit contributions, then the wiki > need to be updated to drop the pull requests steps. > > Thanks, > --Samer > > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] github development process
Jordan and I have updated the EDK II Development Process page. Please check and see if this clears up some of the issues. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Thanks, -Erik > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Bjorge, Erik C > Sent: Thursday, February 11, 2016 10:23 AM > To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] github development process > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > El-Haj-Mahmoud, Samer > > Sent: Wednesday, February 10, 2016 4:03 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] github development process > > > > So I have been itching to submit patches after the transition to > github, > > when I stumbled across this. It looks like the development process > > described in: > https://github.com/tianocore/tianocore.github.io/wiki/EDK- > > II-Development-Process , does not match the process described in: > > > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contribut > > ions.txt > > > > I followed the process in the wiki, and ended up creating a pull > request > > for tiancore/edk for my contribution > > (https://github.com/tianocore/edk2/pull/55). I was also going to send > a > > patch to EDK2 list (as the wiki suggests). Then I quickly realized > that > > the maintainers are still working only with e-mail patches, and not > pull > > requests, as clear from the conversations in closed/rejected pull > > requests: > > > > https://github.com/tianocore/edk2/pull/45 > > https://github.com/tianocore/edk2/pull/51 > > https://github.com/tianocore/edk2/pull/41 > > etc.. > > > > > > I have no problem of sticking with the edk2-devel e-mail patches like > we > > have been doing (all of my team from HPE contributes that way). But if > > that is the only/proper way to submit contributions, then the wiki > need > > to be updated to drop the pull requests steps. > > I will update the Wiki as you suggest. We were hoping to allow for at > least some form of pull request but it looks like we are not quite ready > for that yet. > > Thanks, > -Erik > > > > > Thanks, > > --Samer > > > > > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] github development process
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > El-Haj-Mahmoud, Samer > Sent: Wednesday, February 10, 2016 4:03 PM > To: edk2-devel@lists.01.org > Subject: [edk2] github development process > > So I have been itching to submit patches after the transition to github, > when I stumbled across this. It looks like the development process > described in: https://github.com/tianocore/tianocore.github.io/wiki/EDK- > II-Development-Process , does not match the process described in: > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contribut > ions.txt > > I followed the process in the wiki, and ended up creating a pull request > for tiancore/edk for my contribution > (https://github.com/tianocore/edk2/pull/55). I was also going to send a > patch to EDK2 list (as the wiki suggests). Then I quickly realized that > the maintainers are still working only with e-mail patches, and not pull > requests, as clear from the conversations in closed/rejected pull > requests: > > https://github.com/tianocore/edk2/pull/45 > https://github.com/tianocore/edk2/pull/51 > https://github.com/tianocore/edk2/pull/41 > etc.. > > > I have no problem of sticking with the edk2-devel e-mail patches like we > have been doing (all of my team from HPE contributes that way). But if > that is the only/proper way to submit contributions, then the wiki need > to be updated to drop the pull requests steps. I will update the Wiki as you suggest. We were hoping to allow for at least some form of pull request but it looks like we are not quite ready for that yet. Thanks, -Erik > > Thanks, > --Samer > > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] github development process
Jordan, I think we also need to clarify step 9 as well by removing the option of sending a link and branch name of a forked repo. Thanks, -Erik > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > El-Haj-Mahmoud, Samer > Sent: Thursday, February 11, 2016 7:31 AM > To: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] github development process > > Justen, > > Yes I see now that there is duplicate between: > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > Development-Process > and > https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to- > Github-Quick-Start > > > And yes, step "7. Update the master branch (pull or fetch/merge" is what > triggered me to create a pull request (that, and my incorrect assumption > that we are using github for development process, not just to host the > pull requests). > > Thanks, > --Samer > > > > > > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Wednesday, February 10, 2016 6:32 PM > To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] github development process > > On 2016-02-10 16:03:26, El-Haj-Mahmoud, Samer wrote: > > So I have been itching to submit patches after the transition to > > github, when I stumbled across this. It looks like the development > > process described in: > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developme > > nt-Process , does not match the process described in: > > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contrib > > utions.txt > > > > There seems to be duplicated content on > > https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to- > Github-Quick-Start > > And, I think the EDK-II-Development-Process version was a little older. > I updated it to match the other one. > > Before and after, I only saw one mention of 'pull': > > "7. Update the master branch (pull or fetch/merge)" > > Is this what caused the confusion? Or, was there something else that > generated a pull request? > > -Jordan > > > I followed the process in the wiki, and ended up creating a pull > > request for tiancore/edk for my contribution > > (https://github.com/tianocore/edk2/pull/55). I was also going to send > > a patch to EDK2 list (as the wiki suggests). Then I quickly realized > > that the maintainers are still working only with e-mail patches, and > > not pull requests, as clear from the conversations in closed/rejected > > pull requests: > > > > https://github.com/tianocore/edk2/pull/45 > > https://github.com/tianocore/edk2/pull/51 > > https://github.com/tianocore/edk2/pull/41 > > etc.. > > > > > > I have no problem of sticking with the edk2-devel e-mail patches like > > we have been doing (all of my team from HPE contributes that way). But > > if that is the only/proper way to submit contributions, then the wiki > > need to be updated to drop the pull requests steps. > > > > Thanks, > > --Samer > > > > > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] github development process
On 2016-02-10 16:03:26, El-Haj-Mahmoud, Samer wrote: > So I have been itching to submit patches after the transition to > github, when I stumbled across this. It looks like the development > process described in: > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > , does not match the process described in: > https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contributions.txt > There seems to be duplicated content on https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to-Github-Quick-Start And, I think the EDK-II-Development-Process version was a little older. I updated it to match the other one. Before and after, I only saw one mention of 'pull': "7. Update the master branch (pull or fetch/merge)" Is this what caused the confusion? Or, was there something else that generated a pull request? -Jordan > I followed the process in the wiki, and ended up creating a pull > request for tiancore/edk for my contribution > (https://github.com/tianocore/edk2/pull/55). I was also going to > send a patch to EDK2 list (as the wiki suggests). Then I quickly > realized that the maintainers are still working only with e-mail > patches, and not pull requests, as clear from the conversations in > closed/rejected pull requests: > > https://github.com/tianocore/edk2/pull/45 > https://github.com/tianocore/edk2/pull/51 > https://github.com/tianocore/edk2/pull/41 > etc.. > > > I have no problem of sticking with the edk2-devel e-mail patches > like we have been doing (all of my team from HPE contributes that > way). But if that is the only/proper way to submit contributions, > then the wiki need to be updated to drop the pull requests steps. > > Thanks, > --Samer > > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] github development process
So I have been itching to submit patches after the transition to github, when I stumbled across this. It looks like the development process described in: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process , does not match the process described in: https://raw.githubusercontent.com/tianocore/edk2/master/MdePkg/Contributions.txt I followed the process in the wiki, and ended up creating a pull request for tiancore/edk for my contribution (https://github.com/tianocore/edk2/pull/55). I was also going to send a patch to EDK2 list (as the wiki suggests). Then I quickly realized that the maintainers are still working only with e-mail patches, and not pull requests, as clear from the conversations in closed/rejected pull requests: https://github.com/tianocore/edk2/pull/45 https://github.com/tianocore/edk2/pull/51 https://github.com/tianocore/edk2/pull/41 etc.. I have no problem of sticking with the edk2-devel e-mail patches like we have been doing (all of my team from HPE contributes that way). But if that is the only/proper way to submit contributions, then the wiki need to be updated to drop the pull requests steps. Thanks, --Samer ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
