Re: [edk2] [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx

2018-11-09 Thread Laszlo Ersek 
On 11/09/18 04:34, Bi, Dandan wrote:
> Hi Stewards and package maintainers:
> 
> Since this is a clear bug.  And the risk for this release is small.
> So I plan to push this patch before edk2-stable201811 tag is created.

I agree, this is a bugfix, not a feature patch.

Thanks,
Laszlo

> If you have any concern, please raise here. 
> 
> 
> Thanks,
> Dandan
> 
>> -Original Message-
>> From: Gao, Liming
>> Sent: Thursday, November 8, 2018 9:56 PM
>> To: Bi, Dandan ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu ; Kinney, Michael D
>> 
>> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format
>> in AcpiEx
>>
>> Reviewed-by: Liming Gao 
>>
>>> -Original Message-
>>> From: Bi, Dandan
>>> Sent: Thursday, November 8, 2018 9:50 PM
>>> To: edk2-devel@lists.01.org
>>> Cc: Ni, Ruiyu ; Kinney, Michael D
>>> ; Gao, Liming 
>>> Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text
>>> format in AcpiEx
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312
>>>
>>> Text format for AcpiEx device path in UEFI Spec:
>>> AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR)
>>> AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only)
>>>
>>> When convert device path to text for ACPI device path, current code
>>> check AllowShortcuts parameter to convert the device path to
>>> DisplayOnly text format(shorter text
>>> representation) by mistake.
>>> It should check DisplayOnly parameter.
>>>
>>> This commit is to fix this issue.
>>>
>>> Cc: Ruiyu Ni 
>>> Cc: Michael D Kinney 
>>> Cc: Liming Gao 
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Dandan Bi 
>>> ---
>>>  MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
>>> b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
>>> index cdcdb3623a..97d279eeb2 100644
>>> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
>>> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
>>> @@ -495,11 +495,11 @@ DevPathToTextAcpiEx (
>>>  CIDText,
>>>  UIDStr
>>> );
>>>  }
>>>} else {
>>> -if (AllowShortcuts) {
>>> +if (DisplayOnly) {
>>>//
>>>// display only
>>>//
>>>if (AcpiEx->HID == 0) {
>>>  UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr);
>>> --
>>> 2.18.0.windows.1
> 

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx

2018-11-08 Thread Bi, Dandan 
Hi Stewards and package maintainers:

Since this is a clear bug.  And the risk for this release is small.
So I plan to push this patch before edk2-stable201811 tag is created.

If you have any concern, please raise here. 


Thanks,
Dandan

> -Original Message-
> From: Gao, Liming
> Sent: Thursday, November 8, 2018 9:56 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D
> 
> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format
> in AcpiEx
> 
> Reviewed-by: Liming Gao 
> 
> > -Original Message-
> > From: Bi, Dandan
> > Sent: Thursday, November 8, 2018 9:50 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu ; Kinney, Michael D
> > ; Gao, Liming 
> > Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text
> > format in AcpiEx
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312
> >
> > Text format for AcpiEx device path in UEFI Spec:
> > AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR)
> > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only)
> >
> > When convert device path to text for ACPI device path, current code
> > check AllowShortcuts parameter to convert the device path to
> > DisplayOnly text format(shorter text
> > representation) by mistake.
> > It should check DisplayOnly parameter.
> >
> > This commit is to fix this issue.
> >
> > Cc: Ruiyu Ni 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi 
> > ---
> >  MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > index cdcdb3623a..97d279eeb2 100644
> > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > @@ -495,11 +495,11 @@ DevPathToTextAcpiEx (
> >  CIDText,
> >  UIDStr
> > );
> >  }
> >} else {
> > -if (AllowShortcuts) {
> > +if (DisplayOnly) {
> >//
> >// display only
> >//
> >if (AcpiEx->HID == 0) {
> >  UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr);
> > --
> > 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx

2018-11-08 Thread Gao, Liming 
Reviewed-by: Liming Gao 

> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, November 8, 2018 9:50 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D 
> ; Gao, Liming 
> Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in 
> AcpiEx
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312
> 
> Text format for AcpiEx device path in UEFI Spec:
> AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR)
> AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only)
> 
> When convert device path to text for ACPI device path,
> current code check AllowShortcuts parameter to convert
> the device path to DisplayOnly text format(shorter text
> representation) by mistake.
> It should check DisplayOnly parameter.
> 
> This commit is to fix this issue.
> 
> Cc: Ruiyu Ni 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi 
> ---
>  MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c 
> b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> index cdcdb3623a..97d279eeb2 100644
> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> @@ -495,11 +495,11 @@ DevPathToTextAcpiEx (
>  CIDText,
>  UIDStr
> );
>  }
>} else {
> -if (AllowShortcuts) {
> +if (DisplayOnly) {
>//
>// display only
>//
>if (AcpiEx->HID == 0) {
>  UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr);
> --
> 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel