Re: [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)]

[Nick Dokos]

Ihor Radchenko  writes:

> Nick Dokos  writes:
>
>> Here's an ECM:
>> ...
>> I narrowed it down to this snippet of code in 
>> `org-babel-tangle-single-block':
>> ...
>> and bisecting fingered this commit:
>> ...
>> Apparently, `org-back-to-heading' sets match data differently now: 
>> `(match-end 0)' gets the end of the line,
>> Before the patch, it got the beginning of the line.
>
> Thanks for the report and for the detailed analysis!
> Fixed, on bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=79ec91584

Thanks!

A couple of nits: maybe the comment that `org-back-to-heading' sets match
data should be deleted?  And there is a typo in the initial comment of
the test you added (thanks for adding it!): `:commends org' should be
`:comments org'.

Also, I found a couple of places in the code where `org-back-to-heading' is 
called
and then match data are used. I don't know if there is a problem or not, but it 
might
be worth double checking to make sure that the usage makes sense:

- org.el: l.20792 in `org-forward-heading-same-level'
- org-mouse.el: l.976 in `org-mouse-transform-to-outline'

I'll try to test these cases and report back but I can't promise when.
-- 
Nick

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[No Wayman]

Ihor Radchenko  writes:


No Wayman  writes:


No Wayman  writes:

Evaluating the following source blocking an org mode buffer 
with 
no backing file:


Interesting. I'm only able to reproduce it some of the time.
I'll look into it more when I have time, but it may have been 
an 
artifact of my Emacs session.


I saw
Was it the same for you?


Yes, that's the same error. (Sorry, looks like an intermediate 
message of mine got dropped)


Hmm. plain entry type actually works, except the above error, 
which is

likely Emacs bug.


Could be.

Re: id links in non-org buffers

[Ihor Radchenko]

Samuel Wales  writes:

> will any package highlight or follow org id in non-org?

How would IDs look like in non-org?

Re: [RFC] Refactoring org-element API

[Ihor Radchenko]

Ihor Radchenko  writes:

>> One minor nitpick: I would prefer a function like
>> ~org-element-property-1~ to be named e.g. ~org-element-property-lazy~
>> (or something similar), because the "-1" is just obfuscation to me.
> ...
> I'd prefer to see several more ideas about the alternative names, if
> possible.

What about org-element-property-raw?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: Is this proper time format?

[Ihor Radchenko]

Ihor Radchenko  writes:

> Subject: [PATCH] doc/org-manual.org: Clarify how timestamps are considered by
>  agenda

Canceled.
In favor of the other applied patch.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: Parsing nested markup objects

[Ihor Radchenko]

Ihor Radchenko  writes:

> Fair point. We indeed missed this detail in the syntax blueprint.
>
> Does the attached patch clarify things?
> From 974786c726e151ea6bb709bd508faab1cc155fcf Mon Sep 17 00:00:00 2001
> Message-Id: 
> <974786c726e151ea6bb709bd508faab1cc155fcf.1686222568.git.yanta...@posteo.net>
> From: Ihor Radchenko 
> Date: Thu, 8 Jun 2023 14:08:30 +0300
> Subject: [PATCH] * org-syntax.org (Special tokens): Clarify recursive matching

Applied, onto master.
https://git.sr.ht/~bzg/worg/commit/7b98eb36

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

[Tim Visher]

On Fri, Jun 23, 2023 at 6:53 AM Ihor Radchenko  wrote:

> Tim Visher  writes:
>
> > I've attached a small follow up `worg` patch to hopefully clarify the
> > changelog section of the commit message going forward for other
> > contributors.
>
> Thanks!
> Applied, onto master, with amendments:
>
> 1. I removed "Note", converting into normal sentence. Note is redundant.
> 2. I added reference to GNU standards, explaining what ChangeLogs are.
> https://git.sr.ht/~bzg/worg/commit/ac865c20


Fantastic! Thanks for all your help, Ihor! TTFN!

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[Ihor Radchenko]

No Wayman  writes:

> No Wayman  writes:
>
>> Evaluating the following source blocking an org mode buffer with 
>> no backing file:
>
> Interesting. I'm only able to reproduce it some of the time.
> I'll look into it more when I have time, but it may have been an 
> artifact of my Emacs session.

I saw

Debugger entered--Lisp error: (error "Buffer not visiting a file or directory")
  error("Buffer not visiting a file or directory")
  bookmark-buffer-file-name()
  bookmark-make-record-default()
  bookmark-make-record()
  bookmark-set-internal("Set bookmark named" "org-capture-last-stored" 
overwrite)
  bookmark-set("org-capture-last-stored")

Was it the same for you?

>>> I was able to trigger an error when capturing from non-Org 
>>> buffer, but
>>> that's expected - org-capture is not designed for such 
>>> scenarios.
>
> This seems unnecessarily restrictive considering there is a 
> "plain" entry type, but that's another issue/design consideration.

Hmm. plain entry type actually works, except the above error, which is
likely Emacs bug.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG

[Ihor Radchenko]

Max Nikulin  writes:

>> If we talk about image attributes defined in the affiliated keywords, we
>> should better resort to #+ATTR_HTML. Introducing extra affiliated
>> keyword would be a breaking change.
>
> I am sorry that I was not clear enough. It may be 3 boolean attributes 
> that may be specified in #+ATTR_HTML: or single one that may take 3 
> values for //.

Agree. I am in favour of a single attribute.
However, AFAIU,  is not always applicable because it does not allow
embedding and  demands embedding. So, this may need to be discussed
more carefully with more input from people familiar with HTML conventions.

> The only issue with #+ATTR_HTML: is that it is applied to all images 
> inside a paragraph. So it can not control individual inline images.

That's a general issue. We have it, we know about it, we have previously
discussed how to solve it. But it should not distract us from adding
this particular feature.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

[Ihor Radchenko]

Tim Visher  writes:

> I've attached a small follow up `worg` patch to hopefully clarify the
> changelog section of the commit message going forward for other
> contributors.

Thanks!
Applied, onto master, with amendments:

1. I removed "Note", converting into normal sentence. Note is redundant.
2. I added reference to GNU standards, explaining what ChangeLogs are.
https://git.sr.ht/~bzg/worg/commit/ac865c20

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Ihor Radchenko]

Dmitry Logvinenko  writes:

> Thank you for your comments, fixed.

Thanks!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b3a1a634

I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/d9174193

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at