Re: [O] bulk rescheduling change?
Nick Dokos writes: > Bastien wrote: > >> Hi Nick, >> >> Nick Dokos writes: >> >> > Well, the non-interactiveness and the next day are because the four >> > items I marked were the last four items for that date, so after marking >> > them, the cursor happened to be on the date line for the next day, which >> > apparently is taken as an indication that I want things to be >> > rescheduled for that date, no questions asked. Not sure I like this >> > much. >> >> This implementation was to mimick the previous behavior we had with >> `k m' (to mark an entry) then `k s' (to schedule it to the date at >> point with no prompt.) >> >> I don't like having no prompt here too. >> >> I just changed the behavior so that there is *always* a prompt >> with `m m m B s' -- if the cursor is on a date, this date is the >> default time for the prompt, RET will reschedule to this date. >> > > Thanks - this sounds much better. I hope Greg likes it too. > I ran a bunch of things past it and it worked perfectly (imo of course). Yes, I have updated and the new behavior seems sensible and intuitive. There's a default shown, but if I type anything it's ignored. Thanks for fixing this. pgpXzhCqj5Ur8.pgp Description: PGP signature
Re: [O] bulk rescheduling change?
Hi Bastien On Thu, Sep 13, 2012 at 1:29 AM, Bastien wrote: > This is fixed now, thanks for reporting this! Confirmed, both in an Org buffer and in the agenda buffer. Thank you. Michael
Re: [O] bulk rescheduling change?
Bastien wrote: > Hi Nick, > > Nick Dokos writes: > > > Well, the non-interactiveness and the next day are because the four > > items I marked were the last four items for that date, so after marking > > them, the cursor happened to be on the date line for the next day, which > > apparently is taken as an indication that I want things to be > > rescheduled for that date, no questions asked. Not sure I like this > > much. > > This implementation was to mimick the previous behavior we had with > `k m' (to mark an entry) then `k s' (to schedule it to the date at > point with no prompt.) > > I don't like having no prompt here too. > > I just changed the behavior so that there is *always* a prompt > with `m m m B s' -- if the cursor is on a date, this date is the > default time for the prompt, RET will reschedule to this date. > Thanks - this sounds much better. I hope Greg likes it too. I ran a bunch of things past it and it worked perfectly (imo of course). > > However, if I move the cursor off the date line before I issue the > > bulk command, I get a date dialog, but it's a no-op: no matter what > > I give it, things are rescheduled to today. > I also turned the time grid back on in the agenda and that's working without errors too. Thanks! Nick
Re: [O] bulk rescheduling change?
Hi Nick, Nick Dokos writes: > Well, the non-interactiveness and the next day are because the four > items I marked were the last four items for that date, so after marking > them, the cursor happened to be on the date line for the next day, which > apparently is taken as an indication that I want things to be > rescheduled for that date, no questions asked. Not sure I like this > much. This implementation was to mimick the previous behavior we had with `k m' (to mark an entry) then `k s' (to schedule it to the date at point with no prompt.) I don't like having no prompt here too. I just changed the behavior so that there is *always* a prompt with `m m m B s' -- if the cursor is on a date, this date is the default time for the prompt, RET will reschedule to this date. > However, if I move the cursor off the date line before I issue the > bulk command, I get a date dialog, but it's a no-op: no matter what > I give it, things are rescheduled to today. Fixed. Thanks! -- Bastien
Re: [O] bulk rescheduling change?
Hi Michael, Michael Brand writes: > I didn’t yet investigate further but wanted to throw this in because I > think it is related: Since a few weeks “C-c C-s + 1 2 : 0 0” does not > keep tomorrow’s date but falls back to today after typing the time > part has been completed. This is fixed now, thanks for reporting this! -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos writes: > org-agenda-format-item changed its calling sequence in b508ff69. > I haven't checked all the call sites in org-agenda.el but there is > a call site in org.el that apparently was missed, as well as the > declaration of the function in the same file. Fixed, thanks. -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos writes: >> Not sure - the last thing that .emacs does is bring up the agenda. >> Let me try to investigate a bit what exactly breaks. > > Something goes awry with the agenda time grid. Argh, great that you could isolate this. There was an error here, I just fixed it. Thanks for your patience in hunting this one! -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos wrote: > Nick Dokos wrote: > > > I turned off the grid for now as a workaround for the formatting > > problems. > > > > Going back to the original problem, I'm still having problems with that: > > I mark a bunch of agenda items (scheduled for today) and then do a B s. > > It reschedules them for tomorrow, no questions asked. If I repeat the > > process on the same four items, it reschedules them for the day after, > > again no questions asked. > > > > Not sure if I'm doing/setting something to cause this bahaviour, but > > it's certainly not what I expected: I thought I'd get the usual date > > dialog that would allow me to set the rescheduled date. > > > > Well, the non-interactiveness and the next day are because the four > items I marked were the last four items for that date, so after marking > them, the cursor happened to be on the date line for the next day, which > apparently is taken as an indication that I want things to be > rescheduled for that date, no questions asked. Not sure I like this > much. > > However, if I move the cursor off the date line before I issue the > bulk command, I get a date dialog, but it's a no-op: no matter what > I give it, things are rescheduled to today. Correction: only relative changes are no-ops. Absolute dates or picking a date from the popped-up calendar work. Nick
Re: [O] bulk rescheduling change?
Nick Dokos wrote: > I turned off the grid for now as a workaround for the formatting > problems. > > Going back to the original problem, I'm still having problems with that: > I mark a bunch of agenda items (scheduled for today) and then do a B s. > It reschedules them for tomorrow, no questions asked. If I repeat the > process on the same four items, it reschedules them for the day after, > again no questions asked. > > Not sure if I'm doing/setting something to cause this bahaviour, but > it's certainly not what I expected: I thought I'd get the usual date > dialog that would allow me to set the rescheduled date. > Well, the non-interactiveness and the next day are because the four items I marked were the last four items for that date, so after marking them, the cursor happened to be on the date line for the next day, which apparently is taken as an indication that I want things to be rescheduled for that date, no questions asked. Not sure I like this much. However, if I move the cursor off the date line before I issue the bulk command, I get a date dialog, but it's a no-op: no matter what I give it, things are rescheduled to today. Nick
Re: [O] bulk rescheduling change?
I turned off the grid for now as a workaround for the formatting problems. Going back to the original problem, I'm still having problems with that: I mark a bunch of agenda items (scheduled for today) and then do a B s. It reschedules them for tomorrow, no questions asked. If I repeat the process on the same four items, it reschedules them for the day after, again no questions asked. Not sure if I'm doing/setting something to cause this bahaviour, but it's certainly not what I expected: I thought I'd get the usual date dialog that would allow me to set the rescheduled date. Thanks, Nick
Re: [O] bulk rescheduling change?
Nick Dokos wrote:
> Nick Dokos wrote:
>
> > Bastien wrote:
> >
> > > Nick Dokos writes:
> > >
> > > > Not quite: I now get the following backtrace.
> > >
> > > Can you send me a reproducible minimal recipe?
> > >
> >
> > Not sure - the last thing that .emacs does is bring up the agenda.
> > Let me try to investigate a bit what exactly breaks.
> >
>
> Something goes awry with the agenda time grid. I get the error with
> the appended minimal .emacs when I try to bring up the agenda with
> C-c a a.
>
org-agenda-format-item changed its calling sequence in b508ff69.
I haven't checked all the call sites in org-agenda.el but there is
a call site in org.el that apparently was missed, as well as the
declaration of the function in the same file.
Nick
> ;;; -*- mode: emacs-lisp -*-
> ;;; constant part
> (add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
> (add-to-list 'load-path (expand-file-name
> "~/src/emacs/org/org-mode/contrib/lisp"))
>
> (add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" .
> org-mode))
>
> (require 'org-install)
>
> (setq debug-on-error t)
> (setq debug-on-quit t)
> (setq eval-expression-print-length nil)
> (setq eval-expression-print-level nil)
>
> (global-set-key "\C-cl" 'org-store-link)
> (global-set-key "\C-ca" 'org-agenda)
>
> (setq org-agenda-us-time-grid t)
> (setq org-agenda-time-grid '((daily today)))
>
Re: [O] bulk rescheduling change?
Nick Dokos wrote:
> Bastien wrote:
>
> > Nick Dokos writes:
> >
> > > Not quite: I now get the following backtrace.
> >
> > Can you send me a reproducible minimal recipe?
> >
>
> Not sure - the last thing that .emacs does is bring up the agenda.
> Let me try to investigate a bit what exactly breaks.
>
Something goes awry with the agenda time grid. I get the error with
the appended minimal .emacs when I try to bring up the agenda with
C-c a a.
Thanks,
Nick
--8<---cut here---start->8---
;;; -*- mode: emacs-lisp -*-
;;; constant part
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
(add-to-list 'load-path (expand-file-name
"~/src/emacs/org/org-mode/contrib/lisp"))
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org-install)
(setq debug-on-error t)
(setq debug-on-quit t)
(setq eval-expression-print-length nil)
(setq eval-expression-print-level nil)
(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(setq org-agenda-us-time-grid t)
(setq org-agenda-time-grid '((daily today)))
--8<---cut here---end--->8---
Re: [O] bulk rescheduling change?
Bastien wrote: > Nick Dokos writes: > > > Not quite: I now get the following backtrace. > > Can you send me a reproducible minimal recipe? > Not sure - the last thing that .emacs does is bring up the agenda. Let me try to investigate a bit what exactly breaks. Nick PS. Please disregard my question about the last backtrace. I hadn't gotten through my mail backlog at the time.
Re: [O] bulk rescheduling change?
Bastien wrote: > Nick Dokos writes: > > > Reverting commits > > Yes -- but please bare with us, we want the feature to > stabilize :) > I meant that as a pointer of where things went off the rails - I certainly don't expect you to revert the commits. Thanks, Nick PS. Any idea about the last backtrace?
Re: [O] bulk rescheduling change?
Nick Dokos writes: > Not quite: I now get the following backtrace. Can you send me a reproducible minimal recipe? -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos writes: > Reverting commits Yes -- but please bare with us, we want the feature to stabilize :) -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos writes: > ... and after going back to before Nicolas's last four commits, I get > the attached backtrace in org-agenda-list: > > Debugger entered--Lisp error: (wrong-type-argument wholenump -1) > make-string(-1 32) This is hopefully fixed now. Thanks for testing, -- Bastien
Re: [O] bulk rescheduling change?
Nick Dokos wrote: > Nicolas Goaziou wrote: > > > Hello, > > > > Bastien writes: > > > > > Nick Dokos writes: > > > > > >> org-exp-blocks.el seems to have been deleted but org-exp.el still > > >> requires it. > > >> What's going on? > > > > > > (This is not related to the bug mentioned in this thread.) > > > > > > I guess Nicolas is on this, I'll not interfere here, but yes, > > > this is a problem. > > > > It should be fixed now. > > > > > > OK - the org-exp-blocks.el problem is gone. I'm still getting stuck > on the agenda problem. Looking into it. > Reverting commits b508ff69015cbacdd151aa05ace9131fa66c73f6 and 1f41f087 fixes the agenda problem for me. Thanks, Nick
Re: [O] bulk rescheduling change?
Hi all I didn’t yet investigate further but wanted to throw this in because I think it is related: Since a few weeks “C-c C-s + 1 2 : 0 0” does not keep tomorrow’s date but falls back to today after typing the time part has been completed. I know there is “C-c C-s Shift-Right 1 2 : 0 0” but this is only a workaround for me because only the first allows “touch typing”. Michael
Re: [O] bulk rescheduling change?
Nicolas Goaziou wrote: > Hello, > > Bastien writes: > > > Nick Dokos writes: > > > >> org-exp-blocks.el seems to have been deleted but org-exp.el still requires > >> it. > >> What's going on? > > > > (This is not related to the bug mentioned in this thread.) > > > > I guess Nicolas is on this, I'll not interfere here, but yes, > > this is a problem. > > It should be fixed now. > > OK - the org-exp-blocks.el problem is gone. I'm still getting stuck on the agenda problem. Looking into it. Thanks, Nick
Re: [O] bulk rescheduling change?
Nick Dokos writes: > Greg Troxel wrote: > >> >> I'm running from git, updating every few weeks, currently on >> >> commit c276eeebeecba23913547f62cf4b8122f0e8efa9 >> Author: Jambunathan K >> Date: Wed Sep 5 03:33:16 2012 +0530 >> >> (that commit is surely not relevant to my question...). >> >> I often hope to get more done than I do, so I'm often faced with pushing >> scheduled items forward. I typically do this from the agenda view, with >> 'C-c C-s' for individual items, and markings and 'B s' for groups of >> items (typically, saturday-type items to a week later). I find that >> with individual rescheduling, I get a prompt that has no prefilled text, >> and can easily type '+1', or 'sat'. 'B s' used to behave this >> way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have >> to delete that. This seems like a misfeature, because at least for me >> bulk-reschedulign to today is not the dominant case, and if it were . is >> easy to type anwyay. The info file doesn't explain this. > > It *should* be the case that you shouldn't have to delete the default: > just select a date from the calendar or type +2 or type a date and it > should take that. But in my (rather hastily done) experiment, it > seemed to ignore any such and in fact, when I tried to reschedule > again the bunch of things that it rescheduled for today, it would not > even stop and let me enter anything. I should have pointed out that I'm running emacs 23.4 inside an xterm. pgp5zrNxcklpg.pgp Description: PGP signature
Re: [O] bulk rescheduling change?
Hello, Bastien writes: > Nick Dokos writes: > >> org-exp-blocks.el seems to have been deleted but org-exp.el still requires >> it. >> What's going on? > > (This is not related to the bug mentioned in this thread.) > > I guess Nicolas is on this, I'll not interfere here, but yes, > this is a problem. It should be fixed now. Regards, -- Nicolas Goaziou
Re: [O] bulk rescheduling change?
Nick Dokos wrote: > Bastien wrote: > > > Hi Greg, > > > > Greg Troxel writes: > > > > > I often hope to get more done than I do, so I'm often faced with pushing > > > scheduled items forward. I typically do this from the agenda view, with > > > 'C-c C-s' for individual items, and markings and 'B s' for groups of > > > items (typically, saturday-type items to a week later). I find that > > > with individual rescheduling, I get a prompt that has no prefilled text, > > > and can easily type '+1', or 'sat'. 'B s' used to behave this > > > way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have > > > to delete that. This seems like a misfeature, because at least for me > > > bulk-reschedulign to today is not the dominant case, and if it were . is > > > easy to type anwyay. The info file doesn't explain this. > > > > This has been fixed earlier today -- please update. > > > > OK I just updated and I'm running into trouble: > > org-exp-blocks.el seems to have been deleted but org-exp.el still requires it. > What's going on? > ... and after going back to before Nicolas's last four commits, I get the attached backtrace in org-agenda-list: Debugger entered--Lisp error: (wrong-type-argument wholenump -1) make-string(-1 32) (setq marker (org-agenda-new-marker beg) level (make-string (1- (org-outline-level)) 32) category (org-get-category beg) category-pos (get-text-property beg (quote org-category-position)) tags (save-excursion (org-backward-heading-same-level 0) (org-get-tags-at)) todo-state (org-get-todo-state) warntime (org-entry-get (point) "APPT_WARNTIME")) (progn (setq marker (org-agenda-new-marker beg) level (make-string (1- (org-outline-level)) 32) category (org-get-category beg) category-pos (get-text-property beg (quote org-category-position)) tags (save-excursion (org-backward-heading-same-level 0) (org-get-tags-at)) todo-state (org-get-todo-state) warntime (org-entry-get (point) "APPT_WARNTIME")) (dolist (r (if (stringp result) (list result) result)) (when (and org-agenda-diary-sexp-prefix (string-match org-agenda-diary-sexp-prefix r)) (setq extra (match-string 0 r) r (replace-match "" nil nil r))) (if (string-match "\\S-" r) (setq txt r) (setq txt "SEXP entry returned empty string")) (setq txt (org-agenda-format-item extra txt level category tags (quote time))) (org-add-props txt props (quote org-marker) marker (quote org-category) category (quote date) date (quote todo-state) todo-state (quote org-category-position) category-pos (quote tags) tags (quote level) level (quote type) "sexp" (quote warntime) warntime) (push txt ee))) (if result (progn (setq marker (org-agenda-new-marker beg) level (make-string (1- (org-outline-level)) 32) category (org-get-category beg) category-pos (get-text-property beg (quote org-category-position)) tags (save-excursion (org-backward-heading-same-level 0) (org-get-tags-at)) todo-state (org-get-todo-state) warntime (org-entry-get (point) "APPT_WARNTIME")) (dolist (r (if (stringp result) (list result) result)) (when (and org-agenda-diary-sexp-prefix (string-match org-agenda-diary-sexp-prefix r)) (setq extra (match-string 0 r) r (replace-match "" nil nil r))) (if (string-match "\\S-" r) (setq txt r) (setq txt "SEXP entry returned empty string")) (setq txt (org-agenda-format-item extra txt level category tags (quote time))) (org-add-props txt props (quote org-marker) marker (quote org-category) category (quote date) date (quote todo-state) todo-state (quote org-category-position) category-pos (quote tags) tags (quote level) level (quote type) "sexp" (quote warntime) warn time) (push txt ee (when result (setq marker (org-agenda-new-marker beg) level (make-string (1- (org-outline-level)) 32) category (org-get-category beg) category-pos (get-text-property beg (quote org-category-position)) tags (save-excursion (org-backward-heading-same-level 0) (org-get-tags-at)) todo-state (org-get-todo-state) warntime (org-entry-get (point) "APPT_WARNTIME")) (dolist (r (if (stringp result) (list result) result)) (when (and org-agenda-diary-sexp-prefix (string-match org-agenda-diary-sexp-prefix r)) (setq extra (match-string 0 r) r (replace-match "" nil nil r))) (if (string-match "\\S-" r) (setq txt r) (setq txt "SEXP entry returned empty string")) (setq txt (org-agenda-format-item extra txt level category tags (quote time))) (org-add-props txt props (quote org-marker) marker (quote org-category) category (quote date) date (quote todo-state) todo-state (quote org-category-position) category-pos (quote tags) tags (quote level) level (quote type) "sexp" (quote warntime) warntime) (push txt ee))) (catch :skip (org-agenda-skip) (setq beg (match-beginning 0)) (goto-char (1- (match-end 0))) (setq b (point)) (forward-sexp 1) (setq sexp (buffer-substring b (point))) (setq sexp-entry (if (looking-at "[ ]*\\(\\S-.*\\)") (org-trim (match-string 1)) "")) (setq result (org-diary-sexp-entry sexp sexp-entry
Re: [O] bulk rescheduling change?
Nick Dokos writes: > org-exp-blocks.el seems to have been deleted but org-exp.el still requires it. > What's going on? (This is not related to the bug mentioned in this thread.) I guess Nicolas is on this, I'll not interfere here, but yes, this is a problem. -- Bastien
Re: [O] bulk rescheduling change?
Bastien wrote: > Hi Greg, > > Greg Troxel writes: > > > I often hope to get more done than I do, so I'm often faced with pushing > > scheduled items forward. I typically do this from the agenda view, with > > 'C-c C-s' for individual items, and markings and 'B s' for groups of > > items (typically, saturday-type items to a week later). I find that > > with individual rescheduling, I get a prompt that has no prefilled text, > > and can easily type '+1', or 'sat'. 'B s' used to behave this > > way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have > > to delete that. This seems like a misfeature, because at least for me > > bulk-reschedulign to today is not the dominant case, and if it were . is > > easy to type anwyay. The info file doesn't explain this. > > This has been fixed earlier today -- please update. > OK I just updated and I'm running into trouble: org-exp-blocks.el seems to have been deleted but org-exp.el still requires it. What's going on? Nick
Re: [O] bulk rescheduling change?
Greg Troxel wrote: > > I'm running from git, updating every few weeks, currently on > > commit c276eeebeecba23913547f62cf4b8122f0e8efa9 > Author: Jambunathan K > Date: Wed Sep 5 03:33:16 2012 +0530 > > (that commit is surely not relevant to my question...). > > I often hope to get more done than I do, so I'm often faced with pushing > scheduled items forward. I typically do this from the agenda view, with > 'C-c C-s' for individual items, and markings and 'B s' for groups of > items (typically, saturday-type items to a week later). I find that > with individual rescheduling, I get a prompt that has no prefilled text, > and can easily type '+1', or 'sat'. 'B s' used to behave this > way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have > to delete that. This seems like a misfeature, because at least for me > bulk-reschedulign to today is not the dominant case, and if it were . is > easy to type anwyay. The info file doesn't explain this. It *should* be the case that you shouldn't have to delete the default: just select a date from the calendar or type +2 or type a date and it should take that. But in my (rather hastily done) experiment, it seemed to ignore any such and in fact, when I tried to reschedule again the bunch of things that it rescheduled for today, it would not even stop and let me enter anything. Seems like a bug to me. Nick
Re: [O] bulk rescheduling change?
Hi Greg, Greg Troxel writes: > I often hope to get more done than I do, so I'm often faced with pushing > scheduled items forward. I typically do this from the agenda view, with > 'C-c C-s' for individual items, and markings and 'B s' for groups of > items (typically, saturday-type items to a week later). I find that > with individual rescheduling, I get a prompt that has no prefilled text, > and can easily type '+1', or 'sat'. 'B s' used to behave this > way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have > to delete that. This seems like a misfeature, because at least for me > bulk-reschedulign to today is not the dominant case, and if it were . is > easy to type anwyay. The info file doesn't explain this. This has been fixed earlier today -- please update. Thanks, -- Bastien
[O] bulk rescheduling change?
I'm running from git, updating every few weeks, currently on commit c276eeebeecba23913547f62cf4b8122f0e8efa9 Author: Jambunathan K Date: Wed Sep 5 03:33:16 2012 +0530 (that commit is surely not relevant to my question...). I often hope to get more done than I do, so I'm often faced with pushing scheduled items forward. I typically do this from the agenda view, with 'C-c C-s' for individual items, and markings and 'B s' for groups of items (typically, saturday-type items to a week later). I find that with individual rescheduling, I get a prompt that has no prefilled text, and can easily type '+1', or 'sat'. 'B s' used to behave this way, but now the prompt is prefilled with '<2012-09-12 Wed>', and I have to delete that. This seems like a misfeature, because at least for me bulk-reschedulign to today is not the dominant case, and if it were . is easy to type anwyay. The info file doesn't explain this. pgppG4sIo7ffR.pgp Description: PGP signature
