[Orgmode] [PATCH] fix org-feed when retrieve-method is curl or wget

2009-06-30 Thread Christopher League
Hi Carsten and everyone. I love using org-feed, to gather various  
collection points (delicious, starred in google reader, dial2do, etc)  
into org-mode.


I tried switching the org-feed-retrieve-method to curl or wget, and  
encountered some bugs. The fixes were simple, and the full details are  
in the attached git patch.


The problem I was trying to solve, however, was that delicious.com  
would return a 500 server error sometimes with url.el, and I'm not  
sure why.  It returns RSS content anyway, with the error message as an  
item. Org-feed doesn't notice the HTTP response status, and  
processes the error as if it were a legit item (which means that next  
time the error occurs, it is silent).  Now that I got curl working,  
the 500 doesn't seem to happen anymore.


My hypotheses so far: maybe it has something to do with the user- 
agent, or with mangling special characters in the URL.  The delicious  
URL contains the '' argument separator, and when the error message  
comes back, it appears with something like 'amp;amp;' in it.. as if  
it were replaced twice.  I haven't traced further, to determine if  
fault lies with url.el or with delicious.com.


Best wishes
Chris



0001-fix-org-feed-when-retrieve-method-is-curl-or-wget.patch
Description: Binary data


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] [PATCH] fix org-feed when retrieve-method is curl or wget

2009-06-30 Thread Carsten Dominik

Applied, thanks.

- Carsten

On Jun 30, 2009, at 5:59 PM, Christopher League wrote:

Hi Carsten and everyone. I love using org-feed, to gather various  
collection points (delicious, starred in google reader, dial2do,  
etc) into org-mode.


I tried switching the org-feed-retrieve-method to curl or wget, and  
encountered some bugs. The fixes were simple, and the full details  
are in the attached git patch.


The problem I was trying to solve, however, was that delicious.com  
would return a 500 server error sometimes with url.el, and I'm not  
sure why.  It returns RSS content anyway, with the error message as  
an item. Org-feed doesn't notice the HTTP response status, and  
processes the error as if it were a legit item (which means that  
next time the error occurs, it is silent).  Now that I got curl  
working, the 500 doesn't seem to happen anymore.


My hypotheses so far: maybe it has something to do with the user- 
agent, or with mangling special characters in the URL.  The  
delicious URL contains the '' argument separator, and when the  
error message comes back, it appears with something like 'amp;amp;'  
in it.. as if it were replaced twice.  I haven't traced further, to  
determine if fault lies with url.el or with delicious.com.


Best wishes
Chris

0001-fix-org-feed-when-retrieve-method-is-curl-or-wget.patch
___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode




___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode