Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Konstantin Kliakhandler  writes:

> Sorry for the late reply. Am I supposed to send the patch against master or
> against maint?

The latter. Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Konstantin Kliakhandler]

Hi Nicolas,

Sorry for the late reply. Am I supposed to send the patch against master or
against maint? If against master, see the file starting at 0001. If against
maint, see the file starting with 0002.

For some reason, I can't apply the 0001 patch to the maint branch either,
nor can I rebase it to the maint branch... Weird. Hopefully this is good
enough.

Best,
Kosta

-- 
Konstantin Kliakhandler
http://slumpy.org
  )°) )°( (°(

On 5 July 2016 at 22:13, Nicolas Goaziou  wrote:

> Hello,
>
> Konstantin Kliakhandler  writes:
>
> > I have an additional, similar patch - In this one I changed the unicode
> > symbol for \circ from something looking like ^ to [image: \circ] (#x2218
> =
> > "ring operator" = \circ in TeX input method).
>
> For some reason, I'm unable to apply it to maint branch. Could you
> rebase your repository and try again?
>
> Thank you.
>
> Regards,
>
> --
> Nicolas Goaziou
>


0001-org-entities-Correct-unicode-symbol-of-circ.patch
Description: Binary data


0002-org-entities-Correct-unicode-symbol-of-circ.patch
Description: Binary data

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Rasmus  writes:

> Sure, I can do that.

Thanks !

Regards,

-- 
Nicolas Goaziou

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Rasmus]

Nicolas Goaziou  writes:

>> I'm not sure what were the conclusions of the side discussion, but
>> I do want to point out that my change is in accordance with unicode
>> symbol names and with the symbols that pdflatex prints on paper.
>
> I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus,
> would you feel like reporting it upstream?

Sure, I can do that.

Rasmus

-- 
Slowly unravels in a ball of yarn and the devil collects it

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Konstantin Kliakhandler  writes:

> I have an additional, similar patch - In this one I changed the unicode
> symbol for \circ from something looking like ^ to [image: \circ] (#x2218 =
> "ring operator" = \circ in TeX input method).

For some reason, I'm unable to apply it to maint branch. Could you
rebase your repository and try again?

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Konstantin Kliakhandler]

Thanks!

I have an additional, similar patch - In this one I changed the unicode
symbol for \circ from something looking like ^ to [image: \circ] (#x2218 =
"ring operator" = \circ in TeX input method).

Thanks,
Kosta

-- 
Konstantin Kliakhandler
http://slumpy.org
  )°) )°( (°(

On 1 July 2016 at 10:24, Nicolas Goaziou  wrote:

> Hello,
>
> Konstantin Kliakhandler  writes:
>
> > Attached is the patch, as requested.
>
> Applied. Thank you.
>
> > I'm not sure what were the conclusions of the side discussion, but
> > I do want to point out that my change is in accordance with unicode
> > symbol names and with the symbols that pdflatex prints on paper.
>
> I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus,
> would you feel like reporting it upstream?
>
> Regards,
>
> --
> Nicolas Goaziou
>


0001-org-entities-Correct-unicode-symbol-of-circ.patch
Description: Binary data

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Konstantin Kliakhandler  writes:

> Attached is the patch, as requested.

Applied. Thank you.

> I'm not sure what were the conclusions of the side discussion, but
> I do want to point out that my change is in accordance with unicode
> symbol names and with the symbols that pdflatex prints on paper.

I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus,
would you feel like reporting it upstream?

Regards,

-- 
Nicolas Goaziou

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Konstantin Kliakhandler]

Hello Nicolas,

Attached is the patch, as requested. I'm not sure what were the conclusions
of the side discussion, but I do want to point out that my change is in
accordance with unicode symbol names and with the symbols that pdflatex
prints on paper.

Thanks and regards,
Kosta

-- 
Konstantin Kliakhandler
http://slumpy.org
  )°) )°( (°(

On 28 June 2016 at 17:49, Nicolas Goaziou  wrote:

> Hello,
>
> Konstantin Kliakhandler  writes:
>
> > The unicode letters for 'varphi' and for 'phi' are swapped.
>
> Good catch.
>
> > Here is a patch correcting this:
>
> Would you mind providing a patch with a proper commit message and using
> git format-patch? See
>  for details.
>
> Thank you.
>
> Regards,
>
> --
> Nicolas Goaziou
>


0001-org-entities.el-swapped-symbols-of-varphi-and-phi.patch
Description: Binary data

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Rasmus]

> AFAICT, (La)TeX disagrees with TeX input method. The latter may be
> buggy.
>
> Regards,

Nick Dokos  writes:

> That's not what Lamport says (p.41, 2nd ed.) Maybe the input method
> got it wrong?

Oh, you are all right.  Sorry about the noise.

-- 
You people at the NSA are becoming my new best friends!

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nick Dokos]

Rasmus  writes:

> Konstantin Kliakhandler  writes:
>
>> Hello,
>>
>> The unicode letters for 'varphi' and for 'phi' are swapped.
>>
>> Here is a patch correcting this:
>>
>> diff --git a/lisp/org-entities.el b/lisp/org-entities.el
>> index 4044432..6f6d054 100644
>> --- a/lisp/org-entities.el
>> +++ b/lisp/org-entities.el
>> @@ -204,9 +204,8 @@ packages to be loaded, add these packages to
>> `org-latex-packages-alist'."
>>  ("upsih" "\\Upsilon" t "" "upsilon" "upsilon" "ϒ")
>>  ("upsilon" "\\upsilon" t "" "upsilon" "upsilon" "υ")
>>  ("Phi" "\\Phi" t "" "Phi" "Phi" "Φ")
>> -("phi" "\\phi" t "" "phi" "phi" "φ")
>> -("varphi" "\\varphi" t "" "varphi" "varphi" "ɸ")
>> +("phi" "\\phi" t "" "phi" "phi" "ɸ")
>> +("varphi" "\\varphi" t "" "varphi" "varphi" "φ")
>
> It's not straight forward.
>
> The behavior is "correct" with reference to (La)TeX.  E.g.
>
> M-x set-input-method RET TeX RET
>
> Then,
>
> \phi → φ
> \varphi → ϕ
>

That's not what Lamport says (p.41, 2nd ed.) Maybe the input method
got it wrong?

> Your suggestion is correct with reference to HTML.
>
> I’d tend to favor the TeX interpretation even if it’s technically wrong.
>
> Rasmus

-- 
Nick

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Rasmus  writes:

> The behavior is "correct" with reference to (La)TeX.  E.g.
>
> M-x set-input-method RET TeX RET
>
> Then,
>
> \phi → φ
> \varphi → ϕ
>
> Your suggestion is correct with reference to HTML.
>
> I’d tend to favor the TeX interpretation even if it’s technically
> wrong.

AFAICT, (La)TeX disagrees with TeX input method. The latter may be
buggy.

Regards,

-- 
Nicolas Goaziou

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Rasmus]

Konstantin Kliakhandler  writes:

> Hello,
>
> The unicode letters for 'varphi' and for 'phi' are swapped.
>
> Here is a patch correcting this:
>
> diff --git a/lisp/org-entities.el b/lisp/org-entities.el
> index 4044432..6f6d054 100644
> --- a/lisp/org-entities.el
> +++ b/lisp/org-entities.el
> @@ -204,9 +204,8 @@ packages to be loaded, add these packages to
> `org-latex-packages-alist'."
>  ("upsih" "\\Upsilon" t "" "upsilon" "upsilon" "ϒ")
>  ("upsilon" "\\upsilon" t "" "upsilon" "upsilon" "υ")
>  ("Phi" "\\Phi" t "" "Phi" "Phi" "Φ")
> -("phi" "\\phi" t "" "phi" "phi" "φ")
> -("varphi" "\\varphi" t "" "varphi" "varphi" "ɸ")
> +("phi" "\\phi" t "" "phi" "phi" "ɸ")
> +("varphi" "\\varphi" t "" "varphi" "varphi" "φ")

It's not straight forward.

The behavior is "correct" with reference to (La)TeX.  E.g.

M-x set-input-method RET TeX RET

Then,

\phi → φ
\varphi → ϕ

Your suggestion is correct with reference to HTML.

I’d tend to favor the TeX interpretation even if it’s technically wrong.

Rasmus

-- 
May contains speling mistake

Re: [O] BUG: swapped utf-8 symbols in org-entities

[Nicolas Goaziou]

Hello,

Konstantin Kliakhandler  writes:

> The unicode letters for 'varphi' and for 'phi' are swapped.

Good catch.

> Here is a patch correcting this:

Would you mind providing a patch with a proper commit message and using
git format-patch? See
 for details.

Thank you.

Regards,

-- 
Nicolas Goaziou