[Engine-devel] -1
Hi, This was my last week with oVirt, I give back my maintainer permissions. Good luck guys! :) Best regards, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Eli Mesika emes...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Sunday, September 1, 2013 5:06:42 PM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Eli Mesika emes...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Sunday, September 1, 2013 5:13:39 PM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Eli Mesika emes...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Sunday, September 1, 2013 3:29:06 PM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Eli Mesika emes...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Sunday, September 1, 2013 2:47:02 PM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Eli Mesika emes...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Sunday, September 1, 2013 10:35:43 AM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Eli Mesika emes...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Friday, August 30, 2013 7:17:32 PM
Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures
Hi Eli,
I wrote a quick benchmark to see if there is any difference when
using
STABLE
modifier on functions running queries the way the engine does it
(calling
it
from JDBC, one function in a single statement)
with a stable function:
create function getKakukk(_id int) returns VARCHAR STABLE as
'select
val
from
kakukk where id = $1' language sql;
and one not marked as stable
create function getKakukk_(_id int) returns VARCHAR as 'select val
from
kakukk where id = $1' language sql;
the table is this simple:
create table kakukk(id int primary key, val varchar);
and the only content is:
insert into kakukk (id, val) values (1, 'bla bla bla');
Now the benchmark code:
package com.foobar;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
public class SpeedTest {
Connection connection;
@Before
public void connect() throws SQLException {
connection =
DriverManager.getConnection(jdbc:postgresql://localhost/stabletest,
engine, engine);
}
@After
public void disconnect() throws SQLException {
connection.close();
}
private long measure(Runnable runnable, int times) {
final long start = System.currentTimeMillis();
for (int i = 0; i times; i++) {
runnable.run();
}
final long end = System.currentTimeMillis();
return end - start;
}
public static class Select implements Runnable {
public Select(PreparedStatement preparedStatement) {
super();
this.preparedStatement = preparedStatement;
}
final PreparedStatement preparedStatement;
public void run() {
try (
ResultSet resultSet =
preparedStatement.executeQuery();)
{
while (resultSet.next()) {
// nothing, just next
}
} catch (SQLException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}
}
@Test
public void performTest() throws SQLException {
for (int i = 0; i 10; i++) {
try (
PreparedStatement stable =
connection.prepareStatement(select
getKakukk(1));
PreparedStatement notStable =
connection.prepareStatement(select
getKakukk_(1));)
{
System.out.println(STABLE
Re: [Engine-devel] NPE in RunVmCommandTest
Hi, Thank you reviewers, the patch is now merged. Just an idea how to avoid (or early detect) these problems in the future: we could set up a junkins job to run the tests with -DforkMode=always appended to the mvn command line, so that tests will have an isolated environment. If this build falis, we know that there is a mistake in a test. Hopefully it is only the test :) As forking JVM is relatively costly and time-consuming operation this would run probably once a day, but perform all the same tests as the normal build triggered by gerrit. David, can you help us setting up this configuration? Thank you, Laszlo - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Roy Golan rgo...@redhat.com, engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 4:57:39 PM Subject: Re: [Engine-devel] NPE in RunVmCommandTest Excellent, thanks. Reviewing now. Greg - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Roy Golan rgo...@redhat.com, engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 9:45:17 AM Subject: Re: [Engine-devel] NPE in RunVmCommandTest Hi, I ran into the same, sent a patch, my explanation for the problem is in the commit msg: http://gerrit.ovirt.org/18608 Thx, Laszlo - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Roy Golan rgo...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 10:07:25 PM Subject: [Engine-devel] NPE in RunVmCommandTest Hi Roy, On a fresh clone of ovirt-engine master, I'm experiencing a very strange test failure in RunVmCommandTest. I believe it's race-condition based. It's related to the osRepository variable that you added to RunVmCommand in ba8ada49. Sometimes it's just null in the 16 of the 17 RunVmCommandTest tests, causing an NPE at RunVmCommand:680. Surefire report attached. I can duplicate it pretty well on my home workstation running a command-line build (which is a little slower than my T520). I can't duplicate it on the T520 running a command-line build. I can duplicate it on the T520 if I run the tests inside Eclipse (right click on a test method, Run As JUnit test, wait 30 seconds, fail). If there is a race condition, maybe it's related to setting osRepository in the initializer. That's just a guess. Can you assist? Thanks, Greg Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Opimizing Postgres Stored Procedures
- Original Message - From: Eli Mesika emes...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, August 28, 2013 11:45:14 AM Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Eli Mesika emes...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 11:40:27 AM Subject: Re: [Engine-devel] Opimizing Postgres Stored Procedures Hi Eli, Most of the functions that we have in the DB are doing very simple jobs like run a query, insert/update and I see that now you have all QUERY functions as STABLE. My questions: Is this required for new functions from now on? Yes and a email asking that was posted to engine_devel Is this done in order to improve performance? Yes Do you have any documents/benchmarks on how and why does this improve performance? STABLE functions should improve performance if they return the same result for the same parameters in the same statement. E.g. if you have a stable function like select foo(x) from y then the function can be invoked only once to evaluate each distinct value of y.x - this is kind of useful Functions running queries for the ovirt engine are typically invoked from client side, therefore they are only ivoked once from the parameters list and therefore will be only executed once for that single statement. Thank you, Laszlo - Original Message - From: Eli Mesika emes...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, August 26, 2013 11:22:20 AM Subject: [Engine-devel] Opimizing Postgres Stored Procedures Hi I had merged the following patch http://gerrit.ovirt.org/#/c/17962/ This patch introduce usage of the IMMUTABLE, STABLE and STRICT keywords in order to boost performance of the Postgres SPs. Please make sure that your current/and future DB scripts applied that. Volatility -- * A function should be marked as IMMUTABLE if it doesn't change the database, and if it doesn't perform any lookups (even for database configuration values) during its operation. * A function should be marked STABLE if it doesn't change the database, but might perform lookups (IMMUTABLE is preferable if function meets the requirements). * A function doesn't need to be marked VOLATILE, because that's the default. STRICTNESS -- A function should be marked STRICT if it should return NULL when it is passed a NULL argument, and then the function won't even be called if it is indeed passed a NULL argument. I am available for any questions. Thanks Eli ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Opimizing Postgres Stored Procedures
Hi Eli, Most of the functions that we have in the DB are doing very simple jobs like run a query, insert/update and I see that now you have all QUERY functions as STABLE. My questions: Is this required for new functions from now on? Is this done in order to improve performance? Thank you, Laszlo - Original Message - From: Eli Mesika emes...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, August 26, 2013 11:22:20 AM Subject: [Engine-devel] Opimizing Postgres Stored Procedures Hi I had merged the following patch http://gerrit.ovirt.org/#/c/17962/ This patch introduce usage of the IMMUTABLE, STABLE and STRICT keywords in order to boost performance of the Postgres SPs. Please make sure that your current/and future DB scripts applied that. Volatility -- * A function should be marked as IMMUTABLE if it doesn't change the database, and if it doesn't perform any lookups (even for database configuration values) during its operation. * A function should be marked STABLE if it doesn't change the database, but might perform lookups (IMMUTABLE is preferable if function meets the requirements). * A function doesn't need to be marked VOLATILE, because that's the default. STRICTNESS -- A function should be marked STRICT if it should return NULL when it is passed a NULL argument, and then the function won't even be called if it is indeed passed a NULL argument. I am available for any questions. Thanks Eli ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] NPE in RunVmCommandTest
Hi, I ran into the same, sent a patch, my explanation for the problem is in the commit msg: http://gerrit.ovirt.org/18608 Thx, Laszlo - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Roy Golan rgo...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 10:07:25 PM Subject: [Engine-devel] NPE in RunVmCommandTest Hi Roy, On a fresh clone of ovirt-engine master, I'm experiencing a very strange test failure in RunVmCommandTest. I believe it's race-condition based. It's related to the osRepository variable that you added to RunVmCommand in ba8ada49. Sometimes it's just null in the 16 of the 17 RunVmCommandTest tests, causing an NPE at RunVmCommand:680. Surefire report attached. I can duplicate it pretty well on my home workstation running a command-line build (which is a little slower than my T520). I can't duplicate it on the T520 running a command-line build. I can duplicate it on the T520 if I run the tests inside Eclipse (right click on a test method, Run As JUnit test, wait 30 seconds, fail). If there is a race condition, maybe it's related to setting osRepository in the initializer. That's just a guess. Can you assist? Thanks, Greg Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Ideas about engine clustering?
Hi, - Original Message - From: plysan ply...@gmail.com To: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 3:49:31 PM Subject: [Engine-devel] Ideas about engine clustering? Hello, guys: I'm trying to make a jboss clustering environment for engine. But felt the difficuty too. So I want to know if any one is working on this? I googled it and haven't found anything. I know there will be lots of things to do for engine migrating to clustering environment. I just want to know what problem need to be solved? I would like to list the things I think that is needed to do(or solve): 1. run jboss in standalone-ha mode or domain mode. 2. add @Clustered annotation to each EJB, I think this will solve the replication problem in cluster, probably lots of details in it. 3. QuartzScheduler problem, only one node running a scheduler is enough at a time instead of each node running one. 4. use mod_cluster to handle load balancing. 5. postgresql clustering. For failover it sounds like a plan, just wondering if this could solve load balancing problems as well. Ovirt is generating a big load on the DB and I would be really interested if SQL DB clustering could solve the issues. It would be great if it could, big part of the scalablity issue is the evil things we did against that poor database. 6. There should be more, but hope anyone can think about it :D There are tons of data structures that are used in oVirt that store state. You will have to hunt all of these down and replace with a data structure that is shared between the cluster memebers. This may be a big lot of work from many parts of the application. Any ideas? Thanks! ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] InitBackendServicesOnStartupBean create
Good point! Let's see, there are two services initialized there in try-catch block, therefore the failure of only this two will be tolerated. The two services are: - VmPropertiesUtils - DevicePropertiesUtils I looked into it and for this two services I would rather let engine fail of they can not initialize, since that may very likely be caused by missing or broken configuration and I am not sure the engine would perform right after the failure of these services. - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, August 7, 2013 5:37:16 PM Subject: Re: [Engine-devel] InitBackendServicesOnStartupBean create - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Wednesday, August 7, 2013 5:59:34 PM Subject: [Engine-devel] InitBackendServicesOnStartupBean create Hi, I made some mistake in the upgrade of my engine (which is my bad) but then I noticed that when one service initialization fails, the rest of the services are not initialized, but still the engine will start even then and it did not even log. There are some patterns in that single method on initialization, some work with 'try', some spawn a new thread. Can we have this cleaned up? What I was thinking of is that each service should be initialized, creating a thread is it's own business, exceptions from initialization should be caught, logged and engine startup should be prevented if any service fails to initialize. The question is indeed whether we should really fail in case ANY service fails. In addition, may I suggest spawning a thread for each one of the services (unless there is dependency of course), and wait for completion in order to reduce startup time? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] InitBackendServicesOnStartupBean create
Hi, I made some mistake in the upgrade of my engine (which is my bad) but then I noticed that when one service initialization fails, the rest of the services are not initialized, but still the engine will start even then and it did not even log. There are some patterns in that single method on initialization, some work with 'try', some spawn a new thread. Can we have this cleaned up? What I was thinking of is that each service should be initialized, creating a thread is it's own business, exceptions from initialization should be caught, logged and engine startup should be prevented if any service fails to initialize. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] failed to add host into cluster
- Original Message - From: Wei D Chen wei.d.c...@intel.com To: Itamar Heim ih...@redhat.com Cc: Lijuan Zhang lijuan.zh...@intel.com, engine-devel@ovirt.org Sent: Monday, August 5, 2013 8:03:08 AM Subject: Re: [Engine-devel] failed to add host into cluster Best Regards, Dave Chen -Original Message- From: Itamar Heim [mailto:ih...@redhat.com] Sent: Sunday, August 04, 2013 10:25 PM To: Chen, Wei D Cc: engine-devel@ovirt.org; Zhang, Lijuan Subject: Re: [Engine-devel] failed to add host into cluster On 08/02/2013 09:34 AM, Chen, Wei D wrote: Failed to add a node into cluster. I saw follow hints, but still don't know how to fix it. OS is fedora 19 both for node and engine, anyone can help me? Host *** does not comply with the cluster *** emulated machines. The Hosts emulated machines are clipper,none and the cluster is [rhel6.4.0, pc-1.0]} what Os is the host running? fedora 19 what does 'vdsClient -s 0 getVdsCaps' returns? where to run this command? this command is not recognized both in engine and node. After installing the host, you should have this command in the host OS. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] failed to add host into cluster
Hi, Dave, could you also share the vdsm log as well? I managed to reproduce this on the host that I am using for years and I am using it now, so it should not be a hardware problem. Probably some broken configuration caused some problem in vdsm before it would retrieve the capabilities information from libvirt. - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Wei D Chen wei.d.c...@intel.com, Lijuan Zhang lijuan.zh...@intel.com, engine-devel@ovirt.org Sent: Monday, August 5, 2013 2:03:58 PM Subject: Re: [Engine-devel] failed to add host into cluster On 08/05/2013 09:06 AM, Laszlo Hornyak wrote: - Original Message - From: Wei D Chen wei.d.c...@intel.com To: Itamar Heim ih...@redhat.com Cc: Lijuan Zhang lijuan.zh...@intel.com, engine-devel@ovirt.org Sent: Monday, August 5, 2013 8:03:08 AM Subject: Re: [Engine-devel] failed to add host into cluster Best Regards, Dave Chen -Original Message- From: Itamar Heim [mailto:ih...@redhat.com] Sent: Sunday, August 04, 2013 10:25 PM To: Chen, Wei D Cc: engine-devel@ovirt.org; Zhang, Lijuan Subject: Re: [Engine-devel] failed to add host into cluster On 08/02/2013 09:34 AM, Chen, Wei D wrote: Failed to add a node into cluster. I saw follow hints, but still don't know how to fix it. OS is fedora 19 both for node and engine, anyone can help me? Host *** does not comply with the cluster *** emulated machines. The Hosts emulated machines are clipper,none and the cluster is [rhel6.4.0, pc-1.0]} what Os is the host running? fedora 19 what does 'vdsClient -s 0 getVdsCaps' returns? where to run this command? this command is not recognized both in engine and node. After installing the host, you should have this command in the host OS. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel cat /proc/cpuinfo and virsh capabilities are also interesting ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] failed to add host into cluster
Hi, I got the same error after X reinstallation on a host with fedora 19, fedora 18 engine and latest otopi+host deploy. A total host OS reinstall helped, however I noticed that after installing VDSM from engine, an old version was installed, incompatible with 3.3, so I had to manually edit /etc/yum.repos.d/ovirt.repo to enable nightly and manually upgrade. It worked fine after that. Another, less accurate, but much more effective solution that I previously used is to update the config to accept whatever vdsm offers (obviously a hack, not meant for production) Laszlo - Original Message - From: Itamar Heim ih...@redhat.com To: Wei D Chen wei.d.c...@intel.com Cc: Lijuan Zhang lijuan.zh...@intel.com, engine-devel@ovirt.org Sent: Sunday, August 4, 2013 4:24:44 PM Subject: Re: [Engine-devel] failed to add host into cluster On 08/02/2013 09:34 AM, Chen, Wei D wrote: Failed to add a node into cluster. I saw follow hints, but still don't know how to fix it. OS is fedora 19 both for node and engine, anyone can help me? Host *** does not comply with the cluster *** emulated machines. The Hosts emulated machines are clipper,none and the cluster is [rhel6.4.0, pc-1.0]} what Os is the host running? what does 'vdsClient -s 0 getVdsCaps' returns? ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find bugs job fails
Hi, I will send a fix soon. - Original Message - From: Kiril Nesenko ki...@redhat.com To: Gilad Chaplik gchap...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, July 17, 2013 7:14:20 AM Subject: [Engine-devel] find bugs job fails Hello Gilad, Seems like your patch - 6af11b4d53d8fa1f2bcc2a9088459005865bff0c brakes the job[1]. Please send a fix asap. [1] http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4674/ - Kiril ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] EngineEncryptionUtilsTest
Hi, Just ran into an issue with EngineEncryptionUtilsTest, looks like it is failing if the /etc/ovirt-engine/engine.conf does not have some keys. So of course by now all of us added those keys, but isn't there a logical loop here? First the code should be tested, packaged and then installed and that's how that file should get there. We should not build the tests on the assumption that a version of oVirt is already installed. What is your opinion? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Free Text RFE patchset waiting for review
Hi, Noam Slomianko's Free Text RFE patchset is waiting for review from - restapi - frontend links to patches: - http://gerrit.ovirt.org/15414 - http://gerrit.ovirt.org/15421 - http://gerrit.ovirt.org/15484 - http://gerrit.ovirt.org/15486 Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] checkstyle and tools project
Hi, Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review? http://gerrit.ovirt.org/15719 And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722 Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Introducing limited branding support.
Hi, A related question to the designers: How do you decide if a new configuration goes to the database config, an existing or a new config file? Is there a concept for this? Thx, Laszlo - Original Message - From: Alexander Wels aw...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, June 11, 2013 6:39:20 PM Subject: [Engine-devel] Introducing limited branding support. Hi Guys, We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that allows for limited branding support of oVirt user portal and web admin. We also moved the styles needed to support this branding out of the application and into its own module. The styles can now be found in ovirt- engine/packaging/branding/ovirt.brand. In this directory you will find the following files: - branding.properties. This file controls the branding theme. - ovirt_messages.properties. A standard java resource bundle properties file containing the messages that can be changed. - A bunch of .css files that contain the classes that can be altered. I have created a wiki page with some information and pictures of what parts of the interface can be changed at this point in time. It is located here: http://www.ovirt.org/Feature/Branding There is also more information in README.branding that got introduced with this patch. Alexander ps. If your user interface looks messed up (missing borders and things of that nature) the engine cannot find the default branding. This means you are not using the make commands recently introduced. We highly recommend you use this to have a complete environment. If you are unwilling or unable to use that you can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt- engine/packaging/branding/ovirt.brand ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Introducing limited branding support.
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: aw...@redhat.com, engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 10:54:45 AM Subject: Re: [Engine-devel] Introducing limited branding support. - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: aw...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 11:46:23 AM Subject: Re: [Engine-devel] Introducing limited branding support. Hi, A related question to the designers: How do you decide if a new configuration goes to the database config, an existing or a new config file? Is there a concept for this? Hello Laszlo, I do not fully understand the question in this context. Just to make sure I understand, do you suggest that css, images and messages will be stored in database? Oh no, I wasn't thinking of blobs local FS is just OK. I mean some configuration parameters are stored in /etc/somewhere, some in /etc/somewhereelse and some in the database, and I'd just like to understand what is the concept. Regards, Alon Bar-Lev. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] xml rpc exceptions
hi, When starting my VM's I get a strange XML RPC error. org.xml.sax.SAXException: Serializable objects aren't supported, if isEnabledForExtensions() == false org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects aren't supported, if isEnabledForExtensions() == false Looks like it is trying to send a Serializable object as parameter to the VDSM, but it is not able to do so. Is anyone handling this issue? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] xml rpc exceptions
Got it, after Icada39e3918fb053cb0ad0388178ccf5c6338ca2 watchdog devices are attempted to send to vdsm as enum instead of string. Looks like it only happens to watchdogs, I will send a fix soon. Laszlo - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, June 11, 2013 1:23:33 PM Subject: [Engine-devel] xml rpc exceptions hi, When starting my VM's I get a strange XML RPC error. org.xml.sax.SAXException: Serializable objects aren't supported, if isEnabledForExtensions() == false org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects aren't supported, if isEnabledForExtensions() == false Looks like it is trying to send a Serializable object as parameter to the VDSM, but it is not able to do so. Is anyone handling this issue? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Failing Junit tests in ovirt-engine
Hi Sahina, Thank you for the fix, I merged it because the build was failing. Alissa: could you please check if the changes are OK? Thank you, Laszlo - Original Message - From: Sahina Bose sab...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Friday, June 7, 2013 10:47:34 AM Subject: [Engine-devel] Failing Junit tests in ovirt-engine Hi, I have send a patch to fix failures in junit tests [1] during ovirt-engine build. Could someone please review and merge? http://gerrit.ovirt.org/15434 thanks sahina [1] Results : Failed tests: validateParameters(org.ovirt.engine.core.bll.SetupNetworksParametersTest) at org.junit.Assert.assertFalse(Assert.java:79) at org.ovirt.engine.core.bll.SetupNetworksParametersTest.validateParameters(SetupNetworksParametersTest.java:37) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) Tests in error: gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest) gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest) Time elapsed: 0.001 sec ERROR! java.lang.NullPointerException at org.ovirt.engine.core.common.FeatureSupported.supportedInConfig(FeatureSupported.java:14) at org.ovirt.engine.core.common.FeatureSupported.multipleGatewaysSupported(FeatureSupported.java:114) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Performance and scalability
Hi Liran, Some comments to start the discussion: - Caching: exactly how is this resultset caching going to work? Wouldnt it be more simple to just cache the mapped entities? The mapping is not a big overhead, but caching the resultset seems to be difficult. - Batch updates: sounds cool, transactions are a major overhead on performance, so if you can make the update in a single tx and few interactions that will rock, but what if we keep the dynamic and statistic data in the memory at the first place and synchronize to DB on a background process. So that when you look for dynamic/statistics data, you do not have to hit the DB. Thx, Laszlo - Original Message - From: Liran Zelkha lzel...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, June 4, 2013 1:43:55 PM Subject: [Engine-devel] Performance and scalability Hi all, I've added a new feature page for Performance and Scalability. Please review and add your ideas... http://www.ovirt.org/Features/Performance_And_Scalability ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] oVirt Scheduler API Design
Hi Gilad, Some questions to start the discussion :) External scheduler API: - Why are you mixing xml into json? - I am missing from the documentation how the external scheduler can communicate to the engine Thx, Laszlo - Original Message - From: Gilad Chaplik gchap...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, May 28, 2013 4:34:11 PM Subject: [Engine-devel] oVirt Scheduler API Design Hi all, Attached links for oVirt Scheduler API design wiki page. High level overview: http://www.ovirt.org/Features/oVirtScheduler Detailed design: http://www.ovirt.org/Features/oVirtSchedulerAPI You are more than welcome to share you thoughts. Thanks, Gilad. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] for a few clicks less
Hi, Today the default memory size when creating a VM is 512 MB, this is coming from the Blank template, which is not modifiable by user. This amount of memory is not enough for a installation for most Linux distros (and possibly for other mainstream OS either) so I think it would make sense to increase the default memory size to 1024 MB, for most users, it would save some time. This patch changes the memory size for new installations. http://gerrit.ovirt.org/14747 Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] for a few clicks less
Handling the upgrade is easy but I am not sure users want it. I will write another patch for upgrade. - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, May 22, 2013 2:21:31 PM Subject: Re: [Engine-devel] for a few clicks less On 05/22/2013 03:19 PM, Laszlo Hornyak wrote: Hi, Today the default memory size when creating a VM is 512 MB, this is coming from the Blank template, which is not modifiable by user. This amount of memory is not enough for a installation for most Linux distros (and possibly for other mainstream OS either) so I think it would make sense to increase the default memory size to 1024 MB, for most users, it would save some time. This patch changes the memory size for new installations. http://gerrit.ovirt.org/14747 Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel makes sense to me. looking at the patch - worth handling upgrade as well? ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] how to let engine run scripts with root privilege
Hi, Do you need to run these scripts on the engine environment? Not VDSM? - Original Message - From: bigclouds bigclo...@163.com To: engine-devel engine-devel@ovirt.org Sent: Monday, May 20, 2013 5:44:38 PM Subject: [Engine-devel] how to let engine run scripts with root privilege hi, engine run as a normal user, but sometimes we need it to run scripts(start,stop services) which require root privilege. how to do that? thanks. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] SQL procedure - row mapper
Hi Sahina, Could you share more details what you are trying to do? A procedure always returns the same structure of data, so maybe it is more simple if you to return all the data you received from the plpgsql stored procedure and then just use the data mapped into the beans to build your own data structures. Laszlo - Original Message - From: Sahina Bose sab...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Friday, May 17, 2013 11:34:31 AM Subject: [Engine-devel] SQL procedure - row mapper Hi all, In org.ovirt.engine.core.dal.dbbroker.SimpleJdbcCallsHandler , there's a map maintained for procedure name and SimpleJdbcCall. If I have the same procedure with different row mappers, this results in an error - because the map already contains a mapping for the procedure name but with different row mapper. Do we intend to support calling the same procedure with different RowMappers? If so, I can change this class to handle this. thanks sahina ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] DB performance optimization
Hi Liran, Thanks for this patch, I have been asking for caching for a long while and I hope to see caching in the engine soon. Beyond the comments I have made to your patch, I have some questions about the idea just to start the discussion. So your cache solution is caching data based on SQL statements? What will the cache do if we query the same data with two different SQL statements? e.g. you can query from views like vms and sometimes we only query the vm_static and we should get the same vm_static. Also, how will you deal with updates? e.g. when you update the vm_static record, that vm_static record must be updated or invalidated but also the vm record from Thx, Laszlo - Original Message - From: Liran Zelkha lzel...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, May 13, 2013 10:40:31 AM Subject: [Engine-devel] DB performance optimization Hi all, There is a WIP for caching and DB performance optimization. Please look at - http://gerrit.ovirt.org/#/c/14188/4 To summarize, it includes automatic caching for some business entities (*_static for instance), break up of VDS to VDS_static, VDS_dynamic and VDS_statistics, and support for batch updates. Please share if/where you think batch updates can be used (for a usage scenario, please check InterfaceDaoDbFacadeImpl.massUpdateStatisticsForVds()). Future tasks will include update sensitivity, better Collection caching and trying to minimize getConnection() calls. Would love your comments and ideas. Thanks. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] some cleanup
Thank you Michael! - Original Message - From: Michael Kublin mkub...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, April 23, 2013 9:39:11 AM Subject: Re: [Engine-devel] some cleanup - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, April 22, 2013 8:27:00 PM Subject: [Engine-devel] some cleanup Hi, Some of my patches are waiting for a brave reviewer to +2 them :) - entity cleanups http://gerrit.ovirt.org/13531 http://gerrit.ovirt.org/13705 http://gerrit.ovirt.org/13940 http://gerrit.ovirt.org/13705 - command cleanups http://gerrit.ovirt.org/13945 http://gerrit.ovirt.org/13946 http://gerrit.ovirt.org/13947 Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel Done ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Starting a new translation
Hi Alex, We are doing translations on zanata. Sign up, add your languages to your profile and please send Einav the language you would like to translate, she will add it to the ovIrt project. https://translate.zanata.org/zanata/project/view/ovirt (A translations howto in the wiki is on my todo list) Laszlo - Original Message - From: Alex Ont alexont...@gmail.com To: engine-devel@ovirt.org Sent: Wednesday, April 17, 2013 11:27:41 AM Subject: [Engine-devel] Starting a new translation Hi, Trying to translate the userportal ... How should one obtain the English properties file to jumpstart the translation? e.g. There are ApplicationConstants_xxx.properties for already translated locales, but there is no English version. Thanks, Alex ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] How get all language WebAdm ?
- Original Message - From: 李强 liqiang@gmail.com To: aw...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, April 17, 2013 5:57:36 PM Subject: Re: [Engine-devel] How get all language WebAdm ? We should submit the bug to ovirt ? I think that maybe is config file error but I not be sure. Hi, No, it is maven-related. Maven ignores tests with -DskipTests but not with -Dskipte=true and then you do not have a test environment set up. It looks like a typo, not a bug :) HI：All 见信平安， --- 有问题请通知我，谢谢， 李强 -- + 太初有道，道与神同在，道就是神。(约翰福音1:1) + -- 2013/4/17 Alexander Wels aw...@redhat.com I am having the same error locally right now. Someone broke the unit tests, they should get fixed sooner or later. For now just skip the tests when building with -DskipTests On Wednesday, April 17, 2013 11:44:04 PM 李强 wrote: HI:All This is my logs, thanks, == --- T E S T S --- Forking command line: /bin/sh -c cd /home/liqiang/ovirt-engine/backend/manager/modules/dal /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.17.x86_64/jre/bin/java -jar /home/liqiang/ovirt-engine/backend/manager/modules/dal/target/surefire/surefirebooter4261523418572089603.jar /home/liqiang/ovirt-engine/backend/manager/modules/dal/target/surefire/surefire7472834543455719312tmp /home/liqiang/ovirt-engine/backend/manager/modules/dal/target/surefire/surefire5281802986683589703tmp Running org.ovirt.engine.core.dao.DaoFactoryTest Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.262 sec Running org.ovirt.engine.core.dal.job.ExecutionMessageDirectorTest 23:39:49,030 INFO [ExecutionMessageDirector] Start initializing ExecutionMessageDirector 23:39:49,032 ERROR [ExecutionMessageDirector] Message key job.AddDiskToVm is not valid for enum VdcActionType 23:39:49,033 INFO [ExecutionMessageDirector] Finished initializing ExecutionMessageDirector 23:39:49,033 INFO [ExecutionMessageDirector] Start initializing ExecutionMessageDirector 23:39:49,034 ERROR [ExecutionMessageDirector] Message key job.AddDiskToVm is not valid for enum VdcActionType 23:39:49,034 INFO [ExecutionMessageDirector] Finished initializing ExecutionMessageDirector 23:39:49,034 WARN [ExecutionMessageDirector] The message key Unknown is missing from bundles/ExecutionMessages 23:39:49,035 INFO [ExecutionMessageDirector] Start initializing ExecutionMessageDirector 23:39:49,036 ERROR [ExecutionMessageDirector] The message key XXX cannot be categorized since not started with job. nor step. 23:39:49,037 INFO [ExecutionMessageDirector] Finished initializing ExecutionMessageDirector 23:39:49,037 INFO [ExecutionMessageDirector] Start initializing ExecutionMessageDirector 23:39:49,039 ERROR [ExecutionMessageDirector] Message key job.ABC is not valid for enum VdcActionType 23:39:49,040 INFO [ExecutionMessageDirector] Finished initializing ExecutionMessageDirector 23:39:49,042 INFO [ExecutionMessageDirector] Start initializing ExecutionMessageDirector 23:39:49,044 ERROR [ExecutionMessageDirector] Message key step.XYZ is not valid for enum StepEnum 23:39:49,044 INFO [ExecutionMessageDirector] Finished initializing ExecutionMessageDirector Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec Running org.ovirt.engine.core.dal.dbbroker.generic.DBConfigUtilsTest 23:39:49,431 WARN [LocalConfig] The file /usr/share/ovirt-engine/conf/engine.conf.defaults doesn't exist or isn't readable. Will return an empty set of properties. 23:39:49,431 WARN [LocalConfig] The file /etc/ovirt-engine/engine.conf doesn't exist or isn't readable. Will return an empty set of properties. 23:39:49,432 ERROR [LocalConfig] The property ENGINE_DB_CONNECTION_TIMEOUT doesn't have a value. 23:39:49,433 WARN [DbFacadeLocator] Can't load connection checking parameters of DB facade, will continue using the default values. java.lang.IllegalArgumentException: The property ENGINE_DB_CONNECTION_TIMEOUT doesn't have a value. at org.ovirt.engine.core.utils.LocalConfig.getProperty(LocalConfig.java:234) at org.ovirt.engine.core.utils.LocalConfig.getInteger(LocalConfig.java:293) at org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.loadDbFacadeConfig(DbFacadeLocator.java:177) at org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.createDbFacade(DbFacadeLocator.java:62) at org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.getDbFacade(DbFacadeLocator.java:47) at org.ovirt.engine.core.dao.BaseDAOTestCase.initTestCase(BaseDAOTestCase.java:66) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Re: [Engine-devel] watchdog
- Original Message - From: Michal Skrivanek mskri...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 5:29:53 PM Subject: Re: [Engine-devel] watchdog On 11 Apr 2013, at 12:26, Yair Zaslavsky yzasl...@redhat.com wrote: - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 11:33:19 AM Subject: Re: [Engine-devel] watchdog Good that you have come up with this! So we will make sure to keep this info. Thnx for coming up with it! - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 10:25:28 AM Subject: Re: [Engine-devel] watchdog - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 10:02:16 AM Subject: Re: [Engine-devel] watchdog - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 9:56:32 AM Subject: Re: [Engine-devel] watchdog Hi, Isnt someone already working on removing the UI distinction between server and desktop? Indeed :) However the desktop/server distinction could be useful for scheduling information, I hope that will remain. There will be a combo box: optimized for server/desktop. That one will set up the dialog like you would open the new server/desktop today. But you will be able to change them - it will be just some sugar. But there is no reason why would we enforce the disabling the e.g. soundcard for server. By default we will, but you can enable it if you want. Ok, so in engine we will still have the VmType in vmStatic? I think it would make sense to use it in scheduling / load balancing - if a VM is a desktop and no user is connected to the console, then the VM is not in use, therefore it is a good candidate for saving power (hibernate, migrate, shutdown, or any other bad things that can happen to a VM) - if a VM is a server, usually no user connected, but it may still be used through its network. Therefore it may not be a good candidate to migrate. is this indeed a valid assumption (if VM is a server... ) that a user will less connect to it? IMHO if we want some new behavior/policy there should be a new corresponding property, not desktop/server. That can be quite misleading and I would rather see it go away. Other than use it as a set of default values Sure, let's call it something else, but this is a typical behavior expected from the desktop/server property. So what we are going to do is that remove the property and throw away all the related data, while when (if ever) we get the new property (behaveAsDesktop, notUsedWhenNotConnected, whatever we call it) the users of the system will set this property for the VM's that used to be desktops. We could save that work for the users. Also, it may appear to be an edge-case, but for a good scheduling in my opinion this is important. - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow acath...@redhat.com Sent: Wednesday, April 10, 2013 9:38:15 PM Subject: Re: [Engine-devel] watchdog On 04/10/2013 04:59 PM, Laszlo Hornyak wrote: Hi, A new version of the watchdög feature is available in gerrit: http://gerrit.ovirt.org/13057 - db http://gerrit.ovirt.org/13058 - bll http://gerrit.ovirt.org/13059 - frontend http://gerrit.ovirt.org/13060 - rest http://www.ovirt.org/Features/Watchdog_engine_support Since the last update the patchset has gone through major changes to meet the new architectureal and functional requirements. Also because of the rewrite this is again a preview version under testing with some missing functionality, therefore I re-introduced the [wip] flag on it. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel just a thought after looking at the feature page having different HA dialog for server/desktop - I'd consider removing the distinction between desktop and server in the GUI wrt HA (i.e., just both have same set of options) (not blocking for this patch) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] watchdog
Hi, Isnt someone already working on removing the UI distinction between server and desktop? However the desktop/server distinction could be useful for scheduling information, I hope that will remain. - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow acath...@redhat.com Sent: Wednesday, April 10, 2013 9:38:15 PM Subject: Re: [Engine-devel] watchdog On 04/10/2013 04:59 PM, Laszlo Hornyak wrote: Hi, A new version of the watchdög feature is available in gerrit: http://gerrit.ovirt.org/13057 - db http://gerrit.ovirt.org/13058 - bll http://gerrit.ovirt.org/13059 - frontend http://gerrit.ovirt.org/13060 - rest http://www.ovirt.org/Features/Watchdog_engine_support Since the last update the patchset has gone through major changes to meet the new architectureal and functional requirements. Also because of the rewrite this is again a preview version under testing with some missing functionality, therefore I re-introduced the [wip] flag on it. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel just a thought after looking at the feature page having different HA dialog for server/desktop - I'd consider removing the distinction between desktop and server in the GUI wrt HA (i.e., just both have same set of options) (not blocking for this patch) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] watchdog
- Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 10:02:16 AM Subject: Re: [Engine-devel] watchdog - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 9:56:32 AM Subject: Re: [Engine-devel] watchdog Hi, Isnt someone already working on removing the UI distinction between server and desktop? Indeed :) However the desktop/server distinction could be useful for scheduling information, I hope that will remain. There will be a combo box: optimized for server/desktop. That one will set up the dialog like you would open the new server/desktop today. But you will be able to change them - it will be just some sugar. But there is no reason why would we enforce the disabling the e.g. soundcard for server. By default we will, but you can enable it if you want. Ok, so in engine we will still have the VmType in vmStatic? I think it would make sense to use it in scheduling / load balancing - if a VM is a desktop and no user is connected to the console, then the VM is not in use, therefore it is a good candidate for saving power (hibernate, migrate, shutdown, or any other bad things that can happen to a VM) - if a VM is a server, usually no user connected, but it may still be used through its network. Therefore it may not be a good candidate to migrate. - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow acath...@redhat.com Sent: Wednesday, April 10, 2013 9:38:15 PM Subject: Re: [Engine-devel] watchdog On 04/10/2013 04:59 PM, Laszlo Hornyak wrote: Hi, A new version of the watchdög feature is available in gerrit: http://gerrit.ovirt.org/13057 - db http://gerrit.ovirt.org/13058 - bll http://gerrit.ovirt.org/13059 - frontend http://gerrit.ovirt.org/13060 - rest http://www.ovirt.org/Features/Watchdog_engine_support Since the last update the patchset has gone through major changes to meet the new architectureal and functional requirements. Also because of the rewrite this is again a preview version under testing with some missing functionality, therefore I re-introduced the [wip] flag on it. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel just a thought after looking at the feature page having different HA dialog for server/desktop - I'd consider removing the distinction between desktop and server in the GUI wrt HA (i.e., just both have same set of options) (not blocking for this patch) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] watchdog
No what I meant is that
if the VM is a server {
not having a console connection to it does not mean that it is not used.
}
Therefore desktops on the same host with no console connection, they may be
better candidates for migration. You can connect to servers.
- Original Message -
From: Yair Zaslavsky yzasl...@redhat.com
To: Tomas Jelinek tjeli...@redhat.com
Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel
engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 12:26:35 PM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Tomas Jelinek tjeli...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 11:33:19 AM
Subject: Re: [Engine-devel] watchdog
Good that you have come up with this! So we will make sure to keep this
info.
Thnx for coming up with it!
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Tomas Jelinek tjeli...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 10:25:28 AM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Tomas Jelinek tjeli...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 10:02:16 AM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Itamar Heim ih...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 9:56:32 AM
Subject: Re: [Engine-devel] watchdog
Hi,
Isnt someone already working on removing the UI distinction between
server
and desktop?
Indeed :)
However the desktop/server distinction could be useful for scheduling
information, I hope that will remain.
There will be a combo box: optimized for server/desktop. That one
will set up the dialog like you would open the new server/desktop
today.
But you will be able to change them - it will be just some sugar. But
there
is no reason
why would we enforce the disabling the e.g. soundcard for server. By
default
we will, but
you can enable it if you want.
Ok, so in engine we will still have the VmType in vmStatic?
I think it would make sense to use it in scheduling / load balancing
- if a VM is a desktop and no user is connected to the console, then the
VM
is not in use, therefore it is a good candidate for saving power
(hibernate,
migrate, shutdown, or any other bad things that can happen to a VM)
- if a VM is a server, usually no user connected, but it may still be
used
through its network. Therefore it may not be a good candidate to migrate.
is this indeed a valid assumption (if VM is a server... ) that a user will
less connect to it?
- Original Message -
From: Itamar Heim ih...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow
acath...@redhat.com
Sent: Wednesday, April 10, 2013 9:38:15 PM
Subject: Re: [Engine-devel] watchdog
On 04/10/2013 04:59 PM, Laszlo Hornyak wrote:
Hi,
A new version of the watchdög feature is available in gerrit:
http://gerrit.ovirt.org/13057 - db
http://gerrit.ovirt.org/13058 - bll
http://gerrit.ovirt.org/13059 - frontend
http://gerrit.ovirt.org/13060 - rest
http://www.ovirt.org/Features/Watchdog_engine_support
Since the last update the patchset has gone through major changes
to
meet
the new architectureal and functional requirements.
Also because of the rewrite this is again a preview version under
testing
with some missing functionality, therefore I re-introduced the
[wip]
flag
on it.
Thx,
Laszlo
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
just a thought after looking at the feature page having different
HA
dialog for server/desktop - I'd consider removing the distinction
between desktop and server in the GUI wrt HA (i.e., just both have
same
set of options)
(not blocking for this patch)
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing
[Engine-devel] watchdog
Hi, A new version of the watchdög feature is available in gerrit: http://gerrit.ovirt.org/13057 - db http://gerrit.ovirt.org/13058 - bll http://gerrit.ovirt.org/13059 - frontend http://gerrit.ovirt.org/13060 - rest http://www.ovirt.org/Features/Watchdog_engine_support Since the last update the patchset has gone through major changes to meet the new architectureal and functional requirements. Also because of the rewrite this is again a preview version under testing with some missing functionality, therefore I re-introduced the [wip] flag on it. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Move SQL out of stored procedures
- Original Message - From: Eli Mesika emes...@redhat.com To: engine-devel@ovirt.org Sent: Monday, April 1, 2013 11:35:03 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Libor Spevak lspe...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org Sent: Thursday, March 28, 2013 5:31:34 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures - Original Message - From: Libor Spevak lspe...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org Sent: Thursday, March 28, 2013 4:04:20 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures Hi, apart from SQL vs. stored procedures discussion, I am trying to understand what we can get if we support more databases... Sorry for joining this discussion so late (I was in a vacation) anyway two points missing from SQL VS. SP are 1) security - With plain SQL we will have to handle SQL Injection I do not understand this. What's wrong with PreparedStatement? 2) It is more economic to pass a call to SP than the full SQL on the wire... Ah that is not actually happening with postgresql :) I don't know about all the specific DB's but I am quite sure most other DB does not do that either. If you have a DataSource, like commons-dbcp, it is caching the PreparedStatements in the background. A PreparedStatement executes a 'PREPARE' command in postgresql http://www.postgresql.org/docs/9.2/static/sql-prepare.html After that it will only send over the name of the query plan and the parameters. I believe it usually does not save a lot on bandwidth, for example engine's SQL statements fit in a single tcp/ip frame, but the query parser and planner needs to run only once, when you create the query plan and that is a big win. I wrote a testfor this once, quite long ago but I remember something around 10% win if the query execution was simple enough. But of course it does not matter much if you have a pile of seqscan in your query plan. Anyway, this is kind of cool in PostgreSQL :) Some points: 1. Is there a real need by end-users/customers to run it on e.g. Oracle only? (performance, stability, easier administration). Usually companies have one database and they are trying to stick to that one. Having two doubles the resource needs, you need one more DBA team, care for mirrors, backups. So it almost doubles the costs. Generally, I agree with Alon B L , if you have to support X DBs you are not doubling the effort by X Actually, we had already experience with that when we supported both MS SQL Postgres I believe that as we have some customers with large installations, performance counts and the best way (and sometimes teh only way) id the DB layer Ok, then let's tell MySQL/MariaDB users to use PostgerSQL and see what happens. This is why I frequently hear people asking if we plan to support XyDB in the future. PostgreSQL is cool, but those who already use MySQL/MariaDB, they just do not want one more. What is the future of PostgreSQL? 2. Is it decided by architectural board, what kind of databases we would like to support? (cannot support any db) With a JPA we could support most mainstream relational databases, but in my opinion 99 percent of people run oracle, mysql/mariadb or postgresql. So maybe we do not have to think in big number of database engines. This is theoretical since JPA is still on wishlist :( 3. Are we talking about the Engine only, or there will be a need to rewrite ETL mappings and upgrade DWH database, or maybe modify JasperReports templates (simply, some DB types behave differently)? Maybe we can look at JasperSoft solution, they support more databases. IMHO , ETL DWH are perfect candidates for NO SQL which is already supported by Jasper 4. Current full/incremental upgrade process of PostgreSQL is IMHO very good tuned (it is similar to dbmaintain.org tool - Java implementation - I used successfully on one project - after some changes of course). I do not believe we can use or easily develop general upgrade/migration tool, and XML based (I am sorry Alissa, not sure about Liquibase, I haven't studied it deeply, but there is a need to incrementally change db objects, but sometimes also to migrate data to new structures, the most flexible and quickest is to do it using native SQL, but yes, it depends on the project needs...). I had evaluated Liquibase and I think that managing your DB upgrades via XML is very unfriendly and very limited as you reach complex upgrades as we had in the past. Just think of the tables in which we change the key from long to UUID , there is no way to do that in such tools 5. As a developer
Re: [Engine-devel] Move SQL out of stored procedures
Hi Liran, - Original Message - From: Liran Zelkha liran.zel...@gmail.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Liran Zelkha lzel...@redhat.com, engine-devel@ovirt.org Sent: Tuesday, April 2, 2013 8:37:28 AM Subject: Re: [Engine-devel] Move SQL out of stored procedures Hi Laszlo, I'm currently in the process of adding a caching layer on top of JdbcTemplate, which would greatly reduce the number of database activities we have, so that would solve the last item you raised. That's a great news! Thank you! I didn't mean the ORM performance is caused by the mapping. I think the problem lies in the fact that we will modify our code to have batch updates for most insert activities - a thing that is impossible in JPA/Hibernate. So, if we'll have some code in SQL and some in ORM - I prefer we stick all code to SQL… I think you can do this with a JPAQL in JPA, but anyway, yes, some code would very likely have to be in rdbms-specific SQL statements. On Apr 2, 2013, at 9:34 AM, Laszlo Hornyak wrote: Hi Liran, I agree that ORM tools in general have to add some mapping overhead, but that overhead is very small compared to the time needed by the database interaction. ORM tools sometimes generate SQL statements that we could imagine being better, I do not think they are as hard for the DB as for example the ones generated by searchbackend. Also, we can do rdbms specific optimizations when needed. Plus we could finally have some caching in ovirt engine and the code would not have to read e.g. the DC record again and again. There are some more like that. Therefore having a JPA could improve the performance in engine. Laszlo - Original Message - From: Liran Zelkha lzel...@redhat.com To: Eli Mesika emes...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, April 2, 2013 7:24:08 AM Subject: Re: [Engine-devel] Move SQL out of stored procedures I also apologize for jumping in late... I think concerning SQL injection we'll be covered by using PreparedStatements. Since we're using SpringJDBC, most of our code uses PreparedStatements anyway. Concerning ORM - I feel it won't really be beneficial to us. I know of very few projects who can actually be cross-database, and just maintaining schema creation scripts for different databases can be too difficult to maintain. Also, from a performance perspective, ORM performs worse than regular SQL (or stored procedures), so it wouldn't be the direction I choose. I think we should keep using SpringJDBC with either SQL or stored procedures (doesn't really matter, whatever is easier to maintain and performs faster) and maybe add a better, more generic, RowMapper class. - Original Message - From: Eli Mesika emes...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, April 2, 2013 12:35:03 AM Subject: Re: [Engine-devel] Move SQL out of stored procedures - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Libor Spevak lspe...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org Sent: Thursday, March 28, 2013 5:31:34 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures - Original Message - From: Libor Spevak lspe...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org Sent: Thursday, March 28, 2013 4:04:20 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures Hi, apart from SQL vs. stored procedures discussion, I am trying to understand what we can get if we support more databases... Sorry for joining this discussion so late (I was in a vacation) anyway two points missing from SQL VS. SP are 1) security - With plain SQL we will have to handle SQL Injection 2) It is more economic to pass a call to SP than the full SQL on the wire... Some points: 1. Is there a real need by end-users/customers to run it on e.g. Oracle only? (performance, stability, easier administration). Usually companies have one database and they are trying to stick to that one. Having two doubles the resource needs, you need one more DBA team, care for mirrors, backups. So it almost doubles the costs. Generally, I agree with Alon B L , if you have to support X DBs you are not doubling the effort by X Actually, we had already experience with that when we supported both MS SQL Postgres I believe that as we have some customers with large installations, performance counts and the best way (and sometimes teh only way) id the DB layer This is why I frequently hear people asking if we plan to support XyDB in the future. PostgreSQL is cool, but those who already use MySQL/MariaDB, they just do not want one more. What is the future of PostgreSQL? 2. Is it decided by architectural board, what kind of databases we
Re: [Engine-devel] Move SQL out of stored procedures
- Original Message - From: Libor Spevak lspe...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org Sent: Thursday, March 28, 2013 4:04:20 PM Subject: Re: [Engine-devel] Move SQL out of stored procedures Hi, apart from SQL vs. stored procedures discussion, I am trying to understand what we can get if we support more databases... Some points: 1. Is there a real need by end-users/customers to run it on e.g. Oracle only? (performance, stability, easier administration). Usually companies have one database and they are trying to stick to that one. Having two doubles the resource needs, you need one more DBA team, care for mirrors, backups. So it almost doubles the costs. This is why I frequently hear people asking if we plan to support XyDB in the future. PostgreSQL is cool, but those who already use MySQL/MariaDB, they just do not want one more. What is the future of PostgreSQL? 2. Is it decided by architectural board, what kind of databases we would like to support? (cannot support any db) With a JPA we could support most mainstream relational databases, but in my opinion 99 percent of people run oracle, mysql/mariadb or postgresql. So maybe we do not have to think in big number of database engines. This is theoretical since JPA is still on wishlist :( 3. Are we talking about the Engine only, or there will be a need to rewrite ETL mappings and upgrade DWH database, or maybe modify JasperReports templates (simply, some DB types behave differently)? Maybe we can look at JasperSoft solution, they support more databases. 4. Current full/incremental upgrade process of PostgreSQL is IMHO very good tuned (it is similar to dbmaintain.org tool - Java implementation - I used successfully on one project - after some changes of course). I do not believe we can use or easily develop general upgrade/migration tool, and XML based (I am sorry Alissa, not sure about Liquibase, I haven't studied it deeply, but there is a need to incrementally change db objects, but sometimes also to migrate data to new structures, the most flexible and quickest is to do it using native SQL, but yes, it depends on the project needs...). 5. As a developer, with every new column I need to write upgrade scripts, prepare test environments and test all scenarios several times on different databases, so time-consuming. On 27.3.2013 13:53, Itamar Heim wrote: On 03/26/2013 08:39 PM, Alon Bar-Lev wrote: - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, March 26, 2013 7:34:04 PM Subject: [Engine-devel] Move SQL out of stored procedures Hello, I would like to start a discussion about the subject. I think this is something we need to do if one day we want to be able to use any database other than PostgreSQL. Hello, I think that database layer is a software interface like any other software interface, if done properly, a dba can convert the stored procedure to any other database without any code change. This way the database specific implementation lives within the database and maintained by the designated dba. Fixups and optimizations can be done in database without touching the code. Backward compatibility layer is much simpler to implement based on stored procedures than complex set of views and tables. Also, accessing the database via different technologies is simpler if there is maintained database interface (stored procedures). I've seen hibernate based java applications that promised to be database independent but at the edges when performance counts, the DAO became HQL, then a special dialect and finally database specific SQLS. there may be db specific optimization/logic, but I don't see why we need STPs for 80% (if not more) of the CRUD and basic queries. I also agree with Tal later in the thread that its a good question if we can't find a better solution than re-writing the sql's in the code ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Move SQL out of stored procedures
Hi, I agree with the idea. The stored procedures/UDF's are just one more place to go when trying to find out what is really happening. It is not a good solution for database portability. Laszlo - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, March 26, 2013 6:34:04 PM Subject: [Engine-devel] Move SQL out of stored procedures Hello, I would like to start a discussion about the subject. I think this is something we need to do if one day we want to be able to use any database other than PostgreSQL. I did an small example of what it takes and how it looks like to have the SQL code into the DAOs: http://gerrit.ovirt.org/13347 It isn't rocket science, it isn't an exciting task, it isn't fun, but something I think we should eventually do. I appreciate any comment about how and when to do this, including those saying that instead of this primitive approach we should use this or that ORM framework. Regards, Juan Hernandez -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] watchdog patchset
Hi, The watchdog patch was broken down into a patchset: http://gerrit.ovirt.org/13057 http://gerrit.ovirt.org/13058 http://gerrit.ovirt.org/13059 http://gerrit.ovirt.org/13060 You are welcome to review it, it is working, however due to internal changes it is being completely rewritten. Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] engine watchdog support - new version in gerrit
hi, A new version of the engine watchdog support is available in gerrit. This version finished the rest-api support by adding the capabilities resources. The features listed in the feature page are ready, so if you have enough time and courage, please give it a try! I have left the patch with [wip] because I am waiting for the end of some discussions about the technical background. http://gerrit.ovirt.org/#/c/12419/ Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] VmDynamic kvm_enable
Hi, I came across a VmDynamic property 'kvm_enable'. It sounds strange for me, because ovirt is very colsely integrated with kvm. So a short dig into this flag... There is a similar thing for the VDS, it is set to true by vdsm is the host CPU has a VT flag. It is actually used to check if the host is OK to run VMS. But the one for Vm it looks like a distributed logical loop in vdsm: it is set when constructing a VM object (vdsm/vm.py:~343) from the data sent by the client (engine) and then reported back in vm stats, so it is just a roundtrip between vdsm and it's client. In the engine side, it is just keeps sending it between the frontend DB and vdsm, never part of a decision. Is this still needed here? Can I remove? VDSM guys? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] VDSM: make rpm is failing.
Hi Sharad, There is an update pep8 that you have to use when compiling vdsm, that may be the problem. See http://wiki.ovirt.org/Vdsm_Developers (however this document is frequently outdated) - Original Message - From: snmis...@linux.vnet.ibm.com To: engine-devel@ovirt.org Sent: Wednesday, March 6, 2013 10:48:17 PM Subject: [Engine-devel] VDSM: make rpm is failing. Hi, Using latest VDSM source, I see make rpm failing bunch on tests. Running with 'NOSE_EXCLUDE=.*' I see the following error - -- Ran 0 tests in 0.081s OK make[4]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/tests' make[3]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/tests' make[2]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/tests' Making check in vdsm-tool make[2]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.3/vdsm-tool' make[2]: Nothing to be done for `check'. make[2]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/vdsm-tool' Making check in vdsm_api make[2]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.3/vdsm_api' make[2]: Nothing to be done for `check'. make[2]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/vdsm_api' Making check in yajsonrpc make[2]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.3/yajsonrpc' make[2]: Nothing to be done for `check'. make[2]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3/yajsonrpc' make[2]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.3' make check-local make[3]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.3' find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes ./vdsm/storage/lvm.py:608: list comprehension redefines 'lv' from line 603 make[3]: *** [check-local] Error 123 make[3]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3' make[2]: *** [check-am] Error 2 make[2]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3' make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory `/root/rpmbuild/BUILD/vdsm-4.10.3' error: Bad exit status from /var/tmp/rpm-tmp.pay1sz (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.pay1sz (%check) make: *** [rpm] Error 1 ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] ovirtbot wiki activity noise
Maybe not too many compared to the whole traffic of the irc channel, but there is very little interest in these messages. Also, when I edit a page, it tells my name in the IRC channel, and my irc client is set to notify me when that happens. While most of us use this to get notification if someone needs some info fro us (important) this notification is quite unimportant. - Original Message - From: Dave Neary dne...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, March 5, 2013 3:41:05 PM Subject: Re: [Engine-devel] ovirtbot wiki activity noise Do you think there are too many? I don't find it annoying personally (except when we approve users, because that causes 4 wiki messages for one event). Cheers, Dave. On 03/05/2013 02:49 PM, Laszlo Hornyak wrote: Hi, Anyone needs ovirtbot in #ovirt to log the page edits on the ovirt wiki? Maybe it was better when it did not :) Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- Dave Neary - Community Action and Impact Open Source and Standards, Red Hat - http://community.redhat.com Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13 ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] how to setup development env.
Hi Chenchao, Basically with eclipse you should have the m2e plugin or you can use the `mvn eclipse:eclipse` command to generate eclipse project descriptors. I would recommend the m2e plugin, it is really good quality and it is included in most recent eclipse distributions. You find the build instructions here: http://www.ovirt.org/Building_oVirt_engine If you are also working with the gwt frontend, I would also recommend this page: http://www.ovirt.org/DebugFrontend Best regards, Laszlo - Original Message - From: 陈超 cc272309...@gmail.com To: engine-devel engine-devel@ovirt.org Sent: Monday, February 25, 2013 11:15:24 AM Subject: [Engine-devel] how to setup development env. Hi, all I have setup the project with eclipse successfully.but how should I build the project with eclipse? And when I change the code,how should I run up the test class? And Is there any document about the relationship among those maven modul project ? chenchao thanks. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Changing Gerrit -1 message
Hi, I agree with that. for the - messages this in my opinion would be both more clear and friendly: -1: In my opinion it needs work. -2: I disagree. - Original Message - From: Ofer Schreiber oschr...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, February 19, 2013 10:51:15 AM Subject: [Engine-devel] Changing Gerrit -1 message I feel that the current -1 I would prefer that you didn't submit this message in Gerrit is pretty rude, as usually those -1 reviews are just small fix-ups in the code itself. Any thoughts about a more suitable -1 message? I thought about -1 Please fix your code or something similar. Thanks, Ofer Schreiber ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Watchdog support Feature
Hi Doron, If the watchdog is set to action=reset and you break the kernel, the VM will stay in UP state while waiting for the watchdog to reset the VM, and will still be in UP state while rebooting. So in theory engine will not be notified about a crash. This behavior is different when the action=poweroff because the watchdog will really put the VM in a Down state and it is engine's job to restart it if HA as soon as it receives the notification from VDSM. - Original Message - From: Doron Fediuck dfedi...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Sunday, February 10, 2013 4:40:29 PM Subject: Re: [Engine-devel] Watchdog support Feature Hi Laszlo, Looks very useful. Any thoughts on what engine will do while if the VM is defined as HA while the watchdog is resetting it? - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Wednesday, February 6, 2013 11:25:03 AM Subject: Re: [Engine-devel] Watchdog support Feature Hi everyone, I hope everyone is satisfied with the spec, please read it through for the last time and I will move it to implementation phase soon. Thx, Laszlo - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, January 24, 2013 3:19:57 PM Subject: Watchdog support Feature Hi, Watchdog support in engine will add watchdog to the ovirt UI and REST API. Watchdog cards will be mainly used in HA vm's. http://www.ovirt.org/Features/Watchdog_engine_support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Watchdog support Feature
Hi everyone, I hope everyone is satisfied with the spec, please read it through for the last time and I will move it to implementation phase soon. Thx, Laszlo - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, January 24, 2013 3:19:57 PM Subject: Watchdog support Feature Hi, Watchdog support in engine will add watchdog to the ovirt UI and REST API. Watchdog cards will be mainly used in HA vm's. http://www.ovirt.org/Features/Watchdog_engine_support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] cleanup patch review needed
Hi, I need someone to review this patch http://gerrit.ovirt.org/#/c/11351/ Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Time for Spring?
I have seen a CDI patch from Roy that may be related to the topic. I do not know what the general direction is. CDI is more standard, while it's implementations for me look heavy weight and difficult to port to small containers like tomcat or jetty. In general, now we only inject the Backend deathstar bean to wherever it is needed and then it is used as registry for other service objects and DAOs. With spring dependency injection, we could be more independent from the container, since the ioC container is comming with us to the app container. But at the other hand, ovirt is a nice big ear app, so how would you put it together as a spring app? What changes would this need? Laszlo - Original Message - From: Libor Spevak lspe...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 29, 2013 11:42:35 AM Subject: [Engine-devel] Time for Spring? Hi, it is rather cold in Europe, but can I ask, what's the current opinion or plans about full integration of Spring Framework into oVirt engine (Backend)? This is a commonly accepted integration framework among Java programmers and industry standard, which solves many pains from small to large projects. And can lead to a better understanding of the program. There are several Spring dependencies inside oVirt project, but mostly for LDAP and database communication (JDBC template). Still missing (sorry, looks like marketing, but..): - dependency injection - aspect-oriented programming (AOP) - enterprise integration patterns Is something true? :-) 1. We tried, but it is too large and overcomplicated, it can be solved better way for the project purpose 2. We tried, but we think, we need just e.g. JDBC, LDAP layer covered now 3. We would like to integrate with e.g. Hibernate soon, EJB, remoting, unit tests, integration tests, ... , probably we will need it soon 4. We understand and need dependency injection, but there are other light DI containers (Pico, Guice, JBoss Seam). etc. Still, I think there is strong potential, probably not clear today. We cannot avoid Guice on frontend side because of GWTP, but the backend lacks something. Or not? Thanks. Regards, Libor ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Guid NGuid
- Original Message - From: Michael Kublin mkub...@redhat.com To: engine-devel@ovirt.org Sent: Monday, February 4, 2013 8:47:29 AM Subject: Re: [Engine-devel] Guid NGuid - Original Message - From: Roy Golan rgo...@redhat.com To: engine-devel@ovirt.org Sent: Monday, February 4, 2013 9:18:21 AM Subject: Re: [Engine-devel] Guid NGuid On 02/03/2013 03:19 PM, Alon Bar-Lev wrote: - Original Message - From: Omer Frenkel ofren...@redhat.com To: Michael Kublin mkub...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Sunday, February 3, 2013 3:12:19 PM Subject: Re: [Engine-devel] Guid NGuid - Original Message - From: Michael Kublin mkub...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Sunday, February 3, 2013 3:10:14 PM Subject: [Engine-devel] Guid NGuid Hi, In ovirt-engine code we have Guid and NGuid objects. Guid is extends NGuid and also NGuid class has method getValue() which should return Guid. As for me these two classes are look like the same and I don't see to much differences between them. My proposal is to remove NGuid and move it functionality to Guid (Because of Guid is much more common) i agree, but we need to take another step forward and allow Guid to be null (as it should) and not assume its EMPTY or have a value (i'm pretty sure we have this assumption in many places) Hi, And for the new people out here... why not kill both and use plain standard java UUID[1]? +1 for using java.util.UUID NGuid functionality that should be extracted during the refactor is - 1. refactor DB and Java so empty or null return values are null and not EMPTY_GUID 2. the special constructor of NGuid for UUID return by Microsoft AD should be extracted to a factory/utility I think we should kill compat, I don't see any value in fixing anything about it while leaving it intact. Regards, Alon Bar-Lev. [1] http://docs.oracle.com/javase/6/docs/api/java/util/UUID.html Actually there is exists one reason not to use directly UUID at server side. The main operations on Guid today it is to convert object to Guid or Guid to string. Guid it is immutable object, number of Guids is limited and almost never changed, These sound like classical case for object that can be cached. Benefit - reduced number of string manipulations, reduced number of created instances, less work for garbage collection UUID has the same properties, it is immutable. So you could do the same with UUID, but I am not sure you could effectively cache these objects and prove that you are saving either CPU, heap, or GC time. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] oVirt 3.2 test-day
Hi, I will participate and help users with SLA-related questions. - Original Message - From: Moran Goldboim mgold...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 29, 2013 12:30:40 AM Subject: [Engine-devel] oVirt 3.2 test-day we were supposed to have test day tomorrow, but we decided to push it to Thursday (Jan 31) to have ovirt-node and proper infra for test day (Mike should announce it's officially soon). I have refreshed http://www.ovirt.org/Testing/OvirtTestDay, but there is action from your part as well: -go over the scenarios (regressions), see if those relevant, add more if needed remove if not. -add basic tests for your new 3.2 features. -assign a contributor to be actively present on helping users on his area -make commitment and participate the test day I would like to review this document by Wednesday on users meeting, please make sure your part is updated by than. Thanks, Moran. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Instance Types Feature
A hidden feature is a not existing feature :) - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, January 30, 2013 8:30:26 AM Subject: Re: [Engine-devel] Instance Types Feature Of course after introducing the instance type in ovirt, you will still have control over the instance types and create any instance type you like beyond the pre-defined types you have in public cloud, but you will have two things to set: the instance type and the image, which is more administration... You will still have the templates - you will be able to choose a template which defines both. But it will be hidden in advanced part of the dialog. You are right, the simple way is pretty much inspired by public clouds, because they do great job in making the things easy. You basically just say you want a small machine and attach a rhel image to it. Other advantage of separating the HW and SW configuration is that you can just change the HW profile (instance type) on which you are running, or, if the instance type changes, it gets reflected in all machines using this instance type. This is why I think keeping the template as an entity composed out of an image and a instance type would be great. yep, it seems we will keep it :) It just will be hidden in the advanced options (e.g. one more click). Sounds reasonable? - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, January 28, 2013 12:16:00 PM Subject: Re: [Engine-devel] Instance Types Feature hi, This is what I thought of: In public clouds it is common to have pre-defined instance types e.g. amazon small/medium/large/x-large instance, and this is what customers get even if they don't like it. I guess this helps Amazon a lot to simplify the decision logic for vm scheduling and pricing. In a private cloud, you choose the resources your application needs, therefore you can choose just as much as you need. Of course after introducing the instance type in ovirt, you will still have control over the instance types and create any instance type you like beyond the pre-defined types you have in public cloud, but you will have two things to set: the instance type and the image, which is more administration than just working with templates, while most of the cases the templates were enough: you created both the OS image and the virtual hardware profile it is running on. For another image and another workload, I would most likely want to create another one that just fits the needs. This is why I think keeping the template as an entity composed out of an image and a instance type would be great. Laszlo - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Friday, January 25, 2013 1:32:20 PM Subject: Re: [Engine-devel] Instance Types Feature Hi Laszlo, it is not useful just for public clouds - it can be pretty useful for private as well. But to keep the previous way, it could be done this way: - on the advanced screen (after clicking show advanced options you can specify the template) - by default you pick on basic view the instance type (e.g. HW profile) and the Image (e.g. disk with some metadata such as OS type). But, you can select custom instance type (equivalent to blank template) and no Image. In this case the template appears also on basic view and you can select it. What do you think? Tomas - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, January 22, 2013 7:16:32 PM Subject: Re: [Engine-devel] Instance Types Feature Hi Tomas, I like the idea in general, but for me the instance types looks like a feature that is typical in public clouds, while in private clouds it looks more like a cool extra feature for special cases. Therefore in my opinion it would be great to keep the old template solution as well to keep it simple for most users. A template could be an instance type and an image together. Only the description overlap, and that could be solved. Thanks, Laszlo - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 22, 2013 3:09:51 PM Subject: [Engine-devel] Instance Types Feature Hi All, this is the proposed new feature called instance types: http://www.ovirt.org/Features/Instance_Types Long story short - it should basically split the VM template into: - hardware profile called instance types - software profile called image This should enable to do something like: Create a new small VM
Re: [Engine-devel] Watchdog support Feature
- Original Message - From: Dave Allan dal...@redhat.com To: Doron Fediuck dfedi...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, January 29, 2013 2:42:42 PM Subject: Re: [Engine-devel] Watchdog support Feature On Tue, Jan 29, 2013 at 08:06:44AM -0500, Doron Fediuck wrote: - Original Message - From: Dave Allan dal...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Monday, January 28, 2013 7:23:25 PM Subject: Re: [Engine-devel] Watchdog support Feature On Fri, Jan 25, 2013 at 08:34:27AM -0800, Itamar Heim wrote: On 24/01/2013 06:19, Laszlo Hornyak wrote: Hi, Watchdog support in engine will add watchdog to the ovirt UI and REST API. Watchdog cards will be mainly used in HA vm's. http://www.ovirt.org/Features/Watchdog_engine_support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel looks like a nice, simple, addition. dave, anyone more intimate with the watchdog worth giving another look? I had a look at the ovirt feature page and asked some libvirt folks as well, and it all looks good to me except that the libvirt documentation says that an event when watchdog fires will be added in the future. That event has been added. The watchdog should work pretty much identically to the physical world: configure the virtual watchdog card in the guest hardware description and install the watchdog daemon in the guest. Dave Thanks Dave. Do you happen do know why the shutdown action is not recommended? Yes--it requires guest cooperation which it's unlikely to get if the guest has gotten into a state where the watchdog fires. Dave Yep, the guest kernel should handle an ACPI signal. I don't know in what circumstances would that work, but vdsm does not support it either, so that decision is already made. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
- Original Message -
From: Juan Hernandez jhern...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Tuesday, January 29, 2013 5:41:13 PM
Subject: Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
On 01/29/2013 04:52 PM, Alon Bar-Lev wrote:
- Original Message -
From: Juan Hernandez jhern...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Tuesday, January 29, 2013 5:44:33 PM
Subject: Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
On 01/21/2013 09:45 AM, Michael Pasternak wrote:
On 01/21/2013 10:28 AM, Omer Frenkel wrote:
- Original Message -
From: Yair Zaslavsky yzasl...@redhat.com
To: Michael Pasternak mpast...@redhat.com
Cc: Juan Hernandez jhern...@redhat.com,
engine-devel@ovirt.org
Sent: Monday, January 21, 2013 8:27:36 AM
Subject: Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
- Original Message -
From: Michael Pasternak mpast...@redhat.com
To: Juan Hernandez jhern...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Sunday, January 20, 2013 3:24:58 PM
Subject: Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
On 01/17/2013 01:04 PM, Juan Hernandez wrote:
Once 3.2.0 is released I think we should move to
3.3.0-SNAPSHOT
in
the master branch:
+1
I agree, and this is not the only place where should start
marking
and cluster compatibility version..
all above is true, but Juan meant preparing MVN infra for the
next
development iteration, while you're talking about engine
internals,
maybe we should file BZs on that (as next version tasks) or
should
we
define new process of preparing for the next version that will
include both?
As I don't see hard opposition to this change I will merge it
tomorrow.
Please raise your hand iif you think it shouldn't be merged.
http://gerrit.ovirt.org/11143
For the poms, why didn't you use a variable that is inherited? But
Java is not my domain.
Maven doesn't support use of variables in any of the coordinates of
the
artifacts or of their parents. If you use variables, specially if you
use them in the version of the parent project and the variable is
inherited from the parent project, there is no way to determine which
version of the parent project should be used.
That's correct, but you can set the version numbers of the ovirt artifacts to
${parent.version}. But let's do it in a next patch, we already spent enough
time on this :) Merge!
Tarball should be ovirt-engine-3.3.0_master.tar.gz
RPM release should be ovirt-engine-3.3.0-0.0.master
This will enable us to release milestones, such as beta1, beta2,
rc1, rc2 and finally release without suffix.
--
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat
S.L.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Watchdog support Feature
Hi, Watchdog support in engine will add watchdog to the ovirt UI and REST API. Watchdog cards will be mainly used in HA vm's. http://www.ovirt.org/Features/Watchdog_engine_support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Watchdog support Feature
Hi Yair, - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, January 24, 2013 5:01:28 PM Subject: Re: [Engine-devel] Watchdog support Feature - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, January 24, 2013 4:19:57 PM Subject: [Engine-devel] Watchdog support Feature Hi, Watchdog support in engine will add watchdog to the ovirt UI and REST API. Watchdog cards will be mainly used in HA vm's. http://www.ovirt.org/Features/Watchdog_engine_support Your feedback is welcome! Although I'm sure you're aware of it - I'm reminding you that you should handle backward compatibility for this feature - So you should have an entry at vdc_options for this + use the FeatureEnabled infra Good point, thx! Regarding the action types at db - I would suggest sticking to varchar. Well, at the moment all enums are stored as int, so varchar too will be something new. Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] default Vm memory size
Hi, The default Vm size is 512 MB now. I think A bit more could be useful, e.g. a fedora installer won't start with 512 MB. What about 1024 MB? thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Instance Types Feature
Hi Tomas, I like the idea in general, but for me the instance types looks like a feature that is typical in public clouds, while in private clouds it looks more like a cool extra feature for special cases. Therefore in my opinion it would be great to keep the old template solution as well to keep it simple for most users. A template could be an instance type and an image together. Only the description overlap, and that could be solved. Thanks, Laszlo - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 22, 2013 3:09:51 PM Subject: [Engine-devel] Instance Types Feature Hi All, this is the proposed new feature called instance types: http://www.ovirt.org/Features/Instance_Types Long story short - it should basically split the VM template into: - hardware profile called instance types - software profile called image This should enable to do something like: Create a new small VM and attach a disk with RHEL + Postgres installed. Any comments are more than welcome! Tomas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] maven build trick
hi, I recommend that you add this script to your build script: rm -rf ~/.m2/repository/org/ovirt This will remove the generated ovirt artifacts from your local maven repo. Why is this needed: If you remove some artifact from the build, that other artifacts are built on, these artifacts will still be able to resolve the missing dependency from the local repo (which is wrong). In this way, your build can still depend on an outdated artifact without breaking the build. This is why you do not notice that the build is broken, maven will just take it as a third party artifact. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Time to move to 3.3.0-SNAPSHOT?
Nice to see -SNAPSHOT in the version. - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, January 17, 2013 1:04:28 PM Subject: [Engine-devel] Time to move to 3.3.0-SNAPSHOT? Once 3.2.0 is released I think we should move to 3.3.0-SNAPSHOT in the master branch: http://gerrit.ovirt.org/11143 -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] vdsbroker
hi, Is there any documentation about vdsbroker? Just trying to understand the concepts. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Patches awaiting review.
Hi Sharad, I am on it. Could you help me rebasing your changes? Some needs manual merge. Thank you, Laszlo - Original Message - From: snmis...@linux.vnet.ibm.com To: engine-devel@ovirt.org Sent: Tuesday, December 25, 2012 11:32:36 PM Subject: [Engine-devel] Patches awaiting review. Following patches are waiting for review - http://gerrit.ovirt.org/#/c/10072/ http://gerrit.ovirt.org/#/c/10085/ http://gerrit.ovirt.org/#/c/10086/ http://gerrit.ovirt.org/#/c/10087/ http://gerrit.ovirt.org/#/c/10042/ Thanks Sharad Mishra ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Patches awaiting review.
All merged - except the abandoned ones. - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: snmis...@linux.vnet.ibm.com Cc: engine-devel@ovirt.org Sent: Tuesday, January 1, 2013 6:45:40 PM Subject: Re: [Engine-devel] Patches awaiting review. Hi Sharad, I am on it. Could you help me rebasing your changes? Some needs manual merge. Thank you, Laszlo - Original Message - From: snmis...@linux.vnet.ibm.com To: engine-devel@ovirt.org Sent: Tuesday, December 25, 2012 11:32:36 PM Subject: [Engine-devel] Patches awaiting review. Following patches are waiting for review - http://gerrit.ovirt.org/#/c/10072/ http://gerrit.ovirt.org/#/c/10085/ http://gerrit.ovirt.org/#/c/10086/ http://gerrit.ovirt.org/#/c/10087/ http://gerrit.ovirt.org/#/c/10042/ Thanks Sharad Mishra ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] jpa annotations
Hi, We have JPA annotations on the backend entity beans, but they have never been actually used as far as I know and now that I looked into VmTemplate for example we do not even have a vm_template table anymore, while VmTemplate still refers to it. Any plans with the JPA? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] patches waiting for review
Hi, I have abandoned my patches that did not get +2 in a month, so now I have a reduced list of patches waiting for +2: http://gerrit.ovirt.org/#/dashboard/127 Your feedback is welcome! Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] compatibility version
Hi, When I install an ovirt engine from scratch, the Default DC is set to Compatibility version 3.1, but when I create a new DC, it's Compatibility version is set to 3.2 by default. Is this intentional? Why? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] host cpu feature
Thank you all for your feedback, I moved the feature to implementation status. Patches: - engine http://gerrit.ovirt.org/#/c/9753/ - vdsm: http://gerrit.ovirt.org/#/c/9507/ (engine patch is built on this) - or alternative vdsm: http://gerrit.ovirt.org/#/c/9367/ (vdsm guys still need to decide which one do they want) - Original Message - From: Itamar Heim ih...@redhat.com To: snmis...@linux.vnet.ibm.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 9:56:02 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 09:15 PM, snmis...@linux.vnet.ibm.com wrote: Quoting Doron Fediuck dfedi...@redhat.com: - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Doron Fediuck dfedi...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 7:14:46 PM Subject: Re: [Engine-devel] host cpu feature - Original Message - From: Doron Fediuck dfedi...@redhat.com To: Yaniv Kaul yk...@redhat.com Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 6:10:55 PM Subject: Re: [Engine-devel] host cpu feature Alternative idea, inspired by Thus, if you hit any bugs, you are on your own (http://libvirt.org/formatdomain.html#elementsCPU wrt 'host-passthrough'): A config option to determine if we use host-model or host-passthrough. Y. I do not think the engine should go to this level. ie- it can ask for passthrough as a feature, and the actual implementation is handled by vdsm. If vdsm decides over host-passthrough or host-model, then how will the engine user know what exactly his VM gets. I think vdsm must be told exactly what to do. VDSM maintains some level of independence. This is why it the engine should be able to ask for passthrough as a feature. Otherwize vdsm will handle it. So for now I suggest we stick to passthrough only, and if we get an RFE for advanced mode we'll support the host model. What are we gaining by using passthrough over host-model? Looking at libvirt documentation, it seems that both modes give host CPU capabilities to guest VM. Whereas the downside of passthrough is that it limits migration. Whereas host-model will migrate to other hardware and if the destination hardware is better than source then the guest VM performance can be improved by rebooting guest. As a stretch goal, ovirt can keep track of host capabilities and inform the user after migrating to a better host, that a reboot may improve guest performance. pass-through may give better performance. host-model would be relevant when we can support live migration inside the cluster for some of the nodes, which will be relevant when the scheduler is more pluggable/extendable than today. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] host cpu feature
Hi, CPU-Host support allows the virtual machines to see and utilize the host's CPU flags, this enables better performance in VM's, at the price of worse portablity. http://www.ovirt.org/Features/Cpu-host_Support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] host cpu feature
- Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 2:45:46 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 03:39 PM, Laszlo Hornyak wrote: - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Yaniv Kaul yk...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 1:55:19 PM Subject: Re: [Engine-devel] host cpu feature On Wed, Dec 05, 2012 at 06:46:09AM -0500, Laszlo Hornyak wrote: - Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 12:23:47 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 12:32 PM, Laszlo Hornyak wrote: Hi, CPU-Host support allows the virtual machines to see and utilize the host's CPU flags, this enables better performance in VM's, at the price of worse portablity. http://www.ovirt.org/Features/Cpu-host_Support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel - I assume that when you allow migration, you'd use host-model? This is not clear from the design. It seems like we VDSM developers can choose to use either this or passthrough, while in practice we should support both. I join Kaul's question: it is an ovirt-level question whether hostPassthrough or hostModel or both should be supported. It should not be a unilateral vdsm decision. Ah, possibly misunderstanding, I did not mean that VDSM should decide whether to use host-passthrough or host-model. The engine should decide. I meant _you_ should decide which version of vdsm api modification do you want :) If AllowMigrateCPUHost is set to true (in case you have the same cpu model everywhere in your DC) migration of such hsots will be enabled. Otherwise it will not be enabled. What is the breadth of AllowMigrateCPUHost? Engine wide? Per DC? Per cluster? I thought of eninge-wide. The of course you can have different models in two different DC, but they should be unique in one. We can add this to DC or cluster level, imho it would be just another checkbox on the UI that most users would not use. I favor the latter; a user may have a cluster of exact-same hosts, where hostcpu migration is allowed, and other cluster where it is forbiden. The nice thing about hostModel (unlike hostPassthrough) is that once we created the VM we can migrate it to stronger hosts, and back to the original host. I suppose that it complicates the scheduler. Yes with host-model you get the features that libvirt handles. In such cases the engine could decide, if you want this functionality. Well the scheduler architecture is just being reinvented. For the host-passthrough, I think the AllowMigrateCPUHost configuration option would be a simple decision for the administrator: set it to true if all hosts are uniform. If it is not set to true, then we will not allow migration of such VMs. That's not what I understood from libvirt's documentation. I You may be right, could you send an URL to that point of the documentation or copy-paste? understood that if you want host+migration, you need to use host-model. Otherwise - host-passthrough. Y. - I'm still convinced and commented on both relevat oVirt and libvirt BZs that we need to add x2apic support to the CPU, regardless of what the host CPU exposes. AFAIK, the KVM developers agree with me. Not quite sure how is this related... could you send some URL's for the bugreports? ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] host cpu feature
- Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 3:05:00 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 03:55 PM, Laszlo Hornyak wrote: - Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com , engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 2:45:46 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 03:39 PM, Laszlo Hornyak wrote: - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Yaniv Kaul yk...@redhat.com , engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 1:55:19 PM Subject: Re: [Engine-devel] host cpu feature On Wed, Dec 05, 2012 at 06:46:09AM -0500, Laszlo Hornyak wrote: - Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 12:23:47 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 12:32 PM, Laszlo Hornyak wrote: Hi, CPU-Host support allows the virtual machines to see and utilize the host's CPU flags, this enables better performance in VM's, at the price of worse portablity. http://www.ovirt.org/Features/Cpu-host_Support Your feedback is welcome! Thank you, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel - I assume that when you allow migration, you'd use host-model? This is not clear from the design. It seems like we VDSM developers can choose to use either this or passthrough, while in practice we should support both. I join Kaul's question: it is an ovirt-level question whether hostPassthrough or hostModel or both should be supported. It should not be a unilateral vdsm decision. Ah, possibly misunderstanding, I did not mean that VDSM should decide whether to use host-passthrough or host-model. The engine should decide. I meant _you_ should decide which version of vdsm api modification do you want :) If AllowMigrateCPUHost is set to true (in case you have the same cpu model everywhere in your DC) migration of such hsots will be enabled. Otherwise it will not be enabled. What is the breadth of AllowMigrateCPUHost? Engine wide? Per DC? Per cluster? I thought of eninge-wide. The of course you can have different models in two different DC, but they should be unique in one. We can add this to DC or cluster level, imho it would be just another checkbox on the UI that most users would not use. I favor the latter; a user may have a cluster of exact-same hosts, where hostcpu migration is allowed, and other cluster where it is forbiden. The nice thing about hostModel (unlike hostPassthrough) is that once we created the VM we can migrate it to stronger hosts, and back to the original host. I suppose that it complicates the scheduler. Yes with host-model you get the features that libvirt handles. In such cases the engine could decide, if you want this functionality. Well the scheduler architecture is just being reinvented. For the host-passthrough, I think the AllowMigrateCPUHost configuration option would be a simple decision for the administrator: set it to true if all hosts are uniform. If it is not set to true, then we will not allow migration of such VMs. That's not what I understood from libvirt's documentation. I You may be right, could you send an URL to that point of the documentation or copy-paste? The link I followed from your feature page: http://libvirt.org/formatdomain.html#elementsCPU : host-model The host-model mode is essentially a shortcut to copying host CPU definition from capabilities XML into domain XML. Since the CPU definition is copied just before starting a domain, exactly the same XML can be used on different hosts while still providing the best guest CPU each host supports. Neither match attribute nor any feature elements can be used in this mode. Specifying CPU model is not supported either, but model's fallback attribute may still be used. Libvirt does not model every aspect of each CPU so the guest CPU will not match the host CPU exactly. On the other hand, the ABI provided to the guest is reproducible. During migration, complete CPU model definition is transferred to the destination host so the migrated guest will see exactly the same CPU model even if the destination host contains more capable CPUs for the running instance of the guest; but shutting down and restarting the guest may present different hardware to the guest according to the capabilities of the new host. host-passthrough With this mode, the CPU visible
Re: [Engine-devel] host cpu feature
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Yaniv Kaul yk...@redhat.com Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 3:22:18 PM Subject: Re: [Engine-devel] host cpu feature On Wed, Dec 05, 2012 at 04:05:00PM +0200, Yaniv Kaul wrote: On 12/05/2012 03:55 PM, Laszlo Hornyak wrote: The nice thing about hostModel (unlike hostPassthrough) is that once we created the VM we can migrate it to stronger hosts, and back to the original host. I suppose that it complicates the scheduler. Yes with host-model you get the features that libvirt handles. In such cases the engine could decide, if you want this functionality. Well the scheduler architecture is just being reinvented. For the host-passthrough, I think the AllowMigrateCPUHost configuration option would be a simple decision for the administrator: set it to true if all hosts are uniform. If it is THAT simple, Engine could take this decision without human intervension. Is there a way engine can figure out if the cpu-models in all the hosts are the same? I mean even if some host flags are not handled by libvirt and therefore vdsm and engine... So I would really need that permission from the user. If it is not set to true, then we will not allow migration of such VMs. That's not what I understood from libvirt's documentation. I You may be right, could you send an URL to that point of the documentation or copy-paste? The link I followed from your feature page: http://libvirt.org/formatdomain.html#elementsCPU : host-model The host-model mode is essentially a shortcut to copying host CPU definition from capabilities XML into domain XML. Since the CPU definition is copied just before starting a domain, exactly the same XML can be used on different hosts while still providing the best guest CPU each host supports. Neither match attribute nor any feature elements can be used in this mode. Specifying CPU model is not supported either, but model's fallback attribute may still be used. Libvirt does not model every aspect of each CPU so the guest CPU will not match the host CPU exactly. On the other hand, the ABI provided to the guest is reproducible. During migration, complete CPU model definition is transferred to the destination host so the migrated guest will see exactly the same CPU model even if the destination host contains more capable CPUs for the running instance of the guest; but shutting down and restarting the guest may present different hardware to the guest according to the capabilities of the new host. host-passthrough With this mode, the CPU visible to the guest should be exactly the same as the host CPU even in the aspects that libvirt does not understand. Though the downside of this mode is that the guest environment cannot be reproduced on different hardware. Thus, if you hit any bugs, you are on your own. That's exactly where AllowMigrateCPUHost fits well: when a user ticks this for a cluster he says yeah, I like to be on my own. cpu mode=host-passthrough migration: I talked to the libvirt guys and they said it is OK if the hardware and the software are the same, and it will work, but they would not recommend. So if they do not recommend it, I would drop this from the feature spec. Anyone against it? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] host cpu feature
- Original Message - From: Doron Fediuck dfedi...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Yaniv Kaul yk...@redhat.com Sent: Wednesday, December 5, 2012 5:33:35 PM Subject: Re: [Engine-devel] host cpu feature - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Yaniv Kaul yk...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 5:24:59 PM Subject: Re: [Engine-devel] host cpu feature - Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 4:10:13 PM Subject: Re: [Engine-devel] host cpu feature On 12/05/2012 04:59 PM, Laszlo Hornyak wrote: - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Yaniv Kaul yk...@redhat.com Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Wednesday, December 5, 2012 3:22:18 PM Subject: Re: [Engine-devel] host cpu feature On Wed, Dec 05, 2012 at 04:05:00PM +0200, Yaniv Kaul wrote: On 12/05/2012 03:55 PM, Laszlo Hornyak wrote: The nice thing about hostModel (unlike hostPassthrough) is that once we created the VM we can migrate it to stronger hosts, and back to the original host. I suppose that it complicates the scheduler. Yes with host-model you get the features that libvirt handles. In such cases the engine could decide, if you want this functionality. Well the scheduler architecture is just being reinvented. For the host-passthrough, I think the AllowMigrateCPUHost configuration option would be a simple decision for the administrator: set it to true if all hosts are uniform. If it is THAT simple, Engine could take this decision without human intervension. Is there a way engine can figure out if the cpu-models in all the hosts are the same? I mean even if some host flags are not handled by libvirt and therefore vdsm and engine... So I would really need that permission from the user. If it is not set to true, then we will not allow migration of such VMs. That's not what I understood from libvirt's documentation. I You may be right, could you send an URL to that point of the documentation or copy-paste? The link I followed from your feature page: http://libvirt.org/formatdomain.html#elementsCPU : host-model The host-model mode is essentially a shortcut to copying host CPU definition from capabilities XML into domain XML. Since the CPU definition is copied just before starting a domain, exactly the same XML can be used on different hosts while still providing the best guest CPU each host supports. Neither match attribute nor any feature elements can be used in this mode. Specifying CPU model is not supported either, but model's fallback attribute may still be used. Libvirt does not model every aspect of each CPU so the guest CPU will not match the host CPU exactly. On the other hand, the ABI provided to the guest is reproducible. During migration, complete CPU model definition is transferred to the destination host so the migrated guest will see exactly the same CPU model even if the destination host contains more capable CPUs for the running instance of the guest; but shutting down and restarting the guest may present different hardware to the guest according to the capabilities of the new host. host-passthrough With this mode, the CPU visible to the guest should be exactly the same as the host CPU even in the aspects that libvirt does not understand. Though the downside of this mode is that the guest environment cannot be reproduced on different hardware. Thus, if you hit any bugs, you are on your own. That's exactly where AllowMigrateCPUHost fits well: when a user ticks this for a cluster he says yeah, I like to be on my own. cpu mode=host-passthrough migration: I talked to the libvirt guys and they said it is OK if the hardware and the software are the same, and it will work, but they would not recommend. So if they do not recommend it, I would drop this from the feature spec. Anyone against it? Laszlo I'm a bit against it. I don't see why it's that complicated: Allow migration - use 'host-model' Do not allow - use 'host-passthrough'. So the actual cpu capabilities would depend not only on the 'host cpu' checkbox, but also on the 'pinned to host' checkbox. I think this logical trick would be both funny and confusing from
Re: [Engine-devel] Trusted Compute Pools
Hi, Interesting technology. Some questions: - There will be 1 and only one attestation server installed per ovirt instance or per trusted pool? - Could engine cache the data it received from the attestation server, or does it have to query each time a trusted VM needs to be started? Thank you, Laszlo - Original Message - From: Gang Wei gang@intel.com To: engine-devel@ovirt.org Sent: Tuesday, November 20, 2012 2:06:09 PM Subject: [Engine-devel] Trusted Compute Pools Hi, I am an engineer working in Intel Open Source Technology Center, interested in integrating Intel initiated OpenAttestation(OAT) project (https://github.com/OpenAttestation/OpenAttestation.git) into oVirt to provide a way for Administrator to deploy VMs on trusted hosts hardened with H/W-based security features, such as Intel TXT. I made a draft feature page for this: http://wiki.ovirt.org/wiki/Trusted_compute_pools My draft idea is to provide trust_level requirement while doing vm creation like below: curl -v -u vdcad...@qa.lab.tlv.redhat.com -H Content-type: application/xml -d 'vmnamemy_new_vm/name cluster id=99408929-82cf-4dc7-a532-9d998063fa95 / template id=----/ trust_leveltrusted/trust_level/vm' 'http://10.35.1.1/rhevm-api/vms' Then oVirt Engine should query attestation server built with OAT via RESTful API to get all trusted hosts and select one to create the VM. Attestation server performs host verification through following steps: 1. Hosts boot with Intel TXT technology enabled 2. The hosts' BIOS, hypervisor and OS are measured 3. These measured data is sent to Attestation server when challenged by attestation server 4. Attestation server verifies those measurements against good/known database to determine hosts' trustworthiness Hosts need to be installed with OAT host agent to report host integrity to attestation server. By far, I am still in process of getting familiar with oVirt code and not get solid idea yet on how the oVirt Engine should be modified to support this feature. Any kind of comments or suggestions will be highly appreciated. Thanks Gang (Jimmy) Wei ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] vm priority
hi, Vm + Vmstatic have a property 'priority'. Does anyone know where on the UI can one set this? Is this something only the rest api supports? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] wiki
Hi, The wiki is behaving strangely today. It does not accept login and claims that 'You have cookies disabled'. Also, the password reset form is showing error messages. Is there a server-side problem? Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Building oVirt from source
Hi, We may have some infrastructure problems. Looks like gerrit is dead as well :( Does this directory exist? /usr/share/jboss-as/standalone/deployments/engine.ear/ - Original Message - From: Stephen Liu sati...@yahoo.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 9:25:56 AM Subject: Re: [Engine-devel] Building oVirt from source Hi, I have sent another email to the list under the subject: Deploy error again. But it never came to the list: Subject : Deploy error again Failure:- $ mvn clean install -Pdep,setup /usr/lib/jvm/java [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.ovirt.engine:engine-server-ear:ear:3.1.0 [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-ear-plugin is missing. @ line 154, column 15 [WARNING] 'distributionManagement.repository.id' must not be 'local', this identifier is reserved for the local repository, using it for other repositories will corrupt your repository metadata. @ line 18, column 11 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] [INFO] [INFO] [INFO] Building oVirt Server EAR 3.1.0 [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.pom Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.pom (5 KB at 46.7 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.jar Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.jar (24 KB at 255.8 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ engine-server-ear --- [INFO] Deleting /home/satimis/ovirt-engine/ear/target [INFO] [INFO] --- maven-antrun-plugin:1.3:run (undeploy) @ engine-server-ear --- Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom (3 KB at 77.6 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom (5 KB at 137.9 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom (10 KB at 232.4 KB/sec) Downloading: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.jar Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar (12 KB at 79.1 KB/sec) Downloaded: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar (245 KB at 226.5 KB/sec) Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.jar (1292 KB at 384.3 KB/sec) [INFO] Executing tasks [echo] *** Deleting /usr/share/jboss-as/standalone/deployments/engine.ear/... [INFO] Executed tasks [INFO] [INFO] --- maven-ear-plugin:2.6:generate-application-xml (default-generate-application-xml) @ engine-server-ear --- [INFO] Generating application.xml [INFO] [INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ engine-server-ear --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /home/satimis/ovirt-engine/ear/src/main/java [INFO] Copying 1 resource [INFO] [INFO] --- maven-ear-plugin:2.6:ear (default-ear) @ engine-server-ear --- [INFO] Copying artifact[jar:org.ovirt.engine.core:common:3.1.0] to[lib/engine-common.jar] [INFO] Copying artifact[jar:org.ovirt.engine.core:compat:3.1.0] to[lib/engine-compat.jar] [INFO] Copying artifact[jar:org.ovirt.engine.core:dal:3.1.0] to[lib/engine-dal.jar] [INFO] Copying artifact[jar:org.ovirt.engine.core:utils:3.1.0] to[lib/engine-utils.jar] [INFO] Copying artifact[jar:org.ovirt.engine.core:engineencryptutils:3.1.0] to[lib/engine-encryptutils.jar] [INFO] Copying artifact[jar:org.ovirt.engine.core:vdsbroker:3.1.0] to[lib/engine-vdsbroker.jar] [INFO] Copying artifact[war:org.ovirt.engine.core:root-war:3.1.0] to[root.war] (unpacked) [INFO] Copying
Re: [Engine-devel] Proposal to add Allon Mureinik as maintainer to engine core
+1 - Original Message - From: Itamar Heim ih...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 5:12:09 AM Subject: [Engine-devel] Proposal to add Allon Mureinik as maintainer to engine core Allon has worked on oVirt for the past 10 months. With 534 patches ranging from cleanups, to complex features like user level api and storage live migration. In addition, Allon has been instrumental in the number of patch reviews he has done. I'd like to propose Allon as a maintainer of engine core. Thanks, Itamar ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Building oVirt from source
Ah, just noticed that the build process deleted the directory, or at least attempted to. And then I did not find in the log where did it create again... There must be a problem around the build, maybe a permission issue. I recommend to just copy the engine.ear dir to the deploy directory for now, and then of course touch engine.ear.dodeploy in the same directory and see if it works. I hope the mailing lists will recover soon and the build guys will be able to tell what went wrong. - Original Message - From: Stephen Liu sati...@yahoo.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 11:18:03 AM Subject: Re: [Engine-devel] Building oVirt from source Hi Laszlo, # find / -name engine.ear find: `/run/user/satimis/gvfs': Permission denied /home/satimis/ovirt-engine/ear/target/engine.ear NOT; /usr/share/jboss-as/standalone/deployments/engine.ear/ # find / -name jboss-as find: `/run/user/satimis/gvfs': Permission denied /home/satimis/jboss-as B.R. Stephen L From: Laszlo Hornyak lhorn...@redhat.com To: Stephen Liu sati...@yahoo.com Cc: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 4:36 PM Subject: Re: [Engine-devel] Building oVirt from source Hi, We may have some infrastructure problems. Looks like gerrit is dead as well :( Does this directory exist? /usr/share/jboss-as/standalone/deployments/engine.ear/ - Original Message - From: Stephen Liu sati...@yahoo.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 9:25:56 AM Subject: Re: [Engine-devel] Building oVirt from source Hi, I have sent another email to the list under the subject: Deploy error again. But it never came to the list: Subject : Deploy error again Failure:- $ mvn clean install -Pdep,setup /usr/lib/jvm/java [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.ovirt.engine:engine-server-ear:ear:3.1.0 [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-ear-plugin is missing. @ line 154, column 15 [WARNING] 'distributionManagement.repository.id' must not be 'local', this identifier is reserved for the local repository, using it for other repositories will corrupt your repository metadata. @ line 18, column 11 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] [INFO] [INFO] [INFO] Building oVirt Server EAR 3.1.0 [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.pom Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.pom (5 KB at 46.7 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.jar Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-antrun-plugin/1.3/maven-antrun-plugin-1.3.jar (24 KB at 255.8 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ engine-server-ear --- [INFO] Deleting /home/satimis/ovirt-engine/ear/target [INFO] [INFO] --- maven-antrun-plugin:1.3:run (undeploy) @ engine-server-ear --- Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom (3 KB at 77.6 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom (5 KB at 137.9 KB/sec) Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom (10 KB at 232.4 KB/sec) Downloading: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar Downloading: http://repo1.maven.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.jar Downloaded: http://repo1.maven.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar (12 KB at 79.1 KB/sec) Downloaded: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar (245 KB at 226.5 KB/sec) Downloaded: http://repo1.maven.org
Re: [Engine-devel] Unable to view the storage domains - SQL error
hi, The search queries generate these statements. It looks like something replaced the underscores with spaces in the view names, and that is not good for SQL. But the backend should not do this, maybe only restapi replaces something in the erromessages? Possibly the db upgrade failed somewhere and it left the schema without views? - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Christopher Morrissey christopher.morris...@netapp.com Cc: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 4:02:17 AM Subject: Re: [Engine-devel] Unable to view the storage domains - SQL error Hi Christopher, In general - as a developer at engine project, I would recommend to run the upgrade script on a frequent basis. What troubles me with the query you sent (maybe some problematic copy paste issue?) are the following issues: a. storage domains for search - not sure what this is b. storage domains with hosts view - I guess you have some underline issue at the copy paste. I would appreciate if you attach engine.log (or a part of it that reflects the error you encountered) Kind regards, Yair From: Christopher Morrissey christopher.morris...@netapp.com To: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 12:10:14 AM Subject: [Engine-devel] Unable to view the storage domains - SQL error Hi All, I’m getting an error when trying to view the storage domains using the REST API: ?xml version=1.0 encoding=UTF-8 standalone=yes? fault reasonOperation Failed/reason detailstatementcallback; bad sql grammar [select * from (select * from storage domains for search where ( id in (select storage domains with hosts view.id from storage domains with hosts view )) order by storage name asc ) as t1 offset (1 -1) limit 100]; nested exception is org.postgresql.util.psqlexception: error: relation storage domains for search does not exist position: 30/detail /fault Also, through the web admin console, when viewing the storage domains the list never loads. Did something change in the DB recently such that I would need to rebuild it? -Chris Chris Morrissey Software Engineer NetApp Inc. 919.476.4428 ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Building oVirt from source
- Original Message - From: Stephen Liu sati...@yahoo.com To: engine-devel@ovirt.org Sent: Tuesday, November 13, 2012 5:20:46 PM Subject: [Engine-devel] Building oVirt from source Hi all, Have another round to build oVirt from source following; Building Engine Draft http://wiki.ovirt.org/wiki/Building_Engine_Draft OS - Fedora 17 desktop 64bit, fresh and clean installed. Not much problem encountered up to Installing JBoss AS except follows: 1) Maven personal settings == $ mkdir $HOME/.m2 $ wget -O $HOME/.m2/settings.xml http://wiki.ovirt.org/w/images/1/18/Settings.xml.png (it should read http://wiki.ovirt.org/w/images/1/18/Settings.xml.png;) (not www) 2) Check that the application server starts correctly: $ cd $JBOSS_HOME/bin $ ./standalone.sh -b 0.0.0.0 === JBoss Bootstrap Environment JBOSS_HOME: /home/satimis/jboss-as JAVA: java JAVA_OPTS: -server -XX:+UseCompressedOops -XX:+TieredCompilation -Xms64m -Xmx512m -XX:MaxPermSize=256m -Djava.net.preferIPv4Stack=true -Dorg.jboss.resolver.warning=true -Dsun.rmi.dgc.client.gcInterval=360 -Dsun.rmi.dgc.server.gcInterval=360 -Djboss.modules.system.pkgs=org.jboss.byteman -Djava.awt.headless=tr . 22:14:38,217 INFO [org.jboss.as] (Controller Boot Thread) JBAS015874: JBoss AS 7.1.1.Final Brontes started in 6662ms - Started 133 of 208 services (74 services are passive or on-demand) So your jboss is started at this point and should e listening on 8080 for http connections. Is ovirt running? If not you should check if it is there in standalone/deployments/engine.ear Also, see if engine.ear.deployed exists. touch engine.dodeploy to kick jboss and deploy it. It hung here; Press [Ctrl] + c it continued to display: 19:49,653 INFO [org.jboss.as.osgi] (MSC service thread 1-3) JBAS011942: Stopping OSGi Framework 22:19:49,701 INFO [org.jboss.as.logging] JBAS011503: Restored bootstrap log handlers 22:19:49,726 INFO [org.apache.coyote.http11.Http11Protocol] Pausing Coyote HTTP/1.1 on http--0.0.0.0-8080 22:19:49,727 INFO [org.apache.coyote.http11.Http11Protocol] Stopping Coyote HTTP/1.1 on http--0.0.0.0-8080 22:19:49,729 INFO [com.arjuna.ats.jbossatx] ARJUNA032018: Destroying TransactionManagerService 22:19:49,730 INFO [com.arjuna.ats.jbossatx] ARJUNA032014: Stopping transaction recovery manager 22:19:49,753 INFO [org.jboss.as] JBAS015950: JBoss AS 7.1.1.Final Brontes stopped in 111ms Is it normal? Without problem? Thanks B.R. Stephen L ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] wiki
It works now, probably the same root reason as for the mailing list. - Original Message - From: Douglas Landgraf dougsl...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, November 14, 2012 5:31:54 PM Subject: Re: [Engine-devel] wiki Hi, On 11/14/2012 03:02 AM, Laszlo Hornyak wrote: Hi, The wiki is behaving strangely today. It does not accept login and claims that 'You have cookies disabled'. Also, the password reset form is showing error messages. Is there a server-side problem? Looks like server-side, I am facing the same errors. -- Cheers Douglas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] eclipse juno vs gwt
http://youtu.be/XQ0JmfKs21g - Original Message - From: Christopher Morrissey christopher.morris...@netapp.com To: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Friday, November 2, 2012 11:43:23 PM Subject: RE: [Engine-devel] eclipse juno vs gwt Sorry to follow up my own question, but can you give some specific cases where this would be a problem? Thanks! -Chris -Original Message- From: Morrissey, Christopher Sent: Friday, November 02, 2012 6:41 PM To: 'Laszlo Hornyak'; engine-devel Subject: RE: [Engine-devel] eclipse juno vs gwt Hi Laszlo, I have several methods that define the @Override annotation and return something different from the super class. I haven't had any problems compiling them in GWT. The return value does extend from the return value of the super class, although this is a requirement in Java as well so I'm not sure where the difference is. -Chris -Original Message- From: engine-devel-boun...@ovirt.org [mailto:engine-devel-boun...@ovirt.org] On Behalf Of Laszlo Hornyak Sent: Friday, November 02, 2012 6:19 AM To: engine-devel Subject: [Engine-devel] eclipse juno vs gwt Hi, Just noticed that eclipse juno is adding @Ovewrride annotations to methods that are actually overriding something, like in many cases clone and equals methods in some of the classes. This is fine for the java compiler, but it in some cases the GWT compiler is not going to accept this annotation. E.g. if the return type is different than the method with same name in the superclass. Juno is doing this by default without asking, when saving the file. So be extra-careful when editing java classes if they are shared with GWT Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] eclipse juno vs gwt
Hi, Just noticed that eclipse juno is adding @Ovewrride annotations to methods that are actually overriding something, like in many cases clone and equals methods in some of the classes. This is fine for the java compiler, but it in some cases the GWT compiler is not going to accept this annotation. E.g. if the return type is different than the method with same name in the superclass. Juno is doing this by default without asking, when saving the file. So be extra-careful when editing java classes if they are shared with GWT Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Time to bump version to 3.2.0?
Hi Juan, I think it is time to correct the version, but I was always wondering why we do not use the -SNAPSHOT versioning the maven developers designed? I think once we start pushing artifacts to public repositories, it will be a pain to have released version in our pom files. I think frontend and backend plugin developers will need this. http://www.sonatype.com/books/mvnref-book/reference/pom-relationships-sect-pom-syntax.html Laszlo - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Friday, November 2, 2012 2:42:10 PM Subject: [Engine-devel] Time to bump version to 3.2.0? I think that it is time to bump the version number in the POMs and in the RPM spec to 3.2.0: http://gerrit.ovirt.org/8993 In general I think that we should do this immediately after each release, bumping to the next expected version number. Thoughts? -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] operation mode
The same question applies to HypervisorType, since only KVM is supported. - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, November 1, 2012 9:43:14 AM Subject: [Engine-devel] operation mode Hi, I have just run into this. Vm's have an OperationMode attribute, it can be FullVirtualized or ParaVirtualized. It appears the attribute does not play in any decision, not sent to vdsm. Can it be removed or anyone need it? thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] operation mode
- Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, November 1, 2012 7:35:27 PM Subject: Re: [Engine-devel] operation mode On 11/01/2012 10:43 AM, Laszlo Hornyak wrote: Hi, I have just run into this. Vm's have an OperationMode attribute, it can be FullVirtualized or ParaVirtuaized. It appears the attribute does not play in any decision, not sent to vdsm. Can it be removed or anyone need it? wow, that's old... iirc, back in 2007, some cases required to boot with qemu instead of kvm (some real mode stuff (ghost?)) i think can be removed... http://gerrit.ovirt.org/8986 thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] operation mode
- Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, November 1, 2012 8:16:48 PM Subject: Re: [Engine-devel] operation mode On 11/01/2012 10:57 AM, Laszlo Hornyak wrote: The same question applies to HypervisorType, since only KVM is supported. I think this one is worth a bit more thinking before removing actually, but if you remove it in a single patch, easy enough to revert should we want to add something like this back (and the enum is far from all that needs to be done anyway for such a thing) Do you plan to support hypervisors other than qemu+kvm? - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, November 1, 2012 9:43:14 AM Subject: [Engine-devel] operation mode Hi, I have just run into this. Vm's have an OperationMode attribute, it can be FullVirtualized or ParaVirtualized. It appears the attribute does not play in any decision, not sent to vdsm. Can it be removed or anyone need it? thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] ovirt on wikipedia
- Original Message - From: Yaniv Kaul yk...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, October 31, 2012 9:04:55 AM Subject: Re: [Engine-devel] ovirt on wikipedia On 10/29/2012 05:40 PM, Laszlo Hornyak wrote: Hi, http://en.wikipedia.org/wiki/OVirt At the moment there are OVirt pages in english, russian and hungarian. Any volunteers to write czech, hebrew, german, spanish, catalan? - just to mention the languages some ovirt-developers speak :-) Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel While I could have translated it to Hebrew, I thought it might be more productive to beef-up the English content. I've added information on networking, frontends and API. Once I get how to edit with table of contents, I'll split to: release history components features For the hungarian page I broke it down to - history - components - storage - console protocols - references (release notes, blog, wiki) and indeed some content is missing there :) Btw, is there a logo that could be uploaded? I guess the ASL license is good enough for wikipedia, but it would need some editing. The one on the stickers would be probably better. Y. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] ovirt on wikipedia
Hi, http://en.wikipedia.org/wiki/OVirt At the moment there are OVirt pages in english, russian and hungarian. Any volunteers to write czech, hebrew, german, spanish, catalan? - just to mention the languages some ovirt-developers speak :-) Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Local build failing.
- Original Message - From: snmis...@linux.vnet.ibm.com To: engine-devel@ovirt.org Sent: Thursday, September 27, 2012 12:35:44 AM Subject: [Engine-devel] Local build failing. Hi, My local build is failing today. I cloned the ovirt-engine repo and ran 'mvn clean install. Failed with following error - Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project vdsbroker: Compilation failure [ERROR] /tmp/ovirt-engine/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:[604,44] this file was last modified Wed Aug 15, looks like working. But that line should be fine even with java 1.6. illegal start of expression I noticed that Jenkins build succeeded after this change was merged. -Sharad ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Fixed -Xmx could kill your JVM
Hi Juan, Just wondering why the initial memory size for the JVM. Isn't it better if we just start from the default and let it grow to a maximum size? Thx, Laszlo - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, September 12, 2012 2:32:28 PM Subject: [Engine-devel] Fixed -Xmx could kill your JVM Hello, I recently discovered that I made a mistake in the engine service script. The problem is that were running the JVM with the -Xms option twice, like this: java -Xms1g -Xms1g ... That doesn't correctly limit the max amount of heap space. It has been fixed in a recent commit [1], so with the updated code the engine will run by default like this: java -Xms1g -Xmx1g ... With this change you could start to see OutOfMemory errors if your engine was using a lot of memory, if you are running stress tests, for example. In that case remember that you can adjust this changing the ENGINE_HEAP_MIN and ENGINE_HEAP_MAX parameters in /etc/sysconfig/ovirt-engine. For example, to use 2g instead of the default of 1g: ENGINE_HEAP_MIN=2g ENGINE_HEAP_MAX=2g The restart the engine. Let me know if you have issues. Regards, Juan Hernandez [1] http://gerrit.ovirt.org/7952 -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] what does engine with cpuIdle?
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Omer Frenkel ofren...@redhat.com Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Tuesday, September 11, 2012 9:22:15 AM Subject: Re: [Engine-devel] what does engine with cpuIdle? On Tue, Sep 11, 2012 at 01:55:01AM -0400, Omer Frenkel wrote: - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, September 10, 2012 3:51:59 PM Subject: [Engine-devel] what does engine with cpuIdle? hi, I am trying to change a behavior in vdsm. When you pass 100% load on a VM, it will stop reporting further load and will keep telling 100% until the load drops under 100% again in it's cpuIdle information. This is totally correct if you have only single-cpu VM's, but it is false when you have multiple vcpu's, I think the cpuIdle information should not be on a 0-100 scale, but on a 0-100*vcpus scale. So I submitted this patch to vdsm: http://gerrit.ovirt.org/#/c/7892/2 and Dan pointed out that some functionality may depend on the value in the 0-100 interval. For me it seems it is ignored and the load is calculated only from sysCpu + userCpu. Does anyone build on the cpuIdle value? Thanks, Laszlo you are right, engine doesn't save cpuIdle for vm, so it's not in use in the engine. Laszlo, in this case, I think it would be best to drop this bogus piece of information. Ok. However, before I abandon this patch: we have a requirement to report cpuSys and cpuUser separately. Afaik in libvirt cpuUser and cpuSys does not include the actual guest time (at least not with KVM), and in this way if we only report cpuSys and cpuUser, the sum does not give the actual load, only a relatively little percentage of it. If we have the cpuIdle information in engine, we can calculate the guest time. Therefore, should I - include the guest time in cpuSys or cpuUser? - add another exported field? And in both case, we will still have to calculate from cpuIdle because libvirt does not tell the guest cpu time :-( Dan. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] what does engine with cpuIdle?
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Omer Frenkel ofren...@redhat.com Sent: Tuesday, September 11, 2012 2:34:13 PM Subject: Re: [Engine-devel] what does engine with cpuIdle? On Tue, Sep 11, 2012 at 07:38:11AM -0400, Laszlo Hornyak wrote: - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Omer Frenkel ofren...@redhat.com Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Tuesday, September 11, 2012 9:22:15 AM Subject: Re: [Engine-devel] what does engine with cpuIdle? On Tue, Sep 11, 2012 at 01:55:01AM -0400, Omer Frenkel wrote: - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, September 10, 2012 3:51:59 PM Subject: [Engine-devel] what does engine with cpuIdle? hi, I am trying to change a behavior in vdsm. When you pass 100% load on a VM, it will stop reporting further load and will keep telling 100% until the load drops under 100% again in it's cpuIdle information. This is totally correct if you have only single-cpu VM's, but it is false when you have multiple vcpu's, I think the cpuIdle information should not be on a 0-100 scale, but on a 0-100*vcpus scale. So I submitted this patch to vdsm: http://gerrit.ovirt.org/#/c/7892/2 and Dan pointed out that some functionality may depend on the value in the 0-100 interval. For me it seems it is ignored and the load is calculated only from sysCpu + userCpu. Does anyone build on the cpuIdle value? Thanks, Laszlo you are right, engine doesn't save cpuIdle for vm, so it's not in use in the engine. Laszlo, in this case, I think it would be best to drop this bogus piece of information. Ok. However, before I abandon this patch: Why abandon? I've suggested you to keep it, just make it even simpler. Ok, it is only burocracy, but the new patch will do something completely different than the original, so it does not seem to make sense to continue this patch. It is more simple to make another one. we have a requirement to report cpuSys and cpuUser separately. Afaik in libvirt cpuUser and cpuSys does not include the actual guest time (at least not with KVM), and in this way if we only report cpuSys and cpuUser, the sum does not give the actual load, only a relatively little percentage of it. I am not sure I understand what you are saying, but afaik, libvirt's relatively-new http://libvirt.org/html/libvirt-libvirt.html#virDomainGetCPUStats reports the cpu time spent by the entire qemu process - in guest and host modes. It seems like sysCpu + userCpu cpuTime, therefore something is missing. I will give it another try, maybe something wrong with my hosts. If we have the cpuIdle information in engine, we can calculate the guest time. Therefore, should I - include the guest time in cpuSys or cpuUser? - add another exported field? And in both case, we will still have to calculate from cpuIdle because libvirt does not tell the guest cpu time :-( Now I'm completely at loss. Why should we calculate cpuIdle per VM? Haven't we agreed that it is useless? Well, if libvirt exports the guest time in sysCpu, then we do not have to. But it seems it does not. Dan. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] AsyncTaskManager and the irsbroker
hi, I have just noticed that AsyncTaskManager is - almost all of the public methods are synchronized - and it is singleton - calling to VDS operations (line 291) Therefore this may be a performance bottleneck. Even when you want to create an asynchronous task or query a task's state, you may have to wait till a remote vdsm responds. Would it be ok to remove the synchronization from e.g. the query-like methods? Or the one initiating remote calls? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] what does engine with cpuIdle?
hi, I am trying to change a behavior in vdsm. When you pass 100% load on a VM, it will stop reporting further load and will keep telling 100% until the load drops under 100% again in it's cpuIdle information. This is totally correct if you have only single-cpu VM's, but it is false when you have multiple vcpu's, I think the cpuIdle information should not be on a 0-100 scale, but on a 0-100*vcpus scale. So I submitted this patch to vdsm: http://gerrit.ovirt.org/#/c/7892/2 and Dan pointed out that some functionality may depend on the value in the 0-100 interval. For me it seems it is ignored and the load is calculated only from sysCpu + userCpu. Does anyone build on the cpuIdle value? Thanks, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] waiting for review
hi, I have some patches waiting for review. Some of them are not quite new. But anyway, if you have some time, your reviews are welcome. http://gerrit.ovirt.org/#/dashboard/127 Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] java 1.6 compatibility no more?
Not against it, but then we have declare in the pom that java 1.6 is no longer working http://gerrit.ovirt.org/6447 Laszlo - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, July 19, 2012 7:42:48 AM Subject: Re: [Engine-devel] java 1.6 compatibility no more? On 07/18/2012 06:43 PM, Laszlo Hornyak wrote: Hi, It may be a historic moment, but for a few hours oVirt engine is no longer building on java 1.6. Is this intentional? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel Laszlo, I assumed (maybe wrong) that our subscribers on engine-devel are aware they should use jdk7. We recently had several issues (for example - some ldap/dns issue) with JDK6 , that were fixed on JDK7. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] java 1.6 compatibility no more?
Hi, It may be a historic moment, but for a few hours oVirt engine is no longer building on java 1.6. Is this intentional? Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
