[E-devel] Enlightenment crashes when openening icon-less application menu property page

2007-01-19 Thread Sam Bobroff
Hello Enlightenment developers,
I've found a tiny bug in Enlightenment (compiled from the current 
CVS source) and I hope this is the right place to post it.

Steps to reproduce:

Open the Main menu, select Configuration, Application Menus.
Select an an application without an icon from the Available Applications.
Add the application to a menu (eg. favorite).
Select the new application in the Menus panel.
Right click and open Properties.
Enlightenment crashes.

I ran it under gdb and it was caused by a simple null pointer 
dereference so I've tested a quick fix and stops the crash (although I'm 
not sure it's the correct thing to do because I've never looked at the 
Enlightenment source code before). The patch is below (also thank you 
all for working on enlightenment, it's great!).

Sam B.

diff -u -b -B -d -r1.15 e_widget.c
--- e_widget.c  16 Oct 2006 23:45:16 -  1.15
+++ e_widget.c  19 Jan 2007 15:42:34 -
@@ -146,7 +146,7 @@
  {
if (e_widget_can_focus_get(sobj)) sd-child_can_focus = 1;
  }
-   if (!strcmp(evas_object_type_get(sobj), SMART_NAME))
+   if (evas_object_type_get(sobj)  
!strcmp(evas_object_type_get(sobj), SMART_NAME))
  {
sd = evas_object_smart_data_get(sobj);
if (sd) sd-parent_obj = obj;


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] etk_colorpicker patch to add alpha slider ... and also a problem to solve :)

2007-01-19 Thread Simon TRENY
On Wed, 17 Jan 2007 23:41:27 +0100,
DaveMDS [EMAIL PROTECTED] wrote :

 Hi
 attached a patch to add an alpha slider  to etk_colorpicker.
 If someone need I can also make an option to
 disable the slider. (an application could not handle
 alpha channel and so could want to hide the slider)
 
 There is a problem in the way the current color is displayed
 in the dialog. I have this problem also in
 edje_editor and really I can't figure out how to solve.
 
 evas_object_color_set() don't draw the alpha in the right way:
 if the color is black the alpha are good,
 if the color is white the alpha never change until 0 is reached(and
 then disappear)
 
 Seems that evas always make the transparency on a white background.
 
 What problem is this? is evas? is etk?
 or I missed something
 
 Hope someone can help me, becouse I'am really out of idea  :(
 Dave
 


Sorry Dave, because of exams period, I won't have time to review the
patch but if you need it for Edje Editor, you can commit the code and
we'll improve it later if it needs so. I should have more time in one
week.

Thanks for the patch :)
Simon

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] etk_colorpicker patch to add alpha slider ... and also a problem to solve :)

2007-01-19 Thread DaveMDS
Simon TRENY ha scritto:
 On Wed, 17 Jan 2007 23:41:27 +0100,
 DaveMDS [EMAIL PROTECTED] wrote :

   
 Hi
 attached a patch to add an alpha slider  to etk_colorpicker.
 If someone need I can also make an option to
 disable the slider. (an application could not handle
 alpha channel and so could want to hide the slider)

 There is a problem in the way the current color is displayed
 in the dialog. I have this problem also in
 edje_editor and really I can't figure out how to solve.

 evas_object_color_set() don't draw the alpha in the right way:
 if the color is black the alpha are good,
 if the color is white the alpha never change until 0 is reached(and
 then disappear)

 Seems that evas always make the transparency on a white background.

 What problem is this? is evas? is etk?
 or I missed something

 Hope someone can help me, becouse I'am really out of idea  :(
 Dave

 


 Sorry Dave, because of exams period, I won't have time to review the
 patch but if you need it for Edje Editor, you can commit the code and
 we'll improve it later if it needs so. I should have more time in one
 week.

 Thanks for the patch :)
 Simon


   
Thanks for the replay, no problem for edje editor (simply you don't have
the ability to change alpha until the patch is committed).
Take your time...  :)

dave

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] edje command

2007-01-19 Thread Andreas Volz
Hello,

some time ago there was a edje command to view my edj files. But it
seems to be removed (at least on Gentoo). I've only this files:

/usr/bin/edje_decc
/usr/bin/edje_cc
/usr/bin/edje_recc
/usr/bin/edje-config
/usr/lib/pkgconfig/edje.pc
/usr/lib/libedje.so.0
/usr/lib/libedje.so.0.5.0
/usr/lib/libedje.la
/usr/lib/libedje.so
/usr/lib/libedje.a
/usr/share/doc/edje-/README.gz
/usr/share/doc/edje-/AUTHORS.gz
/usr/share/edje/include/edje.inc
/usr/include/Edje.h

So where is it?

regards
Andreas

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] edje command

2007-01-19 Thread DaveMDS
Andreas Volz ha scritto:
 Hello,

 some time ago there was a edje command to view my edj files. But it
 seems to be removed (at least on Gentoo). I've only this files:

 /usr/bin/edje_decc
 /usr/bin/edje_cc
 /usr/bin/edje_recc
 /usr/bin/edje-config
 /usr/lib/pkgconfig/edje.pc
 /usr/lib/libedje.so.0
 /usr/lib/libedje.so.0.5.0
 /usr/lib/libedje.la
 /usr/lib/libedje.so
 /usr/lib/libedje.a
 /usr/share/doc/edje-/README.gz
 /usr/share/doc/edje-/AUTHORS.gz
 /usr/share/edje/include/edje.inc
 /usr/include/Edje.h

 So where is it?

   
There is edje_viewer instead but it's not part of edje.
You can find it in cvs under e17/proto/edje_viewer

Is also have more feature than the old viewer.

Dave

 regards
 Andreas

 -
 Take Surveys. Earn Cash. Influence the Future of IT
 Join SourceForge.net's Techsay panel and you'll get the chance to share your
 opinions on IT  business topics through brief surveys - and earn cash
 http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


   


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] edje command

2007-01-19 Thread Brian Mattern


On Fri, Jan 19, 2007 at 11:11:27PM +0100, Andreas Volz wrote:
 Hello,
 
 some time ago there was a edje command to view my edj files. But it
 seems to be removed 

It should be in cvs in the test module

rephorm


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] edje command

2007-01-19 Thread William Keaney
On Fri, 2007-01-19 at 23:11 +0100, Andreas Volz wrote:
 Hello,
 
 some time ago there was a edje command to view my edj files. But it
 seems to be removed (at least on Gentoo). I've only this files:
 
 /usr/bin/edje_decc
 /usr/bin/edje_cc
 /usr/bin/edje_recc
 /usr/bin/edje-config
 /usr/lib/pkgconfig/edje.pc
 /usr/lib/libedje.so.0
 /usr/lib/libedje.so.0.5.0
 /usr/lib/libedje.la
 /usr/lib/libedje.so
 /usr/lib/libedje.a
 /usr/share/doc/edje-/README.gz
 /usr/share/doc/edje-/AUTHORS.gz
 /usr/share/edje/include/edje.inc
 /usr/include/Edje.h
 
 So where is it?

There is an ebuild for edje_viewer in vapier's evolution overlay, to
which all e17 ebuilds have been moved.
-- 
Build a person a fire, and they may be warm for a day.
Set that person on fire, and they will be warm for the rest of their
life.
GnuPG Public Key ID: 1024D/203C7431
Public Key Available From http://subkeys.pgp.net:11371/


signature.asc
Description: This is a digitally signed message part
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel