Re: [E-devel] E SVN: discomfitor trunk/elementary
but we have elm_object_content_part_set/get() already. i.e) #define ELM_BUTTON_ICON elm.swallow.icon elm_object_content_part_set(obj, ELM_BUTTON_ICON, icon); Let's run together for the best moment! -Regards, Hermet- -Original Message- From: Enlightenment SVNlt;no-re...@enlightenment.orggt; To: enlightenment-...@lists.sourceforge.net Cc: Sent: 11-10-21(금) 09:26:09 Subject: E SVN: discomfitor trunk/elementary Log: more elm todo items Author: discomfitor Date: 2011-10-20 17:26:09 -0700 (Thu, 20 Oct 2011) New Revision: 64217 Trac: http://trac.enlightenment.org/e/changeset/64217 Modified: trunk/elementary/TODO Modified: trunk/elementary/TODO === --- trunk/elementary/TODO 2011-10-21 00:24:15 UTC (rev 64216) +++ trunk/elementary/TODO 2011-10-21 00:26:09 UTC (rev 64217) @@ -6,3 +6,6 @@ Things That Just Need To Be Rewritten (tm): toolbar icon api is broken, should take an actual elm_icon. requires new elm_toolbar_item_update api as well panel edc + +Features + elm_object_icon_s/get() should be implemented for most widgets to reduce api -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src: lib lib/canvas lib/include modules/engines/gl_x11
On Fri, 21 Oct 2011, Enlightenment SVN wrote:
Log:
add call to get maximum image size (eg max texture size)
changelog, and @since in the doc
Vincent
Author: raster
Date: 2011-10-21 01:17:14 -0700 (Fri, 21 Oct 2011)
New Revision: 64244
Trac: http://trac.enlightenment.org/e/changeset/64244
Modified:
trunk/evas/src/lib/Evas.h trunk/evas/src/lib/canvas/evas_object_image.c
trunk/evas/src/lib/include/evas_private.h
trunk/evas/src/modules/engines/gl_x11/evas_engine.c
Modified: trunk/evas/src/lib/Evas.h
===
--- trunk/evas/src/lib/Evas.h 2011-10-21 07:25:02 UTC (rev 64243)
+++ trunk/evas/src/lib/Evas.h 2011-10-21 08:17:14 UTC (rev 64244)
@@ -2653,22 +2653,38 @@
* @param e The given evas pointer.
* @param size The cache size.
*
- * This function sets the image cache of canvas.
+ * This function sets the image cache of canvas in bytes.
*
*/
EAPI void evas_image_cache_set (Evas *e, int size)
EINA_ARG_NONNULL(1);
/**
- * Set the image cache
+ * Get the image cache
*
* @param e The given evas pointer.
*
- * This function returns the image cache of canvas.
+ * This function returns the image cache size of canvas in bytes.
*
*/
EAPI int evas_image_cache_get (const Evas *e)
EINA_WARN_UNUSED_RESULT EINA_ARG_NONNULL(1) EINA_PURE;
/**
+ * Get the maximum image size evas can possibly handle
+ *
+ * @param e The given evas pointer.
+ * @param maxw Pointer to hold the return value in pixels of the maxumum
width
+ * @param maxh Pointer to hold the return value in pixels of the maximum
height
+ *
+ * This function returns the larges image or surface size that evas can
handle
+ * in pixels, and if there is one, returns EINA_TRUE. It returns EINA_FALSE
+ * if no extra constraint on maximum image size exists. You still should
+ * check the return values of @p maxw and @p maxh as there may still be a
+ * limit, just a much higher one.
+ *
+ */
+EAPI Eina_Bool evas_image_max_size_get (const Evas *e, int
*maxw, int *maxh) EINA_ARG_NONNULL(1) EINA_PURE;
+
+/**
* @}
*/
Modified: trunk/evas/src/lib/canvas/evas_object_image.c
===
--- trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-21 07:25:02 UTC
(rev 64243)
+++ trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-21 08:17:14 UTC
(rev 64244)
@@ -2139,6 +2139,23 @@
return e-engine.func-image_cache_get(e-engine.data.output);
}
+EAPI Eina_Bool
+evas_image_max_size_get(const Evas *e, int *maxw, int *maxh)
+{
+ int w = 0, h = 0;
+ MAGIC_CHECK(e, Evas, MAGIC_EVAS);
+ return EINA_FALSE;
+ MAGIC_CHECK_END();
+
+ if (maxw) *maxw = 0x;
+ if (maxh) *maxh = 0x;
+ if (!e-engine.func-image_max_size_get) return EINA_FALSE;
+ e-engine.func-image_max_size_get(e-engine.data.output, w, h);
+ if (maxw) *maxw = w;
+ if (maxh) *maxh = h;
+ return EINA_TRUE;
+}
+
/* all nice and private */
static void
_proxy_unset(Evas_Object *proxy)
Modified: trunk/evas/src/lib/include/evas_private.h
===
--- trunk/evas/src/lib/include/evas_private.h 2011-10-21 07:25:02 UTC (rev
64243)
+++ trunk/evas/src/lib/include/evas_private.h 2011-10-21 08:17:14 UTC (rev
64244)
@@ -834,6 +834,9 @@
int (*image_animated_loop_count_get) (void *data, void *image);
double (*image_animated_frame_duration_get) (void *data, void *image, int
start_frame, int frame_num);
Eina_Bool (*image_animated_frame_set) (void *data, void *image, int
frame_index);
+
+ /* max size query */
+ void (*image_max_size_get)(void *data, int *maxw, int *maxh);
};
struct _Evas_Image_Load_Func
Modified: trunk/evas/src/modules/engines/gl_x11/evas_engine.c
===
--- trunk/evas/src/modules/engines/gl_x11/evas_engine.c 2011-10-21
07:25:02 UTC (rev 64243)
+++ trunk/evas/src/modules/engines/gl_x11/evas_engine.c 2011-10-21
08:17:14 UTC (rev 64244)
@@ -3764,6 +3764,14 @@
return EINA_TRUE;
}
+static void
+eng_image_max_size_get(void *data, int *maxw, int *maxh)
+{
+ Render_Engine *re = (Render_Engine *)data;
+ if (maxw) *maxw = re-win-gl_context-shared-info.max_texture_size;
+ if (maxh) *maxh = re-win-gl_context-shared-info.max_texture_size;
+}
+
static int
module_open(Evas_Module *em)
{
@@ -3880,6 +3888,8 @@
ORD(image_animated_frame_duration_get);
ORD(image_animated_frame_set);
+ ORD(image_max_size_get);
+
/* now advertise out own api */
em-functions = (void *)(func);
return 1;
--
The demand for IT networking professionals continues to grow, and the
demand for specialized
Re: [E-devel] E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
SeoZ, you definitely need a lock, so somebody could not access your TODO list.
or..
Set a deadly trap there to blow someone away when he open your TODO list. :p
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-21(금) 10:49:16
Subject: E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
Log:
remove gross genlistitemmoved function thingy and implement smart cb
also removed relevant item on TODO
Author: discomfitor
Date: 2011-10-20 18:49:15 -0700 (Thu, 20 Oct 2011)
New Revision: 64222
Trac: http://trac.enlightenment.org/e/changeset/64222
Modified:
trunk/devs/seoz/TODO trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_genlist.c
Modified: trunk/devs/seoz/TODO
===
--- trunk/devs/seoz/TODO 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/devs/seoz/TODO 2011-10-21 01:49:15 UTC (rev 64222)
@@ -4,7 +4,6 @@
[High] Enhance elm_genlist_height_for_width_mode_set() API.
[High] Revise Sohyun's genlist-entry patch.
- Enhance compress mode. Merge styles and call signals.
- - Changed moved item class function to smart callback.
- Merge _item_move_after/before().
- Fix reorder bug when the window edge is going out of the screen.
- Check elm_genlist_item_sorted_insert() API with group index, expandable list
and etc.
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:49:15 UTC (rev 64222)
@@ -18082,6 +18082,7 @@
* pinched out. - @c multi,pinch,in - This is called when the genlist is
* multi-touch pinched in.
* - @c swipe - This is called when the genlist is swiped.
+ * - @c moved - This is called when a genlist item is moved.
* - @c language,changed - This is called when the program's language is
* changed.
*
@@ -18123,7 +18124,6 @@
typedef Evas_Object *(*Elm_Genlist_Item_Icon_Get_Cb) (void *data, Evas_Object
*obj, const char *part); /**lt; Icon fetching class function for genlist item
classes. */
typedef Eina_Bool (*Elm_Genlist_Item_State_Get_Cb) (void *data, Evas_Object
*obj, const char *part); /**lt; State fetching class function for genlist item
classes. */
typedef void (*Elm_Genlist_Item_Del_Cb) (void *data, Evas_Object *obj);
/**lt; Deletion class function for genlist item classes. */
- typedef void (*GenlistItemMovedFunc) (Evas_Object *obj, Elm_Genlist_Item
*item, Elm_Genlist_Item *rel_item, Eina_Bool move_after); /** TODO: remove this
by SeoZ **/
typedef char *(*GenlistItemLabelGetFunc) (void *data, Evas_Object *obj, const
char *part) EINA_DEPRECATED; /** DEPRECATED. Use Elm_Genlist_Item_Label_Get_Cb
instead. */
typedef Evas_Object *(*GenlistItemIconGetFunc) (void *data, Evas_Object *obj,
const char *part) EINA_DEPRECATED; /** DEPRECATED. Use
Elm_Genlist_Item_Icon_Get_Cb instead. */
@@ -18149,7 +18149,6 @@
Elm_Genlist_Item_Icon_Get_Cb icon_get; /**lt; Icon fetching class function
for genlist item classes. */
Elm_Genlist_Item_State_Get_Cb state_get; /**lt; State fetching class function
for genlist item classes. */
Elm_Genlist_Item_Del_Cb del; /**lt; Deletion class function for genlist item
classes. */
- GenlistItemMovedFunc moved; // TODO: do not use this. change this to smart
callback.
} func;
const char *mode_item_style;
};
Modified: trunk/elementary/src/lib/elm_genlist.c
===
--- trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:49:15 UTC (rev 64222)
@@ -276,6 +276,7 @@
static const char SIG_MULTI_PINCH_OUT[] = multi,pinch,out;
static const char SIG_MULTI_PINCH_IN[] = multi,pinch,in;
static const char SIG_SWIPE[] = swipe;
+static const char SIG_MOVED[] = moved;
static const Evas_Smart_Cb_Description _signals[] = {
{SIG_CLICKED_DOUBLE, },
@@ -314,6 +315,7 @@
{SIG_MULTI_PINCH_OUT, },
{SIG_MULTI_PINCH_IN, },
{SIG_SWIPE, },
+ {SIG_MOVED, },
{NULL, NULL}
};
@@ -3474,9 +3476,7 @@
if (after-group_item) it-group_item = after-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart callback
- if (it-itc-func.moved)
- it-itc-func.moved(WIDGET(it), it, after, EINA_TRUE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
static void
@@ -3494,9 +3494,7 @@
if (before-group_item) it-group_item = before-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart callback
- if (it-itc-func.moved)
- it-itc-func.moved(WIDGET(it), it, before, EINA_FALSE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
EAPI Elm_Genlist_Item *
Re: [E-devel] E SVN: discomfitor trunk/elementary
On Fri, 21 Oct 2011 17:35:44 +0900 ChunEon Parkher...@naver.com wrote: but we have elm_object_content_part_set/get() already. i.e) #define ELM_BUTTON_ICON elm.swallow.icon elm_object_content_part_set(obj, ELM_BUTTON_ICON, icon); Let's run together for the best moment! -Regards, Hermet- -Original Message- From: Enlightenment SVNlt;no-re...@enlightenment.orggt; To: enlightenment-...@lists.sourceforge.net Cc: Sent: 11-10-21(금) 09:26:09 Subject: E SVN: discomfitor trunk/elementary Log: more elm todo items Author: discomfitor Date: 2011-10-20 17:26:09 -0700 (Thu, 20 Oct 2011) New Revision: 64217 Trac: http://trac.enlightenment.org/e/changeset/64217 Modified: trunk/elementary/TODO Modified: trunk/elementary/TODO === --- trunk/elementary/TODO 2011-10-21 00:24:15 UTC (rev 64216) +++ trunk/elementary/TODO 2011-10-21 00:26:09 UTC (rev 64217) @@ -6,3 +6,6 @@ Things That Just Need To Be Rewritten (tm): toolbar icon api is broken, should take an actual elm_icon. requires new elm_toolbar_item_update api as well panel edc + +Features + elm_object_icon_s/get() should be implemented for most widgets to reduce api -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel good idea! -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
On Fri, 21 Oct 2011 17:44:52 +0900
ChunEon Parkher...@naver.com wrote:
SeoZ, you definitely need a lock, so somebody could not access your TODO
list. or..
Set a deadly trap there to blow someone away when he open your TODO list. :p
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-21(금) 10:49:16
Subject: E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
Log:
remove gross genlistitemmoved function thingy and implement smart cb
also removed relevant item on TODO
Author: discomfitor
Date: 2011-10-20 18:49:15 -0700 (Thu, 20 Oct 2011)
New Revision: 64222
Trac: http://trac.enlightenment.org/e/changeset/64222
Modified:
trunk/devs/seoz/TODO trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_genlist.c Modified: trunk/devs/seoz/TODO
===
--- trunk/devs/seoz/TODO 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/devs/seoz/TODO 2011-10-21 01:49:15 UTC (rev 64222)
@@ -4,7 +4,6 @@
[High] Enhance elm_genlist_height_for_width_mode_set() API.
[High] Revise Sohyun's genlist-entry patch.
- Enhance compress mode. Merge styles and call signals.
- - Changed moved item class function to smart callback.
- Merge _item_move_after/before().
- Fix reorder bug when the window edge is going out of the screen.
- Check elm_genlist_item_sorted_insert() API with group index, expandable
list and etc. Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:39:14 UTC (rev
64221) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:49:15 UTC
(rev 64222) @@ -18082,6 +18082,7 @@
* pinched out. - @c multi,pinch,in - This is called when the genlist is
* multi-touch pinched in.
* - @c swipe - This is called when the genlist is swiped.
+ * - @c moved - This is called when a genlist item is moved.
* - @c language,changed - This is called when the program's language is
* changed.
*
@@ -18123,7 +18124,6 @@
typedef Evas_Object *(*Elm_Genlist_Item_Icon_Get_Cb) (void *data,
Evas_Object *obj, const char *part); /**lt; Icon fetching class function for
genlist item classes. */ typedef Eina_Bool (*Elm_Genlist_Item_State_Get_Cb)
(void *data, Evas_Object *obj, const char *part); /**lt; State fetching
class function for genlist item classes. */ typedef void
(*Elm_Genlist_Item_Del_Cb) (void *data, Evas_Object *obj); /**lt; Deletion
class function for genlist item classes. */
- typedef void (*GenlistItemMovedFunc) (Evas_Object *obj, Elm_Genlist_Item
*item, Elm_Genlist_Item *rel_item, Eina_Bool move_after); /** TODO: remove
this by SeoZ **/ typedef char *(*GenlistItemLabelGetFunc) (void *data,
Evas_Object *obj, const char *part) EINA_DEPRECATED; /** DEPRECATED. Use
Elm_Genlist_Item_Label_Get_Cb instead. */ typedef Evas_Object
*(*GenlistItemIconGetFunc) (void *data, Evas_Object *obj, const char *part)
EINA_DEPRECATED; /** DEPRECATED. Use Elm_Genlist_Item_Icon_Get_Cb instead. */
@@ -18149,7 +18149,6 @@ Elm_Genlist_Item_Icon_Get_Cb icon_get; /**lt; Icon
fetching class function for genlist item classes. */
Elm_Genlist_Item_State_Get_Cb state_get; /**lt; State fetching class
function for genlist item classes. */ Elm_Genlist_Item_Del_Cb del; /**lt;
Deletion class function for genlist item classes. */
- GenlistItemMovedFunc moved; // TODO: do not use this. change this to smart
callback. } func;
const char *mode_item_style;
};
Modified: trunk/elementary/src/lib/elm_genlist.c
===
--- trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:49:15 UTC (rev 64222)
@@ -276,6 +276,7 @@
static const char SIG_MULTI_PINCH_OUT[] = multi,pinch,out;
static const char SIG_MULTI_PINCH_IN[] = multi,pinch,in;
static const char SIG_SWIPE[] = swipe;
+static const char SIG_MOVED[] = moved;
static const Evas_Smart_Cb_Description _signals[] = {
{SIG_CLICKED_DOUBLE, },
@@ -314,6 +315,7 @@
{SIG_MULTI_PINCH_OUT, },
{SIG_MULTI_PINCH_IN, },
{SIG_SWIPE, },
+ {SIG_MOVED, },
{NULL, NULL}
};
@@ -3474,9 +3476,7 @@
if (after-group_item) it-group_item = after-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart callback
- if (it-itc-func.moved)
- it-itc-func.moved(WIDGET(it), it, after, EINA_TRUE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
static void
@@ -3494,9 +3494,7 @@
if (before-group_item) it-group_item = before-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart callback
- if (it-itc-func.moved)
- it-itc-func.moved(WIDGET(it), it, before, EINA_FALSE);
+
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, Oct 21, 2011 at 12:00 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: and disable invalidate optimization Author: raster Date: 2011-10-21 03:00:03 -0700 (Fri, 21 Oct 2011) New Revision: 64249 Trac: http://trac.enlightenment.org/e/changeset/64249 Modified: trunk/evas/src/lib/canvas/evas_render.c Modified: trunk/evas/src/lib/canvas/evas_render.c === --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 09:59:13 UTC (rev 64248) +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 10:00:03 UTC (rev 64249) @@ -1295,7 +1295,7 @@ _evas_render_check_pending_objects(e-pending_objects, e); /* phase 1. add extra updates for changed objects */ - if (e-invalidate || e-render_objects.count = 0) +/* if (e-invalidate || e-render_objects.count = 0)*/ clean_them = _evas_render_phase1_process(e, e-active_objects, e-restack_objects, This optimisation does really impact performance on low end hardware when they are not using evas map. Could you tell me what was the issue ? How to reproduce it ? So I can bring this optimisation back in. Thanks -- Cedric BAIL -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch] elm_entry - change content, text set
Dear developers.
I'd made a small patch of elm_entry.
It's not a special code itself, however it modify some important policy of
elm_entry.
Current elm_entry only supports content sets to internal scroller's edc.
However it can't be used if scrollable is not set.
I think it's definitely a bug. So I modify to support that situation.
In this patch, if scrollable is not set then a user can content_set to
elm_entry's edc.
If only care about functionality, it's good to exploit elm_entry's edc and
internal scroller's edc.
But it's a definitely redundancy. And I'd talked with Woohyun, his either
doesn't like this idea.
I also agree with it. Eventually one of edc should be choose.
I'm prefer elm_entry's edc. Does any want to change about this?
Thank you.
Index: elementary/src/lib/elm_entry.c
===
--- elementary/src/lib/elm_entry.c (由щ퉬�쟾 64251)
+++ elementary/src/lib/elm_entry.c (�옉�뾽 �궗蹂�)
@@ -780,21 +780,27 @@
Evas_Object *edje;
if ((!wd) || (!content)) return;
- edje = elm_smart_scroller_edje_object_get(wd-scroller);
- if (!strcmp(part, elm.swallow.icon))
+ if (wd-scroll)
{
-if (wd-icon)
- evas_object_del(wd-icon);
-wd-icon = content;
-edje_object_signal_emit(edje, elm,action,show,icon, elm);
+edje = elm_smart_scroller_edje_object_get(wd-scroller);
+if (!strcmp(part, elm.swallow.icon))
+ {
+ if (wd-icon)
+ evas_object_del(wd-icon);
+ wd-icon = content;
+ edje_object_signal_emit(edje, elm,action,show,icon, elm);
+ }
+else if (!strcmp(part, elm.swallow.end))
+ {
+ if (wd-end)
+ evas_object_del(wd-end);
+ wd-end = content;
+ edje_object_signal_emit(edje, elm,action,show,end, elm);
+ }
}
- else if (!strcmp(part, elm.swallow.end))
- {
-if (wd-end)
- evas_object_del(wd-end);
-wd-end = content;
-edje_object_signal_emit(edje, elm,action,show,end, elm);
- }
+ else
+ edje = wd-ent;
+
evas_event_freeze(evas_object_evas_get(obj));
elm_widget_sub_object_add(obj, content);
edje_object_part_swallow(edje, part, content);
@@ -810,17 +816,22 @@
Evas_Object *content, *edje;
if (!wd) return NULL;
- edje = elm_smart_scroller_edje_object_get(wd-scroller);
- if (!strcmp(part, elm.swallow.icon))
+ if (wd-scroll)
{
-wd-icon = NULL;
-edje_object_signal_emit(edje, elm,action,hide,icon, elm);
+edje = elm_smart_scroller_edje_object_get(wd-scroller);
+if (!strcmp(part, elm.swallow.icon))
+ {
+ wd-icon = NULL;
+ edje_object_signal_emit(edje, elm,action,hide,icon, elm);
+ }
+else if (!strcmp(part, elm.swallow.end))
+ {
+ wd-end = NULL;
+ edje_object_signal_emit(edje, elm,action,hide,end, elm);
+ }
}
- else if (!strcmp(part, elm.swallow.end))
- {
-wd-end = NULL;
-edje_object_signal_emit(edje, elm,action,hide,end, elm);
- }
+ else
+ edje = wd-ent;
content = edje_object_part_swallow_get(edje, part);
edje_object_part_swallow(edje, part, NULL);
@@ -842,12 +853,18 @@
Evas_Object *content = NULL, *edje;
if (!wd) return NULL;
- if (!strcmp(part, elm.swallow.icon))
- return wd-icon;
- if (!strcmp(part, elm.swallow.end))
- return wd-end;
+ if (wd-scroll)
+ {
+if (!strcmp(part, elm.swallow.icon))
+ return wd-icon;
+if (!strcmp(part, elm.swallow.end))
+ return wd-end;
- edje = elm_smart_scroller_edje_object_get(wd-scroller);
+edje = elm_smart_scroller_edje_object_get(wd-scroller);
+ }
+ else
+ edje = wd-ent;
+
if (edje)
content = edje_object_part_swallow_get(edje, part);
return content;
@@ -2051,11 +2068,16 @@
{
int len = 0;
ELM_CHECK_WIDTYPE(obj, widtype);
- if (item strcmp(item, default)) return;
Widget_Data *wd = elm_widget_data_get(obj);
if (!wd) return;
evas_event_freeze(evas_object_evas_get(obj));
if (!entry) entry = ;
+ if (item strcmp(item, default))
+ {
+edje_object_part_text_set(wd-ent, item, entry);
+return;
+ }
+
if (wd-text) eina_stringshare_del(wd-text);
wd-text = NULL;
wd-changed = EINA_TRUE;
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, 21 Oct 2011 12:34:05 +0200 Cedric BAIL cedric.b...@free.fr said: On Fri, Oct 21, 2011 at 12:00 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: and disable invalidate optimization Author: raster Date: 2011-10-21 03:00:03 -0700 (Fri, 21 Oct 2011) New Revision: 64249 Trac: http://trac.enlightenment.org/e/changeset/64249 Modified: trunk/evas/src/lib/canvas/evas_render.c Modified: trunk/evas/src/lib/canvas/evas_render.c === --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 09:59:13 UTC (rev 64248) +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 10:00:03 UTC (rev 64249) @@ -1295,7 +1295,7 @@ _evas_render_check_pending_objects(e-pending_objects, e); /* phase 1. add extra updates for changed objects */ - if (e-invalidate || e-render_objects.count = 0) +/* if (e-invalidate || e-render_objects.count = 0)*/ clean_them = _evas_render_phase1_process(e, e-active_objects, e-restack_objects, This optimisation does really impact performance on low end hardware when they are not using evas map. Could you tell me what was the issue ? How to reproduce it ? So I can bring this optimisation back in problem is actually this: object a changes. object b is a big solid object covering obj a entirely. b does NOT change. now we render. we SHOULD reduce this to a nop. but we dont. we are rendering the change region even though its obscured. it's a bug. i reverted this already as i thought this was the quick fix. it did - but it created new bugs. i fixed it elsewhere, but now there is yet another corner case it doesnt detect and i don't know why. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Spank spank raster!
This introduces trailing whitespaces.
Daniel Juyung Seo (SeoZ)
On Fri, Oct 21, 2011 at 2:50 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
nicer formatting of async events
Author: raster
Date: 2011-10-20 22:50:05 -0700 (Thu, 20 Oct 2011)
New Revision: 64240
Trac: http://trac.enlightenment.org/e/changeset/64240
Modified:
trunk/evas/src/lib/canvas/evas_async_events.c
Modified: trunk/evas/src/lib/canvas/evas_async_events.c
===
--- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:40:59
UTC (rev 64239)
+++ trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:50:05
UTC (rev 64240)
@@ -82,28 +82,32 @@
if (_fd_read == -1) return 0;
- do {
+ do
+ {
check = read(_fd_read, ev, sizeof (Evas_Event_Async *));
-
+
if (check == sizeof (Evas_Event_Async *))
{
if (ev-func) ev-func((void *)ev-target, ev-type,
ev-event_info);
free(ev);
count++;
}
- } while (check 0);
+ }
+ while (check 0);
evas_cache_image_wakeup();
if (check 0)
- switch (errno)
- {
- case EBADF:
- case EINVAL:
- case EIO:
- case EISDIR:
- _fd_read = -1;
- }
+ {
+ switch (errno)
+ {
+ case EBADF:
+ case EINVAL:
+ case EIO:
+ case EISDIR:
+ _fd_read = -1;
+ }
+ }
return count;
#else
@@ -130,23 +134,28 @@
ev-type = type;
ev-event_info = event_info;
- do {
- check = write(_fd_write, ev, sizeof (Evas_Event_Async*));
- } while ((check != sizeof (Evas_Event_Async*)) ((errno == EINTR) ||
(errno == EAGAIN)));
+ do
+ {
+ check = write(_fd_write, ev, sizeof (Evas_Event_Async*));
+ }
+ while ((check != sizeof (Evas_Event_Async*))
+ ((errno == EINTR) || (errno == EAGAIN)));
evas_cache_image_wakeup();
if (check == sizeof (Evas_Event_Async*))
result = EINA_TRUE;
else
- switch (errno)
- {
- case EBADF:
- case EINVAL:
- case EIO:
- case EPIPE:
- _fd_write = -1;
- }
+ {
+ switch (errno)
+ {
+ case EBADF:
+ case EINVAL:
+ case EIO:
+ case EPIPE:
+ _fd_write = -1;
+ }
+ }
return result;
#else
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
This is cool.
Thanks zmike!
Daniel Juyung Seo (SeoZ)
2011/10/21 Mike Blumenkrantz m...@zentific.com:
On Fri, 21 Oct 2011 17:44:52 +0900
ChunEon Parkher...@naver.com wrote:
SeoZ, you definitely need a lock, so somebody could not access your TODO
list. or..
Set a deadly trap there to blow someone away when he open your TODO list. :p
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-21(금) 10:49:16
Subject: E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
Log:
remove gross genlistitemmoved function thingy and implement smart cb
also removed relevant item on TODO
Author: discomfitor
Date: 2011-10-20 18:49:15 -0700 (Thu, 20 Oct 2011)
New Revision: 64222
Trac: http://trac.enlightenment.org/e/changeset/64222
Modified:
trunk/devs/seoz/TODO trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_genlist.c Modified: trunk/devs/seoz/TODO
===
--- trunk/devs/seoz/TODO 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/devs/seoz/TODO 2011-10-21 01:49:15 UTC (rev 64222)
@@ -4,7 +4,6 @@
[High] Enhance elm_genlist_height_for_width_mode_set() API.
[High] Revise Sohyun's genlist-entry patch.
- Enhance compress mode. Merge styles and call signals.
- - Changed moved item class function to smart callback.
- Merge _item_move_after/before().
- Fix reorder bug when the window edge is going out of the screen.
- Check elm_genlist_item_sorted_insert() API with group index, expandable
list and etc. Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:39:14 UTC (rev
64221) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:49:15 UTC
(rev 64222) @@ -18082,6 +18082,7 @@
* pinched out. - @c multi,pinch,in - This is called when the genlist is
* multi-touch pinched in.
* - @c swipe - This is called when the genlist is swiped.
+ * - @c moved - This is called when a genlist item is moved.
* - @c language,changed - This is called when the program's language is
* changed.
*
@@ -18123,7 +18124,6 @@
typedef Evas_Object *(*Elm_Genlist_Item_Icon_Get_Cb) (void *data,
Evas_Object *obj, const char *part); /**lt; Icon fetching class function for
genlist item classes. */ typedef Eina_Bool (*Elm_Genlist_Item_State_Get_Cb)
(void *data, Evas_Object *obj, const char *part); /**lt; State fetching
class function for genlist item classes. */ typedef void
(*Elm_Genlist_Item_Del_Cb) (void *data, Evas_Object *obj); /**lt; Deletion
class function for genlist item classes. */
- typedef void (*GenlistItemMovedFunc) (Evas_Object *obj, Elm_Genlist_Item
*item, Elm_Genlist_Item *rel_item, Eina_Bool move_after); /** TODO: remove
this by SeoZ **/ typedef char *(*GenlistItemLabelGetFunc) (void *data,
Evas_Object *obj, const char *part) EINA_DEPRECATED; /** DEPRECATED. Use
Elm_Genlist_Item_Label_Get_Cb instead. */ typedef Evas_Object
*(*GenlistItemIconGetFunc) (void *data, Evas_Object *obj, const char *part)
EINA_DEPRECATED; /** DEPRECATED. Use Elm_Genlist_Item_Icon_Get_Cb instead. */
@@ -18149,7 +18149,6 @@ Elm_Genlist_Item_Icon_Get_Cb icon_get; /**lt; Icon
fetching class function for genlist item classes. */
Elm_Genlist_Item_State_Get_Cb state_get; /**lt; State fetching class
function for genlist item classes. */ Elm_Genlist_Item_Del_Cb del; /**lt;
Deletion class function for genlist item classes. */
- GenlistItemMovedFunc moved; // TODO: do not use this. change this to smart
callback. } func;
const char *mode_item_style;
};
Modified: trunk/elementary/src/lib/elm_genlist.c
===
--- trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:39:14 UTC (rev
64221)
+++ trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:49:15 UTC (rev
64222)
@@ -276,6 +276,7 @@
static const char SIG_MULTI_PINCH_OUT[] = multi,pinch,out;
static const char SIG_MULTI_PINCH_IN[] = multi,pinch,in;
static const char SIG_SWIPE[] = swipe;
+static const char SIG_MOVED[] = moved;
static const Evas_Smart_Cb_Description _signals[] = {
{SIG_CLICKED_DOUBLE, },
@@ -314,6 +315,7 @@
{SIG_MULTI_PINCH_OUT, },
{SIG_MULTI_PINCH_IN, },
{SIG_SWIPE, },
+ {SIG_MOVED, },
{NULL, NULL}
};
@@ -3474,9 +3476,7 @@
if (after-group_item) it-group_item = after-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart callback
- if (it-itc-func.moved)
- it-itc-func.moved(WIDGET(it), it, after, EINA_TRUE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
static void
@@ -3494,9 +3494,7 @@
if (before-group_item) it-group_item = before-group_item;
_item_queue(it-wd, it);
- // TODO: change this to smart
Re: [E-devel] about removing trailing whitespaces
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to fit
the exact coding style of the efl (I think it's close now) but I noticed a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files, or
the number of spaces between a variable type and its name in a declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it to
work, it could be done in a single commit but might cause conflicts to devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] gnome-terminal exit code
Hi, Why does gnome-terminal exit with code 255 when executed from the menu in E, but not when executed from a terminal? S. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gnome-terminal exit code
On 21/10/11 21:27, Sebastian Dransfeld wrote: Hi, Why does gnome-terminal exit with code 255 when executed from the menu in E, but not when executed from a terminal? I'm also having issues with exit codes, premature exits, and etc. For example, when running libreoffice from e (using a custom command in open with, because choosing libreoffice from the list doesn't work) I get program (null) ended with exit code ... although libreoffice is still running. Also, I get it every couple of minutes, so it's even not the app launched by e, very weird. Also, sometimes when I close one window of firefox, the application closes. I'm not using gnome-terminal anymore, but when I did, closing one window sometimes caused gnome-terminal to close completely. (all gnome-terminal instances are really just one application). WTH? :P -- Tom. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gnome-terminal exit code
On Fri, 21 October 2011 Tom Hacohen t...@stosb.com wrote: On 21/10/11 21:27, Sebastian Dransfeld wrote: Why does gnome-terminal exit with code 255 when executed from the menu in E, but not when executed from a terminal? I'm also having issues with exit codes, premature exits, and etc. For example, when running libreoffice from e (using a custom command in open with, because choosing libreoffice from the list doesn't work) I get program (null) ended with exit code ... although libreoffice is still running. Also, I get it every couple of minutes, so it's even not the app launched by e, very weird. Also, sometimes when I close one window of firefox, the application closes. I'm not using gnome-terminal anymore, but when I did, closing one window sometimes caused gnome-terminal to close completely. (all gnome-terminal instances are really just one application). WTH? :P Is it a matter of those apps forking (LibreOffice) and possibly the environment they are seeing? stracing enlightenment (and looking at the clone which execs the app + further children) might shed some more precise light on it. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/elementary/src/lib
On Fri, 21 Oct 2011 09:53:01 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: elm gengrid: Changed widget data member 'self' to 'obj'. Sync with genlist. Author: seoz Date: 2011-10-21 09:53:01 -0700 (Fri, 21 Oct 2011) New Revision: 64262 Trac: http://trac.enlightenment.org/e/changeset/64262 Modified: trunk/elementary/src/lib/elm_gengrid.c oh good, I was going to do this today -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gnome-terminal exit code
On 21/10/11 22:10, Bruno wrote: Is it a matter of those apps forking (LibreOffice) and possibly the environment they are seeing? stracing enlightenment (and looking at the clone which execs the app + further children) might shed some more precise light on it. If it was only easily/consistently reproducible :| -- Tom. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gnome-terminal exit code
On Fri, 2011-10-21 at 21:27 +0200, Sebastian Dransfeld wrote: Why does gnome-terminal exit with code 255 when executed from the menu in E, but not when executed from a terminal? Bug in gnome-terminal, has nothing to do with menu launching. See: https://bugzilla.gnome.org/show_bug.cgi?id=646317 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633979 Ross -- Ross Vandegrift r...@kallisti.us signature.asc Description: This is a digitally signed message part -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sat, 22 Oct 2011 00:47:33 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:
Spank spank raster!
This introduces trailing whitespaces.
turn off your annoyance mode in your editor. fyi if u mean trailing white
spaces at the START of blank lines - thats actually HOW many editors work on
autoindent... because they are EXPECTING you to write some code there. it's
perfectly logical and all you are doing is bitching about something that is
actually a good thing because you insist on having an hyper-annoying editor
feature on.
Daniel Juyung Seo (SeoZ)
On Fri, Oct 21, 2011 at 2:50 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
nicer formatting of async events
Author: raster
Date: 2011-10-20 22:50:05 -0700 (Thu, 20 Oct 2011)
New Revision: 64240
Trac: http://trac.enlightenment.org/e/changeset/64240
Modified:
trunk/evas/src/lib/canvas/evas_async_events.c
Modified: trunk/evas/src/lib/canvas/evas_async_events.c
===
--- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:40:59
UTC (rev 64239) +++ trunk/evas/src/lib/canvas/evas_async_events.c
2011-10-21 05:50:05 UTC (rev 64240) @@ -82,28 +82,32 @@
if (_fd_read == -1) return 0;
- do {
+ do
+ {
check = read(_fd_read, ev, sizeof (Evas_Event_Async *));
-
+
if (check == sizeof (Evas_Event_Async *))
{
if (ev-func) ev-func((void *)ev-target, ev-type,
ev-event_info); free(ev);
count++;
}
- } while (check 0);
+ }
+ while (check 0);
evas_cache_image_wakeup();
if (check 0)
- switch (errno)
- {
- case EBADF:
- case EINVAL:
- case EIO:
- case EISDIR:
- _fd_read = -1;
- }
+ {
+ switch (errno)
+ {
+ case EBADF:
+ case EINVAL:
+ case EIO:
+ case EISDIR:
+ _fd_read = -1;
+ }
+ }
return count;
#else
@@ -130,23 +134,28 @@
ev-type = type;
ev-event_info = event_info;
- do {
- check = write(_fd_write, ev, sizeof (Evas_Event_Async*));
- } while ((check != sizeof (Evas_Event_Async*)) ((errno == EINTR) ||
(errno == EAGAIN)));
+ do
+ {
+ check = write(_fd_write, ev, sizeof (Evas_Event_Async*));
+ }
+ while ((check != sizeof (Evas_Event_Async*))
+ ((errno == EINTR) || (errno == EAGAIN)));
evas_cache_image_wakeup();
if (check == sizeof (Evas_Event_Async*))
result = EINA_TRUE;
else
- switch (errno)
- {
- case EBADF:
- case EINVAL:
- case EIO:
- case EPIPE:
- _fd_write = -1;
- }
+ {
+ switch (errno)
+ {
+ case EBADF:
+ case EINVAL:
+ case EIO:
+ case EPIPE:
+ _fd_write = -1;
+ }
+ }
return result;
#else
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gnome-terminal exit code
On Fri, 21 Oct 2011 21:16:33 -0400 Ross Vandegrift r...@kallisti.us said: On Fri, 2011-10-21 at 21:27 +0200, Sebastian Dransfeld wrote: Why does gnome-terminal exit with code 255 when executed from the menu in E, but not when executed from a terminal? Bug in gnome-terminal, has nothing to do with menu launching. See: https://bugzilla.gnome.org/show_bug.cgi?id=646317 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633979 and it'll be the same bug in the other circumstances. too. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about removing trailing whitespaces
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to fit
the exact coding style of the efl (I think it's close now) but I noticed a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files, or
the number of spaces between a variable type and its name in a declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it to
work, it could be done in a single commit but might cause conflicts to devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot more
than gnu indent does. the problem right now is in getting it to consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a
Re: [E-devel] about removing trailing whitespaces
Yeah, I've seen ecrustify but I think when testing it, it didn't give good
results and from what I could perceive, other devs don't seem to trust it to
work reliably which is why I put efl-indent in there.
Also I believe using a tested and used GNU app is better than using a custom
made one that might have bugs, and being able to easily configure the output
using arguments to indent makes it better than looking through ecrustify to
figure out what causes it to format a line the wrong way.
As for the format, I configured efl-indent to match what the wiki says
(other than one bug I'm not sure how to change, need to read the man page),
but the current issues is with the fact that each file seem to use a
different coding style (or different styles within the same file) and I'm
not sure what to do with these as they are undocumented in the wiki.
p.s: for trailing spaces (which is this mail's original subject), I use a
sed line in efl-indent to take care of that, at least that could safely be
put into a svn hook while we figure out the coding style issue.
On Fri, Oct 21, 2011 at 10:14 PM, Carsten Haitzler ras...@rasterman.comwrote:
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in
FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer
to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't
match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to
fit
the exact coding style of the efl (I think it's close now) but I noticed
a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files,
or
the number of spaces between a variable type and its name in a
declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it
to
work, it could be done in a single commit but might cause conflicts to
devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our
current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot
more
than gnu indent does. the problem right now is in getting it to
consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to
commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr
wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and
whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com
wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn
best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
will hurt enough.
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand
Re: [E-devel] about removing trailing whitespaces
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Yeah, I've seen ecrustify but I think when testing it, it didn't give good
results and from what I could perceive, other devs don't seem to trust it to
work reliably which is why I put efl-indent in there.
Also I believe using a tested and used GNU app is better than using a custom
made one that might have bugs, and being able to easily configure the output
using arguments to indent makes it better than looking through ecrustify to
figure out what causes it to format a line the wrong way.
As for the format, I configured efl-indent to match what the wiki says
(other than one bug I'm not sure how to change, need to read the man page),
but the current issues is with the fact that each file seem to use a
different coding style (or different styles within the same file) and I'm
not sure what to do with these as they are undocumented in the wiki.
the wiki doesn't really cover the real formatting rules - so don't trust it.
trust actual code as examples of it. the only thing here that u can do is look
at the code and make sure it comes out looking right.
p.s: for trailing spaces (which is this mail's original subject), I use a
sed line in efl-indent to take care of that, at least that could safely be
put into a svn hook while we figure out the coding style issue.
its a totally stupid issue brought up by a bunch of vim users who have vim set
to please annoy me about spaces at the end of lines. the spacing does not
affect code quality nor readability. ESPECIALLY spaces at the start of blank
lines. i hit tab to indent and editors ADD the spaces in automatically. i'm not
going to manually go removing them each and every time to appease those that
wish to make their lives annoying. this is standard behavior on all editors.
On Fri, Oct 21, 2011 at 10:14 PM, Carsten Haitzler
ras...@rasterman.comwrote:
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui
kakar...@kakaroto.homelinux.net said:
Ha! I was about to start a thread about this specific issue!
I don't know if you noticed but I added a 'efl-indent' script in
FORMATTING
which uses GNU's indent. That works very good, and is used by GStreamer
to
do their code formatting.
GStreamer uses git and when you try to commit something that doesn't
match
the formatting code, it will not let you commit, and will show you how it
should have been.
Here is an example : http://pastie.org/2686190
I discussed this with SeoZ on #edevelop a couple of weeks ago. The script
might need some tweaking (the man page of indent is quite extensive) to
fit
the exact coding style of the efl (I think it's close now) but I noticed
a
lot of things aren't standardized, like struct { with the accolades on
the same line in some files and with it on separate lines in other files,
or
the number of spaces between a variable type and its name in a
declaration
(some align it, some don't), etc... all that stuff has to be defined and
respected across the board.
We can do a pre-commit hook in svn that would work just like its git
counterpart in GStreamer. But we'd need to reindent all the files for it
to
work, it could be done in a single commit but might cause conflicts to
devs,
or do it one file at a time, whenever it gets modified by someone, he'd
format it at the same time.
What do you think ?
umm that's why formatefl.sh is there. it actually gets very close to our
current
style. it has 1 annoying bug at the moment though. it actually compiles and
installs a custom re-formatter that's a fork of uncrustify that does a lot
more
than gnu indent does. the problem right now is in getting it to
consistently
100% of the time format the right way. right now the bug it has in sticking
spaces before prototype functionames is annoying and going to lead to
commit
hooks probably locking out commits permanently.
KaKaRoTo
On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri vto...@univ-evry.fr
wrote:
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote:
I raise this issue again.
We need pre/post-commit hook for formatting, whitespaces, and
whatever.
unfortunately, these hook will imply a lot of conflicts
Vincent
webkit already does this job.
Daniel Juyung Seo (SeoZ)
On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com
wrote:
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner
tho...@gstaedtner.net wrote:
That is true, but the Don't do that, nasty programmer. SPANK SPANK
SPANK mail tells you that the hook triggered and also it hurts the
programmer who did produce the trailing whitespaces. People learn
best
when it hurts :P
Automated emails might just go to spam, don't hurt that much. Unless
you intend to not accept the commit and make them do it over. That
