[EGIT] [bindings/python/python-efl] master 01/03: Elementary: Revert several RuntimeWarnings back to 1.7 behavior
kuuko pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=7a3883f5e2d08e23bb87de0e3953d7e5bb5e2def commit 7a3883f5e2d08e23bb87de0e3953d7e5bb5e2def Author: Kai Huuhko kai.huu...@gmail.com Date: Mon Dec 2 21:44:43 2013 +0200 Elementary: Revert several RuntimeWarnings back to 1.7 behavior The methods in entry, icon and object now return a bool value like they used to do in 1.7. --- efl/elementary/entry.pyx | 6 +++--- efl/elementary/icon.pyx | 12 efl/elementary/object.pyx | 47 ++- 3 files changed, 33 insertions(+), 32 deletions(-) diff --git a/efl/elementary/entry.pyx b/efl/elementary/entry.pyx index b3e9b4d..d52f16d 100644 --- a/efl/elementary/entry.pyx +++ b/efl/elementary/entry.pyx @@ -1970,11 +1970,11 @@ cdef class Entry(Object): :param selection: Selection type for copying and pasting :param format: Selection format -:raise RuntimeWarning: if getting cnp data fails. +:return bool: Whether getting cnp data is successful or not. -if not elm_cnp_selection_get(self.obj, selection, format, NULL, NULL): -raise RuntimeWarning(Could not get cnp data from widget.) +return bool(elm_cnp_selection_get( +self.obj, selection, format, NULL, NULL)) def callback_changed_add(self, func, *args, **kwargs): diff --git a/efl/elementary/icon.pyx b/efl/elementary/icon.pyx index c7e9a60..36a5f5e 100644 --- a/efl/elementary/icon.pyx +++ b/efl/elementary/icon.pyx @@ -218,11 +218,15 @@ cdef class Icon(Image): .. seealso:: Image.file :type: string -:raise RuntimeWarning: when setting the standard icon fails +:raise RuntimeWarning: when setting the standard name fails. + +:return bool: For 1.7 compatibility standard_set() returns a bool value +that tells whether setting the standard name was succesful or not. def __get__(self): return _ctouni(elm_icon_standard_get(self.obj)) + def __set__(self, name): if isinstance(name, unicode): name = PyUnicode_AsUTF8String(name) if not elm_icon_standard_set(self.obj, @@ -231,9 +235,8 @@ cdef class Icon(Image): def standard_set(self, name): if isinstance(name, unicode): name = PyUnicode_AsUTF8String(name) -if not elm_icon_standard_set(self.obj, -const_char *name if name is not None else NULL): -raise RuntimeWarning(Setting standard icon failed) +return elm_icon_standard_set(self.obj, +const_char *name if name is not None else NULL) def standard_get(self): return _ctouni(elm_icon_standard_get(self.obj)) @@ -245,6 +248,7 @@ cdef class Icon(Image): def __get__(self): return elm_icon_order_lookup_get(self.obj) + def __set__(self, order): elm_icon_order_lookup_set(self.obj, order) diff --git a/efl/elementary/object.pyx b/efl/elementary/object.pyx index 90c0871..69b741b 100644 --- a/efl/elementary/object.pyx +++ b/efl/elementary/object.pyx @@ -195,31 +195,27 @@ Defines the kind of action associated with the drop data if for XDND -from cpython cimport PyUnicode_AsUTF8String +from cpython cimport PyObject, Py_INCREF, Py_DECREF, PyObject_GetAttr, \ +PyObject_GetBuffer, PyBuffer_Release, PyBUF_SIMPLE, PyObject_CheckBuffer, \ +PyUnicode_AsUTF8String from efl.eo cimport _object_mapping_register -from efl.utils.conversions cimport _ctouni +from efl.utils.conversions cimport _ctouni, eina_list_objects_to_python_list +from efl.utils.deprecated cimport DEPRECATED from efl.evas cimport Object as evasObject - -from cpython cimport PyObject, Py_INCREF, Py_DECREF, PyObject_GetAttr, \ -PyObject_GetBuffer, PyBuffer_Release, PyBUF_SIMPLE, PyObject_CheckBuffer +from efl.evas cimport EventKeyDown, EventKeyUp, EventMouseWheel, \ +evas_object_smart_callback_add, evas_object_smart_callback_del include cnp_callbacks.pxi include tooltips.pxi -from efl.utils.conversions cimport eina_list_objects_to_python_list -from efl.utils.deprecated cimport DEPRECATED - -from efl.evas cimport EventKeyDown, EventKeyUp, EventMouseWheel -from efl.evas cimport evas_object_smart_callback_add -from efl.evas cimport evas_object_smart_callback_del -cimport efl.evas.enums as evasenums +from theme cimport Theme import logging log = logging.getLogger(elementary) import traceback -from theme cimport Theme +cimport efl.evas.enums as evasenums cimport enums ELM_FOCUS_PREVIOUS = enums.ELM_FOCUS_PREVIOUS @@ -1744,20 +1740,23 @@ cdef class Object(evasObject): :param buf: The data selected :type buf: An object that supports the new buffer interface -:raise RuntimeWarning: if setting cnp data fails. +:return bool: Whether setting cnp data was successful or not. -
Re: [E-devel] [EGIT] [core/efl] efl-1.8 01/02: FUCK - remove logic to silently add -release names to libtool builds
On Mon, 2 Dec 2013 13:50:35 -0200 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Mon, Dec 2, 2013 at 1:54 AM, Carsten Haitzler ras...@rasterman.com wrote: raster pushed a commit to branch efl-1.8. http://git.enlightenment.org/core/efl.git/commit/?id=4186fadce4c0166532c7290abc07466a332f72ce commit 4186fadce4c0166532c7290abc07466a332f72ce Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Dec 2 12:28:12 2013 +0900 FUCK - remove logic to silently add -release names to libtool builds sneaky hidden m4 rule to ADD -release to shared lib names IF profile != dev profile. come on! why do that? seriously. this snuck in and was undetected because i recompiled things against efl and thus things linked against the new releasename libs. this requires an efl 1.8.1. argh! --- m4/efl.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/efl.m4 b/m4/efl.m4 index 3671ba8..31c5f87 100644 --- a/m4/efl.m4 +++ b/m4/efl.m4 @@ -27,7 +27,7 @@ m4_define([v_min], [$2])dnl m4_define([v_mic], [$3])dnl m4_define([dev_version], m4_esyscmd([(git rev-list --count HEAD 2/dev/null || echo 0) | tr -d '\n']))dnl m4_define([v_rev], m4_if($4, dev, 2[dev_version], [0]))dnl -m4_define([v_rel], m4_if($4, dev, [], m4_ifblank($4, [], [-release $4])))dnl +m4_define([v_rel], [])dnl m4_define([def_build_profile], m4_if($4, dev, [dev], [release]))dnl dnl m4_define([efl_version], m4_if($4, dev, [v_maj.v_min.v_mic.v_rev], [v_maj.v_min.v_mic]))dnl m4_define([efl_version], [v_maj.v_min.v_mic])dnl I did that when I created this file to help with the previously messy code that had to be manually changed everytime, I recall it was like that before, no? but why force a change in soname just because we are NOT dev profile (debug or release)? that makes no sense. profile simply is the set of features on or off by default - or should be. there is no logical reason for it to go renaming shared libs... that was something we did long before efl 1.0 to ensure our api breakages prior to 1.0 didnt hurt as much. we havent used it since. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. 2013/12/2 Daniel Juyung Seo seojuyu...@gmail.com As 1.8.1 is out, how about updating docs pages to search 1.8 not 1.7? http://web.enlightenment.org/p.php?p=docsl=en Thanks in advance. Daniel Juyung Seo (SeoZ) On Mon, Dec 2, 2013 at 12:53 PM, Carsten Haitzler ras...@rasterman.com wrote: Due to a sneaky autofoo m4 macro issue, this resulted in library files being generated with -release names. this snuck past because i did full rebuilds including apps depending on efl and they just re-linked to the new releasename .so's. efl 1.8.1 is up now with this fixed. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ Enlightenment-intl mailing list enlightenment-i...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-intl -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
you cant see it unless you do 'git fetch --tags' On Mon, Dec 2, 2013 at 8:32 PM, Rafael Antognolli antogno...@gmail.comwrote: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? 2013/12/2 Daniel Juyung Seo seojuyu...@gmail.com As 1.8.1 is out, how about updating docs pages to search 1.8 not 1.7? http://web.enlightenment.org/p.php?p=docsl=en Thanks in advance. Daniel Juyung Seo (SeoZ) On Mon, Dec 2, 2013 at 12:53 PM, Carsten Haitzler ras...@rasterman.com wrote: Due to a sneaky autofoo m4 macro issue, this resulted in library files being generated with -release names. this snuck past because i did full rebuilds including apps depending on efl and they just re-linked to the new releasename .so's. efl 1.8.1 is up now with this fixed. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ Enlightenment-intl mailing list enlightenment-i...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-intl -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rafael Antognolli -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
Date: Tue, 3 Dec 2013 09:20:43 +0900 From: ras...@rasterman.com To: enlightenment-devel@lists.sourceforge.net CC: thanatermesis.e...@gmail.com Subject: Re: [E-devel] [Enlightenment-intl] EFL 1.8.1 On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. I'm seeing the same thing, the tag is there, but not showing up correctly.From what I can tell, it's in a separate branch with no head. No idea how or why. -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Mon, 2 Dec 2013 22:32:00 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? http://git.enlightenment.org/core/efl.git/ cgit can see it. 2013/12/2 Daniel Juyung Seo seojuyu...@gmail.com As 1.8.1 is out, how about updating docs pages to search 1.8 not 1.7? http://web.enlightenment.org/p.php?p=docsl=en Thanks in advance. Daniel Juyung Seo (SeoZ) On Mon, Dec 2, 2013 at 12:53 PM, Carsten Haitzler ras...@rasterman.com wrote: Due to a sneaky autofoo m4 macro issue, this resulted in library files being generated with -release names. this snuck past because i did full rebuilds including apps depending on efl and they just re-linked to the new releasename .so's. efl 1.8.1 is up now with this fixed. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ Enlightenment-intl mailing list enlightenment-i...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-intl -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rafael Antognolli -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Mon, Dec 2, 2013 at 10:42 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:32:00 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? http://git.enlightenment.org/core/efl.git/ cgit can see it. Doug is right. The tagged commit is not in the efl-1.8 branch (not even on master). This is the 1.8.1 commit on efl-1.8 branch: https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.8id=2af23d998a3be6dc4ef6e9c48d0927821d808014 And this is the commit that was tagged as v1.8.1: https://git.enlightenment.org/core/efl.git/commit/?id=dbc8e3cef9a414bf55dba3f3ddf4e08b85c48b1e They are different commits. And I don't know why, but it appears on cgit but doesn't on a local branch unless you fetch with --tags. I tried to clone the repository again, in a new location, and it still doesn't show the tag. Maybe it's because it's not in any branch, so no reason to fetch the tag. 2013/12/2 Daniel Juyung Seo seojuyu...@gmail.com As 1.8.1 is out, how about updating docs pages to search 1.8 not 1.7? http://web.enlightenment.org/p.php?p=docsl=en Thanks in advance. Daniel Juyung Seo (SeoZ) On Mon, Dec 2, 2013 at 12:53 PM, Carsten Haitzler ras...@rasterman.com wrote: Due to a sneaky autofoo m4 macro issue, this resulted in library files being generated with -release names. this snuck past because i did full rebuilds including apps depending on efl and they just re-linked to the new releasename .so's. efl 1.8.1 is up now with this fixed. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ Enlightenment-intl mailing list enlightenment-i...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-intl -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Mon, 2 Dec 2013 22:57:04 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:42 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:32:00 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? http://git.enlightenment.org/core/efl.git/ cgit can see it. Doug is right. The tagged commit is not in the efl-1.8 branch (not even on master). This is the 1.8.1 commit on efl-1.8 branch: https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.8id=2af23d998a3be6dc4ef6e9c48d0927821d808014 And this is the commit that was tagged as v1.8.1: https://git.enlightenment.org/core/efl.git/commit/?id=dbc8e3cef9a414bf55dba3f3ddf4e08b85c48b1e They are different commits. And I don't know why, but it appears on cgit but doesn't on a local branch unless you fetch with --tags. I tried to clone the repository again, in a new location, and it still doesn't show the tag. Maybe it's because it's not in any branch, so no reason to fetch the tag. well i tagged and i had to fix a conflict as well so maybe the tag got lost during the conflict fix somehow. i don't know what git was doing there, but i committed, tagged and pushed - push failed due to upstream having changed yet again! (seriously. this is why i try to push early because if you don't you end up here even more often - git is not a silver bullet), so i pulled, pull had a conflict - i resolved it, then push, then push --tags. 2013/12/2 Daniel Juyung Seo seojuyu...@gmail.com As 1.8.1 is out, how about updating docs pages to search 1.8 not 1.7? http://web.enlightenment.org/p.php?p=docsl=en Thanks in advance. Daniel Juyung Seo (SeoZ) On Mon, Dec 2, 2013 at 12:53 PM, Carsten Haitzler ras...@rasterman.com wrote: Due to a sneaky autofoo m4 macro issue, this resulted in library files being generated with -release names. this snuck past because i did full rebuilds including apps depending on efl and they just re-linked to the new releasename .so's. efl 1.8.1 is up now with this fixed. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ Enlightenment-intl mailing list enlightenment-i...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-intl -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net
[EGIT] [core/efl] master 01/01: ximmodule: check whether pointer is NULL before accessing in xim_preedit_callback_set
jihoon pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=8fe2ec9d4b6329f1859a975f9909358a5d2263d4
commit 8fe2ec9d4b6329f1859a975f9909358a5d2263d4
Author: Jihoon Kim jihoon48@samsung.com
Date: Tue Dec 3 13:32:15 2013 +0900
ximmodule: check whether pointer is NULL before accessing in
xim_preedit_callback_set
ecore_imf_context_data_get () can return NULL, so it should be checked
before using the result value.
This fixes CID 1135273
---
src/modules/ecore_imf/xim/ecore_imf_xim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/modules/ecore_imf/xim/ecore_imf_xim.c
b/src/modules/ecore_imf/xim/ecore_imf_xim.c
index 7243b42..da33e3c 100644
--- a/src/modules/ecore_imf/xim/ecore_imf_xim.c
+++ b/src/modules/ecore_imf/xim/ecore_imf_xim.c
@@ -1062,6 +1062,8 @@ _ecore_imf_xim_preedit_callback_set(Ecore_IMF_Context
*ctx)
{
Ecore_IMF_Context_Data *imf_context_data;
imf_context_data = ecore_imf_context_data_get(ctx);
+ if (!imf_context_data)
+ return XVaCreateNestedList(0, NULL);
imf_context_data-preedit_start_cb.client_data = (XPointer)ctx;
imf_context_data-preedit_start_cb.callback =
(XIMProc)_ecore_imf_xim_preedit_start_call;
--
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Mon, Dec 2, 2013 at 11:05 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:57:04 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:42 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:32:00 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? http://git.enlightenment.org/core/efl.git/ cgit can see it. Doug is right. The tagged commit is not in the efl-1.8 branch (not even on master). This is the 1.8.1 commit on efl-1.8 branch: https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.8id=2af23d998a3be6dc4ef6e9c48d0927821d808014 And this is the commit that was tagged as v1.8.1: https://git.enlightenment.org/core/efl.git/commit/?id=dbc8e3cef9a414bf55dba3f3ddf4e08b85c48b1e They are different commits. And I don't know why, but it appears on cgit but doesn't on a local branch unless you fetch with --tags. I tried to clone the repository again, in a new location, and it still doesn't show the tag. Maybe it's because it's not in any branch, so no reason to fetch the tag. well i tagged and i had to fix a conflict as well so maybe the tag got lost during the conflict fix somehow. i don't know what git was doing there, but i committed, tagged and pushed - push failed due to upstream having changed yet again! (seriously. this is why i try to push early because if you don't you end up here even more often - git is not a silver bullet), so i pulled, pull had a The problem is that you tagged one commit and pushed a rebased commit *and* the tagged commit (that now isn't on any branch). That's maybe one reason to force the --tags to actually push the tags. You can always push the commits first and later tag what is already public. Btw, you can see these things on your machine more easily by using tig, gitk or the like. Lucas De Marchi -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Enlightenment-intl] EFL 1.8.1
On Tue, 3 Dec 2013 03:07:25 -0200 Lucas De Marchi lucas.demar...@profusion.mobi said: On Mon, Dec 2, 2013 at 11:05 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:57:04 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:42 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 22:32:00 -0200 Rafael Antognolli antogno...@gmail.com said: On Mon, Dec 2, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 2 Dec 2013 21:43:38 +0100 Thanatermesis thanatermesis.e...@gmail.com said: BTW, if 1.8.1 is out, we need a proper v1.8.1 tag. with git tag -l i can see it listed, but this command is not reliable to get the last tagged value (version) on the branch, for that I use instead git describe --tag --abbrev=0, but it points to v1.8.0, is the tag wrongly set ? the tag will be on the 1.8 branch - so possibly you need to switch to it. That shouldn't be necessary, and actually doesn't show the tags to me. Is there anyone else who can't see the v1.8.1 tag, or is it just me? http://git.enlightenment.org/core/efl.git/ cgit can see it. Doug is right. The tagged commit is not in the efl-1.8 branch (not even on master). This is the 1.8.1 commit on efl-1.8 branch: https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.8id=2af23d998a3be6dc4ef6e9c48d0927821d808014 And this is the commit that was tagged as v1.8.1: https://git.enlightenment.org/core/efl.git/commit/?id=dbc8e3cef9a414bf55dba3f3ddf4e08b85c48b1e They are different commits. And I don't know why, but it appears on cgit but doesn't on a local branch unless you fetch with --tags. I tried to clone the repository again, in a new location, and it still doesn't show the tag. Maybe it's because it's not in any branch, so no reason to fetch the tag. well i tagged and i had to fix a conflict as well so maybe the tag got lost during the conflict fix somehow. i don't know what git was doing there, but i committed, tagged and pushed - push failed due to upstream having changed yet again! (seriously. this is why i try to push early because if you don't you end up here even more often - git is not a silver bullet), so i pulled, pull had a The problem is that you tagged one commit and pushed a rebased commit *and* the tagged commit (that now isn't on any branch). That's maybe one reason to force the --tags to actually push the tags. You can always push the commits first and later tag what is already public. Btw, you can see these things on your machine more easily by using tig, gitk or the like. Lucas De Marchi i would expect the tag to be applied to the conflict merged commit as it needs to be for it to ever be pushed. there is nothing in the git manpage about tagging specific commit revs, so i can only use it to tag what i currently am committing. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/terminology] master 01/01: theme selector - use gengrid instead of list
raster pushed a commit to branch master.
http://git.enlightenment.org/apps/terminology.git/commit/?id=83b8fec5273e60d156107cee2fc0923225c2e8a1
commit 83b8fec5273e60d156107cee2fc0923225c2e8a1
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Tue Dec 3 15:25:37 2013 +0900
theme selector - use gengrid instead of list
this makes the theme selector look much nicer. it's a step in the
right direction, but not 100% there. did this more as an example for
people filling in wallpaper and color selector (colors will need to
have a scheme/theme and preview too and then a way to edit a custom
theme/scheme).
---
src/bin/options_theme.c | 55 -
1 file changed, 41 insertions(+), 14 deletions(-)
diff --git a/src/bin/options_theme.c b/src/bin/options_theme.c
index 79d6e7c..fc2b648 100644
--- a/src/bin/options_theme.c
+++ b/src/bin/options_theme.c
@@ -9,10 +9,6 @@
#include utils.h
#include main.h
-static Evas_Object *op_themelist;
-
-static Eina_List *themes = NULL;
-
typedef struct _Theme Theme;
struct _Theme
{
@@ -21,6 +17,10 @@ struct _Theme
Evas_Object *term;
};
+static Evas_Object *op_themelist;
+static Eina_List *themes = NULL;
+static Ecore_Timer *seltimer = NULL;
+
static char *
_cb_op_theme_text_get(void *data, Evas_Object *obj EINA_UNUSED, const char
*part EINA_UNUSED)
{
@@ -79,11 +79,25 @@ _cb_op_theme_sort(const void *d1, const void *d2)
return strcasecmp(d1, d2);
}
+static Eina_Bool
+_cb_sel_item(void *data)
+{
+ Theme *t = data;
+
+ if (t)
+ {
+elm_gengrid_item_selected_set(t-item, EINA_TRUE);
+elm_gengrid_item_bring_in(t-item, ELM_GENGRID_ITEM_SCROLLTO_MIDDLE);
+ }
+ seltimer = NULL;
+ return EINA_FALSE;
+}
+
void
options_theme(Evas_Object *opbox, Evas_Object *term)
{
Evas_Object *o, *box, *fr;
- Elm_Genlist_Item_Class *it_class;
+ Elm_Gengrid_Item_Class *it_class;
Eina_List *files;
char buf[4096], *file;
Theme *t;
@@ -105,16 +119,17 @@ options_theme(Evas_Object *opbox, Evas_Object *term)
elm_object_content_set(fr, o);
evas_object_show(o);
- it_class = elm_genlist_item_class_new();
- it_class-item_style = end_icon;
+ it_class = elm_gengrid_item_class_new();
+ it_class-item_style = thumb;
it_class-func.text_get = _cb_op_theme_text_get;
it_class-func.content_get = _cb_op_theme_content_get;
- op_themelist = o = elm_genlist_add(opbox);
+ op_themelist = o = elm_gengrid_add(opbox);
evas_object_size_hint_weight_set(o, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(o, EVAS_HINT_FILL, EVAS_HINT_FILL);
- elm_genlist_mode_set(o, ELM_LIST_COMPRESS);
- elm_genlist_homogeneous_set(o, EINA_TRUE);
+ elm_gengrid_item_size_set(o,
+ elm_config_scale_get() * 160,
+ elm_config_scale_get() * 180);
snprintf(buf, sizeof(buf), %s/themes, elm_app_data_dir_get());
files = ecore_file_ls(buf);
@@ -122,6 +137,11 @@ options_theme(Evas_Object *opbox, Evas_Object *term)
files = eina_list_sort(files, eina_list_count(files),
_cb_op_theme_sort);
+ if (seltimer)
+ {
+ecore_timer_del(seltimer);
+seltimer = NULL;
+ }
EINA_LIST_FREE(files, file)
{
const char *ext = strchr(file, '.');
@@ -132,15 +152,17 @@ options_theme(Evas_Object *opbox, Evas_Object *term)
t = calloc(1, sizeof(Theme));
t-name = eina_stringshare_add(file);
t-term = term;
- t-item = elm_genlist_item_append(o, it_class, t, NULL,
- ELM_GENLIST_ITEM_NONE,
+ t-item = elm_gengrid_item_append(o, it_class, t,
_cb_op_theme_sel, t);
if (t-item)
{
themes = eina_list_append(themes, t);
if ((config-theme)
(!strcmp(config-theme, t-name)))
-elm_genlist_item_selected_set(t-item, EINA_TRUE);
+{
+ if (seltimer) ecore_timer_del(seltimer);
+ seltimer = ecore_timer_add(0.2, _cb_sel_item, t);
+}
}
else
{
@@ -151,7 +173,7 @@ options_theme(Evas_Object *opbox, Evas_Object *term)
free(file);
}
- elm_genlist_item_class_free(it_class);
+ elm_gengrid_item_class_free(it_class);
elm_box_pack_end(box, o);
evas_object_size_hint_weight_set(opbox, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
@@ -166,6 +188,11 @@ options_theme_clear(void)
op_themelist = NULL;
+ if (seltimer)
+ {
+ecore_timer_del(seltimer);
+seltimer = NULL;
+ }
EINA_LIST_FREE(themes, t)
{
eina_stringshare_del(t-name);
--
[EGIT] [core/elementary] master 01/01: theme - fix evrything theme elements for enlightenment
raster pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=ac183a608c71ed03b3f257929519a69f857e1423
commit ac183a608c71ed03b3f257929519a69f857e1423
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Tue Dec 3 16:39:58 2013 +0900
theme - fix evrything theme elements for enlightenment
this will fix T596 where the open mode is laid out badly. it also
fixes the text elements in the file borwser list mode to align text
properly.
---
data/themes/edc/evrything.edc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/data/themes/edc/evrything.edc b/data/themes/edc/evrything.edc
index 9b9a276..ec9de7b 100644
--- a/data/themes/edc/evrything.edc
+++ b/data/themes/edc/evrything.edc
@@ -61,6 +61,7 @@ group { name: e/modules/everything/main;
}
description { state: wide 0;
inherit: default 0.0;
+rel1.relative: 0.0 0.0;
rel2.relative: 0.5 1.0;
}
}
@@ -1610,7 +1611,8 @@ group { name: e/modules/everything/thumbview/item/list;
rel1.relative: 1.0 0.0;
rel1.to_x: icon0;
rel2.offset: -3 -3;
-rel2.relative: 1.0 1.0;
+rel2.relative: 0.0 1.0;
+rel2.to_x: arrow;
color: 255 255 255 255;
color3: 0 0 0 128;
color_class: ilist_item;
--
[EGIT] [core/elementary] elementary-1.8 01/01: theme - fix evrything theme elements for enlightenment
raster pushed a commit to branch elementary-1.8.
http://git.enlightenment.org/core/elementary.git/commit/?id=5068ced34874cf7f222c7f59043156a73090f25c
commit 5068ced34874cf7f222c7f59043156a73090f25c
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Tue Dec 3 16:39:58 2013 +0900
theme - fix evrything theme elements for enlightenment
this will fix T596 where the open mode is laid out badly. it also
fixes the text elements in the file borwser list mode to align text
properly.
---
data/themes/edc/evrything.edc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/data/themes/edc/evrything.edc b/data/themes/edc/evrything.edc
index 9b9a276..ec9de7b 100644
--- a/data/themes/edc/evrything.edc
+++ b/data/themes/edc/evrything.edc
@@ -61,6 +61,7 @@ group { name: e/modules/everything/main;
}
description { state: wide 0;
inherit: default 0.0;
+rel1.relative: 0.0 0.0;
rel2.relative: 0.5 1.0;
}
}
@@ -1610,7 +1611,8 @@ group { name: e/modules/everything/thumbview/item/list;
rel1.relative: 1.0 0.0;
rel1.to_x: icon0;
rel2.offset: -3 -3;
-rel2.relative: 1.0 1.0;
+rel2.relative: 0.0 1.0;
+rel2.to_x: arrow;
color: 255 255 255 255;
color3: 0 0 0 128;
color_class: ilist_item;
--
[EGIT] [core/efl] master 01/02: gitignore: ignore new async test.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=7cac8bceef0ddf1534f71c5d49f7906d5cd08060 commit 7cac8bceef0ddf1534f71c5d49f7906d5cd08060 Author: Cedric Bail cedric.b...@samsung.com Date: Tue Dec 3 11:48:48 2013 +0900 gitignore: ignore new async test. --- src/tests/efreet/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/efreet/.gitignore b/src/tests/efreet/.gitignore index 1d7a37c..9f9bdc1 100644 --- a/src/tests/efreet/.gitignore +++ b/src/tests/efreet/.gitignore @@ -3,6 +3,6 @@ /efreet_spec_test /efreet_test /efreet_user_dir - +/efreet_async_test /compare/efreet_alloc /compare/efreet_menu_alloc --
[EGIT] [core/efl] efl-1.8 01/01: evas: bugfix in evas_render of not maintaining changed flags on object correctly.
cedric pushed a commit to branch efl-1.8.
http://git.enlightenment.org/core/efl.git/commit/?id=95fb0e6d731a3bede51f1d12a981daa64f87b3a8
commit 95fb0e6d731a3bede51f1d12a981daa64f87b3a8
Author: Cedric Bail cedric.b...@samsung.com
Date: Tue Dec 3 16:23:05 2013 +0900
evas: bugfix in evas_render of not maintaining changed flags on object
correctly.
This bug is particularly visible in EFM video preview ( T 539 ). The
problem is
that the logic for changed has evolved over time. At the beginning Evas
canvas
was flat and could be handle in an array. It was then not using the changed
flag
that much. This day, we are living with a tree and we need to propagate the
changed flag to the parent, so that when we walk them we only need to walk
the
active objects and don't spend our time on branch that are completely
static.
Sadly things did collide here. We remove all object that have been rendered
from the pending_objects array. That does include any smart object that was
processed even if one of the child was not. Once any of the child of that
not
processed object is marked changed, it will be propagated up to the first
parent that is changed. As the parent of that one are marked as not changed
when evas_render walk the tree, he is blocked really early in the process
and
never get a chance to detect that the child of a not changed object did
change
and tada !
The fix is to add all the parent of all the object that are in the
pending_objects
array back into the pending_objects list. So they will always be marked as
changed.
Another alternative to this logic would have been to change pending_change
to
filter out those and keep them around. I choose the first solution as I
think it
will be more robust to catch all the parent in all case.
---
src/lib/evas/canvas/evas_render.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/lib/evas/canvas/evas_render.c
b/src/lib/evas/canvas/evas_render.c
index b12af6b..d33cd42 100644
--- a/src/lib/evas/canvas/evas_render.c
+++ b/src/lib/evas/canvas/evas_render.c
@@ -2048,6 +2048,21 @@ evas_render_updates_internal(Evas *eo_e,
them from the pending list. */
eina_array_remove(e-pending_objects, pending_change, NULL);
+ /* Reinsert parent of changed object in the pending changed state */
+ for (i = 0; i e-pending_objects.count; ++i)
+ {
+obj = eina_array_data_get(e-pending_objects, i);
+eo_obj = obj-object;
+if (obj-smart.parent)
+ {
+ Evas_Object_Protected_Data *smart_parent;
+
+ smart_parent = eo_data_scope_get(obj-smart.parent,
+ EVAS_OBJ_CLASS);
+ evas_object_change(obj-smart.parent, smart_parent);
+ }
+ }
+
for (i = 0; i e-render_objects.count; ++i)
{
obj = eina_array_data_get(e-render_objects, i);
@@ -2055,7 +2070,7 @@ evas_render_updates_internal(Evas *eo_e,
obj-pre_render_done = EINA_FALSE;
if ((obj-changed) (do_draw))
{
- obj-func-render_post(eo_obj, obj, obj-private_data);
+ obj-func-render_post(eo_obj, obj, obj-private_data);
obj-restack = EINA_FALSE;
evas_object_change_reset(eo_obj);
}
--
[EGIT] [core/efl] master 02/02: evas: bugfix in evas_render of not maintaining changed flags on object correctly.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f90803aa2fb2a201529cd1205702edc99bd180f6
commit f90803aa2fb2a201529cd1205702edc99bd180f6
Author: Cedric Bail cedric.b...@samsung.com
Date: Tue Dec 3 16:23:05 2013 +0900
evas: bugfix in evas_render of not maintaining changed flags on object
correctly.
This bug is particularly visible in EFM video preview ( T 539 ). The
problem is
that the logic for changed has evolved over time. At the beginning Evas
canvas
was flat and could be handle in an array. It was then not using the changed
flag
that much. This day, we are living with a tree and we need to propagate the
changed flag to the parent, so that when we walk them we only need to walk
the
active objects and don't spend our time on branch that are completely
static.
Sadly things did collide here. We remove all object that have been rendered
from the pending_objects array. That does include any smart object that was
processed even if one of the child was not. Once any of the child of that
not
processed object is marked changed, it will be propagated up to the first
parent that is changed. As the parent of that one are marked as not changed
when evas_render walk the tree, he is blocked really early in the process
and
never get a chance to detect that the child of a not changed object did
change
and tada !
The fix is to add all the parent of all the object that are in the
pending_objects
array back into the pending_objects list. So they will always be marked as
changed.
Another alternative to this logic would have been to change pending_change
to
filter out those and keep them around. I choose the first solution as I
think it
will be more robust to catch all the parent in all case.
---
src/lib/evas/canvas/evas_render.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/lib/evas/canvas/evas_render.c
b/src/lib/evas/canvas/evas_render.c
index b12af6b..d33cd42 100644
--- a/src/lib/evas/canvas/evas_render.c
+++ b/src/lib/evas/canvas/evas_render.c
@@ -2048,6 +2048,21 @@ evas_render_updates_internal(Evas *eo_e,
them from the pending list. */
eina_array_remove(e-pending_objects, pending_change, NULL);
+ /* Reinsert parent of changed object in the pending changed state */
+ for (i = 0; i e-pending_objects.count; ++i)
+ {
+obj = eina_array_data_get(e-pending_objects, i);
+eo_obj = obj-object;
+if (obj-smart.parent)
+ {
+ Evas_Object_Protected_Data *smart_parent;
+
+ smart_parent = eo_data_scope_get(obj-smart.parent,
+ EVAS_OBJ_CLASS);
+ evas_object_change(obj-smart.parent, smart_parent);
+ }
+ }
+
for (i = 0; i e-render_objects.count; ++i)
{
obj = eina_array_data_get(e-render_objects, i);
@@ -2055,7 +2070,7 @@ evas_render_updates_internal(Evas *eo_e,
obj-pre_render_done = EINA_FALSE;
if ((obj-changed) (do_draw))
{
- obj-func-render_post(eo_obj, obj, obj-private_data);
+ obj-func-render_post(eo_obj, obj, obj-private_data);
obj-restack = EINA_FALSE;
evas_object_change_reset(eo_obj);
}
--
[EGIT] [core/enlightenment] master 01/01: bump randr settings up 1 more epoch for e18 release
raster pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=59080c6752bbe515145e7928bbfd2ea0a6139216 commit 59080c6752bbe515145e7928bbfd2ea0a6139216 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Tue Dec 3 16:56:59 2013 +0900 bump randr settings up 1 more epoch for e18 release bump to epoch 3 (version 1 again) so that an e17.6 release can bump version up but then e18 bump it up again. --- src/bin/e_randr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/e_randr.h b/src/bin/e_randr.h index 86dd213..7264040 100644 --- a/src/bin/e_randr.h +++ b/src/bin/e_randr.h @@ -13,8 +13,8 @@ typedef struct _E_Randr_Config E_Randr_Config; #define E_RANDR_VERSION_1_3 ((1 16) | 3) #define E_RANDR_VERSION_1_4 ((1 16) | 4) -#define E_RANDR_CONFIG_FILE_EPOCH 2 -#define E_RANDR_CONFIG_FILE_GENERATION 3 +#define E_RANDR_CONFIG_FILE_EPOCH 3 +#define E_RANDR_CONFIG_FILE_GENERATION 1 #define E_RANDR_CONFIG_FILE_VERSION \ ((E_RANDR_CONFIG_FILE_EPOCH * 100) + E_RANDR_CONFIG_FILE_GENERATION) --
