Re: [E-devel] EFL + Elementary ABI report v1.17.0 alpha1

2016-01-26 Thread Tom Hacohen 
On 05/01/16 16:05, Tom Hacohen wrote:
> Hey,
>
> Here again, the new EFL + Elementary ABI reports.
>
> As usual:
> https://devs.enlightenment.org/~tasn/abi/
>
> --
> Tom.

Updated to beta3.

--
Tom.


--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: win: redo resize deferral to trigger during pre render

2016-01-26 Thread Daniel Zaoui 
Hi Mike,

I have an issue with that patch on Exactness. See the attachments.

By reverting this patch (+ conflict resolution), it works well.

Thank you
JackDanielZ


On Thu, 10 Dec 2015 12:56:23 -0800
Mike Blumenkrantz  wrote:

> discomfitor pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/elementary.git/commit/?id=6149fd7a0a9ef3f9495270cf1c4ab7727a30f21c
> 
> commit 6149fd7a0a9ef3f9495270cf1c4ab7727a30f21c
> Author: Mike Blumenkrantz 
> Date:   Thu Dec 10 15:53:31 2015 -0500
> 
> win: redo resize deferral to trigger during pre render
> 
> using a job results in the resize occurring after render in the
> same loop, meaning that anything which depends on resizes to happen
> in a certain time will not have synchronized display vs toolkit
> geometries 
> fixes all issues related to wayland window geometries
> ---
>  src/lib/elm_win.c | 19 ++-
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c
> index c9729ce..0012445 100644
> --- a/src/lib/elm_win.c
> +++ b/src/lib/elm_win.c
> @@ -130,7 +130,7 @@ struct _Elm_Win_Data
> } win32;
>  #endif
>  
> -   Ecore_Job *deferred_resize_job;
> +   Eina_Bool deferred_resize_job;
> Ecore_Job *deferred_child_eval_job;
>  
> Elm_Win_Type   type;
> @@ -824,7 +824,7 @@ _elm_win_resize_job(void *data)
> ELM_WIN_DATA_GET(data, sd);
> int w, h;
>  
> -   sd->deferred_resize_job = NULL;
> +   sd->deferred_resize_job = EINA_FALSE;
> ecore_evas_request_geometry_get(sd->ee, NULL, NULL, , );
> if (sd->constrain)
>   {
> @@ -848,13 +848,21 @@ _elm_win_resize_job(void *data)
>  }
>  
>  static void
> +_elm_win_pre_render(Ecore_Evas *ee)
> +{
> +   Elm_Win_Data *sd = _elm_win_associate_get(ee);
> +
> +   if (sd->deferred_resize_job)
> + _elm_win_resize_job(sd->obj);
> +}
> +
> +static void
>  _elm_win_resize(Ecore_Evas *ee)
>  {
> Elm_Win_Data *sd = _elm_win_associate_get(ee);
> if (!sd) return;
>  
> -   ecore_job_del(sd->deferred_resize_job);
> -   sd->deferred_resize_job = ecore_job_add(_elm_win_resize_job,
> sd->obj);
> +   sd->deferred_resize_job = EINA_TRUE;
>  }
>  
>  static void
> @@ -1945,7 +1953,6 @@ _elm_win_evas_object_smart_del(Eo *obj,
> Elm_Win_Data *sd) ecore_evas_callback_resize_set(sd->ee, NULL);
>   }
>  
> -   ecore_job_del(sd->deferred_resize_job);
> ecore_job_del(sd->deferred_child_eval_job);
> eina_stringshare_del(sd->shot.info);
> ecore_timer_del(sd->shot.timer);
> @@ -1992,6 +1999,7 @@ _elm_win_evas_object_smart_del(Eo *obj,
> Elm_Win_Data *sd) ecore_evas_callback_focus_out_set(sd->ee, NULL);
> ecore_evas_callback_move_set(sd->ee, NULL);
> ecore_evas_callback_state_change_set(sd->ee, NULL);
> +   ecore_evas_callback_pre_render_set(sd->ee, NULL);
>  
> eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
>  
> @@ -3856,6 +3864,7 @@ _elm_win_finalize_internal(Eo *obj,
> Elm_Win_Data *sd, const char *name, Elm_Win_
> ecore_evas_callback_focus_out_set(sd->ee, _elm_win_focus_out);
> ecore_evas_callback_resize_set(sd->ee, _elm_win_resize);
> ecore_evas_callback_move_set(sd->ee, _elm_win_move);
> +   ecore_evas_callback_pre_render_set(sd->ee, _elm_win_pre_render);
> if (type != ELM_WIN_FAKE)
>   ecore_evas_callback_mouse_in_set(sd->ee, _elm_win_mouse_in);
> evas_object_event_callback_add(obj, EVAS_CALLBACK_HIDE,
> _elm_win_cb_hide, NULL);
> 
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Eina value optional

2016-01-26 Thread Jean-Philippe André 
On 27 January 2016 at 00:03, Felipe Magno de Almeida <
felipe.m.alme...@gmail.com> wrote:

> On Tue, Jan 26, 2016 at 12:51 PM, Tom Hacohen  wrote:
> > On 26/01/16 14:42, Stefan Schmidt wrote:
> >> Hello.
>
> [snip]
>
> >> JP, Tom are you happy with Felipe's explanation? If not we need to act
> >> now as we only have 6 days left before the release and once it is in
> >> 1.17 it will stay.
> >
> > My concern was about the docs. Haven't reviewed the concept.
>
> There always were docs.
>
> https://build.enlightenment.org/job/nightly_efl_gcc_x86_64/lastSuccessfulBuild/artifact/doc/html/group__Eina__Value__Optional__Group.html
>
> It might be improved maybe with some motivation information.
> 
>

Yes, there are docs as to how, I was asking about why. And got my answer :)
The motivation can be documented as well, but it's not a release blocker.

Thanks,

-- 
Jean-Philippe André
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Work items for 1.17

2016-01-26 Thread Stefan Schmidt 
Hello.

Here is an updated version along with beta3. Thanks for all the people 
who already worked on some of these items!

Some more items have been tackled and I consider none of the items below 
a showstopper. If you think there is one let me know asap. From my side 
1.17 is on track for Monday.


Phab show stopper:
--
None


Phab high:
--

https://phab.enlightenment.org/T2835 elementary application segfaults 
when window type is set to ELM_WIN_SOCKET_IMAGE
https://phab.enlightenment.org/T2789 evas image delete crash
https://phab.enlightenment.org/T2708 Genlist tree+homogeneous broken
https://phab.enlightenment.org/T3069 Edc with textblock inside scroller 
not resizing properly.
https://phab.enlightenment.org/T3067 Focus highlighting position problem.

Coverity high impact:
-

EFL high impact:
CID 1347412 Resource leak (ector_gl_surface)
CID 1347409 Uninitialized pointer read (gl_x11 evas engine)
CID 1339963 Resource leak (gl_commna evas engine)
CID 1306604 Resource leak (edje_cc_out)
CID 1267458 Read from pointer after free (edje_cc_pick)


Elementary high impact:
None

New APIs with missing test cases:
-

Ecore_Evas.h
ecore_evas_wayland2_window_get ( Ecore_Evas const* ee )

Edje_Common.h
edje_mmap_size_class_iterator_new ( Eina_File* f )
edje_mmap_text_class_iterator_new ( Eina_File* f )
edje_size_class_active_iterator_new ( )
edje_size_class_del ( char const* size_class )
edje_text_class_active_iterator_new ( )

Efl_Model_Common.h
efl_model_error_notify ( Efl_Model_Base* model )
efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int
count )
efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum
Efl_Model_Load_Status status )
efl_model_property_changed_notify ( Efl_Model_Base* model, char const*
property )
efl_model_property_invalidated_notify ( Efl_Model_Base* model, char
const* property )
efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc )
efl_model_value_struct_description_new ( unsigned int member_count,
Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data )

eina_inline_value.x
eina_value_optional_empty_new ( )
eina_value_optional_type_get ( Eina_Value* value )

eina_value.h
eina_value_optional_new ( Eina_Value_Type const* subtype, void const*
value )

eldbus_freedesktop.h
eldbus_proxy_property_value_set ( Eldbus_Proxy* proxy, char const* name,
char const* sig, Eina_Value const* value, void(*cb)(void*,
Eldbus_Message const*, Eldbus_Pending*), void const* data )

eldbus_introspection.h
eldbus_introspection_argument_find ( Eina_List* arguments, char const*
name )
eldbus_introspection_interface_find ( Eina_List* interfaces, char const*
name )
eldbus_introspection_node_free ( Eldbus_Introspection_Node* node )
eldbus_introspection_parse ( char const* xml )
eldbus_introspection_property_find ( Eina_List* properties, char const*
name )


Smatch defects:
-

EFL:
src/lib/emile/emile_main.c:149 emile_pbkdf2_sha1() warn: right shifting
more than type allows
src/lib/emile/emile_main.c:150 emile_pbkdf2_sha1() warn: right shifting
more than type allows
src/lib/emile/emile_main.c:151 emile_pbkdf2_sha1() warn: right shifting
more than type allows
src/lib/emile/emile_cipher_openssl.c:611
_emile_cipher_client_handshake() warn: missing break? reassigning
'client->handshaking'

src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:442
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535
src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:470
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535
src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:489
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535
src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:520
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535
src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:542
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535
src/modules/evas/image_loaders/xpm/evas_image_load_xpm.c:580
evas_image_load_file_xpm() error: buffer overflow 'line' 256 <= 65535

src/lib/eet/eet_data.c:1755 _eet_descriptor_hash_new() warn: double
check that we're allocating correct size: 16 vs 1024
src/lib/eet/eet_data.c:4515 eet_data_get_variant() warn: double check
that we're allocating correct size: 12 vs 11

src/lib/eet/eet_lib.c:806 eet_internal_read2() warn: double check that
we're allocating correct size: 8 vs 2048
src/lib/eet/eet_lib.c:2251 eet_alias() warn: double check that we're
allocating correct size: 8 vs 2048
src/lib/eet/eet_lib.c:2372 eet_write_cipher() warn: double check that
we're allocating correct size: 8 vs 2048


Elementary:
src/lib/elm_datetime.c:300 _parse_format() error: buffer overflow
'mapping' 6 <= 6


regards
Stefan Schmidt

--
Site24x7 APM Insight: Get Deep Visibility into Application

Re: [E-devel] Eina value optional

2016-01-26 Thread Stefan Schmidt 
Hello.

On 13/01/16 11:56, Tom Hacohen wrote:
> On 13/01/16 02:38, Jean-Philippe André wrote:
>> Hi Felipe,
>>
>> You added the optional type to eina value. I'm not sure what it's point is.
>> I understand an optional value can be empty (ie. void and not "nil" or 0 or
>> whatever).
>>
>> But I don't understand why this couldn't be implemented inside all standard
>> values. Add an "empty" property to them.
>>
>> Could you explain shortly why we need a special type? I'm sure you had a
>> good reason :)
>>
>> Thanks in advance,
>>
> And please also add it to the docs. I assume it's not already there
> because of this question.

JP, Tom are you happy with Felipe's explanation? If not we need to act 
now as we only have 6 days left before the release and once it is in 
1.17 it will stay.

regards
Stefan Schmidt


--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Eina value optional

2016-01-26 Thread Tom Hacohen 
On 26/01/16 14:42, Stefan Schmidt wrote:
> Hello.
>
> On 13/01/16 11:56, Tom Hacohen wrote:
>> On 13/01/16 02:38, Jean-Philippe André wrote:
>>> Hi Felipe,
>>>
>>> You added the optional type to eina value. I'm not sure what it's point is.
>>> I understand an optional value can be empty (ie. void and not "nil" or 0 or
>>> whatever).
>>>
>>> But I don't understand why this couldn't be implemented inside all standard
>>> values. Add an "empty" property to them.
>>>
>>> Could you explain shortly why we need a special type? I'm sure you had a
>>> good reason :)
>>>
>>> Thanks in advance,
>>>
>> And please also add it to the docs. I assume it's not already there
>> because of this question.
>
> JP, Tom are you happy with Felipe's explanation? If not we need to act
> now as we only have 6 days left before the release and once it is in
> 1.17 it will stay.

My concern was about the docs. Haven't reviewed the concept.

--
Tom.


--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL + Elementary ABI report v1.17.0 alpha1

2016-01-26 Thread Stefan Schmidt 
Hello.

On 06/01/16 19:38, Cedric BAIL wrote:
> Hello,
>
> On Wed, Jan 6, 2016 at 7:52 AM, Stefan Schmidt  wrote:
>> On 05/01/16 17:05, Tom Hacohen wrote:
>>> Here again, the new EFL + Elementary ABI reports.
>>>
>>> As usual:
>>> https://devs.enlightenment.org/~tasn/abi/
>> My review for EFL. Happy about every other review or comment here.
>>
>> Ignoring the unstable EO APIs as well as ector which is marked as
>> unstable we have still a big number of new APIs:
>>
>> Ecore_Evas.h
>> ecore_evas_cocoa_window_get ( Ecore_Evas const* ee )
>> ecore_evas_wayland_window_get2 ( Ecore_Evas const* ee )
> get2 ? Is it something we usually do ? Why do we need a get2 ? I mean,
> we are in C switching to return a void * is not an ABI break and it
> would not create a new function (Arguably all this window_get could
> really be just the same function).

Are you fine with the renaming Chris did?

>> Efl_Model_Common.h
>> efl_model_error_notify ( Efl_Model_Base* model )
>> efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int
>> count )
>> efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum
>> Efl_Model_Load_Status status )
>> efl_model_property_changed_notify ( Efl_Model_Base* model, char const*
>> property )
>> efl_model_property_invalidated_notify ( Efl_Model_Base* model, char
>> const* property )
>> efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc )
>> efl_model_value_struct_description_new ( unsigned int member_count,
>> Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data )
> This should still be under BETA flag, isn't that the case ? To me the
> header is completely protected by the BETA flag.
>

Hmm, do you mean because it is included behind a #ifdef 
EFL_BETA_API_SUPPORT in Efl.h?

The Efl_Model_Common.h has no BETA_API guards at all and it is shipped 
which means anyone can include this without having to define the 
BETA_API in their app.
I think some guards inside Efl_Model_Common.h are also needed.

regards
Stefan Schmidt


--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Eina value optional

2016-01-26 Thread Felipe Magno de Almeida 
On Tue, Jan 26, 2016 at 12:51 PM, Tom Hacohen  wrote:
> On 26/01/16 14:42, Stefan Schmidt wrote:
>> Hello.

[snip]

>> JP, Tom are you happy with Felipe's explanation? If not we need to act
>> now as we only have 6 days left before the release and once it is in
>> 1.17 it will stay.
>
> My concern was about the docs. Haven't reviewed the concept.

There always were docs.
https://build.enlightenment.org/job/nightly_efl_gcc_x86_64/lastSuccessfulBuild/artifact/doc/html/group__Eina__Value__Optional__Group.html

It might be improved maybe with some motivation information.

> --
> Tom.

Regards,
-- 
Felipe Magno de Almeida

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL + Elementary ABI report v1.17.0 alpha1

2016-01-26 Thread Stefan Schmidt 
Hello.

On 08/01/16 01:27, Cedric BAIL wrote:
> On Thu, Jan 7, 2016 at 3:56 AM, Jean-Philippe André  wrote:
>> On 7 January 2016 at 03:38, Cedric BAIL  wrote:
 [...]
 Edje_Common.h
>>> edje_size_class_list ( )
>>>
>> I'm not a fan of this. It's just like text_class and color_class, so fine,
>> but I think an iterator would have been better.
>> Consistency is important, though.
> Yes, for consistency alone I agree on this API (Even if I prefer iterator).
>
 edje_mmap_size_class_iterator_new ( Eina_File* f )
 edje_mmap_text_class_iterator_new ( Eina_File* f )
 edje_size_class_active_iterator_new ( )
 edje_text_class_active_iterator_new ( )
>> OK, so those APIs are in fact useless right now.
>>
>> They return an iterator to a private struct: Edje_Size_Class or
>> Edje_Text_Class.
> Oh, interesting I didn't notice we didn't export those structure. We
> do export Edje_Color_Class and I was expecting the same behavior for
> this two class.
>
>> A few solutions:
>> - Make those structs public and STABLE
> Any reason why not doing so ?
>
>> - Keep them opaque but add APIs to inspect them (eg.
>> edje_size_class_iterator_item_name_get() ,
>> edje_size_class_iterator_item_del() ...)
> I don't like adding accessor that will need binding later on.
>
>> - Remove these APIs (they return a different set than the class_list
>> functions)
> This API has been useful for color class in the past, I am guessing it
> would be the same for this too.

What is the outcome for these above APIs?

>> Also, what about EO and bindings here?
> I am guessing we could expose a root singleton Edje object that this
> function get attached to, but the main question is would that be
> useful to an application ? I am not sure as this is something that
> elementary do act on. No obvious answer at this stage.
>
>> What do you guys think?
>>
>> All those APIs need test cases btw.
> True.
>
 Edje_Legacy.h
 edje_object_size_class_del ( Evas_Object* obj, char const* size_class )
 edje_object_text_class_del ( Evas_Object* obj, char const* text_class )
>>> I am fine with all the above one.
>> Are those necessary? Adding legacy APIs for new things.
>> No EO equivalent?
> Oh, that's a mistake it should have been an Eo API with automatically
> generated code for legacy. I didn't notice that. Thanks for pointing
> it, will fix it right away. It actually also apply to color_class_del
> !

I lost track on this one. Is it fixed?

regards
Stefan Schmidt

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL + Elementary ABI report v1.17.0 alpha1

2016-01-26 Thread Felipe Magno de Almeida 
On Tue, Jan 26, 2016 at 12:59 PM, Stefan Schmidt  wrote:
> Hello.

[snip]

>>> Efl_Model_Common.h
>>> efl_model_error_notify ( Efl_Model_Base* model )
>>> efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int
>>> count )
>>> efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum
>>> Efl_Model_Load_Status status )
>>> efl_model_property_changed_notify ( Efl_Model_Base* model, char const*
>>> property )
>>> efl_model_property_invalidated_notify ( Efl_Model_Base* model, char
>>> const* property )
>>> efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc )
>>> efl_model_value_struct_description_new ( unsigned int member_count,
>>> Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data )
>> This should still be under BETA flag, isn't that the case ? To me the
>> header is completely protected by the BETA flag.
>>
>
> Hmm, do you mean because it is included behind a #ifdef
> EFL_BETA_API_SUPPORT in Efl.h?
>
> The Efl_Model_Common.h has no BETA_API guards at all and it is shipped
> which means anyone can include this without having to define the
> BETA_API in their app.
> I think some guards inside Efl_Model_Common.h are also needed.

Should efl_model_base.eo.h be marked as beta as well? It doesn't
seem to be possible to define a whole class @beta in Eolian. But
it also gets shipped and can be directly included.

> regards
> Stefan Schmidt

Regards,
-- 
Felipe Magno de Almeida

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL + Elementary ABI report v1.17.0 alpha1

2016-01-26 Thread Cedric BAIL 
On Tue, Jan 26, 2016 at 3:44 PM, Felipe Magno de Almeida
 wrote:
> On Tue, Jan 26, 2016 at 12:59 PM, Stefan Schmidt  
> wrote:
>> Hello.
>
> [snip]
>
 Efl_Model_Common.h
 efl_model_error_notify ( Efl_Model_Base* model )
 efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int
 count )
 efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum
 Efl_Model_Load_Status status )
 efl_model_property_changed_notify ( Efl_Model_Base* model, char const*
 property )
 efl_model_property_invalidated_notify ( Efl_Model_Base* model, char
 const* property )
 efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc )
 efl_model_value_struct_description_new ( unsigned int member_count,
 Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data )
>>> This should still be under BETA flag, isn't that the case ? To me the
>>> header is completely protected by the BETA flag.
>>>
>>
>> Hmm, do you mean because it is included behind a #ifdef
>> EFL_BETA_API_SUPPORT in Efl.h?
>>
>> The Efl_Model_Common.h has no BETA_API guards at all and it is shipped
>> which means anyone can include this without having to define the
>> BETA_API in their app.
>> I think some guards inside Efl_Model_Common.h are also needed.
>
> Should efl_model_base.eo.h be marked as beta as well? It doesn't
> seem to be possible to define a whole class @beta in Eolian. But
> it also gets shipped and can be directly included.

This is true for all Efl* header. I don't think it is a real problem
as they would fail to compile without proper difficult to get right
include. We do only support direct include of the main header file and
nothing else. If someone does something else. To bad for them, no ?
-- 
Cedric BAIL

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel