[EGIT] [core/efl] master 03/05: examples/evas: Fix weird use of word synchrony in comment
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=9f9d2177bf9902aafe0cda4cd46f6171856414c0 commit 9f9d2177bf9902aafe0cda4cd46f6171856414c0 Author: Bryce HarringtonDate: Fri May 12 14:42:29 2017 +0900 examples/evas: Fix weird use of word synchrony in comment Summary: 'keep in sync' is more familiar programmer jargon. Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4876 --- src/examples/evas/evas-aspect-hints.c | 3 +-- src/examples/evas/evas-events.c | 3 +-- src/examples/evas/evas-hints.c | 3 +-- src/examples/evas/evas-images.c | 3 +-- src/examples/evas/evas-images2.c| 3 +-- src/examples/evas/evas-images3.c| 3 +-- src/examples/evas/evas-images4.c| 3 +-- src/examples/evas/evas-images5.c| 3 +-- src/examples/evas/evas-object-manipulation-eo.c | 3 +-- src/examples/evas/evas-object-manipulation.c| 3 +-- src/examples/evas/evas-smart-interface.c| 3 +-- src/examples/evas/evas-smart-object.c | 3 +-- src/examples/evas/evas-stacking.c | 3 +-- src/examples/evas/evas-table.c | 3 +-- src/examples/evas/evas-text.c | 3 +-- 15 files changed, 15 insertions(+), 30 deletions(-) diff --git a/src/examples/evas/evas-aspect-hints.c b/src/examples/evas/evas-aspect-hints.c index 9698d5b..fc3cfd7 100644 --- a/src/examples/evas/evas-aspect-hints.c +++ b/src/examples/evas/evas-aspect-hints.c @@ -42,8 +42,7 @@ struct test_data static struct test_data d = {0}; -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-events.c b/src/examples/evas/evas-events.c index 7838ce9..a76051c 100644 --- a/src/examples/evas/evas-events.c +++ b/src/examples/evas/evas-events.c @@ -48,8 +48,7 @@ struct test_data static struct test_data d = {0}; -/* here to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-hints.c b/src/examples/evas/evas-hints.c index 5ac91f5..dd2444e 100644 --- a/src/examples/evas/evas-hints.c +++ b/src/examples/evas/evas-hints.c @@ -92,8 +92,7 @@ struct test_data static struct test_data d = {0}; -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-images.c b/src/examples/evas/evas-images.c index 2cda226..61501c2 100644 --- a/src/examples/evas/evas-images.c +++ b/src/examples/evas/evas-images.c @@ -58,8 +58,7 @@ _on_destroy(Ecore_Evas *ee EINA_UNUSED) ecore_main_loop_quit(); } -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-images2.c b/src/examples/evas/evas-images2.c index ab1e598..3aa24ac 100644 --- a/src/examples/evas/evas-images2.c +++ b/src/examples/evas/evas-images2.c @@ -142,8 +142,7 @@ _on_destroy(Ecore_Evas *ee EINA_UNUSED) ecore_main_loop_quit(); } -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-images3.c b/src/examples/evas/evas-images3.c index 51e6ecb..5730acd 100644 --- a/src/examples/evas/evas-images3.c +++ b/src/examples/evas/evas-images3.c @@ -52,8 +52,7 @@ _on_destroy(Ecore_Evas *ee EINA_UNUSED) ecore_main_loop_quit(); } -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-images4.c b/src/examples/evas/evas-images4.c index 1dd0faa..63dcad9 100644 --- a/src/examples/evas/evas-images4.c +++ b/src/examples/evas/evas-images4.c @@ -58,8 +58,7 @@ _on_destroy(Ecore_Evas *ee EINA_UNUSED) ecore_main_loop_quit(); } -/* here just to keep our example's window size and background image's - * size in synchrony */ +/* Keep the example's window size in sync with the background image's size */ static void _canvas_resize_cb(Ecore_Evas *ee) { diff --git a/src/examples/evas/evas-images5.c b/src/examples/evas/evas-images5.c index
[EGIT] [core/efl] master 01/05: evas: Fix two whitespace errors
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6c2826db03e98e215e890d1fb227ccf2efe0c232 commit 6c2826db03e98e215e890d1fb227ccf2efe0c232 Author: Bryce HarringtonDate: Fri May 12 14:41:49 2017 +0900 evas: Fix two whitespace errors Summary: Removes extraneous newline, and fixes the indentation of the while statement's sub-clause (which looked like a code error at first glance). Signed-off-by: Bryce Harrington Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4875 --- src/lib/evas/canvas/evas_async_events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/evas/canvas/evas_async_events.c b/src/lib/evas/canvas/evas_async_events.c index 047b2eb..a903644 100644 --- a/src/lib/evas/canvas/evas_async_events.c +++ b/src/lib/evas/canvas/evas_async_events.c @@ -130,7 +130,6 @@ evas_async_events_init(void) _read_error = EINA_FALSE; _write_error = EINA_FALSE; - eina_spinlock_new(_lock); eina_inarray_step_set(_queue, sizeof (Eina_Inarray), sizeof (Evas_Event_Async), 16); @@ -197,7 +196,7 @@ evas_async_events_process(void) _event_count = 0; while (ecore_pipe_wait(_async_pipe, 1, 0.0)) - count = _event_count; + count = _event_count; return count; } --
[EGIT] [core/efl] master 05/05: popup: enable to set last_button_number to 0
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=9df368588465b37e8c6d775aeecded2173b1884f commit 9df368588465b37e8c6d775aeecded2173b1884f Author: JinYong ParkDate: Fri May 12 14:57:01 2017 +0900 popup: enable to set last_button_number to 0 Summary: If last added button is removed, any statements to set last_button_number in for loop doesn't be executed. So last button number has previous value, not 0. Because of that, action area is not removed, but that area has zero height, so it doesn't be shown. @fix Reviewers: herb, jpeg, cedric, singh.amitesh, raster Reviewed By: jpeg Subscribers: woohyun Differential Revision: https://phab.enlightenment.org/D4870 --- src/lib/elementary/elc_popup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/elementary/elc_popup.c b/src/lib/elementary/elc_popup.c index 7fa35ad..a24c1c0 100644 --- a/src/lib/elementary/elc_popup.c +++ b/src/lib/elementary/elc_popup.c @@ -613,6 +613,8 @@ _button_remove(Evas_Object *obj, ELM_SAFE_FREE(sd->buttons[pos], free); + sd->last_button_number = 0; + for (i = ELM_POPUP_ACTION_BUTTON_MAX - 1; i >= 0; i--) { if (sd->buttons[i]) --
[EGIT] [core/efl] master 02/05: efl_ui_focus_manager: Fix misspellings in comments
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=34d28a93ae56024fcf7bfaf5432a9f591380d073 commit 34d28a93ae56024fcf7bfaf5432a9f591380d073 Author: Bryce HarringtonDate: Fri May 12 14:42:04 2017 +0900 efl_ui_focus_manager: Fix misspellings in comments Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4877 --- src/lib/elementary/efl_ui_focus_manager.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/lib/elementary/efl_ui_focus_manager.c b/src/lib/elementary/efl_ui_focus_manager.c index 00741e7..9b8b71f 100644 --- a/src/lib/elementary/efl_ui_focus_manager.c +++ b/src/lib/elementary/efl_ui_focus_manager.c @@ -54,7 +54,7 @@ struct _Node{ Efl_Ui_Focus_Manager *redirect_manager; struct _Tree_Node{ -Node *parent; //the parent in the tree +Node *parent; //the parent of the tree Eina_List *children; //this saves the original set of elements Eina_List *safed_order; }tree; @@ -280,7 +280,7 @@ _calculate_node(Efl_Ui_Focus_Manager_Data *pd, Efl_Ui_Focus_Object *node, Dimens } -/* two only way the calculation does make sense is if the two number +/* The only way the calculation does make sense is if the two number * lines are not disconnected. * If they are connected one point of the 4 lies between the min and max of the other line */ @@ -764,13 +764,13 @@ _efl_ui_focus_manager_unregister(Eo *obj EINA_UNUSED, Efl_Ui_Focus_Manager_Data F_DBG("Manager: %p unregister %p", obj, child); - //remove the object from the stack if it hasnt dont that until now - //after this its not at the top anymore + //remove the object from the stack if it hasn't done that until now + //after this it's not at the top anymore //elm_widget_focus_set(node->focusable, EINA_FALSE); //delete again from the list, for the case it was not at the top pd->focus_stack = eina_list_remove(pd->focus_stack, node); - //add all neighboors of the node to the dirty list + //add all neighbors of the node to the dirty list for(int i = 0; i < 4; i++) { Node *partner; @@ -961,7 +961,7 @@ _coords_movement(Efl_Ui_Focus_Manager_Data *pd, Node *upper, Efl_Ui_Focus_Direct Node *candidate; Eina_List *node_list; - //we are searcing which of the partners is lower to the history + //we are searching which of the partners is lower to the history EINA_LIST_REVERSE_FOREACH(pd->focus_stack, node_list, candidate) { if (eina_list_data_find(G(upper).directions[direction].partners, candidate)) @@ -971,7 +971,7 @@ _coords_movement(Efl_Ui_Focus_Manager_Data *pd, Node *upper, Efl_Ui_Focus_Direct } } - //if we havent found anything in the history, use the widget with the smallest distance + //if we haven't found anything in the history, use the widget with the smallest distance { Eina_List *lst = G(upper).directions[direction].partners; Eina_List *n; @@ -1025,7 +1025,7 @@ _next(Node *node) return eina_list_data_get(T(node).children); } - //case 2 we are the root and we dont have children, return ourself + //case 2 we are the root and we don't have children, return ourself if (!T(node).parent) { return node; @@ -1076,11 +1076,11 @@ _prev(Node *node) return n; } - //case 2 there is a item in the parent preivous to node, which has no children + //case 2 there is a item in the parent previous to node, which has no children if (n) return n; - //case 3 there is a no item in the parent provious to this one + //case 3 there is a no item in the parent previous to this one return T(node).parent; } @@ -1228,7 +1228,7 @@ _efl_ui_focus_manager_focus(Eo *obj, Efl_Ui_Focus_Manager_Data *pd, Efl_Ui_Focus pd->focus_stack = eina_list_remove(pd->focus_stack, node); pd->focus_stack = eina_list_append(pd->focus_stack, node); -//safe fields we later need +//save fields we later need focusable = node->focusable; //populate the new change --
[EGIT] [core/efl] master 04/05: evas: Revise documentation for evas_async_events*()
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=226c1cff827c6c900a1ca8ea87ddc92683596514 commit 226c1cff827c6c900a1ca8ea87ddc92683596514 Author: Bryce HarringtonDate: Fri May 12 14:46:55 2017 +0900 evas: Revise documentation for evas_async_events*() Summary: Straightens up grammar and simplifies phrasing to make the functions purposes clearer. Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4874 --- src/lib/evas/Evas_Common.h | 45 ++--- 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/src/lib/evas/Evas_Common.h b/src/lib/evas/Evas_Common.h index 8fabb16..32cac7b 100644 --- a/src/lib/evas/Evas_Common.h +++ b/src/lib/evas/Evas_Common.h @@ -780,47 +780,39 @@ EAPI int evas_shutdown(void); EAPI Evas_Alloc_Error evas_alloc_error(void); /** - * @brief Get evas' internal asynchronous events read file descriptor. + * @brief Access the canvas' asynchronous event queue. * - * @return The canvas' asynchronous events read file descriptor. + * @return A file descriptor to the asynchronous events. * - * Evas' asynchronous events are meant to be dealt with internally, - * i.e., when building stuff to be glued together into the EFL - * infrastructure -- a module, for example. The context that demands - * its use is when calculations need to be done out of the main - * thread, asynchronously, and some action must be performed after - * that. + * Normally, Evas handles asynchronous events internally, particularly + * in Evas-using modules that are part of the EFL infrastructure. + * Notably, ecore-evas takes care of processing these events for + * canvases instantiated through it. * - * An example of actual use of this API is for image asynchronous - * preload inside evas. If the canvas was instantiated through - * ecore-evas usage, ecore itself will take care of calling those - * events' processing. - * - * This function returns the read file descriptor where to get the - * asynchronous events of the canvas. Naturally, other mainloops, - * apart from ecore, may make use of it. + * However, when asynchronous calculations need to be done outside the + * main thread (in some other mainloop) with some followup action, this + * function permits accessing the events. An example would be + * asynchronous image preloading. * * @ingroup Evas_Main_Group */ EAPI int evas_async_events_fd_get(void) EINA_WARN_UNUSED_RESULT; /** - * @brief Trigger the processing of all events waiting on the file - * descriptor returned by evas_async_events_fd_get(). + * @brief Process the asynchronous event queue. * * @return The number of events processed. * - * All asynchronous events queued up by evas_async_events_put() are - * processed here. More precisely, the callback functions, informed - * together with other event parameters, when queued, get called (with - * those parameters), in that order. + * Triggers the callback functions for asynchronous events that were + * queued up by evas_async_events_put(). The callbacks are called in + * the same order that they were queued. * * @ingroup Evas_Main_Group */ EAPI int evas_async_events_process(void); /** - * Insert asynchronous events on the canvas. + * @brief Insert asynchronous events on the canvas. * * @param target The target to be affected by the events. * @param type The type of callback function. @@ -829,10 +821,9 @@ EAPI int evas_async_events_process(void); * * @return EINA_FALSE if an error occurred, EINA_TRUE otherwise. * - * This is the way, for a routine running outside evas' main thread, - * to report an asynchronous event. A callback function is informed, - * whose call is to happen after evas_async_events_process() is - * called. + * Allows routines running outside Evas' main thread to report an + * asynchronous event. The target, type, and event info will be passed + * to the callback function when evas_async_events_process() is called. * * @ingroup Evas_Main_Group */ --
[EGIT] [apps/ecrire] master 01/01: disable x specific code in ecrire so it works on wayland
raster pushed a commit to branch master. http://git.enlightenment.org/apps/ecrire.git/commit/?id=20983dc2a2c737620c7aaf8f45d47d5e84e71334 commit 20983dc2a2c737620c7aaf8f45d47d5e84e71334 Author: Carsten Haitzler (Rasterman)Date: Fri May 12 14:40:00 2017 +0900 disable x specific code in ecrire so it works on wayland at least until this is done some other way... not sure exactly why it needs to know about selection ownership loss. - disable some widget... probably should have a smarrt cb on entry or something to make this work. @fix --- src/bin/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/bin/main.c b/src/bin/main.c index e2fe161..9c2a2e9 100644 --- a/src/bin/main.c +++ b/src/bin/main.c @@ -6,9 +6,11 @@ # include #endif +/* #ifdef HAVE_ECORE_X # include #endif +*/ #include @@ -567,6 +569,7 @@ editor_font_choose(Ecrire_Entry *ent, const char *font, int size) ecrire_cfg_save(); } +/* #ifdef HAVE_ECORE_X static Eina_Bool _selection_notify(void *data, int type __UNUSED__, void *_event) @@ -587,6 +590,7 @@ _selection_notify(void *data, int type __UNUSED__, void *_event) return ECORE_CALLBACK_PASS_ON; } #endif +*/ int main(int argc, char *argv[]) @@ -733,6 +737,7 @@ main(int argc, char *argv[]) elm_toolbar_item_append(tbar, "preferences-system", _("Settings"), _font_settings, main_ec_ent); +/* #ifdef HAVE_ECORE_X if (!ecore_x_selection_owner_get(ECORE_X_ATOM_SELECTION_CLIPBOARD)) { @@ -743,6 +748,7 @@ main(int argc, char *argv[]) ecore_event_handler_add(ECORE_X_EVENT_FIXES_SELECTION_NOTIFY, _selection_notify, main_ec_ent); #endif +*/ /* We don't have a selection when we start, make the items disabled */ elm_object_item_disabled_set(main_ec_ent->copy_item, EINA_TRUE); --
[EGIT] [core/efl] master 01/01: evas textblock: fix dereferenced memory after free issue for ellipsis
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f97920816d3e54fe0815d9d03777bbf747d54787 commit f97920816d3e54fe0815d9d03777bbf747d54787 Author: Youngbok ShinDate: Fri May 12 14:17:30 2017 +0900 evas textblock: fix dereferenced memory after free issue for ellipsis Summary: _layout_ellipsis_item_new() function deallocates "ellip_ti" and allocates memory for new one. The local "ellip_ti" pointer should be updated. @fix Test Plan: N/A Reviewers: raster, cedric, herdsman, jpeg, woohyun Differential Revision: https://phab.enlightenment.org/D4854 --- src/lib/evas/canvas/evas_object_textblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index 0555008..0a53730 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -5309,7 +5309,7 @@ _layout_par_ellipsis_items(Ctxt *c, double ellip) off += it->adv; } c->o->ellip_prev_it = i; - if (it) _layout_ellipsis_item_new(c, it); + if (it) ellip_ti = _layout_ellipsis_item_new(c, it); pos = (it && it->type == EVAS_TEXTBLOCK_ITEM_TEXT) ? --
Re: [E-devel] Express UI Ideas
On 05/12/2017 02:38 AM, Christopher Michael wrote: > > Hello All, > > As some of you may know, I have been refactoring the backend of the > Express IRC client. Well, the backend has reached a good stable point > with most IRC commands/responses being handled now (CTCP/DCC still need > implementing). > > I'd like to move on in refactoring the UIso I am writting this email > in order to solicit ideas from the community with regard to what users > would like to see in an IRC front-end. > > I would like to stay away from something as boring as an X-Chat > interface...preferring to come up with a unique interface that showcases > EFL abilities. > As someone who uses Hexchat / xchat daily I like the way it functionally presents its interface so maybe something starting with that and "blinging" it up alot / maybe merging ideas from other apps like rage or maybe terminology. I think it would be cool to have something like rages interface where you just have full screen with no controls until you mouse over (with the option to disable it for people who find it annoying, but with a hexchat like layout, channels on the left, users on the right and topic at the top. Gah now i'm off to have a play with gimp, you have succesfully just postponed a enlightenment release by a hour or 3 :-P -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Missed commit mails: efl.gfx.map
Hi, I pushed a new API set for evas map for EO. As it was already in my private branch and no one has done any commit on master since, the git commit ML hasn't sent any commit mails. I didn't intend to sneakily push those commits. So I'm sending this mail here. The contents are nothing crazy, just a better (or so I hope) API for maps. Best regards, -- Jean-Philippe André -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: evas map: Rename raw_coord to coord_absolute
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c6d6e130601567cc503ebab5cc9ded288536bbc1 commit c6d6e130601567cc503ebab5cc9ded288536bbc1 Author: Jean-Philippe AndreDate: Fri May 12 12:02:24 2017 +0900 evas map: Rename raw_coord to coord_absolute This is more in line with the other "absolute" APIs. --- src/bin/elementary/test_flip_page_eo.c | 12 ++-- src/examples/evas/evas-map-aa-eo.c | 18 +- src/examples/evas/evas-map-utils-eo.c | 8 src/lib/evas/canvas/efl_gfx_map.c | 8 src/lib/evas/canvas/efl_gfx_map.eo | 2 +- 5 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/bin/elementary/test_flip_page_eo.c b/src/bin/elementary/test_flip_page_eo.c index 0722822..cf88d02 100644 --- a/src/bin/elementary/test_flip_page_eo.c +++ b/src/bin/elementary/test_flip_page_eo.c @@ -96,25 +96,25 @@ _slice_apply(State *st, Slice *sl, if (st->dir == 0) { int p[4] = { 0, 1, 2, 3 }; - efl_gfx_map_raw_coord_set(sl->obj, i, ox + sl->x[p[i]], oy + sl->y[p[i]], sl->z[p[i]]); + efl_gfx_map_coord_absolute_set(sl->obj, i, ox + sl->x[p[i]], oy + sl->y[p[i]], sl->z[p[i]]); efl_gfx_map_uv_set(sl->obj, i, sl->u[p[i]] , sl->v[p[i]]); } else if (st->dir == 1) { int p[4] = { 1, 0, 3, 2 }; - efl_gfx_map_raw_coord_set(sl->obj, i, ox + (w - sl->x[p[i]]), oy + sl->y[p[i]], sl->z[p[i]]); + efl_gfx_map_coord_absolute_set(sl->obj, i, ox + (w - sl->x[p[i]]), oy + sl->y[p[i]], sl->z[p[i]]); efl_gfx_map_uv_set(sl->obj, i, 1. - sl->u[p[i]] , sl->v[p[i]]); } else if (st->dir == 2) { int p[4] = { 1, 0, 3, 2 }; - efl_gfx_map_raw_coord_set(sl->obj, i, ox + sl->y[p[i]], oy + sl->x[p[i]], sl->z[p[i]]); + efl_gfx_map_coord_absolute_set(sl->obj, i, ox + sl->y[p[i]], oy + sl->x[p[i]], sl->z[p[i]]); efl_gfx_map_uv_set(sl->obj, i, sl->v[p[i]] , sl->u[p[i]]); } else if (st->dir == 3) { int p[4] = { 0, 1, 2, 3 }; - efl_gfx_map_raw_coord_set(sl->obj, i, ox + sl->y[p[i]], oy + (w - sl->x[p[i]]), sl->z[p[i]]); + efl_gfx_map_coord_absolute_set(sl->obj, i, ox + sl->y[p[i]], oy + (w - sl->x[p[i]]), sl->z[p[i]]); efl_gfx_map_uv_set(sl->obj, i, sl->v[p[i]] , 1. - sl->u[p[i]]); } } @@ -131,8 +131,8 @@ _slice_3d(State *st EINA_UNUSED, Slice *sl, Evas_Coord x, Evas_Coord y, Evas_Coo { double xx, yy; -efl_gfx_map_raw_coord_get(sl->obj, i, , , NULL); -efl_gfx_map_raw_coord_set(sl->obj, i, xx, yy, 0); +efl_gfx_map_coord_absolute_get(sl->obj, i, , , NULL); +efl_gfx_map_coord_absolute_set(sl->obj, i, xx, yy, 0); } efl_gfx_visible_set(sl->obj, efl_gfx_map_clockwise_get(sl->obj)); } diff --git a/src/examples/evas/evas-map-aa-eo.c b/src/examples/evas/evas-map-aa-eo.c index 5b4c66f..3b6b78b 100644 --- a/src/examples/evas/evas-map-aa-eo.c +++ b/src/examples/evas/evas-map-aa-eo.c @@ -60,15 +60,15 @@ static struct exemple_data d = static void update(void) { - efl_gfx_map_raw_coord_set(d.target1, 0, d.px1, d.py1, 0); - efl_gfx_map_raw_coord_set(d.target1, 1, d.px2, d.py2, 0); - efl_gfx_map_raw_coord_set(d.target1, 2, d.px3, d.py3, 0); - efl_gfx_map_raw_coord_set(d.target1, 3, d.px4, d.py4, 0); - - efl_gfx_map_raw_coord_set(d.target2, 0, d.px1 + 400, d.py1, 0); - efl_gfx_map_raw_coord_set(d.target2, 1, d.px2 + 400, d.py2, 0); - efl_gfx_map_raw_coord_set(d.target2, 2, d.px3 + 400, d.py3, 0); - efl_gfx_map_raw_coord_set(d.target2, 3, d.px4 + 400, d.py4, 0); + efl_gfx_map_coord_absolute_set(d.target1, 0, d.px1, d.py1, 0); + efl_gfx_map_coord_absolute_set(d.target1, 1, d.px2, d.py2, 0); + efl_gfx_map_coord_absolute_set(d.target1, 2, d.px3, d.py3, 0); + efl_gfx_map_coord_absolute_set(d.target1, 3, d.px4, d.py4, 0); + + efl_gfx_map_coord_absolute_set(d.target2, 0, d.px1 + 400, d.py1, 0); + efl_gfx_map_coord_absolute_set(d.target2, 1, d.px2 + 400, d.py2, 0); + efl_gfx_map_coord_absolute_set(d.target2, 2, d.px3 + 400, d.py3, 0); + efl_gfx_map_coord_absolute_set(d.target2, 3, d.px4 + 400, d.py4, 0); } static void diff --git a/src/examples/evas/evas-map-utils-eo.c b/src/examples/evas/evas-map-utils-eo.c index fdf000e..6ce5fc0 100644 --- a/src/examples/evas/evas-map-utils-eo.c +++ b/src/examples/evas/evas-map-utils-eo.c @@ -131,10 +131,10 @@ _anim_cb(void *data) efl_gfx_map_reset(o); efl_gfx_map_smooth_set(o, ad->smooth); efl_gfx_map_alpha_set(o, ad->alpha); - efl_gfx_map_raw_coord_set(o, 0, x, y + h, 0); - efl_gfx_map_raw_coord_set(o, 1, x + w, y + h, 0); - efl_gfx_map_raw_coord_set(o, 2, win_w - 10, win_h - 30, 0); - efl_gfx_map_raw_coord_set(o, 3, (win_w / 2) + 10, win_h - 30,
[EGIT] [core/efl] master 01/01: elm_test: Add EO version of "Flip Page" test
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f1bb8c7ad9d662b787e1449658025b517c53aca4 commit f1bb8c7ad9d662b787e1449658025b517c53aca4 Author: Jean-Philippe AndreDate: Thu May 11 17:03:21 2017 +0900 elm_test: Add EO version of "Flip Page" test This is a copy of the "Flip Page" map usage example that relies on the new set of APIs for EO. This was used to test the API and show its usage. The calculation being done in absolute values, this does not really exploit the new API, but instead proves that it is on par feature-wise. The performance is worse than with legacy, because of extra list walkings, map calculations, small struct allocations and eo calls. This fixes the shadow of the page which was broken with the legacy API (as color_get did not recalc the map). A better implementation can probably be done without having to rely so much on absolute coordinates. --- src/Makefile_Elementary.am | 1 + src/bin/elementary/test.c | 2 + src/bin/elementary/test_flip_page.c| 3 +- .../{test_flip_page.c => test_flip_page_eo.c} | 137 + 4 files changed, 66 insertions(+), 77 deletions(-) diff --git a/src/Makefile_Elementary.am b/src/Makefile_Elementary.am index ae8bd09..db6dfa2 100644 --- a/src/Makefile_Elementary.am +++ b/src/Makefile_Elementary.am @@ -779,6 +779,7 @@ bin/elementary/test_fileselector.c \ bin/elementary/test_fileselector_entry.c \ bin/elementary/test_flip.c \ bin/elementary/test_flip_page.c \ +bin/elementary/test_flip_page_eo.c \ bin/elementary/test_flipselector.c \ bin/elementary/test_floating.c \ bin/elementary/test_focus.c \ diff --git a/src/bin/elementary/test.c b/src/bin/elementary/test.c index be0797d..b21a712 100644 --- a/src/bin/elementary/test.c +++ b/src/bin/elementary/test.c @@ -202,6 +202,7 @@ void test_flip3(void *data, Evas_Object *obj, void *event_info); void test_flip_interactive(void *data, Evas_Object *obj, void *event_info); void test_flip_to(void *data, Evas_Object *obj, void *event_info); void test_flip_page(void *data, Evas_Object *obj, void *event_info); +void test_flip_page_eo(void *data, Evas_Object *obj, void *event_info); void test_label(void *data, Evas_Object *obj, void *event_info); void test_label_slide(void *data, Evas_Object *obj, void *event_info); void test_label_wrap(void *data, Evas_Object *obj, void *event_info); @@ -768,6 +769,7 @@ add_tests: ADD_TEST(NULL, "Effects", "Flip Interactive", test_flip_interactive); ADD_TEST(NULL, "Effects", "Flip To", test_flip_to); ADD_TEST(NULL, "Effects", "Flip Page", test_flip_page); + ADD_TEST(NULL, "Effects", "Flip Page (EO API)", test_flip_page_eo); ADD_TEST(NULL, "Effects", "Animation", test_anim); //--// diff --git a/src/bin/elementary/test_flip_page.c b/src/bin/elementary/test_flip_page.c index 4dc2734..dc80342 100644 --- a/src/bin/elementary/test_flip_page.c +++ b/src/bin/elementary/test_flip_page.c @@ -151,7 +151,7 @@ _slice_3d(State *st EINA_UNUSED, Slice *sl, Evas_Coord x, Evas_Coord y, Evas_Coo static void _slice_light(State *st EINA_UNUSED, Slice *sl, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h) { - Evas_Map *m = (Evas_Map *)evas_object_map_get(sl->obj); + Evas_Map *m = evas_map_dup(evas_object_map_get(sl->obj)); int i; if (!m) return; @@ -174,6 +174,7 @@ _slice_light(State *st EINA_UNUSED, Slice *sl, Evas_Coord x, Evas_Coord y, Evas_ evas_map_point_color_set(m, i, r, g, b, a); } evas_object_map_set(sl->obj, m); + evas_map_free(m); } static void diff --git a/src/bin/elementary/test_flip_page.c b/src/bin/elementary/test_flip_page_eo.c similarity index 86% copy from src/bin/elementary/test_flip_page.c copy to src/bin/elementary/test_flip_page_eo.c index 4dc2734..0722822 100644 --- a/src/bin/elementary/test_flip_page.c +++ b/src/bin/elementary/test_flip_page_eo.c @@ -62,7 +62,7 @@ static State state = }; static Slice * -_slice_new(State *st EINA_UNUSED, Evas_Object *obj) +_slice_new(State *st EINA_UNUSED, Evas_Object *obj, int x, int y, int w, int h) { Slice *sl; @@ -72,6 +72,7 @@ _slice_new(State *st EINA_UNUSED, Evas_Object *obj) evas_object_image_smooth_scale_set(sl->obj, EINA_FALSE); evas_object_pass_events_set(sl->obj, EINA_TRUE); evas_object_image_source_set(sl->obj, obj); + evas_object_geometry_set(sl->obj, x, y, w, h); return sl; } @@ -87,93 +88,77 @@ _slice_apply(State *st, Slice *sl, Evas_Coord x EINA_UNUSED, Evas_Coord y EINA_UNUSED, Evas_Coord w, Evas_Coord h EINA_UNUSED, Evas_Coord ox, Evas_Coord oy, Evas_Coord ow, Evas_Coord oh) { - Evas_Map *m; - int i; - - m = evas_map_new(4); - if (!m) return; - evas_map_smooth_set(m, EINA_FALSE); - for (i = 0; i < 4; i++) +
Re: [E-devel] Can I use enlightenment on the kernel 4.11?
Hi Al! On 11.05.2017 21:16, Al Poole wrote: > Are you compiling your own kernels??? Yep, been doing so for the last 18 years. Force of habit I guess as I don't want stuff in my kernel that won't be used on my system anyway. :-) > If so, maybe you could talk to someone that packages up kernels for ideas? > > Personally, I wouldn't advise building any kernel from source unless you're > testing new features or building one for an embedded system...two pence for > you! Thanks for the advice. Would be interesting to get feedback from other users here that are running packaged 4.11 kernels provided by Debian and such. Then I might start comparing .config files. Cheers, Florian > On Thu, May 11, 2017 at 1:07 PM, Florian Schaeferwrote: > >> >> On 11.05.2017 12:33, Carsten Haitzler (The Rasterman) wrote: >>> On Wed, 10 May 2017 09:48:19 +0200 PaulTT said: >>> i just posted a message about this... (sorry, i've seen now this thread) as i said there, there's also a problem with unlocking (so, pam >> related, i assume ?) via console su and sudo worked like a charm (i've got error messages >> about cpufreq and backlight too) >>> >>> pam would be executing a setuid root binary to do the password check... >> so it's >>> the same issue. something has decided that e and app processes below it >> in the >>> process tree "cant run setuid (root) binaries" and has disabled that >> feature. >>> that feature seems to only kick in with 4.11 kernel. it certainly is not >> e >>> doing this. it has relied on this working for many years. it's something >> new >>> security-wise that is being enabled by a new kernel. >>> >>> maybe some parent process is using setpriv? CAP_SETUID disabled? man >>> capabilities ... for info ... maybe run captest ? >>> e >>> 12:20PM ~ > captest >>> User credentials uid:1000 euid:1000 suid:1000 >>> Group credentials gid:1000 egid:1000 sgid:1000 >>> Current capabilities: none >>> securebits flags: none >>> Attempting direct access to shadow...FAILED (Permission denied) >>> Attempting to access shadow by child process...FAILED >>> Child User credentials uid:1000 euid:1000 suid:1000 >>> Child Group credentials gid:1000 egid:1000 sgid:1000 >>> Child capabilities: none >>> Child securebits flags: none >>> >>> is what i get. which is normal. >> >> I get the same as you on my system here: >> >> florian@washu:~ # uname -a >> Linux washu 4.11.0 #2 SMP PREEMPT Tue May 2 12:12:51 JST 2017 i686 >> GNU/Linux >> florian@washu:~ # captest >> User credentials uid:500 euid:500 suid:500 >> Group credentials gid:100 egid:100 sgid:100 >> Current capabilities: none >> securebits flags: none >> Attempting direct access to shadow...FAILED (Permission denied) >> Attempting to access shadow by child process...FAILED >> Child User credentials uid:500 euid:500 suid:500 >> Child Group credentials gid:100 egid:100 sgid:100 >> Child capabilities: none >> Child securebits flags: none >> >> Cheers, >> Florian >> could the problem be related to some new sh**y systemd operation i saw that also using wayland, i coulnd't access halt/reboot/suspend >> menu items too (this happens to me also with previous kernels) >>> >>> works for me with enlightenment + wl + arch (+systemd)... i can do all >> the >>> power off etc. stuff... >>> On Thu, May 4, 2017 at 6:19 AM, Carsten Haitzler wrote: > On Thu, 04 May 2017 11:09:13 +0900 said: > >> Hi, >> >> Carsten Haitzler (The Rasterman) wrote: >> >>> On Wed, 3 May 2017 12:09:21 +0900 Florian Schaefer < >> list...@netego.de> > said: >> Hi! On 03.05.2017 10:04, Carsten Haitzler (The Rasterman) wrote: > On Tue, 02 May 2017 21:16:40 +0900 fulwood...@gmail.com said: > >> Hi, >> >> I got the source of kernel 4.11, then comipled, and check the >> behaviour of enlightenment (efl 1.18.1, enlightment 0.21.7). >> >> At the start up of enlightenment, I got an error message; >> >> There was an error trying to set the cpu power state setting via > the >> module's setfreq utility. >> >> On the kernel 4.10.x, I never see such a message. >> >> And, I tried to use su and sudo command in the terminal, I got a >> strange message; >> >> fulwood@linux-uw5l:~> sudo >> sudo: effective uid is not 0, is sudo installed setuid root >> >> fulwood@linux-uw5l:~> su >> Password: >> su: incorrect password >> >> This means, there is a problem concerning uid treatment in the >> enlightenment, doesn't it. >> >> Moreover, VirtualBox indicate the problem of enlightenment > directly; >> >> fulwood@linux-uw51:~> VirtualBox >> >> VirtualBox:
Re: [E-devel] Can I use enlightenment on the kernel 4.11?
On 11.05.2017 22:12, Carsten Haitzler (The Rasterman) wrote: > On Thu, 11 May 2017 21:07:20 +0900 Florian Schaefersaid: > >> >> On 11.05.2017 12:33, Carsten Haitzler (The Rasterman) wrote: >>> On Wed, 10 May 2017 09:48:19 +0200 PaulTT said: >>> i just posted a message about this... (sorry, i've seen now this thread) as i said there, there's also a problem with unlocking (so, pam related, i assume ?) via console su and sudo worked like a charm (i've got error messages about cpufreq and backlight too) >>> >>> pam would be executing a setuid root binary to do the password check... so >>> it's the same issue. something has decided that e and app processes below >>> it in the process tree "cant run setuid (root) binaries" and has disabled >>> that feature. that feature seems to only kick in with 4.11 kernel. it >>> certainly is not e doing this. it has relied on this working for many >>> years. it's something new security-wise that is being enabled by a new >>> kernel. >>> >>> maybe some parent process is using setpriv? CAP_SETUID disabled? man >>> capabilities ... for info ... maybe run captest ? >>> e >>> 12:20PM ~ > captest >>> User credentials uid:1000 euid:1000 suid:1000 >>> Group credentials gid:1000 egid:1000 sgid:1000 >>> Current capabilities: none >>> securebits flags: none >>> Attempting direct access to shadow...FAILED (Permission denied) >>> Attempting to access shadow by child process...FAILED >>> Child User credentials uid:1000 euid:1000 suid:1000 >>> Child Group credentials gid:1000 egid:1000 sgid:1000 >>> Child capabilities: none >>> Child securebits flags: none >>> >>> is what i get. which is normal. >> >> I get the same as you on my system here: >> >> florian@washu:~ # uname -a >> Linux washu 4.11.0 #2 SMP PREEMPT Tue May 2 12:12:51 JST 2017 i686 GNU/Linux >> florian@washu:~ # captest >> User credentials uid:500 euid:500 suid:500 >> Group credentials gid:100 egid:100 sgid:100 >> Current capabilities: none >> securebits flags: none >> Attempting direct access to shadow...FAILED (Permission denied) >> Attempting to access shadow by child process...FAILED >> Child User credentials uid:500 euid:500 suid:500 >> Child Group credentials gid:100 egid:100 sgid:100 >> Child capabilities: none >> Child securebits flags: none > > try capsh --print > ? > Current: = > Bounding set > =cap_chown,cap_dac_override,cap_dac_read_search,cap_fowner,cap_fsetid,cap_kill,cap_setgid,cap_setuid,cap_setpcap,cap_linux_immutable,cap_net_bind_service,cap_net_broadcast,cap_net_admin,cap_net_raw,cap_ipc_lock,cap_ipc_owner,cap_sys_module,cap_sys_rawio,cap_sys_chroot,cap_sys_ptrace,cap_sys_pacct,cap_sys_admin,cap_sys_boot,cap_sys_nice,cap_sys_resource,cap_sys_time,cap_sys_tty_config,cap_mknod,cap_lease,cap_audit_write,cap_audit_control,cap_setfcap,cap_mac_override,cap_mac_admin,cap_syslog,cap_wake_alarm,cap_block_suspend,cap_audit_read > Securebits: 00/0x0/1'b0 secure-noroot: no (unlocked) > secure-no-suid-fixup: no (unlocked) > secure-keep-caps: no (unlocked) > uid=1000(raster) > gid=1000(raster) > groups=5(tty),6(disk),7(lp),10(wheel),50(games),78(kvm),90(network),91(video),92 > (audio),93(optical),94(floppy),95(storage),96(scanner),98(power),100(users),492 > (oprofile),1000(raster) Oh, that's a nice command. :-) florian@washu:~ # /sbin/capsh --print Current: = Bounding set =cap_chown,cap_dac_override,cap_dac_read_search,cap_fowner,cap_fsetid,cap_kill,cap_setgid,cap_setuid,cap_setpcap,cap_linux_immutable,cap_net_bind_service,cap_net_broadcast,cap_net_admin,cap_net_raw,cap_ipc_lock,cap_ipc_owner,cap_sys_module,cap_sys_rawio,cap_sys_chroot,cap_sys_ptrace,cap_sys_pacct,cap_sys_admin,cap_sys_boot,cap_sys_nice,cap_sys_resource,cap_sys_time,cap_sys_tty_config,cap_mknod,cap_lease,cap_audit_write,cap_audit_control,cap_setfcap,cap_mac_override,cap_mac_admin,cap_syslog,cap_wake_alarm,cap_block_suspend,cap_audit_read Securebits: 00/0x0/1'b0 secure-noroot: no (unlocked) secure-no-suid-fixup: no (unlocked) secure-keep-caps: no (unlocked) uid=500(florian) gid=100(users) groups=20(dialout),24(cdrom),25(floppy),29(audio),30(dip),44(video),46(plugdev),100(users),106(camera),108(netdev),119(systemd-journal) It seems that I have cap_setuid. That's good, right? Cheers, Florian -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/enlightenment] master 01/01: Bryce/Gadgets: Add backlight, xkbswitch, and mixer gadgets. This should round out the core gadget ports.
okra pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=20f94cec74b7a7d1c28eabba1704a95e7dcc261d commit 20f94cec74b7a7d1c28eabba1704a95e7dcc261d Author: Stephen 'Okra' HoustonDate: Thu May 11 17:13:15 2017 -0500 Bryce/Gadgets: Add backlight, xkbswitch, and mixer gadgets. This should round out the core gadget ports. All three of these gadgets are ports of the existing modules of the same name and are contained within those directories. Once the move from shelves -> bryce and gadcon->gadgets is complete, backlight and mixer will likely need to go into the sysinfo gadget. --- src/modules/Makefile_backlight.mk | 5 +- src/modules/Makefile_mixer.mk | 3 + src/modules/Makefile_xkbswitch.mk | 5 +- src/modules/backlight/e_mod_main.c | 11 +- src/modules/backlight/gadget/backlight.c | 300 + src/modules/backlight/gadget/backlight.h | 16 + src/modules/backlight/gadget/mod.c | 27 + src/modules/mixer/e_mod_main.c | 10 +- src/modules/mixer/{e_mod_main.c => gadget/mixer.c} | 723 +++-- src/modules/mixer/gadget/mixer.h | 31 + src/modules/mixer/gadget/mod.c | 49 ++ src/modules/pager/gadget/mod.c | 6 +- src/modules/pager/gadget/pager.h | 6 +- src/modules/xkbswitch/e_mod_main.c | 10 +- src/modules/xkbswitch/gadget/mod.c | 28 + src/modules/xkbswitch/gadget/xkbswitch.c | 284 src/modules/xkbswitch/gadget/xkbswitch.h | 25 + 17 files changed, 1028 insertions(+), 511 deletions(-) diff --git a/src/modules/Makefile_backlight.mk b/src/modules/Makefile_backlight.mk index 2fbb123..37d5a8e 100644 --- a/src/modules/Makefile_backlight.mk +++ b/src/modules/Makefile_backlight.mk @@ -12,7 +12,10 @@ backlightpkg_LTLIBRARIES = src/modules/backlight/module.la src_modules_backlight_module_la_LIBADD = $(MOD_LIBS) src_modules_backlight_module_la_CPPFLAGS = $(MOD_CPPFLAGS) src_modules_backlight_module_la_LDFLAGS = $(MOD_LDFLAGS) -src_modules_backlight_module_la_SOURCES = src/modules/backlight/e_mod_main.c +src_modules_backlight_module_la_SOURCES = src/modules/backlight/e_mod_main.c \ + src/modules/backlight/gadget/backlight.h \ + src/modules/backlight/gadget/backlight.c \ + src/modules/backlight/gadget/mod.c PHONIES += backlight install-backlight backlight: $(backlightpkg_LTLIBRARIES) $(backlight_DATA) diff --git a/src/modules/Makefile_mixer.mk b/src/modules/Makefile_mixer.mk index 4f90cf1..5a8f53b 100644 --- a/src/modules/Makefile_mixer.mk +++ b/src/modules/Makefile_mixer.mk @@ -34,6 +34,9 @@ src_modules_mixer_module_la_SOURCES = src/modules/mixer/e_mod_main.c \ src/modules/mixer/e_mod_main.h \ src/modules/mixer/e_mod_config.c \ src/modules/mixer/e_mod_config.h \ + src/modules/mixer/gadget/mixer.h \ + src/modules/mixer/gadget/mixer.c \ + src/modules/mixer/gadget/mod.c \ $(emixerlib) src_modules_mixer_module_la_LIBADD = $(MOD_LIBS) @PULSE_LIBS@ @ALSA_LIBS@ diff --git a/src/modules/Makefile_xkbswitch.mk b/src/modules/Makefile_xkbswitch.mk index 1b4df52..00ef2ec 100644 --- a/src/modules/Makefile_xkbswitch.mk +++ b/src/modules/Makefile_xkbswitch.mk @@ -16,7 +16,10 @@ src_modules_xkbswitch_module_la_SOURCES = src/modules/xkbswitch/e_mod_main.c \ src/modules/xkbswitch/e_mod_main.h \ src/modules/xkbswitch/e_mod_config.c \ src/modules/xkbswitch/e_mod_parse.c \ - src/modules/xkbswitch/e_mod_parse.h + src/modules/xkbswitch/e_mod_parse.h \ + src/modules/xkbswitch/gadget/xkbswitch.h \ + src/modules/xkbswitch/gadget/xkbswitch.c \ + src/modules/xkbswitch/gadget/mod.c PHONIES += xkbswitch install-xkbswitch xkbswitch: $(xkbswitchpkg_LTLIBRARIES) $(xkbswitch_DATA) diff --git a/src/modules/backlight/e_mod_main.c b/src/modules/backlight/e_mod_main.c index e7e16bd..75356ed 100644 --- a/src/modules/backlight/e_mod_main.c +++ b/src/modules/backlight/e_mod_main.c @@ -10,6 +10,7 @@ */ #include "e.h" +#include "gadget/backlight.h" /* gadcon requirements */ static E_Gadcon_Client *_gc_init(E_Gadcon *gc, const char *name, const char *id, const char *style); @@ -469,6 +470,8 @@ E_API E_Module_Api e_modapi = E_API void * e_modapi_init(E_Module *m) { + e_modapi_gadget_init(m); + backlight_module = m;
[EGIT] [apps/terminology] master 01/01: configure: need efl ≥ 1.8.0
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=852047ea08e4d9f5e7c3b0f5527729a91e2f09ce commit 852047ea08e4d9f5e7c3b0f5527729a91e2f09ce Author: Boris FaureDate: Thu May 11 23:18:30 2017 +0200 configure: need efl ≥ 1.8.0 --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f638a85..fb10bf0 100644 --- a/configure.ac +++ b/configure.ac @@ -18,7 +18,7 @@ AC_PROG_CC AM_PROG_CC_C_O AC_C___ATTRIBUTE__ -efl_version="1.7.0" +efl_version="1.8.0" AC_SUBST(efl_version) --
Re: [E-devel] Express UI Ideas
On 05/11/2017 01:55 PM, Vincent Torri wrote: > On Thu, May 11, 2017 at 7:08 PM, Christopher Michael >wrote: >> >> Hello All, >> >> As some of you may know, I have been refactoring the backend of the >> Express IRC client. Well, the backend has reached a good stable point >> with most IRC commands/responses being handled now (CTCP/DCC still need >> implementing). >> >> I'd like to move on in refactoring the UIso I am writting this email >> in order to solicit ideas from the community with regard to what users >> would like to see in an IRC front-end. >> >> I would like to stay away from something as boring as an X-Chat >> interface...preferring to come up with a unique interface that showcases >> EFL abilities. >> >> If anyone would like to submit ideas (preferrably with attached mockups >> or some ASCII art which demonstrates the idea), please feel free. > > do you plan to change your mind and not using the terminology UI ? > > Vincent > The "terminology" type UI is still "on the table" as an option... I was just looking for other ideassomething "unique". If/When we get a few of these ideas, we could put them to a vote (perhaps a Phab poll). Chris -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Express UI Ideas
On Thu, May 11, 2017 at 7:08 PM, Christopher Michaelwrote: > > Hello All, > > As some of you may know, I have been refactoring the backend of the > Express IRC client. Well, the backend has reached a good stable point > with most IRC commands/responses being handled now (CTCP/DCC still need > implementing). > > I'd like to move on in refactoring the UIso I am writting this email > in order to solicit ideas from the community with regard to what users > would like to see in an IRC front-end. > > I would like to stay away from something as boring as an X-Chat > interface...preferring to come up with a unique interface that showcases > EFL abilities. > > If anyone would like to submit ideas (preferrably with attached mockups > or some ASCII art which demonstrates the idea), please feel free. do you plan to change your mind and not using the terminology UI ? Vincent -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Express UI Ideas
Hello All, As some of you may know, I have been refactoring the backend of the Express IRC client. Well, the backend has reached a good stable point with most IRC commands/responses being handled now (CTCP/DCC still need implementing). I'd like to move on in refactoring the UIso I am writting this email in order to solicit ideas from the community with regard to what users would like to see in an IRC front-end. I would like to stay away from something as boring as an X-Chat interface...preferring to come up with a unique interface that showcases EFL abilities. If anyone would like to submit ideas (preferrably with attached mockups or some ASCII art which demonstrates the idea), please feel free. Kind Regards, Christopher Michael -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment Developer Days 2017 Call for Papers
Hello. On 04/28/2017 11:30 AM, Stefan Schmidt wrote: > This years edition of the annual Enlightenment developer gathering will > take place Saturday 24th and Sunday 25th of June, 2017 in Valletta, Malta. > > For more information and registration (free, but needed due to limited > seats) see our event page. > > https://phab.enlightenment.org/w/events/enlightenment_developer_days_2017/ > > If you want to propose a talk, a hands on session, a hackathon theme or > something else please send a mail to efl-dev-day-...@lists.s-osg.org . > Title and short abstracts would be good as well as the time you expect > it will take. The same address can be used to request a VISA invitation > letter which might be needed for some folks. The mailing list mentioned here was not active until a few minutes ago. Sorry for that. Its fixed now and if you have submitted a proposal already please resend it. regards Stefan Schmidt -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Can I use enlightenment on the kernel 4.11?
On Thu, 11 May 2017 21:07:20 +0900 Florian Schaefersaid: > > On 11.05.2017 12:33, Carsten Haitzler (The Rasterman) wrote: > > On Wed, 10 May 2017 09:48:19 +0200 PaulTT said: > > > >> i just posted a message about this... (sorry, i've seen now this thread) > >> > >> as i said there, there's also a problem with unlocking (so, pam related, i > >> assume ?) > >> via console su and sudo worked like a charm (i've got error messages about > >> cpufreq and backlight too) > > > > pam would be executing a setuid root binary to do the password check... so > > it's the same issue. something has decided that e and app processes below > > it in the process tree "cant run setuid (root) binaries" and has disabled > > that feature. that feature seems to only kick in with 4.11 kernel. it > > certainly is not e doing this. it has relied on this working for many > > years. it's something new security-wise that is being enabled by a new > > kernel. > > > > maybe some parent process is using setpriv? CAP_SETUID disabled? man > > capabilities ... for info ... maybe run captest ? > >e > > 12:20PM ~ > captest > > User credentials uid:1000 euid:1000 suid:1000 > > Group credentials gid:1000 egid:1000 sgid:1000 > > Current capabilities: none > > securebits flags: none > > Attempting direct access to shadow...FAILED (Permission denied) > > Attempting to access shadow by child process...FAILED > > Child User credentials uid:1000 euid:1000 suid:1000 > > Child Group credentials gid:1000 egid:1000 sgid:1000 > > Child capabilities: none > > Child securebits flags: none > > > > is what i get. which is normal. > > I get the same as you on my system here: > > florian@washu:~ # uname -a > Linux washu 4.11.0 #2 SMP PREEMPT Tue May 2 12:12:51 JST 2017 i686 GNU/Linux > florian@washu:~ # captest > User credentials uid:500 euid:500 suid:500 > Group credentials gid:100 egid:100 sgid:100 > Current capabilities: none > securebits flags: none > Attempting direct access to shadow...FAILED (Permission denied) > Attempting to access shadow by child process...FAILED > Child User credentials uid:500 euid:500 suid:500 > Child Group credentials gid:100 egid:100 sgid:100 > Child capabilities: none > Child securebits flags: none try capsh --print ? Current: = Bounding set =cap_chown,cap_dac_override,cap_dac_read_search,cap_fowner,cap_fsetid,cap_kill,cap_setgid,cap_setuid,cap_setpcap,cap_linux_immutable,cap_net_bind_service,cap_net_broadcast,cap_net_admin,cap_net_raw,cap_ipc_lock,cap_ipc_owner,cap_sys_module,cap_sys_rawio,cap_sys_chroot,cap_sys_ptrace,cap_sys_pacct,cap_sys_admin,cap_sys_boot,cap_sys_nice,cap_sys_resource,cap_sys_time,cap_sys_tty_config,cap_mknod,cap_lease,cap_audit_write,cap_audit_control,cap_setfcap,cap_mac_override,cap_mac_admin,cap_syslog,cap_wake_alarm,cap_block_suspend,cap_audit_read Securebits: 00/0x0/1'b0 secure-noroot: no (unlocked) secure-no-suid-fixup: no (unlocked) secure-keep-caps: no (unlocked) uid=1000(raster) gid=1000(raster) groups=5(tty),6(disk),7(lp),10(wheel),50(games),78(kvm),90(network),91(video),92 (audio),93(optical),94(floppy),95(storage),96(scanner),98(power),100(users),492 (oprofile),1000(raster) > Cheers, > Florian > > >> could the problem be related to some new sh**y systemd operation > >> i saw that also using wayland, i coulnd't access halt/reboot/suspend menu > >> items too (this happens to me also with previous kernels) > > > > works for me with enlightenment + wl + arch (+systemd)... i can do all the > > power off etc. stuff... > > > >> On Thu, May 4, 2017 at 6:19 AM, Carsten Haitzler > >> wrote: > >> > >>> On Thu, 04 May 2017 11:09:13 +0900 said: > >>> > Hi, > > Carsten Haitzler (The Rasterman) wrote: > > > On Wed, 3 May 2017 12:09:21 +0900 Florian Schaefer > >>> said: > > >> Hi! > >> > >> On 03.05.2017 10:04, Carsten Haitzler (The Rasterman) wrote: > >>> On Tue, 02 May 2017 21:16:40 +0900 fulwood...@gmail.com said: > >>> > Hi, > > I got the source of kernel 4.11, then comipled, and check the > behaviour of enlightenment (efl 1.18.1, enlightment 0.21.7). > > At the start up of enlightenment, I got an error message; > > There was an error trying to set the cpu power state setting via > >>> the > module's setfreq utility. > > On the kernel 4.10.x, I never see such a message. > > And, I tried to use su and sudo command in the terminal, I got a > strange message; > > fulwood@linux-uw5l:~> sudo > sudo: effective uid is not 0, is sudo installed setuid root > > fulwood@linux-uw5l:~> su > Password: > su: incorrect password > > This means, there is a problem concerning uid treatment in the > enlightenment,
Re: [E-devel] Can I use enlightenment on the kernel 4.11?
Are you compiling your own kernels??? If so, maybe you could talk to someone that packages up kernels for ideas? Personally, I wouldn't advise building any kernel from source unless you're testing new features or building one for an embedded system...two pence for you! On Thu, May 11, 2017 at 1:07 PM, Florian Schaeferwrote: > > On 11.05.2017 12:33, Carsten Haitzler (The Rasterman) wrote: > > On Wed, 10 May 2017 09:48:19 +0200 PaulTT said: > > > >> i just posted a message about this... (sorry, i've seen now this thread) > >> > >> as i said there, there's also a problem with unlocking (so, pam > related, i > >> assume ?) > >> via console su and sudo worked like a charm (i've got error messages > about > >> cpufreq and backlight too) > > > > pam would be executing a setuid root binary to do the password check... > so it's > > the same issue. something has decided that e and app processes below it > in the > > process tree "cant run setuid (root) binaries" and has disabled that > feature. > > that feature seems to only kick in with 4.11 kernel. it certainly is not > e > > doing this. it has relied on this working for many years. it's something > new > > security-wise that is being enabled by a new kernel. > > > > maybe some parent process is using setpriv? CAP_SETUID disabled? man > > capabilities ... for info ... maybe run captest ? > >e > > 12:20PM ~ > captest > > User credentials uid:1000 euid:1000 suid:1000 > > Group credentials gid:1000 egid:1000 sgid:1000 > > Current capabilities: none > > securebits flags: none > > Attempting direct access to shadow...FAILED (Permission denied) > > Attempting to access shadow by child process...FAILED > > Child User credentials uid:1000 euid:1000 suid:1000 > > Child Group credentials gid:1000 egid:1000 sgid:1000 > > Child capabilities: none > > Child securebits flags: none > > > > is what i get. which is normal. > > I get the same as you on my system here: > > florian@washu:~ # uname -a > Linux washu 4.11.0 #2 SMP PREEMPT Tue May 2 12:12:51 JST 2017 i686 > GNU/Linux > florian@washu:~ # captest > User credentials uid:500 euid:500 suid:500 > Group credentials gid:100 egid:100 sgid:100 > Current capabilities: none > securebits flags: none > Attempting direct access to shadow...FAILED (Permission denied) > Attempting to access shadow by child process...FAILED > Child User credentials uid:500 euid:500 suid:500 > Child Group credentials gid:100 egid:100 sgid:100 > Child capabilities: none > Child securebits flags: none > > Cheers, > Florian > > >> could the problem be related to some new sh**y systemd operation > >> i saw that also using wayland, i coulnd't access halt/reboot/suspend > menu > >> items too (this happens to me also with previous kernels) > > > > works for me with enlightenment + wl + arch (+systemd)... i can do all > the > > power off etc. stuff... > > > >> On Thu, May 4, 2017 at 6:19 AM, Carsten Haitzler > >> wrote: > >> > >>> On Thu, 04 May 2017 11:09:13 +0900 said: > >>> > Hi, > > Carsten Haitzler (The Rasterman) wrote: > > > On Wed, 3 May 2017 12:09:21 +0900 Florian Schaefer < > list...@netego.de> > >>> said: > > >> Hi! > >> > >> On 03.05.2017 10:04, Carsten Haitzler (The Rasterman) wrote: > >>> On Tue, 02 May 2017 21:16:40 +0900 fulwood...@gmail.com said: > >>> > Hi, > > I got the source of kernel 4.11, then comipled, and check the > behaviour of enlightenment (efl 1.18.1, enlightment 0.21.7). > > At the start up of enlightenment, I got an error message; > > There was an error trying to set the cpu power state setting via > >>> the > module's setfreq utility. > > On the kernel 4.10.x, I never see such a message. > > And, I tried to use su and sudo command in the terminal, I got a > strange message; > > fulwood@linux-uw5l:~> sudo > sudo: effective uid is not 0, is sudo installed setuid root > > fulwood@linux-uw5l:~> su > Password: > su: incorrect password > > This means, there is a problem concerning uid treatment in the > enlightenment, doesn't it. > > Moreover, VirtualBox indicate the problem of enlightenment > >>> directly; > > fulwood@linux-uw51:~> VirtualBox > > VirtualBox: Error -10 in SUPRHardenedMain! > VirtualBox: Effective UID is not root (euid=1000, egid=100, > >>> uid=1000, > gid=100) > VirtualBox: Tip! It may help to reintall VirtualBox. > > Why does uid=1000? > >>> > >>> that's a common uid to start with for users added to a system - > >>> first > >>> user added commonly is uid 1000... that's probably ... you. > >>> > So, we
Re: [E-devel] Weekly news from the automated build and QA front
Thanks! On Thu, May 11, 2017 at 4:16 AM Carsten Haitzlerwrote: > On Tue, 09 May 2017 12:43:39 + Mike Blumenkrantz > said: > > > Hi raster, > > > > Can you look at CID1365406 for Enlightenment? I requested this last year > > and it seems you still have not gotten to it... > > forgot about it... sorry. > > but really. it's not a bug. it's coverity being... coverity. :) > > > On Mon, May 8, 2017 at 4:08 AM Stefan Schmidt > > wrote: > > > > > Hello. > > > > > > Summary: > > > o A few more bug reports and a few more new patches, nothing else > really. > > > > > > This should give everyone an overview over what has happened in the > last > > > week on the QA front. The numbers in parentheses reflect the values > from > > > last week to give you a trend. > > > > > > CI: > > > o Overall build statistic: 2.70% (2.70%) failed. > > > https://build.enlightenment.org/ > > > > > > Unit tests: > > > o N/A (N/A) unit tests for efl > > > > > > Coverage: > > > o EFL total coverage is at N/A% (N/A%) lines, N/A% (N/A%) functions and > > > N/A (N/A) branches > > > https://build.enlightenment.org/view/Test%20Coverage/ > > > > > > Coverity: > > > o EFL: Outstanding defects 45 (45) with a density of 0.04 (0.04) > > > o Enlightenment: Outstanding defects 2 (2) with a density of 0.01 > (0.01) > > > o Terminology: Outstanding defects 0 (0) with a density of 0 (0) > > > o Rage: Outstanding defects 0 (0) with a density of 0 (0) > > > > > > Phab: > > > o EFL bug count: 393 (390) > > > o E bug count: 414 (414) > > > https://phab.enlightenment.org/maniphest/report/burn/ > > > o Pending patch reviews: 167 (161) > > > > > > regards > > > Stefan Schmidt > > > > > > > > > > -- > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Can I use enlightenment on the kernel 4.11?
On 11.05.2017 12:33, Carsten Haitzler (The Rasterman) wrote: > On Wed, 10 May 2017 09:48:19 +0200 PaulTTsaid: > >> i just posted a message about this... (sorry, i've seen now this thread) >> >> as i said there, there's also a problem with unlocking (so, pam related, i >> assume ?) >> via console su and sudo worked like a charm (i've got error messages about >> cpufreq and backlight too) > > pam would be executing a setuid root binary to do the password check... so > it's > the same issue. something has decided that e and app processes below it in the > process tree "cant run setuid (root) binaries" and has disabled that feature. > that feature seems to only kick in with 4.11 kernel. it certainly is not e > doing this. it has relied on this working for many years. it's something new > security-wise that is being enabled by a new kernel. > > maybe some parent process is using setpriv? CAP_SETUID disabled? man > capabilities ... for info ... maybe run captest ? >e > 12:20PM ~ > captest > User credentials uid:1000 euid:1000 suid:1000 > Group credentials gid:1000 egid:1000 sgid:1000 > Current capabilities: none > securebits flags: none > Attempting direct access to shadow...FAILED (Permission denied) > Attempting to access shadow by child process...FAILED > Child User credentials uid:1000 euid:1000 suid:1000 > Child Group credentials gid:1000 egid:1000 sgid:1000 > Child capabilities: none > Child securebits flags: none > > is what i get. which is normal. I get the same as you on my system here: florian@washu:~ # uname -a Linux washu 4.11.0 #2 SMP PREEMPT Tue May 2 12:12:51 JST 2017 i686 GNU/Linux florian@washu:~ # captest User credentials uid:500 euid:500 suid:500 Group credentials gid:100 egid:100 sgid:100 Current capabilities: none securebits flags: none Attempting direct access to shadow...FAILED (Permission denied) Attempting to access shadow by child process...FAILED Child User credentials uid:500 euid:500 suid:500 Child Group credentials gid:100 egid:100 sgid:100 Child capabilities: none Child securebits flags: none Cheers, Florian >> could the problem be related to some new sh**y systemd operation >> i saw that also using wayland, i coulnd't access halt/reboot/suspend menu >> items too (this happens to me also with previous kernels) > > works for me with enlightenment + wl + arch (+systemd)... i can do all the > power off etc. stuff... > >> On Thu, May 4, 2017 at 6:19 AM, Carsten Haitzler >> wrote: >> >>> On Thu, 04 May 2017 11:09:13 +0900 said: >>> Hi, Carsten Haitzler (The Rasterman) wrote: > On Wed, 3 May 2017 12:09:21 +0900 Florian Schaefer >>> said: >> Hi! >> >> On 03.05.2017 10:04, Carsten Haitzler (The Rasterman) wrote: >>> On Tue, 02 May 2017 21:16:40 +0900 fulwood...@gmail.com said: >>> Hi, I got the source of kernel 4.11, then comipled, and check the behaviour of enlightenment (efl 1.18.1, enlightment 0.21.7). At the start up of enlightenment, I got an error message; There was an error trying to set the cpu power state setting via >>> the module's setfreq utility. On the kernel 4.10.x, I never see such a message. And, I tried to use su and sudo command in the terminal, I got a strange message; fulwood@linux-uw5l:~> sudo sudo: effective uid is not 0, is sudo installed setuid root fulwood@linux-uw5l:~> su Password: su: incorrect password This means, there is a problem concerning uid treatment in the enlightenment, doesn't it. Moreover, VirtualBox indicate the problem of enlightenment >>> directly; fulwood@linux-uw51:~> VirtualBox VirtualBox: Error -10 in SUPRHardenedMain! VirtualBox: Effective UID is not root (euid=1000, egid=100, >>> uid=1000, gid=100) VirtualBox: Tip! It may help to reintall VirtualBox. Why does uid=1000? >>> >>> that's a common uid to start with for users added to a system - >>> first >>> user added commonly is uid 1000... that's probably ... you. >>> So, we can't use enlightenment on the kernel 4.11. >>> >>> from the above it seems like since you compiled your own kernel it >>> seemingly has disabled setuid root binaries. i assume this is some >>> new >>> feature of kernels since 4.11 that has been turned on. i suggest >>> you >>> turn it off to allow them again. your kernel broke far more than >>> enlightenment. it broke sudo. probably even broke su. it broke >>> virtualbox... it broke stuff. what that option is - i don't know. >>> this >>> is news to me. >> >> Just for the record I'd like to add that I observe
Re: [E-devel] Enlightenment Developer Days 2017 Call for Papers
Hi guys, Are there recommendations for the hotels location? There are a few near the university and on the other side (Sliema)? What is better for hanging out? JackDanielZ On Fri, 28 Apr 2017 11:30:30 +0200 Stefan Schmidtwrote: > This years edition of the annual Enlightenment developer gathering > will take place Saturday 24th and Sunday 25th of June, 2017 in > Valletta, Malta. > > For more information and registration (free, but needed due to > limited seats) see our event page. > > https://phab.enlightenment.org/w/events/enlightenment_developer_days_2017/ > > If you want to propose a talk, a hands on session, a hackathon theme > or something else please send a mail to > efl-dev-day-...@lists.s-osg.org . Title and short abstracts would be > good as well as the time you expect it will take. The same address > can be used to request a VISA invitation letter which might be needed > for some folks. > > For this year, we think we are going to reproduce the same principle > as last year with the morning dedicated to presentation and talk, the > afternoon to small group hacking and discussion session. There is a > potential to dedicate the late afternoon of Saturday for talk > targeted to user. We may dedicate 1 or 2 hours total for that just > before heading to dinner. So if someone want to present something for > users, that would be a good time. > > Please give us plenty of time handling them by submitting your request > early. The deadline for the Call for Participation is May 29 2017. > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment Developer Days 2017 Call for Papers
Hello. On 05/11/2017 10:53 AM, Daniel Zaoui wrote: > Hi guys, > > Are there recommendations for the hotels location? There are a few near the > university and on the other side (Sliema)? What is better for hanging out? Cedric wanted to put together a list last time we spoke. A summary from my own findings would be that the hotels in Valletta itself are quite expensive. There are apartments as accommodation options as well. Sliema on the other hand has plenty of hotels for all budgets and apartments as well. The ferry ride is quick and cheap (2 EUR and something like 10 minutes). I have reserved myself a hotel room Sliema for now. regards Stefan Schmidt -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/enlightenment] master 01/01: e cpufreq - stop checking status nullness - silence coverity
raster pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=8ea03a039f38f1b94cd4bbd167b195c882188409 commit 8ea03a039f38f1b94cd4bbd167b195c882188409 Author: Carsten Haitzler (Rasterman)Date: Thu May 11 17:13:30 2017 +0900 e cpufreq - stop checking status nullness - silence coverity status is a msg from the child thread. it's never null. checks before sending should guarantee that. fix CID 1365406 --- src/modules/cpufreq/e_mod_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/cpufreq/e_mod_main.c b/src/modules/cpufreq/e_mod_main.c index 3c72636..e189597 100644 --- a/src/modules/cpufreq/e_mod_main.c +++ b/src/modules/cpufreq/e_mod_main.c @@ -1321,7 +1321,7 @@ _cpufreq_cb_frequency_check_notify(void *data EINA_UNUSED, return; } active = cpufreq_config->status->active; - if ((cpufreq_config->status) && (status) && + if ((cpufreq_config->status) && ( #ifdef __OpenBSD__ (status->cur_percent != cpufreq_config->status->cur_percent ) || --
Re: [E-devel] Weekly news from the automated build and QA front
On Tue, 09 May 2017 12:43:39 + Mike Blumenkrantzsaid: > Hi raster, > > Can you look at CID1365406 for Enlightenment? I requested this last year > and it seems you still have not gotten to it... forgot about it... sorry. but really. it's not a bug. it's coverity being... coverity. :) > On Mon, May 8, 2017 at 4:08 AM Stefan Schmidt > wrote: > > > Hello. > > > > Summary: > > o A few more bug reports and a few more new patches, nothing else really. > > > > This should give everyone an overview over what has happened in the last > > week on the QA front. The numbers in parentheses reflect the values from > > last week to give you a trend. > > > > CI: > > o Overall build statistic: 2.70% (2.70%) failed. > > https://build.enlightenment.org/ > > > > Unit tests: > > o N/A (N/A) unit tests for efl > > > > Coverage: > > o EFL total coverage is at N/A% (N/A%) lines, N/A% (N/A%) functions and > > N/A (N/A) branches > > https://build.enlightenment.org/view/Test%20Coverage/ > > > > Coverity: > > o EFL: Outstanding defects 45 (45) with a density of 0.04 (0.04) > > o Enlightenment: Outstanding defects 2 (2) with a density of 0.01 (0.01) > > o Terminology: Outstanding defects 0 (0) with a density of 0 (0) > > o Rage: Outstanding defects 0 (0) with a density of 0 (0) > > > > Phab: > > o EFL bug count: 393 (390) > > o E bug count: 414 (414) > > https://phab.enlightenment.org/maniphest/report/burn/ > > o Pending patch reviews: 167 (161) > > > > regards > > Stefan Schmidt > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: efreet: free the allocated buffer before returning
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=55676b335c697420fc3760c7125473b6fb250577 commit 55676b335c697420fc3760c7125473b6fb250577 Author: Stefan SchmidtDate: Thu May 11 09:34:53 2017 +0200 efreet: free the allocated buffer before returning This fixes the commit 169a08c03a6a7270e185bda85d4ab9afd9063c8e (efreetd: BSD optimizations). Coverity rightly pointed out six different leaks of various buffers on error paths. CID: 1374949 1374950 1374951 1374952 1374953 1374954 --- src/bin/efreet/efreetd_cache.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/src/bin/efreet/efreetd_cache.c b/src/bin/efreet/efreetd_cache.c index 58fb520..c347acc 100644 --- a/src/bin/efreet/efreetd_cache.c +++ b/src/bin/efreet/efreetd_cache.c @@ -196,7 +196,11 @@ subdir_cache_save(void) efreet_cache_home_get(), efreet_hostname_get()); tmpfd = eina_file_mkstemp(eina_strbuf_string_get(buf), ); - if (tmpfd < 0) return; + if (tmpfd < 0) + { +eina_strbuf_free(buf); +return; + } eina_strbuf_reset(buf); @@ -324,10 +328,15 @@ icon_cache_update_cache_cb(void *data EINA_UNUSED) if (icon_cache_exe) { icon_queue = EINA_TRUE; +eina_strbuf_free(file); return ECORE_CALLBACK_CANCEL; } icon_queue = EINA_FALSE; - if ((!icon_flush) && (!icon_exts)) return ECORE_CALLBACK_CANCEL; + if ((!icon_flush) && (!icon_exts)) + { +eina_strbuf_free(file); +return ECORE_CALLBACK_CANCEL; + } if (icon_change_monitors) eina_hash_free(icon_change_monitors); if (icon_change_monitors_mon) eina_hash_free(icon_change_monitors_mon); @@ -650,7 +659,11 @@ icon_changes_listen(void) if (!buf) return; stack = eina_inarray_new(sizeof(struct stat), 16); - if (!stack) return; + if (!stack) + { +eina_strbuf_free(buf); +return; + } icon_changes_listen_recursive(stack, efreet_icon_deprecated_user_dir_get(), EINA_TRUE); eina_inarray_flush(stack); icon_changes_listen_recursive(stack, efreet_icon_user_dir_get(), EINA_TRUE); @@ -715,10 +728,10 @@ fill_list(const char *file, Eina_List **l) Eina_File_Line *line = NULL; Eina_Strbuf *buf = eina_strbuf_new(); if (!buf) return; - + eina_strbuf_append_printf(buf, "%s/efreet/%s", efreet_cache_home_get(), file); f = eina_file_open(eina_strbuf_string_get(buf), EINA_FALSE); - if (!f) return; + if (!f) goto error_buf; it = eina_file_map_lines(f); if (!it) goto error; EINA_ITERATOR_FOREACH(it, line) @@ -731,8 +744,9 @@ fill_list(const char *file, Eina_List **l) } eina_iterator_free(it); error: - eina_strbuf_free(buf); eina_file_close(f); +error_buf: + eina_strbuf_free(buf); } static void @@ -757,6 +771,10 @@ save_list(const char *file, Eina_List *l) eina_strbuf_append_printf(buf, "%s/efreet/%s", efreet_cache_home_get(), file); f = fopen(eina_strbuf_string_get(buf), "wb"); if (!f) return; + { +eina_strbuf_free(buf); +return; + } EINA_LIST_FOREACH(l, ll, path) fprintf(f, "%s\n", path); fclose(f); --