Re: [E-devel] [PATCH] evas directfb engine API fixes
[EMAIL PROTECTED] wrote: From a quick glance: This seems like a good start, just needs more stuff filled out. This would really be best left for raster to look over though... when he finds the time eventually, but it's not forgotten. :) Hi, thanks for the reply. I have a few more fixes and changes here on my end but things are working pretty good, well enough for me to get my Freevo/Kaa work done in the meantime. I am planning on sending an updated patch sooner or later. -Rob - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] evas directfb engine API fixes
Hello,
I really need evas' directfb engine working so I took it upon myself to
do some work on it. :) I am not the best C guy around but I am familiar
with the workings of directfb.
My first patch just brings the directfb engine in line with some recent
engine API changes. It builds now and I am able to run the directfb
tests. There are still some problems and some things left unimplimented
but I will work on those things next.
I will followup soon with some questions about the engines and how I
should attack these functions.
Thanks,
-Rob
Index: src/modules/engines/directfb/evas_engine_dfb.c
===
RCS file:
/var/cvs/e/e17/libs/evas/src/modules/engines/directfb/evas_engine_dfb.c,v
retrieving revision 1.8
diff -u -r1.8 evas_engine_dfb.c
--- src/modules/engines/directfb/evas_engine_dfb.c 17 Oct 2006 10:36:36
- 1.8
+++ src/modules/engines/directfb/evas_engine_dfb.c 15 Jan 2007 16:15:41
-
@@ -80,6 +80,10 @@
evas_engine_directfb_image_draw,
evas_engine_directfb_image_comment_get,
evas_engine_directfb_image_format_get,
+ evas_engine_directfb_image_colorspace_set,
+ evas_engine_directfb_image_colorspace_get,
+ evas_engine_directfb_image_native_set,
+ evas_engine_directfb_image_native_get,
evas_engine_directfb_image_cache_flush,
evas_engine_directfb_image_cache_set,
@@ -771,7 +775,7 @@
*
* */
void *
-eng_gradient_new(void *data)
+evas_engine_directfb_gradient_new(void *data)
{
return evas_common_gradient_new();
}
@@ -914,10 +918,10 @@
re = (Render_Engine *)data;
if (!context || !gradient) return 0;
return 1;
- }
+}
-static void
-eng_gradient_render_pre(void *data, void *context, void *gradient)
+void
+evas_engine_directfb_gradient_render_pre(void *data, void *context, void
*gradient)
{
int len;
Render_Engine *re;
@@ -930,8 +934,8 @@
evas_common_gradient_map(context, gradient, len);
}
-static void
-eng_gradient_render_post(void *data, void *gradient)
+void
+evas_engine_directfb_gradient_render_post(void *data, void *gradient)
{
}
@@ -965,7 +969,7 @@
* */
void*
-evas_engine_directfb_font_load(void *data, char *name, int size)
+evas_engine_directfb_font_load(void *data, const char *name, int size)
{
Render_Engine *re;
@@ -983,7 +987,7 @@
}
void *
-evas_engine_directfb_font_add(void *data, void *font, char *name, int size)
+evas_engine_directfb_font_add(void *data, void *font, const char *name, int
size)
{
Render_Engine *re;
@@ -1047,7 +1051,7 @@
}
void
-evas_engine_directfb_font_string_size_get(void *data, void *font, char *text,
+evas_engine_directfb_font_string_size_get(void *data, void *font, const char
*text,
int *w, int *h)
{
Render_Engine *re;
@@ -1057,7 +1061,7 @@
}
int
-evas_engine_directfb_font_inset_get(void *data, void *font, char *text)
+evas_engine_directfb_font_inset_get(void *data, void *font, const char *text)
{
Render_Engine *re;
@@ -1066,7 +1070,7 @@
}
int
-evas_engine_directfb_font_h_advance_get(void *data, void *font, char *text)
+evas_engine_directfb_font_h_advance_get(void *data, void *font, const char
*text)
{
Render_Engine *re;
int h, v;
@@ -1077,7 +1081,7 @@
}
int
-evas_engine_directfb_font_v_advance_get(void *data, void *font, char *text)
+evas_engine_directfb_font_v_advance_get(void *data, void *font, const char
*text)
{
Render_Engine *re;
int h, v;
@@ -1088,7 +1092,7 @@
}
int
-evas_engine_directfb_font_char_coords_get(void *data, void *font, char *text,
+evas_engine_directfb_font_char_coords_get(void *data, void *font, const char
*text,
int pos, int *cx, int *cy, int *cw,
int *ch)
{
@@ -1099,7 +1103,7 @@
}
int
-evas_engine_directfb_font_char_at_coords_get(void *data, void *font, char
*text,
+evas_engine_directfb_font_char_at_coords_get(void *data, void *font, const
char *text,
int x, int y, int *cx, int *cy,
int *cw, int *ch)
{
@@ -1112,7 +1116,7 @@
void
evas_engine_directfb_font_draw(void *data, void *context, void *surface,
void *font, int x, int y, int w, int h, int ow,
- int oh, char *text)
+ int oh, const char *text)
{
Render_Engine *re;
void *p;
Index: src/modules/engines/directfb/evas_engine_dfb.h
===
RCS file:
/var/cvs/e/e17/libs/evas/src/modules/engines/directfb/evas_engine_dfb.h,v
retrieving revision 1.4
diff -u -r1.4 evas_engine_dfb.h
--- src/modules/engines/directfb/evas_engine_dfb.h 30 Sep 2006 10:18:34
- 1.4
+++ src/modules/engines/directfb/evas_engine_dfb.h
Re: [E-devel] evas directfb make error
[EMAIL PROTECTED] wrote: it should be broken if your cvs is up to date - i changed apis for engines. if its not broken compile-time - its going to be broken runtime. :) The build problem here was a pretty simple fix. However, as you say, the engine api changed so there's probably a lot more to do. Are there any api docs for this? I am willing to put work into maintaining the directfb engine as Freevo will be using evas (through kaa.evas) for its next generation release. That would be excellent. The many evas engines really need help. fb, dfb, qtopia, xrender, xcb, cairo, opengl, ... need people who know about these in order to efficiently implement various aspects with these engines, to keep up with developments, to fix/ improve whatever, etc. BTW: What is kaa.evas? Kaa.evas is python bindings for evas and will be used in Freevo 2 through kaa.canvas (soon to be kaa.candy). http://freevo.sourceforge.net/cgi-bin/freevo-2.0/Kaa Any help on pointing me in the right direction would be appreciated. Docs, etc... ... There are no 'docs' for evas internals, as far as I know, but it's really fairly straightforward to eg. look at the code for the dfb engine for the relevant aspects (also, raster and others might be able to lend some insights on #edevelop). I will be digging into this soon, thanks. -Rob - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas directfb make error
Carsten Haitzler (The Rasterman) wrote: On Sun, 17 Dec 2006 22:11:13 -0500 Michael Jennings [EMAIL PROTECTED] babbled: On Monday, 18 December 2006, at 12:11:52 (+0900), Carsten Haitzler wrote: yes its probably broken - there is a reason its not enabled by default. dont build it - it has almost no usefulness as nothing i know of needs or uses it. i am considering semi-retiring it until it comes up to snuff. Builds just fine here. it should be broken if your cvs is up to date - i changed apis for engines. if its not broken compile-time - its going to be broken runtime. :) The build problem here was a pretty simple fix. However, as you say, the engine api changed so there's probably a lot more to do. Are there any api docs for this? I am willing to put work into maintaining the directfb engine as Freevo will be using evas (through kaa.evas) for its next generation release. Any help on pointing me in the right direction would be appreciated. Docs, etc... Thanks, -Rob - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] evas DirectFB CVS changes
Hello, I am running DirectFB CVS (aka 0.9.23) and have just checked out and installed evas. There was a small problem with a DirectFB API change that I fixed with this patch. Thanks, -Rob -- --- Rob Shortt| http://tvcentric.com | Freevo [EMAIL PROTECTED] | http://freevo.sf.net | Free your TV ? evas_directfb_cardcaps.patch Index: src/bin/evas_directfb_main.c === RCS file: /cvsroot/enlightenment/e17/libs/evas/src/bin/evas_directfb_main.c,v retrieving revision 1.4 diff -u -r1.4 evas_directfb_main.c --- src/bin/evas_directfb_main.c 22 May 2005 02:49:35 - 1.4 +++ src/bin/evas_directfb_main.c 21 Sep 2005 01:33:19 - @@ -26,7 +26,11 @@ IDirectFBEventBuffer *buffer; DFBResult err; DFBSurfaceDescription dsc; +#if (DIRECTFB_MAJOR_VERSION == 0) (DIRECTFB_MINOR_VERSION == 9) (DIRECTFB_MICRO_VERSION 23) DFBCardCapabilities caps; +#else + DFBGraphicsDeviceDescription caps; +#endif DFBDisplayLayerConfig layer_config; DFBInputEvent evt; Index: src/bin/evas_directfb_window.c === RCS file: /cvsroot/enlightenment/e17/libs/evas/src/bin/evas_directfb_window.c,v retrieving revision 1.5 diff -u -r1.5 evas_directfb_window.c --- src/bin/evas_directfb_window.c 22 May 2005 02:49:35 - 1.5 +++ src/bin/evas_directfb_window.c 21 Sep 2005 01:33:19 - @@ -75,7 +75,11 @@ IDirectFBEventBuffer *buffer; DFBDisplayLayerConfig layer_config; +#if (DIRECTFB_MAJOR_VERSION == 0) (DIRECTFB_MINOR_VERSION == 9) (DIRECTFB_MICRO_VERSION 23) DFBCardCapabilitiescaps; +#else + DFBGraphicsDeviceDescription caps; +#endif IDirectFBWindow* upper; DFBWindowIDid1; @@ -88,7 +92,11 @@ DFBCHECK(DirectFBInit( argc, argv )); DFBCHECK(DirectFBCreate( dfb )); +#if (DIRECTFB_MAJOR_VERSION == 0) (DIRECTFB_MINOR_VERSION == 9) (DIRECTFB_MICRO_VERSION 23) dfb-GetCardCapabilities( dfb, caps ); +#else + dfb-GetDeviceDescription( dfb, caps ); +#endif dfb-GetDisplayLayer( dfb, DLID_PRIMARY, layer );
Re: [E-devel] [PATCH] evas DirectFB CVS changes
Hi, Mike Frysinger wrote: On Wednesday 21 September 2005 08:14 pm, Rob Shortt wrote: I am running DirectFB CVS (aka 0.9.23) and have just checked out and installed evas. There was a small problem with a DirectFB API change that I fixed with this patch. wouldnt it be saner to just keep evas compatible with the latest released version ? otherwise, we'll end up with ugly #ifdef-ed code all over the place ... especially with DirectFB which tends to change a little with every release To a certain point I'd agree with you, if we had #ifdefs for multiple versions back and various API changes. But there's no checking here for versions older than the last release and I don't think it's unreasonable for one project's CVS to support another's. Many developers working on different projects need to build CVS versions all over the place. Also, once DirectFB 0.9.23 is released, if there is a desire to get rid of these #ifdefs, I could send a patch to remove them and tweak the version check in configure. Thanks, -Rob -- --- Rob Shortt| http://tvcentric.com | Freevo [EMAIL PROTECTED] | http://freevo.sf.net | Free your TV --- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42 plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
