from:"rustyBSD"

Hi all,
can someone add gettext support to e/src/bin/e_fm_op.c ?

Thanks !
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [ecore] Recursive rm

Le 15/10/2012 18:57, rustyBSD a écrit :
 Le 15/10/2012 10:03, Vincent Torri a écrit :
  Maxime: you can separate code with the  _WIN32 macro. Can you update
  ecore and write a patch that use lstat on non win32 ?
 Ok.
So, what's new ??
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] e_fm_op.c: Gettext

Le 30/10/2012 11:44, Michael Blumenkrantz a écrit :
 any particular reason?
For translation
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] cpufreq

Hi,
here is a patch for e/src/modules/cpufreq/e_mod_main.c

I. _cpufreq_status_check_available() always returns 1,
   so moved to void.

II. Don't need to 'buf[sizeof(buf) - 1] = 0;', as it's
already done by snprintf.

III. Stuff for OpenBSD.

IV. Fixed files descriptors leaks, and removed useless
code.

thanks
--- e_mod_main.c	Tue Oct 30 09:14:27 2012
+++ e_mod_main.c	Tue Oct 30 09:14:24 2012
@@ -1,6 +1,11 @@
 #include e.h
 #include e_mod_main.h
 
+/* NOTE: for OpenBSD, as we cannot set the frequency but
+ *   only its percent, we store percents 25-50-75-100
+ *   in s-frequencies instead of available frequencies.
+ */
+
 #if defined (__FreeBSD__) || defined (__OpenBSD__)
 # include sys/sysctl.h
 #endif
@@ -38,7 +43,7 @@
 static Eina_Bool _cpufreq_cb_check(void *data);
 static Status   *_cpufreq_status_new(void);
 static void  _cpufreq_status_free(Status *s);
-static int   _cpufreq_status_check_available(Status *s);
+static void  _cpufreq_status_check_available(Status *s);
 static int   _cpufreq_status_check_current(Status *s);
 static int   _cpufreq_cb_sort(const void *item1, const void *item2);
 static void  _cpufreq_face_update_available(Instance *inst);
@@ -301,7 +306,6 @@
  frequency / 100.);
 #endif
 
-  buf[sizeof(buf) - 1] = 0;
   e_menu_item_label_set(mi, buf);
   e_menu_item_radio_set(mi, 1);
   e_menu_item_radio_group_set(mi, 1);
@@ -556,7 +560,7 @@
return 0;
 }
 
-static int
+static void
 _cpufreq_status_check_available(Status *s)
 {
char buf[4096];
@@ -564,36 +568,23 @@
// FIXME: this assumes all cores accept the same freqs/ might be wrong
 
 #if defined (__OpenBSD__)
-   int freq, mib[] = {CTL_HW, HW_CPUSPEED};
-   size_t len = sizeof(freq);
int p;
 
-   if (sysctl(mib, 2, freq, len, NULL, 0) == 0)
+   if (s-frequencies)
  {
-if (s-frequencies)
-  {
- eina_list_free(s-frequencies);
- s-frequencies = NULL;
-  }
-
-if (s-governors)
-  {
- for (l = s-governors; l; l = l-next)
-   free(l-data);
- eina_list_free(s-governors);
- s-governors = NULL;
-  }
-
-/* storing percents */
-p = 100;
-s-frequencies = eina_list_append(s-frequencies, (void *)p);
-p = 75;
-s-frequencies = eina_list_append(s-frequencies, (void *)p);
-p = 50;
-s-frequencies = eina_list_append(s-frequencies, (void *)p);
-p = 25;
-s-frequencies = eina_list_append(s-frequencies, (void *)p);
+eina_list_free(s-frequencies);
+s-frequencies = NULL;
  }
+
+   /* storing percents */
+   p = 100;
+   s-frequencies = eina_list_append(s-frequencies, (void *)p);
+   p = 75;
+   s-frequencies = eina_list_append(s-frequencies, (void *)p);
+   p = 50;
+   s-frequencies = eina_list_append(s-frequencies, (void *)p);
+   p = 25;
+   s-frequencies = eina_list_append(s-frequencies, (void *)p);
 #elif defined (__FreeBSD__)
int freq;
size_t len = sizeof(buf);
@@ -649,8 +640,11 @@
  s-frequencies = NULL;
   }
 
-if (fgets(buf, sizeof(buf), f) == NULL) return 1;
-buf[sizeof(buf) - 1] = 0;
+if (fgets(buf, sizeof(buf), f) == NULL)
+  {
+ fclose(f);
+ return;
+  }
 fclose(f);
 
 freq = strtok(buf,  );
@@ -683,8 +677,11 @@
  s-governors = NULL;
   }
 
-if (fgets(buf, sizeof(buf), f) == NULL) return 1;
-buf[sizeof(buf) - 1] = 0;
+if (fgets(buf, sizeof(buf), f) == NULL)
+  {
+ fclose(f);
+ return;
+  }
 fclose(f);
 
 gov = strtok(buf,  );
@@ -703,7 +700,6 @@
  (int (*)(const void *, const void *))strcmp);
  }
 #endif
-   return 1;
 }
 
 static int
@@ -736,6 +732,7 @@
 
s-can_set_frequency = 1;
s-cur_governor = NULL;
+
 #elif defined (__FreeBSD__)
size_t len = sizeof(frequency);
s-active = 0;
@@ -752,6 +749,7 @@
/* hardcoded for testing */
s-can_set_frequency = 1;
s-cur_governor = NULL;
+
 #else
char buf[4096];
FILE *f;
@@ -770,8 +768,11 @@
 f = fopen(buf, r);
 if (f)
   {
- if (fgets(buf, sizeof(buf), f) == NULL) continue;
- buf[sizeof(buf) - 1] = 0;
+ if (fgets(buf, sizeof(buf), f) == NULL)
+   {
+  fclose(f);
+  continue;
+   }
  fclose(f);
 
  frequency = atoi(buf);
@@ -811,10 +812,13 @@
  {
 char *p;
 
-buf[0] = 0;
-if (fgets(buf, sizeof(buf), f) == NULL) return ret; ;
-buf[sizeof(buf) - 1] = 0;
+if (fgets(buf, sizeof(buf), f) == NULL)
+  {
+ fclose(f);
+ return ret;
+  }
 fclose(f);
+
 for (p

[E-devel] [e] Patch

2012-10-25 Thread rustyBSD

Hi all,
here is a patch for the randomization in
e/src/bin/e_fm_op.c.


I. Simplification, andif we cannot stat(), the best
thing to do is toswitch to a copy-delete operation.

II.Just stuff...

III. There is a problem with _e_fm_op_random_char().
When wewant to randomize a string we do srand(time())
foreachcharacter, so if the file is small enough
to be deleted inless than a second, it's not randomized.
And even if it's bigger, it's not goodly randomized.Sorry.


Thanks
--- e_fm_op.c	Sat Oct 20 16:28:10 2012
+++ e_fm_op.c	Sat Oct 20 16:26:55 2012
@@ -106,7 +106,7 @@
 static int   _e_fm_op_rename_atom(E_Fm_Op_Task *task);
 static int   _e_fm_op_destroy_atom(E_Fm_Op_Task *task);
 static void  _e_fm_op_random_buf(char *buf, ssize_t len);
-static char  _e_fm_op_random_char();
+static void  _e_fm_op_random_char(char *buf, size_t len);
 
 Eina_List *_e_fm_op_work_queue = NULL, *_e_fm_op_scan_queue = NULL;
 Ecore_Idler *_e_fm_op_work_idler_p = NULL, *_e_fm_op_scan_idler_p = NULL;
@@ -311,12 +311,11 @@
  if ((stat(argv[i], st1) == 0) 
  (stat(buf, st2) == 0))
{
-  /* if files are on the same device */
-  if (st1.st_dev == st2.st_dev)
-type = E_FM_OP_RENAME;
-  else
+  /* if files are not on the same device */
+  if (st1.st_dev != st2.st_dev)
 type = E_FM_OP_MOVE;
}
+ else type = E_FM_OP_MOVE;
   }
  }
 
@@ -1661,7 +1660,6 @@
return 0;
 }
 
-/* EXPERIMENTAL */
 static int
 _e_fm_op_destroy_atom(E_Fm_Op_Task *task)
 {
@@ -1691,7 +1689,7 @@
 
if (st2.st_dev != task-src.st.st_dev ||
st2.st_ino != task-src.st.st_ino ||
-   !S_ISREG(st2.st_mode))
+   st2.st_mode != task-src.st.st_mode)
  goto finish;
 
if ((buf = malloc(READBUFSIZE)) == NULL)
@@ -1744,32 +1742,28 @@
 _e_fm_op_random_buf(char *buf, ssize_t len)
 {
int f = -1;
-   ssize_t i;
 
if ((f = open(/dev/urandom, O_RDONLY)) == -1)
  {
-   for (i = 0; i  len; i++)
- {
-buf[i] = _e_fm_op_random_char();
- }
-   return;
+_e_fm_op_random_char(buf, len);
+return;
  }
 
if (read(f, buf, len) != len)
- {
-   for (i = 0; i  len; i++)
- {
-buf[i] = _e_fm_op_random_char();
- }
- }
+ _e_fm_op_random_char(buf, len);
 
close(f);
return;
 }
 
-static char
-_e_fm_op_random_char()
+static void
+_e_fm_op_random_char(char *buf, size_t len)
 {
+   size_t i;
srand((unsigned int)time(NULL));
-   return (rand() % 256) + 'a';
+
+   for (i = 0; i  len; i++)
+ {
+buf[i] = (rand() % 256) + 'a';
+ }
 }

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [ecore] Recursive rm

2012-10-15 Thread rustyBSD

Le 15/10/2012 10:03, Vincent Torri a écrit :
 Maxime: you can separate code with the  _WIN32 macro. Can you update
 ecore and write a patch that use lstat on non win32 ?
Ok.
--- ecore_file.c	2012-10-15 18:53:22.594116119 +0200
+++ ecore_file.c	2012-10-15 18:52:46.668671104 +0200
@@ -399,22 +399,27 @@
 EAPI Eina_Bool
 ecore_file_recursive_rm(const char *dir)
 {
-   Eina_Iterator *it;
-   char buf[PATH_MAX];
struct stat st;
-   int ret;
+
+#ifdef _WIN32
+   char buf[PATH_MAX];
 
if (readlink(dir, buf, sizeof(buf) - 1)  0)
  return ecore_file_unlink(dir);
+   if (stat(dir, st) == -1)
+ return EINA_FALSE;
+#else
+   if (lstat(dir, st) == -1)
+ return EINA_FALSE;
+#endif
 
-   ret = stat(dir, st);
-   if ((ret == 0)  (S_ISDIR(st.st_mode)))
+   if (S_ISDIR(st.st_mode))
  {
 Eina_File_Direct_Info *info;
+Eina_Iterator *it;
+int ret;
 
 ret = 1;
-if (stat(dir, st) == -1) return EINA_FALSE; /* WOOT: WHY ARE WE CALLING STAT TWO TIMES ??? */
-
 it = eina_file_direct_ls(dir);
 EINA_ITERATOR_FOREACH(it, info)
   {
@@ -431,7 +436,6 @@
  }
else
  {
-if (ret == -1) return EINA_FALSE;
 return ecore_file_unlink(dir);
  }
 }
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [ecore] Recursive rm

2012-10-06 Thread rustyBSD

Hi,
I looked at the ecore_file_recursive_rm() function
(in ecore/src/lib/ecore_file/), and I wonder why this
is so ugly/complicated.

We are doing a readlink() and two stat(). Why not simply
do a lstat() ?

It takes less memory and it's simplier. Here is a patch.

Am I wrong ?

(And readlink() is ssize_t)
--- ecore_file.c	2012-10-06 13:11:59.884889232 +0200
+++ ecore_file.c	2012-10-06 13:08:24.569905570 +0200
@@ -399,21 +399,16 @@
 EAPI Eina_Bool
 ecore_file_recursive_rm(const char *dir)
 {
-   Eina_Iterator *it;
-   char buf[PATH_MAX];
struct stat st;
-   int ret;
 
-   if (readlink(dir, buf, sizeof(buf) - 1)  0)
- return ecore_file_unlink(dir);
+   if (lstat(dir, st) == -1)
+ return EINA_FALSE;
 
-   ret = stat(dir, st);
-   if ((ret == 0)  (S_ISDIR(st.st_mode)))
+   if (S_ISDIR(st.st_mode))
  {
 Eina_File_Direct_Info *info;
-
-ret = 1;
-if (stat(dir, st) == -1) return EINA_FALSE; /* WOOT: WHY ARE WE CALLING STAT TWO TIMES ??? */
+Eina_Iterator *it;
+int ret = 1;
 
 it = eina_file_direct_ls(dir);
 EINA_ITERATOR_FOREACH(it, info)
@@ -429,11 +424,8 @@
 else
 return EINA_FALSE;
  }
-   else
- {
-if (ret == -1) return EINA_FALSE;
-return ecore_file_unlink(dir);
- }
+
+   return ecore_file_unlink(dir);
 }
 
 static inline Eina_Bool
@@ -790,7 +782,7 @@
 ecore_file_readlink(const char *lnk)
 {
char buf[PATH_MAX];
-   int count;
+   ssize_t count;
 
if ((count = readlink(lnk, buf, sizeof(buf) - 1))  0) return NULL;
buf[count] = 0;
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [ecore] Recursive rm

2012-10-06 Thread rustyBSD

Le 06/10/2012 14:03, Vincent Torri a écrit :
 Hi,
  I looked at the ecore_file_recursive_rm() function
  (in ecore/src/lib/ecore_file/), and I wonder why this
  is so ugly/complicated.
 
  We are doing a readlink() and two stat(). Why not simply
  do a lstat() ?
 note that lstat does not exist on Windows

 Vincent

Ah ok, I didn't know.

But the second stat() is still useless.
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] Translation broken !

2012-10-05 Thread rustyBSD

Le 29/09/2012 13:27, rustyBSD a écrit :
 Mmmh... The translation of e/src/modules/notification
 seems to be broken.

 I don't know if it's the right thing to do, but I added
 entries in POTFILES.in/.skip.

 Then we can removee/src/modules/notification/po.
Sometimes I wonder who I'm talking to
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] evas bad typedef

2012-10-04 Thread rustyBSD

Le 01/10/2012 19:08, rustyBSD a écrit :
 Hi,
 == evas_gl_api_ext.h l.4 ==
 The GLchar type is already defined on openbsd
 (/usr/X11R6/include/GL/glext.h), so it has to
 be renamed.

You should really use another name.GLchar
already comes with gl/opengl.

OpenBSD and NetBSD don't like that.
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] cpufreq: OpenBSD support


On 09/30/12 14:11, rustyBSD wrote:

are you sure about fresqet.c ? Just returning 1 ?

Not really.

I'm looking for a way to change the cpu freq

Mmhh...

The problem with openbsd's sysctl is that
we get cpu freq in Mhz, but we can only set
it in percents - and not up to 100%.

So I put percents instead of Mhz in the menu,
even if it sometimes causes some problems with
the speedbar. But it works.

I'll continue later. You can commit these
patches.
--- e_mod_main.cMon Oct  1 07:42:45 2012
+++ e_mod_main.cMon Oct  1 07:43:43 2012
@@ -1,9 +1,8 @@
 #include e.h
 #include e_mod_main.h
 
-#ifdef __FreeBSD__
-#include sys/types.h
-#include sys/sysctl.h
+#if defined (__FreeBSD__) || defined (__OpenBSD__)
+# include sys/sysctl.h
 #endif
 
 /* gadcon requirements */
@@ -291,11 +290,17 @@
 
   frequency = (long)l-data;
   mi = e_menu_item_new(mo);
+
+#ifdef __OpenBSD__
+  snprintf(buf, sizeof(buf), _(%i %%), frequency);
+#else
   if (frequency  100)
 snprintf(buf, sizeof(buf), _(%i MHz), frequency / 1000);
   else
 snprintf(buf, sizeof(buf), _(%'.1f GHz),
  frequency / 100.);
+#endif
+
   buf[sizeof(buf) - 1] = 0;
   e_menu_item_label_set(mi, buf);
   e_menu_item_radio_set(mi, 1);
@@ -445,8 +451,10 @@
 return;
  }
 
-   // change it to userspace
+#ifndef __OpenBSD__
+   /* OpenBSD doesn't have governors */
_cpufreq_set_governor(userspace);
+#endif
 
snprintf(buf, sizeof(buf),
 %s %s %i, cpufreq_config-set_exe_path, frequency, frequency);
@@ -548,8 +556,40 @@
 {
char buf[4096];
Eina_List *l;
-   // FIXME: this sssumes all cores accept the same freqs/ might be wrong
-#ifdef __FreeBSD__
+   // FIXME: this assumes all cores accept the same freqs/ might be wrong
+
+#if defined (__OpenBSD__)
+   int freq, mib[] = {CTL_HW, HW_CPUSPEED};
+   size_t len = sizeof(freq);
+   int p;
+
+   if (sysctl(mib, 2, freq, len, NULL, 0) == 0)
+ {
+if (s-frequencies)
+  {
+ eina_list_free(s-frequencies);
+ s-frequencies = NULL;
+  }
+
+if (s-governors)
+  {
+ for (l = s-governors; l; l = l-next)
+   free(l-data);
+ eina_list_free(s-governors);
+ s-governors = NULL;
+  }
+
+/* storing percents */
+p = 100;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 75;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 50;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 25;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+ }
+#elif defined (__FreeBSD__)
int freq, i;
size_t len = 0;
char *freqs, *pos, *q;
@@ -665,15 +705,28 @@
 static int
 _cpufreq_status_check_current(Status *s)
 {
-   char buf[4096];
-   int i;
-   FILE *f;
int ret = 0;
int frequency = 0;
-   int frequency_min = 0x7fff;
-   int frequency_max = 0;
-   int freqtot = 0;
-#ifdef __FreeBSD__
+
+#if defined (__OpenBSD__)
+   size_t len = sizeof(frequency);
+   int mib[] = {CTL_HW, HW_CPUSPEED};
+   s-active = 0;
+
+   _cpufreq_status_check_available(s);
+
+   if (sysctl(mib, 2, frequency, len, NULL, 0) == 0)
+ {
+frequency *= 1000;
+if (frequency != s-cur_frequency) ret = 1;
+s-cur_frequency = frequency;
+s-active = 1;
+ }
+
+   s-can_set_frequency = 1;
+   s-cur_governor = NULL;
+   s-cur_frequency = frequency;
+#elif defined (__FreeBSD__)
int len = 4;
 
s-active = 0;
@@ -690,6 +743,13 @@
s-can_set_frequency = 1;
s-cur_governor = NULL;
 #else
+   char buf[4096];
+   FILE *f;
+   int frequency_min = 0x7fff;
+   int frequency_max = 0;
+   int freqtot = 0;
+   int i;
+
s-active = 0;
 
_cpufreq_status_check_available(s);
@@ -724,7 +784,7 @@
 
 //  printf(%i | %i %i\n, frequency, frequency_min, frequency_max);
 
-   // FIXME: this sssumes all cores are on the same governor
+   // FIXME: this assumes all cores are on the same governor
f = fopen(/sys/devices/system/cpu/cpu0/cpufreq/scaling_setspeed, r);
if (f)
  {
--- freqset.c   Mon Oct  1 07:59:21 2012
+++ freqset.c   Mon Oct  1 07:46:15 2012
@@ -5,10 +5,15 @@
 #include string.h
 
 #ifdef __FreeBSD__
-#include sys/types.h
-#include sys/sysctl.h
+# include sys/sysctl.h
 #endif
 
+#ifdef __OpenBSD__
+# include sys/param.h
+# include sys/resource.h
+# include sys/sysctl.h
+#endif
+
 static int sys_cpu_setall(const char *control, const char *value);
 static int sys_cpufreq_set(const char *control, const char *value);
 
@@ -25,9 +30,29 @@
if (seteuid(0))
  {
 fprintf(stderr, Unable to assume root privileges\n);
+return 1;
  }
 
-#ifdef __FreeBSD__
+#if defined __OpenBSD__
+   if (!strcmp(argv[1

Re: [E-devel] [e] cpufreq: OpenBSD support


On 10/01/12 08:22, Vincent Torri wrote:

maybe this could help you :

http://stackoverflow.com/questions/4226353/show-memory-and-cpu-in-c

Vincent

?

There is no problem when getting the frequency.
The only difference with linux is that instead
of displaying available frequencies (in the menu),
we display 25-50-75-100% - as we can only set
percents.

We unfortunately cannot get available levels, so
we don't know what is the max/min frequency
available for the processor, and it sometimes
causes problem with the speedcounter, which
doesn't know where to place the freq in the
counter.

PS: I forgot to mention that the freebsd support
is broken.

Here are patches again. This time it's really ok,
I also quickly modified the freebsd code.

--- e_mod_main.cMon Oct  1 14:58:24 2012
+++ e_mod_main.cMon Oct  1 14:41:45 2012
@@ -1,9 +1,8 @@
 #include e.h
 #include e_mod_main.h
 
-#ifdef __FreeBSD__
-#include sys/types.h
-#include sys/sysctl.h
+#if defined (__FreeBSD__) || defined (__OpenBSD__)
+# include sys/sysctl.h
 #endif
 
 /* gadcon requirements */
@@ -291,17 +290,29 @@
 
   frequency = (long)l-data;
   mi = e_menu_item_new(mo);
+
+#ifdef __OpenBSD__
+  snprintf(buf, sizeof(buf), %i %%, frequency);
+#else
   if (frequency  100)
 snprintf(buf, sizeof(buf), _(%i MHz), frequency / 1000);
   else
 snprintf(buf, sizeof(buf), _(%'.1f GHz),
  frequency / 100.);
+#endif
+
   buf[sizeof(buf) - 1] = 0;
   e_menu_item_label_set(mi, buf);
   e_menu_item_radio_set(mi, 1);
   e_menu_item_radio_group_set(mi, 1);
+
+#ifdef __OpenBSD__
+  if (cpufreq_config-status-cur_percent == frequency)
+e_menu_item_toggle_set(mi, 1);
+#else
   if (cpufreq_config-status-cur_frequency == frequency)
 e_menu_item_toggle_set(mi, 1);
+#endif
   e_menu_item_callback_set(mi, _cpufreq_menu_frequency, 
l-data);
}
   }
@@ -445,8 +456,10 @@
 return;
  }
 
-   // change it to userspace
+#ifndef __OpenBSD__
+   /* OpenBSD doesn't have governors */
_cpufreq_set_governor(userspace);
+#endif
 
snprintf(buf, sizeof(buf),
 %s %s %i, cpufreq_config-set_exe_path, frequency, frequency);
@@ -548,14 +561,45 @@
 {
char buf[4096];
Eina_List *l;
-   // FIXME: this sssumes all cores accept the same freqs/ might be wrong
-#ifdef __FreeBSD__
-   int freq, i;
-   size_t len = 0;
+   // FIXME: this assumes all cores accept the same freqs/ might be wrong
+
+#if defined (__OpenBSD__)
+   int freq, mib[] = {CTL_HW, HW_CPUSPEED};
+   size_t len = sizeof(freq);
+   int p;
+
+   if (sysctl(mib, 2, freq, len, NULL, 0) == 0)
+ {
+if (s-frequencies)
+  {
+ eina_list_free(s-frequencies);
+ s-frequencies = NULL;
+  }
+
+if (s-governors)
+  {
+ for (l = s-governors; l; l = l-next)
+   free(l-data);
+ eina_list_free(s-governors);
+ s-governors = NULL;
+  }
+
+/* storing percents */
+p = 100;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 75;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 50;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+p = 25;
+s-frequencies = eina_list_append(s-frequencies, (void *)p);
+ }
+#elif defined (__FreeBSD__)
+   int freq;
+   size_t len = sizeof(buf);
char *freqs, *pos, *q;
 
/* read freq_levels sysctl and store it in freq */
-   len = sizeof(buf);
if (sysctlbyname(dev.cpu.0.freq_levels, buf, len, NULL, 0) == 0)
  {
 /* sysctl returns 0 on success */
@@ -665,18 +709,37 @@
 static int
 _cpufreq_status_check_current(Status *s)
 {
-   char buf[4096];
-   int i;
-   FILE *f;
int ret = 0;
int frequency = 0;
-   int frequency_min = 0x7fff;
-   int frequency_max = 0;
-   int freqtot = 0;
-#ifdef __FreeBSD__
-   int len = 4;
 
+#if defined (__OpenBSD__)
+   size_t len = sizeof(frequency);
+   int percent, mib[] = {CTL_HW, HW_CPUSPEED};
s-active = 0;
+
+   _cpufreq_status_check_available(s);
+
+   if (sysctl(mib, 2, frequency, len, NULL, 0) == 0)
+ {
+frequency *= 1000;
+if (frequency != s-cur_frequency) ret = 1;
+s-cur_frequency = frequency;
+s-active = 1;
+ }
+
+   mib[1] = HW_SETPERF;
+
+   if (sysctl(mib, 2, percent, len, NULL, 0) == 0)
+ {
+s-cur_percent = percent;
+ }
+
+   s-can_set_frequency = 1;
+   s-cur_governor = NULL;
+#elif defined (__FreeBSD__)
+   size_t len = sizeof(frequency);
+   s-active = 0;
+
/* frequency is stored in dev.cpu.0.freq */
if (sysctlbyname(dev.cpu.0.freq, frequency, len, NULL, 0) == 0)
  {
@@

Re: [E-devel] [e] cpufreq: OpenBSD support

On 10/01/12 15:20, Vincent Torri wrote:
 ?
 I have seen that :

 printf(CPU: %d MHz Free: %ld MB\n, cpuspeed,
 sysconf(_SC_AVPHYS_PAGES)*sysconf(_SC_PAGESIZE))20

 so it displays the freq in Mhz, no ?

My ? meant that it's not actually the problem.
The freq is correctly displayed in the counter
in Mhz, it's just the pointer which sometimes
goes crazy, but we cannot do anything.
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] evas bad typedef

Hi,
== evas_gl_api_ext.h l.4 ==
The GLchar type is already defined on openbsd
(/usr/X11R6/include/GL/glext.h), so it has to
be renamed.
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] cpufreq: OpenBSD support

On 10/01/12 19:41, Vincent Torri wrote:
 is the freebsd support still broken avec your changes ?
Yes I think, but I'm not sure.
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] cpufreq: OpenBSD support

2012-09-30 Thread rustyBSD


Hi,
I added support for OpenBSD on the cpufreq
module.

Thanks
--- e_mod_main.cSun Sep 30 11:16:50 2012
+++ e_mod_main.cSun Sep 30 11:11:57 2012
@@ -6,6 +6,12 @@
 #include sys/sysctl.h
 #endif
 
+#ifdef __OpenBSD__
+#include sys/types.h
+#include sys/sysctl.h
+#include sys/param.h
+#endif
+
 /* gadcon requirements */
 static E_Gadcon_Client *_gc_init(E_Gadcon *gc, const char *name, const char 
*id, const char *style);
 static void _gc_shutdown(E_Gadcon_Client *gcc);
@@ -422,7 +428,7 @@
char buf[4096];
int ret;
 
-#ifdef __FreeBSD__
+#if defined (__FreeBSD__) || defined (__OpenBSD__)
frequency /= 1000;
 #endif
if (!cpufreq_config-status-can_set_frequency)
@@ -548,8 +554,32 @@
 {
char buf[4096];
Eina_List *l;
-   // FIXME: this sssumes all cores accept the same freqs/ might be wrong
-#ifdef __FreeBSD__
+   // FIXME: this assumes all cores accept the same freqs/ might be wrong
+
+#ifdef __OpenBSD__
+   int freq, getMhz[] = {CTL_HW, HW_CPUSPEED};
+   size_t len = sizeof(buf);
+
+   if (sysctl(getMhz, 2, buf, len, NULL, 0) == 0)
+ {
+if (s-frequencies)
+  {
+ eina_list_free(s-frequencies);
+ s-frequencies = NULL;
+  }
+
+freq = atoi(buf);
+s-frequencies = eina_list_append(s-frequencies, (void *)freq);
+
+if (s-governors)
+  {
+ for (l = s-governors; l; l = l-next)
+   free(l-data);
+ eina_list_free(s-governors);
+ s-governors = NULL;
+  }
+ }
+#elif defined (__FreeBSD__)
int freq, i;
size_t len = 0;
char *freqs, *pos, *q;
@@ -665,15 +695,25 @@
 static int
 _cpufreq_status_check_current(Status *s)
 {
-   char buf[4096];
-   int i;
-   FILE *f;
int ret = 0;
int frequency = 0;
-   int frequency_min = 0x7fff;
-   int frequency_max = 0;
-   int freqtot = 0;
-#ifdef __FreeBSD__
+
+#if defined (__OpenBSD__)
+   size_t len = sizeof(frequency);
+   int getMhz[] = {CTL_HW, HW_CPUSPEED};
+   s-active = 0;
+
+   if (sysctl(getMhz, 2, frequency, len, NULL, 0) == 0)
+ {
+frequency *= 1000;
+if (frequency != s-cur_frequency) ret = 1;
+s-cur_frequency = frequency;
+s-active = 1;
+ }
+
+   s-can_set_frequency = 0;
+   s-cur_governor = NULL;
+#elif defined (__FreeBSD__)
int len = 4;
 
s-active = 0;
@@ -690,6 +730,13 @@
s-can_set_frequency = 1;
s-cur_governor = NULL;
 #else
+   char buf[4096];
+   FILE *f;
+   int frequency_min = 0x7fff;
+   int frequency_max = 0;
+   int freqtot = 0;
+   int i;
+
s-active = 0;
 
_cpufreq_status_check_available(s);
@@ -724,7 +771,7 @@
 
 //  printf(%i | %i %i\n, frequency, frequency_min, frequency_max);
 
-   // FIXME: this sssumes all cores are on the same governor
+   // FIXME: this assumes all cores are on the same governor
f = fopen(/sys/devices/system/cpu/cpu0/cpufreq/scaling_setspeed, r);
if (f)
  {
--- freqset.c   Sun Sep 30 11:19:34 2012
+++ freqset.c   Sun Sep 30 11:14:48 2012
@@ -15,6 +15,11 @@
 int
 main(int argc, char *argv[])
 {
+
+#ifdef __OpenBSD__
+   return 1;
+#endif
+
if (argc != 3)
  {
 fprintf(stderr, Invalid command. Syntax:\n);
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] cpufreq: OpenBSD support

2012-09-30 Thread rustyBSD

On 09/30/12 13:57, Vincent Torri wrote:
 are you sure about fresqet.c ? Just returning 1 ?
Not really.

I'm looking for a way to change the cpu freq
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] Patch

2012-09-29 Thread rustyBSD

Hi,
some trivial changes.

I.   _e_fm_op_stdin_handler is unused, so - removed.

II.  if we cannot malloc _e_fm_op_stdin_buffer, we
 are in big shit, so nullcheck.

III. Formatting.

IV.  if argc  4 we quit, so we don't need to check
 if argc = 4.

V.   removed 'ret' variables. They are useless and
 they were not in old revisions.

VI.  _e_fm_op_copy_atom always returns 1, so we don't
 need to always check and return 1.

Thanks !
--- e_fm_op.c	2012-09-29 09:02:41.187650273 +0200
+++ e_fm_op.c	2012-09-29 09:02:35.358737797 +0200
@@ -108,8 +108,6 @@
 static void  _e_fm_op_random_buf(char *buf, ssize_t len);
 static char  _e_fm_op_random_char();
 
-Ecore_Fd_Handler *_e_fm_op_stdin_handler = NULL;
-
 Eina_List *_e_fm_op_work_queue = NULL, *_e_fm_op_scan_queue = NULL;
 Ecore_Idler *_e_fm_op_work_idler_p = NULL, *_e_fm_op_scan_idler_p = NULL;
 
@@ -172,10 +170,10 @@
eina_init();
 
_e_fm_op_stdin_buffer = malloc(READBUFSIZE);
+   if (!_e_fm_op_stdin_buffer) return 0;
 
-   _e_fm_op_stdin_handler =
- ecore_main_fd_handler_add(STDIN_FILENO, ECORE_FD_READ, _e_fm_op_stdin_data, NULL,
-   NULL, NULL);
+   ecore_main_fd_handler_add(STDIN_FILENO, ECORE_FD_READ, _e_fm_op_stdin_data,
+ NULL, NULL, NULL);
 
if (argc  3) return 0;
 
@@ -198,8 +196,8 @@
if ((type == E_FM_OP_SECURE_REMOVE) ||
(type == E_FM_OP_MOVE))
  {
-   _e_fm_op_work_queue = eina_list_append(_e_fm_op_work_queue, NULL);
-   _e_fm_op_separator = _e_fm_op_work_queue;
+_e_fm_op_work_queue = eina_list_append(_e_fm_op_work_queue, NULL);
+_e_fm_op_separator = _e_fm_op_work_queue;
  }
 
if ((type == E_FM_OP_COPY) ||
@@ -209,7 +207,7 @@
  {
 if (argc  4) goto quit;
 
-if ((argc = 4)  (ecore_file_is_dir(argv[last])))
+if (ecore_file_is_dir(argv[last]))
   {
  char buf[PATH_MAX];
  char *p2, *p3;
@@ -237,20 +235,17 @@
  done = 0;
  total = last - 2;
 
- char *p;
-
  for (; i  last; i++)
{
-  p = argv[i];
   const char *name;
   size_t name_len;
 
   /* Don't move a dir into itself */
-  if (ecore_file_is_dir(p) 
-  (strcmp(p, p2) == 0))
+  if (ecore_file_is_dir(argv[i]) 
+  (strcmp(argv[i], p2) == 0))
 goto skip_arg;
 
-  name = ecore_file_file_get(p);
+  name = ecore_file_file_get(argv[i]);
   if (!name) goto skip_arg;
   name_len = strlen(name);
   if (p2_len + name_len = PATH_MAX) goto skip_arg;
@@ -267,19 +262,19 @@
 {
if (type == E_FM_OP_RENAME)
  {
-if (!strcmp(argv[i],buf))
+if (!strcmp(argv[i], buf))
   goto skip_arg;
 
-if (buf[0]!='/')
+if (buf[0] != '/')
   _E_FM_OP_ERROR_SEND_SCAN(0, E_FM_OP_ERROR,
Unknown destination '%s': %s., buf);
  }
else if (type == E_FM_OP_MOVE)
  {
-if (!strcmp(argv[i],buf))
+if (!strcmp(argv[i], buf))
   goto skip_arg;
 
-if (buf[0]!='/')
+if (buf[0] != '/')
   _E_FM_OP_ERROR_SEND_SCAN(0, E_FM_OP_ERROR,
Unknown destination '%s': %s., buf);
 
@@ -673,7 +668,8 @@
   *queue = eina_list_remove_list(*queue, *node);
   *node = NULL;
   *mark = 0;
-  /* Do not clean out _e_fm_op_error_response. This way when another error occures, it would be handled automatically. */
+  /* Do not clean out _e_fm_op_error_response. This way when another error
+   * occures, it would be handled automatically. */
   return 1;
}
   }
@@ -935,8 +931,6 @@
  }
else
  {
-int ret = 0;
-
 vsnprintf(str, READBUFSIZE - 3 * sizeof(int), fmt, ap);
 len = strlen(str);
 
@@ -944,7 +938,7 @@
 *((int *)(buf + sizeof(int))) = type;
 *((int *)(buf + (2 * sizeof(int = len + 1;
 
-ret = write(STDOUT_FILENO, buf, (3 * sizeof(int)) + len + 1);
+write(STDOUT_FILENO, buf, (3 * sizeof(int)) + len + 1);
 
 E_FM_OP_DEBUG(%s, str);
 E_FM_OP_DEBUG( Error sent.\n);
@@ -993,8 +987,7 @@
const int magic = E_FM_OP_MAGIC;
const int id = E_FM_OP_PROGRESS;
char *p, *data;
-

[E-devel] [e] Translation broken !

2012-09-29 Thread rustyBSD

Mmmh... The translation of e/src/modules/notification
seems to be broken.

I don't know if it's the right thing to do, but I added
entries in POTFILES.in/.skip.

Then we can removee/src/modules/notification/po.
--- po/POTFILES.in	2012-09-29 13:14:20.739145592 +0200
+++ po/POTFILES.in	2012-09-29 13:14:06.559345319 +0200
@@ -259,3 +259,7 @@
 src/modules/xkbswitch/e_mod_main.c
 src/modules/xkbswitch/e_mod_config.c
 src/modules/xkbswitch/e_mod_parse.c
+src/modules/notification/e_mod_box.c
+src/modules/notification/e_mod_config_item.c
+src/modules/notification/e_mod_main.c
+src/modules/notification/e_mod_config.c
--- po/POTFILES.skip	2012-09-29 13:14:24.064098773 +0200
+++ po/POTFILES.skip	2012-09-29 13:12:42.653529510 +0200
@@ -60,3 +60,4 @@
 src/modules/conf_wallpaper2/e_int_config_wallpaper.c
 src/modules/conf_wallpaper2/e_mod_main.c
 src/modules/conf_wallpaper2/module.desktop.in
+src/modules/notification/module.desktop.in
--
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

2012-09-28 Thread rustyBSD

Le 28/09/2012 09:04, Carsten Haitzler (The Rasterman) a écrit :
 Can you please revert your changes ?
 why? its better than the code that was there (your patch). your patch did 
 this:

 1. find out size of file
 2. alloc memory for ENTIRE file
 3. fill buffer with  random data or 0xff
 4. write whole buffer in 1 write call
 5. fsync the file

 this will be JUSt as slow and blocking as the code there now, except the code
 now doesn't need as much memory. if it was a 2gb file u'd need 2gb of ram or
 it'd fail. now it needs a fixed 64k.

 so why revert it? it's an improvement.
You fucking don't understand what i told.

I told that

I HAVE ALREADY MADE A PATCH WHICH DOES A BETTER JOB
THAN YOURS, AND THAT I'M JUST WAITING FOR VTORRI

Isn't that fucking clear ?
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

2012-09-28 Thread rustyBSD

Le 28/09/2012 12:39, Carsten Haitzler (The Rasterman) a écrit :
 you're waiting for vincent to commit patches? what patches? where? by who?
 doing what? you planned to do something ... but never mention you did it.
 planning and doing are very different things. you didn't say that the patches
 you sent fix this. sorry but your mails are incredibly far from being clear on
 the topic. your first reply to me definitely is not. and then its revert
 changes which of course i refused as it'd make the code worse.

 could you please actually be clear before resorting to swearing and asking for
 reverts?

You're not doing (overwrite_count) passes,
but (overwrite_count*NB_PASS). You cannot
cancel operation and see progression.

Here is a patch.

$ svn update -r77020 e_fm_op.c
And then patch.

So we are doing the same thing (I mean, in
a loop), but correctly. (and ...random_buf()
never returns -1, so - void).

Discomfitor asked me to improve e_fm_op.c,
and I started by adding this little feature.

It's just that it make me angry when I'm in
charge of something which is modified by others
without asking anything. Then I loose my time to
write mails, as if I had only that to do.
--- e_fm_op.c	2012-09-28 17:01:30.375484254 +0200
+++ e_fm_op.c	2012-09-28 17:14:05.047492064 +0200
@@ -105,7 +105,7 @@
 static int   _e_fm_op_remove_atom(E_Fm_Op_Task *task);
 static int   _e_fm_op_rename_atom(E_Fm_Op_Task *task);
 static int   _e_fm_op_destroy_atom(E_Fm_Op_Task *task);
-static int   _e_fm_op_random_buf(char *buf, ssize_t len);
+static void  _e_fm_op_random_buf(char *buf, ssize_t len);
 static char  _e_fm_op_random_char();
 
 Ecore_Fd_Handler *_e_fm_op_stdin_handler = NULL;
@@ -1679,6 +1679,9 @@
if (_e_fm_op_abort) goto finish;
static int fd = -1;
static char *buf = NULL;
+   static int passes = 0;
+   static off_t pos = 0;
+   off_t sz;
 
if (fd == -1)
  {
@@ -1702,27 +1705,39 @@
!S_ISREG(st2.st_mode))
  goto finish;
 
-   if ((buf = malloc(st2.st_size)) == NULL)
+   if ((buf = malloc(READBUFSIZE)) == NULL)
  goto finish;
 
task-src.st.st_size = st2.st_size;
  }
 
-   if (lseek(fd, SEEK_SET, 0) == -1)
- goto finish;
+   if (pos + READBUFSIZE  task-src.st.st_size) sz = task-src.st.st_size - pos;
+   else sz = READBUFSIZE;
 
-   if (_e_fm_op_random_buf(buf, task-src.st.st_size) == -1)
- memset(buf, 0xFF, task-src.st.st_size);
-   if (write(fd, buf, task-src.st.st_size) != task-src.st.st_size)
+   _e_fm_op_random_buf(buf, sz);
+   if (write(fd, buf, sz) != sz)
  goto finish;
if (fsync(fd) == -1)
  goto finish;
 
-   task-dst.done++;
-   _e_fm_op_update_progress_report_simple((double)task-dst.done/NB_PASS*100, /dev/urandom, task-src.name);
+   pos += sz;
 
-   if (task-dst.done == NB_PASS)
- goto finish;
+   _e_fm_op_update_progress_report_simple((double) (pos + (passes * task-src.st.st_size)) /
+  (task-src.st.st_size * NB_PASS) * 100,
+  /dev/urandom, task-src.name);
+
+   if (pos = task-src.st.st_size)
+ {
+   passes++;
+
+   if (passes == NB_PASS)
+ goto finish;
+   if (lseek(fd, SEEK_SET, 0) == -1)
+ goto finish;
+
+   pos = 0;
+   return 1;
+ }
 
return 1;
 
@@ -1730,11 +1745,13 @@
close(fd);
fd = -1;
E_FREE(buf);
+   passes = 0;
+   pos = 0;
task-finished = 1;
return 1;
 }
 
-static int
+static void
 _e_fm_op_random_buf(char *buf, ssize_t len)
 {
int f = -1;
@@ -1746,7 +1763,7 @@
  {
 buf[i] = _e_fm_op_random_char();
  }
-   return 0;
+   return;
  }
 
if (read(f, buf, len) != len)
@@ -1758,7 +1775,7 @@
  }
 
close(f);
-   return 0;
+   return;
 }
 
 static char
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

2012-09-28 Thread rustyBSD

Le 28/09/2012 19:21, Lucas De Marchi a écrit :
 There's no need for a revert here. Code now is better than it was
 before. If yours is indeed better yet (didn't look your patch), just
 re-diff it and *send* as an improvement. You didn't submit it before
 and raster committed a much more sane code.
.
--- e_fm_op.c   2012-09-28 20:49:39.744734480 +0200
+++ e_fm_op.c   2012-09-28 20:49:25.796987970 +0200
@@ -105,7 +105,7 @@
 static int   _e_fm_op_remove_atom(E_Fm_Op_Task *task);
 static int   _e_fm_op_rename_atom(E_Fm_Op_Task *task);
 static int   _e_fm_op_destroy_atom(E_Fm_Op_Task *task);
-static int   _e_fm_op_random_buf(char *buf, ssize_t len);
+static void  _e_fm_op_random_buf(char *buf, ssize_t len);
 static char  _e_fm_op_random_char();
 
 Ecore_Fd_Handler *_e_fm_op_stdin_handler = NULL;
@@ -1679,10 +1679,9 @@
if (_e_fm_op_abort) goto finish;
static int fd = -1;
static char *buf = NULL;
-   off_t pos, sz;
-// if we do this 7 times! we're
-//   int cnt, overwrite_count = 7;
-   int cnt, overwrite_count = 1;
+   static int passes = 0;
+   static off_t pos = 0;
+   off_t sz;
 
if (fd == -1)
  {
@@ -1706,39 +1705,39 @@
!S_ISREG(st2.st_mode))
  goto finish;
 
-   if ((buf = malloc(65536)) == NULL)
+   if ((buf = malloc(READBUFSIZE)) == NULL)
  goto finish;
 
task-src.st.st_size = st2.st_size;
  }
 
-   for (cnt = 0; cnt  overwrite_count; cnt++)
+   if (pos + READBUFSIZE  task-src.st.st_size) sz = task-src.st.st_size - 
pos;
+   else sz = READBUFSIZE;
+
+   _e_fm_op_random_buf(buf, sz);
+   if (write(fd, buf, sz) != sz)
+ goto finish;
+   if (fsync(fd) == -1)
+ goto finish;
+
+   pos += sz;
+
+   _e_fm_op_update_progress_report_simple((double) (pos + (passes * 
task-src.st.st_size)) /
+  (task-src.st.st_size * NB_PASS) * 
100,
+  /dev/urandom, task-src.name);
+
+   if (pos = task-src.st.st_size)
  {
-if (lseek(fd, SEEK_SET, 0) == -1)
-  goto finish;
-
-for (pos = 0; pos  task-src.st.st_size; pos += 65536)
-  {
- sz = 65536;
- if ((task-src.st.st_size - pos)  sz) sz = task-src.st.st_size 
- pos;
- if (_e_fm_op_random_buf(buf, sz) == -1)
-   // alternate patterb between 0x00 and 0xff each round starting 
with 0xff
-   memset(buf, 0xff * ((cnt + 1)  0x1), sz);
- if (write(fd, buf, sz) != sz)
-   {
-  fsync(fd);
-  goto finish;
-   }
-  }
-if (fsync(fd) == -1)
-  goto finish;
- }
+   passes++;
 
-   task-dst.done++;
-   _e_fm_op_update_progress_report_simple((double)task-dst.done/NB_PASS*100, 
/dev/urandom, task-src.name);
+   if (passes == NB_PASS)
+ goto finish;
+   if (lseek(fd, SEEK_SET, 0) == -1)
+ goto finish;
 
-   if (task-dst.done == NB_PASS)
- goto finish;
+   pos = 0;
+   return 1;
+ }
 
return 1;
 
@@ -1746,11 +1745,13 @@
close(fd);
fd = -1;
E_FREE(buf);
+   passes = 0;
+   pos = 0;
task-finished = 1;
return 1;
 }
 
-static int
+static void
 _e_fm_op_random_buf(char *buf, ssize_t len)
 {
int f = -1;
@@ -1762,7 +1763,7 @@
  {
 buf[i] = _e_fm_op_random_char();
  }
-   return 0;
+   return;
  }
 
if (read(f, buf, len) != len)
@@ -1774,7 +1775,7 @@
  }
 
close(f);
-   return 0;
+   return;
 }
 
 static char
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

Le 27/09/2012 12:10, Carsten Haitzler (The Rasterman) a écrit :
 and that's what i did. a fixed buffer of 64kb is malloced - and random filled
 or 0xff filled as per before - but just written 64k at a time. and yes - it
 handles the tail that may not be a full 64k too.

 here's the question... this is pretty lame security-wise. shouldn't we be
 military/cia/nsa spec and overwrite it at least 7 times? :) oh and this will
 probably/possible get screwed by logging fs's or flash media that may shuffle
 the blocks around on write :) ie it wont help.

 anyway... why not do it 7 times and then we can say not even the cia can get
 your warez after this! :)
I planned to do something like this.

I don't have commit access, and I wait for vtorri to commit
other patches.
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

Le 27/09/2012 18:24, rustyBSD a écrit :
 Le 27/09/2012 12:10, Carsten Haitzler (The Rasterman) a écrit :
 and that's what i did. a fixed buffer of 64kb is malloced - and random filled
 or 0xff filled as per before - but just written 64k at a time. and yes - it
 handles the tail that may not be a full 64k too.

 here's the question... this is pretty lame security-wise. shouldn't we be
 military/cia/nsa spec and overwrite it at least 7 times? :) oh and this will
 probably/possible get screwed by logging fs's or flash media that may shuffle
 the blocks around on write :) ie it wont help.

 anyway... why not do it 7 times and then we can say not even the cia can get
 your warez after this! :)
 I planned to do something like this.

 I don't have commit access, and I wait for vtorri to commit
 other patches.
 --
 Everyone hates slow websites. So do we.
 Make your web apps faster with AppDynamics
 Download AppDynamics Lite for free today:
 http://ad.doubleclick.net/clk;258768047;13503038;j?
 http://info.appdynamics.com/FreeJavaPerformanceDownload.html
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Oh I just saw you already committed a patch.

But... it's bad. If I'm removing a BIG ( 2go) file,
how can I cancel ? I can't. And there is no progress
bar.

(and as I told, i'm just waiting to commit patches...)
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

Le 27/09/2012 18:55, rustyBSD a écrit :
 Le 27/09/2012 18:24, rustyBSD a écrit :
 Le 27/09/2012 12:10, Carsten Haitzler (The Rasterman) a écrit :
 and that's what i did. a fixed buffer of 64kb is malloced - and random 
 filled
 or 0xff filled as per before - but just written 64k at a time. and yes - it
 handles the tail that may not be a full 64k too.

 here's the question... this is pretty lame security-wise. shouldn't we be
 military/cia/nsa spec and overwrite it at least 7 times? :) oh and this will
 probably/possible get screwed by logging fs's or flash media that may 
 shuffle
 the blocks around on write :) ie it wont help.

 anyway... why not do it 7 times and then we can say not even the cia can 
 get
 your warez after this! :)
 I planned to do something like this.

 I don't have commit access, and I wait for vtorri to commit
 other patches.
 --
 Everyone hates slow websites. So do we.
 Make your web apps faster with AppDynamics
 Download AppDynamics Lite for free today:
 http://ad.doubleclick.net/clk;258768047;13503038;j?
 http://info.appdynamics.com/FreeJavaPerformanceDownload.html
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 Oh I just saw you already committed a patch.

 But... it's bad. If I'm removing a BIG ( 2go) file,
 how can I cancel ? I can't. And there is no progress
 bar.

 (and as I told, i'm just waiting to commit patches...)
 --
 Everyone hates slow websites. So do we.
 Make your web apps faster with AppDynamics
 Download AppDynamics Lite for free today:
 http://ad.doubleclick.net/clk;258768047;13503038;j?
 http://info.appdynamics.com/FreeJavaPerformanceDownload.html
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Please revert your changes
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

Le 28/09/2012 01:41, Carsten Haitzler (The Rasterman) a écrit :
 On Thu, 27 Sep 2012 18:55:39 +0200 rustyBSD rusty...@gmx.fr said:

  Le 27/09/2012 18:24, rustyBSD a écrit :
   Le 27/09/2012 12:10, Carsten Haitzler (The Rasterman) a écrit :
   and that's what i did. a fixed buffer of 64kb is malloced - and random
   filled or 0xff filled as per before - but just written 64k at a time. 
   and
   yes - it handles the tail that may not be a full 64k too.
  
   here's the question... this is pretty lame security-wise. shouldn't 
   we be
   military/cia/nsa spec and overwrite it at least 7 times? :) oh and 
   this
   will probably/possible get screwed by logging fs's or flash media 
   that may
   shuffle the blocks around on write :) ie it wont help.
  
   anyway... why not do it 7 times and then we can say not even the cia 
   can
   get your warez after this! :)
   I planned to do something like this.
  
   I don't have commit access, and I wait for vtorri to commit
   other patches.
   --
   Everyone hates slow websites. So do we.
   Make your web apps faster with AppDynamics
   Download AppDynamics Lite for free today:
   http://ad.doubleclick.net/clk;258768047;13503038;j?
   http://info.appdynamics.com/FreeJavaPerformanceDownload.html
   ___
   enlightenment-devel mailing list
   enlightenment-devel@lists.sourceforge.net
   https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
  Oh I just saw you already committed a patch.
  
  But... it's bad. If I'm removing a BIG ( 2go) file,
  how can I cancel ? I can't. And there is no progress
  bar.
 well... it's no worse than your original patch/code... which would try 
 allocate
 2gb of ram... then write it all at once (and if alloc failed it'd refuse to
 do the rm overwrite at all_. :)


Can you please revert your changes ?
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

2012-09-25 Thread rustyBSD

Le 25/09/2012 15:57, Sebastian Dransfeld a écrit :
 Something like this (untested!!).
Hi,
I use malloc() because OpenBSD's secure rm
uses malloc too.

I'm not sure mmap() is good, but I'll read some
documentation.

In all cases, your patch doesn't work, as
eina_file_map_all() give a read access. So
we can't write randomized data to the file
(PROT_READ).



--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: caro trunk/e/src/bin

2012-09-25 Thread rustyBSD

Le 25/09/2012 15:57, Sebastian Dransfeld a écrit :
 Something like this (untested!!).
Hi,
I use malloc() because OpenBSD's secure rm
uses malloc too.

I'm not sure mmap() is good, but I'll read some
documentation.

In all cases, your patch doesn't work, as
eina_file_map_all() give a read access. So
we can't write randomized data to the file
(PROT_READ).
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Segfault

2012-09-22 Thread rustyBSD


Hi,
== e_fm_op.c l.984 ==
if dst = NULL, strlen() sefaults.

Here is a patch.
--- e_fm_op.c   Sat Sep 22 13:31:24 2012
+++ e_fm_op.c   Sat Sep 22 13:31:19 2012
@@ -980,6 +980,8 @@
int size, src_len, dst_len;
int ret = 0;
 
+   if (!dst) return;
+
src_len = strlen(src);
dst_len = strlen(dst);
 
--
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] e_malloc ?

2012-09-05 Thread rustyBSD

Le 04/09/2012 01:54, Carsten Haitzler (The Rasterman) a écrit :
 agreed. if u abort() or segv() it makes little difference. for small data
 structs (linked list nodes for example) its VERY hard to recover sensibly from
 such an out-of-memory situation. but for large allocs its perfectly possible. 
 a
 blanket abort on fail is bad. really bad. ESPECIALLY for a wm. we try and
 recover in a lot of cases. but there is a lot of allocation going on.

 also the same crash happens when you run out of stack space - no way to 
 recover
 or detect actually...
Ok, so what will we do for all unchecked calls to malloc, calloc,
realloc(), [...] ?
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] e_malloc ?

2012-09-03 Thread rustyBSD

Hi,
in a lot of files, we use calloc(), malloc(),
realloc(), ...

Wouldn't it be good to have stuffs like g_malloc()
which aborts when it cannot allocate memory ?

Because there are a lot of un-null-checked calls,
which could be problematic...
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Int occupation

2012-09-02 Thread rustyBSD

Hi,
in src/bin/e_widget_check.c, the structure
E_Widget_Data has 'int *valptr'. If I'm not
mistaken, it's just used as boolean (true or
false). So why not use Eina_Bool or anything
else 'smaller' ? In e_fm_prop.c, for example,
all int could be Eina_Bool; and if i'm not mistaken
again, it takes less memory than int.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Int occupation

2012-09-02 Thread rustyBSD

Le 02/09/2012 13:20, Daniel Juyung Seo a écrit :
 It looks like valptr is not always boolean. You can set int value to
 the check object.
 So it's int rather than Eina_Bool.
 But yes, most of cases it is used as if it was a boolean.

 Anybody has a historical idea on this?

 Daniel Juyung Seo (SeoZ)
Mmhhh... In e_widget_check.c, i don't see
where valptr isn't a boolean.

Yes, argument passed to e_widget_check_add()
is int, but as it's used as boolean, we also could
replace all call to e_widget_check_add() to pass
an Eina_Bool. It implies a lot of changes... but it
uses less memory.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] Overflow ?

Le 22/08/2012 05:27, Carsten Haitzler (The Rasterman) a écrit :
 On Tue, 21 Aug 2012 18:01:05 +0200 rustyBSD rusty...@gmx.fr said:

 Hi,
 == e/src/modules/illume-keyboard/e_kbd_int.c ==
 line 972:   if (sscanf(buf, %4000s, str) != 1) continue;

 str is declared like this: char str[PATH_MAX];

 Here, if PATH_MAX is  4000, it could overflow.
 On my bsd, PATH_MAX is 1024, and I get a
 warning.

 Idem at line 1015 and 1030.
 ok- fixed buffer. :)

Forgot line 1015:

char label[PATH_MAX];
if (sscanf(buf, %*s %4000s, label) != 1) continue;
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] Double define

Hi,
== src/modules/conf_theme/e_int_config_color_classes.c ==
l. 235: OpenBSD's ctype.h already defines _X.
( http://ftp.cc.uoc.gr/mirrors/OpenBSD/src/include/ctype.h )
So we should use another name.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [e] desklock vuln

== src/bin/e_desklock.c ==
during auth, user's password may be written
to disk (core dump). To avoid that, the solution
is to limit core file size to 0 with|| setrlimit(). The
problem is that once set to 0, the file size can't
be raised; so we can't reset the size to the value
it was before.

Here is a little patch.

Ok or not ?
--- e_desklock.c	2012-08-22 12:45:13.650831422 +0200
+++ e_desklock.c	2012-08-22 12:43:46.449291918 +0200
@@ -196,6 +196,11 @@
E_Manager *man;
int total_zone_num;
E_Event_Desklock *ev;
+   struct rlimit limit;
+
+   limit.rlim_cur = limit.rlim_max = 0;
+   if (setrlimit(RLIMIT_CORE, limit) != 0)
+ printf(ERROR: unable to set core limit:  %s\n, strerror(errno));
 
if (_e_custom_desklock_exe) return 0;
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [e] desklock vuln

Le 22/08/2012 14:12, Tom Hacohen a écrit :
On 22/08/12 15:04, Carsten Haitzler (The Rasterman) wrote:
On Wed, 22 Aug 2012 14:54:30 +0300 Tom Hacohen tom.haco...@samsung.com
said:

On 22/08/12 14:51, Carsten Haitzler (The Rasterman) wrote:
On Wed, 22 Aug 2012 14:46:50 +0300 Tom Hacohen tom.haco...@samsung.com
said:

To be honest, I don't know how secure we can get there because of entry.
We only free (without explicitly erasing) the buffers used internally by
entry (elm+edje) and textblock, so there might be cleartext copies of
the pass in memory anyway...
it doesnt use elm or edje entry or e entry.. its literally done by hand
listening to keystrokes (whihc frankly if u can force coredumps u can
divine
the passwd thru keystroke memory history if u are lucky). :)
So not entry, but it uses text/textblock to show the text, doesn't it?
If so, the same logic applies.
it only shows *

so i guess u could find out how many chars the pw has.. that's it. evas only
ever sees *** (and edje too).

Ah, you are right. I remembered it had issues with handling hebrew
passwords (it showed as many * as the bytes instead of the chars), but
it's because the count was wrong, not a malfunction in edje/textblock.
Now I remember. :)

Ok, cool.

--
Tom.

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

https://www.securecoding.cert.org/confluence/display/seccode/MSC06-C.+Be+aware+of+compiler+optimization+when+dealing+with+sensitive+data

Mmhhh...

[E-devel] [e] useless operation