Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http

2012-03-01 Thread Elevate Efl
One comment to this commit.

On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN 
no-re...@enlightenment.org wrote:

 Log:
 elev8: Remove HTTP module compile-time warnings

 Author:   acidx
 Date: 2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012)
 New Revision: 68596
 Trac: http://trac.enlightenment.org/e/changeset/68596

 Modified:
  trunk/PROTO/elev8/src/modules/http/elev8_http.cc

 Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc
 ===
 --- trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01
 20:28:22 UTC (rev 68595)
 +++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01
 20:39:19 UTC (rev 68596)
 @@ -8,7 +8,7 @@
  int XMLHttpRequest::fd_counter = 0;
  HandleObjectTemplate xmlHttpReqObj;

 -Eina_Bool data_callback(void *data, int type, void *event)
 +Eina_Bool data_callback(void *data, int, void *event)


Why not use __UNUSED__ like the rest of EFL.


  {
Ecore_Con_Event_Url_Data *url_data = (Ecore_Con_Event_Url_Data *)event;
void *ptr = ecore_con_url_data_get(url_data-url_con);
 @@ -29,7 +29,7 @@
return EINA_FALSE;
  }

 -Eina_Bool completion_callback(void *data, int type, void *event)
 +Eina_Bool completion_callback(void *data, int, void *event)
  {
HandleScope handle_scope;
Ecore_Con_Event_Url_Complete *url_complete =
 (Ecore_Con_Event_Url_Complete *)event;
 @@ -81,7 +81,7 @@
out.write((char *)eina_binbuf_string_get(reqObj-data),
   eina_binbuf_length_get(reqObj-data));
out.close();
 -   HTTP_INF(  Size of response Data = %lu bytes,
 +   HTTP_INF(  Size of response Data = %d bytes,

  eina_binbuf_length_get(reqObj-data));
reqObj-responseText =  static_castPersistentString
 (String::New(buf));
 }
 @@ -126,8 +126,7 @@
  }

  HandleValue
 -response_text_getter(LocalString property,
 -const AccessorInfo info)
 +response_text_getter(LocalString, const AccessorInfo info)
  {
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
 @@ -138,8 +137,7 @@
  }

  HandleValue
 -status_getter(LocalString property,
 -const AccessorInfo info)
 +status_getter(LocalString, const AccessorInfo info)
  {
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
 @@ -149,8 +147,7 @@
  }

  HandleValue
 -readystate_getter(LocalString property,
 -const AccessorInfo info)
 +readystate_getter(LocalString, const AccessorInfo info)
  {
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
 @@ -310,7 +307,7 @@
return Undefined();
  }

 -HandleValue createXMLHttpReqInstance(const Arguments args)
 +HandleValue createXMLHttpReqInstance(const Arguments)
  {
HandleScope scope;




 --
 Virtualization  Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http

2012-03-01 Thread Lucas De Marchi
On Thu, Mar 1, 2012 at 10:18 PM, Elevate Efl eflel...@gmail.com wrote:
 One comment to this commit.

 On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN 
 no-re...@enlightenment.org wrote:

 Log:
 elev8: Remove HTTP module compile-time warnings

 Author:       acidx
 Date:         2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012)
 New Revision: 68596
 Trac:         http://trac.enlightenment.org/e/changeset/68596

 Modified:
  trunk/PROTO/elev8/src/modules/http/elev8_http.cc

 Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc
 ===
 --- trunk/PROTO/elev8/src/modules/http/elev8_http.cc    2012-03-01
 20:28:22 UTC (rev 68595)
 +++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc    2012-03-01
 20:39:19 UTC (rev 68596)
 @@ -8,7 +8,7 @@
  int XMLHttpRequest::fd_counter = 0;
  HandleObjectTemplate xmlHttpReqObj;

 -Eina_Bool data_callback(void *data, int type, void *event)
 +Eina_Bool data_callback(void *data, int, void *event)


 Why not use __UNUSED__ like the rest of EFL.

Because this is the standard way to do in C++. The rest of EFL is not
C++ so we can't do this there too.


Lucas De Marchi

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel