Re: [E-devel] patch for a better wallpaper dialog layout

2007-07-21 Thread Alberto Castro 
Hannes Janetzek wrote:
 hi,
 if this patch is ok iwould go on and fix some of the other dialog
 layouts. 
 
 a screenshot is here:
 http://www.informatik.uni-bremen.de/~jeff/conf2.jpg
 
 Regards,
 Hannes jeffdameth Janetzek
 
 
 
 
 Index: e_int_config_wallpaper.c
 ===
 RCS file: 
 /var/cvs/e/e17/apps/e/src/modules/conf_wallpaper/e_int_config_wallpaper.c,v
 retrieving revision 1.1
 diff -u -r1.1 e_int_config_wallpaper.c
 --- e_int_config_wallpaper.c  4 Jul 2007 15:09:24 -   1.1
 +++ e_int_config_wallpaper.c  14 Jul 2007 18:07:58 -
 @@ -57,7 +57,7 @@
  e_int_config_wallpaper_desk(E_Container *con, const char *params)
  {
 int con_num, zone_num, desk_x, desk_y;
 -   
 +
 if (!params) return NULL;
 con_num = zone_num = desk_x = desk_y = -1;
 if (sscanf(params, %i %i %i %i, con_num, zone_num, desk_x, desk_y) 
 != 4)
 @@ -75,7 +75,7 @@
 if (e_config_dialog_find(E, _config_wallpaper_dialog)) return NULL;
 v = E_NEW(E_Config_Dialog_View, 1);
 cw = E_NEW(E_Config_Wallpaper, 1);
 -  
 +
 v-create_cfdata   = _create_data;
 v-free_cfdata = _free_data;
 v-basic.apply_cfdata  = _basic_apply_data;
 @@ -109,7 +109,7 @@
 E_Config_Dialog_Data *cfdata;
 char path[4096];
 const char *homedir;
 -   
 +
 cfdata = dia-cfdata;
 homedir = e_user_homedir_get();
 cfdata-fmdir = 1;
 @@ -132,7 +132,7 @@
  e_int_config_wallpaper_import_done(E_Config_Dialog *dia)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = dia-cfdata;
 cfdata-win_import = NULL;
  }
 @@ -141,7 +141,7 @@
  e_int_config_wallpaper_gradient_done(E_Config_Dialog *dia)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = dia-cfdata;
 cfdata-dia_gradient = NULL;
  }
 @@ -150,7 +150,7 @@
  _cb_button_up(void *data1, void *data2)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = data1;
 if (cfdata-o_fm)
   e_fm2_parent_go(cfdata-o_fm);
 @@ -162,7 +162,7 @@
  _cb_files_changed(void *data, Evas_Object *obj, void *event_info)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = data;
 if (!cfdata-o_fm) return;
 if (!e_fm2_has_parent_get(cfdata-o_fm))
 @@ -187,7 +187,7 @@
 E_Fm2_Icon_Info *ici;
 const char *realpath;
 char buf[4096];
 -   
 +
 cfdata = data;
 if (!cfdata-o_fm) return;
 selected = e_fm2_selected_list_get(cfdata-o_fm);
 @@ -225,7 +225,7 @@
 E_Config_Dialog_Data *cfdata;
 const char *p, *homedir;
 char buf[4096];
 -   
 +
 cfdata = data;
 if (!cfdata-bg) return;
 if (!cfdata-o_fm) return;
 @@ -247,18 +247,18 @@
   else
 p = cfdata-bg;
   }
 -   
 +
 e_fm2_select_set(cfdata-o_fm, p, 1);
 e_fm2_file_show(cfdata-o_fm, p);
  }
  
  static void
 -_cb_files_files_deleted(void *data, Evas_Object *obj, void *event_info) 
 +_cb_files_files_deleted(void *data, Evas_Object *obj, void *event_info)
  {
 E_Config_Dialog_Data *cfdata;
 Evas_List *sel, *all, *n;
 E_Fm2_Icon_Info *ici, *ic;
 -   
 +
 cfdata = data;
 if (!cfdata-bg) return;
 if (!cfdata-o_fm) return;
 @@ -269,23 +269,23 @@
 if (!sel) return;
  
 ici = sel-data;
 -   
 +
 all = evas_list_find_list(all, ici);
 n = evas_list_next(all);
 -   if (!n) 
 +   if (!n)
   {
   n = evas_list_prev(all);
   if (!n) return;
   }
 -   
 +
 ic = n-data;
 if (!ic) return;
 -   
 +
 e_fm2_select_set(cfdata-o_fm, ic-file, 1);
 e_fm2_file_show(cfdata-o_fm, ic-file);
 -   
 +
 evas_list_free(n);
 -   
 +
 evas_object_smart_callback_call(cfdata-o_fm, selection_change, cfdata);
  }
  
 @@ -294,7 +294,7 @@
  {
 E_Config_Dialog_Data *cfdata;
 const char *f;
 -   
 +
 cfdata = data;
 if (cfdata-use_theme_bg)
   {
 @@ -320,7 +320,7 @@
 E_Config_Dialog_Data *cfdata;
 char path[4096];
 const char *homedir;
 -   
 +
 cfdata = data;
 if (cfdata-fmdir == 1)
   {
 @@ -338,11 +338,11 @@
  _cb_import(void *data1, void *data2)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = data1;
 if (cfdata-win_import)
   e_win_raise(cfdata-win_import);
 -   else 
 +   else
   cfdata-win_import = e_int_config_wallpaper_import(cfdata-cfd);
  }
  
 @@ -350,11 +350,11 @@
  _cb_gradient(void *data1, void *data2)
  {
 E_Config_Dialog_Data *cfdata;
 -   
 +
 cfdata = data1;
 if (cfdata-dia_gradient)
   e_win_raise(cfdata-dia_gradient-win);
 -   else 
 +   else
   cfdata-dia_gradient = e_int_config_wallpaper_gradient(cfdata-cfd);
  }
  
 @@ -364,7 +364,7 @@
 char path[4096];
 E_Config_Wallpaper *cw;
 const E_Config_Desktop_Background *cfbg;
 -  
 +
 cw = cfdata-cfd-data;
  
 if (cw-specific_config)
 @@ -400,10 +400,10 @@
cfdata-bg = strdup(cfbg-file);
 }
   }
 -   
 -   if ((!cfdata-bg)

Re: [E-devel] patch for a better wallpaper dialog layout

2007-07-21 Thread Christopher Michael 
Alberto Castro wrote:
 Hannes Janetzek wrote:
 hi,
 if this patch is ok iwould go on and fix some of the other dialog
 layouts. 

 a screenshot is here:
 http://www.informatik.uni-bremen.de/~jeff/conf2.jpg

 Regards,
 Hannes jeffdameth Janetzek

 (accidently i replied to Raster instead of the list.)
 
 I'm going to be really anal about this.
 
 Do we really really need to have a go up a directory button ?

Yes, we need the go up button because a user may have sub-dirs in 
their Personal folder (ie: ~/.e/e/backgrounds/Space Images).

  isn't
 that what the file dialog is for ? 

Which file dialog are you referring to ?

That's enough questions, but don't
 you think both the personal, system, including the theme wallpaper 
 should be part of the list itself (at all times) (you could even add a 
 header, to separate them or make them more visible to the user).

We actually had it like this a long time ago, not sure why the change tho.

  I don't
 see why we need 3 different sources when they could all be selected from 
 the list itself.
 
I'm not seeing 3 different sources...I see 2...Personal and System.

 Now if you allow me to be more critical, the arrow on the go up a 
 directory button never once changes states. Its always the same image, 
 regardless of the button state.
 
Is it supposed to ?

devilhorns



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] patch for a better wallpaper dialog layout

2007-07-21 Thread The Rasterman 
On Sat, 21 Jul 2007 04:40:55 -0400 Christopher Michael [EMAIL PROTECTED]
babbled:

 Alberto Castro wrote:
  Hannes Janetzek wrote:
  hi,
  if this patch is ok iwould go on and fix some of the other dialog
  layouts. 
 
  a screenshot is here:
  http://www.informatik.uni-bremen.de/~jeff/conf2.jpg
 
  Regards,
  Hannes jeffdameth Janetzek
 
  (accidently i replied to Raster instead of the list.)
  
  I'm going to be really anal about this.
  
  Do we really really need to have a go up a directory button ?
 
 Yes, we need the go up button because a user may have sub-dirs in 
 their Personal folder (ie: ~/.e/e/backgrounds/Space Images).
 
   isn't
  that what the file dialog is for ? 
 
 Which file dialog are you referring to ?

this is the wallpaper and theme selector dialogs (for example) - not file
selector. chris is right - you can create subdirs and use them to store
files/wallpapers etc.

 That's enough questions, but don't
  you think both the personal, system, including the theme wallpaper 
  should be part of the list itself (at all times) (you could even add a 
  header, to separate them or make them more visible to the user).
 
 We actually had it like this a long time ago, not sure why the change tho.

it changed because it became a filemanager backed list - and it will only
display 1 directory at a time. personal and system are in completely separate
places on the fs - thus a switch to swap between them. it was a quick way top
keep the functionality with the new ui widgets.

   I don't
  see why we need 3 different sources when they could all be selected from 
  the list itself.
  
 I'm not seeing 3 different sources...I see 2...Personal and System.
 
  Now if you allow me to be more critical, the arrow on the go up a 
  directory button never once changes states. Its always the same image, 
  regardless of the button state.
  
 Is it supposed to ?
 
 devilhorns
 
 
 
 -
 This SF.net email is sponsored by: Microsoft
 Defy all challenges. Microsoft(R) Visual Studio 2005.
 http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] patch for a better wallpaper dialog layout

2007-07-20 Thread The Rasterman 
On Sat, 14 Jul 2007 20:09:46 +0200 Hannes Janetzek [EMAIL PROTECTED] babbled:

a slight problem is that now the theme selector has a different layout... :/
also it only changes advanced mode. not sure i like the inconsistency.

 hi,
 if this patch is ok iwould go on and fix some of the other dialog
 layouts. 
 
 a screenshot is here:
 http://www.informatik.uni-bremen.de/~jeff/conf2.jpg
 
 Regards,
 Hannes jeffdameth Janetzek


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] patch for a better wallpaper dialog layout

2007-07-14 Thread Hannes Janetzek 
hi,
if this patch is ok iwould go on and fix some of the other dialog
layouts. 

a screenshot is here:
http://www.informatik.uni-bremen.de/~jeff/conf2.jpg

Regards,
Hannes jeffdameth JanetzekIndex: e_int_config_wallpaper.c
===
RCS file: /var/cvs/e/e17/apps/e/src/modules/conf_wallpaper/e_int_config_wallpaper.c,v
retrieving revision 1.1
diff -u -r1.1 e_int_config_wallpaper.c
--- e_int_config_wallpaper.c	4 Jul 2007 15:09:24 -	1.1
+++ e_int_config_wallpaper.c	14 Jul 2007 18:07:58 -
@@ -57,7 +57,7 @@
 e_int_config_wallpaper_desk(E_Container *con, const char *params)
 {
int con_num, zone_num, desk_x, desk_y;
-   
+
if (!params) return NULL;
con_num = zone_num = desk_x = desk_y = -1;
if (sscanf(params, %i %i %i %i, con_num, zone_num, desk_x, desk_y) != 4)
@@ -75,7 +75,7 @@
if (e_config_dialog_find(E, _config_wallpaper_dialog)) return NULL;
v = E_NEW(E_Config_Dialog_View, 1);
cw = E_NEW(E_Config_Wallpaper, 1);
-  
+
v-create_cfdata   = _create_data;
v-free_cfdata = _free_data;
v-basic.apply_cfdata  = _basic_apply_data;
@@ -109,7 +109,7 @@
E_Config_Dialog_Data *cfdata;
char path[4096];
const char *homedir;
-   
+
cfdata = dia-cfdata;
homedir = e_user_homedir_get();
cfdata-fmdir = 1;
@@ -132,7 +132,7 @@
 e_int_config_wallpaper_import_done(E_Config_Dialog *dia)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = dia-cfdata;
cfdata-win_import = NULL;
 }
@@ -141,7 +141,7 @@
 e_int_config_wallpaper_gradient_done(E_Config_Dialog *dia)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = dia-cfdata;
cfdata-dia_gradient = NULL;
 }
@@ -150,7 +150,7 @@
 _cb_button_up(void *data1, void *data2)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = data1;
if (cfdata-o_fm)
  e_fm2_parent_go(cfdata-o_fm);
@@ -162,7 +162,7 @@
 _cb_files_changed(void *data, Evas_Object *obj, void *event_info)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = data;
if (!cfdata-o_fm) return;
if (!e_fm2_has_parent_get(cfdata-o_fm))
@@ -187,7 +187,7 @@
E_Fm2_Icon_Info *ici;
const char *realpath;
char buf[4096];
-   
+
cfdata = data;
if (!cfdata-o_fm) return;
selected = e_fm2_selected_list_get(cfdata-o_fm);
@@ -225,7 +225,7 @@
E_Config_Dialog_Data *cfdata;
const char *p, *homedir;
char buf[4096];
-   
+
cfdata = data;
if (!cfdata-bg) return;
if (!cfdata-o_fm) return;
@@ -247,18 +247,18 @@
 	else
 	  p = cfdata-bg;
  }
-   
+
e_fm2_select_set(cfdata-o_fm, p, 1);
e_fm2_file_show(cfdata-o_fm, p);
 }
 
 static void
-_cb_files_files_deleted(void *data, Evas_Object *obj, void *event_info) 
+_cb_files_files_deleted(void *data, Evas_Object *obj, void *event_info)
 {
E_Config_Dialog_Data *cfdata;
Evas_List *sel, *all, *n;
E_Fm2_Icon_Info *ici, *ic;
-   
+
cfdata = data;
if (!cfdata-bg) return;
if (!cfdata-o_fm) return;
@@ -269,23 +269,23 @@
if (!sel) return;
 
ici = sel-data;
-   
+
all = evas_list_find_list(all, ici);
n = evas_list_next(all);
-   if (!n) 
+   if (!n)
  {
 	n = evas_list_prev(all);
 	if (!n) return;
  }
-   
+
ic = n-data;
if (!ic) return;
-   
+
e_fm2_select_set(cfdata-o_fm, ic-file, 1);
e_fm2_file_show(cfdata-o_fm, ic-file);
-   
+
evas_list_free(n);
-   
+
evas_object_smart_callback_call(cfdata-o_fm, selection_change, cfdata);
 }
 
@@ -294,7 +294,7 @@
 {
E_Config_Dialog_Data *cfdata;
const char *f;
-   
+
cfdata = data;
if (cfdata-use_theme_bg)
  {
@@ -320,7 +320,7 @@
E_Config_Dialog_Data *cfdata;
char path[4096];
const char *homedir;
-   
+
cfdata = data;
if (cfdata-fmdir == 1)
  {
@@ -338,11 +338,11 @@
 _cb_import(void *data1, void *data2)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = data1;
if (cfdata-win_import)
  e_win_raise(cfdata-win_import);
-   else 
+   else
  cfdata-win_import = e_int_config_wallpaper_import(cfdata-cfd);
 }
 
@@ -350,11 +350,11 @@
 _cb_gradient(void *data1, void *data2)
 {
E_Config_Dialog_Data *cfdata;
-   
+
cfdata = data1;
if (cfdata-dia_gradient)
  e_win_raise(cfdata-dia_gradient-win);
-   else 
+   else
  cfdata-dia_gradient = e_int_config_wallpaper_gradient(cfdata-cfd);
 }
 
@@ -364,7 +364,7 @@
char path[4096];
E_Config_Wallpaper *cw;
const E_Config_Desktop_Background *cfbg;
-  
+
cw = cfdata-cfd-data;
 
if (cw-specific_config)
@@ -400,10 +400,10 @@
 	 cfdata-bg = strdup(cfbg-file);
 	  }
  }
-   
-   if ((!cfdata-bg)  e_config-desktop_default_background) 
+
+   if ((!cfdata-bg)  e_config-desktop_default_background)
  cfdata-bg = strdup(e_config-desktop_default_background);
-   
+
if (cfdata-bg)
  {
 	const char *f;
@@ -434,9 +434,9 @@
 static void
 _free_data(E_Config_Dialog *cfd, E_Config_Dialog_Data *cfdata)
 {
-   if (cfdata-win_import) 
+   if