[Evolution-hackers] Disabled code in Evolution has a bug

2008-01-15 Thread Philip Van Hoof
Hi there,

In Evolution this code is not used (imap_parse_namespace_response -
imap_namespace_decode), nonetheless it contains a bug.

If the delimiter for a namespace is NIL, the imap_next_word will search
for the first space. This ain't correct if there are no parameters to
parse. For example ((MyShared NIL)).

http://tinymail.org/trac/tinymail/changeset/3263#file2

I'm adding Jeffrey in CC because I think he once intended to use this
code to improve namespace support?

Camel-lite has gotten too specific in this area of the code: it supports
the shared and personal namespace by only asking for LSUB recursively
for those two namespaces, and LIST and LSUB for the personal namespace.

The namespace-line parsing, however, is recovered from things that I
found in existing (but not used) camel's imap code.

ps. I commented out the original line in camel-lite because the += 3
might not be the right fix (perhaps is fixing imap_next_word better).


Hf.


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Warning: careful rebuilding with my makefile!!

2008-01-15 Thread Reid Thompson
Paul Smith wrote:
 Hi all;
 
 This morning just after the 2.21.5 release of Evo was announced, the 2.4
 branch of libsoup was merged to the trunk.
 
 This version is not that easy to build: it requires a newer version of
 GLIB than is available in Ubunut Gutsy, at least (2.15 or better, while
 Gutsy contains 2.14.1)  Plus, someone reported to me that even after
 getting a new-enough GLIB, they still couldn't finish building libsoup:
 
 gcc -g -Wall -Wstrict-prototypes -Wmissing-declarations 
 -Wmissing-prototypes -Wnested-externs -Wpointer-arith -D_REENTRANT -o 
 .libs/context-test context-test.o test-utils.o  
 ../libsoup/.libs/libsoup-2.4.so  -Wl,--rpath -Wl,/opt/evo/lib
 ../libsoup/.libs/libsoup-2.4.so: undefined reference to 
 `g_cancellable_is_cancelled'
 
 So, maybe you need something even more new than suggested by the
 configure.in file!  I haven't tried this myself so I can't say for sure.
 
 (thanks to Gareth Doutch for the heads-up!)
 

gentoo also does not yet offer 2.15 GLIB either ( stable or ~ ).  Which kinda 
puts me in a bind, since it appears that the last successful build I got has an 
issue with logging into exchange OWA.  I guess I'll be failing over to mutt  
tbird for a few days -- trying to decide if I wanna introduce GLIB 2.15 or not. 
  Anyone have any heads up issues re GLIB 2.15?
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Possible memory leak

2008-01-15 Thread Jose Dapena Paz

El lun, 14-01-2008 a las 14:33 +0100, Philip Van Hoof escribió:

 I think this needs to be something like this:
 
 GSList *item = cc-status_stack;
 cc-status_stack = g_slist_remove_link(cc-status_stack, item);
 g_slist_free (item);

Or just use g_slist_delete_link:

cc-status_stack = g_slist_delete_link (cc-status_stack, cc-status_stack);

AFAIK it frees the list node.

-- 
Jose Dapena Paz [EMAIL PROTECTED]
Igalia
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers