Re: [Evolution-hackers] Base URI for "On This Computer"

2010-07-15 Thread Matthew Barnes
On Wed, 2010-06-09 at 08:56 -0400, Matthew Barnes wrote:
> A local ESource with a URI of:
> 
> file:///home/mbarnes/.evolution/calendar/local/<>
> 
> will have to be changed as follows when we move to XDG base directories:
> 
> file:///home/mbarnes/.local/share/evolution/calendar/<>
> 
> but since they have to change anyway, I propose just naming it:
> 
> local://<>
> 
> to avoid the account migration problems I described previously.


Just a heads up that I plan to push this today if testing goes well.

And it will be "local:<>" as Ross suggested (no slashes).

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Matthew Barnes
On Wed, 2010-06-09 at 14:49 +0100, Ross Burton wrote:
> local:<>, surely.  No need for // when you're not putting a
> hostname or path.

Good point.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread chen
On Wed, 2010-06-09 at 08:56 -0400, Matthew Barnes wrote:
> On Wed, 2010-06-09 at 08:41 -0400, Matthew Barnes wrote:
> > So a local source group with a base URI of:
> > 
> > file:///home/mbarnes/.evolution/calendar/local
> > 
> > will become:
> > 
> > file:///home/mbarnes/.local/share/evolution/calendar
> 
> 
> Let me rephrase this to try and better clarify:
> 
> A local ESource with a URI of:
> 
> file:///home/mbarnes/.evolution/calendar/local/<>
> 
> will have to be changed as follows when we move to XDG base directories:
> 
> file:///home/mbarnes/.local/share/evolution/calendar/<>
> 
> but since they have to change anyway, I propose just naming it:
> 
> local://<>
> 
> to avoid the account migration problems I described previously.
Yup makes sense. It is worth to list all the apps which uses eds for 
address-book and calendar and notify the changes to them or directly
make changes there. I guess you might have this already in your to-do
list :)

Thanks, Chenthill.
> 
> 
> ___
> evolution-hackers mailing list
> evolution-hackers@gnome.org
> To change your list options or unsubscribe, visit ...
> http://mail.gnome.org/mailman/listinfo/evolution-hackers



___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Ross Burton
On Wed, 2010-06-09 at 08:56 -0400, Matthew Barnes wrote:
> but since they have to change anyway, I propose just naming it:
> 
> local://<>

local:<>, surely.  No need for // when you're not putting a
hostname or path.

Ross
-- 
Ross Burton mail: r...@burtonini.com
  jabber: r...@burtonini.com
   www: http://burtonini.com


signature.asc
Description: This is a digitally signed message part
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Matthew Barnes
On Wed, 2010-06-09 at 08:41 -0400, Matthew Barnes wrote:
> So a local source group with a base URI of:
> 
> file:///home/mbarnes/.evolution/calendar/local
> 
> will become:
> 
> file:///home/mbarnes/.local/share/evolution/calendar


Let me rephrase this to try and better clarify:

A local ESource with a URI of:

file:///home/mbarnes/.evolution/calendar/local/<>

will have to be changed as follows when we move to XDG base directories:

file:///home/mbarnes/.local/share/evolution/calendar/<>

but since they have to change anyway, I propose just naming it:

local://<>

to avoid the account migration problems I described previously.


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Matthew Barnes
On Wed, 2010-06-09 at 17:50 +0530, chen wrote:
> Changing the uri to local:// might break other applications who depend
> on the uri to check if its a local calendar source. I could not
> understand what kind of problems changing uri solves.. Is it really
> necessary to change the uri ?  Just looked at one such case in a test
> program, test-ecal.c.

The immediate problem is that I'm trying to move us toward XDG base
directories instead of lumping everything under ~/.evolution (see my
previous post about that).

So a local source group with a base URI of:

file:///home/mbarnes/.evolution/calendar/local

will become:

file:///home/mbarnes/.local/share/evolution/calendar

But we've been getting bit by these absolute paths for years.  If a user
backs up his accounts and then restores them under a different username,
the URI is no longer valid and things break.  So rather than pile on yet
more workarounds and migration cruft, I'm trying to fix the root problem
by eliminating the need to specify a file path at all.

Do you know of any applications that actually check for "file://"?
Tracker maybe?  (and I'm okay with forcing them to adapt)

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread chen
On Wed, 2010-06-09 at 06:32 -0400, Matthew Barnes wrote:
> On Wed, 2010-06-09 at 09:18 +0200, Milan Crha wrote:
> > Are you going to change ESourceGroup's base_uri to contain only the
> > protocol for all the ESourceGroups? If yes, then I think it's not the
> > best thing, because for example evolution-mapi uses as base uri
> > "mapi://u...@server/", and each account you have configured and enabled
> > in the preferences has its own group. It cannot be distinguished just by
> > "mapi://", because for example (I believe) every user has its default
> > calendar named "Calendar".
> 
> No, I'm not touching MAPI, only trying to fix the absolute path problem
> with the "On This Computer" group.  Maybe instead of using "file://",
> which already has an established meaning, we should just make one up so
> the real absolute file system path is implicit.  Perhaps "local://", so
> e_source_get_uri() would return "local://<>" and that would
> fully describe an "On This Computer" source in the context of a given
> source list.
Changing the uri to local:// might break other applications who depend
on the uri to check if its a local calendar source. I could not
understand what kind of problems changing uri solves.. Is it really
necessary to change the uri ?  Just looked at one such case in a test
program, test-ecal.c.

- Chenthill.
> 
> Again, as far as I can tell the URI just needs to uniquely identify the
> source.  It's not used -verbatim- to open files or connect to servers.
> 
> ___
> evolution-hackers mailing list
> evolution-hackers@gnome.org
> To change your list options or unsubscribe, visit ...
> http://mail.gnome.org/mailman/listinfo/evolution-hackers



___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Matthew Barnes
On Wed, 2010-06-09 at 09:18 +0200, Milan Crha wrote:
> Are you going to change ESourceGroup's base_uri to contain only the
> protocol for all the ESourceGroups? If yes, then I think it's not the
> best thing, because for example evolution-mapi uses as base uri
> "mapi://u...@server/", and each account you have configured and enabled
> in the preferences has its own group. It cannot be distinguished just by
> "mapi://", because for example (I believe) every user has its default
> calendar named "Calendar".

No, I'm not touching MAPI, only trying to fix the absolute path problem
with the "On This Computer" group.  Maybe instead of using "file://",
which already has an established meaning, we should just make one up so
the real absolute file system path is implicit.  Perhaps "local://", so
e_source_get_uri() would return "local://<>" and that would
fully describe an "On This Computer" source in the context of a given
source list.

Again, as far as I can tell the URI just needs to uniquely identify the
source.  It's not used -verbatim- to open files or connect to servers.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Base URI for "On This Computer"

2010-06-09 Thread Milan Crha
On Tue, 2010-06-08 at 21:17 -0400, Matthew Barnes wrote:
> Is there any reason why we can't just use "file://" as the base URI for
> the "On This Computer" source group?  No other group uses that scheme,
> so it seems we could identify the "On This Computer" group as "file://"
> as easily as "file://home/mbarnes/.evolution/calendar/local".  Plus it
> would solve a whole class of migration issues and help make moving to
> XDG base directories easier.
> 
> I can't find anything that actually uses the source group's base URI to
> locate files -- everything I see uses a hard-coded path, which actually
> works out well for me in this case.

Hi,
I'm not much sure what you are trying to do, but even you probably know,
the e_source_get_uri uses ESourceGroup's base uri and a relative uri of
the ESource to build the full uri, if not built/set an absolute uri on
the ESource already.

Are you going to change ESourceGroup's base_uri to contain only the
protocol for all the ESourceGroups? If yes, then I think it's not the
best thing, because for example evolution-mapi uses as base uri
"mapi://u...@server/", and each account you have configured and enabled
in the preferences has its own group. It cannot be distinguished just by
"mapi://", because for example (I believe) every user has its default
calendar named "Calendar".
Hope that helps,
Milan

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] Base URI for "On This Computer"

2010-06-08 Thread Matthew Barnes
Is there any reason why we can't just use "file://" as the base URI for
the "On This Computer" source group?  No other group uses that scheme,
so it seems we could identify the "On This Computer" group as "file://"
as easily as "file://home/mbarnes/.evolution/calendar/local".  Plus it
would solve a whole class of migration issues and help make moving to
XDG base directories easier.

I can't find anything that actually uses the source group's base URI to
locate files -- everything I see uses a hard-coded path, which actually
works out well for me in this case.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers