[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 05:12 EST --- (In reply to comment #1) Ok, I'll do the review. Thx. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221015] Review Request: ksplash-engine-moodin - Moodin is a splash engine for KDE Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksplash-engine-moodin - Moodin is a splash engine for KDE Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221015 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 06:06 EST --- Hi. Some time ago I've made(*) a splash screen with the fc6 artwork. Perhaps it would be worth to think about an inclusion in the package? Otherwise just ignore this comment. :) https://www.redhat.com/archives/fedora-art-list/2006-November/msg00145.html * I'm not an artist. The screen works for me (tm) but surely needs some enhancement. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] Review Request: freetype1 compatibility FreeType 1.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freetype1 compatibility FreeType 1.x https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 08:06 EST --- Thanks, now that I'm sorta back online I've imported and build this, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] Review Request: freetype1 - FreeType 1.x compatibility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freetype1 - FreeType 1.x compatibility library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: freetype1 |Review Request: freetype1 - |compatibility FreeType 1.x |FreeType 1.x compatibility ||library -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: LabPlot - Data Analysis and Visualization
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 08:35 EST ---
A few comments:
1.
Requires: kdelibs ImageMagick-c++ gsl fftw
aren't required, rpm will(should!) pick these up automatically, you should
remove these manual dependencies.
2. subpkgs, particularly -devel, should
Requires: %{name} = %{version}-%{devel}
3. configure \
%ifarch x86_64 sparc64 ppc64 amd64
--enable-libsuffix=64 \
--with-qt-libraries=$QTDIR/lib \
%endif
shouldn't be required. qt packaging properly sets QTLIB env variable for awhile
now.
4. instead of
sed -i -e \
s'|Categories=Qt;KDE;Education;Science;Physics;Math;|Categories=Science;|' \
%{buildroot}%{_datadir}/applications/kde/%{name}.desktop
It's preferable to use
desktop-file-install --remove-category=...
(and I'd argue you shouldn't be removing Qt;KDE;Education categories
5. items under
%{_datadir}/apps/%{name}/handbook
imo, should be marked %doc
6. These are not required:
%post devel -p /sbin/ldconfig
%postun devel -p /sbin/ldconfig
and -devel's
Requires(post):/sbin/ldconfig
Requires(postun): /sbin/ldconfig
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221957] Review Request: ksshaskpass - A KDE version of ssh-askpass with KWallet support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksshaskpass - A KDE version of ssh-askpass with KWallet support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221957 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 09:01 EST --- Excellent, thanks for the explanations and update. APPROVED. Now we need the author's also cool-looking ksshagent (: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 10:31 EST --- I have fixed he above issues. Spec URL: http://www.stahnkage.com/rpms/pastebin.spec SRPM URL: http://www.stahnkage.com/rpms/pastebin-0.50-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 10:41 EST --- ok looks good and the package works. APPROVED and ill sponsor you also as it seems you are not sponsored already apply for cvsextras group access -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pastebin - A collaborative debugging tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
OtherBugsDependingO|163779 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:08 EST ---
(In reply to comment #1)
rpmlint is silent.
rpmlint is not silent:
W: pastebin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
Also, there are some documentation files in %{_datadir}/pastebin/lib/geshi/docs
which should be moved to %doc. Creation of new directory there, like geshi
sounds like a good solution. It seems to me that the content of
{_datadir}/pastebin/lib/geshi may be moved there as well, obviously after some
fixing in example.php.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:10 EST --- Oops, I didn't want to set an FE-REVIEW blocker back. Changing to FE-ACCEPT again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:27 EST --- Are you saying the geshi doc should be in /usr/share/doc/geshi or /usr/share/doc/pastebin-0.50/geshi? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:32 EST --- Well, some notes: Keep timestamps for text files as possible. ( Timestamps in http://fedoraproject.org/wiki/Packaging/Guidelines ) * Use cp -p or install -p instead of just cp or install * for sed usage: find . -type f| xargs sed -i 's/\r//' Well, this usage of find - sed change timestamps of all files under the directory ., even some (many) files are actually not necessary to be fixed. Just use sed to the files which are _actually_ needed to be changed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:35 EST --- (In reply to comment #6) Are you saying the geshi doc should be in /usr/share/doc/geshi or /usr/share/doc/pastebin-0.50/geshi? I meant the second one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:49 EST --- with the find and sed removed i get [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |grep wrong-script-end-of-line-encoding |wc -l 84 [EMAIL PROTECTED] SPECS]$ rpm -qlp /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |wc -l 106 [EMAIL PROTECTED] SPECS]$ so nearly every single file is dos line ended in this instance i think it is fine to mass change line endings. if it was a small handfull of files i would do them individually. but that is not the case. as far as the docs yeah I missed that they should go into %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:53 EST --- as far as rpmlint goes [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-1.noarch.rpm [EMAIL PROTECTED] SPECS]$ it is indeed silent for me if there is mixed spaces/tabs then thats should be fixed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:12 EST --- (In reply to comment #10) it is indeed silent for me if there is mixed spaces/tabs then thats should be fixed Apart from built rpm file, you ought to also check rpmlint against source rpm file. [EMAIL PROTECTED] ~]$ rpmlint ~/rpmbuild/SRPMS/pastebin-0.50-2.src.rpm W: pastebin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:15 EST --- (In reply to comment #9) with the find and sed removed i get [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |grep wrong-script-end-of-line-encoding |wc -l 84 [EMAIL PROTECTED] SPECS]$ rpm -qlp /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |wc -l 106 [EMAIL PROTECTED] SPECS]$ so nearly every single file is dos line ended in this instance i think it is fine to mass change line endings. if it was a small handfull of files i would do them individually. but that is not the case. Well, even this case, still checking if the file sed command is to be applied is really a text file. As far as I checked, there is one file which is not a text file (./public_html/favicon.ico), against this file sed command should not be used. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 215224] Review Request: gtk-murrine-engine - Murrine GTK2 engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtk-murrine-engine - Murrine GTK2 engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215224 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:20 EST --- Well, for me accessing to http://cimi.netsons.org/ gets 404 so currently I cannot check if the source files is valid... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:40 EST --- (In reply to comment #12) Well, even this case, still checking if the file sed command is to be applied is really a text file. As far as I checked, there is one file which is not a text file (./public_html/favicon.ico), against this file sed command should not be used. It may be easily fixed by sedding only the files in lib/ subdirectory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: poker-network - A poker server, client and abstract user interface library Alias: poker-network https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:58 EST --- Spec URL: http://tkmame.retrogames.com/fedora-extras/poker-network.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/poker-network-1.0.33-1.src.rpm %changelog * Thu Jan 11 2007 Christopher Stone [EMAIL PROTECTED] 1.0.33-1 - Upstream sync - Add %%find_lang for new locales -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 13:15 EST --- I forgot to add that the files in public_html/ directory should be listed explicitly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - GTK frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 13:58 EST --- small notes - today´s entry in the changelog still refers to version 0.5.9 - rpmlint gives W: gxine mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 25) for the spec file, so convert the indentation to only one of them -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:01 EST --- Imported, owners.list updated, branches requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222070] Review Request: prewikka - Prelude IDS Management Console
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prewikka - Prelude IDS Management Console
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222070
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:09 EST ---
I have not rebuilt this package, however..
* Requires:
-
Requires: python-abi = .
-
- This is not needed any more because rpmbuild automatically
adds python requirement as Requires: python(abi) = ...
* Bytecompiled python objects .pyc and .pyo files should have 0644
permission.
* At %install stage:
--
rm -rf %{buildroot}/%{python_sitearch}/%{name}/templates/__init__.py
--
Why is this needed?
* Documentation:
-
mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}
mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}/apache
cp -p AUTHORS README NEWS HACKING.README \
%{buildroot}%{_defaultdocdir}/%{name}-%{version}
cp -p doc/apache.conf %{buildroot}%{_defaultdocdir}/%{name}-%{version}/apache/
-
These can be done by:
-
%install
..
mkdir apache
cp -p doc/apache.conf apache/
..
%files
%doc AUTHORS README NEWS HACKING.README
%doc apache/
..
-
By the way, is it really needed to move apache.conf documentation
to apache directory (by creating apache directory)?
* Other dependency
This package requires either libpreludedb-mysql/pgsql/sqlite
package. Also, it seems that prewikka-httpd will not work
only by installing one of them. To use prewikka-httpd some
setting seems still needed.
One solution is that you write a document README.fedora which
explains that prewikka user needs to install either a package
according to what database he/she will use and some settings are
needed according to what installed (at this stage, you can
say the details of settings are on http://..., however,
you must write to the document at least what package user should
install)
By the way, if prewikka-httpd is used only by privileged user,
it should be installed under %{_sbindir}.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 213511] Review Request: gxine - Gnome frontend for the xine multimedia library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - Gnome frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511 [EMAIL PROTECTED] changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:13 EST --- *** This bug has been marked as a duplicate of 222326 *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - GTK frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:13 EST --- *** Bug 213511 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:15 EST --- Can you tell me why (source) I should list public_html files explicitly? I didn't see anything on http://fedoraproject.org/wiki/Packaging/Guidelines about it. I am not saying I won't do it, I just want to know why. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221873] Review Request: cgdb - A curses-based interface to the GNU Debugger (GDB)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cgdb - A curses-based interface to the GNU Debugger (GDB) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221873 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:23 EST --- #8: I've got a couple of other packages that are waiting in the pipe-line - I'll add them ASAP. (and post the BZ# here.) More-ever, I'll start following the review requests and see if I can help. #9: I'll fix the errors and upload nice spec file. Thanks, Gilboa -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - GTK frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:23 EST --- (In reply to comment #1) small notes - today´s entry in the changelog still refers to version 0.5.9 - rpmlint gives W: gxine mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 25) for the spec file, so convert the indentation to only one of them Thanks, fixed. I replaced the old versions with the fixed ones. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222338] New: Review Request: initng-conf-gtk - InitNG configuration and control utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222338 Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com SRPM URL: http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.4-1.src.rpm Description: This is a gtk gui for controlling and configuring InitNG that I'm the author of. There's also a short description and a screenshot at http://www.initng.org/wiki/initng-conf-gtk -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222338 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:24 EST --- Created an attachment (id=145381) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=145381action=view) initng-conf-gtk 0.4-1 spec file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gxine - GTK frontend for the xine multimedia library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:25 EST ---
REVIEW CHECKLIST
- rpmlint output is clean
- package meets package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream (tho as a side note the URL didn't work)
0df37a7a38ea0d63129d2590971caabb /home/josef/gxine-0.5.10.tar.bz2
- package successfully compiles and builds on x86_64 FC6
- all build dependencies listed in BR
- locales handled properly
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by default packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- package contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no .la files
* desktop file is not installed via the appropriate methods
- package does not own files or directories owned by other packages
Things that need to be fixed
* I found the upstream sources, but the URL that was in your spec file did not
resolve, you may want to find a more permament URL.
* You need to install the desktop file appropriatly, look here for an example
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
gxine seems to install it by itself, so you will want to do something like
what I did for geany
http://www.toxicpanda.com/geany.spec
* for gxine-mozplugin, it would not install because you have
Requires: %{name}=%{version}-%{release}
you need to put a space in between the '=', so it looks like this
Requires: %{name} = %{version}-%{release}
and then it will work.
I am not sponsored, this is just a review to help me get sponsored.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:26 EST --- (In reply to comment #15) Can you tell me why (source) I should list public_html files explicitly? I meant that you ought to sed all files in lib/ and explicit list files to sed in public_html. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: polyester - KDE style and window decoration
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:51 EST ---
REVIEW CHECKLIST
* rpmlint output
[EMAIL PROTECTED] SPECS]$
rpmlint /home/josef/redhat/RPMS/x86_64/polyester-1.0-1.x86_64.rpm
E: polyester
binary-or-shlib-defines-rpath /usr/lib64/kde3/kstyle_polyester_config.so
['/usr/lib64']
E: polyester
binary-or-shlib-defines-rpath /usr/lib64/kde3/kwin_polyester_config.so
['/usr/lib64']
E: polyester binary-or-shlib-defines-rpath /usr/lib64/kde3/kwin3_polyester.so
['/usr/lib64']
E: polyester
binary-or-shlib-defines-rpath /usr/lib64/kde3/plugins/styles/polyester.so
['/usr/lib64']
- package meets package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream
12e5f0fa6daeb083621635b410d7c813 polyester-1.0.tar.bz2
- package successfully compiles and builds on x86_64 FC6
- all build dependencies listed in BR
- locales handled properly
- uses ldconfig properly
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by default packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- package contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
* contains .la files (should be OK
http://fedoraproject.org/wiki/PackagingDrafts/LibtoolArchives)
* desktop file is not installed via the appropriate methods
- package does not own files or directories owned by other packages
Things that need to be addressed
* You need to fix the rpmlint errors.
* You do not need the Requires: kdebase, that should be pulled in
automatically
* You need to install the desktop file appropriatly, look here for an example
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
gxine seems to install it by itself, so you will want to do something like
what I did for geany
http://www.toxicpanda.com/geany.spec
I'm not sponsored, this is just a review to help me get sponsored.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:53 EST --- reviewed two review requests with errors bz20 bz222326 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gxine - GTK frontend for the xine multimedia library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:58 EST ---
(In reply to comment #4)
Things that need to be fixed
* I found the upstream sources, but the URL that was in your spec file did
not
resolve, you may want to find a more permament URL.
* You need to install the desktop file appropriatly, look here for an example
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
gxine seems to install it by itself, so you will want to do something like
what I did for geany
http://www.toxicpanda.com/geany.spec
* for gxine-mozplugin, it would not install because you have
Requires: %{name}=%{version}-%{release}
you need to put a space in between the '=', so it looks like this
Requires: %{name} = %{version}-%{release}
and then it will work.
Fixed.
New SPEC: http://feannatar.hostuju.cz/fedora/files/FC6/SPECS/gxine.spec
New SRPM:
http://feannatar.hostuju.cz/fedora/files/FC6/SRPMS/gxine-0.5.10-2.src.rpm
Thanks for pre-review.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:58 EST --- FYI, desktop-file-install is not mandatory. The guidelines only include suggested usage. (I mention this, mostly because I don't think it's use is warranted here). The rpath thing is annoying, especially having been built with ./configure --disable-rpath. ): -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pastebin - A collaborative debugging tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:05 EST ---
Would this be an acceptable way to sed only text files?
for file in `find . -type f`
do
if (file $file | awk -F: '{print $2}' | grep -i text /dev/null) ; then
sed -i 's/\r//g' $file
fi
done
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:07 EST --- (In reply to comment #3) REVIEW CHECKLIST ... * desktop file is not installed via the appropriate methods ... Things that need to be addressed ... * You need to install the desktop file appropriatly, look here for an example http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 Josef, IMO you (and the guidelines) are wrong in this case. Please read the following thread on FE-list: https://www.redhat.com/archives/fedora-extras-list/2006-December/msg00494.html especially https://www.redhat.com/archives/fedora-extras-list/2006-December/msg00495.html and https://www.redhat.com/archives/fedora-extras-list/2006-December/msg00496.html -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222347] New: Review Request: g-wrap - A tool for creating Scheme interfaces to C libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222347
Summary: Review Request: g-wrap - A tool for creating Scheme
interfaces to C libraries
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/notting/review/g-wrap.spec
SRPM URL: http://people.redhat.com/notting/review/g-wrap-1.9.6-8.src.rpm
Description: scheme/C interface library used for GNUCash
Part of reviewing the GNUCash stack for the grand merger.
Only rpmlint complaints I know of is that g-wrap-devel has an include in
/usr/{lib,lib64} - this is intentional as it's wordsize-specific and can't go
in /usr/include.
Latest upstream version is 1.9.7, but as that has caused issues with gnucash,
and gnucash is the only consumer of g-wrap... not updating.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:13 EST --- IMO, The Guidelines aren't wrong, they only say that .desktop files be installed appropriately (though arguably that is too vague for some folks). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222350] New: Review Request: eclipse-cdt - C/C++ Development plugins for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222350 Summary: Review Request: eclipse-cdt - C/C++ Development plugins for Eclipse Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.vermillionskye.com/eclipse-cdt.spec SRPM URL: http://www.vermillionskye.com/eclipse-cdt-3.1.1-6.fc7.src.rpm Description: The eclipse-cdt package bundles the set of Eclipse CDT plugins which are used for C/C++ code development. In addition to the upstream CDT plugins, this project adds the new Autotools plugin from Red Hat which adds support for maintaining C/C++ projects using autotools (e.g. autoconf, automake). This project was formerly shipped in Fedora Core. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:23 EST --- Mhh. Strange. The problem with rpath doesn't exist on x86 and I don't have a machine with x86_64 for testing. But I also don't know how to fix it. --disable-rpath is already set, there seems no local copy of libtool and I am not skilled in editing makefiles. Any suggestions? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:46 EST --- There is a local libtool in the admin subdirectory. You can add the following lines (see http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-7cea8c7aa96400a4687e843156354476434ff883) to the spec file after running configure and before running make. # Don't use rpath! sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool Only check where libtool is created whether in the toplevel source dir or in the admin subdir and set the right path for libtool. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222365] New: Review Request: eclipse-changelog - simplifies the task of maintaining ChangeLogs for projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222365 Summary: Review Request: eclipse-changelog - simplifies the task of maintaining ChangeLogs for projects Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://sourceware.org/eclipse/changelog/eclipse-changelog.spec SRPM URL: http://sourceware.org/eclipse/changelog/eclipse-changelog-2.3.3-3.fc7.src.rpm Description: The ChangeLog plug-in simplifies the task of maintaining ChangeLogs for your projects. It has parsers that work with Java, C/C++, and Python. It currently has one formatter, which formats ChangeLog entries in the GNU Style. You can add your own parsers and formatters by contributing to the extension points defined in the plug-in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218744] Review Request: sofia-sip - SIP user agent library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sofia-sip - SIP user agent library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218744 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 16:04 EST --- Pekka, are you still interested in getting this packaged? If not I can take it over... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222350] Review Request: eclipse-cdt - C/C++ Development plugins for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-cdt - C/C++ Development plugins for Eclipse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222350 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: eclipse-cdt |Review Request: eclipse-cdt |- C/C++ Development plugins |- C/C++ Development plugins |for Eclipse |for Eclipse OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 16:41 EST --- (In reply to comment #6) IMO, The Guidelines aren't wrong, they only say that .desktop files be installed appropriately (though arguably that is too vague for some folks). ATM the guidelines state: Also remember that it is not simply enough to just include the .desktop file in the package, you need to run desktop-file-install in %install -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 16:46 EST --- Oh, my fault. Didn't knowed that I must run %configure to get the libtool-file. Thanks Dan. Next try: SPEC Url: http://www.deadbabylon.de/fedora/extras/polyester/polyester.spec SRPM: Url: http://www.deadbabylon.de/fedora/extras/polyester/polyester-1.0-2.fc6.src.rpm Changelog: - Removed kdebase from Require - fix rpath Because I cannot reproduce the rpath error on x86 someone else must try it on x86_64. Josef? I also think so that desktop-file-install is not needed here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 16:47 EST --- Sigh, ok, I guess we need to work to consolodate all the .desktop file references into one place. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: polyester - KDE style and window decoration
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 16:50 EST ---
More importantly, one should note that the example:
desktop-file-install --vendor= \
--dir=%{buildroot}%{_datadir}/applications/vendor_id \
%{buildroot}/%{_datadir}/applications/vendor_id/foo.desktop
Is (almost) a no-op, other than serving as a sanity-check/validator for the
.desktop file (ie, dfi will barf if it finds something non-compliant).
Now, how to (re)word this to make it clear fdi is not a MUST item, while at the
same time maximizing confusion... (:
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222372] New: Review Request: tilda - a quake like drop down terminal for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222372 Summary: Review Request: tilda - a quake like drop down terminal for GNOME Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.toxicpanda.com/tilda.spec SRPM URL: http://www.toxicpanda.com/tilda-0.9.4-1.src.rpm Description: Tilda is a Linux terminal taking after the likeness of many classic terminals from first person shooter games, Quake, Doom and Half-Life (to name a few), where the terminal has no border and is hidden from the desktop until a key is pressed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222372] Review Request: tilda - a quake like drop down terminal for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tilda - a quake like drop down terminal for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222372 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 17:07 EST --- added a BR for libconfuse-devel which is required for building Spec URL: http://www.toxicpanda.com/tilda.spec SRPM URL: http://www.toxicpanda.com/tilda-0.9.4-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222374] New: Review Request: paprefs - Management tool for PulseAudio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222374 Summary: Review Request: paprefs - Management tool for PulseAudio Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: ftp://ftp.zouric.com/public/paprefs.spec SRPM URL: ftp://ftp.zouric.com/public/paprefs-0.9.5-1.src.rpm Description: PulseAudio Preferences (paprefs) is a simple GTK based configuration dialog for the PulseAudio sound server. This is my first package and I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222372] Review Request: tilda - a quake like drop down terminal for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tilda - a quake like drop down terminal for GNOME
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222372
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 17:23 EST ---
cp {AUTHORS,COPYING,README,ChangeLog,TODO,NEWS}
$RPM_BUILD_ROOT/%{_datadir}/doc/%{name}-%{version}
Instead of that, simply do this
%doc AUTHORS COPYING README ChangeLog TODO NEWS
in the %files section.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221944] Review Request: libofx - A library for supporting Open Financial Exchange (OFX)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libofx - A library for supporting Open Financial Exchange (OFX) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221944 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 17:39 EST --- 0.8.3-3 uploaded - INSTALL, opensp-devel fixed. Tools split off into a 'ofx' package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222374] Review Request: paprefs - Management tool for PulseAudio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: paprefs - Management tool for PulseAudio https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222374 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221947] Review Request: gwenhywfar - utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gwenhywfar - utility library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 17:54 EST --- 2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222220] Review Request: polyester - KDE style and window decoration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 17:55 EST --- Just a note to the conversation about the *.desktop-files: I've tried to avoid packages which requires desktop-file-install in the past because I cannot say I've really understanded this (usage/guidelines/syntax/etc.). :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193898] Review Request: Jython - Java source interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Jython - Java source interpreter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 18:02 EST --- Okay, I've (finally!) taken care of the two issues above. Here's the new spec and SRPM: http://people.redhat.com/overholt/jython.spec http://people.redhat.com/overholt/jython-2.2-0.2.a1.src.rpm Here's a diff from the most recently reviewed spec and the one above: http://people.redhat.com/overholt/jython.spec.patch Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222388] New: Review Request: gnucash - personal finance management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222388 Summary: Review Request: gnucash - personal finance management Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://people.redhat.com/notting/review/gnucash.spec SRPM URL: http://people.redhat.com/notting/review/gnucash-2.0.4-2.fc7.src.rpm Description: GnuCash is a personal finance manager. A check-book like register GUI allows you to enter and track bank accounts, stocks, income and even currency trades. The interface is designed to be simple and easy to use, but is backed with double-entry accounting principles to ensure balanced books. Known rpmlint complaints: - gnucash ships a couple of plugins in libdir - rpmlint thinks the schema files should be %config - I'm pretty sure they're not supposed to be -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219056] Review Request: iscsitarget - iSCSI Enterprise Target
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: iscsitarget - iSCSI Enterprise Target
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219056
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 18:45 EST ---
I look only some things, you should use the rpm directory macros %{_sbindir} and
%{_initrddir}[1] and the command 'ln' must create with '-sf' parameter for a
clean re-install output, you should delete of top the _docdir macro and the
Packager tag should not be used[2].
[1] http://fedoraproject.org/wiki/Extras/RPMMacros
[2] http://fedoraproject.org/wiki/Packaging/Guidelines
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222070] Review Request: prewikka - Prelude IDS Management Console
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prewikka - Prelude IDS Management Console
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222070
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 19:06 EST ---
* removed python-abi requirement
* rm -rf %{buildroot}/%{python_sitearch}/%{name}/templates/__init__.py
this is an empty file, thus is removed it.
* moved apache.conf to %{buildroot}%{_defaultdocdir}/%{name}-%{version}
* created a README.fedora with setup instructions and put it in
%{buildroot}%{_defaultdocdir}/%{name}-%{version}
* moved prewikka-httpd from /usr/bin = /usr/sbin
new package is available here:
http://people.redhat.com/tscherf/fedora-extra/prewikka-0.9.7.1-4.src.rpm
http://people.redhat.com/tscherf/fedora-extra/prewikka.spec
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 19:13 EST --- Spec URL: http://www.stahnkage.com/rpms/pastebin.spec SRPM URL: http://www.stahnkage.com/rpms/pastebin-0.50-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219930] Review Request: lxpanel - A lightweight X11 desktop panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lxpanel - A lightweight X11 desktop panel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219930 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 20:44 EST --- One thine you may need to know: the lxde author says he will no more develop and maintain these programs So there is no NEXT version of lxde. That is one reason why I don't want to maintain any of lxde packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220969] Review Request: isomaster - an easy to use GUI CD image editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: isomaster - an easy to use GUI CD image editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 20:45 EST --- GLOBALFLAGS += flags-speciied-for-program That's okay. The Makefile is very simple and hardcoded. Alternatively, it could use $(CFLAGS) in the same way that it's possible to override it from the outside. That works with most projects. %clean Maybe in mock. In my local, custom build directory remains. rpmbuild --clean ... ;-) Then look at the end of the build output. Btw, I prefer rpmbuild over mock. Btw, project compiled with OPTFLAGS is over 10% larger than the previous one. Is this normal? Increase in size is normal and due to options like -fasynchronous-unwind-tables. Whether it's 10% or more or less, I don't know. :) $ rpm --eval %optflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] New: Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions Product: Fedora Core Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.redhat.com/mclasen/ConsoleKit/ConsoleKit.spec SRPM URL: http://people.redhat.com/mclasen/ConsoleKit/ConsoleKit-0.1.0-1.src.rpm Description: ConsoleKit is a system daemon for tracking seats and sessions. It provides asynchronous notification via the system message bus. ConsoleKit is a central part of the effort to make fast user switching work well for FC7. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:19 EST --- I should have mentioned that still needs to go in core, since gdm will depend on it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|188265 |188267 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:23 EST --- the description is a little terse. the words seats and sessions have a specific undefined meaning for instance. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:25 EST --- in the last package i reviewed you said you didn't think having specific version for the build requires was a good idea. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:26 EST --- If the tarball name is console-kit, why are we calling the package ConsoleKit ? why are we specifically passing -n to %setup? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:29 EST --- you need a Requires(preun): service i think -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:37 EST --- do we really want to be shipping a binary that upstream explicitly made noinst? and giving it our own name nontheless? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:39 EST --- The init scripts have bogus priority numbers. why is it getting started so late? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 23:41 EST --- Re comment 2, from the README: What is a seat? 8 === 9 10 A seat is a collection of sessions and a set of hardware (usually at 11 least a keyboard and mouse). Only one session may be active on a 12 seat at a time. 13 14 What is a session? 15 == 16 17 A session is a collection of all processes that originate from a single 18 common ancestor and retain knowledge of a secret. As an implementation 19 detail, this secret may be stored in the process environment by the 20 login manager under the name XDG_SESSION_COOKIE. That reminds me that I should include the README ChangeLog, etc in the rpm Re comment 3: True. This spec was stolen from davidz... Re comment 4: I don't know. This is the way William Jon McCann shipped it. The project itself is clearly called ConsoleKit (see e.g. the README), but the tarball is named console-kit. David decided to go with the project name for the rpm, which is explicitly allowed by the package naming guidelines. Re comment 5: /sbin/service is part of initscripts, which is on the exceptions list. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 00:13 EST --- Well, its currently started at the same time as hal and NetworkManager... Do we really want to deviate from upstream for that, without a concrete problem that would be solved by starting it earlier ? Updated: Spec URL: http://people.redhat.com/mclasen/ConsoleKit/ConsoleKit.spec SRPM URL: http://people.redhat.com/mclasen/ConsoleKit/ConsoleKit-0.1.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|188267 |188268 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 00:18 EST --- We should fix the description to say what consolekit does in primitive terms. But with that change and assuming this passes rpmlint and succeeds in mock, it seems like it's good to go. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222388] Review Request: gnucash - personal finance management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnucash - personal finance management https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222388 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 00:58 EST --- Obviously, because once you install it, you will never ever want to uninstall it, evar. Or, I screwed up. Fixed uploaded. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 01:00 EST --- * Commands under paths only used by previledged users (like /sbin/service) must be written with full path in scriptlets. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222404] Review Request: ConsoleKit - System daemon for tracking seats and sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ConsoleKit - System daemon for tracking seats and sessions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222404 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 01:11 EST --- We should probably require dbus explicitly, for the /etc/dbus-1/system.d directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205755] Review Request: elsa - manages group of processes and allows accounting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: elsa - manages group of processes and allows accounting https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205755 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 01:42 EST --- Yes I have access, thanks Josh. Thank you very much everybody for your help. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221947] Review Request: gwenhywfar - utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gwenhywfar - utility library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 01:52 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPMS. E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. But its ok as it looks mis-error by rpmlint. + source files match upstream. 0f7cf7d0efa6719f85c00d6d8ccec2b3 gwenhywfar-2.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code Not contents. + no static libraries present. + no gwenhywfar.pc files present. + -devel subpackage exists + included %post -p /sbin/ldconfig %postun -p /sbin/ldconfig + no .la files. + translations are available + Dose owns the directories it creates. + no duplicates in %files. + no scriptlets used. + file permissions are appropriate. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
