[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477854 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Fabian Affolter fab...@bernewireless.net 2008-12-27 03:50:45 EDT --- New Package CVS Request === Package Name: yersinia Short Description: Network protocols tester and attacker Owners: fab Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478290] New: Review Request: screenie - A small and lightweight screen wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: screenie - A small and lightweight screen wrapper https://bugzilla.redhat.com/show_bug.cgi?id=478290 Summary: Review Request: screenie - A small and lightweight screen wrapper Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/screenie.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/screenie-1.30.0-1.fc9.src.rpm Description: Screenie is a small and lightweight screen wrapper that is designed to be a session handler that simplifies the process of administrating detached jobs by providing an interactive menu. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1022715 rpmlint output: [...@laptop024 noarch]$ rpmlint screenie-1.30.0-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint screenie-1.30.0-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455165] Review-Request: maatkit - Essential command-line utilities for MySQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455165 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Lubomir Rintel lkund...@v3.sk 2008-12-27 05:39:20 EDT --- Imported and built. Thanks for review and CVS! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478291] New: Review Request: shtool - Portable shell tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: shtool - Portable shell tool https://bugzilla.redhat.com/show_bug.cgi?id=478291 Summary: Review Request: shtool - Portable shell tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/shtool.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/shtool-2.0.8-1.fc9.src.rpm Project URL: http://www.gnu.org/software/shtool/ Description: GNU shtool is a compilation of small but very stable and portable shell scripts into a single shell tool. All ingredients were in successful use over many years in various free software projects. The compiled shtool program is intended to be used inside the source tree of other free software packages. There it can overtake various (usually non-portable) tasks related to the building and installation of such a package. It especially can replace the old mkdir.sh, install.sh and related scripts. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1022748 rpmlint output: [...@laptop024 noarch]$ rpmlint shtool-2.0.8-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint shtool-2.0.8-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471145] Review Request: procinfo-ng - System monitoring application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471145
--- Comment #5 from Fabian Affolter fab...@bernewireless.net 2008-12-27
06:32:08 EDT ---
Michael, thanks for your inputs.
(In reply to comment #3)
g++ -O0 -g3 --pipe -Wall -lncurses procinfo.cpp -o procinfo
It ignores our global %{optflags}, also influenced by switching on
--enable-maintainer-mode. You want to make it accept $CFLAGS (as it doesn't
use
$CXXFLAGS for C++) and make sure that $LDFLAGS does not include -s (to avoid
stripping the binaries as that would make the debuginfo pkg useless).
fixed
/usr/bin/procinfo-ng
It builds just this executable (renamed from procinfo) and therefore is not
suitable as a direct replacement of the procinfo package, which includes
lsdev and socklist.
It is NOT options-compatible with the procinfo pkg either.
It conflicts with package procinfo in the manual page file, which you forgot
to rename to procinfo-ng.8
I renamed the man page now. It's the same man page as in procinfo as far as I
can see. lsdev and socklist are missing in procinfo-ng.
(In reply to comment #4)
Summary:System monitoring application
It's text-based (ncurses), which is special enough to mention that. Else a
summary like this is misleading, since most users will expect a modern desktop
GUI application that adds a menu entry, too.
Changed
Here are the new files
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/procinfo-ng.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/procinfo-ng-2.0.217-2.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 224245] Merge Review: squirrelmail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=224245 --- Comment #18 from Michal Hlavinka mhlav...@redhat.com 2008-12-27 06:55:08 EDT --- I'll look at this soon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477958] Review Request: id3mtag - Command line mass ID3 tagging utility for audio files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477958
--- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-27
06:57:56 EDT ---
The rpmlint output...
[...@laptop024 i386]$ rpmlint id3mtag*
id3mtag.i386: W: invalid-license Two-clause BSD
id3mtag-debuginfo.i386: E: empty-debuginfo-package
id3mtag-debuginfo.i386: W: invalid-license Two-clause BSD
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
[...@laptop024 SRPMS]$ rpmlint id3mtag-0.78-1.fc9.src.rpm
id3mtag.src: W: invalid-license Two-clause BSD
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
For more details check https://fedoraproject.org/wiki/Licensing
Some comments on your spec file
- CHANGES, COPYING, and so on should be placed in the %files section
%doc CHANGES COPYING
%doc %{_docdir}/%{name} looks a bit unusual
- Don't mix $RPM_BUILD_ROOT and %{buildroot}
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- Is 'Prefix: %{_usr}' really needed?
https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages
- Remove the 'fc9' in the changelog entry '...com - 0.78-1'
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
- %{?_smp_mflags} and %{optflags} are not honored in the %build section
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] New: Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: fswebcam - Tiny and flexible webcam program https://bugzilla.redhat.com/show_bug.cgi?id=478294 Summary: Review Request: fswebcam - Tiny and flexible webcam program Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/fswebcam.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/fswebcam-20070108-3.fc9.src.rpm Project URL: http://www.firestorm.cx/fswebcam/ Description: A tiny and flexible webcam program for capturing images from a V4L1/V4L2 device, and overlaying a caption or image. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1022775 rpmlint output: [...@laptop024 i386]$ rpmlint fswebcam* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint fswebcam-20070108-3.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. This review request based on https://bugzilla.redhat.com/show_bug.cgi?id=222009 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||p...@sanslogic.co.uk --- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-27 07:29:27 EDT --- *** Bug 222009 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222009] Review Request: fswebcam - Small webcam app
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=222009 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Resolution|WONTFIX |DUPLICATE --- Comment #10 from Fabian Affolter fab...@bernewireless.net 2008-12-27 07:29:27 EDT --- *** This bug has been marked as a duplicate of 478294 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Comment #12 from Terje Røsten terje...@phys.ntnu.no 2008-12-27 08:12:22 EDT --- Please make a cvs request: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477839] Review Request: libxfce4menu - A freedesktop.org compliant menu implementation for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477839 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2008-12-27 08:15:15 EDT --- Good work, this package is simply perfect: * Spec file sane and legible * Compiler flags used appropriately * RPMlint silent * Builds in mock fine (fedora-devel-i386 with recent libxfce4util) * Requires/provides are sane * Filelists for main package and -devel sane * License correct APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478294
manuel wolfshant wo...@nobugconsulting.ro changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
Flag||fedora-review+
--- Comment #2 from manuel wolfshant wo...@nobugconsulting.ro 2008-12-27
08:28:38 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:GPLv2
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package match the upstream source, as provided
in the spec URL.
SHA1SUM of package: 69df690a91dd5902b5fe3d6b5c6a140fe242f002
fswebcam-20070108.tar.gz
[x] Package is not known to require ExcludeArch.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Final provides and requires are sane.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64 + koji scratch build
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: koji scratch build
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[-] %check is present and the test passes.
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2008-12-27 09:04:35 EDT --- (In reply to comment #0) Note: this package is part of the upcoming Xfce 4.6. You will need: Apart from the packages you enumerated that were found in xfce4-settings [1] directory, I've also grabbed xfconf [2], since a couple of packages demanded it. [1] http://www.scrye.com/~kevin/fedora/xfce4-settings/ [2] http://www.scrye.com/~kevin/fedora/xfconf/ * RPMlint is silent and happy * Spec file is mostly sane and legible * Compiler flags are used appropriately * Builds find in mock, with additional repository of xfce packages * Requires, provides and filelists are sane * License is correct A few notes: 1.) Please don't do --vendor ; in case upstream specifies vendor field, do not reset it, otherwise set it to fedora https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation 2.) Please ensure the following is correct: Build Configuration: * Installation prefix: /usr * Debug Support: minimum * Libnotify support: no * Xcursor support: yes * Sounds settings supportno * Libxklavier support: no Did you really mean to build w/o support for the above? 3.) The following line seems useless: find $RPM_BUILD_ROOT -name '*.desktop' -ls I guest it was forgotten there. Please remove it. I don't think any of the above would warrant a review blocker: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 --- Comment #1 from David Timms dti...@iinet.net.au 2008-12-27 09:23:36 EDT --- Koji scratch build result (success): http://koji.fedoraproject.org/koji/taskinfo?taskID=1022934 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476530] Review Request: projxp - Agile project management server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476530 --- Comment #2 from Darryl L. Pierce dpie...@redhat.com 2008-12-27 09:43:17 EDT --- Updated release is available: Spec URL: http://mcpierce.fedorapeople.org/rpms/projxp.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/projxp-0.1.1-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478294] Review Request: fswebcam - Tiny and flexible webcam program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478294 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Fabian Affolter fab...@bernewireless.net 2008-12-27 09:47:54 EDT --- New Package CVS Request === Package Name: fswebcam Short Description: Tiny and flexible webcam program Owners: fab Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478300] New: Review Request: python-wifi - Python binding for the wireless extensions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-wifi - Python binding for the wireless extensions https://bugzilla.redhat.com/show_bug.cgi?id=478300 Summary: Review Request: python-wifi - Python binding for the wireless extensions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi-0.3.1-1.fc9.src.rpm Project URL: https://developer.berlios.de/projects/pythonwifi/ Description: Python-Wifi is a Python library that provides access to information about a W-LAN card's capabilities, like the wireless extensions written in C. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1023011 rpmlint output: [...@laptop024 noarch]$ rpmlint python-wifi-0.3.1-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop024 SRPMS]$ rpmlint python-wifi-0.3.1-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456684] Review Request: pathfinder - X.509 Path Discovery and Validation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456684 --- Comment #4 from Konstantin Ryabitsev mri...@gmail.com 2008-12-27 13:28:05 EDT --- Still waiting for a new upstream release. http://code.google.com/p/pathfinder-pki/issues/detail?id=16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474827] Review Request: xteddy - Tool to sit around silently, look cute, and make you smile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474827 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2008-12-27 14:10:58 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d33bfe05f18259a3f7fd17ae256c5644 xteddy-2.0.1.tar.gz d33bfe05f18259a3f7fd17ae256c5644 xteddy-2.0.1.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install See below - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Might include: xteddy.README xtuxxy.credit as doc files? 2. Agreed on your reasoning for no desktop file... older x apps like xeyes are in the same boat I think. Perhaps if upstream is still alive you could suggest them making a launcher that comes up and lets people choose options? I don't see any further blockers here, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 --- Comment #2 from Jason Tibbitts ti...@math.uh.edu 2008-12-27 14:28:03 EDT --- Vmware should supply this, not Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455164] Review-Request: NaturalDocs - Documentation generator for multiple programming languages
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455164
Kevin Fenzi ke...@tummy.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Kevin Fenzi ke...@tummy.com 2008-12-27 15:18:37 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
05a9a2a392bd3d6d44d1576e624ba74a NaturalDocs-1.4.zip
05a9a2a392bd3d6d44d1576e624ba74a NaturalDocs-1.4.zip.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
Issues:
1. It looks pretty clear that the package is GPLv2+, but some of the files just
say
the GPL. You might ping upstream about that and suggest they mention that
it's v2 or
later.
2. Might use 'install -p' to preserve the timestamp on the script.
3. SourceUrl is not right... looks like they use naturaldocs instead of
NaturalDocs
in there.
Ie:
http://downloads.sourceforge.net/naturaldocs/%{name}-%{version}.zip
None of those are blockers, so this package is APPROVED, provided you
fix those up on import.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471754
--- Comment #6 from Brennan Ashton bash...@brennanashton.com 2008-12-27
16:19:08 EDT ---
[x]source files match upstream:
b7942cb1b57897119062f6ff7a30c970b754e7d2728297a32228b02272785695
virtaal-0.2.tar.bz2
[x]package meets naming and versioning guidelines.
[FAIL]specfile is properly named, is cleanly written and uses macros
consistently.
The spec file should not have the version or at least not the revision number
as part of its name, it should be virtaal.spec
[x]dist tag is present.
[x]build root is correct.
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x]license field matches the actual license.
[x]license is open source-compatible.
GPLv2+
[x]license text included in package.
[x]latest version is being packaged.
[FAIL]BuildRequires are proper.
You should not have desktop-file-utils see:
http://fedoraproject.org/wiki/NewMIMESystem
[x]compiler flags are appropriate.
[x]%clean is present.
[x]package builds in mock.
package installs properly.
[FAIL]rpmlint is silent.
rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm
../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm
virtaal.src: E: invalid-spec-name
Rename Spec file
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/recent.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/about.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/markup.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/document.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/formats.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/tips.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/terminology.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/main_window.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_model.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/modes.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__version__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/rendering.py 0644
2 packages and 1 specfiles checked; 36
[Bug 477953] Review Request: podcatcher - Armangil's podcast client for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477953 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net --- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-27 16:23:36 EDT --- Just some comments on your spec file - 'Source0:' should point to the upstream tarball if possible. - Please preserve the time stamp in the %install section - Shouldn't '%doc demo' be '%doc demo/' ? - Replace '/usr/bin/' with a macro https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros rpmlint is not quite... [...@laptop024 SRPMS]$ rpmlint podcatcher-3.1.4-1.fc10.src.rpm podcatcher.src: E: no-cleaning-of-buildroot %install podcatcher.src: W: more-than-one-%changelog-section podcatcher.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 16) 1 packages and 0 specfiles checked; 1 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478316] New: Review Request: Farsight2 - GStreamer libraries for videoconferencing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Farsight2 - GStreamer libraries for videoconferencing https://bugzilla.redhat.com/show_bug.cgi?id=478316 Summary: Review Request: Farsight2 - GStreamer libraries for videoconferencing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bdpep...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://bpepple.fedorapeople.org/rpms/farsight2.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/farsight2-0.0.6-1.fc10.src.rpm Description: Farsight2 is a collection of GStreamer modules and libraries for videoconferencing. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1023264 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477953] Review Request: podcatcher - Armangil's podcast client for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477953 --- Comment #2 from Christof Damian chris...@damian.net 2008-12-27 16:58:40 EDT --- (In reply to comment #1) Just some comments on your spec file - 'Source0:' should point to the upstream tarball if possible. fixed, though the URL has to be looked up again on every release because it contains some release id - Please preserve the time stamp in the %install section fixed - Shouldn't '%doc demo' be '%doc demo/' ? I changed it. I didn't realize that it makes a difference, but it is easier readable. - Replace '/usr/bin/' with a macro https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros OK. rpmlint is not quite... [...@laptop024 SRPMS]$ rpmlint podcatcher-3.1.4-1.fc10.src.rpm podcatcher.src: E: no-cleaning-of-buildroot %install podcatcher.src: W: more-than-one-%changelog-section podcatcher.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 16) 1 packages and 0 specfiles checked; 1 errors, 2 warnings. those are now fixed too. I have uploaded the new files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #11 from Tim Fenn f...@stanford.edu 2008-12-27 17:04:55 EDT --- update to 0.5.2, fixed most rpmlint errors (most of the rest require significant changes to upstream package, will discuss with upstream): Spec URL: http://www.stanford.edu/~fenn/packs/coot.spec SRPM URL: http://www.stanford.edu/~fenn/packs/coot-0.5.2-1.fc10.src.rpm need some info re. if its OK to progress with the existing rpmlint issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476536
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-27
17:27:46 EDT ---
Just some comments on your spec file
- The echo call in the %prep section is a bit unusual
- The license is not GPLv2, it's GPLv2+ according to the header in the source
file
- One line per BR would be nice
- There is no need for '\' in the description
- From my point of view, there is no need for 'chmod 755
%{buildroot}%{_bindir}/%{name}'
The guidelines says that the BuildRequires for python packages should be
'BuildRequires: python' and the egg stuff 'BuildRequires:
python-setuptools-devel'
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 --- Comment #3 from David Timms dti...@iinet.net.au 2008-12-27 17:32:36 EDT --- Agreed, but I think they never will. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] New: Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with https://bugzilla.redhat.com/show_bug.cgi?id=478318 Summary: Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jonstan...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora SRPM URL: http://jstanley.fedorapeople.org/trac-privateticketsplugin-1.1.1-0.1.svn5068.el5.src.rpm Spec URL: http://jstanley.fedorapeople.org/trac-privateticketsplugin.spec Description: A trac plugin to allow users to see only tickets that they are involved with. [jstan...@rugrat SPECS]$ rpmlint trac-privateticketsplugin.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [jstan...@rugrat SPECS]$ rpmlint ../SRPMS/trac-privateticketsplugin-1.1.1-0.1.svn5068.el5.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [jstan...@rugrat SPECS]$ rpmlint ../RPMS/trac-privateticketsplugin-1.1.1-0.1.svn5068.el5.noarch.rpm trac-privateticketsplugin.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [jstan...@rugrat SPECS]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474827] Review Request: xteddy - Tool to sit around silently, look cute, and make you smile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474827 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Lubomir Rintel lkund...@v3.sk 2008-12-27 17:45:48 EDT --- Thanks for the review! (In reply to comment #6) Issues: 1. Might include: xteddy.README xtuxxy.credit as doc files? Yup, will do on import. 2. Agreed on your reasoning for no desktop file... older x apps like xeyes are in the same boat I think. Perhaps if upstream is still alive you could suggest them making a launcher that comes up and lets people choose options? Upstream is still alive, but I guess it will oppose the idea of launcher, since it would at least double the complexity of the package, and at least I strongly oppose it, for the reasons described above. New Package CVS Request === Package Name: xteddy Short Description: Tool to sit around silently, look cute, and make you smile Owners: lkundrak Branches: F-10 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455164] Review-Request: NaturalDocs - Documentation generator for multiple programming languages
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455164
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
Flag||fedora-cvs?
--- Comment #3 from Lubomir Rintel lkund...@v3.sk 2008-12-27 17:46:34 EDT ---
Issues:
1. It looks pretty clear that the package is GPLv2+, but some of the files
just
say
the GPL. You might ping upstream about that and suggest they mention that
it's v2 or
later.
2. Might use 'install -p' to preserve the timestamp on the script.
3. SourceUrl is not right... looks like they use naturaldocs instead of
NaturalDocs
in there.
Ie:
http://downloads.sourceforge.net/naturaldocs/%{name}-%{version}.zip
None of those are blockers, so this package is APPROVED, provided you
fix those up on import.
All three are reasonable and I will surely address them. Thanks for the review!
New Package CVS Request
===
Package Name: NaturalDocs
Short Description: Documentation generator for multiple programming languages
Owners: lkundrak
Branches: F-9 F-10 EL-5
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 Clint Savage her...@gmail.com changed: What|Removed |Added CC||her...@gmail.com AssignedTo|nob...@fedoraproject.org|her...@gmail.com --- Comment #1 from Clint Savage her...@gmail.com 2008-12-27 18:08:11 EDT --- reviewing this package at Jon's request -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453395] Review Request: libmapi - OpenChange: Microsoft Exchange access with native protocols
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453395 --- Comment #13 from Matthew Barnes mbar...@redhat.com 2008-12-27 19:10:12 EDT --- Updated to a more recent SVN revision. http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-0.6.svn949.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: python-oasa - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 --- Comment #17 from Jesse Keating jkeat...@redhat.com 2008-12-27 19:51:05 EDT --- Please don't add me to initial CC. I'm not interested in getting bugzilla mail for this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477839] Review Request: libxfce4menu - A freedesktop.org compliant menu implementation for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477839 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Kevin Fenzi ke...@tummy.com 2008-12-27 20:16:00 EDT --- Thanks for the quick review! New Package CVS Request === Package Name: libxfce4menu Short Description: A freedesktop.org compliant menu implementation for Xfce Owners: kevin Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added Status|NEW |CLOSED CC||ita...@ispbrasil.com.br Resolution||NOTABUG --- Comment #4 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2008-12-27 20:37:46 EDT --- (In reply to comment #3) why you don't fire your efforts in direction of open source programs, like KVM, xen or QEMU ? vmware is not opensource and your contribution can't be accepted. please take a look. https://fedoraproject.org/wiki/ForbiddenItems#VMware I am also agree with Jason Tibbitts Vmware should supply this, not Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Kevin Fenzi ke...@tummy.com 2008-12-27 20:47:37 EDT --- 1.) Please don't do --vendor ; in case upstream specifies vendor field, do not reset it, otherwise set it to fedora https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation Good catch. Fixed to use fedora as vendor (upstream doesn't have one by default) 2.) Please ensure the following is correct: Build Configuration: * Installation prefix: /usr * Debug Support: minimum * Libnotify support: no * Xcursor support: yes * Sounds settings supportno * Libxklavier support: no Did you really mean to build w/o support for the above? Nope. Thanks for spotting those. Added some buildrequires to pick them up. 3.) The following line seems useless: find $RPM_BUILD_ROOT -name '*.desktop' -ls I guest it was forgotten there. Please remove it. Well, it's needed because the make install installs the desktop files, and I then install them again with desktop-file-install. I can just use --delete-original instead. I will switch to that. I don't think any of the above would warrant a review blocker: APPROVED Thanks! FYI, new package: Spec URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings.spec SRPM URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings-4.5.92-2.fc11.src.rpm CVS request: New Package CVS Request === Package Name: xfce4-settings Short Description: Settings Manager for Xfce Owners: kevin Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 David Timms dti...@iinet.net.au changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|NOTABUG | --- Comment #5 from David Timms dti...@iinet.net.au 2008-12-27 21:26:20 EDT --- (In reply to comment #4) why you don't fire your efforts in direction of open source programs, like KVM, xen or QEMU ? USing Fedora gives users like me the advantages of Fedora and the capability to contribute to the Fedora Project, but virtualization gives me what they may require for the machine to be a useful (winxp) in the real employment world. vmware is not opensource Correct. and your contribution can't be accepted. I believe this to be incorrect. Please point to the section of the guidelines that would exclude this meta package. please take a look. I have. Did you notice that this request for review is a meta-package only. It does not require any non-open source packages, nor any packages outside of the Fedora world. At all. I understand that there will be many who don't support the out of Fedora applications, that this this will make easier to use, but I am yet to see anything that would stop this package actually being acceptable to Fedora, and am hence re-opening. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 David Timms dti...@iinet.net.au changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477866] Review Request: perl-Hardware-Verilog-Parser - Complete grammar for parsing Verilog code using perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477866 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:30:16 EDT --- New Package CVS Request === Package Name: perl-Hardware-Verilog-Parser Short Description: Complete grammar for parsing Verilog code using perl Owner: chitlesh Branches: F-9 F-10 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477871] Review Request: perl-ModelSim-List - Analyse the 'list' output of the ModelSim simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477871 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477867] Review Request: perl-Perlilog - Verilog environment and IP core handling in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477867 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:32:25 EDT --- New Package CVS Request === Package Name: perl-Perlilog Short Description: Verilog environment and IP core handling in Perl Owner: chitlesh Branches: F-9 F-10 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477871] Review Request: perl-ModelSim-List - Analyse the 'list' output of the ModelSim simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477871 --- Comment #2 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:34:41 EDT --- New Package CVS Request === Package Name: perl-ModelSim-List - Short Description: Analyse the 'list' output of the ModelSim simulator Owner: chitlesh Branches: F-9 F-10 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 223591] Review Request: Magic - A very capable VLSI layout tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=223591 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #26 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:54:25 EDT --- Package Change Request === Package Name: magic Short Description: A very capable VLSI layout tool Owners: chitlesh Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226725] Review Request: netgen - LVS netlist comparison tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226725 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #51 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:52:42 EDT --- Package Change Request === Package Name: netgen Short Description: LVS netlist comparison tool Owners: chitlesh Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226715] Review Request: irsim - Switch-level simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226715 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226715] Review Request: irsim - Switch-level simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226715 --- Comment #22 from Chitlesh GOORAH cgoo...@yahoo.com.au 2008-12-27 21:53:22 EDT --- Package Change Request === Package Name: irsim Short Description: Switch-level simulator Owners: chitlesh Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478007 --- Comment #6 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2008-12-27 22:06:49 EDT --- (In reply to comment #5) USing Fedora gives users like me the advantages of Fedora and the capability to contribute to the Fedora Project, but virtualization gives me what they may require for the machine to be a useful (winxp) in the real employment world. I am using kvm to virtualize window$ at the ratio of 20:1, with extreme performance. in real employment world we use xen/kvm/qemu, have you tried one of these ? If you want to leave this ticket open then go ahead, I am curious to see what other developers think about this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #2 from David Nalley da...@gnsa.us 2008-12-28 01:18:26 EDT --- Fabian - I believe I have addressed all of your comments you can find the new spec and srpm files here: http://ke4qqq.fedorapeople.org/zapplet-0.1-2.src.rpm http://ke4qqq.fedorapeople.org/zapplet.spec Thanks for taking the time to review the package! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 Clint Savage her...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review+ --- Comment #2 from Clint Savage her...@gmail.com 2008-12-28 01:24:16 EDT --- Grammar on the %description is odd, should be improved. Apparently, that's the way the authors wrote the description. Builds fine. rpmlint trac-privateticketsplugin.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint trac-privateticketsplugin-1.1.1-0.2.svn5068.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Looks good to me, other than my caveat of poor grammar by the creator. I say it's a go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478318] Review Request: trac-privateticketsplugin - allow users to see only tickets they are involved with
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478318 Jon Stanley jonstan...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Jon Stanley jonstan...@gmail.com 2008-12-28 01:30:33 EDT --- New Package CVS Request === Package Name: trac-privateticketsplugin Short Description: Trac extension to allow users to view only related tickets Owners: jstanley Branches: EL-5 F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
