[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:45:24 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488108] Review Request: django-tagging - A generic tagging application for Django projects

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488108


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:44:18 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 477570] Review Request: couchdb - A document database server, accessible via a RESTful JSON API

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477570


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:48:38 EDT ---
sorry about that. Try now?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481751] Review Request: fence-agents - Fence Agents for Red Hat Cluster

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481751


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #16 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:49:16 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487312] Review Request: tuned - A dynamic adaptive system tuning daemon

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487312


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457060] Review Request: wordpress-mu - Multi-user variant of WordPress

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457060


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #19 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:49:52 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481731] Review Request: resource-agents - Open Source HA Resource Agents for Red Hat Cluster

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481731


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #13 from Kevin Fenzi ke...@tummy.com  2009-03-03 15:51:38 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488347] Review Request: kdepim3 - Compatibility support for kdepim3

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488347


John Poelstra poels...@redhat.com changed:

   What|Removed |Added

 CC||poels...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475852] Review Request: gnustep-base - GNUstep Base library package

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475852





--- Comment #11 from Scott Christley schrist...@mac.com  2009-03-03 16:35:22 
EDT ---
I think it is reasonable to switch to libffi.  It use to be that libffi was not
well supported on some platforms and missing functionality, but I think it has
caught up.  Especially if GNUstep is now recommending a version that works, we
should go with that.  Think you can use the --enable-libffi and
--disable-ffcall flags to configure to force usage, but it seems GNUstep should
automatically pick libffi first if it finds it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488333] Review Request: nmh - the MH mail handling system

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488333


James Ralston rals...@pobox.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||CURRENTRELEASE




--- Comment #2 from James Ralston rals...@pobox.com  2009-03-03 16:35:06 EDT 
---
Thanks; closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488035


Adam Tkac at...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488359] New: Review Request: dcbd - daemon and configuration tool for data center bridging

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: dcbd - daemon and configuration tool for data center 
bridging

https://bugzilla.redhat.com/show_bug.cgi?id=488359

   Summary: Review Request: dcbd - daemon and configuration tool
for data center bridging
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: agosp...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://people.redhat.com/agospoda/dcbd/dcbd.spec
SRPM URL: http://people.redhat.com/agospoda/dcbd/dcbd-0.9.7-1.fc10.src.rpm
Description: 

This package contains the Linux user space daemon and configuration tool for
Intel Enhanced Ethernet for the Data Center software.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475852] Review Request: gnustep-base - GNUstep Base library package

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475852


Michel Alexandre Salim michel.syl...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|michel.syl...@gmail.com
   Flag||fedora-review?




--- Comment #12 from Michel Alexandre Salim michel.syl...@gmail.com  
2009-03-03 16:58:38 EDT ---
There's probably no need to use --disable-ffcall explicitly. If the build req
is updated to libffi-devel, since we're building on Koji, ffcall won't even be
installed into the chroot used for building.

Nobody seems to be in charge of this review yet, so I'll assign it to myself;
Scott will be doing the pre-review on the way to getting sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485420] Review Request: openbios - Open Source implementation of IEEE 1275-1994

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485420





--- Comment #9 from Peter Lemenkov lemen...@gmail.com  2009-03-03 16:57:19 
EDT ---
From my PoV it;s still look ugly - I don't think that it's easy to understand
that all these tricks with exactarch/noarch for w/o comments. In other words, I
think that this package is not legible enough. However, keeping in mind that we
really need this package in order to clean up mess with pre-built blobs in qemu
here is my 

REVIEW:

- rpmlint is not silent (checked on ppc):

openbios.src:137: E: files-attr-not-set
openbios.src:138: E: files-attr-not-set
openbios.src:139: E: files-attr-not-set
openbios.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 10)
openbios.src: W: summary-ended-with-dot OpenBios implementation of IEEE
1275-1994.
openbios.src: E: description-line-too-long features, Open Firmware provides an
instruction set independent device interface.
openbios-debuginfo.ppc: E: empty-debuginfo-package
openbios-ppc.noarch: W: no-documentation
openbios-ppc.noarch: E: arch-independent-package-contains-binary-or-object
/usr/share/openbios/openbios-ppc
4 packages and 0 specfiles checked; 6 errors, 3 warnings.

+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+/- The package meets the Packaging Guidelines. I've got only one complain
about explicit installation of docs in %install section. I't enogh just to list
them as %doc
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
- The spec file for the package is not legible enough (see messages above).
unfortunately, I don't think that this can be easily fixed, because this
situation is relatively complex (different parts of this package should be
built on different arches).

- The sources used to build the package must match the upstream source, as
provided in the spec URL. Unfortunately, I failed to download sources using the
following address (taken from spec-file):

http://downloads.sourceforge.net/openbios/openbios-1.0.tar.gz

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture (see koji ogs above)
+ All build dependencies are listed in BuildRequires.

- The package must own all directories that it creates. Unfortunately, I can't
find that sub-package owns %{_datadir}/openbios

+ A package does not contain any duplicate files in the %files listing.

- Permissions on files must be set properly. See rpmlint warnings above.
+ The package has a %clean section.
+ The package consistently uses macros.
+ The package contains code, or permissable content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Please, fix issues, mentioned above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488285] Review Request: txt2man - Convert flat ASCII text to man page format

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488285


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484598] Review Request: grin - Grep-like tool for source code

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484598


Terje Røsten terje...@phys.ntnu.no changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #6 from Terje Røsten terje...@phys.ntnu.no  2009-03-03 17:03:10 
EDT ---
Imported, built and pushed to bodhi.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459211] Review Request: oolite - A space sim game, inspired by Elite

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459211





--- Comment #5 from manuel wolfshant wo...@nobugconsulting.ro  2009-03-03 
17:25:32 EDT ---
eh, my interest in gnustep is null, what I care for is to revive my Elite
memories since the C64 era :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483615] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483615





--- Comment #17 from Suravee Suthikulpanit suravee.suthikulpa...@amd.com  
2009-03-03 17:30:51 EDT ---
Parag,

Thank you for your time. I also found some useful tips in the Packaging Note on
you wiki page.  One of them is using the $DESTDIR to specify the
$RPM_BUILD_ROOT during installation.  Therefore, I am making some changes since
this is much cleaner than the code in revision 3. I hope this would not
interrupting your review.

I have posted the new SRPM and spec files here:

Spec URL:
http://ftp-developer.amd.com/user/ssuthiku/CodeAnalyst-gui-2.8.38-4.fc11/CodeAnalyst-gui.spec

SRPM URL:
http://ftp-developer.amd.com/user/ssuthiku/CodeAnalyst-gui-2.8.38-4.fc11/CodeAnalyst-gui-2.8.38-4.fc11.src.rpm
(From a scratch build against fc11 on Koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=1217770)

Changes:
- Using %configure macro instead of ./configure.
- Using DESTDIR variable instead of the $prefix and $libdir variable during
installation. This requires adding the patch01 (ca-destdir.patch).
- Clean up the file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459211] Review Request: oolite - A space sim game, inspired by Elite

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459211





--- Comment #6 from Michel Alexandre Salim michel.syl...@gmail.com  
2009-03-03 18:16:09 EDT ---
I spent too many hours last summer on Oolite -- but GNUstep itself is a rather
neat platform, especially with new work now on Etoile (looking forward to when
it works on stock GNUstep).

I'll stop chattering on this bug now, until gnustep-base passes review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488010


Caius kaio Chance ccha...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?, |
   |needinfo?(peter...@redhat.c |
   |om) |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488285] Review Request: txt2man - Convert flat ASCII text to man page format

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488285


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro  2009-03-03 
18:46:39 EDT ---
Nothing much to review here.
All standard packaging rules seem to be respected, rpmlint has no complaints,
license (GPLv2+ is OK), sha1sum (e19c284ebcf4ced66ccb4a4954d99e69cc7b63b1
txt2man-1.5.5.tar.gz) is fine, works as expected

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488285] Review Request: txt2man - Convert flat ASCII text to man page format

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488285


Sindre Pedersen Bjørdal sindr...@fedoraproject.org changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Sindre Pedersen Bjørdal sindr...@fedoraproject.org  
2009-03-03 19:04:12 EDT ---
New Package CVS Request
===
Package Name: txt2man
Short Description: Convert flat ASCII text to man page format
Owners: sindrepb
Branches: F-9, F-10 EL-4 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481594


Michael Stahnke mastah...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||oget.fed...@gmail.com
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-03 
19:57:24 EDT ---
This is a very simple ruby package. I went through it and didn't find any
problems. But I have a few questions and two little suggestions:

? The other rubygem packages have BR: ruby(rubygems). This one has BR:
rubygems. Why is there a difference? Does it matter? Also BR: ruby(abi) =
%{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it
specifically? I know the guidelines tell us to do so. But I don't know why.

! The ruby guidelines tell us to use %global instead of %define. While it
doesn't matter much in this case, it would be good to obey the guidelines.

! It would look nicer and consistent if you make the description span evenly
and use the full 80 columns.


Otherwise, the package is good to go:

---
This package (rubygem-htmlentities) is APPROVED by oget
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

 CC||har...@redhat.com




--- Comment #9 from Bill Nottingham nott...@redhat.com  2009-03-03 20:30:32 
EDT ---
(In reply to comment #7)
 Spec URL: http://plautrba.fedorapeople.org/soud/soud.spec
 SRPM URL: http://plautrba.fedorapeople.org/soud/soud-0.1.3-1.fc10.src.rpm
 
 2) Daemon was part of development process and it is now optional. 
 
 Now it is based on udev rules created by soud-save-to-udev.pl from config 
 file.

OK, but then I really don't see what purpose this serves at all.

All it does is create an obfuscation/abstraction layer between udev rules and
its own configuration. Instead of having the user write:

ACTION==add, SUBSYSTEM==bluetooth, RUN+=/sbin/initctl emit
bluetooth-start

(which works on any distro), you have them write, somewhere else:

[bluetooth_start]
filter=SUBSYSTEM=bluetooth ACTION=add
action=/sbin/initctl emit bluetooth-start

which will only work on Fedora for now.

There's no actual value added in the process - it's just a translation layer.
And if you're packaging this config, and immediately post-processing it into
rules files in %post ... just package the rules files directly and skip the
processing.

I don't see how soud-watch.pl gives you anything you don't already have with
'udevadm monitor', and if we need more infrastructure there, we should get it
added upstream.

 3) bluetooth event.d script checks hw after runlevel changed. if there is no
 hw, calls stop on service, same situation if hw is removed.

However, given the normal way things work, as this is written now:

No hardware:
1) runlevel service starts bluetooth daemon
2) after runlevel, event is kicked off, checks hardware, then stops service

Has bluetooth hardware:
1) get udev event, trigger off upstart event
2) since upstart event is running before we enter a runlevel, we won't start
the service
3) normal runlevel service will start bluetooth daemon
4) after runlevel, event is kicked off, checks hardware, then exits

So, for both the 'normal' boot cases, it adds code and complication to the boot
process, without much benefit.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751


Yaakov Nemoy loupgaroubl...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #59 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-03-03 
20:37:53 EDT ---
New Package CVS Request
===
Package Name: ghc-X11
Short Description: A Haskell binding to the X11 graphics library.
Owners: ynemoy, petersen
Branches: F-9, F-10, F-11, devel
InitialCC: ynemoy

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485621] Review Request: perl-Gtk2-MozEmbed - Interface to the Mozilla embedding widget

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485621


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #5 from Chris Weyl cw...@alumni.drew.edu  2009-03-03 20:37:31 EDT 
---
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751





--- Comment #60 from Jens Petersen peter...@redhat.com  2009-03-03 20:46:39 
EDT ---
That should be

Branches: F-9 F-10
InitialCC: haskell-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486302] Review Request: parrot - Parrot is a virtual machine.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486302





--- Comment #5 from Gerd Pokorra g...@zimt.uni-siegen.de  2009-03-03 20:52:42 
EDT ---
By the ppc architecture the problems starting during configuring Parrot. May be
there is a lot of work to do that Parrot builds on PowerPC. Is it necessary
that parrot builds successful on ppc?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487052





--- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-03 
21:31:22 EDT ---
Thanks for the update.

* To clean up the SPEC file you can use a for-loop like: 

for file in README Sample_Commands.txt Options_Reference.txt; do
   sed 's|\r||' $file  $file.tmp
   touch -r $file $file.tmp
   mv -f $file.tmp $file
done

* You probably missed this question I asked:

 ? What is the directory build-aux and the executable files in the root of the
source tree for?

The reason I asked was: If these files run tests to check whether the
application is compiled properly, you will need to make a %check section and
run these tests.
On the other hand, if these scripts are useful for people who want to
use/develop dc3dd, you might want to put them in %{_datadir}/%{name} or inside
%doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459979





--- Comment #40 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-03 
21:33:53 EDT ---
kwizart, I think you should take this package over, otherwise it might take a
very long time for it to get done. I can do the review if you want.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488185] Review Request: php-pecl-selinux - SELinux binding for PHP scripts

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488185





--- Comment #1 from KaiGai Kohei kai...@kaigai.gr.jp  2009-03-03 21:55:59 EDT 
---
The result of rpmlint:

[kai...@saba ~]$ rpmlint
/home/kaigai/RPMS/SRPMS/php-pecl-selinux-0.1.2-devel.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[kai...@saba ~]$ rpmlint
/home/kaigai/RPMS/RPMS/i386/php-pecl-selinux-0.1.2-devel.fc10.i386.rpm
php-pecl-selinux.i386: W: incoherent-version-in-changelog 0.1.2
['0.1.2-devel.fc10', '0.1.2-devel']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

It claims 0.1.2 is noted on %changelog, although it is 0.1.2-devel.fc10.
IIRC, it can be an acceptable warnings, isn't it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487421] Review Request: libyaml - YAML 1.1 parser and emitter written in C

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487421


Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

 CC||rc040...@freenet.de




--- Comment #13 from Ralf Corsepius rc040...@freenet.de  2009-03-03 22:01:11 
EDT ---
(In reply to comment #12)
 I have pulled the .a file out of the -devel package and rebuilt.
Better use:

%configure --disable-static

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479903] Review Request: gdesklet-slideshow - Cycle through a collection of pictures

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479903


Luya Tshimbalanga l...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487296] Review Request: sssd - System Security Services Daemon

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487296





--- Comment #3 from Simo Sorce sso...@redhat.com  2009-03-03 22:11:42 EDT ---
talloc,tdb,tevent and ldb are now available as subpackages of the samba4
package and are built in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463088] Review Request: cl-trivial-gray-streams - A portable streams library for Common Lisp

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463088


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

   Flag||needinfo?(gr...@redhat.com)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486698] Review Request: fedora-setup-keyboard - Hal keyboard layout callout

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486698


Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #12 from Jens Petersen peter...@redhat.com  2009-03-03 22:45:02 
EDT ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=92365

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488397] New: Review Request: ghc-tar - Reading, writing and manipulating .tar archive files in Haskell

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ghc-tar - Reading, writing and manipulating .tar 
archive files in Haskell

https://bugzilla.redhat.com/show_bug.cgi?id=488397

   Summary: Review Request: ghc-tar - Reading, writing and
manipulating .tar archive files in Haskell
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: loupgaroubl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ynemoy.fedorapeople.org/review/ghc-tar.spec
SRPM URL: http://ynemoy.fedorapeople.org/review/ghc-tar-0.3.0.0-1.fc10.src.rpm
Description: This library is for working with .tar archive files. It can read
and write a range of common variations of archive format including V7, USTAR,
POSIX and GNU formats. It provides support for packing and unpacking portable
archives. This makes it suitable for distribution but not backup because
details like file ownership and exact permissions are not preserved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487094] Review Request: stp - Constraint solver/decision procedure

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487094





--- Comment #4 from David A. Wheeler dwhee...@dwheeler.com  2009-03-03 
22:53:50 EDT ---
New Package CVS Request
===
Package Name: stp
Short Description: Constraint solver/decision procedure
Owners: dwheeler amdunn
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485641] Review Request: pdftk - The PDF Toolkit

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485641





--- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-03 
22:52:31 EDT ---
* We still have the rpmlint:
   pdftk.src: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 1)

* To fix the dependency you can add this to the end of the %install section:

-
# Fix the weird dependency, e.g.
# /usr/lib64/gcj/itext/itext-x.y.z.jar.so()(64bit)  to
# /usr/lib64/gcj/itext/itext-x.y.z.jar.so
%define _use_internal_dependency_generator 0
cat  \EOF  %{name}.req
#!%{_buildshell}
grep -v %{_docdir} - | %{__find_requires} $* \
 | sed 's...@\(itext-[0-9.]*\.jar\.so\)\(()(64bit)\)\...@\1@'
EOF

%define __find_requires %{_builddir}/%{name}-%{version}/%{name}.req
chmod +x %{__find_requires}
-
Note that you will need to remove
   Requires:  %{_libdir}/gcj/itext/itext-2.1.4.jar.so
now. Also not that this won't break anything in 32bit systems. I am rebuilding
itext with proper provides now.

* Unfortunately, we have a bigger issue. pdftk fails to compile with gcc44:

-
/usr/lib/gcc/x86_64-redhat-linux/4.4.0/../../../../include/c++/4.4.0/ostream:514:
  instantiated from 'std::basic_ostreamchar, _Traits
std::operator(std::basic_ostreamchar, _Traits, const char*) [with _Traits
= std::char_traitschar]'
pdftk.cc:119:   instantiated from here
/usr/lib/gcc/x86_64-redhat-linux/4.4.0/../../../../include/c++/4.4.0/bits/ostream_insert.h:107:
error: mixing C++ and Java catches in a single translation unit
-

I don't know (yet) how to solve this. Andrew?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487094] Review Request: stp - Constraint solver/decision procedure

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487094


David A. Wheeler dwhee...@dwheeler.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Pravin Satpute psatp...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE




--- Comment #7 from Pravin Satpute psatp...@redhat.com  2009-03-03 23:39:54 
EDT ---
completed build
Thanks Parag and Kevin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481192] Review Request: perl-pgsql_perl5 - Pg - Perl5 extension for PostgreSQL

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481192


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #11 from Parag AN(पराग) panem...@gmail.com  2009-03-03 23:47:55 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #11 from Parag AN(पराग) panem...@gmail.com  2009-03-03 23:58:28 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484323] Review Request: perl-KinoSearch - Search engine library

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323


Bug 484323 depends on bug 484321, which changed state.

Bug 484321 Summary: Review Request: perl-Lingua-StopWords - Stop words for 
several languages
https://bugzilla.redhat.com/show_bug.cgi?id=484321

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484321] Review Request: perl-Lingua-StopWords - Stop words for several languages

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484321


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #6 from Parag AN(पराग) panem...@gmail.com  2009-03-03 23:58:52 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487645





--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-03-04 00:04:34 
EDT ---
can you close this review now as packages are built in cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #7 from Parag AN(पराग) panem...@gmail.com  2009-03-04 00:11:18 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488401] New: Review Request: ghc-filepath - Library for manipulating FilePath's in a cross platform way.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ghc-filepath - Library for manipulating FilePath's in 
a cross platform way.

https://bugzilla.redhat.com/show_bug.cgi?id=488401

   Summary: Review Request: ghc-filepath - Library for
manipulating FilePath's in a cross platform way.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: loupgaroubl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ynemoy.fedorapeople.org/review/ghc-filepath.spec
SRPM URL:
http://ynemoy.fedorapeople.org/review/ghc-filepath-1.1.0.1-1.fc10.src.rpm
Description: None given

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488401] Review Request: ghc-filepath - Library for manipulating FilePath's in a cross platform way.

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488401


Yaakov Nemoy loupgaroubl...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG




--- Comment #1 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-03-04 
00:26:41 EDT ---
oh nevermind, it's in the core. for some reason it's on hackage too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481527] Review Request: bucardo - asynchronous PostgreSQL replication system

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481527


Bug 481527 depends on bug 481531, which changed state.

Bug 481531 Summary: Review Request: perl-Test-Dynamic - Automatic test counting 
for Test::More
https://bugzilla.redhat.com/show_bug.cgi?id=481531

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||NOTABUG
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481531


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG




--- Comment #11 from Parag AN(पराग) panem...@gmail.com  2009-03-04 00:45:53 
EDT ---
Fine. Closing this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486757] Review Request: divine-mc - Multi-core model checking system for proving specifications

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486757





--- Comment #5 from David A. Wheeler dwhee...@dwheeler.com  2009-03-04 
00:56:56 EDT ---
I'll be glad to package DiVinE 2.0 when it's out.  My experience is that
deadlines often get missed :-).  So, let's package what's available.  If
nothing else, packaging the next release is likely to get way easier.

I'll try to improve the automated tests, though, as you suggested.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488404] New: Review Request: pony - Can I have a pony?

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pony -  Can I have a pony?

https://bugzilla.redhat.com/show_bug.cgi?id=488404

   Summary: Review Request: pony -  Can I have a pony?
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: loupgaroubl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ynemoy.fedorapeople.org/review/pony.spec
SRPM URL: http://ynemoy.fedorapeople.org/review/pony-1.0-1.fc10.src.rpm
Description: You can have a pony!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488407] New: Review Request: python-text_table - Simple Eyecandy ASCII Tables

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-text_table - Simple Eyecandy ASCII Tables

https://bugzilla.redhat.com/show_bug.cgi?id=488407

   Summary: Review Request: python-text_table - Simple Eyecandy
ASCII Tables
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ra...@bludgeon.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora



Ray Van Dolson ra...@bludgeon.org changed:

   What|Removed |Added

   Flag||fedora-review?


Spec URL: 
  http://rayvd.fedorapeople.org/python-text_table/python-text_table.spec
SRPM URL: 
 
http://rayvd.fedorapeople.org/python-text_table/python-text_table-0.02-1.el5.src.rpm

Description:
This module provides an interface to output simple ASCII tables.  It is based
on
the perl module Text::SimpleTable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485596] Review Request: phoronix-test-suite - A Comprehensive Linux Benchmarking System

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485596





--- Comment #5 from Joseph Smidt josephsm...@gmail.com  2009-03-04 01:27:07 
EDT ---
Okay, I removed the explicite-lib dependencies you mentioned and changed
qt4-devel to qt-devel.  Here are the new files:

Spec: http://jsmidt.fedorapeople.org/phoronix-test-suite.spec
Srpm: http://jsm:dt.fedorapeople.org/phoronix-test-suite-1.6.0-2.fc10.src.rpm

Here is the new rpmlint results:

rpmlint phoronix-test-suite-1.6.0-2.fc10.noarch.rpm 
phoronix-test-suite.noarch: E: non-executable-script
/usr/share/phoronix-test-suite/pts-core/modules/dummy_script_module.sh 0644
phoronix-test-suite.noarch: E: devel-dependency SDL_gfx-devel
1 packages and 0 specfiles checked; 2 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488407] Review Request: python-text_table - Simple Eyecandy ASCII Tables

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488407


Ray Van Dolson ra...@bludgeon.org changed:

   What|Removed |Added

   Flag|fedora-review?  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488404] Review Request: pony - Can I have a pony?

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488404


Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 CC||fedora-haskell-l...@redhat.
   ||com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478852] Review Request: lpairs - Classical memory game with cards

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478852





--- Comment #5 from Michael Schwendt bugs.mich...@gmx.net  2009-03-04 
02:07:34 EDT ---
%configure inst_dir=%{_datadir}/%{name}

makes Patch0 obsolete, btw.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487645


Christof Damian chris...@damian.net changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Christof Damian chris...@damian.net  2009-03-04 02:24:57 
EDT ---
closing now

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488410] New: Review Request: perl-HTML-TagCloud - Generate An HTML Tag Cloud

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-HTML-TagCloud - Generate An HTML Tag Cloud
Alias: perl-HTML-TagCloud

https://bugzilla.redhat.com/show_bug.cgi?id=488410

   Summary: Review Request: perl-HTML-TagCloud - Generate An HTML
Tag Cloud
   Product: Fedora
   Version: rawhide
  Platform: All
   URL: http://search.cpan.org/dist/HTML-TagCloud
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: cw...@alumni.drew.edu
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~cweyl/review/perl-HTML-TagCloud.spec
SRPM URL:
http://fedorapeople.org/~cweyl/review/perl-HTML-TagCloud-0.34-1.fc10.src.rpm

Description:
The HTML::TagCloud module enables you to generate tag clouds in HTML. Tag
clouds serve as a textual way to visualize terms and topics that are used
most frequently. The tags are sorted alphabetically and a larger font is
used to indicate more frequent term usage.

This module provides a simple interface to generating a CSS-based HTML tag
cloud. You simply pass in a set of tags, their URL and their count.  This
module outputs stylesheet-based HTML.  You may use the included CSS or use
your own.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1219368

*rt-0.05

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459979





--- Comment #41 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-03-04 
02:27:16 EDT ---
I'm sorry to say that jebba's MIA in order to spend more time on other things
in life.  IF no one wants to take this over, this bug should be closed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488410] Review Request: perl-HTML-TagCloud - Generate An HTML Tag Cloud

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488410


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485621] Review Request: perl-Gtk2-MozEmbed - Interface to the Mozilla embedding widget

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485621


Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Remi Collet fed...@famillecollet.com  2009-03-04 02:28:44 
EDT ---
Thanks for the review.


New Package CVS Request
===
Package Name: perl-Gtk2-MozEmbed
Short Description: Interface to the Mozilla embedding widget
Owners: remi
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488407] Review Request: python-text_table - Simple Eyecandy ASCII Tables

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488407


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488410] Review Request: perl-HTML-TagCloud - Generate An HTML Tag Cloud

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488410


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-03-04 02:44:26 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1219368
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
095f3b1d5159cd1ef1d3dd240f566bb3  HTML-TagCloud-0.34.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=14,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.16 cusr  0.02
csys =  0.19 CPU)
+ Package perl-HTML-TagCloud-0.34-1.fc11-noarch =
  Provides: perl(HTML::TagCloud) = 0.34
  Requires: perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487507] Review Request: perl-Class-XSAccessor-Array - Generate fast XS accessors without runtime compilation

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487507


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #5 from Parag AN(पराग) panem...@gmail.com  2009-03-04 02:43:12 
EDT ---

Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1219373
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fe97bdfbfdcfb37260a270d0d8bd4b36  Class-XSAccessor-Array-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=63,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.17 cusr  0.03
csys =  0.23 CPU)
+ Package perl-Class-XSAccessor-Array-0.14-2.fc11-i586 =
  Provides: Array.so perl(Class::XSAccessor::Array) = 0.14
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl =
0:5.006 perl(Carp) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


<    1   2