[Bug 470703] Review Request: links 2 - text mode browser with graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 --- Comment #22 from Lubomir Rintel lkund...@v3.sk 2009-04-03 02:26:40 EDT --- SPECS: http://v3.sk/~lkundrak/SPECS/links.spec SRPMS: http://v3.sk/~lkundrak/SRPMS/links-2.2-5.fc11.src.rpm + NSS support Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1274783 Anyone to review this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493432] Review Request: libgdata - Library for the GData protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493432 --- Comment #8 from Philip Withnall bugzi...@tecnocode.co.uk 2009-04-03 02:25:29 EDT --- (In reply to comment #7) It only seems to test two things, but that's better than testing nothing. If you agree, please consider this approved and add something like that when you import the package. None of the test programs are particularly comprehensive yet, but I do plan to improve their coverage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488173] Package Review: ibus-table-erbi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488173 --- Comment #3 from Caius kaio Chance ccha...@redhat.com 2009-04-03 02:50:00 EDT --- SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090403-1.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 Mattias Ellert mattias.ell...@fysast.uu.se changed: What|Removed |Added CC|mattias.ell...@fysast.uu.se | Flag|fedora-review? |fedora-review+ --- Comment #10 from Mattias Ellert mattias.ell...@fysast.uu.se 2009-04-03 03:54:18 EDT --- Package approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Pierre-YvesChibon pin...@pingoured.fr 2009-04-03 04:04:58 EDT --- Thanks for the review :) New Package CVS Request === Package Name: R-IRanges Short Description: Low-level containers for storing set of integer ranges Owners: pingou Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490724] Review Request: R-RUnit - R Unit test framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-04-03 04:36:43 EDT --- R-RUnit-0.4.21-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490724] Review Request: R-RUnit - R Unit test framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-04-03 04:36:49 EDT --- R-RUnit-0.4.21-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492946] Review Request: eclipse-dltk - Dynamic Languages Toolkit (DLTK) Eclipse plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492946
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
CC||akurt...@redhat.com
Flag||fedora-review+
--- Comment #9 from Alexander Kurtakov akurt...@redhat.com 2009-04-03
04:56:01 EDT ---
Formal review:
# OK: rpmlint gives no warnings/errors
# OK: named according to the Package Naming Guidelines .
# OK: The spec file match the base package %{name}
# OK: EPL
# OK: Every subpackage has it's own license shipping with it and included in
%doc.
# OK: The spec file must be written in American English.
# OK: The spec file for the package MUST be legible.
# OK: Fetch script shipped in the srpm.
# OK: Builds fine.
# OK: All BuildRequires and Requires are fine
# OK: Owns all folders.
# OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
# OK: Permissions on files must be set properly.
# OK: Each package must have a %clean section
# OK: Each package must consistently use macros.
# OK: The package must contain code, or permissable content.
# OK: If a package includes something as %doc, it must not affect the runtime
of the application.
# OK: All filenames in rpm packages must be valid UTF-8.
Package is good to go.
Mat, just FYI,
If this package is going to be available only F-11+, you can remove -a
-DjavacTarget=1.5 -DjavacSource=1.5 parts. This is added automatically from
pdebuild script when needed in F-11.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492946] Review Request: eclipse-dltk - Dynamic Languages Toolkit (DLTK) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492946 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479008] Review Request: libQGLViewer - Qt based OpenGL generic 3D viewer library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479008 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-04-03 05:01:49 EDT --- libQGLViewer-2.3.1-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libQGLViewer-2.3.1-8.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490722] Review Request: R-BSgenome - Infrastructure for Biostrings-based genome data packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490722 --- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se 2009-04-03 05:16:45 EDT --- see bug 490721 comment 3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490721] Review Request: R-Biostrings - String objects representing biological sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490721 --- Comment #3 from Mattias Ellert mattias.ell...@fysast.uu.se 2009-04-03 05:15:09 EDT --- This looks quite good, but if I try to use this package to build the R-BSgenome package I get this error: Loading required package: Biostrings Warning: Multiple methods tables found for 'score' Warning: Multiple methods tables found for 'substr' Warning: Multiple methods tables found for 'substring' Warning: Multiple methods tables found for 'chartr' Error in insertMethod(m1, as.character(sigi), args, el(methods, i), FALSE) : inserting method with invalid signature matching argument '...' to class ANY\ Error: package 'Biostrings' could not be loaded Execution halted Is this error caused by the R-Biostrings package not working, or is it used in the wrong way by the R-BSgenome package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470703] Review Request: links 2 - text mode browser with graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 Ondrej Vasik ova...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ova...@redhat.com --- Comment #23 from Ondrej Vasik ova...@redhat.com 2009-04-03 05:12:28 EDT --- Ok, just quick check first... 1) #Issue: # There is a symlink in /usr/bin/links to elinks if that package is installed # Should this package use links2 or should I modify elinks to remove the links # symlink from elinks - this comment in spec should be removed as elinks/links2 now uses alternatives. 2) Many warnings pointer targets in passing argument N of variable differ in signedness in build.log still ... upstream should address those... maybe just adding Mikulas to that review could be ok. The rest of the spec file looks sane to me (except one trailing space in build section - line with mv converted.AUTHORS ). Question: Shouldn't be that NSS support enabled via configure option (like in elinks?). This should be easier to get into upstream ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474356 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #21 from Alexander Kurtakov akurt...@redhat.com 2009-04-03 05:21:11 EDT --- Package is in repos now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487365] Review Request: eclipse-oprofile - Eclipse plugin for OProfile integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487365 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #12 from Alexander Kurtakov akurt...@redhat.com 2009-04-03 05:25:59 EDT --- Builded in repos. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487365] Review Request: eclipse-oprofile - Eclipse plugin for OProfile integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487365 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Alexander Kurtakov akurt...@redhat.com 2009-04-03 05:26:17 EDT --- Builded in repos. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489323] Review Request: ecj - Eclipse Compiler for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489323 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||akurt...@redhat.com Resolution||NEXTRELEASE --- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2009-04-03 05:25:07 EDT --- Builded in repos. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490724] Review Request: R-RUnit - R Unit test framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-04-03 05:38:08 EDT --- R-RUnit-0.4.21-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490724] Review Request: R-RUnit - R Unit test framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-04-03 05:38:13 EDT --- R-RUnit-0.4.21-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470703] Review Request: links 2 - text mode browser with graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 --- Comment #24 from Lubomir Rintel lkund...@v3.sk 2009-04-03 05:42:48 EDT --- (In reply to comment #23) Ok, just quick check first... If I understand correctly, you're planning to do a more detailed review later, right? In that case, I'll wait with updating the package until then. 1) #Issue: # There is a symlink in /usr/bin/links to elinks if that package is installed # Should this package use links2 or should I modify elinks to remove the links # symlink from elinks - this comment in spec should be removed as elinks/links2 now uses alternatives. Will remove. 2) Many warnings pointer targets in passing argument N of variable differ in signedness in build.log still ... upstream should address those... maybe just adding Mikulas to that review could be ok. Mikulas? Which one? An upstream developer? The rest of the spec file looks sane to me (except one trailing space in build section - line with mv converted.AUTHORS ). Will fix. Question: Shouldn't be that NSS support enabled via configure option (like in elinks?). This should be easier to get into upstream ... It should. In fact, I have little motivation to fix configure scripts gotten obviously wrong -- see use of random include directories in openssl detection routine below. So my plan is to throw this upstream and rewrite it (and the openssl detection) only once they complain. I don't really care about user choosing between NSS and OpenSSL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492946] Review Request: eclipse-dltk - Dynamic Languages Toolkit (DLTK) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492946 Mat Booth fed...@matbooth.co.uk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Mat Booth fed...@matbooth.co.uk 2009-04-03 05:50:35 EDT --- (In reply to comment #9) Package is good to go. Mat, just FYI, If this package is going to be available only F-11+, you can remove -a -DjavacTarget=1.5 -DjavacSource=1.5 parts. This is added automatically from pdebuild script when needed in F-11. Cool, I didn't know this. (Worth mentioning in the PDE build notes in the Eclipse plugin guidelines?) However, I'm going to request an F-10 branch since that's where my machines are at right now. Thanks for the speedy review. New Package CVS Request === Package Name: eclipse-dltk Short Description: Dynamic Languages Toolkit (DLTK) Eclipse plugin Owners: mbooth Branches: F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490721] Review Request: R-Biostrings - String objects representing biological sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490721 --- Comment #4 from Pierre-YvesChibon pin...@pingoured.fr 2009-04-03 05:55:03 EDT --- Hm indeed I run in the same problem while just trying to load Biostrings in R. Thanks for pointing this out I will investigate the source of the problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470703] Review Request: links 2 - text mode browser with graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 Ondrej Vasik ova...@redhat.com changed: What|Removed |Added CC||miku...@artax.karlin.mff.cu ||ni.cz --- Comment #25 from Ondrej Vasik ova...@redhat.com 2009-04-03 06:10:21 EDT --- (In reply to comment #24) Ok, just quick check first... If I understand correctly, you're planning to do a more detailed review later, right? In that case, I'll wait with updating the package until then. Yep, I do plan to checkfill review approval template I have step by step... Hopefully today ;) 2) Many warnings pointer targets in passing argument N of variable differ in signedness in build.log still ... upstream should address those... maybe just adding Mikulas to that review could be ok. Mikulas? Which one? An upstream developer? Exactly... adding him to CC... Question: Shouldn't be that NSS support enabled via configure option (like in elinks?). This should be easier to get into upstream ... It should. In fact, I have little motivation to fix configure scripts gotten obviously wrong -- see use of random include directories in openssl detection routine below. So my plan is to throw this upstream and rewrite it (and the openssl detection) only once they complain. I don't really care about user choosing between NSS and OpenSSL. In general - I'm ok with that - that patch is not very complicated and NSS compat could be full replacement for OpenSSL in that case. I guess that's not review blocker anyway - any maintainer/comaintainer could improve that configure script later to give user a chance to choose which library will be used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470703] Review Request: links 2 - text mode browser with graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 Matej Cepl mc...@redhat.com changed: What|Removed |Added CC|miku...@artax.karlin.mff.cu |mpato...@redhat.com |ni.cz | --- Comment #26 from Matej Cepl mc...@redhat.com 2009-04-03 06:16:36 EDT --- or what about his Red Hat address :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493432] Review Request: libgdata - Library for the GData protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493432 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Bastien Nocera bnoc...@redhat.com 2009-04-03 06:27:05 EDT --- New Package CVS Request === Package Name: libgdata Short Description: Library for the GData protocol Owners: hadess Branches: F-11 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #5 from Xavier Bachelot xav...@bachelot.org 2009-04-03 06:32:27 EDT --- New version, add a Group: tag to -selinux subpackage. http://www.bachelot.org/fedora/SPECS/drraw.spec http://www.bachelot.org/fedora/SRPMS/drraw-2.2-0.5.b2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483286] Review Request: perl-Data-Report - A flexible plugin-driven reporting framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483286 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||hdego...@redhat.com AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com Flag||fedora-review? --- Comment #6 from Hans de Goede hdego...@redhat.com 2009-04-03 07:06:34 EDT --- Hi Johan, As discussed by mail already, I'll review your current 4 package submissions, and once they are all approved, I'll sponsor you. I've done a full review of this package all in all it looks good, except for a few small things (see below). MUST FIX * Drop the patch and (Build)Requires perl(Text::CSV) instead of Text::CSV_XS I know you are upstream, but we do not want to deviate from upstream when not necessary and since you've now also packaged TEXT::CSV, there is no reason for the patch anymore. * Add Changes and README to %doc SHOULD FIX -- * Add following to spec: BuildRequires: perl(HTML::Entities) Requires: perl(HTML::Entities) I know this is optional but in Fedora we always try to enable as much features in packaes as possible, even if this drags in a few additional dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483250] Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483250
Hans de Goede hdego...@redhat.com changed:
What|Removed |Added
AssignedTo|fab...@bernewireless.net|hdego...@redhat.com
--- Comment #13 from Hans de Goede hdego...@redhat.com 2009-04-03 07:16:03
EDT ---
Hi Johan,
As discussed by mail already, I'll review your current 4 package submissions,
and once they are all approved, I'll sponsor you.
I've done a full review of this package and I fully agree with Fabian,
please change the %'s in the changelog to %% and add a whiteline between the
different release entries, iow change this:
* Fri Jan 30 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-3
- Fixed URL and Source urls
- Added %{?dist} to Release
- Fixed missing (optional) argument to %defattr
- Changed examples to examples/* to include all examples
* Fri Jan 30 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-2
- Update description
- Add patch to fix Makefiles to avoid double install of manual pages
- use smp_mflags
- use install -p
* Thu Jan 29 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-1
- First Fedora version
To:
* Fri Jan 30 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-3
- Fixed URL and Source urls
- Added %%{?dist} to Release
- Fixed missing (optional) argument to %%defattr
- Changed examples to examples/* to include all examples
* Fri Jan 30 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-2
- Update description
- Add patch to fix Makefiles to avoid double install of manual pages
- use smp_mflags
- use install -p
* Thu Jan 29 2009 Johan Vromans jvrom...@squirrel.nl - 4.2-1
- First Fedora version
Otherwise its fine. Fabian, re-assigning to me since I'm going to
sponsor Johan, and thanks for your review!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483250] Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483250 --- Comment #14 from Hans de Goede hdego...@redhat.com 2009-04-03 08:00:53 EDT --- Oops, I'm afraid that I've not done my review properly, trusting to much on Fabain's initial review. I just checked the AUTHORS file and the licensing discussed in there is a big red flag. Quoting from the AUTHORS file: CHORD is licensed following the conditions of the general GNU license. You are authorized to use this program free of charge. You are authorized to distribute this program freely as long as the full source is included. You are not allowed to remove the `copyright' notices from the authors nor are you allowed to pretend you wrote it. You are not allowed to charge any money for CHORD. You are not allowed to distribute a modified version of CHORD without written authorizations from the authors. You are not allowed to use parts of CHORD in any other commercial or public-domain software. Sorry for all the negatives rules ... but we've been bitten once! The GPL of course is fine, however the additional non GPL compatible rules like no selling or not acceptable for Fedora. I notice that you are the new upstream, and that you've written: CHORD is originally written by Martin Leclerc and Mario Dorion. Unfortunately, they have given up interest and disappeared from the internet. I hope that that is not entirely true, and with some hunting you can still contact them and get them to wave the extra rules they've added on top of the GPL, otherwise this program cannot be part of Fedora. --- As discussed already, I would review your current 4 package submissions, and once they are all approved, I would sponsor you. However this package looks like it will hit serious license troubles, so I would like to change the deal (in your benefit) to the following: as soon as the other 3 packages are approved I'll sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483250] Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483250 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #15 from Hans de Goede hdego...@redhat.com 2009-04-03 08:04:29 EDT --- Hmm, I see in the README that you've already tried to contact the old upstream people several times and failed. Let me run this past our legal stuff vetting person. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483364] Review Request: EekBoek - Bookkeeping software for small and medium-size businesses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483364 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com Flag||fedora-review? --- Comment #7 from Hans de Goede hdego...@redhat.com 2009-04-03 08:53:51 EDT --- As discussed already, I'll review this and your other 2 perl package submissions, and once they are all approved, I'll sponsor you. I've done a full review of this package and I fully agree with Mamoru, please fix the points he has addressed and then I'll aprove this. As for the license tag, I've checked the various .pm sources, and the correct license tag would be: License: GPL+ or Artistic -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490721] Review Request: R-Biostrings - String objects representing biological sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490721 --- Comment #5 from Pierre-YvesChibon pin...@pingoured.fr 2009-04-03 09:00:42 EDT --- After asking the Bioconductor-devel mailing list the answer is that the bug comes from the IRanges. I used the developmental version of IRanges to get the corrected DESCRIPTION file, this seems to not be compatible with the current Biostrings. I normally only package the stable version of Bioconductor but since the new release is coming before the end of the month I took the risk and there is the bug. I will update Biostrings to the development version aswell so that we can finish the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492164] Review Request: healpix - Hierarchical Equal Area isoLatitude Pixelization of a sphere
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492164 --- Comment #6 from Lubomir Rintel lkund...@v3.sk 2009-04-03 09:09:47 EDT --- Thanks, Jussi. I've incorporated your changes, and adjusted it into using a shared library instead of static one. Here you are: SPEC: http://v3.sk/~lkundrak/SPECS/healpix.spec SRPM: http://v3.sk/~lkundrak/SRPMS/healpix-2.11c-3.el5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487114 Jasper Capel fedora-jas...@newnewyork.nl changed: What|Removed |Added CC||fedora-jas...@newnewyork.nl --- Comment #9 from Jasper Capel fedora-jas...@newnewyork.nl 2009-04-03 09:14:36 EDT --- OK, it's been a while, I was distracted by other projects, but I have some results: * Upstream changed license header, included COPYING file * README corrected * Help text corrected * Init script modified to support spawning multiple daemons http://bender.newnewyork.nl/review/gvrpcd.spec http://bender.newnewyork.nl/review/gvrpcd-1.2-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2009-04-03 09:22:52 EDT --- You can go ahead with the cvs request, I've already approved the package. One last comment, you may want to delete the .la file in the %install section rather than excluding it in the %files section, but it doesn't really matter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493957] New: Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files https://bugzilla.redhat.com/show_bug.cgi?id=493957 Summary: Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lkund...@v3.sk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 492164 Estimated Hours: 0.0 Classification: Fedora SPEC: http://v3.sk/~lkundrak/SPECS/skyviewer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/skyviewer-1.0.0-1.fc11.src.rpm SkyViewer is an OpenGL based program to display HEALPix-based skymaps, saved in FITS format files. The loaded skymaps can be viewed either on a 3D sphere or as a Mollweide projection. In either case, realtime panning and zooming are supported, along with rotations for the 3D sphere view, assuming you have a strong enough graphics card. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492164] Review Request: healpix - Hierarchical Equal Area isoLatitude Pixelization of a sphere
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492164 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Blocks||493957 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489962] Review request: libhbalinux - SNIA HBAAPI vendor library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489962 --- Comment #1 from Jan Zeleny jzel...@redhat.com 2009-04-03 09:23:38 EDT --- Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbalinux/libhbalinux.spec Updated SRPM: http://jzeleny.fedorapeople.org/packages/libhbalinux/libhbalinux-1.0.7-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493958] New: Review request: fcoe-utils - utilities for fibre channel over ethernet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review request: fcoe-utils - utilities for fibre channel over ethernet https://bugzilla.redhat.com/show_bug.cgi?id=493958 Summary: Review request: fcoe-utils - utilities for fibre channel over ethernet Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: d...@danny.cz ReportedBy: jzel...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Jan Zeleny jzel...@redhat.com changed: What|Removed |Added Flag||fedora-review? SRPM: http://jzeleny.fedorapeople.org/packages/fcoe-utils/fcoe-utils-1.0.7-2.fc10.src.rpm SPEC: http://jzeleny.fedorapeople.org/packages/fcoe-utils/fcoe-utils.spec Fibre Channel over Ethernet utilities: fcoeadm - command line tool for configuring FCoE interfaces fcoemon - service to configure DCB Ethernet QOS filters, works with dcbd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490399] (Rename) Review Request: WebKitGTK - GTK+ Web content engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490399 Xan López x...@gnome.org changed: What|Removed |Added CC||x...@gnome.org --- Comment #6 from Xan López x...@gnome.org 2009-04-03 09:52:19 EDT --- (In reply to comment #4) 1. I'm a bit confused by what package name we should use here. domain: webkitgtk.org content on website: WebKitGTK+ link to source on website: WebKitGTK+ tar file downloaded: webkit-1.1.3.tar.gz So, the choices seem to be 'WebKitGTK+', 'webkit', 'webkitgtk'. Can you please ask upstream what the desired package name should be? Along with what case? ;) The 'official' name of the project is WebKitGTK+, but I'd say that's a weird name for a package name. IMHO webkitgtk would be the best option. It's a bit similar to GNU Emacs and 'emacs' as package name. And yeah, we should not name our tarball just 'webkit' :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: show - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 --- Comment #5 from Dave Malcolm dmalc...@redhat.com 2009-04-03 11:46:22 EDT --- Thanks. tabulate is growing on me as well, so would /usr/bin/tabulate be acceptable? Note to self: - tabulate can be autocompleted as tab[TAB] on my system (4 keystrokes, although all 4 are with left hand) - squeal requires sque[TAB] (5 keystrokes) and breaks autocompletion of squ[TAB] to squid - show requires 5 keystrokes, but the keys are shared between left and right hands. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492690] Review Request: kvirc - KVIrc is a free portable IRC client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492690
Alexey Torkhov atork...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|atork...@gmail.com
Flag||fedora-cvs?
--- Comment #11 from Alexey Torkhov atork...@gmail.com 2009-04-03 11:47:00
EDT ---
Only duplicate files left to fix in this package:
- It lists COPYING, FAQ and README as %doc, but those files simultaneously got
installed into %{_datadir}/%{name}. They must be excluded from install.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492690] Review Request: kvirc - KVIrc is a free portable IRC client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492690 Alexey Torkhov atork...@gmail.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: show - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 --- Comment #6 from manuel wolfshant wo...@nobugconsulting.ro 2009-04-03 11:54:26 EDT --- (In reply to comment #5) Thanks. tabulate is growing on me as well, so would /usr/bin/tabulate be acceptable? Note to self: - tabulate can be autocompleted as tab[TAB] on my system (4 keystrokes, although all 4 are with left hand) http://gadgets.inventivelabs.com.au/tabulate - squeal requires sque[TAB] (5 keystrokes) and breaks autocompletion of squ[TAB] to squid I can live with that. I doubt there will be many users with both squid and squeal on the same machine. But I'll be happy to be proven wrong :) - show requires 5 keystrokes, but the keys are shared between left and right hands. show is a .. show stopper, isn't it ( https://bugzilla.redhat.com/show_bug.cgi?id=492816#c2 )? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492164] Review Request: healpix - Hierarchical Equal Area isoLatitude Pixelization of a sphere
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492164
--- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-03 12:00:31
EDT ---
rpmlint output:
chealpix.x86_64: W: no-soname /usr/lib64/libchealpix.so
chealpix.x86_64: W: shared-lib-calls-exit /usr/lib64/libchealpix.so
e...@glibc_2.2.5
chealpix-devel.x86_64: W: no-documentation
healpix-fortran.x86_64: W: no-soname /usr/lib64/libgif.so
healpix-fortran.x86_64: W: no-soname /usr/lib64/libhealpix.so
healpix-fortran-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 6 warnings.
- Did you send the shared library patch upstream? IIRC some package sponsors
have frowned on Fedora specific patches to build shared libraries.
- Even though there is only one C header, it might be logical to put it into
the same place as the Fortran module files.
- Maybe Fortran package should be named just 'healpix'.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
- The java library seems to be under LGPLv2+, but since it isn't included no
problem.
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. NEEDSFIX
- chealpix and healpix-fortran need to call ldconfig in %post phase.
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. NEEDSFIX
- fortran-devel must require fortran since the libraries are in fortran.
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: show - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 --- Comment #7 from Dave Malcolm dmalc...@redhat.com 2009-04-03 12:01:58 EDT --- Heh, very good! BTW, I want to wait a while before renaming, in case someone comes up with a better name, and to become happy with the new name. If you have other name ideas, please let me know! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: show - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 --- Comment #8 from Dave Malcolm dmalc...@redhat.com 2009-04-03 12:10:10 EDT --- re the tabulate link in comment #6, it appears to be a non-Free iPhone/iPod-only app that works around a deficiency of that proprietary platform. I don't see it being a source of name confusion on Fedora, or any other Linux distribution, and, as a common English word, I don't see it being trademarkable, though IANAL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493957] Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493957 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-03 12:18:33 EDT --- - Don't use macros for cat or rm. (Macro for python is in the python guideline for some reason.) - Don't use filelist. - Use %defattr(-,root,root,-) - Remove empty %post and %postun sections. - Change BuildRequires: python, python-devel, python-setuptools to BuildRequires: python-setuptools-devel (BR python is redundant, since python-devel already pulls that in. If you BR python-setuptools-devel, then it pulls setuptools and python-devel automatically.) Also, you don't even need python-setuptools unless you want to build for EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493957] Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493957 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi Flag||fedora-review? --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-03 12:21:41 EDT --- Damn, wrong tab; meant for bug 492979. I must be daydreaming. Sorry. :) Well, I might as well review this package as it's related to healpix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492979] Review Request: python-cliutils - A collection of utilities easing the creation of command line scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492979 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-03 12:23:39 EDT --- - Don't use macros for cat or rm. (Macro for python is in the python guideline for some reason.) - Don't use filelist. - Use %defattr(-,root,root,-) - Remove empty %post and %postun sections. - Change BuildRequires: python, python-devel, python-setuptools to BuildRequires: python-setuptools-devel (BR python is redundant, since python-devel already pulls that in. If you BR python-setuptools-devel, then it pulls setuptools and python-devel automatically.) You don't even need python-setuptools unless you want to build for EPEL. For a plain Fedora spec you'd just need BR: python-devel. (In the python guideline the BR is actually just python.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478749 --- Comment #21 from wsny...@wsnyder.org 2009-04-03 14:11:08 EDT --- I've released dinotrace 9.4a that includes the core dump and lisp code fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 --- Comment #10 from Mohammed Morsi mmo...@redhat.com 2009-04-03 16:19:41 EDT --- Hey sorry for the delay, I got pulled onto something else last week and have been busy since. Some updates (new spec / srpm has been uploaded) - boost requirement has been removed - dist-f11 koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1276085 - been working w/ the anyterm upstream community to get some changes committed, including some necessary bugfixes, new features, and integration w/ httpd. After this no patches / additional changes should be needed for this - because of the previous I don't think anyterm 1.1.29 tarball from the site will cut it, so we'll need to either source this from the version control checkout tarball, or (less preferably) wait for the next release Thanks for the feedback -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:33:29 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226205] Merge Review: nss_ldap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226205 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #2 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:34:09 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489117] Review Request: tulrich-tuffy-fonts - Generic sans font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489117 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:37:59 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492946] Review Request: eclipse-dltk - Dynamic Languages Toolkit (DLTK) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492946 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:39:57 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225974] Merge Review: krb5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225974 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:43:13 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489929] Review request: libhbaapi - SNIA HBAAPI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489929 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:41:57 EDT --- I used SNIA HBAAPI library as the Short Description as that seems more correct. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491084] Review Request: medusa - parallel brute forcing pasword cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491084 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:45:34 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493432] Review Request: libgdata - Library for the GData protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493432 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:46:31 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493521] Review Request: perl-Log-Trace - A unified approach to tracing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493521 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:47:26 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493527] Review Request: perl-PlRPC - Interface for building pServer Clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493527 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:48:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458054 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #35 from Kevin Fenzi ke...@tummy.com 2009-04-03 16:44:37 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459925] Review Request: libowfat - Reimplementation of libdjb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459925 Simon Wesp cassmod...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Simon Wesp cassmod...@fedoraproject.org 2009-04-03 16:55:38 EDT --- in repo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491570] Review Request: sahana - Disaster Management System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491570 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-04-03 17:45:39 EDT --- sahana-0.6.2.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sahana-0.6.2.2-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491570] Review Request: sahana - Disaster Management System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491570 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-04-03 17:45:34 EDT --- sahana-0.6.2.2-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/sahana-0.6.2.2-4.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483250] Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483250 --- Comment #16 from Fabian Affolter fab...@bernewireless.net 2009-04-03 17:50:58 EDT --- Hans, thanks for checking my review. So far I wasn't aware of that there are developers out there who put copyright information in the AUTHORS files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458714] Review Request: libkate - Libraries to handle the Kate bitstream format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458714 --- Comment #15 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-04-03 19:12:10 EDT --- Spec URL: http://kwizart.fedorapeople.org/SPECS/libkate.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/libkate-0.3.1-2.fc11.src.rpm Description: Libraries to handle the Kate bitstream format Changelog - Prevent getline() conflict in recent rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458054 David Carter dcar...@entertain-me.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476346] Review Request: python-polybori - Framework for Boolean Rings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476346 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #24 from Conrad Meyer kon...@tylerc.org 2009-04-03 21:04:25 EDT --- Imported and built in rawhide; closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=1276530 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458279] Review Request: python-arm4 - Python language bindings for Applicatioon Response Measurement
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458279 Bug 458279 depends on bug 458054, which changed state. Bug 458054 Summary: Review Request: arm4 - Application Response Measurement (ARM) agent https://bugzilla.redhat.com/show_bug.cgi?id=458054 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494073] New: Review Request: libvmime - Powerful library for MIME messages and Internet messaging services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libvmime - Powerful library for MIME messages and Internet messaging services https://bugzilla.redhat.com/show_bug.cgi?id=494073 Summary: Review Request: libvmime - Powerful library for MIME messages and Internet messaging services Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kana...@kanarip.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.kanarip.com/custom/SPECS/libvmime.spec SRPM URL: http://www.kanarip.com/custom/f11/SRPMS/libvmime-0.9.0-1.fc11.src.rpm Description: VMime is a powerful C++ class library for working with MIME messages and Internet messaging services like IMAP, POP or SMTP. With VMime you can parse, generate and modify messages, and also connect to store and transport services to receive or send messages over the Internet. The library offers all the features to build a complete mail client. rpmlint is silent - f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=1276553 (fails because of dependency error) - f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=1276589 (succeeds without inkscape builddep) - f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1276554 - f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1276559 A note on the inkscape builddep; if I were to package the documentation I would need inkscape to generate the pdf from the *.tex files, though I'm not sure that I should (the docs don't build for a normal ./configure make either) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490638] Review Request: b43-tools - Tools for the Broadcom 43xx series WLAN chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490638 Keith G. Robertson-Turner redhat-bugzi...@slated.org changed: What|Removed |Added CC||redhat-bugzi...@slated.org --- Comment #1 from Keith G. Robertson-Turner redhat-bugzi...@slated.org 2009-04-03 22:01:30 EDT --- Missing BuildRequires: python-devel + cd debug + python install.py install --skip-build --root /var/tmp/b43-tools-0-0.1.git20090125.blag90001-QEJNVW running install error: invalid Python installation: unable to open /usr/lib64/python2.5/config/Makefile (No such file or directory) error: Bad exit status from /var/tmp/rpm-tmp.65195 (%install) Please consider using Mach/Mock for clean chroot builds, as this will identify missing deps at an early stage. Thanks for the package, I need this now I'm running a linux-libre kernel (b43 deblobbed) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490638] Review Request: b43-tools - Tools for the Broadcom 43xx series WLAN chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490638 --- Comment #2 from Keith G. Robertson-Turner redhat-bugzi...@slated.org 2009-04-03 22:34:57 EDT --- Test build succeeded. b43-asm successfully assembled OpenFWWF b43 firmware. Module inserts into kernel (with qos=0 option). NetworkManager establishes WiFi connection. Network responsive and shows no degradation. +1 publish (after fixing missing BuildRequires: python, python-devel) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Bernard Johnson bjohn...@symetrix.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Bernard Johnson bjohn...@symetrix.com 2009-04-03 23:17:09 EDT --- Here lately I've been liking using %exclude rather than a rm in the spec. Thanks again for the review. New Package CVS Request === Package Name: libmkv Short Description: An alternative to the official libmatroska library Owners: bjohnson Branches: F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426753] Review Request: xmonad - A tiling window manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426753 --- Comment #36 from Jens Petersen peter...@redhat.com 2009-04-04 00:02:17 EDT --- Yaakov built it http://koji.fedoraproject.org/koji/buildinfo?buildID=96455 unfortunately now it has higher release number than rawhide which is not good. You should use ghc-X11-1.4.5-5.fc10.1 to bump in F-10 to keep it less than ghc-X11-1.4.5-5.fc11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463035
--- Comment #11 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04
01:30:36 EDT ---
Phew, it's been 6 months. This was one of my first reviews and I barely
remember it.
Anyway, since then, there were some changes in the guidelines too. I had a
quick look at the package:
* The problem that I reported before remains:
When I run the pyroman script I get the error:
No rule files found in directory './examples/base'!
I think you need to change the default_rules_path in the launching script (to
%{_sysconfdir}/%name via 'sed', for instance).
* Please make use of the %{name} macro in %install
* Please use the -p switch of install extensively, to preserve timestamps.
* %setup -q -n %{name}-%{version}
is not necessary.
%setup -q
should be enough
* We certainly don't want
%define _unpackaged_files_terminate_build 0
* The new guidelines suggest that, In the first line, %define should be
replaced by %global
? Where does SOURCE1 come from? Why the name fedora.init ?
! You probably don't need
cp -p %SOURCE1 .
because you can use
install -pm 0755 %{SOURCE1} %{buildroot}/%{_initrddir}/%{name}
in the %install section.
* Also there are two rpmlints that deserve attention:
pyroman.noarch: W: service-default-enabled /etc/rc.d/init.d/pyroman
pyroman.noarch: W: incoherent-subsys /etc/rc.d/init.d/pyroman $prog
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:41:14 EDT --- re-ping? shall I add someone else to CC? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226036] Merge Review: liboil
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226036 --- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:44:09 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226034
--- Comment #22 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04
01:47:48 EDT ---
Could you folks update the package according to comment #7 so we can close the
merge review?
I also noticed that there is one occurrence of rm that should be converted to
%{__rm} for macro consistency.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #43 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:51:45 EDT --- Is mlt totally useless without kdenlive? Can someone write an application that uses mlt and no ffmpeg? If yes, mlt package belongs to Fedora. Otherwise, we can carry it over to rpmfusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465646] Review Request: python-hachoir-core - Hachoir core parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465646 --- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:55:15 EDT --- re-ping? is there anything wrong? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
