[Bug 517822] Review Request: hyphen-mr - Marathi hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517822 Caolan McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||caol...@redhat.com AssignedTo|nob...@fedoraproject.org|caol...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517821] Review Request: hyphen-bn - Bengali hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517821 Caolan McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||caol...@redhat.com AssignedTo|nob...@fedoraproject.org|caol...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517970] Review Request: lingot-0.7.6 - musical instruments tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517970 --- Comment #2 from Karel Volný kvo...@redhat.com 2009-08-19 03:23:52 EDT --- (In reply to comment #1) Question: Why do you not create a wrapper script for your application? because I consider it overkill ... no problem starting the app from gui but if you think it should be done, basically nothing prevents me from doing that -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517822] Review Request: hyphen-mr - Marathi hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517822 Caolan McNamara caol...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #1 from Caolan McNamara caol...@redhat.com 2009-08-19 03:28:08 EDT --- Review: + package builds in mock + rpmlint is error-free for SRPM and for RPM. + source files match upstream url + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491980] Review Request: bauble - Biodiversity collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491980 --- Comment #21 from Pierre-YvesChibon pin...@pingoured.fr 2009-08-19 03:29:03 EDT --- with python-mako-0.2.4-2.fc11.noarch the connection to the database works However the export to XML produces an error: /usr/lib/python2.6/site-packages/bauble/plugins/imex/xml.py:68: GtkWarning: gtk_file_chooser_button_set_property: Choosers of type `GtkFileChooserButton` do not support selecting multiple files. file_chooser.set_select_multiple(False) xml.py(83): on_dialog_response(/home/pierrey, True) Traceback (most recent call last): File /usr/lib/python2.6/site-packages/bauble/plugins/imex/xml.py, line 85, in on_dialog_response self.__export_task(filename, one_file) File /usr/lib/python2.6/site-packages/bauble/plugins/imex/xml.py, line 95, in __export_task for table_name, table in tables.iteritems(): NameError: global name 'tables' is not defined Export to csv works fine -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517821] Review Request: hyphen-bn - Bengali hyphenation rules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517821
Caolan McNamara caol...@redhat.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Caolan McNamara caol...@redhat.com 2009-08-19 03:31:15
EDT ---
Review:
+ package builds in mock
+ rpmlint is error-free for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
APPROVED.
Are these hyphenation rules good for Bengali as written in Bangladesh ?, I'd
guess that they probably are, if so then maybe...
pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/
bn_IN_aliases=bn_BD
for lang in $bn_IN_aliases; do
ln -s hyph_bn_IN.dic hyph_$lang.dic
done
popd
after the cp is indicated
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503256 --- Comment #56 from Jussi Lehtola jussi.leht...@iki.fi 2009-08-19 03:32:25 EDT --- You've bumped the version, so reset the release to 1. Same for paperbox. Do the missing informal review, will you? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503847] Review Request: paperbox - A GTK tracker based document browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503847 --- Comment #15 from Jussi Lehtola jussi.leht...@iki.fi 2009-08-19 03:41:11 EDT --- Yes, seems to build fine in rawhide. Reset the release to 1, as you've updated the version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513892] Review Request: bilbo - Blogging client, focused on simplicity and usability
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513892 --- Comment #3 from Martin Gieseking martin.giesek...@uos.de 2009-08-19 04:04:13 EDT --- OK, there's already an upstream comment to the reported problem. However, they probably didn't quite understand the problem. COPYING.LGPL in subfolder bilbokblog contains the text of LGPL v2 (GNU *Lesser* General Public License) but the file headers refer to the outdated GNU *Library* public license. Maybe you could point them to this ambiguity. Anyway, it shouldn't be a blocker for this package. Could you please update the spec file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518018] Review Request: zyx-liveinstaller - Install a running LiveOS rebootlessly
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518018 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-08-19 04:22:13 EDT --- url is incorrect, should be http://filteredperception.org/smiley/projects/zyx-rli/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517822] Review Request: hyphen-mr - Marathi hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517822 Parag pnem...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Parag pnem...@redhat.com 2009-08-19 04:45:26 EDT --- Thanks for the review. New Package CVS Request === Package Name: hyphen-mr Short Description: Marathi hyphenation rules Owners: pnemade Branches: F-11, devel InitialCC: pnemade -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517821] Review Request: hyphen-bn - Bengali hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517821 Parag pnem...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Parag pnem...@redhat.com 2009-08-19 04:47:41 EDT --- Thanks for the review. I will ask upstream and if they says its ok I will add support for bn_BD. New Package CVS Request === Package Name: hyphen-bn Short Description: Bengali hyphenation rules Owners: pnemade Branches: F-11, devel InitialCC: pnemade -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517416 --- Comment #2 from Benoît Marcelin serein...@online.fr 2009-08-19 07:27:03 EDT --- done new spec : http://tmp.sereinity.homelinux.org/rpm/awl.spec new srpm : http://tmp.sereinity.homelinux.org/rpm/awl-0.37-2.fc11.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517914 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 07:41:54 EDT --- I'll take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517914 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 08:02:12 EDT --- Rpmlint gives a number of warnings: rpmlint aqute-bndlib.spec aqute-bndlib.spec:37: W: non-standard-group Development/Java aqute-bndlib.spec:72: W: non-standard-group Development/Documentation rpmlint aqute-bndlib-0.0.203-4.2.fc12.src.rpm aqute-bndlib.src: W: non-standard-group Development/Java rpmlint noarch/aqute-bndlib-* aqute-bndlib.noarch: W: non-standard-group Development/Java aqute-bndlib.noarch: W: incoherent-version-in-changelog 0.0.203-4.2 ['0:0.0.203-4.2.fc12', '0:0.0.203-4.2'] aqute-bndlib.noarch: W: no-documentation aqute-bndlib.noarch: W: non-conffile-in-etc /etc/maven/fragments/aqute-bndlib aqute-bndlib-javadoc.noarch: W: non-standard-group Development/Documentation I would like to see them (except non-conffile-in-etc) cleaned. Full review will follow shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244192 --- Comment #40 from rob rob.my...@gtri.gatech.edu 2009-08-19 08:09:30 EDT --- http://rmyers.fedorapeople.org/eclipse-anyedit/eclipse-anyedit-2.2.0-1.fc11.src.rpm http://rmyers.fedorapeople.org/eclipse-anyedit/eclipse-anyedit-2.2.0-1.fc11/ * Wed Aug 19 2009 Rob Myers rob.my...@gtri.gatech.edu 2.2.0-1 - Updated to 2.2.0 - Drop gcj support - Change jar location to /usr/share/eclipse/dropins/anyedit - Bump eclipse-platform to 3.4.0+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518189] New: Review Request: java-augeas - Java bindings for Augeas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: java-augeas - Java bindings for Augeas https://bugzilla.redhat.com/show_bug.cgi?id=518189 Summary: Review Request: java-augeas - Java bindings for Augeas Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bkear...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://bkearney.fedorapeople.org/java-augeas.spec SRPM URL: http://bkearney.fedorapeople.org/java-augeas-0.0.1-1.fc11.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1614282 Description: Java Bindings for Augeas. The spec file will be correct if/when David lets me have some space on augeas.net to put the tarball :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517416 --- Comment #3 from Andrew Colin Kissa and...@topdog.za.net 2009-08-19 08:41:02 EDT --- The srpm is actually an rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517416 --- Comment #4 from Benoît Marcelin serein...@online.fr 2009-08-19 08:53:45 EDT --- Oups, sorry http://tmp.sereinity.homelinux.org/rpm/awl-0.37-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480724 --- Comment #41 from pjp pj.pan...@yahoo.co.in 2009-08-19 08:59:48 EDT --- Hi, I've made most of the changes indicated in the *brilliant* review above, except for the sub package and name change part. I tried doing that as well, but I think it'll become more complex with so many rpm/subpackages and in turn be less intuitive for users. So it'll be better to install all tools/servers/docs from one rpm. Simple and straight forward. Please take a look at the latest files: SPEC: http://pjp.dgplug.org/djbdns/djbdns.spec SORC: http://pjp.dgplug.org/djbdns/djbdns-1.05.3.tar.gz SRPM: http://pjp.dgplug.org/djbdns/djbdns-1.05.3-2.fc10.src.rpm Thanks so much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517416 Andrew Colin Kissa and...@topdog.za.net changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|and...@topdog.za.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244192 --- Comment #41 from Andrew Overholt overh...@redhat.com 2009-08-19 09:16:59 EDT --- 3 minor things: - please put comments above the package and assemble scripts saying that you wrote them - change the %files entry to be /usr/share/eclipse/dropins/anyedit - injecting the license isn't necessary Otherwise, good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517416
Andrew Colin Kissa and...@topdog.za.net changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #5 from Andrew Colin Kissa and...@topdog.za.net 2009-08-19
09:31:04 EDT ---
FIX: rpmlint must be run on every package. The output should be posted in the
review
rpmlint rpmbuild/SPECS/awl.spec rpmbuild/SRPMS/awl-0.37-2.fc11.src.rpm
rpmbuild/RPMS/noarch/awl-0.37-2.fc11.noarch.rpm
rpmbuild/SPECS/awl.spec:57: W: macro-in-%changelog _datadir
rpmbuild/SPECS/awl.spec:58: W: macro-in-%changelog _datadir
awl.src:57: W: macro-in-%changelog _datadir
awl.src:58: W: macro-in-%changelog _datadir
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Just use /usr/share/php in the changelog
OK: The package must be name according to the Package Naming Guidelines
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines
FIX: The License field in the package spec file must match the actual license.
Based on the README GPLv2+ can be used.
OK: If (an only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources use to build the package must match the upstream source, as
provided in the spec URL.
sha1sum awl_0.37.tar.gz rpmbuild/SOURCES/awl_0.37.tar.gz
1cee5d230672be387702d673c40ffdf9abacd0b4 awl_0.37.tar.gz
1cee5d230672be387702d673c40ffdf9abacd0b4 rpmbuild/SOURCES/awl_0.37.tar.gz
OK: The package MUST successfully compile an build into binary rpms on at least
one primary architecture.
N/A: If the package does not successfully compile, build or work on an
architecture
N/A: All build dependencies must be listed in BuildRequires
N/A: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A: Every binary RPM package (or subpackage) which stores share library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
N/A: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
FIX: Each package must consistently use macros.
If you want to use %{__install} or %{__sed} style, please use %{__make},
%{__rm} for consistency.
OK: The package must contain code, or permissible content.
N\A: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
N\A: Header files must be in a -devel package.
N\A: Static libraries must be in a -static package.
N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
Directory ownership and usability).
N\A: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that en in .so (without suffix) must go in a -devel package.
N\A: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
N\A: Packages must NOT contain any .la libtool archives, these must be remove
in the spec if they are built.
N\A: Packages containing GUI applications must include a %{name}.desktop file
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
No real blockers just fix the issues raised before requesting CVS
---
This package (awl) is APPROVED by topdog
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are
[Bug 517520] Review Request: easymock2- Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517520 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Dennis Gilmore den...@ausil.us 2009-08-19 09:38:06 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480724 --- Comment #42 from Dan Peterson dpi...@gmail.com 2009-08-19 09:41:49 EDT --- And why not the name change? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517520] Review Request: easymock2- Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517520 --- Comment #10 from Dennis Gilmore den...@ausil.us 2009-08-19 09:38:46 EDT --- I should add that i disagree with renaming. it doesn't meet the guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: Pre-Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 09:41:38 EDT --- This is a full review request. The pre-review request was bug #500253. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] New: Review Request: Pre-Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Pre-Review Request: directory-naming - Directory Naming https://bugzilla.redhat.com/show_bug.cgi?id=518205 Summary: Review Request: Pre-Review Request: directory-naming - Directory Naming Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: akurt...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-4.fc12.src.rpm Description: Old directory/naming module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: Pre-Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks||429551 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461849] Review Request: garmintools - Communication tools for Garmin devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461849
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
CC||lemen...@gmail.com
--- Comment #7 from Peter Lemenkov lemen...@gmail.com 2009-08-19 09:48:11
EDT ---
Brian, I'm sorry for shameless breaking of your review process, but it seems,
that you forgot about this ticket :)
REVIEW:
- rpmlint is not silent (I added custom message numbering for the sake of
simplicity)
[pe...@sulaco SPECS]$ rpmlint ~/Desktop/garmintools-
1. garmintools.ppc: W: shared-lib-calls-exit /usr/lib/libgarmintools.so.4.2.0
e...@glibc_2.0
2. garmintools.ppc: E: postin-without-ldconfig /usr/lib/libgarmintools.so.4.2.0
3. garmintools.ppc: E: library-without-ldconfig-postun
/usr/lib/libgarmintools.so.4.2.0
4. garmintools.ppc: W: devel-file-in-non-devel-package
/usr/lib/libgarmintools.so
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
[pe...@sulaco SPECS]$
The 1st message is indicated a possible design flaw in garmintools. You should
consider asking upstream about it.
The 2nd and the 3rd messaged should be fixed. Please remove devel from the
%post and %postun sections (looks like the leftover), and be careful - don't
forget the %post section which contains rmmod garmin_gps /dev/null || true
The 4th message should be fixed - you accidentally listed file
%{_libdir}/libgarmintools.so twice - in main package and in devel-subpackage. I
advise you to change in %files section this line
%{_libdir}/lib*.so*
to that one:
%{_libdir}/lib*.so.*
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
- The package must meet the Packaging Guidelines, but there is an issue, in the
%files section, with owned directories which are already owned by other
applications. See my note below.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.
[pe...@sulaco SOURCES]$ sha256sum garmintools-0.10.tar.gz*
ffd50b7f963fa9b8ded3223c4786b07906c887ed900de64581a24ff201444cee
garmintools-0.10.tar.gz
ffd50b7f963fa9b8ded3223c4786b07906c887ed900de64581a24ff201444cee
garmintools-0.10.tar.gz.1
[pe...@sulaco SOURCES]$
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1614626
+ All build dependencies are listed in BuildRequires.
- Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. See my notes, regarding rpmlint messages above.
+ The package owns all directories that it creates (none, actually).
- A Fedora package must not list a file more than once in the spec file's
%files listings. See my notes, regarding rpmlint messages above.
+ Permissions on files were set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are in a -devel package.
+ No static libraries.
- If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package. See
my notes, regarding rpmlint messages above.
+ The devel subpackage requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
- The package must not own files or directories already owned by other
packages. Unfortunately, main package owns /etc/udev/rules.d and
/etc/modprobe.d
Please use the correct form (note the asterisk mark at the end of the
strings)):
%config(noreplace) %{_sysconfdir}/udev/rules.d/*
%config(noreplace) %{_sysconfdir}/modprobe.d/*
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm package are valid UTF-8.
Please, fix issues noted above.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #56 from Fedora Update System upda...@fedoraproject.org 2009-08-19 09:50:43 EDT --- colossus-0.9.1-2.20090817svn4489.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/colossus-0.9.1-2.20090817svn4489.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #55 from Fedora Update System upda...@fedoraproject.org 2009-08-19 09:48:50 EDT --- colossus-0.9.1-2.20090817svn4489.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/colossus-0.9.1-2.20090817svn4489.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502689] Review Request: mingw32-cppunit - MinGW Windows C++ unit testing framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502689
--- Comment #6 from Kalev Lember ka...@smartlink.ee 2009-08-19 09:53:53 EDT
---
Fedora review mingw32-cppunit-1.12.1-2.fc11.src.rpm 2009-08-19
+ OK
! needs attention
+ rpmlint is quiet
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ The stated license (LGPLv2+) is a Fedora approved license
+ The stated license is the same as the one for the corresponding
Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
bd30e9cf5523cdfc019b94f5e1d7fd19 cppunit-1.12.1.tar.gz
bd30e9cf5523cdfc019b94f5e1d7fd19 Download/cppunit-1.12.1.tar.gz
+ Package builds in mock (Fedora Rawhide i386)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
! Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! According to http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
packages must use one of the changelog formats defined in there.
1) Use your real name in the changelog;
2) fix the date of latest entry (it reads Jan 5 right now);
3) remove spaces around your email address.
It should read something like this:
* Mon Jan 5 2009 Nicolas Chauvet kwiz...@gmail.com - 1.12.1-1
Besides the missing Requires: pkgconfig and the problem with changelog entries
the spec file looks good.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517520] Review Request: easymock2- Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517520 --- Comment #11 from Andrew Overholt overh...@redhat.com 2009-08-19 09:57:41 EDT --- (In reply to comment #10) I should add that i disagree with renaming. it doesn't meet the guidelines Understood. In the future (after this maven nightmare is fixed), we will move them: easymock2 - easymock easymock - easymock1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Summary|Review Request: Pre-Review |Review Request: |Request: directory-naming - |directory-naming - |Directory Naming|Directory Naming --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 10:01:05 EDT --- Fix summary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244192 --- Comment #42 from rob rob.my...@gtri.gatech.edu 2009-08-19 10:02:12 EDT --- Should all be fixed now. http://rmyers.fedorapeople.org/eclipse-anyedit/eclipse-anyedit-2.2.0-2.fc11.src.rpm http://rmyers.fedorapeople.org/eclipse-anyedit/eclipse-anyedit-2.2.0-2.fc11/ * Wed Aug 19 2009 Rob Myers rob.my...@gtri.gatech.edu 2.2.0-2 - Drop LICENSE file - Minor spec file cleanup -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #28 from Karel Volný kvo...@redhat.com 2009-08-19 10:05:51 EDT --- (In reply to comment #27) http://adamwill.fedorapeople.org/navit/navit-0.1.1-0.1.2431.aw_fc12.src.rpm just FYI, I did a koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=1614676 after starting the application, the Data menu item is empty ... is that expected? - how do I load some larger map? (er, if the answer is RTFM then just give me some time, I just had a quick peek, will take deeper look in a few days :-)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244192 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #43 from Andrew Overholt overh...@redhat.com 2009-08-19 10:08:49 EDT --- Approved. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517914 --- Comment #4 from Andrew Overholt overh...@redhat.com 2009-08-19 10:15:08 EDT --- Updated package: http://overholt.fedorapeople.org/aqute-bndlib-0.0.203-4.3.fc12.src.rpm http://overholt.fedorapeople.org/aqute-bndlib.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 10:12:16 EDT --- New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-4.fc12.src.rpm Changes: - Remove gcj support. - Build with build.sysclasspath=only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516271] Review Request: perl-Curses-UI - Curses based OO user interface framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516271 Emmanuel Seyman emmanuel.sey...@club-internet.fr changed: What|Removed |Added CC||emmanuel.sey...@club-intern ||et.fr Flag||fedora-cvs- --- Comment #5 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 2009-08-19 10:17:47 EDT --- (In reply to comment #4) New Package CVS Request The fedora‑cvs flag isn't set so I doubt the CVS admins are going to see this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 10:21:29 EDT --- New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-5.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244192 rob rob.my...@gtri.gatech.edu changed: What|Removed |Added Flag||fedora-cvs? --- Comment #44 from rob rob.my...@gtri.gatech.edu 2009-08-19 10:26:01 EDT --- New Package CVS Request === Package Name: eclipse-anyedit Short Description: AnyEdit plugin for eclipse Owners: rmyers joshkayse Branches: F-11 InitialCC: overholt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] New: Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: dumbster - Fake SMTP Server https://bugzilla.redhat.com/show_bug.cgi?id=518219 Summary: Review Request: dumbster - Fake SMTP Server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: akurt...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-8.fc12.src.rpm Description: The Dumbster is a very simple fake SMTP server designed for unit and system testing applications that send email messages. It responds to all standard SMTP commands but does not deliver messages to the user. The messages are stored within the Dumbster for later extraction and verification. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518219 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks||429551 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 10:44:34 EDT --- This is a full review request. The pre-review request was bug #500251. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt overh...@redhat.com changed: What|Removed |Added CC||overh...@redhat.com --- Comment #5 from Andrew Overholt overh...@redhat.com 2009-08-19 10:41:54 EDT --- A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM - I'd like to see a comment for the patch to the project files - I removed the remaining sed lines for setproxy and the build was fine. I think they can be removed. Otherwise, things look good. It's nice that all of the test suites run and have no failures/errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470293] Review Request: sblim-cmpi-network - SBLIM Network Instrumentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470293 Vitezslav Crhonek vcrho...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Vitezslav Crhonek vcrho...@redhat.com 2009-08-19 11:13:28 EDT --- New Package CVS Request === Package Name: sblim-cmpi-network Short Description: Standards Based Linux Instrumentation Network Providers Owners: vcrhonek Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517183] Review Request: mipv6-daemon - IPv6 Mobility Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517183 --- Comment #13 from Jarod Wilson jwil...@redhat.com 2009-08-19 11:27:50 EDT --- Okay, I've sponsored you into the 'packager' group, will go ahead and set the cvs request flag now... Oh, looks like I already set it... Oops. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515046] Review Request: perl-XML-Parser-Lite-Tree-XPath - XPath access to XML::Parser::Lite::Tree structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515046 --- Comment #7 from Juanjo reid...@usebox.net 2009-08-19 11:32:18 EDT --- Fixed: 1. License issue: the author removed the offending line referring to Perl license. Now the module it's properly licensed (Artistic 2.0). 2. Tests problems: the author answered that the problem was in the dependency XML::Parser::Lite::Tree, so he released a new version of the module and XML::Parser::Lite::Tree::XPath requires XML::Parser::Lite::Tree = 0.10. 3. Regarding the install -p issue, the install line executed is generated from Makefile.PL and I think it's safe (as far as I can see in other spec files). Updated data follows... Spec URL: http://jjmartinez.fedorapeople.org/packages/SPECS/perl-XML-Parser-Lite-Tree-XPath.spec SRPM URL: http://jjmartinez.fedorapeople.org/packages/SRPMS/perl-XML-Parser-Lite-Tree-XPath-0.23-1.fc11.src.rpm Description: This is a pure-Perl implementation of XPath as complement to XML::Parser::Lite::Tree, a pure-Perl XML tree parser and builder. It aims to implement 100% of the W3C XPath specification. This is my first package for fedora and I need someone to sponsor. Moreover I've upgraded XML::Parser::Lite::Tree (spec fetched from CVS), because this package needs to be updated (as stated previously in point .2). You can fetch the spec/SRPM from: http://jjmartinez.fedorapeople.org/packages/SPECS/perl-XML-Parser-Lite-Tree.spec http://jjmartinez.fedorapeople.org/packages/SRPMS/perl-XML-Parser-Lite-Tree-0.10-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517183] Review Request: mipv6-daemon - IPv6 Mobility Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517183 Jarod Wilson jwil...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #14 from Jarod Wilson jwil...@redhat.com 2009-08-19 11:37:53 EDT --- Here we go... I screwed up and set the flag to + instead of ?. The ? lets the cvs admin folks know action is needed, the + signifies action has been taken. New Package CVS Request === Package Name: mipv6-daemon Short Description: Owners: tgraf Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516114] Review Request: trac-accountmanager-plugin - Trac plugin for account registration and management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516114 Paul Howarth p...@city-fan.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|p...@city-fan.org Flag||fedora-review? --- Comment #2 from Paul Howarth p...@city-fan.org 2009-08-19 11:36:55 EDT --- I'll review this one since I had a look at an earlier submission (Bug #494219) and when the submitter of that one lost interest I had a go at packaging it myself (Bug #518046). There may be some mileage in merging our efforts actually. First looks: * shouldn't the tarball name have _r5836 rather than _r0? * is the git-core dependency a remnant of starting with the spec file for the git plugin, or is there some actual reason for having it? * the package description could list a few extra features such as allowing users to change their passwords * the setuptools regression mentioned in the comments has been fixed in F-11 so that comment could be removed * there is a patch available in svn trunk for http://trac-hacks.org/ticket/4125 (it's in my package from Bug #518046). * please include sessionstore_convert.py script (see http://www.mailinglistarchive.com/trac-us...@googlegroups.com/msg03696.html) * it's safe to use --skip-build as EPEL-4 doesn't have trac = 0.11 so there's not likely to be an EL-4 branch of this package * the noarch/sitelib comment from the python spec file template can be dropped I think -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518219
Andrew Overholt overh...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||overh...@redhat.com
AssignedTo|nob...@fedoraproject.org|overh...@redhat.com
Flag||fedora-review?
--- Comment #2 from Andrew Overholt overh...@redhat.com 2009-08-19 11:43:26
EDT ---
- change the groups to make rpmlint quiet
- md5sum of source doesn't match but contents do
- you can remove the post{,un} requirements for javadoc
- there are two sections to SimpleSmtpServer.java; I'd like to see the first
one go upstream or at least be discussed with upstream. I won't block on this.
Otherwise, things are good to go
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470293] Review Request: sblim-cmpi-network - SBLIM Network Instrumentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470293 --- Comment #13 from Vitezslav Crhonek vcrho...@redhat.com 2009-08-19 11:43:46 EDT --- I'm looking for volunteers to go through Review Request of few other sblim-* packages, so if anyone is interested, feel free to take them;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518233] Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518233 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks||429551 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-08-19 11:47:09 EDT --- This is a full review request. The pre-review request was bug #500254. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518233] New: Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jakarta-commons-jxpath - Simple XPath interpreter https://bugzilla.redhat.com/show_bug.cgi?id=518233 Summary: Review Request: jakarta-commons-jxpath - Simple XPath interpreter Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: akurt...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://akurtakov.fedorapeople.org/jakarta-commons-jxpath.spec SRPM URL: http://akurtakov.fedorapeople.org/jakarta-commons-jxpath-1.2-7.fc12.src.rpm Description: Defines a simple interpreter of an expression language called XPath. JXPath applies XPath expressions to graphs of objects of all kinds: JavaBeans, Maps, Servlet contexts, DOM etc, including mixtures thereof. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518238] Review Request: backport-util-concurrent - Backport of java.util.concurrent API, introduced in Java 5.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518238 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Blocks||429551 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518238] New: Review Request: backport-util-concurrent - Backport of java.util.concurrent API, introduced in Java 5.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: backport-util-concurrent - Backport of java.util.concurrent API, introduced in Java 5.0 https://bugzilla.redhat.com/show_bug.cgi?id=518238 Summary: Review Request: backport-util-concurrent - Backport of java.util.concurrent API, introduced in Java 5.0 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: overh...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://overholt.fedorapeople.org/backport-util-concurrent.spec SRPM URL: http://overholt.fedorapeople.org/backport-util-concurrent-3.1-2.src.rpm Description: This package is the backport of java.util.concurrent API, introduced in Java 5.0, to Java 1.4. The backport is based on public-domain sources from the JSR 166 CVS repository, and the dl.util.concurrent package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501576] Review Request: python-repoze-what-quickstart - A plugin enabling a simple authentication system with repoze.who and repoze.what
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501576 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA Bug 501576 depends on bug 476789, which changed state. Bug 476789 Summary: Review Request: python-repoze-what - Authorization for WSGI applications https://bugzilla.redhat.com/show_bug.cgi?id=476789 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2009-08-19 11:58:48 EDT --- python-repoze-what-quickstart-1.0-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-repoze-what-quickstart'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0316 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518233] Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518233 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||overh...@redhat.com AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review+ --- Comment #2 from Andrew Overholt overh...@redhat.com 2009-08-19 12:05:02 EDT --- - extra spaces interspersed in %description - md5sums are different but contents are the same - svn revision I got was different # ... perhaps we should just remove that comment - licensing, naming fine - locations fine - rpmlint clean (except for maven fragment in /etc) - we should go to 1.3 ASAP but I can understand the strict need for 1.2 to get maven updated Please fix those minor things. Review approved since they're not blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #29 from Adam Williamson awill...@redhat.com 2009-08-19 12:30:03 EDT --- RTFReadme :) [ad...@adam ~]$ cat /usr/share/doc/navit-0.1.1/README.fedora Navit comes with a sample map of Munich, but if you live (or drive!) anywhere else, you'll need to add another map set. These are not available as packages because they're rather large and the data changes on a daily basis, so the packages would have to be refreshed very often. For instructions on downloading or generating, and installing, different types of map sets, see these Navit Wiki pages: http://wiki.navit-project.org/index.php/OpenStreetMaps http://wiki.navit-project.org/index.php/European_maps http://wiki.navit-project.org/index.php/Garmin_maps You should either add the appropriate configuration elements to /etc/navit/navit.xml, or copy /etc/navit/navit.xml to ~/.navit/navit.xml and edit it there. You may have to remove or comment out the section for the sample map set, also. Also note that the default configuration assumes you have a GPS device active, and gpsd running. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tcall...@redhat.com AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com Flag||fedora-review+ --- Comment #6 from Tom spot Callaway tcall...@redhat.com 2009-08-19 13:44:20 EDT --- Two items of note: 1. Instead of using sed to try to stop configure from running twice (it doesn't work), do this: # run autogen.sh until we have a proper release, but don't run configure twice. NOCONFIGURE=true ./autogen.sh That works because the provided autogen.sh just calls out to gnome-autogen.sh, which has some intelligence. 2. Do you want to pass --enable-scaled-background to configure? == Review == Good: - rpmlint checks return: mutter-moblin.x86_64: W: shared-lib-calls-exit /usr/lib64/libmoblin-panel.so.0.0.0 e...@glibc_2.2.5 mutter-moblin-devel.x86_64: W: no-documentation mutter-moblin-devel.x86_64: W: dangling-relative-symlink /usr/lib64/mutter/plugins/moblin-netbook.so moblin-netbook.so.3400.0.0 All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (c781f9a6558167658fc7891d1ba8c041db1a75113ef220441c05f11a877436ed) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Address the first two issues before commit, but this is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472658] Review Request: shmpps - Shared Memory driver for PPS signals
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472658 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 14:33:15 EDT --- Looks good to me; still builds fine, and the issues I found are fixed. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510822] Review Request: maloc - Minimal Abstraction Layer for Object-oriented C/C++ programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510822 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 14:49:15 EDT --- OK, builds fine, rpmlint is as previously discussed above and the versioning loooks good to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Peter Robinson pbrobin...@gmail.com 2009-08-19 14:58:07 EDT --- New Package CVS Request === Package Name: mutter-moblin Short Description: Moblin Netbook plugin for Mutter Owners: pbrobinson Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 --- Comment #7 from Peter Robinson pbrobin...@gmail.com 2009-08-19 14:55:02 EDT --- Two items of note: 1. Instead of using sed to try to stop configure from running twice (it doesn't work), do this: # run autogen.sh until we have a proper release, but don't run configure twice. NOCONFIGURE=true ./autogen.sh That works because the provided autogen.sh just calls out to gnome-autogen.sh, which has some intelligence. Thanks. That is very good to know, I've seen so many different work arounds its hard to know which is best. 2. Do you want to pass --enable-scaled-background to configure? I was discussing that one last night with someone, I agree I think its the best option. I will update them both before commit. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515081 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 15:08:08 EDT --- Did you want to somehow update this package to include the proper licensing information? Either the updated source with proper licensing information or the email from the author clarifying the license needs to make it into the package. If I download the srpm from comment #3, and just look at what's in the package, the licensing situation is still unclear. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516114] Review Request: trac-accountmanager-plugin - Trac plugin for account registration and management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516114 --- Comment #3 from Ben Boeckel maths...@gmail.com 2009-08-19 14:52:12 EDT --- I'll merge out spec files this week. Patches, description, and cleaning useless comments. And the git BR is due to starting from the git plugin ;) . It'll be gone next round. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||lemen...@gmail.com Flag||needinfo?(akurt...@redhat.c ||om) --- Comment #6 from Peter Lemenkov lemen...@gmail.com 2009-08-19 15:19:11 EDT --- I don't understand - what's happening here? I saw that this package was already reviewed and even imported into CVS tree (as well as these two - #518219 and #518233 ). Why you created another Review Request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|needinfo?(akurt...@redhat.c | |om) | --- Comment #8 from Andrew Overholt overh...@redhat.com 2009-08-19 15:25:19 EDT --- Unsetting flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #7 from Andrew Overholt overh...@redhat.com 2009-08-19 15:24:59 EDT --- See comment #1: This is a full review request. The pre-review request was bug #500253. In an attempt to get maven updated, it was deemed necessary to pre-review some packages for bootstrapping purposes. We've decided to speed up the actual process by doing full reviews on packages that don't need this initial step. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515081 --- Comment #9 from Pierre-YvesChibon pin...@pingoured.fr 2009-08-19 15:28:46 EDT --- There is a new upstream release that correct the license issue There are the updated version: Spec URL: http://pingou.fedorapeople.org/RPMs/R-affy.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/R-affy-1.22.1-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513320] Review Request: boxbackup - A fast, secure and automatic online backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513320 --- Comment #1 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 15:33:34 EDT --- This fails to build for me: + test -e configure + ./bootstrap ./bootstrap: line 3: aclocal: command not found ./bootstrap: line 4: autoheader: command not found ./bootstrap: line 5: autoconf: command not found Looks like missing dependencies. Scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=1615423 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508922 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 15:45:08 EDT --- I'm sorry that nobody has looked at this; we have far more review submissions than reviewers, and far too much traffic for anyone to actually follow all of the bugzilla mail. Posting to fedora-devel or dropping by #fedora-devel and requesting help is the best means of getting something time-sensitive noticed. However, I tried to take a look, but the package failed to build for me. It looks like the makefile calls restorecon, which is not only a really bad idea since I don't think it works as a regular user and there's no guarantee that the build filesystem supports contexts (think my home dir and NFS). But I think that it actually fails because policycoreutils isn't installed as nothing in the package actually requires it. Here's a scratch build showing the failure: http://koji.fedoraproject.org/koji/taskinfo?taskID=1615432 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518310] Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518310 --- Comment #1 from Andrew Overholt overh...@redhat.com 2009-08-19 15:46:49 EDT --- Note that this is a full review request. The pre-review request (which has already been granted and the package imported into CVS) is bug #500246. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518310] New: Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework https://bugzilla.redhat.com/show_bug.cgi?id=518310 Summary: Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: overh...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://overholt.fedorapeople.org/plexus-classworlds.spec SRPM URL: http://overholt.fedorapeople.org/plexus-classworlds-1.2-0.a9.6.fc11.src.rpm Description: Classworlds is a framework for container developers who require complex manipulation of Java's ClassLoaders. Java's native ClassLoader mechanims and classes can cause much headache and confusion for certain types of application developers. Projects which involve dynamic loading of components or otherwise represent a 'container' can benefit from the classloading control provided by classworlds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518310] Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518310 --- Comment #2 from Andrew Overholt overh...@redhat.com 2009-08-19 15:51:01 EDT --- Updated: Spec URL: http://overholt.fedorapeople.org/plexus-classworlds.spec SRPM URL: http://overholt.fedorapeople.org/plexus-classworlds-1.2-0.a9.7.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515081 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 15:56:33 EDT --- That fails to compile for me. gcc -m64 -std=gnu99 -I/usr/include/R -DHAVE_ZLIB=1 -I/usr/local/include -I/usr/lib64/R/library/preprocessCore/include -fpic -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c rma2.c -o rma2.o rma2.c:109:29: error: rma_background4.h: No such file or directory rma2.c:120:45: error: preprocessCore_background_stubs.c: No such file or directory rma2.c:121:48: error: preprocessCore_normalization_stubs.c: No such file or directory rma2.c:122:48: error: preprocessCore_summarization_stubs.c: No such file or directory rma2.c:124:31: error: R_subColSummarize.h: No such file or directory rma2.c:125:37: error: R_subColSummarize_stubs.c: No such file or directory rma2.c: In function 'do_RMA2': rma2.c:134: warning: implicit declaration of function 'R_subColSummarize_medianpolish_log' rma2.c:134: warning: assignment makes pointer from integer without a cast rma2.c: In function 'rma_c_call': rma2.c:186: warning: implicit declaration of function 'qnorm_c' rma2.c: In function 'rma_c_complete': rma2.c:247: warning: implicit declaration of function 'rma_bg_correct' make: *** [rma2.o] Error 1 ERROR: compilation failed for package 'affy' Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1615456 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515081 --- Comment #11 from Pierre-YvesChibon pin...@pingoured.fr 2009-08-19 16:15:07 EDT --- Damn stupid mistake... I forgot to use R-preprocessCore-devel in the BR. Corrected in : Spec URL: http://pingou.fedorapeople.org/RPMs/R-affy.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/R-affy-1.22.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518315] New: Review Request: vanessa_logger - Generic logging layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vanessa_logger - Generic logging layer https://bugzilla.redhat.com/show_bug.cgi?id=518315 Summary: Review Request: vanessa_logger - Generic logging layer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pa...@hubbitus.info QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger-0.0.7-2.fc11.src.rpm Description: Generic logging layer that may be used to log to one or more of syslog, an open file handle or a file name. Though due to limitations in the implementation of syslog opening multiple syslog loggers doesn't makes sense. Includes the ability to limit which messages will be logged based on priorities. http://koji.fedoraproject.org/koji/taskinfo?taskID=1615499 build done. P.S. In spec used 5 space tab width. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518315] Review Request: vanessa_logger - Generic logging layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518315 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Blocks||518316 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518316] Review Request: vanessa_adt - Library of Abstract Data Types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518316 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Depends on||518315 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518316] New: Review Request: vanessa_adt - Library of Abstract Data Types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vanessa_adt - Library of Abstract Data Types https://bugzilla.redhat.com/show_bug.cgi?id=518316 Summary: Review Request: vanessa_adt - Library of Abstract Data Types Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pa...@hubbitus.info QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt-0.0.7-3.fc11.src.rpm Description: Library of Abstract Data Types (ADTs) that may be useful. Includes queue, dynamic array and key value ADT. P.S. In spec used 5 space tab width. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518317] New: Review Request: perdition - Mail Retrieval Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perdition - Mail Retrieval Proxy https://bugzilla.redhat.com/show_bug.cgi?id=518317 Summary: Review Request: perdition - Mail Retrieval Proxy Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pa...@hubbitus.info QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hubbitus.net.ru/rpm/Fedora11/perdition/perdition.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/perdition/perdition-1.17.1-2.fc11.src.rpm Description: Perdition is a fully featured POP3 and IMAP4 proxy server. It is able to handle both SSL and non-SSL connections and redirect users to a real-server based on a database lookup. Perdition supports modular based database access. ODBC, MySQL, PostgreSQL, GDBM, POSIX Regular Expression and NIS modules ship with the distribution. The API for modules is open allowing arbitrary modules to be written to allow access to any data store. Perdition can be used to: Create large mail systems where a users mailbox may be stored on one of several hosts. Integrate different mail systems together. Migrate between different email infrastructure. And in firewall P.S. In spec used 5 space tab width. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518318] Review Request: vanessa_socket - Simplify TCP/IP socket operations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518318 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Blocks||518317 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518316] Review Request: vanessa_adt - Library of Abstract Data Types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518316 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Blocks||518317 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518317] Review Request: perdition - Mail Retrieval Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518317 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Depends on||518315, 518318, 518316 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518315] Review Request: vanessa_logger - Generic logging layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518315 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Blocks||518317 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518318] Review Request: vanessa_socket - Simplify TCP/IP socket operations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518318 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Depends on||518315 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518315] Review Request: vanessa_logger - Generic logging layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518315 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Blocks||518318 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518318] New: Review Request: vanessa_socket - Simplify TCP/IP socket operations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vanessa_socket - Simplify TCP/IP socket operations https://bugzilla.redhat.com/show_bug.cgi?id=518318 Summary: Review Request: vanessa_socket - Simplify TCP/IP socket operations Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pa...@hubbitus.info QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.7-2.fc11.src.rpm Description: Library to simplify TCP/IP socket operations. Includes code to open a socket to a server as a client, to listen on socket for clients as a server and to pipe information between sockets. P.S. In spec used 5 space tab width. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507849] Review Request: anjal - email client for small screen devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507849 --- Comment #10 from Michel Alexandre Salim michael.silva...@gmail.com 2009-08-19 16:55:21 EDT --- Approved -- make sure to fix the changelog entry when importing into the repository -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507849] Review Request: anjal - email client for small screen devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507849 Michel Alexandre Salim michael.silva...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|michael.silva...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507849] Review Request: anjal - email client for small screen devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507849
Michel Alexandre Salim michael.silva...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||michael.silva...@gmail.com
Flag||fedora-review+
--- Comment #9 from Michel Alexandre Salim michael.silva...@gmail.com
2009-08-19 16:53:52 EDT ---
Review:
• rpmlint: source clean. binary has one warning: changelog incoherent
anjal.x86_64: W: incoherent-version-in-changelog 0.1.0-0.3
['0.1.0-0.4.20090813git2d4e6a0.fc12', '0.1.0-0.4.20090813git2d4e6a0']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines:
valid but bizarre (author does not trust FSF enough to use LGPLv2+ ?)
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK
• builds under = 1 archs, others excluded: OK (Koji)
• build dependencies complete: OK (Koji)
• locales handled using %find_lang, no %{_datadir}/locale: OK
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• desktop file uses desktop-file-install: desktop-file-validate, OK
• clean buildroot before install: OK
• filenames UTF-8: OK
SHOULD
• package build in mock on all architectures: OK (Koji)
• package functioned as described: OK (tested on x86_64)
• scriplets are sane: OK
• require package not files: OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506174] Review Request: qtdmm - a digital multimeter readout software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506174 Andrew Zabolotny anp...@mail.ru changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Andrew Zabolotny anp...@mail.ru 2009-08-19 16:56:36 EDT --- New Package CVS Request === Package Name: QtDMM Short Description: QtDMM is a DMM readout software including a configurable recorder. Owners: zap Branches: F-10 F-11 InitialCC: chitlesh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517641 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||182235(FE-Legal) AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review? --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 17:00:01 EDT --- I have to agree with Christof here; the channel itself doesn't have any specific PHP version dependency, and it's foolish to try and track whatever might get added to the channel to somehow extract that information. Besides, no supported Fedora release has anything older than php 5.2.6, so the guidelines indicate that we shouldn't have a versioned dependency in any case. What troubles me is where you found an MIT license for the content in this package. I would tend to lean towards the one small XML file in this package being non-copyrightable data, but then the fedora-bookmarks just has a list of URLs and it carries the GFDL license, so I guess it's good that I'm not a lawyer. Doctrine itself is LGPLv2+. I guess I'll block FE-Legal for an opinion, but you could just clear this up if you just ask upstream for some indication of the license of the channel file. (Actually what really bothers me is that we have to be so anal about this, but that's the way it is.) In any case, this is the epitome of a trivial package. I'd approve it if the license issue were cleared up one way or the other. * source file matches upstream. sha256sum: 215215f50b339b89d72b15cfa0273728dd2ba397c7d300c51a785f8223f4cdbc channel.xml * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. ? license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints (no-documentation). * final provides and requires are sane: php-channel(pear.doctrine-project.com) php-channel-doctrine = 1.0.0-1.fc12 = /bin/sh /usr/bin/pear php-cli php-pear(PEAR) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets are OK (pear channel registration) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429483] Review Request: o3read - Standalone converter for OpenOffice.org documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=429483 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 17:03:44 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #59 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 17:05:07 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507849] Review Request: anjal - email client for small screen devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507849 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Peter Robinson pbrobin...@gmail.com 2009-08-19 17:05:07 EDT --- Thanks! New Package CVS Request === Package Name: anjal Short Description: An email client for small screen devices Owners: pbrobinson Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514634] Review Request: gpxviewer - A simple gpx viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514634 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-08-19 17:08:03 EDT --- I do not have the power to remove the old import. I've asked an admin to do it, and it should be gone soon. I've set up the new module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
