[Bug 541978] Review Request: pulseaudio-equalizer - PulseAudio Equalizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541978
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||lkund...@v3.sk
AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk
Flag||fedora-review?
--- Comment #4 from Lubomir Rintel lkund...@v3.sk 2009-12-20 04:11:20 EDT ---
Hicham, this looks useful and you've done a good job packing this,
unfortunately upstream knows dick about properly maintaining a project. I'm
still willing to review this, but am hesitant to approve it until upstream's
problems that make it impossible to do a proper review are gone.
Legend:
* good
- bad
ॐ wtf
* Package is named properly
* Version correct and matches upstream
ॐ Can't verify if sources match, could not download it
(see below)
* License is ok
ॐ License is present in source tarball and installed as %doc
(see below)
- Spec file is clean and legible
In fact it mostly is, just have to get rid of that pre-%setup voodoo in %prep
- Does not build
Enough said above. What you do in %prep is not only unnecessary, but also
totally sick. In my case it BUILD/usr in the package and deleted it :) Please,
never do anything outside your %{buildsubdir}. Unpack the other sources under
it and if necessary create additional top-level directory with %setup -c.
* Filelist sane
* Requires/provides sane
Action points:
Please ask upstream for anonymously accessible address of tarball which they
use to produce their .debs, eventually publish them unless they already do.
Please ensure that tarball contains a license file.
I believe a sane source tarball would make the %prep shit unnecessary.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 541978] Review Request: pulseaudio-equalizer - PulseAudio Equalizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541978 --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2009-12-20 04:19:20 EDT --- Two more issues: 1.) This file name is not nice: /usr/bin/pulseaudio-equalizer.sh How about stripping .sh? 2.) According to FHS, proper place for user commands is /usr/bin. Exec=/usr/share/pulseaudio-equalizer/pulseaudio-equalizer.py How about making /usr/bin/pulseaudio-equalizer-gui wrapper or something like that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 547974] Review Request: ibus-skk - Japanese Simple Kana Kanji IME for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547974 --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20 04:18:34 EDT --- (In reply to comment #3) then each time I type ka, nn, ji each string is changed immediately to か ん then じ, and no kanji conversion by space bar works... That is expected behavior. To start kana-kanji conversion in SKK, you need to type first few letters in uppercase. For the above example, try Kannji or KAnnji instead of kannji, and then type space. Ah, thank you for explanation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520322] Review Request: mm-common - common files for GNOME C++ bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520322 Daniel Elstner daniel.ki...@gmail.com changed: What|Removed |Added CC||daniel.ki...@gmail.com --- Comment #22 from Daniel Elstner daniel.ki...@gmail.com 2009-12-20 05:23:22 EDT --- (In reply to comment #1) * License - As http://gcc.gnu.org/onlinedocs/libstdc++/ says libstdc++ documents are under GFDL, the license tag should be GPLv2+ and GFDL. No, the API reference documentation is released under the same license as the libstdc++ source code. It's not made very visible: http://gcc.gnu.org/onlinedocs/libstdc++/manual/bk01pt01ch01s02.html See the bottom of the page. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520322] Review Request: mm-common - common files for GNOME C++ bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520322 --- Comment #24 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20 06:34:07 EDT --- (In reply to comment #23) Please don't comment such a thing on review request bugs closed more than one months ago and open a new bug against mm-common instead. Actually more than 3 months ago. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520322] Review Request: mm-common - common files for GNOME C++ bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520322 --- Comment #23 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20 06:31:27 EDT --- Please don't comment such a thing on review request bugs closed more than one months ago and open a new bug against mm-common instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell chalmers-lava2000 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #1 from Shakthi Kannan shakthim...@gmail.com 2009-12-20 07:25:43 EDT --- * Created patch to remove verification modules in build that use wrapper scripts that require, and invoke third party non-free binaries. * Remove Scripts/ folder. * Wrote README.fedora and removed default README. Spec URL: http://shakthimaan.fedorapeople.org/SPECS/ghc-chalmers-lava2000.spec SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/ghc-chalmers-lava2000-1.1.1-1.fc12.src.rpm Successful Koji builds for F-11, F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1881728 http://koji.fedoraproject.org/koji/taskinfo?taskID=1881732 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479527] Review Request: synfigstudio - Vector-based 2D animation studio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479527 --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2009-12-20 08:08:43 EDT --- Hicham, please don't close review requests that haven't been completed (i.e. the package is not yet imported and built). This was built just now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #8 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:11:18 EDT --- Updated %define - %global New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533725] Review Request: rubygem-linecache - Caches (Ruby source) files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533725 Jeroen van Meeuwen kana...@kanarip.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:06:26 EDT --- New Package CVS Request === Package Name: rubygem-linecache Short Description: Caches (Ruby source) files Owners: kanarip Branches: EL-5 F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532309] Review Request: rubygem-ruby-net-ldap - A full-featured pure-Ruby LDAP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532309 Jeroen van Meeuwen kana...@kanarip.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:12:33 EDT --- New Package CVS Request === Package Name: rubygem-ruby-net-ldap Short Description: A full-featured pure-Ruby LDAP client Owners: kanarip Branches: EL-5 F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530198] Review Request: rubygem-columnize - Sorts an array in column order
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530198 Jeroen van Meeuwen kana...@kanarip.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:14:04 EDT --- New Package CVS Request === Package Name: rubygem-columnize Short Description: Sorts an array in column order Owners: kanarip Branches: EL-5 F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530193] Review Request: rubygem-calendar_date_select - A popular date picker widget for ruby on rails and prototype.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530193 --- Comment #2 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:33:41 EDT --- New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-calendar_date_select.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-calendar_date_select-1.15-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 547993] Package Name Change: jconvolver - Real-time Convolution Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547993 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20 11:40:51 EDT --- Well, ? About Source1: - I checked http://www.kokkinizita.net/linuxaudio/downloads/index.html , however the license of Source1 seems unclear. Would you ask upstream? - While Source0 is 128K, Source1 has 6.0M (50 times the size of Source1) and as a result while jconvolver binary rpm has 6.4M its debuginfo rpm has only 48K. Is Source2 always needed for jconvolver? Also are there any reason behind that jconvolver and -reverbs are not seperately packaged (into rpm)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530021] Review Request: moovida - Media Center
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530021 Valent Turkovic valent.turko...@gmail.com changed: What|Removed |Added CC||valent.turko...@gmail.com --- Comment #31 from Valent Turkovic valent.turko...@gmail.com 2009-12-20 14:45:16 EDT --- Can't wait to install Moovida on Fedora 12! When do you expect rpms to be available in Fedora repos? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20
15:06:52 EDT ---
Created an attachment (id=379509)
-- (https://bugzilla.redhat.com/attachment.cgi?id=379509)
Patch for ruby-debug to use system-wide -base and test fix
Ah...
(In reply to comment #3)
(In reply to comment #2)
(In reply to comment #1)
- Please create one srpm per one gem.
These gems do not distribute very well separately, they have the same
upstream
and one requires the other in a %{version}-%{release} specific manner.
- Ah, I checked two gems and actually dependency is in loop...
Well, I checked these two gems' dependency again and actually
ruby-debug-base does not require ruby-debug
( ruby-debug-base-0.10.3/test/base/base.rb has require 'ruby_debug'
for example, but this is satisfied by ruby_debug.so in ruby-debug-base
(and not by ruby-debug.rb in ruby-debug gem) )
Also rake test under ruby-debug-base succeeds without ruby-debug
gem. So still ruby-debug-base and ruby-debug should be packaged seperately.
(ruby-debug-base does not depend on ruby-debug but ruby-debug does depend
on ruby-debug-base)
For ruby-debug, currently your spec file contains:
-
99 %check
100 pushd %{_builddir}/%{name}-%{version}/%{geminstdir2}
101 rake -f ../ruby-debug-0.10.3/Rakefile test
-
This skips many tests, because ruby-debug Rakefile contains
-
27 CLI_TEST_FILE_LIST = FileList['test/cli/commands/unit/*.rb',
28'test/cli/commands/*_test.rb',
29'test/cli/**/*_test.rb',
30'test/test-*.rb']
61 t.test_files = CLI_TEST_FILE_LIST
--
however many of these files cannot be detected if the working
directory is ./%{geminstdir2}, not ./%{geminstdir}.
rake test for ruby-debug should be done under .%{geminstdir}.
Note that when executing rake test correctly under ./%{geminstdir}
many tests fail and patch is needed (attached). After applying patch:
---
[tasa...@localhost ruby-debug-0.10.3]$ rake test
(in
/home/tasaka1/rpmbuild/Reviewing/rubygem-related/rubygem-ruby-debug/rubygem-ruby-debug-0.10.3-4.fc12.src/TMP2/DEBUGINSTDIR/gems/ruby-debug-0.10.3)
ruby_debug already installed, skipping creating shared library extension
/usr/bin/ruby -Ilib:./ext:./lib
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb
test/base/base.rb test/base/binding.rb test/base/catchpoint.rb
Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
.
Finished in 0.003895 seconds.
5 tests, 30 assertions, 0 failures, 0 errors
/usr/bin/ruby -Ilib:./ext:./lib:./cli
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb
test/cli/commands/unit/regexp.rb test/cli/commands/catchpoint_test.rb
test/cli/commands/catchpoint_test.rb test/test-edit.rb test/test-info.rb
test/test-source.rb test/test-annotate.rb test/test-ctrl.rb
test/test-list.rb test/test-catch.rb test/test-save.rb
test/test-info-thread.rb test/test-emacs-basic.rb test/test-quit.rb
test/test-init.rb test/test-method.rb test/test-info-var.rb
test/test-output.rb test/test-trace.rb test/test-setshow.rb
test/test-help.rb test/test-hist.rb test/test-raise.rb
test/test-breakpoints.rb test/test-finish.rb test/test-stepping.rb
test/test-frame.rb test/test-condition.rb test/test-enable.rb
test/test-display.rb test/test-dollar-0.rb test/test-break-bad.rb
test/test-pm.rb
Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
.Skipping method sig test
..
Finished in 18.947538 seconds.
35 tests, 46 assertions, 0 failures, 0 errors
---
Currently only the first 5 tests are executed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549189] New: Review Request: Djagios - Djagios is an open source Nagios web based configuration tool with a co mplete Python Nagios API..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Djagios - Djagios is an open source Nagios web based configuration tool with a co mplete Python Nagios API.. https://bugzilla.redhat.com/show_bug.cgi?id=549189 Summary: Review Request: Djagios - Djagios is an open source Nagios web based configuration tool with a co mplete Python Nagios API.. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kris.buyta...@inuits.be QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.krisbuytaert.be/download/djagios.spec SRPM URL: http://www.krisbuytaert.be/download/djagios-0.1.3-1.src.rpm Description: Djagios is an open source Nagios web based configuration tool with a complete Py thon Nagios API. The main goal of the tool was to make Nagios usable for non-Nagios admins. The i nitial install and configuration would have to be done by Nagios administrators. But once done ordinary users can add servers, appliances, devices, services the mselves. Note: This is my first package ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549189] Review Request: Djagios - Djagios is an open source Nagios web based configuration tool with a co mplete Python Nagios API..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549189 Kris Buytaert kris.buyta...@inuits.be changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532813] Review Request: gummi - A simple LaTeX editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532813 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2009-12-20 15:52:54 EDT --- Thanks for your comments guys Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gummi.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gummi-0.4.2-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510376] Review Request: bluemodem - A bluetooth modem configuration utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510376 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag|needinfo?(fab...@bernewirel | |ess.net)| --- Comment #4 from Fabian Affolter fab...@bernewireless.net 2009-12-20 15:52:31 EDT --- Thanks for your patience. Here are the new files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/bluemodem.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/bluemodem-0.7-2.fc12.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882151 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549198] New: Review Request: python-jabberbot - A simple jabber (XMPP) bot framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-jabberbot - A simple jabber (XMPP) bot framework https://bugzilla.redhat.com/show_bug.cgi?id=549198 Summary: Review Request: python-jabberbot - A simple jabber (XMPP) bot framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-jabberbot.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-jabberbot-0.8-1.fc12.src.rpm Project URL: http://thpinfo.com/2007/python-jabberbot/ Description: This is python-jabberbot, a Jabber bot framework for Python that enables you to easily write simple Jabber bots. You can use your Jabber bots to provide information about your running systems, to make your website interact with your visitors or notify you about updates or changes you monitor with your Python scripts. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882194 rpmlint output: [...@localhost noarch]$ rpmlint python-jabberbot-0.8-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@localhost SRPMS]$ rpmlint python-jabberbot-0.8-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 541978] Review Request: pulseaudio-equalizer - PulseAudio Equalizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541978 --- Comment #6 from Hicham HAOUARI hicham.haou...@gmail.com 2009-12-20 17:09:02 EDT --- I just mailed the author and he told me that he won't put the sources in his launchpad account until mid january. And by the way, there seems to be a better equalizer which doesn't depend on ladspa in upstream pulseaudio : http://pulseaudio.org/wiki/SystemEqualizer, but this one has a Qt interface only. I am wondering if i should go with this package if upstream do have better solutions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548180] Review Request: hostapd - IEEE 802.11 AP, IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548180 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #15 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-12-20 17:12:04 EDT --- I wasn't able to use hostapd with the nl80211 driver on Fedora 11, but everything went fine for Fedora 12 using an atheros hardware. (none work with intel and a iwl3945 driver) This package (hostapd) is APPROVED by me -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530021] Review Request: moovida - Media Center
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530021 --- Comment #32 from Alex Lancaster al...@users.sourceforge.net 2009-12-20 17:22:19 EDT --- (In reply to comment #31) Can't wait to install Moovida on Fedora 12! When do you expect rpms to be available in Fedora repos? Only once Matthias has approved the package (which hopefully will be soon) and agreed to sponsor Graeme (which he appears to be willing to do), then the package can be built. The bottleneck is now getting Matthias' final approval, until then be patient Valent. Matthias: could you please set the review flag and ASSIGN to bug to yourself to indicate that you are actively doing the review as per the standard practice of reviewing? If you find yourself unable to finish this off in timely fashion (say within the next week or so, since it's already been 2 weeks since you initiated the review), please let us know and we can recommence the search for a new sponsor. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 547993] Package Name Change: jconvolver - Real-time Convolution Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547993 --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-12-20 17:20:39 EDT --- Thanks Mtasaka, (In reply to comment #4) Well, ? About Source1: - I checked http://www.kokkinizita.net/linuxaudio/downloads/index.html , however the license of Source1 seems unclear. Would you ask upstream? Sure. I just asked upstream via email. - While Source0 is 128K, Source1 has 6.0M (50 times the size of Source1) and as a result while jconvolver binary rpm has 6.4M its debuginfo rpm has only 48K. Is Source2 always needed for jconvolver? Also are there any reason behind that jconvolver and -reverbs are not seperately packaged (into rpm)? Ah, this is the way we used to package jconv. It is a packager's choice in some sense. Let me elaborate: Imagine that you are packaging an office package. The office software makes use of fonts that are under a special format that can only be opened from this particular office software. Of course the software can operate without these fonts but it is 50 times more functional if it these fonts were available. :) It is almost the same situation with jconv(olver). We can put these in a subpackage. But given the target audience is really limited to enthusiasts and these reverbs aren't updated independently from jconv(olver) software, it is not beneficial to make a subpackage (or a separate package). This package came from PlanetCCRMA. We didn't receive any user complaints about the size all this time either here or at PlanetCCRMA list. Therefore I decided to keep things the way they were for consistency. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542463] Review Request: zaz - A puzzle game where the player has to arrange balls in triplets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Xavier Bachelot xav...@bachelot.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|xav...@bachelot.org
Flag||fedora-review+
--- Comment #2 from Xavier Bachelot xav...@bachelot.org 2009-12-20 17:46:05
EDT ---
OK: spec file is properly named
OK: package is properly named
OK: Spec is legible
NOK: use of macros is consistent
OK: tarball match upstream :
d0e625ee9b8d4823955686048ac69d0a zaz-0.3.0.tar.gz
OK: License field match the actual license and is acceptable
Ok: BuildRoot is correct
OK: BuildRequires and Requires are correct
OK: no bundled copied of libraries
OK: Desktop file is validated and installed
OK: scriplets are correct.
OK: locales are properly handled
OK: defattr is correct
OK: %doc is correct
Ok: builds in mock
OK: all files and directories are properly packaged
Ok: doesn't own dirs it shouldn't
OK: files/dirs perms are correct
OK; rpmlint output is clean ;
zaz.i686: W: dangling-symlink /usr/share/zaz/FreeSans.ttf
/usr/share/fonts/gnu-free/FreeSans.ttf
zaz.i686: W: dangling-symlink /usr/share/zaz/font1.ttf
/usr/share/fonts/oflb-dignas-handwriting/phranzysko_-_Digna_s_Handwriting.ttf
zaz.i686: W: dangling-symlink /usr/share/zaz/FreeMonoBold.ttf
/usr/share/fonts/gnu-free/FreeMonoBold.ttf
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
These 3 are expected and can be ignored.
Ok: final provides and requires are correct
Note :
typo in %prep section :
# Fix premissions
^^
Please fix use of macros, there is a spurious %{buildroot} when installing the
icon, then this package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518315] Review Request: vanessa_logger - Generic logging layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518315 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-12-20 17:51:40 EDT --- vanessa_logger-0.0.8-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/vanessa_logger-0.0.8-5.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518318] Review Request: vanessa_socket - Simplify TCP/IP socket operations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518318 --- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-12-20 17:53:36 EDT --- (In reply to comment #3) Hello, Version 0.0.7 seems to be a bit out of date; 0.0.10 is out. Also, the Source0 line is not accessible (no ftp anymore). You are rigth. Updated. http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.10-5.fc11.src.rpm http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket.spec Why tabsize of 5? It just seems non-standard :) Don't suppose I could convince you to use 4 or 8 or to just use spaces? Do we really need that ugly looking thing above the %configure? https://fedoraproject.org/wiki/PavelAlexeev/tabsize -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436612] Review Request: avfs - A Virtual File System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=436612 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436612] Review Request: avfs - A Virtual File System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=436612
Tony Fu t...@redhat.com changed:
What|Removed |Added
Flag|needinfo+ |
Lorenzo Villani lvill...@binaryhelix.net changed:
What|Removed |Added
Keywords||Reopened
Status|CLOSED |ASSIGNED
CC||lvill...@binaryhelix.net
Blocks|201449(FE-DEADREVIEW) |
Resolution|NOTABUG |
--- Comment #5 from Lorenzo Villani lvill...@binaryhelix.net 2009-12-20
18:09:35 EDT ---
Since I am interested in packaging worker (avfs is one of its dependencies) I
am reopening this.
SPEC URI: http://gitorious.org/lvillani/specs/trees/master/avfs
SRPM URI: http://fedorapeople.org/~arbiter/avfs/
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882296
rpmlint output:
[lvill...@enterprise avfs (master)]$ rpmlint avfs.spec
../../srpms/avfs-0.9.8-1.fc12.src.rpm
../../rpms/x86_64/{avfs-0.9.8-1.fc12.x86_64.rpm,avfs-debuginfo-0.9.8-1.fc12.x86_64.rpm,avfs-devel-0.9.8-1.fc12.x86_64.rpm}
avfs-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.
Notes: 'documentation' (license and readme files) is included in the main
package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542740] Review Request: f2c - Fortran to C/C++ conversion program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542740 --- Comment #43 from Carl Byington c...@five-ten-sg.com 2009-12-20 18:27:38 EDT --- done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549198] Review Request: python-jabberbot - A simple jabber (XMPP) bot framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Thomas Spura toms...@fedoraproject.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||toms...@fedoraproject.org
AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org
Flag||fedora-review+
--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2009-12-20
18:32:19 EDT ---
Review:
Good:
- name ok
- %files section ok
- permissions ok
- rpmlint clean
- macros everywhere
- %clean is there
- %doc ok
- no *.la files
- no libs
- no gui - no desktop file
- no translations
- group ok
Needswork:
- Have you queried upstream to include a COPYING file?
If not yet, please do so.
- BR: python-devel is not needed
- --prefix=%{_prefix} is not needed in %install
- License is GPLv3+ not GPLv3 only
###
These are only minor issues, which are fixed easily - appoving
###
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530473] Review Request: lessfs - Lessfs is an inline data deduplicating filesystem.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530473
--- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-12-20 18:59:34 EDT ---
I'm very-very apologize for the big delay. Circumstances beyond my control, but
I'm just trying to fight them ...
Long awaited review:
Legend: + - Ok.
- - Error.
+/- - It item acceptable, but I strongly recommend enhancement.
= - N/A.
MUST Items
[+] MUST: rpmlint must be run on every package. The output should be posted in
the review.
$ rpmlint *
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[-] MUST: The package must meet the Packaging Guidelines.
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
Patch0 has not any comment.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[-] MUST: The License field in the package spec file must match the actual
license.
Comment in lessfs.c say:
You can redistribute lessfs and/or modify it under the terms of either (1) the
GNU General Public License; either version 3 of the or (at your option) any
later version as published by the Free Software Foundation.
So, license of package may be GPLv3+. Why you boundary it by GPLv3?
[-] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
If the source package does not include the text of the license(s), the packager
should contact upstream and encourage them to correct this mistake.
Text of license is not includes. Do you try ask maintainer include it?
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task.
$ md5sum lessfs-0.9.4.tar.gz lessfs-0.9.4.tar.gz.downloaded
c4c5dbe234dc026bbba7945dc14f8305 lessfs-0.9.4.tar.gz
c4c5dbe234dc026bbba7945dc14f8305 lessfs-0.9.4.tar.gz.downloaded
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1882307
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[=] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[=] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[=] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[-] MUST: Each package must consistently use macros.
Do not use direct path /etc/lessfs.cfg, /etc/init.d/lessfs . Macros
like%{_sysconfdir} must be used.
[-] MUST: The package must contain code, or permissable content.
lib_qlz.{c,h}:
// QuickLZ data compression library
// Copyright (C) 2006-2007 Lasse Mikkel Reinhold
// l...@quicklz.com
//
// QuickLZ can be used for free under the GPL-1 or GPL-2 license (where
anything.
// released into public must be open source) or under a commercial license if
such.
// has been acquired (see http://www.quicklz.com/order.html). The commercial
license.
// does not cover derived or ported versions created by third parties under
GPL.
lib_BMW.c, lib_sboxes.c, lib_net.{h,c}, lib_tiger.c, listdb.c, have not any
mention of license and require further clarification.
miniacc.h, portab.h, portab_a.h :
/* ACC ---
[Bug 549223] New: Review Request: ignuit - A memorization aiding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ignuit - A memorization aiding tool https://bugzilla.redhat.com/show_bug.cgi?id=549223 Summary: Review Request: ignuit - A memorization aiding tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/ignuit.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/ignuit-0.0.16-1.fc12.src.rpm Project URL: http://homepages.ihug.co.nz/~trmusson/programs.html#ignuit Description: Ignuit is a memorization aid based on the Leitner flashcard system. It has a GNOME look and feel, a good selection of quiz options, and supports UTF-8. Cards can include embedded audio, images, and mathematical formulae (via LaTeX). It can import and export several file formats, including CSV. Ignuit can be used for both long-term learning and cramming. I'd really appreciate any feedback about the program and any problems you have with it. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882373 rpmlint output: [...@localhost i686]$ rpmlint ignuit* ignuit.i686: W: non-conffile-in-etc /etc/gconf/schemas/ignuit.schemas 2 packages and 0 specfiles checked; 0 errors, 1 warnings. [...@localhost SRPMS]$ rpmlint ignuit-0.0.16-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542747] Review Request: oglappth - Libraries for the oglappth chemistry package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542747 --- Comment #7 from Carl Byington c...@five-ten-sg.com 2009-12-20 19:19:34 EDT --- done. http://www.five-ten-sg.com/oglappth.spec http://www.five-ten-sg.com/oglappth-0.98-4.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1882370 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549228] New: Review Request: fosfor - A media player for Linux that uses the Clutter and GStreamer toolkits
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: fosfor - A media player for Linux that uses the Clutter and GStreamer toolkits https://bugzilla.redhat.com/show_bug.cgi?id=549228 Summary: Review Request: fosfor - A media player for Linux that uses the Clutter and GStreamer toolkits Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: hicham.haou...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hicham.fedorapeople.org/fosfor.spec SRPM URL: http://hicham.fedorapeople.org/fosfor-0.1-0.82svn.fc12.src.rpm Description: A media player for Linux that uses the Clutter and GStreamer toolkits Rpmlint output: none -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549228] Review Request: fosfor - A media player for Linux that uses the Clutter and GStreamer toolkits
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549228 Hicham HAOUARI hicham.haou...@gmail.com changed: What|Removed |Added Depends on||549229 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 529496] Review Request: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529496 --- Comment #12 from Felipe Contreras felipe.contre...@gmail.com 2009-12-20 20:36:28 EDT --- Ping. It seems everything has been done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520015] Review Request: ibus-table-cantonhk - Cantonese (Hong Kong) input method table for ibus-table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520015 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added CC||dc...@redhat.com --- Comment #1 from Ding-Yi Chen dc...@redhat.com 2009-12-20 20:56:05 EDT --- Invalid URLs, did you put them elsewhere? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520017] Review Request: ibus-table-zhuyin - Zhu Yin input method tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520017 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dc...@redhat.com AssignedTo|nob...@fedoraproject.org|dc...@redhat.com --- Comment #2 from Ding-Yi Chen dc...@redhat.com 2009-12-20 20:54:23 EDT --- Isn't Zhu Yin is not usable unless ibus-table has End-Key support? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 547427] Review Request: cciss_vol_status - show status of logical drives attached to HP Smartarray controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547427 Toshio Ernie Kuratomi a.bad...@gmail.com changed: What|Removed |Added CC||a.bad...@gmail.com Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Toshio Ernie Kuratomi a.bad...@gmail.com 2009-12-20 21:14:53 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531256] Review Request: dpm - Disk Pool Manager (DPM)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531256 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added CC||dc...@redhat.com --- Comment #2 from Ding-Yi Chen dc...@redhat.com 2009-12-20 21:12:17 EDT --- Upstream names it as glite, thus, it will be great that your package reflect this. Also, I cannot found the dependency lcgdm-devel, where does it come from? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494695] Review Request: qutim - Multiplatform Instant Messenger on Qt4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494695 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #28 from Kevin Fenzi ke...@tummy.com 2009-12-20 22:14:52 EDT --- We no longer do F-10 branches as it's now end of life. otherwise, cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521996] New Package for Dogtag PKI: pki-silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521996 --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2009-12-20 22:43:49 EDT --- Thanks for update. waiting for dependencies to be built in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522207] New Package for Dogtag PKI: pki-common
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522207 --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2009-12-20 22:45:18 EDT --- waiting for dependencies to be first built in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521255] New package for Dogtag PKI: pki-selinux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521255 --- Comment #15 from Parag AN(पराग) panem...@gmail.com 2009-12-20 22:47:04 EDT --- unable to download srpm/spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521993] New Package for Dogtag PKI:pki-setup
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521993 --- Comment #9 from Parag AN(पराग) panem...@gmail.com 2009-12-20 23:02:38 EDT --- Review: + package builds in mock (rawhide i686). koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1882524 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 9d363872b283edbd8d719ccb11fd952e8a496482 pki-setup-1.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) As said in comment#4, please remove Requires for perl packages. perl dependencies are auto installed by yum. 2) May I know why this package have Requires: pki-native-tools ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542559] Review Request: rubygem-thor - Scripting framework that replaces rake, sake and rubigen
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542559 --- Comment #2 from Matthew Kent mk...@magoazul.com 2009-12-21 00:12:21 EDT --- Thank you for the review. (In reply to comment #1) Some notes: * Source - Source0 in srpm differs from what I could download from the URL written in the spec file - 5fa79d6ca562a39c72c89f5447a3fbd5 thor-0.12.0.gem 32e034949be3726ff1857d0edeae6566 rubygem-thor-0.12.0-1.fc13.src/thor-0.12.0.gem - (and the contents of two gems actually differ) Good catch! Looks like they replaced it after the recent rubyforge - gemcutter migration. * Requires - bin/rake2thor contains: - 8 require 'rake' - As the Summary of this spec file says that replaces rake,, I think it is admitted to add Requires: rubygem(rake) and this should surely be added. Yeah I went back and forth on this one a bit initial, but your right, it should be there. - lib/thor/shell/color.rb contains: - 98@diff_lcs_loaded = begin 99 require 'diff/lcs' 100 true 101rescue LoadError 102 false 103end - I guess diff/lcs dependency is surely optional, however as Fedora already has rubygem-diff-lcs, you may want to add this dependency (however this is up to what you think) Oh, missed this one. Looks like a minimal impact to add it as diff-lcs doesn't have any dependencies of its own. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542559] Review Request: rubygem-thor - Scripting framework that replaces rake, sake and rubigen
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542559 --- Comment #3 from Matthew Kent mk...@magoazul.com 2009-12-21 00:13:48 EDT --- Spec URL: http://magoazul.com/wip/SPECS/rubygem-thor.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-thor-0.12.0-2.fc13.src.rpm * Fri Dec 18 2009 Matthew Kent mk...@magoazul.com - 0.12.0-2 - Add Requires for rubygem(rake) (#542559). - Upstream replaced Source after the gemcutter migration, update to latest (#542559). - Add Requires for rubygem(diff-lcs) as Thor can take advantage of it for colourized diff output (#542559). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548203] Review Request: mediawiki-LdapAccount - Use LDAP as an account source for medaiwiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548203 Michael Stahnke mastah...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Michael Stahnke mastah...@gmail.com 2009-12-21 00:55:12 EDT --- New Package CVS Request === Package Name: mediawiki-LdapAccount Short Description: estrict mediawiki to using LDAP accounts only Owners: stahnma Branches: F11 F12 EL5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483728 --- Comment #34 from Fedora Update System upda...@fedoraproject.org 2009-12-21 01:22:04 EDT --- kde-plasma-ihatethecashew-0.4-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483728 --- Comment #33 from Fedora Update System upda...@fedoraproject.org 2009-12-21 01:21:58 EDT --- kde-plasma-ihatethecashew-0.4-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 546147] Merge Review: kasumi
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=546147
--- Comment #2 from Akira TAGOH ta...@redhat.com 2009-12-21 02:23:01 EDT ---
Thanks for the review. I should do self-review before submitting this ;)
(In reply to comment #1)
Some remarks
* BR
- Please check if gettext-devel is really needed for BR
- Also BR: automake autoconf don't seem to be needed because
no autotools are called during build.
No they aren't needed. fixed.
* SourceURL
- I guess the following works.
http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz
Aha. it didn't work before IIRC. so that might be improved at sf.jp then :)
cool. fixed.
* %makeinstall
- Please avoid to use %makeinstall and use make install
DESTDIR=$RPM_BUILD_ROOT
instead
fixed.
? Removing desktop
---
# remove .desktop file so that kasumi is accessible from
# scim panel and it's not necessary for other users.
rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/*.desktop
---
- Is this also true for people using ibus (as now we use
ibus by default) and some other input method (such as uim/uim-anthy)?
- Does this mean that %_datadir/pixmaps/kasumi.png can also
be removed?
added it back. ideally ibus-anthy should supports it as scim-anthy does and get
rid of it from the menu after that, but anyway.
* Misc rpmlint issues
---
kasumi.i686: W: summary-ended-with-dot C An anthy dictionary management tool.
---
- Please fix above.
fixed.
please revisit the CVS again for confirming.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 547974] Review Request: ibus-skk - Japanese Simple Kana Kanji IME for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547974 --- Comment #5 from Jens Petersen peter...@redhat.com 2009-12-21 02:46:15 EDT --- Ueno-san, would you be interested in owning the package? I only submitted because I made a test package... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 541765] Review Request: NanoEngineer-1 - Nano-composite modeling and simulation program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541765 --- Comment #4 from Thomas Fitzsimmons fitz...@fitzsim.org 2009-12-21 02:49:11 EDT --- I fixed the UI hang on startup -- see NanoEngineer-1_Suite_v1.1.1.12-fix-startup-hang.patch -- and made all the changes you requested. Here are the updated spec and SRPM files: http://fitzsim.org/packages/NanoEngineer-1.spec http://fitzsim.org/packages/NanoEngineer-1-1.1.1.12-0.2.fc12.src.rpm Please review and retest these on your x86-64 machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 541978] Review Request: pulseaudio-equalizer - PulseAudio Equalizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541978 --- Comment #7 from Lubomir Rintel lkund...@v3.sk 2009-12-21 02:51:49 EDT --- (In reply to comment #6) I just mailed the author and he told me that he won't put the sources in his launchpad account until mid january. ... I am wondering if i should go with this package if upstream do have better solutions. Don't let that discourage you. Until upstream comes to senses, you can get at lease get rid of that gross %prep hack. You should probably use the .deb file as the only source, use %setup -c -T and unpack it with ar afterwards. (And of course address the other issues, which are more-or-less trivial). Feel free to ask for help should you need any! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
