[Bug 551721] Review Request: php-channel-pdepend - PHP Depend PEAR channel

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551721


Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

 CC||fed...@famillecollet.com




--- Comment #1 from Remi Collet fed...@famillecollet.com  2010-01-02 03:00:07 
EDT ---
Same notes than for 544660

- Requires php-cli is redundant with php-pear
- replace pear.pdepend.org.xml by %{name}.xml (cf PHP Guidelines)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551722] Review Request: php-channel-phpmd - PHP Mess Detector PEAR channel

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551722


Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

 CC||fed...@famillecollet.com




--- Comment #1 from Remi Collet fed...@famillecollet.com  2010-01-02 03:01:18 
EDT ---
Again ;)
- Requires php-cli is redundant with php-pear
- replace pear.phpmd.org.xml by %{name}.xml (cf PHP Guidelines)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476





--- Comment #11 from Matthew Kent mk...@magoazul.com  2010-01-02 03:25:36 EDT 
---
(In reply to comment #7)
 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-newgem.spec
 SRPM:
 http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-newgem-1.5.2-1.fc11.src.rpm
 
 Matthew: Feel free to help. I'd be glad and thankful if you could 
 (co-)maintain
 this once it's in.  

Sure thing. I'm now requiring this for another package I'm working on so I'll
post my update. I tried to record my modifications in the changelog. Hopefully
they all make sense.

Only other improvement I'd like to make is to break the ri/rdoc content, tests
and Rakefile into a separate -doc package giving the main one a smaller
footprint. Any issue with that?

(In reply to comment #8)
 1] rpmlint complaining
 rubygem-newgem.noarch: W: incoherent-version-in-changelog 1.4.1-3
 ['1.5.2-1.fc12', '1.5.2-1']
 rubygem-newgem.noarch: E: non-executable-script
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/templates/bin/app.rb.erb
 0644 /usr/bin/env
 rubygem-newgem.noarch: W: hidden-file-or-dir
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge
 rubygem-newgem.noarch: W: hidden-file-or-dir
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge
 rubygem-newgem.noarch: E: zero-length
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/website/version.js
 rubygem-newgem.noarch: E: zero-length
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/plain_theme/USAGE
 rubygem-newgem.noarch: E: zero-length
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem_simple/templates/lib/templates.rb
 rubygem-newgem.noarch: W: wrong-file-end-of-line-encoding
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/test_helper.rb
 rubygem-newgem.noarch: E: zero-length
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/long_box_theme/USAGE
 rubygem-newgem.noarch: E: non-executable-script
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem/templates/script/console.erb
 0644 /usr/bin/env
 rubygem-newgem.noarch: E: zero-length
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/USAGE
 rubygem-newgem.noarch: E: non-executable-script
 /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_generators/install_website/templates/script/txt2html
 0644 /usr/bin/env
 2 packages and 0 specfiles checked; 8 errors, 4 warnings.
 
 *license ok
 *naming ok
 *spec file legible
 *build ok
 
 please fix rpmlint messages

I've fixed the one regarding the crlf issue but the others are harder to quash
as they are all templates/placeholder files used by newgem to create new
projects. Is there a nicer way to have rpmlint ignore these? For now I've added
a note in the spec file.

 SPEC file here and in src.rpm seems different

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476





--- Comment #12 from Matthew Kent mk...@magoazul.com  2010-01-02 03:29:00 EDT 
---
Spec URL: http://magoazul.com/wip/SPECS/rubygem-newgem.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-newgem-1.5.2-2.fc13.src.rpm

* Fri Jan 01 2010 Matthew Kent mk...@magoazul.com - 1.5.2-2
- Drop versioning on requirements as this is a new package.
- Drop unused ruby_sitelib macro.
- Add a rubyabi macro.
- RPM_BUILD_ROOT - buildroot - use one style of macros.
- Fix bin/env ruby searching in bin/newgem.
- Remove duplicate hoe dependency.
- Add check phase.
- Fix another crlf (#504476).
- Add note about rpmlint complaints (#504476).

mk...@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint rubygem-newgem.spec
/var/tmp/old_results/rubygem-newgem-1.5.2-2.fc13.*
rubygem-newgem.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/templates/bin/app.rb.erb
0644 /usr/bin/env
rubygem-newgem.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge
rubygem-newgem.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge
rubygem-newgem.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/website/version.js
rubygem-newgem.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/plain_theme/USAGE
rubygem-newgem.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem_simple/templates/lib/templates.rb
rubygem-newgem.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/long_box_theme/USAGE
rubygem-newgem.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem/templates/script/console.erb
0644 /usr/bin/env
rubygem-newgem.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/USAGE
rubygem-newgem.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_generators/install_website/templates/script/txt2html
0644 /usr/bin/env

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551817] Review Request: rubygem-templater - Ruby framework for building code generators

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551817


Matthew Kent mk...@magoazul.com changed:

   What|Removed |Added

 Depends on||504476




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551817] New: Review Request: rubygem-templater - Ruby framework for building code generators

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-templater - Ruby framework for building code 
generators

https://bugzilla.redhat.com/show_bug.cgi?id=551817

   Summary: Review Request: rubygem-templater - Ruby framework for
building code generators
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mk...@magoazul.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://magoazul.com/wip/SPECS/rubygem-templater.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-templater-1.0.0-1.fc13.src.rpm
Description: Templater is a Ruby framework for building code generators. It has
the ability to both copy files from A to B and also to render templates using
ERB.

mk...@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint rubygem-templater.spec
/var/tmp/results/rubygem-templater-*
rubygem-templater-doc.noarch: W: no-documentation
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Action/destination%3d-i.yaml
%3d
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Generator/glob%21-c.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Directory/identical%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Spec/Helpers/CreateMatcher/matches%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Generator/render%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/gems/templater-1.0.0/spec/templates/glob/hellothar.html.%feh%
%feh
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Template/exists%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/File/invoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Action/source%3d-i.yaml
%3d
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Template/invoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/EmptyDirectory/identical%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/EmptyDirectory/revoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Discovery/discover%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/gems/templater-1.0.0/spec/templates/glob/hellothar.%feh%
%feh
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/File/revoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Spec/Helpers/InvokeMatcher/matches%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Generator/invoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/EmptyDirectory/exists%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/EmptyDirectory/invoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Template/revoke%21-i.yaml
%21
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/ArgumentDescription/valid%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/File/exists%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Generator/match_options%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/File/identical%3f-i.yaml
%3f
rubygem-templater-doc.noarch: W: misspelled-macro
/usr/lib/ruby/gems/1.8/doc/templater-1.0.0/ri/Templater/Actions/Template/identical%3f-i.yaml
%3f
3 packages and 1 specfiles checked; 0 errors, 26 warnings.

-- 

[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476


Matthew Kent mk...@magoazul.com changed:

   What|Removed |Added

 Blocks||551817




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551651] Review Request: ArpON - Arp handler inspection

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551651





--- Comment #4 from ELMORABITY Mohamed melmorab...@fedoraproject.org  
2010-01-02 04:11:56 EDT ---
Shakthi : about your comment #001: since glibc-devel is a dependancy of gcc,
and since gcc is part of the minimal build system in Fedora (see
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2), there is no
need to set glibc-devel as a BR. By the way the RPM builds fine in mock without
it.

About #002: moreover, I don't think there is a real need to modify the
Makefile. /usr/lib and /usr/include (or /usr/lib64 and /usr/include when
running Fedora on a x86_64) already belong to the search paths by default of
gcc. It's not a problem to leave the Makefile looking for headers and libs in
/usr/local since this directory is empty anyway in a mock chroot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551651] Review Request: ArpON - Arp handler inspection

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551651





--- Comment #5 from ELMORABITY Mohamed melmorab...@fedoraproject.org  
2010-01-02 04:36:45 EDT ---
Arun: just a cosmetic issue about the $RPM_OPT_FLAGS variable I suggested
before. In fact, you should replace $RPM_OPT_FLAGS by %{optflags}, since you
are using a macro-style in your .spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 544660] Review Request: php-channel-swift - Adds swift mailer project channel to PEAR

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544660





--- Comment #2 from Christof Damian chris...@damian.net  2010-01-02 05:43:16 
EDT ---
(In reply to comment #1)
 Quick notes before review :
 - Requires php-cli is redundant with php-pear
 - replace pear.swiftmailer.org.xml by %{name}.xml (cf PHP Guidelines)
 
 I think using REST version provided (here 1.3) as version could be a good idea
 for this package where version have no really meaning.  

As with the other channels I got for review I just copied the one from
php-channel-doctrine.

Removing php-cli makes sense.

I am not sure about the version number, the channel format is version 1.0 and
all other php-channel-* seem to use that at the moment. It might be worth
discussing that on the fedora-php list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 544660] Review Request: php-channel-swift - Adds swift mailer project channel to PEAR

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544660





--- Comment #3 from Remi Collet fed...@famillecollet.com  2010-01-02 06:06:20 
EDT ---
Note about version is only a note. There is actually no meaning to this field.
I have use REST version for latest phpunit channel update, only because I think
it could be usefull ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 519009] Review Request: gnome-do-docklets - Docklets for gnome-do

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519009


Julian Aloofi julian.fed...@googlemail.com changed:

   What|Removed |Added

 CC||julian.fed...@googlemail.co
   ||m




--- Comment #9 from Julian Aloofi julian.fed...@googlemail.com  2010-01-02 
07:51:05 EDT ---
I suppose nobody will see this CVS request as the fedora-cvs flag is not set...
Just pointing this out, as I'd like to see the docklets in the repos.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551258] Review Request: libgcal - A library to access google calendar events and contacts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551258


Andrea Musuruane musur...@gmail.com changed:

   What|Removed |Added

 CC||musur...@gmail.com




--- Comment #1 from Andrea Musuruane musur...@gmail.com  2010-01-02 08:16:29 
EDT ---
Changelog format is not correct:
http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

This is why you get a warning in rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551651] Review Request: ArpON - Arp handler inspection

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551651





--- Comment #6 from Shakthi Kannan shakthim...@gmail.com  2010-01-02 08:21:48 
EDT ---
(In reply to comment #4)
| About #002: moreover, I don't think there is a real need to modify the
| Makefile. /usr/lib and /usr/include (or /usr/lib64 and /usr/include when
| running Fedora on a x86_64) already belong to the search paths by default of
| gcc. It's not a problem to leave the Makefile looking for headers and libs in
| /usr/local since this directory is empty anyway in a mock chroot.  
\--

It is not just a question of it working in mock chroot, but, how upstream
sources should use it on different platforms, and target builds.

Ideally, upstream should use a PREFIX for the install variable, and not
hard-code it everywhere in the Makefile. From the .spec file one should be able
to override the PREFIX with the preferred location.

Thanks for your feedback.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 549366] Review Request: flaw - F.L.A.W is a small multiplayer action game

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549366


Andrea Musuruane musur...@gmail.com changed:

   What|Removed |Added

 CC||musur...@gmail.com




--- Comment #8 from Andrea Musuruane musur...@gmail.com  2010-01-02 08:33:33 
EDT ---
You must not install irrelevant files like the INSTALL file in %doc:
http://fedoraproject.org/wiki/Packaging/Guidelines#Documentation

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551838] New: Review Request: opendchub - A hub software for Direct Connect

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: opendchub - A hub software for Direct Connect

https://bugzilla.redhat.com/show_bug.cgi?id=551838

   Summary: Review Request: opendchub - A hub software for Direct
Connect
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: singh.rosha...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://roshansingh.fedorapeople.org/opendchub/opendchub.spec
SRPM URL:
http://roshansingh.fedorapeople.org/opendchub/opendchub-0.8.1-1.fc12.src.rpm
Description: Opendchub is the hub software for Direct Connect P2P network. It
runs as a daemon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551587] Review Request: java-gnome - Java GNOME bindings

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551587





--- Comment #4 from Alexander Boström a...@root.snowtree.se  2010-01-02 
09:45:00 EDT ---
* Simplify the .jar symlink mess.

Spec URL:
http://www.root.snowtree.se/abo/fedora/reviews/java-gnome/java-gnome.spec
SRPM URL:
http://www.root.snowtree.se/abo/fedora/reviews/java-gnome/java-gnome-4.0.14-3.fc12.src.rpm

$ rpmlint java-gnome.spec java-gnome-4.0.14-3.fc12.src.rpm
java-gnome-4.0.14-3.fc12.x86_64.rpm
java-gnome-debuginfo-4.0.14-3.fc12.x86_64.rpm
java-gnome-javadoc-4.0.14-3.fc12.x86_64.rpm
4 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551857] New: Review Request: fwsnort - Translates Snort rules into equivalent iptables rules

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: fwsnort - Translates Snort rules into equivalent 
iptables rules

https://bugzilla.redhat.com/show_bug.cgi?id=551857

   Summary: Review Request: fwsnort - Translates Snort rules into
equivalent iptables rules
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: guillermo.go...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://gomix.fedorapeople.org/fwsnort/fwsnort.spec
SRPM URL: http://gomix.fedorapeople.org/fwsnort/fwsnort-1.0.6-1.fc12.src.rpm

Description: 

fwsnort translates Snort rules into equivalent iptables rules and generates
a Bourne shell script that implements the resulting iptables commands. This
ruleset allows network traffic that exhibits Snort signatures to be logged
and/or dropped by iptables directly without putting any interface into
promiscuous mode or queuing packets from kernel to user space. In addition,
fwsnort (optionally) uses the IPTables::Parse module to parse the iptables
ruleset on the machine to determine which Snort rules are applicable to the
specific iptables policy.  After all, if iptables is blocking all inbound
http traffic from external addresses, it is probably not of much use to try
detecting inbound attacks against against tcp/80. By default fwsnort
generates iptables rules that log Snort sid's with --log-prefix to klogd
where the messages can be analyzed with a log watcher such as logwatch or
psad (see http://www.cipherdyne.org/psad). fwsnort relies on the iptables
string match module to match Snort content fields in the application portion
of ip traffic. Since Snort rules can contain hex data in content fields,
fwsnort implements a patch against iptables-1.2.7a which adds a
--hex-string option which will accept content fields such as
|0d0a5b52504c5d3030320d0a|. fwsnort is able to translate approximately 60%
of all rules from the Snort-2.3.3 IDS into equivalent iptables rules. For
more information about the translation strategy as well as
advantages/disadvantages of the method used by fwsnort to obtain intrusion
detection data, see the README included with the fwsnort sources or browse
to: http://www.cipherdyne.org/fwsnort/

Also via git at fedorapeople.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838


ELMORABITY Mohamed melmorab...@fedoraproject.org changed:

   What|Removed |Added

 CC||melmorab...@fedoraproject.o
   ||rg




--- Comment #1 from ELMORABITY Mohamed melmorab...@fedoraproject.org  
2010-01-02 10:46:52 EDT ---
Hi,

here is an informal review of your package, while waiting to be sponsored ^^.
Just a few remarks about BR, the general look of the .spec seems pretty good
^^.

* since glibc-devel is a dependancy of gcc,
and since gcc is part of the minimal build system in Fedora (see
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2), there is no
need to set glibc-devel as a BuildRequires.

* However, after checking the configure.in, I think you'll need to set
perl-devel as a BuildRequires.

* By the way, according to the file configure.in, the BR libcap-devel is only
required if the option « --enable-switch_user » is explicitely called.
Otherwise it is useless.
If you think that this option is useful, it may be a good thing to enable it,
to offer as many enabled features as possible in your binary.

You should check that you have defined all the required BuildRequires with
mock:
   http://fedoraproject.org/wiki/Extras/MockTricks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 539989] Review Request: nettop - top-like program for network packets

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539989


Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

 CC||pa...@hubbitus.info




--- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2010-01-02 11:10:59 EDT ---
Offsite http://srparish.net/scripts/ seams down.

Meantime where links to upstream bugreports for each patches?
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550601] Review Request: themonospot-gui-qt - Qt gui to scan multimedia files using Themonospot

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550601


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Depends on||551860




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 538558] Review Request: kde-partitionmanager - KDE Partition Manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538558


Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

 CC||pa...@hubbitus.info




--- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2010-01-02 11:19:18 EDT ---
Thomas Janssen, do you plan push updates for Fedora 11 too?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530743] Review Request: tmux - A terminal multiplexer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530743


Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

 CC||pa...@hubbitus.info




--- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2010-01-02 11:17:58 EDT ---
Sven Lankes, do you plan push updates for EPEL5 and Fedora 11?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550601] Review Request: themonospot-gui-qt - Qt gui to scan multimedia files using Themonospot

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550601





--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2010-01-02 
11:24:21 EDT ---
While bug 551534 is not a strict blocker for this review,
bug 551860 should surely be fixed before this bug is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530743] Review Request: tmux - A terminal multiplexer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530743





--- Comment #15 from Sven Lankes s...@lank.es  2010-01-02 11:46:41 EDT ---
The latest release is in EPEL5-stable and and I'm not planning to push it to
F11 or EPEL4.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530743] Review Request: tmux - A terminal multiplexer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530743





--- Comment #16 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2010-01-02 11:52:57 EDT ---
(In reply to comment #15)
 I'm not planning to push it to F11 or EPEL4.
Then for what you request F-11 branch before?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell chalmers-lava2000 library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546376


Chitlesh GOORAH chitl...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||chitl...@gmail.com
 AssignedTo|chitl...@gmail.com  |nob...@fedoraproject.org
   Flag|fedora-review?  |




--- Comment #2 from Chitlesh GOORAH chitl...@gmail.com  2010-01-02 11:56:07 
EDT ---
I apologize, I can't carry on this package review since I'll be offline for one
month.
https://fedoraproject.org/wiki/Vacation

If no one has taken up the review, I'll do when I'll be back.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #23 from David A. Wheeler dwhee...@dwheeler.com  2010-01-02 
12:12:51 EDT ---
Hooray!! This updated package now works on 32-bit (using Fedora 11).   It
builds without hanging.  I also used the mortality.pvs demo, and PVS quickly
proves Socrates is mortal.  That's good, since Socrates has been dead a long
time :-).  Anyway, that worked in 64-bit, now it works (again) in 32-bit.

I found no rpmlint warnings in this version (at least for the 32-bit version). 
I did rpmlint ./RPMS/i586/pvs-sbcl-4.2-2.20091229svn.fc11.i586.rpm
./SRPMS/pvs-sbcl-4.2-2.20091229svn.fc11.src.rpm ./SPECS/pvs-sbcl.spec and it
reported:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

I'll try 64-bit Fedora 12 next; presuming that works, I'll then walk through
the package guideline checklist.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530743] Review Request: tmux - A terminal multiplexer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530743





--- Comment #17 from Sven Lankes s...@lank.es  2010-01-02 12:12:09 EDT ---
I have requested the branch so that I could 
push tmux it to F11 if anyone requested it.

Noone has asked for tmux on F11 yet.

If you want tmux for F11 please file a bug and I'll 
see if it works on F11 (it should) and push an update.

Let's not continue this discussion in this closed bug 
please - file a new one if you want an F11-package and 
if there is anything else, send me an email.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #24 from David A. Wheeler dwhee...@dwheeler.com  2010-01-02 
13:22:40 EDT ---
This PVS also seems to work on 64-bit Fedora 12.  It builds fine. There are no
rpmlint warnings or errors on this one, either:
 rpmlint pvs-sbcl.spec
../RPMS/x86_64/pvs-sbcl-4.2-2.20091229svn.fc12.x86_64.rpm
../SRPMS/pvs-sbcl-4.2-2.20091229svn.fc12.src.rpm
 2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 431665] Review Request: fox - A C++ library for GUI development

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431665


Terje Røsten terje...@phys.ntnu.no changed:

   What|Removed |Added

 CC||terje...@phys.ntnu.no




--- Comment #23 from Terje Røsten terje...@phys.ntnu.no  2010-01-02 13:30:12 
EDT ---
I might have some interest in this package, spec file links seems dead,
any private copy floating around?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542760] Review Request: mopac7 - Semi-empirical quantum mechanics suite

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542760





--- Comment #12 from Carl Byington c...@five-ten-sg.com  2010-01-02 13:44:02 
EDT ---
done.

http://www.five-ten-sg.com/mopac7.spec
http://www.five-ten-sg.com/mopac7-1.15-8.fc12.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=1898980

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 538558] Review Request: kde-partitionmanager - KDE Partition Manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538558





--- Comment #12 from Thomas Janssen thom...@fedoraproject.org  2010-01-02 
13:43:23 EDT ---
Hello Pavel,

yes, i push updates always for every supported Fedora the same time.
kde-partitionmanager-1.0.0-2 is as well in Fedora 11 and rawhide :)

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542759] Review Request: mpqc - Ab-initio chemistry program

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542759





--- Comment #30 from Carl Byington c...@five-ten-sg.com  2010-01-02 14:28:48 
EDT ---
done. I just added atlas-devel, since it won't build without blas-devel. It
seems that removing blas-devel would require extensive patches to ./configure
or ./configure.in, which is probably not what you meant.

http://www.five-ten-sg.com/mpqc.spec
http://www.five-ten-sg.com/mpqc-2.3.1-7.fc12.src.rpm  
http://koji.fedoraproject.org/koji/taskinfo?taskID=1898999

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #25 from David A. Wheeler dwhee...@dwheeler.com  2010-01-02 
14:43:43 EDT ---
Okay, I reviewed the package using the guideline checklist at:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

I have questions/issues for two points:
* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]
NO.  There are some files that are stored as shared library files:
/usr/lib64/pvs/bin/ix86_64-Linux/runtime/
Granted, these probably aren't shared by other packages, but they MIGHT be.
* MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [20]
??? NOT SURE.  There are .so files not in a -devel package, but it's not
clear that they SHOULD be in a -devel package.

Comments?  Perhaps I'm misunderstanding something?

There are a few things I need to do, too. I can't check the svn version at this
instant (can't download), so I hope to do that soon.  I also intend to do a
koji build, which will answer some.

Other than that, looks like we're off.  Here's the guideline checklist results:

*  MUST: rpmlint must be run on every package. The output should be posted
in the review.[1]

OK.  No warnings or errors.

* MUST: The package must be named according to the Package Naming
Guidelines.

OK.

* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2].

OK.

* MUST: The package must meet the Packaging Guidelines.

OK.  At least, I don't see any violations.

* MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.

OK (GPLv2+).

* MUST: The License field in the package spec file must match the actual
license. [3]

OK.  It has the usual GPL LICENSE file.  The PVS website also specifically
states that it is GPL-licensed:
http://pvs.csl.sri.com/download.shtml

* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]

OK.  See /usr/share/doc/pvs-sbcl-4.2/LICENSE

* MUST: The spec file must be written in American English. [5]

OK.

* MUST: The spec file for the package MUST be legible. [6]

OK.

* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

??? I need to check this later.  This package uses an SVN version, to pick up
necessary patches.  The spec file documents that the extraction uses:
 svn export -r 5477 https://spartan.csl.sri.com/svn/public/pvs/trunk pvs-4.2
I'm having trouble downloading from SVN at this moment; I'll try again later.

* MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]

OK.

* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]

OK to my knowledge.  I only tried x86, 32-bit and 64-bit.  Koji would answer
this.

* MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

OK to my knowledge.  Koji would answer this.

* MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

NA.  Only English.

* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]

NO.  There are some files that are stored as shared library files:
/usr/lib64/pvs/bin/ix86_64-Linux/runtime/
Granted, these probably aren't shared by other packages, but they MIGHT be.

* MUST: Packages must NOT bundle copies of system libraries.[11]

OK.  There's a /usr/lib64/pvs/wish, but this is a *directory* not wish
itself.

* MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that 

[Bug 550597] Review Request: themonospot-plugin-avi - manage Avi container

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550597


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-cvs? |




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:09:16 EDT ---
Are you sure you account name is right here? 

I cannot see that account in the fedora account system. 
Please check your account name and add a new request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542747] Review Request: oglappth - Libraries for the oglappth chemistry package

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542747


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #14 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:10:32 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 541978] Review Request: pulseaudio-equalizer - A 15 Bands Equalizer for PulseAudio

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541978


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #14 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:12:34 EDT ---
No problem. Please do continue to pressure upstream into setting up a proper
repository/etc. 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 547916] Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=547916


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:11:19 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483250] Review Request: chordii - Print songbooks (lyrics + chords)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483250


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #27 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:16:06 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551878


Jean-Francois Saucier jfsauc...@infoglobe.ca changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544964


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:14:13 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 529423] Review Request: mingw32-OpenSceneGraph - Fedora mingw high performance real-time graphics toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529423


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:17:07 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 522207] New Package for Dogtag PKI: pki-common

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522207


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #16 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:20:30 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551878] New: Review Request: font-manager - A font management application for the GNOME desktop environment

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: font-manager - A font management application for the 
GNOME desktop environment

https://bugzilla.redhat.com/show_bug.cgi?id=551878

   Summary: Review Request: font-manager - A font management
application for the GNOME desktop environment
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jfsauc...@infoglobe.ca
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://jfsaucier.fedorapeople.org/packages/font-manager.spec
SRPM URL:
http://jfsaucier.fedorapeople.org/packages/font-manager-0.4.2-1.fc12.src.rpm
Description: 
Font Manager is an application that allows users to easily manage fonts
on their system.

Although designed with the GNOME desktop environment in mind, it should
work well with most major desktop environments such as XFCE,
Enlightenment, and even KDE.


Here is the koji scratch build result:
F11 : https://koji.fedoraproject.org/koji/taskinfo?taskID=1899011
F12 : https://koji.fedoraproject.org/koji/taskinfo?taskID=1899009
F13 : https://koji.fedoraproject.org/koji/taskinfo?taskID=1899013


The only error rpmlint gave me is on the SPEC file and I think it can be safely
ignored after my research :

font-manager.noarch: E: explicit-lib-dependency libxml2-python



I need someone to sponsor me for this package.

Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 521995] New Package for Dogtag PKI:pki-java-tools

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521995


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #14 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:19:47 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483406] Review Request: perl-Text-CSV - Comma-separated values manipulator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483406


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #16 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:23:26 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542759] Review Request: mpqc - Ab-initio chemistry program

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542759





--- Comment #31 from Jussi Lehtola jussi.leht...@iki.fi  2010-01-02 15:25:35 
EDT ---
(In reply to comment #30)
 done. I just added atlas-devel, since it won't build without blas-devel. It
 seems that removing blas-devel would require extensive patches to ./configure
 or ./configure.in, which is probably not what you meant.
 
 http://www.five-ten-sg.com/mpqc.spec
 http://www.five-ten-sg.com/mpqc-2.3.1-7.fc12.src.rpm  
 http://koji.fedoraproject.org/koji/taskinfo?taskID=1898999  

The spec file is still revision 6.

I haven't had a look at the spec file yet, but the magic trick is to define the
blas library as
 --with-blas=-L%{_libdir}/atlas -lf77blas -latlas
instead of
 --with-blas=-lblas.
in %configure. Anyway, you should get the idea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483286] Review Request: perl-Data-Report - A flexible plugin-driven reporting framework

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483286


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #22 from Kevin Fenzi ke...@tummy.com  2010-01-02 15:22:15 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #26 from David A. Wheeler dwhee...@dwheeler.com  2010-01-02 
15:38:04 EDT ---
I've resolved most other questions, other than the library-file items above
(the 2 MUSTs), but I got a weird difference between the svn version and what
you sent.

First, though, the good news.  Koji (scratch) build with dist-f12 worked
correctly:
 $ koji build --scratch dist-f12 ./pvs-sbcl-4.2-2.20091229svn.fc12.src.rpm 
...
1899006 build (dist-f12, pvs-sbcl-4.2-2.20091229svn.fc12.src.rpm): open
(ppc04.phx2.fedoraproject.org) - closed
  0 free  0 open  3 done  0 failed
1899006 build (dist-f12, pvs-sbcl-4.2-2.20091229svn.fc12.src.rpm) completed
successfully
Also, silly me, the spec uses ExclusiveArch and I've tested both of them, so
obviously we're fine in terms of architectural support.


HOWEVER, when I downloaded the source code using the spec directions (including
svn), I found this incredibly tiny difference:
[dwhee...@eve SOURCES]$ diff -u -r pvs-4.2 ~/temp/pvs-4.2
diff -u -r pvs-4.2/lib/bitvectors/bv_mult_div_rem.pvs
/home/dwheeler/temp/pvs-4.2/lib/bitvectors/bv_mult_div_rem.pvs
--- pvs-4.2/lib/bitvectors/bv_mult_div_rem.pvs  2002-12-18 20:23:50.0
-0500
+++ /home/dwheeler/temp/pvs-4.2/lib/bitvectors/bv_mult_div_rem.pvs 
2002-12-18 20:23:50.0 -0500
@@ -9,7 +9,7 @@
 %
 %  Author: Bart Jacobs
 %  Started: Wednesday 24 May 00 10:59:26 b...@frustratie
-%  Last-modified: $Date: 2002-12-18 18:23:50 -0700 (Wed, 18 Dec 2002) $
+%  Last-modified: $Date: 2002-12-18 20:23:50 -0500 (Wed, 18 Dec 2002) $
 %  Last-modified by: $Author: owre $


I can't see how this change makes a *difference*, but it's still a difference.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550598] Review Request: themonospot-plugin-mkv - manage Matroska container

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550598





--- Comment #8 from Armando Basile hmandevt...@gmail.com  2010-01-02 16:00:05 
EDT ---
New Package CVS Request
===
Package Name: themonospot-plugin-mkv
Short Description: Matroska plugin for Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtasaka
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550597] Review Request: themonospot-plugin-avi - manage Avi container

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550597





--- Comment #9 from Armando Basile hmandevt...@gmail.com  2010-01-02 15:57:33 
EDT ---
yes, my Fedora Account is hman-it

New Package CVS Request
===
Package Name: themonospot-plugin-avi
Short Description: Avi plugin for Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtas...@ioa.s.u-tokyo.ac.jp
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550594] Review request: themonospot-base - core component of Themonospot suite

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550594





--- Comment #17 from Armando Basile hmandevt...@gmail.com  2010-01-02 
15:59:10 EDT ---
New Package CVS Request
===
Package Name: themonospot-base
Short Description: Core component of Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtasaka
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550600] Review Request: themonospot-gui-gtk - Gtk gui to scan multimedia files using Themonospot

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550600





--- Comment #12 from Armando Basile hmandevt...@gmail.com  2010-01-02 
16:00:47 EDT ---
New Package CVS Request
===
Package Name: themonospot-gui-gtk
Short Description: Gtk gui for Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtasaka
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #11 from Armando Basile hmandevt...@gmail.com  2010-01-02 
16:00:24 EDT ---
New Package CVS Request
===
Package Name: themonospot-console
Short Description: Console application for Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtasaka
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530772





--- Comment #15 from Fedora Update System upda...@fedoraproject.org  
2010-01-02 16:31:15 EDT ---
pxe-kexec-0.2.3-2.fc12 has been pushed to the Fedora 12 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pxe-kexec'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0101

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530772


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #14 from Fedora Update System upda...@fedoraproject.org  
2010-01-02 16:29:02 EDT ---
pxe-kexec-0.2.3-2.fc11 has been pushed to the Fedora 11 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pxe-kexec'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0087

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550667] Review Request: mysql-querybrowser - A graphical tool for handling MySQL queries, construct and analize it

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550667


Dominic Hopf dma...@fedoraproject.org changed:

   What|Removed |Added

 CC||dma...@fedoraproject.org




--- Comment #1 from Dominic Hopf dma...@fedoraproject.org  2010-01-02 
17:03:41 EDT ---
There already exists a package named mysql-query-browser within the Fedora
repositorys. Did you just miss that one or is it really necessary to do another
review here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550667] Review Request: mysql-querybrowser - A graphical tool for handling MySQL queries, construct and analize it

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550667





--- Comment #2 from Dominic Hopf dma...@fedoraproject.org  2010-01-02 
17:06:40 EDT ---
Or am I just missing you splitted up the mysql-gui-tools package? *blush*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 431665] Review Request: fox - A C++ library for GUI development

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431665





--- Comment #24 from Terje Røsten terje...@phys.ntnu.no  2010-01-02 17:24:15 
EDT ---
Redid the thing with help from a wieers rpm:

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1899111
spec: http://terjeros.fedorapeople.org/fox/fox.spec
srpm: http://terjeros.fedorapeople.org/fox/fox-1.6.37-1.fc12.src.rpm

This is for the current stable version. 

TODO: pkgconfig issue.

I don't see the Adie.stx location as blocker, it's more 
a bug in the app, not a thing to stop approval?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551027] Review Request: nicotine+ - A client for the SoulSeek filesharing network

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551027





--- Comment #3 from ELMORABITY Mohamed melmorab...@fedoraproject.org  
2010-01-02 18:15:34 EDT ---
Another update:
Spec URL: http://melmorabity.fedorapeople.org/packages/nicotine+/nicotine+.spec
SRPM URL:
http://melmorabity.fedorapeople.org/packages/nicotine+/nicotine+-1.2.14-4.fc12.src.rpm

The Nicotine+ bug tracker works now, so I submitted the patches used in my SRPM
upstream; the URLs to the corresponding open tickets are given in comments in
the .spec file for each patch. The patch correcting the .desktop file provided
was accepted upstream :-) :
  
http://www.nicotine-plus.org/changeset?old_path=%2Fold=1353new_path=%2Fnew=1353
The other patches are waiting a review.

I also discovered a bug in the application making help unavailable. I made a
patch to correct this issue, and I submitted it also (see comments in .spec).
This is the reason why I updated my SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 546301] Review Request: moblin-app-installer - Moblin Application Installer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546301


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cwick...@fedoraproject.org
   Flag||fedora-review?




--- Comment #2 from Christoph Wickert cwick...@fedoraproject.org  2010-01-02 
18:35:37 EDT ---

OK - MUST: $ rpmlint
/var/lib/mock/fedora-12-x86_64/result/moblin-app-installer-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv2
only)
OK - MUST: License field in spec file matches the actual license (GPLv2)
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
N/A - MUST: sources match the upstream source by MD5 (git version)
OK - MUST: successfully compiles and builds into binary rpms on x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}.
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
N/A - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly installed with
desktop-file-install in the %install section.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: all filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are used, those scriptlets must be sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
N/A - SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself.


Other items:
OK - latest stable version
OK - Compiler flags ok
OK - Debuginfo complete


Issues:
- Missing docs: AUTHORS NEWS README TODO

- BR gtk2-devel is redundant

- no need to patch the desktop file, you can do this with desktop-file-install
--remove-key ... If you patch it, please use the upstream patch from
http://git.moblin.org/cgit.cgi/moblin-app-installer/commit/?id=bc65c884d3a1ae37e69431417888126b2a3ea021

- applist.xml contains lots of packages that are not part of Fedora. At least
the closed source apps like AdobeReader or World of Go should IMO be removed.
Other packages need their names fixed (like kanagram, khangman and kiten which
are part of the kdeedu package).

- applist.xml should be packaged as separate package, see README

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this 

[Bug 359941] Review Request: drupal-calendar - This module will display any Views date field in calendar formats

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=359941





--- Comment #12 from Sven Lankes s...@lank.es  2010-01-02 18:54:34 EDT ---
Sorry - I totally missed the fact that the drupal-bug was answered and closed. 

I looked into the licensing again and according to the drupal site every module 
that is included in the drupal cvs has to be licensed under the same terms as 
drupal itself (which is GPLv2+).

So please fix the license tag in the spec I'll do a full review ASAP (I just
skimmed through the spec, did a mock build and installed it on a drupal
instance without issues so it should be good to go).

BTW: drupal-views and drupal-cck also have GPLv2 as license - they should
probably be fixed at least for rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 266001] Review Request: webunit - Python web testing framework

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=266001


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC|fab...@bernewireless.net|
 AssignedTo|fab...@bernewireless.net|nob...@fedoraproject.org
   Flag|fedora-review?  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 541978] Review Request: pulseaudio-equalizer - A 15 Bands Equalizer for PulseAudio

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541978





--- Comment #15 from Fedora Update System upda...@fedoraproject.org  
2010-01-02 19:06:44 EDT ---
pulseaudio-equalizer-2.4-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pulseaudio-equalizer-2.4-1.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #27 from Jerry James loganje...@gmail.com  2010-01-02 19:32:15 
EDT ---
David, thanks for reviewing the package so thoroughly.  The packaging
guidelines say, in section 1.24, In addition, every binary RPM package which
contains shared library files (not just symlinks) in any of the dynamic
linker's default paths, must call ldconfig in %post and %postun.  This package
does not put a shared library file in any of the dynamic linker's default
paths, so this requirement is vacuously satisfied.

The .so files are covered by section 1.22.  Since the shared libraries are for
PVS's use only, this section is also vacuously satisfied.

I can't account for the timestamp difference you see, but since the time is off
by 2 hours in one direction and the time zone is off by 2 hours in the other
direction, they represent the same time.  I live in the -0700 timezone.  I'm
guessing you live in the -0500 timezone.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 546301] Review Request: moblin-app-installer - Moblin Application Installer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546301





--- Comment #3 from Peter Robinson pbrobin...@gmail.com  2010-01-02 19:52:02 
EDT ---

 Issues:
 - Missing docs: AUTHORS NEWS README TODO
 
 - BR gtk2-devel is redundant
 
 - no need to patch the desktop file, you can do this with desktop-file-install
 --remove-key ... If you patch it, please use the upstream patch from
 http://git.moblin.org/cgit.cgi/moblin-app-installer/commit/?id=bc65c884d3a1ae37e69431417888126b2a3ea021
 
 - applist.xml contains lots of packages that are not part of Fedora. At least
 the closed source apps like AdobeReader or World of Go should IMO be removed.
 Other packages need their names fixed (like kanagram, khangman and kiten which
 are part of the kdeedu package).
 
 - applist.xml should be packaged as separate package, see README  

Updated SRPM:
http://pbrobinson.fedorapeople.org/moblin-app-installer-0.4.0-0.3.fc12.src.rpm

Fixed all of the above. Dropped the applist.xml file and will look at what's
required to package separately or use local repos.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 523526] Review Request: clutter-box2d - 2D physics simulation layer for Clutter

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523526


Alexander Boström a...@root.snowtree.se changed:

   What|Removed |Added

 CC||a...@root.snowtree.se




--- Comment #1 from Alexander Boström a...@root.snowtree.se  2010-01-02 
20:00:15 EDT ---
Well... It contains a copy of box2d. Maybe that's formally ok since box2d is
not packaged yet, but it's certainly not ideal. It probably best to DDRT from
the start by packaging it separately.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 546301] Review Request: moblin-app-installer - Moblin Application Installer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546301





--- Comment #4 from Christoph Wickert cwick...@fedoraproject.org  2010-01-02 
20:37:05 EDT ---
(In reply to comment #3)

 Dropped the applist.xml file and will look at what's
 required to package separately or use local repos.  

Without the file the package is pretty useless, so please don't build it for
F12 yet. Feel free to CC me when you submit a package for the applist data.

Please also remove adobe-reader.png, skype.png and world-of-goo.png from the
package because I'm not sure about there licenses. chromium.png should be ok I
guess, but all these should be in the applist package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 550139] Review Request: pino - A fast, easy and free Twitter client

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550139


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cwick...@fedoraproject.org
 AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org
   Flag||fedora-review?




--- Comment #4 from Christoph Wickert cwick...@fedoraproject.org  2010-01-02 
21:10:06 EDT ---
(In reply to comment #1)
 - You need to add 'hicolor-icon-theme' as a requirement to avoid issues with
 the ownership of the %{_datadir}/icons/hicolor directory

Requiring hicolor-icon-theme is not strictly needed because gtk2 already
requires it. It is however recommended.

 - Can you please take a look at your BRs .  Isn't gettext needed by intltool

not on older releases such as EPEL, so I suggest to leave it in.

 The rpmlint output
 
 [...@localhost i686]$ rpmlint pino*
 pino-debuginfo.i686: E: debuginfo-without-sources

This one is fixed in with the new package.

(In reply to comment #3)
 - Update to 0.1.0  

Please update to 0.1.1 and then I will review the package. Some more comments:

- Timestamps of both the spec and the source are one year in the future. Please
take care of the timestamps, see 
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

- (Try to) Use Fedoras waf instead of the included version to build the
package.

- %description should be more detailed and end with a dot.

- Don't hardcode /usr in --prefix=/usr. Use the %{_prefix} macro instead, see
http://fedoraproject.org/wiki/Packaging:RPMMacros

- You could use a few more wildcards: Instead of

%{_datadir}/icons/hicolor/scalable/actions/mentions.svg
%{_datadir}/icons/hicolor/scalable/actions/timeline.svg
%{_datadir}/icons/hicolor/scalable/apps/pino.svg
%{_datadir}/icons/hicolor/scalable/apps/pino_fresh.svg

use

%{_datadir}/icons/hicolor/scalable/*/*.svg

But this is minor and up to you. The rest looks fine, package works as
described. Looking forward to see it in Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 549366] Review Request: flaw - Small multiplayer action game

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549366


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

Summary|Review Request: flaw -  |Review Request: flaw -
   |F.L.A.W is a small  |Small multiplayer action
   |multiplayer action game |game




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551911] New: Review Request: monodevelop-boo - A boo plugin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: monodevelop-boo - A boo plugin for monodevelop

https://bugzilla.redhat.com/show_bug.cgi?id=551911

   Summary: Review Request: monodevelop-boo - A boo plugin for
monodevelop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@all-the-johnsons.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SRPM URL:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-boo-2.2-1.fc13.src.rpm
Description: This is a simple boo plugin for monodevelop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551912] New: Review Request: monodevelop-java - A boo plugin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: monodevelop-java - A boo plugin for monodevelop

https://bugzilla.redhat.com/show_bug.cgi?id=551912

   Summary: Review Request: monodevelop-java - A boo plugin for
monodevelop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@all-the-johnsons.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SRPM URL:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-java-2.2-1.fc13.src.rpm
Description: This is a simple Java plugin for monodevelop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551913] New: Review Request: monodevelop-vala - A vala plugin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: monodevelop-vala - A vala plugin for monodevelop

https://bugzilla.redhat.com/show_bug.cgi?id=551913

   Summary: Review Request: monodevelop-vala - A vala plugin for
monodevelop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@all-the-johnsons.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SRPM URL:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-valaa-2.2-1.fc13.src.rpm
Description: This is a simple vala plugin for monodevelop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551914] New: Review Request: monodevelop-database - A database plugin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: monodevelop-database - A database plugin for 
monodevelop

https://bugzilla.redhat.com/show_bug.cgi?id=551914

   Summary: Review Request: monodevelop-database - A database
plugin for monodevelop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@all-the-johnsons.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SRPM URL:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-database-2.2-1.fc13.src.rpm
Description: This addin for monodevelop give support for multiple database
systems

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551915] New: Review Request: monodevelop-debugger-gdb - A gdb debugger addin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: monodevelop-debugger-gdb - A gdb debugger addin for 
monodevelop

https://bugzilla.redhat.com/show_bug.cgi?id=551915

   Summary: Review Request: monodevelop-debugger-gdb - A gdb
debugger addin for monodevelop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@all-the-johnsons.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SRPM URL:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-debugger-gdb-2.2-1.fc13.src.rpm
Description: A debugger plugin for monodevelop which uses gdb

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 551913] Review Request: monodevelop-vala - A vala plugin for monodevelop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551913





--- Comment #1 from Paul F. Johnson p...@all-the-johnsons.co.uk  2010-01-02 
21:27:46 EDT ---
URL correction

http://www.all-the-johnsons.co.uk/fedora/monodevelop-vala-2.2-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607


David A. Wheeler dwhee...@dwheeler.com changed:

   What|Removed |Added

   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607





--- Comment #28 from David A. Wheeler dwhee...@dwheeler.com  2010-01-02 
22:46:45 EDT ---
 I can't account for the timestamp difference you see, but since the time is 
 off
by 2 hours in one direction and the time zone is off by 2 hours in the other
direction, they represent the same time.

You're right!  They're the same time, and that text is the only difference. 
That is a weird thing that svn does, but that's a clear explanation... it
appears that in certain cases, svn uses the local timezone when retrieving, and
thus I see a difference that isn't really a difference at all.  Great; that
means that that MUST is resolved.

And I see what you mean about the .so files.  You're right, those MUSTs are
vacuously satisfied.

So: all requirements are met.  Thank you SO MUCH for packaging PVS; this one
required real work to make it 64-bit-ready, and was *tricky* for other reasons
too.  Great job.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 548607] Review Request: pvs-sbcl - SRI's Prototype Verification System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548607


Jerry James loganje...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-cvs?




--- Comment #29 from Jerry James loganje...@gmail.com  2010-01-02 23:17:30 
EDT ---
New Package CVS Request
===
Package Name: pvs-sbcl
Short Description: Interactive theorem prover from SRI
Owners: jjames
Branches: F-11 F-12
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 523526] Review Request: clutter-box2d - 2D physics simulation layer for Clutter

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523526





--- Comment #2 from Peter Robinson pbrobin...@gmail.com  2010-01-02 23:22:12 
EDT ---
What's DDRT?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 532286] Review Request: treeline - Store almost any kind of information in a tree structure

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532286


Jean-Francois Saucier jfsauc...@infoglobe.ca changed:

   What|Removed |Added

 CC||jfsauc...@infoglobe.ca




--- Comment #1 from Jean-Francois Saucier jfsauc...@infoglobe.ca  2010-01-03 
00:35:52 EDT ---
 treeline.x86_64: E: no-binary

I think you should add this to your spec file to specify that your package is
not arch specific :

BuildArch: noarch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review