[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/show_bug.cgi?id=191671 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-28 11:11 EST --- Sindre, please close you reviews if your package becomes available. Closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 17:49 EST --- Just a reminder that this report should probably be closed, package is in CVS, owners.list and in the FE repos. BTW. 0.7 is out. :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-06-10 16:51 EST --- Just a reminder that this report should probably be closed, package is in CVS, owners.list and in the FE repos. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 08:37 EST --- Is there a particular reason not to use serpentine-0.6.91? http://developer.berlios.de/project/shownotes.php?group_id=3081release_id=9269 0.6.91 introduces support for gstreamer-1.0 and fixes the issuse with the russian desktop.file and translations. Unfortunately German translations were dropped :(, maybe I'm going to update them. Attaching a patch. This patch also fixes the following issues: - own /usr/lib/python2.4/site-packages/serpentine and /usr/share/serpentine (comment #1) - drop python-abi Requires: (comment # 4) - drop serpentine-0.6.4-desktop.patch and use sed instead - description now ends with a dot: ...simplicity, usability and compatibility. BTW: IMHO description could be a little mor elaborate, something like: Serpentine is an application for writing CD-Audio discs. It aims for simplicity, usability and compatibility and accepts a big range of audio (and video) formats thanks to the excelent GStreamer framework. It also tries to integrate well with other applications, accepting full Drag N Drop from applications like Nautilus, Rhythmbox and even Firefox. (parts taken from http://gnomefiles.org/app.php?soft_id=907) - require gstreamer-python instead of gstreamer08-python - remove-category X-Ximian-Main from fedora-serpentine.desktop A minor note: Calling update-desktop-database in post and postun was not necessary, because the desktop entry did not contain a mime type. 0.6.91 has a mime type, so we do need it now. Take what you need from my patch and update your package please. I'm going do do a complete review then. From what I've seen everything looks fine, package builds in mock and works well. I've successfully burned a couple of audio discs, in fact I'm using serpentine for a long time and rolled my own package. Nice to see somebody is willing to maintain it for extras. :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 09:59 EST --- Updated spec: http://folk.ntnu.no/sindrb/packages/serpentine.spec Updated SRPM: http://folk.ntnu.no/sindrb/packages/serpentine-0.6.91-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 11:53 EST --- $ md5sum serpentine-0.6.91-1.src.rpm 5965ec6a4622440337452084f79c5c59 serpentine-0.6.91-1.src.rpm REVIEW: - rpmlint clean: $ ls *.rpm serpentine-0.6.91-1.noarch.rpm serpentine-0.6.91-1.src.rpm $ rpmlint *.rpm ; echo $? 0 - package and spec naming OK - package meets guidelines - license is GPL, matches license field spec - license both included in source and %doc - spec file written in English and is legible - sources match upstream - package builds OK on FC5 (noarch) and in FC5 and rawhide mock (noarch) - BR's OK, on duplicates, no exeptions - locales handled correctly - no libraries to worry about - not relocatable - no directory ownership issues - no duplicates in %files - permissions OK, correct %defattr - %clean section present and correct - macro usage consistent - code, not content - no large docs - docs don't affect runtime - no pkgconfigs to worry about - no devel sub package needed - desktop file OK and properly installed - scriptlets match examples from wiki APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 16:57 EST --- I'm jumping in for a formal review. Stay tuned. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-16 15:58 EST --- A few preliminary comments: * These directories should be owned, otherwise they hang around after uninstalling: /usr/lib/python2.4/site-packages/serpentine /usr/share/serpentine * The russian entry in the .desktop file doesn't seem to be UTF-8... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-05-16 18:22 EST --- How can I deal with the russian entry issue? The ru.po file claims to be utf-8. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191671] Review Request: serpentine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 --- Additional Comments From [EMAIL PROTECTED] 2006-05-16 19:21 EST --- I'm pretty sure it's not UTF-8. I ran through a bunch of encodings and didn't see one that would produce meaningful output when viewed on a Unicode-capable terminal. I would ask upstream. If you have no luck there, you could always remove the Russian translation and work to get it in later. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
