[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC||kana...@kanarip.com --- Comment #15 from Jason Tibbitts ti...@math.uh.edu 2009-03-17 18:39:08 EDT --- *** Bug 490757 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 Bug 427121 depends on bug 373861, which changed state. Bug 373861 Summary: add fortran modules macro and FFLAGS switch https://bugzilla.redhat.com/show_bug.cgi?id=373861 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2008-12-24 07:58:59 EDT --- grib_api-1.6.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2008-12-24 13:41:26 EDT --- grib_api-1.6.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #11 from Fedora Update System [EMAIL PROTECTED] 2008-12-03 06:37:05 EDT --- grib_api-1.6.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/grib_api-1.6.4-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 Patrice Dumas [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Patrice Dumas [EMAIL PROTECTED] 2008-12-03 10:38:46 EDT --- The release I mentionned in Comment #9 has still tests failing, but the latest release builds and tests fine! Thanks for your patience and remainders. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #10 from Jason Tibbitts [EMAIL PROTECTED] 2008-12-02 18:30:39 EDT --- Is there any chance of closing this now, nine months after the review has been completed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #9 from Patrice Dumas [EMAIL PROTECTED] 2008-08-12 11:23:29 EDT --- I had a look last month, and it was not ready, but it looks like there is a new release now. I'll try to update and let you know. (I don't have a lot of time currently, but I should be done in one week at most). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Comment #8 from Jason Tibbitts [EMAIL PROTECTED] 2008-08-08 12:32:42 EDT --- Are we still waiting for upstream to do something? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 Bug 427121 depends on bug 373861, which changed state. Bug 373861 Summary: add fortran modules macro and FFLAGS switch https://bugzilla.redhat.com/show_bug.cgi?id=373861 What|Old Value |New Value Status|CLOSED |ASSIGNED Resolution|RAWHIDE | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:55 EST --- Yes, I am waiting for upstream for the next release to build the package, as they asked, and as it isn't built I don't close the bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Additional Comments From [EMAIL PROTECTED] 2008-05-30 20:40 EST --- Any reason this is still open? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 Bug 427121 depends on bug 373861, which changed state. Bug 373861 Summary: add fortran modules macro and FFLAGS switch https://bugzilla.redhat.com/show_bug.cgi?id=373861 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-03 15:03 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:17 EST --- This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it. I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor. Which name did you think was too generic? I guess typesizes.mod might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:29 EST --- (In reply to comment #3) This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it. According to upstream it is fixed, but upstream also asked me to wait for the next release to make a release. I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor. I am discussing adding shared libs with the debian maintainer (upstream agreed), so I'll prefer to keep them. Which name did you think was too generic? I guess typesizes.mod might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable. It is because I prefixed 2 of them... .mod files should really not be generic, I hope that we end up with a lof of .mod files... Thanks for the review! New Package CVS Request === Package Name: grib_api Short Description: ECMWF encoding/decoding GRIB software Owners: pertusus Branches: InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||373861 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software
https://bugzilla.redhat.com/show_bug.cgi?id=427121
--- Additional Comments From [EMAIL PROTECTED] 2008-02-23 10:02 EST ---
(In reply to comment #1)
Builds OK; rpmlint has many complaints about the .sh files in the
documentation being executable, for example:
grib_api-devel.x86_64: W: spurious-executable-perm
/usr/share/doc/grib_api-devel-1.3.0/examples/precision_fortran.sh
which, though I don't like executable documentation in general, I suppose are
OK as long as they don't generate additional dependencies. (They don't seem
to do so.)
I agree, but in that case they are auto-documenting the arguments
for the examples. And they are set up such that it should be easy to
rerun them.
Also,
grib_api-devel.x86_64: E: zero-length
/usr/share/doc/grib_api-devel-1.3.0/data/missing_new.grib2
which I guess is used by one of the examples and needs to be empty (although
you should verify this; we don't really want to be shipping empty files unless
there's some reason for it).
This warning is not there anymore.
You should use a complete URL for Source0; this seems to work:
http://www.ecmwf.int/products/data/software/download/software_files/%{name}-%{version}.tar.gz
I note that 1.4.0 is out; did you want to update to it? A naive update fails
to build because __dist_doc seems to have been changed a bit.
Yes, I updated to the latest version.
Without clarification from them I am
inclined to say that LGPLv3 is correct.
It seems so to me too. I contacted them, but in the mean time I think
that LGPLv3 is ok.
* description is OK (although some definition of grib might be considered
to
be kind to the users.
Done.
X license field matches the actual license.
Done.
X latest version is being packaged.
done.
* %check is present and all tests pass:
All 19 tests passed
All 14 tests passed
Now one test doesn't pass, I have contacted upstream. I disabled them
in the mean time.
There are .mod files that are not rightly placed for now, still
waiting on the fortran mod files guideline to be implemented.
I don't think it should be a blocker I'll do things right as soon
as it is implemented.
I also contacted upstream for names that are too generic.
http://www.environnement.ens.fr/perso/dumas/fc-srpms/grib_api.spec
http://www.environnement.ens.fr/perso/dumas/fc-srpms/grib_api-1.4.0-1.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software
https://bugzilla.redhat.com/show_bug.cgi?id=427121
--- Additional Comments From [EMAIL PROTECTED] 2008-02-22 20:18 EST ---
Builds OK; rpmlint has many complaints about the .sh files in the
documentation being executable, for example:
grib_api-devel.x86_64: W: spurious-executable-perm
/usr/share/doc/grib_api-devel-1.3.0/examples/precision_fortran.sh
which, though I don't like executable documentation in general, I suppose are
OK as long as they don't generate additional dependencies. (They don't seem
to do so.)
Also,
grib_api-devel.x86_64: E: zero-length
/usr/share/doc/grib_api-devel-1.3.0/data/missing_new.grib2
which I guess is used by one of the examples and needs to be empty (although
you should verify this; we don't really want to be shipping empty files unless
there's some reason for it).
You should use a complete URL for Source0; this seems to work:
http://www.ecmwf.int/products/data/software/download/software_files/%{name}-%{version}.tar.gz
I note that 1.4.0 is out; did you want to update to it? A naive update fails
to build because __dist_doc seems to have been changed a bit.
I believe the software is LGPLv3; that's what the upstream web site says, and
the LICENSE and source files seem to agree:
* Licensed under the GNU Lesser General Public License which
* incorporates the terms and conditions of version 3 of the GNU
* General Public License.
although that language is kind of bizarre and they also package a copy of the
GPLv3 (and a second copy of LGPLv3 for good measure, I guess) all in the
top-level directory of the tarball. Can you check with upstream to see
if they intend one or the other? Without clarification from them I am
inclined to say that LGPLv3 is correct.
The API documentation is about 70% of the -devel package, but I don't think
that's big enough to warrant splitting the package.
* source files match upstream:
36f31407f0c4aa64991f65f5d362d2b3efd986ea25b0d8f214772b21665a170b
grib_api-1.3.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK (although some definition of grib might be considered to
be kind to the users.
* dist tag is present.
* build root is OK.
X license field matches the actual license.
* license is open source-compatible.
* license text included in package.
X latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
? rpmlint has one complaint which may be valid.
* final provides and requires are sane:
grib_api-1.3.0-1.fc9.x86_64.rpm
grib_api = 1.3.0-1.fc9
=
libjasper.so.1()(64bit)
grib_api-devel-1.3.0-1.fc9.x86_64.rpm
grib_api-static = 1.3.0-1.fc9
grib_api-devel = 1.3.0-1.fc9
=
/bin/sh
grib_api = 1.3.0-1.fc9
* %check is present and all tests pass:
All 19 tests passed
All 14 tests passed
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers.
* no pkgconfig files.
* static libraries are in the -devel package, which is OK because there are no
dynamic libraries provided. The -static provide is present as required.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
