[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #17 from Chris St. Pierre stpie...@nebrwesleyan.edu 2009-06-24 09:18:22 EDT --- New spec file: http://fedora-ds-graph.svn.sourceforge.net/viewvc/fedora-ds-graph/trunk/389-ds-graph.spec?revision=52 New SRPM: http://internap.dl.sourceforge.net/sourceforge/fedora-ds-graph/389-ds-graph-1.1.2-1.fc10.src.rpm As you can see, I'm still on F10, where the package names haven't been updated yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added CC||joc...@herr-schmitt.de --- Comment #18 from Jochen Schmitt joc...@herr-schmitt.de 2009-06-24 12:37:25 EDT --- Hallo, I want to notify you, that the Fedora DS was rename to 389-ds, so it may be nice, if you can rename your package into 389-ds-graph. The reason, why the ds was renamed, was to clarified, that the 389-ds is not a fedora specific product. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #14 from Jason Tibbitts ti...@math.uh.edu 2009-06-23 14:47:12 EDT --- So, things didn't really work out with this package. I never managed to get far enough through my todo list to get back to this package, and now the whole fedora-ds thing has either been renamed or exists in another form as the 389-* packages. Given that, what should happen to this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #15 from Chris St. Pierre stpie...@nebrwesleyan.edu 2009-06-23 14:51:28 EDT --- Renaming the package would be easy enough. AFAIK, the 389-* packages aren't even out yet, so this isn't really behind the times that much. I'll get a new version turned out that replaces references to Fedora DS with 389 DS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #16 from Jason Tibbitts ti...@math.uh.edu 2009-06-23 15:37:24 EDT --- Well, my development box shows: 389-console.noarch : 389 Management Console 389-ds-base.i586 : 389 Directory Server (base) 389-ds-base-devel.i586 : Development libraries for 389 Directory Server so the 389 packages are definitely making it into the distro. koji shows shows eight source packages in the system: http://koji.fedoraproject.org/koji/search?match=globtype=packageterms=389* I expect they will continue to appear with successive pushes, although I admit I have no real knowledge of the plans for the 389-* packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Blocks||177841 --- Comment #9 from manuel wolfshant wo...@nobugconsulting.ro 2008-12-22 04:08:00 EDT --- http://fedoraproject.org/wiki/PackageMaintainers/Join should answer your questions. More precisely, see 1.1.9 (Get a Fedora Account ) and 1.1.11 (Get Sponsored) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2008-12-22 09:32:59 EDT --- Note that the Package Review Process document does explicitly link to the Join document; see the second paragraph in the Contributor section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #11 from Chris St. Pierre stpie...@nebrwesleyan.edu 2008-12-22 11:53:36 EDT --- The text was: A Contributor is defined as someone who wants to submit (and maintain) a package in Fedora. As a Contributor, you should have already made a package which adheres to the Package Naming Guidelines and Packaging Guidelines. You should also be aware of ForbiddenItems. If you are unsure how to become a contributor, or if you need more detailed instructions on this process, you should read PackageMaintainers/Join. The link is now unburied: A Contributor is defined as someone who wants to submit (and maintain) a package in Fedora. To become a contributor, you must follow the detailed instructions on this process at PackageMaintainers/Join. As a Contributor, you should have already made a package which adheres to the Package Naming Guidelines and Packaging Guidelines. You should also be aware of ForbiddenItems. Additionally, the http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored mentions the proper procedure when submitting your first review request, which I evidently didn't follow, since my bug didn't block FE-NEEDSPONSOR until you added that for me (thanks!). I can't seem to find that procedure anywhere, though; if there's more to it than using the form at https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedoraformat=extras-review, could you point me to that documentation, too, so I can a) make sure I didn't miss anything; and b) edit the wiki accordingly to make that more clear. Thanks again. FAS username is 'cstpierre'. Sponsorship will be found eventually, I suppose. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #12 from manuel wolfshant wo...@nobugconsulting.ro 2008-12-22 20:16:41 EDT --- Well, http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored says it all in the first 2 paragraphs. Quoting from over there: - it is necessary for you to show that you have an understanding of the process and of the packaging guidelines. - The best ways for you to illustrate your understanding of the packaging guidelines are to submit quality packages and to assist with package reviews. Prospective sponsors will want to see what reviews you have done, so go ahead and tell them when you submit your first package review request and add comments to your open review ticket with information about your activities. To cut it short: the current procedure asks for you to prove your packaging skills (in the context of Fedora rules). You can do that either by doing pre-reviews[*] of existing bugs ( http://fedoraproject.org/PackageReviewStatus/NEW.html is a cached list of open tickets) and/or by submitting several [ new ] packages. [*]Comment #1 is an example of such a pre-review. Only sponsored people may perform formal reviews. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #13 from Chris St. Pierre stpie...@nebrwesleyan.edu 2008-12-22 22:15:13 EDT --- Yep, already read that, thanks. As I mentioned, I'll be working on finding sponsorship eventually. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #7 from Jason Tibbitts ti...@math.uh.edu 2008-12-21 15:50:56 EDT --- Actually, I don't see you in the account system at all. Are you sure you have already been sponsored? What's your account ID in the Fedora system? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 --- Comment #8 from Chris St. Pierre stpie...@nebrwesleyan.edu 2008-12-21 16:39:28 EDT --- To the best of my knowledge, I'm not in the Fedora account system; I haven't been sponsored, nor, as far as I can tell, did I claim to be. The process document at http://fedoraproject.org/wiki/Package_Review_Process doesn't seem to suggest that I need to be sponsored. If that document is out of date, and I need to obtain the account and/or sponsorship of which you speak, I'd appreciate it if you could point me to more up-to-date documentation on the process. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 Chris St. Pierre [EMAIL PROTECTED] changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #6 from Chris St. Pierre [EMAIL PROTECTED] 2008-12-01 11:57:48 EDT --- Ready for review. New SRPM: http://downloads.sourceforge.net/fedora-ds-graph/fedora-ds-graph-1.1.0-1.src.rpm?use_mirror= -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Status Whiteboard||NotReady --- Comment #5 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-16 10:20:41 EDT --- Please clear the whiteboard when you are ready for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 Chris St. Pierre [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |eyan.edu) | --- Comment #4 from Chris St. Pierre [EMAIL PROTECTED] 2008-11-05 11:24:52 EDT --- Yes, I intend to fix all of these issues in the next version of Fedora DS Graph, but release of that has been held up by some unrelated issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435724 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Fabian Affolter [EMAIL PROTECTED] 2008-10-24 05:44:38 EDT --- Fedora DS Graph 1.0.2 was released at 22 September, 2008. An other appendix: %description - The line in the description is longer than 80 characters. rpmlint will complain about this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435724] Review Request: fedora-ds-graph - an rrdtool-based graphing utility for Fedora Directory Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435724
Oron Peled [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Oron Peled [EMAIL PROTECTED] 2008-08-14 16:21:12 EDT ---
This is not an official review, but some preliminary observations:
1. There is no ownership info in %files.
You should add something like:
%defattr(-,root,root,-)
Or alternatively specify %attr(-,owner,group) before files
that have specific ownership/groupship.
2. Release tag should be:
Release: 1%{dist}
3. License should be clarified. Pick the correct string from:
http://fedoraproject.org/wiki/Licensing
More info in:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
Your LICENSE file looks like GPLv2
4. This is a web application and it would fail to run with SELinux
activated. You should fix the context of the cgi script.
For a quick howto, look at:
http://fedoraproject.org/wiki/PackagingDrafts/SELinux
And probably create a subpackage fedora-ds-graph-selinux
5. No docs whatsoever. As a minimum you can add the COPYING
and CHANGELOG files. Also...
6. Since you are the upstream author:
* Adding a README would be even nicer.
* The common name is ChangeLog and not CHANGELOG.
* Exclude the .svn from the tarball, either via
tar command line flags, or by using 'svn export'
for the tarball.
7. Dependencies:
* The cgi is in perl and uses some modules in other packages, so:
Requires: perl, rrdtool-perl
* Time::Local and Symbol are part of perl package itself. OK.
8. The init script (ds-graph) does not follow Fedora common behaviour:
* Should use daemon function.
* Should touch and rm /var/lock/subsys/ds-graph
* Should observe exit status and return appropriate values.
Hope it helps and thank you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
