[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #13 from Fedora Update System 2009-01-21 16:30:50 EDT --- mingw32-pdcurses-3.4-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #12 from Fedora Update System 2009-01-17 06:51:27 EDT --- mingw32-pdcurses-3.4-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-pdcurses-3.4-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi 2009-01-16 22:26:02 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Richard W.M. Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Richard W.M. Jones 2009-01-16 13:16:12 EDT --- New Package CVS Request === Package Name: mingw32-pdcurses Short Description: Curses library for MinGW Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Tim Lauridsen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Tim Lauridsen 2009-01-16 12:04:18 EDT --- (In reply to comment #7) > (In reply to comment #4) > > $ md5sum PDCurses-3.4.tar.gz > > 65c9b1d4c5ef3e031039da620d6199ee PDCurses-3.4.tar.gz (upstream) > > 4e04e4412d1b1392a7f9a489b95b331a rpmbuild/SOURCES/PDCurses-3.4.tar.gz > > (SRPM) > > > > X Source checksum don't match upstream > > Are you sure about this one? I just downloaded it again and > I get the same (4e04...) md5sum: Ok, the must have been some download error :) 4e04e4412d1b1392a7f9a489b95b331a PDCurses-3.4.tar.gz 4e04e4412d1b1392a7f9a489b95b331a /home/tim/rpmbuild/SOURCES/PDCurses-3.4.tar.gz * Source match upstream APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #8 from Richard W.M. Jones 2009-01-16 04:18:24 EDT --- (In reply to comment #3) > $ rpmlint rpmbuild/RPMS/noarch/mingw32-pdcurses-3.4-2.fc10.noarch.rpm > mingw32-pdcurses.noarch: W: spurious-executable-perm > /usr/i686-pc-mingw32/sys-root/mingw/include/term.h Actually I will correct the executable perms on these header files before uploading. The executable perms on the library files should be OK though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #7 from Richard W.M. Jones 2009-01-16 04:16:13 EDT --- (In reply to comment #4) > $ md5sum PDCurses-3.4.tar.gz > 65c9b1d4c5ef3e031039da620d6199ee PDCurses-3.4.tar.gz (upstream) > 4e04e4412d1b1392a7f9a489b95b331a rpmbuild/SOURCES/PDCurses-3.4.tar.gz (SRPM) > > X Source checksum don't match upstream Are you sure about this one? I just downloaded it again and I get the same (4e04...) md5sum: $ wget 'http://downloads.sourceforge.net/pdcurses/PDCurses-3.4.tar.gz?modtime=1220886172&big_mirror=0' --2009-01-16 09:10:47-- http://downloads.sourceforge.net/pdcurses/PDCurses-3.4.tar.gz?modtime=1220886172&big_mirror=0 Resolving downloads.sourceforge.net... 216.34.181.60 Connecting to downloads.sourceforge.net|216.34.181.60|:80... connected. HTTP request sent, awaiting response... 302 Found Location: http://surfnet.dl.sourceforge.net/sourceforge/pdcurses/PDCurses-3.4.tar.gz [following] --2009-01-16 09:10:48-- http://surfnet.dl.sourceforge.net/sourceforge/pdcurses/PDCurses-3.4.tar.gz Resolving surfnet.dl.sourceforge.net... 130.59.138.20, 2001:620:0:1b::20 Connecting to surfnet.dl.sourceforge.net|130.59.138.20|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 331253 (323K) [application/x-tar] Saving to: `PDCurses-3.4.tar.gz' 100%[==>] 331,253 222K/s in 1.5s 2009-01-16 09:10:50 (222 KB/s) - `PDCurses-3.4.tar.gz' saved [331253/331253] $ md5sum PDCurses-3.4.tar.gz 4e04e4412d1b1392a7f9a489b95b331a PDCurses-3.4.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #6 from Tim Lauridsen 2009-01-16 04:11:27 EDT --- if the source in the SRPM is fixed to match upstream, then i will approve the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467388
--- Comment #5 from Tim Lauridsen 2009-01-16
04:10:27 EDT ---
MUST:
* package is named appropriately
mingw32-*
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine
* Packager, Vendor ,Distribution tag not used
* License used and not Copyright
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* /sbin/ldconfig used in packages containing libraries.
no native libs
* Not GUI app
* header files goes into -devel sub-package.
no native header files
* *.so goes into -devel sub-package.
no *.so files
* devel package require the base package using a fully versioned dependency
no *-devel
* *.la files is deleted.
no *.la files
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* The spec file handles locales properly (%find_lang ) (no locales)
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
. %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime
no docs
* follow the MinGW guidelines on http://fedoraproject.org/wiki/Packaging/MinGW
SHOULD:
* package should include license text in the package and mark it with %doc
no license file for Public Domain
* package should build on i386
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #4 from Tim Lauridsen 2009-01-16 04:10:07 EDT --- $ md5sum PDCurses-3.4.tar.gz 65c9b1d4c5ef3e031039da620d6199ee PDCurses-3.4.tar.gz (upstream) 4e04e4412d1b1392a7f9a489b95b331a rpmbuild/SOURCES/PDCurses-3.4.tar.gz (SRPM) X Source checksum don't match upstream -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #3 from Tim Lauridsen 2009-01-16 04:03:01 EDT --- $ rpmlint Download/mingw32-pdcurses-3.4-2.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/RPMS/noarch/mingw32-pdcurses-3.4-2.fc10.noarch.rpm mingw32-pdcurses.noarch: W: no-documentation mingw32-pdcurses.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/term.h mingw32-pdcurses.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/include/term.h mingw32-pdcurses.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libpdcurses.dll.a mingw32-pdcurses.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libpdcurses.dll.a mingw32-pdcurses.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/curses.h mingw32-pdcurses.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/include/curses.h mingw32-pdcurses.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/panel.h mingw32-pdcurses.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/include/panel.h mingw32-pdcurses.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libpdcurses.dll.a mingw32-pdcurses.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 1 packages and 0 specfiles checked; 1 errors, 10 warnings. This should be OK, because of the cross compiler nature of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Tim Lauridsen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Tim Lauridsen changed: What|Removed |Added CC||tim.laurid...@googlemail.co ||m AssignedTo|nob...@fedoraproject.org|tim.laurid...@googlemail.co ||m Flag||fedora-review? --- Comment #2 from Tim Lauridsen 2009-01-16 03:28:53 EDT --- I will review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 --- Comment #1 from Richard W.M. Jones <[EMAIL PROTECTED]> 2008-12-10 11:27:01 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/pdcurses/mingw32-pdcurses.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-pdcurses-3.4-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Bug 467388 depends on bug 454410, which changed state. Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++ https://bugzilla.redhat.com/show_bug.cgi?id=454410 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467407 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467388] Review Request: mingw32-pdcurses - Curses library for MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467388 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||454410 Alias||mingw32-pdcurses -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
