[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #17 from Fedora Update System upda...@fedoraproject.org  
2009-01-07 04:10:50 EDT ---
virtaal-0.2-2.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #16 from Fedora Update System upda...@fedoraproject.org  
2009-01-07 04:09:59 EDT ---
virtaal-0.2-2.fc10 has been pushed to the Fedora 10 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi ke...@tummy.com  2009-01-04 15:16:08 EDT ---
ok, sounds good. Nothing preventing them, just that we like to avoid making
them if they aren't needed. 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #13 from Dwayne Bailey dwa...@translate.org.za  2009-01-04 
16:43:53 EDT ---
Fabian, Brennan and Kevin - thanks for your work and effort to get this package
in. Happy 2009 to all of you... I'm busy getting the sources into CVS as I type
this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #15 from Fedora Update System upda...@fedoraproject.org  
2009-01-04 17:18:58 EDT ---
virtaal-0.2-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/virtaal-0.2-2.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #14 from Fedora Update System upda...@fedoraproject.org  
2009-01-04 17:18:55 EDT ---
virtaal-0.2-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/virtaal-0.2-2.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #11 from Dwayne Bailey dwa...@translate.org.za  2008-12-31 
05:31:36 EDT ---
There have been discussions around building activities for localisation, this
would require the future adaptation of the application.

I'm happy to drop the OLPC branches and request them later if needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #10 from Kevin Fenzi ke...@tummy.com  2008-12-31 00:46:13 EDT ---
Does this really need a OLPC-2 and OLPC-3 branch? 
Is OLPC-2 accepting new builds? And is this package going to be different in
the OLPC-3 branch from F-9 (which OLPC uses unless there are differences).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #7 from Dwayne Bailey dwa...@translate.org.za  2008-12-28 
14:10:43 EDT ---
(In reply to comment #6)
 [FAIL]specfile is properly named, is cleanly written and uses macros
 consistently.
 The spec file should not have the version or at least not the revision number
 as part of its name, it should be virtaal.spec

The name of the .spec file at the download link is just for tracking purposes,
my local copy is named virtaal.spec.

 [FAIL]BuildRequires are proper.
 
 You should not have desktop-file-utils see:
 http://fedoraproject.org/wiki/NewMIMESystem

Fixed

 [FAIL]rpmlint is silent.
 
 rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm
 ../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm 
 virtaal.src: E: invalid-spec-name
 
 Rename Spec file

See comment above

 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/recent.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/about.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/markup.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/document.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/formats.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/tips.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/__init__.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/terminology.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/main_window.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/store_model.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/modes.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/__version__.py 0644
 virtaal.noarch: E: non-executable-script
 /usr/lib/python2.5/site-packages/virtaal/rendering.py 0644
 2 packages and 1 specfiles checked; 36 errors, 0 warnings.

Should I fix these? These shouldn't be executable but they all have #! headers.

 [?]desktop files valid and installed properly.
 The version in the desktop file is 1.0 but 0.2 for the package is that 
 correct?

This is correct, it refers to the standard version, not the application 

[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Brennan Ashton bash...@brennanashton.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #8 from Brennan Ashton bash...@brennanashton.com  2008-12-28 
19:18:58 EDT ---
The non-executable is not and issue.  Thanks for the pointer on the version
number on the desktop file, I have not seen that variable used before. I did a
test on it and is seems to work correctly.
It is now:
APPROVED.  Apply for CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Dwayne Bailey dwa...@translate.org.za changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #9 from Dwayne Bailey dwa...@translate.org.za  2008-12-29 
02:37:00 EDT ---
New Package CVS Request
===
Package Name: virtaal
Short Description: Localization and translation editor
Owners: dwayne
Branches: F-9 F-10 EL-4 EL-5 OLPC-2 OLPC-3
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #6 from Brennan Ashton bash...@brennanashton.com  2008-12-27 
16:19:08 EDT ---
[x]source files match upstream:
b7942cb1b57897119062f6ff7a30c970b754e7d2728297a32228b02272785695 
virtaal-0.2.tar.bz2
[x]package meets naming and versioning guidelines.
[FAIL]specfile is properly named, is cleanly written and uses macros
consistently.
The spec file should not have the version or at least not the revision number
as part of its name, it should be virtaal.spec

[x]dist tag is present.
[x]build root is correct.
 (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

[x]license field matches the actual license.
[x]license is open source-compatible.
GPLv2+
[x]license text included in package.
[x]latest version is being packaged.
[FAIL]BuildRequires are proper.

You should not have desktop-file-utils see:
http://fedoraproject.org/wiki/NewMIMESystem

[x]compiler flags are appropriate.
[x]%clean is present.
[x]package builds in mock.
package installs properly.
[FAIL]rpmlint is silent.

rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm
../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm 
virtaal.src: E: invalid-spec-name

Rename Spec file

virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/recent.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/about.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/markup.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/document.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/formats.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/tips.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/terminology.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/main_window.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_model.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/modes.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__version__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/rendering.py 0644
2 packages and 1 specfiles checked; 36 

[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #5 from Dwayne Bailey dwa...@translate.org.za  2008-12-17 
04:49:12 EDT ---
Brennan - Do you want to take this one?  No change since we chatted on
#fedora-devel.  I dropped a message there but you might have missed it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Brennan Ashton bash...@brennanashton.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|bash...@brennanashton.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #4 from Dwayne Bailey [EMAIL PROTECTED]  2008-12-06 10:21:00 EDT 
---
Fabian - thanks for the review.  I disappeared on holiday just before.  My
comments below.

(In reply to comment #3)
 Just some quick comments on your spec file.
 
 - 'BuildRequires: python-devel' should be 'BuildRequires: python'
   https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

python-devel is still required, otherwise building fails.  I added python as a
build requires, although this is already pulled in by python-devel.

 - %{buildroot} and $RPM_BUILD_ROOT should not be mixed.

Fixed 

 - '--vendor=fedora \' is obsolete for new packages.
   see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

Fixed

 - remove '.fc9' in your %changelog section

Fixed

New SPEC: http://dwayne.fedorapeople.org/virtaal-0.2-2.spec
New SRPM: http://dwayne.fedorapeople.org/virtaal-0.2-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-12-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Bug 471754 depends on bug 466608, which changed state.

Bug 466608 Summary: Update translate-toolkit to the latest release 1.2
https://bugzilla.redhat.com/show_bug.cgi?id=466608

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-11-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Fabian Affolter [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #3 from Fabian Affolter [EMAIL PROTECTED]  2008-11-24 06:56:10 
EDT ---
Just some quick comments on your spec file.

- 'BuildRequires: python-devel' should be 'BuildRequires: python'
  https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

- %{buildroot} and $RPM_BUILD_ROOT should not be mixed.
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

- '--vendor=fedora \' is obsolete for new packages.
  see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

- remove '.fc9' in your %changelog section
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Bug 471754 depends on bug 466608, which changed state.

Bug 466608 Summary: Update translate-toolkit to the latest release 1.2
https://bugzilla.redhat.com/show_bug.cgi?id=466608

   What|Old Value   |New Value

 Status|FAILS_QA|ON_QA
 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED
 Resolution|NEXTRELEASE |
 Status|CLOSED  |ASSIGNED



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #1 from Fedora Update System [EMAIL PROTECTED]  2008-11-17 
04:16:53 EDT ---
translate-toolkit-1.2.0-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/translate-toolkit-1.2.0-3.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #2 from Dwayne Bailey [EMAIL PROTECTED]  2008-11-17 08:32:13 EDT 
---
(In reply to comment #1)
 translate-toolkit-1.2.0-3.fc9 has been submitted as an update for Fedora 9.
 http://admin.fedoraproject.org/updates/translate-toolkit-1.2.0-3.fc9

Ignore this, I set the wrong bug number of a translate-toolkit update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471754] Review Request: virtaal - Localization and translation editor

2008-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754


Dwayne Bailey [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||466608




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review