[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #7 from Alexander Kurtakov akurt...@redhat.com 2009-02-02 05:13:03 EDT --- Builded in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2009-02-01 06:13:43 EDT --- New Package CVS Request === Package Name: eclipse-cmakeed Short Description: CMake Editor plug-in for Eclipse Owners: akurtakov Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-02-01 14:02:56 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-31 15:00:28 EDT --- Thanks. Good to go. -- This package (eclipse-cmakeed) is APPROVED by oget -- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477144
--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-01-26
14:19:18 EDT ---
Spec URL:
http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec
SRPM URL:
http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.2-1.fc10.src.rpm
(In reply to comment #2)
Here's the review for this one.
* The prebuilt binaries need removed in %prep
./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar
./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar
./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar
Fixed.
* I believe that
./com.cthing.cmakeed.ui/doc/*
should go to %doc. These don't end up in the RPM otherwise, right?
No. This is documentation that is part of com.cting.cmakeed.ui_*.jar and is the
documentation shown inside the editor.
* Please make the description span across 80 columns. It'll look nicer.
Fixed.
* Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT
mixed. This needs corrected. You should also use %{__install} for consistency.
Fixed.
* Please make use of the %{version} macro, e.g. in Source0
Fixed.
* Latest version must be packaged. Please update to 1.1.1
Fixed. Updated to version 1.1.2.
* There is no license file in the sources. The upstream should be notified to
include a license file.
Fixed. Upstream released new version with License.html in it for us.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477144
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
--- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-23
14:39:00 EDT ---
Here's the review for this one.
* The prebuilt binaries need removed in %prep
./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar
./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar
./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar
* I believe that
./com.cthing.cmakeed.ui/doc/*
should go to %doc. These don't end up in the RPM otherwise, right?
* Please make the description span across 80 columns. It'll look nicer.
* Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT
mixed. This needs corrected. You should also use %{__install} for consistency.
* Please make use of the %{version} macro, e.g. in Source0
* Latest version must be packaged. Please update to 1.1.1
* There is no license file in the sources. The upstream should be notified to
include a license file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477144] Review Request: eclipse-cmakeed - CMake Editor plug-in for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-01-05 05:58:52 EDT --- Spec URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.0-1.fc10.src.rpm Update to 1.1.0 final. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
