[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 nucleo alekc...@googlemail.com changed: What|Removed |Added CC||alekc...@googlemail.com --- Comment #8 from nucleo alekc...@googlemail.com 2009-03-31 04:01:43 EDT --- Subtitle Composer not in Multimedia KDE memu but in Other. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 --- Comment #9 from Rex Dieter rdie...@math.unl.edu 2009-03-31 09:43:04 EDT --- nod, maybe: Categories=Qt;Video;AudioVideoEditing; would be better. See http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry for available categories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-03-19 23:01:34 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480235
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2009-03-18 09:09:04 EDT
---
Looking at
http://tuxbrewr.fedorapeople.org/subtitlecomposer
I don't see any scriptlets.
But I don't see any remaining problems or blockers, APPROVED.
Cosmetic items worth fixing before building:
1. icon scriptlets (see comment #3 for an example).
2. use kde4 macros like
%{_kde4_iconsdir} instead of %{_datadir}/icons
%{_kde4_appsdir} instead of %{_datadir}/kde4/apps
3. drop for KDE in summary/description. It should work just fine outside of
KDE.
4. Not sure if it's possible, but try to use a full URL for Source0. kde-apps
may make this difficult to do though. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 Steven M. Parrish tuxbr...@fedoraproject.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Steven M. Parrish tuxbr...@fedoraproject.org 2009-03-18 10:28:15 EDT --- New Package CVS Request === Package Name: subtitlecomposer Short Description: A text based subtitles editor Owners: tuxbrewr Branches: F9 F10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480235
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
CC||rdie...@math.unl.edu
--- Comment #1 from Rex Dieter rdie...@math.unl.edu 2009-01-15 15:23:48 EDT
---
initial comments from quick perusal:
1. use BR: kdelibs4-devel instead of kdelibs-devel (to avoid ambiguity)
2. omit
-DCMAKE_INSTALL_PREFIX=$(kde4-config --prefix) -DCMAKE_BUILD_TYPE=debugfull
not required or desired, %_cmake_kde4 macro includes both already
3. what's
-DKDE4_BUILD_TESTS:BOOL=${BUILD_TESTS}
for? I don't see BUILD_TESTS defined anywhere. ?
4. missing icon scriptlets
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 --- Comment #2 from Steven M. Parrish smparr...@shallowcreek.net 2009-01-15 16:07:31 EDT --- 1, 2, 3 all fixed Can you give an example of what you are looking at for #4. Never used scriplets for icons b4. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 --- Comment #3 from Rex Dieter rdie...@math.unl.edu 2009-01-15 16:14:16 EDT --- example, kdetoys: http://cvs.fedoraproject.org/viewvc/devel/kdetoys/kdetoys.spec?revision=1.42view=markup Requires(post): xdg-utils Requires(postun): xdg-utils %post xdg-icon-resource forceupdate --theme hicolor 2 /dev/null || : %postun xdg-icon-resource forceupdate --theme hicolor 2 /dev/null || : -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480235] Review Request: subtitlecomposer - A text-based subtitles editor for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 --- Comment #4 from Steven M. Parrish smparr...@shallowcreek.net 2009-01-15 19:09:58 EDT --- all fixed new spec and srpm online -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
