[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-02-25 11:24:32 EDT --- perl-Test-Harness-Straps-0.30-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 --- Comment #4 from Marcela Maslanova mmasl...@redhat.com 2009-02-13 03:26:20 EDT --- I've added BuildRequires: perl(Test::Simple) because here's live Test::More. It must be BR because the build failed with requires. Spec URL: http://mmaslano.fedorapeople.org/perl-Test-Harness-Straps/perl-Test-Harness-Straps.spec SRPM URL: http://mmaslano.fedorapeople.org/perl-Test-Harness-Straps/perl-Test-Harness-Straps-0.30-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 --- Comment #5 from Marcela Maslanova mmasl...@redhat.com 2009-02-13 03:59:40 EDT --- The BR should be perl(Test::More). Fixed, rebuilt. Spec URL: http://mmaslano.fedorapeople.org/perl-Test-Harness-Straps/perl-Test-Harness-Straps.spec SRPM URL: http://mmaslano.fedorapeople.org/perl-Test-Harness-Straps/perl-Test-Harness-Straps-0.30-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Miroslav Suchy msu...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Miroslav Suchy msu...@redhat.com 2009-02-13 04:03:33 EDT --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Marcela Maslanova mmasl...@redhat.com 2009-02-13 04:31:34 EDT --- New Package CVS Request === Package Name: perl-Test-Harness-Straps Short Description: Detailed analysis of test results Owners: mmaslano Branches: F-10 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-02-13 19:46:06 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Miroslav Suchy msu...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||msu...@redhat.com AssignedTo|nob...@fedoraproject.org|msu...@redhat.com --- Comment #2 from Miroslav Suchy msu...@redhat.com 2009-02-04 10:27:00 EDT --- I will look on this review. Please consider adding fedora-perl-devel-l...@redhat.com to cc when you create new Review Request of perl package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480944
Miroslav Suchy msu...@redhat.com changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #3 from Miroslav Suchy msu...@redhat.com 2009-02-04 10:56:22 EDT
---
You forgot to set flag fedora‑review? setting it for you.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
SEE LATER - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b72c0aa8950a6dfc1908b884fc768577 for both
N/A - Package needs ExcludeArch
FAIL - BuildRequires correct
N/A - Spec handles locales/find_lang
N/A - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
OK- Doc subpackage needed/used.
N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.
N/A - Package is a GUI app and has a .desktop file
FAIL - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
FAIL - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
perl-Test-Harness-Straps-0.30-1.fc11.noarch.rpm
perl(Test::Harness::Assert) = 0.02
perl(Test::Harness::Iterator) = 0.02
perl(Test::Harness::Iterator::ARRAY)
perl(Test::Harness::Iterator::FH)
perl(Test::Harness::Point) = 0.01
perl(Test::Harness::Results) = 0.01
perl(Test::Harness::Straps) = 0.30
perl-Test-Harness-Straps = 0.30-1.fc11
=
perl(:MODULE_COMPAT_5.10.0)
perl(Config)
perl(Exporter)
perl(Test::Harness::Assert)
perl(Test::Harness::Iterator)
perl(Test::Harness::Point)
perl(Test::Harness::Results)
perl(strict)
perl(vars)
SHOULD Items:
OK, tested on x86_64 - Should build in mock.
OK - Should build on all supported archs
Didn't test - Should function as described.
No scriptlets - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version
N/A - check for outstanding bugs on package. (For core merge reviews)
TODO:
please add build requires: perl(Test::More)
it is no more part of perl itself in Fedora 11
http://koji.fedoraproject.org/koji/taskinfo?taskID=1103852
and try to build is as --scratch in koji
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480944] Review Request: perl-Test-Harness-Straps - Detailed analysis of test results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480944 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added CC||ska...@redhat.com --- Comment #1 from Marcela Maslanova mmasl...@redhat.com 2009-01-21 09:34:33 EDT --- Test::Harness doesn't use Straps. These are included in this package only for backward compatibility. Details of problem are mentioned in this thread: www.nntp.perl.org/group/perl.perl5.porters/2009/01/msg143565.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
