[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2009-02-13 03:20:15 EDT --- looks ok now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #6 from Ralf Corsepius rc040...@freenet.de 2009-02-12 08:13:59 EDT --- This package suffers from a larger number of clashes with perl-Test-Unit: (In reply to comment #2) + Package perl-Test-Unit-Lite-0.1101-1.fc11 = Provides: perl(Test::Unit::Debug) perl(Test::Unit::HarnessUnit) perl(Test::Unit::Lite) = 0.11 perl(Test::Unit::Lite::AllTests) perl(Test::Unit::Result) perl(Test::Unit::TestCase) perl(Test::Unit::TestRunner) perl(Test::Unit::TestSuite) # rpm -ql --provides perl-Test-Unit .. perl(Test::Unit::Result) .. perl(Test::Unit::Runner) perl(Test::Unit::TestCase) .. perl(Test::Unit::TestRunner) perl(Test::Unit::TestSuite) I'd suggest to filter these out of perl-Test-Unit-Lite -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 --- Comment #7 from Parag AN(पराग) panem...@gmail.com 2009-02-12 10:32:55 EDT --- Ralf, Please help me to understand how to avoid such clashes in future perl package reviews? I think I just looked into code and see what META.yml said as provides. Also, I successfully installed this package using rpm command where I have already installed perl-Test-Unit. Did I miss anything in this review for such clash? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 --- Comment #8 from Ralf Corsepius rc040...@freenet.de 2009-02-12 11:33:04 EDT --- (In reply to comment #7) Please help me to understand how to avoid such clashes in future perl package reviews? These are hard to catch. The only semi-systematic approach I am aware about is to iterate through repoquery --whatprovides 'perl(..)' on all provides a perl package provides. I only caught these in this particular case, because another package BR'ed: perl(Test::Unit::TestCase), which resulted into this: # repoquery --whatprovides 'perl(Test::Unit::TestCase)' perl-Test-Unit-0:0.25-4.fc9.noarch perl-Test-Unit-0:0.25-4.fc9.noarch perl-Test-Unit-Lite-0:0.1101-1.fc10.noarch I think I just looked into code and see what META.yml said as provides. Also, I successfully installed this package using rpm command where I have already installed perl-Test-Unit. Right, I am also observing this, but ... what is BR: perl(Test::Unit::TestCase) supposed to do? IMO, to pull-in the actual perl(Test::Unit::TestCase) module, i.e. the version from perl-Test-Unit, not the lite version from perl-Test-Unit-Lite. I fear, we are facing the tip of an iceberg of hidden issues. Did I miss anything in this review for such clash? Strictly speaking, yes - but we all are humans :-) I likely also would not have caught this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 --- Comment #9 from Allisson Azevedo allis...@gmail.com 2009-02-12 11:59:48 EDT --- Hi, Please take a look in this scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1122217 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #5 from Allisson Azevedo allis...@gmail.com 2009-02-06 05:56:52 EDT --- Builds fine: http://koji.fedoraproject.org/koji/packageinfo?packageID=7656 Closing now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-02-05 21:47:10 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2009-02-04 03:55:32 EDT --- Review: + package builds in mock (rawhide i386). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1103094 + rpmlint is silent for SRPM and for RPM. + source files match upstream url bad27502bda4377fa6e7e39602b82aab Test-Unit-Lite-0.1101.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.71 CPU) + Package perl-Test-Unit-Lite-0.1101-1.fc11 = Provides: perl(Test::Unit::Debug) perl(Test::Unit::HarnessUnit) perl(Test::Unit::Lite) = 0.11 perl(Test::Unit::Lite::AllTests) perl(Test::Unit::Result) perl(Test::Unit::TestCase) perl(Test::Unit::TestRunner) perl(Test::Unit::TestSuite) Requires: perl = 0:5.006 perl(Carp) perl(Cwd) perl(Exporter) perl(File::Basename) perl(File::Copy) perl(File::Find) perl(File::Path) perl(File::Spec) perl(Symbol) perl(base) perl(strict) perl(warnings) Suggestions: 1) Take care to remove BR:perl before committing to cvs Another thing, I see META.yml specifies which provides: this package should provide which this package already providing so I see no filter required here. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Allisson Azevedo allis...@gmail.com 2009-02-04 05:27:14 EDT --- New Package CVS Request === Package Name: perl-Test-Unit-Lite Short Description: Unit testing without external dependencies Owners: allisson Branches: F-10 F-9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-01-29 11:03:21 EDT --- Not needed BuildRequires: perl = 0:5.006 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
