Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: reindent hlsenc code

[Liu Steven]

> 在 2017年10月27日，上午8:11，Steven Liu  写道：
> 
> Signed-off-by: Steven Liu 
> ---
> libavformat/hlsenc.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 530fc11305..0ea93480a5 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1081,13 +1081,13 @@ static int hls_window(AVFormatContext *s, int last)
> }
> avio_printf(out, "\n");
> }
> -if (hls->flags & HLS_ROUND_DURATIONS)
> -avio_printf(out, "#EXTINF:%ld,\n",  lrint(en->duration));
> -else
> -avio_printf(out, "#EXTINF:%f,\n", en->duration);
> -if (byterange_mode)
> -avio_printf(out, "#EXT-X-BYTERANGE:%"PRId64"@%"PRId64"\n",
> -en->size, en->pos);
> +if (hls->flags & HLS_ROUND_DURATIONS)
> +avio_printf(out, "#EXTINF:%ld,\n",  lrint(en->duration));
> +else
> +avio_printf(out, "#EXTINF:%f,\n", en->duration);
> +if (byterange_mode)
> +avio_printf(out, "#EXT-X-BYTERANGE:%"PRId64"@%"PRId64"\n",
> +en->size, en->pos);
> 
> if (hls->flags & HLS_PROGRAM_DATE_TIME) {
> time_t tt, wrongsecs;
> @@ -1113,9 +1113,9 @@ static int hls_window(AVFormatContext *s, int last)
> avio_printf(out, "#EXT-X-PROGRAM-DATE-TIME:%s.%03d%s\n", buf0, 
> milli, buf1);
> prog_date_time += en->duration;
> }
> -if (hls->baseurl)
> -avio_printf(out, "%s", hls->baseurl);
> -avio_printf(out, "%s\n", en->filename);
> +if (hls->baseurl)
> +avio_printf(out, "%s", hls->baseurl);
> +avio_printf(out, "%s\n", en->filename);
> }
> 
> if (last && (hls->flags & HLS_OMIT_ENDLIST)==0)
> -- 
> 2.11.0 (Apple Git-81)
> 
> 
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Applied!


Thanks



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix missing first segment bug in fmp4 mode

[Liu Steven]

> 在 2017年10月27日，上午8:11，Steven Liu  写道：
> 
> fix ticket id: #6776
> fix code logic error, need not check first segment.
> 
> Signed-off-by: Steven Liu 
> ---
> libavformat/hlsenc.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 55ce800c5a..530fc11305 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1080,7 +1080,7 @@ static int hls_window(AVFormatContext *s, int last)
> avio_printf(out, ",BYTERANGE=\"%"PRId64"@%"PRId64"\"", 
> en->size, en->pos);
> }
> avio_printf(out, "\n");
> -} else {
> +}
> if (hls->flags & HLS_ROUND_DURATIONS)
> avio_printf(out, "#EXTINF:%ld,\n",  lrint(en->duration));
> else
> @@ -1088,7 +1088,7 @@ static int hls_window(AVFormatContext *s, int last)
> if (byterange_mode)
> avio_printf(out, "#EXT-X-BYTERANGE:%"PRId64"@%"PRId64"\n",
> en->size, en->pos);
> -}
> +
> if (hls->flags & HLS_PROGRAM_DATE_TIME) {
> time_t tt, wrongsecs;
> int milli;
> @@ -1113,11 +1113,9 @@ static int hls_window(AVFormatContext *s, int last)
> avio_printf(out, "#EXT-X-PROGRAM-DATE-TIME:%s.%03d%s\n", buf0, 
> milli, buf1);
> prog_date_time += en->duration;
> }
> -if (!((hls->segment_type == SEGMENT_TYPE_FMP4) && (en == 
> hls->segments))) {
> if (hls->baseurl)
> avio_printf(out, "%s", hls->baseurl);
> avio_printf(out, "%s\n", en->filename);
> -}
> }
> 
> if (last && (hls->flags & HLS_OMIT_ENDLIST)==0)
> -- 
> 2.11.0 (Apple Git-81)
> 
> 
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Applied!

Thanks

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

[Liu Steven]

> 在 2017年10月26日，上午7:54，Steven Liu  写道：
> 
> fix ticket id: #6777
> when use argument hls_segment_filename, the basename_size will be 0
> 
> Signed-off-by: Steven Liu 
> ---
> libavformat/hlsenc.c | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 418f153c6f..55ce800c5a 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1335,6 +1335,7 @@ static int hls_write_header(AVFormatContext *s)
> AVDictionary *options = NULL;
> int basename_size = 0;
> int vtt_basename_size = 0;
> +int fmp4_init_filename_len = strlen(hls->fmp4_init_filename) + 1;
> 
> if (hls->segment_type == SEGMENT_TYPE_FMP4) {
> pattern = "%d.m4s";
> @@ -1445,7 +1446,6 @@ static int hls_write_header(AVFormatContext *s)
> }
> 
> if (av_strcasecmp(hls->fmp4_init_filename, "init.mp4")) {
> -int fmp4_init_filename_len = strlen(hls->fmp4_init_filename) + 1;
> hls->base_output_dirname = av_malloc(fmp4_init_filename_len);
> if (!hls->base_output_dirname) {
> ret = AVERROR(ENOMEM);
> @@ -1453,19 +1453,25 @@ static int hls_write_header(AVFormatContext *s)
> }
> av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, 
> fmp4_init_filename_len);
> } else {
> -hls->base_output_dirname = av_malloc(basename_size);
> +if (basename_size > 0) {
> +hls->base_output_dirname = av_malloc(basename_size);
> +} else {
> +hls->base_output_dirname = 
> av_malloc(strlen(hls->fmp4_init_filename));
> +}
> if (!hls->base_output_dirname) {
> ret = AVERROR(ENOMEM);
> goto fail;
> }
> 
> -av_strlcpy(hls->base_output_dirname, s->filename, basename_size);
> -p = strrchr(hls->base_output_dirname, '/');
> +if (basename_size > 0) {
> +av_strlcpy(hls->base_output_dirname, s->filename, basename_size);
> +p = strrchr(hls->base_output_dirname, '/');
> +}
> if (p) {
> *(p + 1) = '\0';
> av_strlcat(hls->base_output_dirname, hls->fmp4_init_filename, 
> basename_size);
> } else {
> -av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, 
> basename_size);
> +av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, 
> fmp4_init_filename_len);
> }
> }
> 
> -- 
> 2.11.0 (Apple Git-81)
> 

Applied!

Thanks



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow in mov_write_single_packet Detected with clang and -fsanitize=signed-integer-overflow

[Vitaly Buka]

ping

On Fri, Oct 6, 2017 at 4:20 PM, Vitaly Buka  wrote:

> Signed-off-by: Vitaly Buka 
> ---
>  libavformat/movenc.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 2838286141..e70500ae2c 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -5354,6 +5354,10 @@ static int mov_write_single_packet(AVFormatContext
> *s, AVPacket *pkt)
>  // duration, but only helps for this particular track, not
>  // for the other ones that are flushed at the same time.
>  trk->track_duration = pkt->dts - trk->start_dts;
> +if (trk->start_dts != AV_NOPTS_VALUE)
> +trk->track_duration = pkt->dts - trk->start_dts;
> +else
> +trk->track_duration = 0;
>  if (pkt->pts != AV_NOPTS_VALUE)
>  trk->end_pts = pkt->pts;
>  else
> --
> 2.14.2.920.gcf0c67979c-goog
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/zscale: add explanation for error 3074

[Dxfhgwet]

Sent with [ProtonMail](https://protonmail.com) Secure Email.

0001-avfilter-zscale-add-explanation-for-error-3074.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

[Carl Eugen Hoyos]

2017-10-29 2:32 GMT+02:00 James Almer :
> On 10/28/2017 8:47 PM, Carl Eugen Hoyos wrote:

>> +uint8_t[4] transparency_color;  // background color for 
>> transparency
>
> This broke compilation

Should be fixed, sorry, I was already testing yuva2rgb on BE and
forgot to compile on my desktop.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

[James Almer]

On 10/28/2017 8:47 PM, Carl Eugen Hoyos wrote:
> 2017-10-28 23:50 GMT+02:00 Clément Bœsch :
>> On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote:
>>> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos :
>>>
 Attached patch is useful in combination with the transparency patch
 for paletteuse.
>>>
 +{ "background", "set a background color for transparency", 
 OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, 
 FLAGS },
>>>
>>> Locally changed to "lime" to make sure fate stays unchanged.
>>>
>>
>> Please use "transparency_color" as option name (and field struct).
> 
> I liked "background";-(
> 
>> Also, the correct type in the structure is uint8_t[4]
>>
>> And ideally, you would also document the option in doc/filters.texi
>>
>> You can apply any time with these changes.
> 
> Done, thank you!
> 
> Carl Eugen

> diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c
> index 03de317..2a04ae5 100644 (file)
> --- a/libavfilter/vf_palettegen.c
> +++ b/libavfilter/vf_palettegen.c
> @@ -27,6 +27,7 @@
>  #include "libavutil/internal.h"
>  #include "libavutil/opt.h"
>  #include "libavutil/qsort.h"
> +#include "libavutil/intreadwrite.h"
>  #include "avfilter.h"
>  #include "internal.h"
>  
> @@ -74,6 +75,7 @@ typedef struct PaletteGenContext {
>  struct range_box boxes[256];// define the segmentation of 
> the colorspace (the final palette)
>  int nb_boxes;   // number of boxes (increase 
> will segmenting them)
>  int palette_pushed; // if the palette frame is 
> pushed into the outlink or not
> +uint8_t[4] transparency_color;  // background color for 
> transparency

This broke compilation. It should be, if anything

uint8_t transparency_color[4];

>  } PaletteGenContext;
>  
>  #define OFFSET(x) offsetof(PaletteGenContext, x)
> @@ -81,6 +83,7 @@ typedef struct PaletteGenContext {
>  static const AVOption palettegen_options[] = {
>  { "max_colors", "set the maximum number of colors to use in the 
> palette", OFFSET(max_colors), AV_OPT_TYPE_INT, {.i64=256}, 4, 256, FLAGS },
>  { "reserve_transparent", "reserve a palette entry for transparency", 
> OFFSET(reserve_transparent), AV_OPT_TYPE_BOOL, {.i64=1}, 0, 1, FLAGS },
> +{ "transparency_color", "set a background color for transparency", 
> OFFSET(transparency_color), AV_OPT_TYPE_COLOR, {.str="lime"}, CHAR_MIN, 
> CHAR_MAX, FLAGS },
>  { "stats_mode", "set statistics mode", OFFSET(stats_mode), 
> AV_OPT_TYPE_INT, {.i64=STATS_MODE_ALL_FRAMES}, 0, NB_STATS_MODE-1, FLAGS, 
> "mode" },
>  { "full", "compute full frame histograms", 0, AV_OPT_TYPE_CONST, 
> {.i64=STATS_MODE_ALL_FRAMES}, INT_MIN, INT_MAX, FLAGS, "mode" },
>  { "diff", "compute histograms only for the part that differs from 
> previous frame", 0, AV_OPT_TYPE_CONST, {.i64=STATS_MODE_DIFF_FRAMES}, 
> INT_MIN, INT_MAX, FLAGS, "mode" },
> @@ -250,7 +253,7 @@ static void write_palette(AVFilterContext *ctx, AVFrame 
> *out)
>  
>  if (s->reserve_transparent) {
>  av_assert0(s->nb_boxes < 256);
> -pal[out->width - pal_linesize - 1] = 0xff00; // add a green 
> transparent color
> +pal[out->width - pal_linesize - 1] = AV_RB32(>transparency_color) 
> >> 8;
>  }
>  }



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

[Carl Eugen Hoyos]

2017-10-28 23:50 GMT+02:00 Clément Bœsch :
> On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote:
>> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos :
>>
>> > Attached patch is useful in combination with the transparency patch
>> > for paletteuse.
>>
>> > +{ "background", "set a background color for transparency", 
>> > OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, 
>> > FLAGS },
>>
>> Locally changed to "lime" to make sure fate stays unchanged.
>>
>
> Please use "transparency_color" as option name (and field struct).

I liked "background";-(

> Also, the correct type in the structure is uint8_t[4]
>
> And ideally, you would also document the option in doc/filters.texi
>
> You can apply any time with these changes.

Done, thank you!

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

[Carl Eugen Hoyos]

2017-10-17 23:27 GMT+02:00 Carl Eugen Hoyos :
> 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos :

> Remaining comment is:
> The paletteuse filter does not work correctly on big-endian

The issue was yuva->rgb on big-endian, patch sent.

Sorry, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]lsws/yuv2rgb: Fix yuva2rgb32 on big-endian hardware

[Carl Eugen Hoyos]

Hi!

Attached patch fixes using paletteuse with yuva input on big endian.

I will push soon, Carl Eugen
From 5f231955f4d09cb70b2ed6dd4229940b1b9ef910 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos 
Date: Sun, 29 Oct 2017 01:40:18 +0200
Subject: [PATCH] lsws/yuv2rgb: Fix yuva2rgb32 on big endian.

---
 libswscale/yuv2rgb.c |8 
 1 file changed, 8 insertions(+)

diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c
index 1fe5abe..737cbb0 100644
--- a/libswscale/yuv2rgb.c
+++ b/libswscale/yuv2rgb.c
@@ -267,7 +267,11 @@ ENDYUV2RGBLINE(8, 1)
 PUTRGB(dst_2, py_2, 0);
 ENDYUV2RGBFUNC()
 
+#if HAVE_BIGENDIAN
+YUV2RGBFUNC(yuva2argb_c, uint32_t, 1)
+#else
 YUV2RGBFUNC(yuva2rgba_c, uint32_t, 1)
+#endif
 LOADCHROMA(0);
 PUTRGBA(dst_1, py_1, pa_1, 0, 24);
 PUTRGBA(dst_2, py_2, pa_2, 0, 24);
@@ -301,7 +305,11 @@ ENDYUV2RGBLINE(8, 1)
 PUTRGBA(dst_2, py_2, pa_2, 0, 24);
 ENDYUV2RGBFUNC()
 
+#if HAVE_BIGENDIAN
+YUV2RGBFUNC(yuva2rgba_c, uint32_t, 1)
+#else
 YUV2RGBFUNC(yuva2argb_c, uint32_t, 1)
+#endif
 LOADCHROMA(0);
 PUTRGBA(dst_1, py_1, pa_1, 0, 0);
 PUTRGBA(dst_2, py_2, pa_2, 0, 0);
-- 
1.7.10.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

[Marton Balint]

On Sat, 28 Oct 2017, Clément Bœsch wrote:


On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote:

Signed-off-by: Marton Balint 
---
 fftools/ffplay.c | 67 +---
 1 file changed, 35 insertions(+), 32 deletions(-)



Won't this prevent using ffplay without a display? Think of playing audio
with ffplay on a headless machine (no display server).


No, for that, the user have to use -nodisp, and it should work the 
same way as before, because the window/renderer creating code is in an if 
(!display_disable) {...} block.


Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [BUMP][PATCH] avfilter/zscale: fix memory leak

[Moritz Barsnick]

On Sat, Oct 28, 2017 at 13:29:01 -0400, Dxfhgwet wrote:
> From: dxfhgwet 

A patch should name a proper author. Whether you establish that name
"dxfhgwet" used there instead of your real name is up to you, but the
email address doesn't identify you at all. (This remark is also valid
for your other submitted patch.)

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

[Clément Bœsch]

On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote:
> Signed-off-by: Marton Balint 
> ---
>  fftools/ffplay.c | 67 
> +---
>  1 file changed, 35 insertions(+), 32 deletions(-)
> 

Won't this prevent using ffplay without a display? Think of playing audio
with ffplay on a headless machine (no display server).

[...]

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

[Clément Bœsch]

On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote:
> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos :
> 
> > Attached patch is useful in combination with the transparency patch
> > for paletteuse.
> 
> > +{ "background", "set a background color for transparency", 
> > OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, 
> > FLAGS },
> 
> Locally changed to "lime" to make sure fate stays unchanged.
> 

Please use "transparency_color" as option name (and field struct).

Also, the correct type in the structure is uint8_t[4]

And ideally, you would also document the option in doc/filters.texi

You can apply any time with these changes.

Thanks,

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mark Thompson]

On 27/10/17 19:09, mmironov wrote:
> From b1b697aed459947cfa04bccdca0f7cfb5c8be72c Mon Sep 17 00:00:00 2001
> From: mmironov 
> Date: Fri, 27 Oct 2017 13:03:15 -0400
> Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs
>  based on AMF SDK

There isn't any sense in which this is "accelerated" is there?  Just say it's a 
hardware encoder (as you already do in the changelog).

> 
> Signed-off-by: mmironov 
> ---
>  Changelog|3 +-
>  compat/amd/amfsdkenc.h   | 1750 
> ++
>  configure|   28 +
>  libavcodec/Makefile  |4 +
>  libavcodec/allcodecs.c   |4 +
>  libavcodec/amfenc.c  |  463 
>  libavcodec/amfenc.h  |  131 
>  libavcodec/amfenc_h264.c |  467 +
>  libavcodec/amfenc_hevc.c |  354 ++
>  libavcodec/version.h |4 +-
>  10 files changed, 3205 insertions(+), 3 deletions(-)
>  create mode 100644 compat/amd/amfsdkenc.h
>  create mode 100644 libavcodec/amfenc.c
>  create mode 100644 libavcodec/amfenc.h
>  create mode 100644 libavcodec/amfenc_h264.c
>  create mode 100644 libavcodec/amfenc_hevc.c
> 
> diff --git a/Changelog b/Changelog
> index 6592d86..f0d22fa 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -6,7 +6,8 @@ version :
>  - Dropped support for OpenJPEG versions 2.0 and below. Using OpenJPEG now
>requires 2.1 (or later) and pkg-config.
>  - VDA dropped (use VideoToolbox instead)
> -
> +- AMF H.264 encoder
> +- AMF HEVC encoder
>  
>  version 3.4:
>  - deflicker video filter
> diff --git a/compat/amd/amfsdkenc.h b/compat/amd/amfsdkenc.h
> new file mode 100644
> index 000..a640c17
> --- /dev/null
> +++ b/compat/amd/amfsdkenc.h

(Ignoring the header, will consider this separately.)

> diff --git a/configure b/configure
> index 0e1ccaa..229443f 100755
> --- a/configure
> +++ b/configure
> @@ -304,6 +304,7 @@ External library support:
>  
>The following libraries provide various hardware acceleration features:
>--disable-audiotoolbox   disable Apple AudioToolbox code [autodetect]
> +  --disable-amfdisable AMF video encoding code [autodetect]
>--disable-cuda   disable dynamically linked Nvidia CUDA code 
> [autodetect]
>--enable-cuda-sdkenable CUDA features that require the CUDA SDK 
> [no]
>--disable-cuvid  disable Nvidia CUVID support [autodetect]
> @@ -1643,6 +1644,7 @@ EXTERNAL_LIBRARY_LIST="
>  HWACCEL_AUTODETECT_LIBRARY_LIST="
>  audiotoolbox
>  crystalhd
> + amf
>  cuda
>  cuvid
>  d3d11va

Lists in configure should be kept in alphabetical order.

> @@ -2785,12 +2787,16 @@ scale_npp_filter_deps="cuda libnpp"
>  scale_cuda_filter_deps="cuda_sdk"
>  thumbnail_cuda_filter_deps="cuda_sdk"
>  
> +amf_deps_any="dlopen LoadLibrary"
> +amf_encoder_deps="amf"
> +
>  nvenc_deps="cuda"
>  nvenc_deps_any="libdl LoadLibrary"
>  nvenc_encoder_deps="nvenc"
>  
>  h263_v4l2m2m_decoder_deps="v4l2_m2m h263_v4l2_m2m"
>  h263_v4l2m2m_encoder_deps="v4l2_m2m h263_v4l2_m2m"
> +h264_amf_encoder_deps="amf"
>  h264_crystalhd_decoder_select="crystalhd h264_mp4toannexb_bsf h264_parser"
>  h264_cuvid_decoder_deps="cuda cuvid"
>  h264_cuvid_decoder_select="h264_mp4toannexb_bsf"
> @@ -2809,6 +2815,7 @@ 
> h264_vaapi_encoder_deps="VAEncPictureParameterBufferH264"
>  h264_vaapi_encoder_select="cbs_h264 vaapi_encode"
>  h264_v4l2m2m_decoder_deps="v4l2_m2m h264_v4l2_m2m"
>  h264_v4l2m2m_encoder_deps="v4l2_m2m h264_v4l2_m2m"
> +hevc_amf_encoder_deps="amf"
>  hevc_cuvid_decoder_deps="cuda cuvid"
>  hevc_cuvid_decoder_select="hevc_mp4toannexb_bsf"
>  hevc_mediacodec_decoder_deps="mediacodec"
> @@ -2830,6 +2837,8 @@ mjpeg_vaapi_encoder_select="vaapi_encode jpegtables"
>  mpeg1_cuvid_decoder_deps="cuda cuvid"
>  mpeg1_v4l2m2m_decoder_deps="v4l2_m2m mpeg1_v4l2_m2m"
>  mpeg2_crystalhd_decoder_select="crystalhd"
> +amf_h264_encoder_select="h264_amf_encoder"
> +amf_hevc_encoder_select="hevc_amf_encoder"

These names aren't mentioned anywhere else.

>  mpeg2_cuvid_decoder_deps="cuda cuvid"
>  mpeg2_mmal_decoder_deps="mmal"
>  mpeg2_mediacodec_decoder_deps="mediacodec"
> @@ -6305,6 +6314,18 @@ else
>  disable cuda cuvid nvenc
>  fi
>  
> +if enabled x86; then
> +case $target_os in
> +mingw32*|mingw64*|win32|win64|cygwin*)
> +;;
> +*)
> +disable  amf
> +;;
> +esac
> +else
> +disable amf
> +fi

Why this OS test?  It should just be going by whether the relevant build 
packages are present.

> +
>  enabled nvenc &&
>  check_cc -I$source_path <  #include "compat/nvenc/nvEncodeAPI.h"
> @@ -6313,6 +6334,13 @@ void f(void) { struct { const GUID guid; } s[] = { { 
> NV_ENC_PRESET_HQ_GUID } };
>  int main(void) { return 0; }
>  EOF
>  
> +enabled amf &&
> +check_cc -I$source_path < +#include "compat/amd/amfsdkenc.h"
> +AMFFactory *factory;
> +int main(void) { return 0; }
> +EOF
> +

[FFmpeg-devel] libavcodec/magicyuv : remove unneed variable assignment

[Martin Vignali]

Hello,

In attach patch to remove unneed variable assignment (for left and left top
in gradient and median prediction)


in gradient prediction :
left and left top are not use in the first line(s)

and doesn't depend of previous value in the rest of the slice


in median prediction :
left and left top are unused in the first line(s)
no need to assign it twice, in interlace footage


pass fate-magicyuv test for me (os x)


Martin


0002-libavcodec-magicyuv-remove-unneed-variable-assignmen.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavcodec/magicyuvenc : fix warning

[Martin Vignali]

Hello,

Patch in attach fix clang warning

warning: suggest braces around initialization of subobject
[-Wmissing-braces]
PTable counts[256] = { 0 };


Martin


0001-libavcodec-magicyuvenc-fix-warning.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] ffplay: only use hardware accelerated SDL texture formats

[Marton Balint]

Typically only a small subset of the SDL texture formats are supported directly
by the SDL renderer drivers, the rest is software emulated. It's better if
libswscale does the format conversion to a hardware-accelerated texture format
instead of SDL.

This should fix video render slowdowns with some texture formats after
3bd2228d05a05eab5f91ac00b01efac9cb07649b.

Signed-off-by: Marton Balint 
---
 fftools/ffplay.c | 16 
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index bebc2b392b..4e1ff62dc4 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -1828,10 +1828,18 @@ static int configure_video_filters(AVFilterGraph 
*graph, VideoState *is, const c
 AVCodecParameters *codecpar = is->video_st->codecpar;
 AVRational fr = av_guess_frame_rate(is->ic, is->video_st, NULL);
 AVDictionaryEntry *e = NULL;
-int i;
+int nb_pix_fmts = 0;
+int i, j;
 
-for (i = 0; i < FF_ARRAY_ELEMS(pix_fmts); i++)
-pix_fmts[i] = sdl_texture_format_map[i].format;
+for (i = 0; i < renderer_info.num_texture_formats; i++) {
+for (j = 0; j < FF_ARRAY_ELEMS(sdl_texture_format_map) - 1; j++) {
+if (renderer_info.texture_formats[i] == 
sdl_texture_format_map[j].texture_fmt) {
+pix_fmts[nb_pix_fmts++] = sdl_texture_format_map[j].format;
+break;
+}
+}
+}
+pix_fmts[nb_pix_fmts] = AV_PIX_FMT_NONE;
 
 while ((e = av_dict_get(sws_dict, "", e, AV_DICT_IGNORE_SUFFIX))) {
 if (!strcmp(e->key, "sws_flags")) {
@@ -3741,7 +3749,7 @@ int main(int argc, char **argv)
 av_log(NULL, AV_LOG_VERBOSE, "Initialized %s renderer.\n", 
renderer_info.name);
 }
 }
-if (!window || !renderer) {
+if (!window || !renderer || !renderer_info.num_texture_formats) {
 av_log(NULL, AV_LOG_FATAL, "Failed to create window or renderer: 
%s", SDL_GetError());
 exit(1);
 }
-- 
2.13.6

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

[Carl Eugen Hoyos]

2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos :

> Attached patch is useful in combination with the transparency patch
> for paletteuse.

> +{ "background", "set a background color for transparency", 
> OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, 
> FLAGS },

Locally changed to "lime" to make sure fate stays unchanged.

Ping, will probably commit if there are no objections.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [RFC]lswr/rematrix: Support s32p

[Carl Eugen Hoyos]

Hi!

Attached patch fixes a random testcase for ticket #6785 here but I
don't know if this is the correct fix.

Please review, Carl Eugen
From a93b9309d74f5eadece371ee1e682d266af6cd83 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos 
Date: Sat, 28 Oct 2017 22:52:02 +0200
Subject: [PATCH] lswr/rematrix: Support s32p.

Fixes ticket #6785.
---
 libswresample/rematrix.c |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c
index 66a43c1..a6aa6b0 100644
--- a/libswresample/rematrix.c
+++ b/libswresample/rematrix.c
@@ -445,14 +445,23 @@ av_cold int swri_rematrix_init(SwrContext *s){
 s->mix_2_1_f = (mix_2_1_func_type*)sum2_double;
 s->mix_any_f = (mix_any_func_type*)get_mix_any_func_double(s);
 }else if(s->midbuf.fmt == AV_SAMPLE_FMT_S32P){
-// Only for dithering currently
-// s->native_matrix = av_calloc(nb_in * nb_out, sizeof(double));
-s->native_one= av_mallocz(sizeof(int));
+s->native_one= av_mallocz(sizeof(int64_t));
 if (!s->native_one)
 return AVERROR(ENOMEM);
-// for (i = 0; i < nb_out; i++)
-// for (j = 0; j < nb_in; j++)
-// ((double*)s->native_matrix)[i * nb_in + j] = s->matrix[i][j];
+s->native_matrix = av_calloc(nb_in * nb_out, sizeof(int));
+if (!s->native_matrix) {
+av_freep(>native_one);
+return AVERROR(ENOMEM);
+}
+for (i = 0; i < nb_out; i++) {
+double rem = 0;
+
+for (j = 0; j < nb_in; j++) {
+double target = s->matrix[i][j] * 32768 + rem;
+((int*)s->native_matrix)[i * nb_in + j] = lrintf(target);
+rem += target - ((int64_t*)s->native_matrix)[i * nb_in + j];
+}
+}
 *((int*)s->native_one) = 32768;
 s->mix_1_1_f = (mix_1_1_func_type*)copy_s32;
 s->mix_2_1_f = (mix_2_1_func_type*)sum2_s32;
-- 
1.7.10.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: change fate-ffmpeg-attached_pics to encode to pcm_s16le

[Marton Balint]

On Sat, 28 Oct 2017, Michael Niedermayer wrote:


On Fri, Oct 27, 2017 at 10:54:49PM +0200, Marton Balint wrote:

Previously alac encoder was used, from a first glance I thought it is bitexact,
but it turns out it is using floating point arithmetic as well, so probably it
is not. Fixes fate failures on mingw32/64.


seems working locally on mingw+wine here


Thanks, applied.

Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Feature suggestion for FFMPEG

[Carl Eugen Hoyos]

2017-10-28 14:10 GMT+02:00 Ben Hutchinson :
> Currently AAC audio can only be output within various
> container/encapsulation formats (such as MP4 or ADTS containers).

This is not correct.

Please post all usage questions on the user mailing list.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Feature suggestion for FFMPEG

[Ben Hutchinson]

FFMPEG should be able to output raw AAC audio stream, without any
encapsulation, in the same way that a raw h264 video stream can be output
from FFMPEG. Currently AAC audio can only be output within various
container/encapsulation formats (such as MP4 or ADTS containers). If you
try to output raw AAC by doing "-f aac" it gives the same error as if you
selected any other invalid container format, like "-f abcxyz". Please add
this feature so I can save a truly unencapsulated AAC audio stream.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lswr/swresample: Mention actually supported formats when erroring out

[Carl Eugen Hoyos]

2017-10-27 4:12 GMT+02:00 Michael Niedermayer :
> On Thu, Oct 26, 2017 at 05:03:37PM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch is supposed to fix ticket #6779.
>>
>> Please comment, Carl Eugen
>
>>  swresample.c |4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> d66bcf39e9ce53dad4db82a5202c7494fbf2d46c  
>> 0001-lswr-swresample-Mention-the-actually-supported-forma.patch
>> From 17ffc43ba32c83e0e1d26df06b7f4445adb1206b Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos 
>> Date: Thu, 26 Oct 2017 16:52:22 +0200
>> Subject: [PATCH] lswr/swresample: Mention the actually supported formats when
>>  erroring out.
>>
>> Fixes ticket #6779.
>> ---
>>  libswresample/swresample.c |4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> probably ok

Patch applied.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Carl Eugen Hoyos]

2017-10-27 20:09 GMT+02:00 mmironov :
> +const enum AVPixelFormat ff_amf_pix_fmts[] = {
> +AV_PIX_FMT_NV12,

> +AV_PIX_FMT_BGRA,
> +AV_PIX_FMT_ARGB,
> +AV_PIX_FMT_RGBA,

This is wrong, your encoders do not convert transparency
information, there are 32 rgb formats without alpha channel.

> +{ AV_PIX_FMT_NV12,   AMF_SURFACE_NV12 },
> +{ AV_PIX_FMT_D3D11,  AMF_SURFACE_NV12 },

Just curious: Can you explain this in simple words?

I will try not to comment on the headers you sent, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes)

[Carl Eugen Hoyos]

2017-10-27 21:28 GMT+02:00 Peter Große :
> On Thu, 26 Oct 2017 18:32:57 +0200
> Carl Eugen Hoyos  wrote:
>
>> 2017-10-26 18:28 GMT+02:00 Peter Große :
>> > On Thu, 26 Oct 2017 18:07:55 +0200
>> > Carl Eugen Hoyos  wrote:
>> >
>> >> Did you test our dash muxer lately with some validation tool?
>> >> Errors were reported in the past.
>> >
>> > No official validation tool, no.
>>
>> The following was mentioned in the past iirc:
>> http://www-itec.uni-klu.ac.at/dash/?page_id=605
>
> With the attached patch and checking against the current conformance XSD [1]
> instead of their "Standard XSD", I get a "Your DASH-MPD is VALID" logo.

Thank you for testing!

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes)

[Michael Niedermayer]

On Fri, Oct 27, 2017 at 09:28:16PM +0200, Peter Große wrote:
> On Thu, 26 Oct 2017 18:32:57 +0200
> Carl Eugen Hoyos  wrote:
> 
> > 2017-10-26 18:28 GMT+02:00 Peter Große :
> > > On Thu, 26 Oct 2017 18:07:55 +0200
> > > Carl Eugen Hoyos  wrote:
> > >  
> > >> Did you test our dash muxer lately with some validation tool?
> > >> Errors were reported in the past.  
> > >
> > > No official validation tool, no.  
> > 
> > The following was mentioned in the past iirc:
> > http://www-itec.uni-klu.ac.at/dash/?page_id=605
> 
> With the attached patch and checking against the current conformance XSD [1]
> instead of their "Standard XSD", I get a "Your DASH-MPD is VALID" logo.
> 
> Regards
> Peter
> 
> [1]
> https://github.com/Dash-Industry-Forum/Conformance-and-reference-source/blob/master/conformance/MPDValidator/schemas/DASH-MPD.xsd
> 
> 

>  dashenc.c |6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> b5414faf2d7a219c5d8a2335eb33799654cd773a  
> 0001-dashenc-move-UTCTiming-element-to-the-end-of-the-man.patch
> From 7a731e2d0d1fd9c771b0cc2730a812e84ae9981e Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Peter=20Gro=C3=9Fe?= 
> Date: Fri, 27 Oct 2017 21:18:47 +0200
> Subject: [PATCH 1/1] dashenc: move UTCTiming element to the end of the
>  manifest
> To: ffmpeg-devel@ffmpeg.org
> 
> Required by comformance XSD [1].
> 
> [1] 
> https://github.com/Dash-Industry-Forum/Conformance-and-reference-source/blob/master/conformance/MPDValidator/schemas/DASH-MPD.xsd
> ---
>  libavformat/dashenc.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)

applied

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

[Michael Niedermayer]

On Thu, Oct 26, 2017 at 08:51:50PM -0700, Sasi Inguva wrote:
> On Tue, Oct 24, 2017 at 2:48 PM, Michael Niedermayer  > wrote:
> 
> > On Mon, Oct 23, 2017 at 04:18:28PM -0700, Sasi Inguva wrote:
> > > Signed-off-by: Sasi Inguva 
> > > ---
> > >  libavformat/mov.c   | 15 +++-
> > >  tests/fate/mov.mak  |  4 ++
> > >  tests/ref/fate/mov-invalid-elst-entry-count | 57
> > +
> > >  3 files changed, 75 insertions(+), 1 deletion(-)
> > >  create mode 100644 tests/ref/fate/mov-invalid-elst-entry-count
> > >
> > > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > > index b22a116140..424293ad93 100644
> > > --- a/libavformat/mov.c
> > > +++ b/libavformat/mov.c
> > > @@ -4597,6 +4597,7 @@ static int mov_read_elst(MOVContext *c,
> > AVIOContext *pb, MOVAtom atom)
> > >  {
> > >  MOVStreamContext *sc;
> > >  int i, edit_count, version;
> > > +int64_t elst_entry_size;
> > >
> > >  if (c->fc->nb_streams < 1 || c->ignore_editlist)
> > >  return 0;
> > > @@ -4605,6 +4606,15 @@ static int mov_read_elst(MOVContext *c,
> > AVIOContext *pb, MOVAtom atom)
> > >  version = avio_r8(pb); /* version */
> > >  avio_rb24(pb); /* flags */
> > >  edit_count = avio_rb32(pb); /* entries */
> > > +atom.size -= 8;
> > > +
> > > +elst_entry_size = version == 1 ? 20 : 12;
> > > +if (atom.size != edit_count * elst_entry_size &&
> > > +c->fc->strict_std_compliance >= FF_COMPLIANCE_STRICT) {
> > > +av_log(c->fc, AV_LOG_ERROR, "Invalid edit list entry_count: %d
> > for elst atom of size: %"PRId64" bytes.\n",
> > > +   edit_count, atom.size + 8);
> > > +return AVERROR_INVALIDDATA;
> > > +}
> > >
> > >  if (!edit_count)
> > >  return 0;
> > > @@ -4617,17 +4627,20 @@ static int mov_read_elst(MOVContext *c,
> > AVIOContext *pb, MOVAtom atom)
> > >  return AVERROR(ENOMEM);
> > >
> > >  av_log(c->fc, AV_LOG_TRACE, "track[%u].edit_count = %i\n",
> > c->fc->nb_streams - 1, edit_count);
> > > -for (i = 0; i < edit_count && !pb->eof_reached; i++) {
> > > +for (i = 0; i < edit_count && atom.size > 0 && !pb->eof_reached;
> > i++) {
> > >  MOVElst *e = >elst_data[i];
> > >
> > >  if (version == 1) {
> > >  e->duration = avio_rb64(pb);
> > >  e->time = avio_rb64(pb);
> > > +atom.size -= 16;
> > >  } else {
> > >  e->duration = avio_rb32(pb); /* segment duration */
> > >  e->time = (int32_t)avio_rb32(pb); /* media time */
> > > +atom.size -= 8;
> > >  }
> > >  e->rate = avio_rb32(pb) / 65536.0;
> > > +atom.size -= 4;
> > >  av_log(c->fc, AV_LOG_TRACE, "duration=%"PRId64" time=%"PRId64"
> > rate=%f\n",
> > > e->duration, e->time, e->rate);
> >
> > it would be simpler to adjust edit_count in case of ineqality.
> > you already compute the elst_entry_size
> > this would also avoid allocating a larger than needed array
> >
> > Done. Attaching the corrected patch.
> 
> >
> > [...]
> >
> > --
> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > Many things microsoft did are stupid, but not doing something just because
> > microsoft did it is even more stupid. If everything ms did were stupid they
> > would be bankrupt already.
> >
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >

>  libavformat/mov.c   |   21 +-
>  tests/fate/mov.mak  |4 +
>  tests/ref/fate/mov-invalid-elst-entry-count |   57 
> 
>  3 files changed, 81 insertions(+), 1 deletion(-)
> c553340f66797876d039f408f83574a40c54d17b  
> 0001-lavf-mov.c-Fix-parsing-of-edit-list-atoms-with-inval.patch
> From 188602e662868a79c7f85e9193e9aedc9ba1a170 Mon Sep 17 00:00:00 2001
> From: Sasi Inguva 
> Date: Wed, 18 Oct 2017 20:11:16 -0700
> Subject: [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst
>  entry count.

applied

thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> No it doesn't work like that any more.
> 
> Some folks commit to maintained code by someone else without prior review.
> 
> Why I should not be one of them?

Are you trying to derail the project on purpose?

Now, please behave like a civilized member of a multi-user community. I
want to review the patch to make sure it is now correct (remember it is
the third iteration, the first two were wrong), because I care about
code quality. I need time and good access to the source code for that. I
am sorry, you will have to wait. Fortunately, this patch is not about
security or a regression, it is about a harmless limitation that have
been around for years, it can wait a few days more. I am sure you have
plenty better to do with your time.

This will probably the last mail I will have time to write this
week-end; I would have preferred to spend it on something more
interesting. When I come back, I expect to find things as is, or
possibly an even better version on the patch waiting on the mailing
list. Anything else would be a declaration of open hostility.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: change fate-ffmpeg-attached_pics to encode to pcm_s16le

[Michael Niedermayer]

On Fri, Oct 27, 2017 at 10:54:49PM +0200, Marton Balint wrote:
> Previously alac encoder was used, from a first glance I thought it is 
> bitexact,
> but it turns out it is using floating point arithmetic as well, so probably it
> is not. Fixes fate failures on mingw32/64.

seems working locally on mingw+wine here

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Paul B Mahol  wrote:
> On 10/28/17, Nicolas George  wrote:
>> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>>> I already posted another version which I will push shortly.
>>
>> No, you will wait until I approve the patch, since it is code that I
>> maintain. That is how it works.
>
> No it doesn't work like that any more.
>
> Some folks commit to maintained code by someone else without prior review.
>
> Why I should not be one of them?
>

And remmember, you are bad guy here.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> I already posted another version which I will push shortly.
>
> No, you will wait until I approve the patch, since it is code that I
> maintain. That is how it works.

No it doesn't work like that any more.

Some folks commit to maintained code by someone else without prior review.

Why I should not be one of them?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> I already posted another version which I will push shortly.

No, you will wait until I approve the patch, since it is code that I
maintain. That is how it works.

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] fate/vsrc_testsrc : add fate test for testsrc2 and small size

[Martin Vignali]

2017-10-28 18:39 GMT+02:00 Martin Vignali :

> Hello,
>
> Fate test for testsrc2 with small size
>
> Need to be apply after patch in discussion :
> libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size
>
>
>
New patch in attach with two tests
one for too small height (same as the previous patch)
one for too small width (add in this version)

relative to discussion : libavfilter/vsrc_testsrc : fix hang with testsrc2
and small size

Martin


0003-fate-testsrc2-add-test-for-two-hang-cases.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Paul B Mahol]

On 10/28/17, Martin Vignali  wrote:
> 2017-10-28 18:57 GMT+02:00 Nicolas George :
>
>> Le septidi 7 brumaire, an CCXXVI, Martin Vignali a ecrit :
>> > Don't know if there is a better way to fix it
>> > but if the variable stay unsigned
>> > this for loop create the problem
>> > for (y = ymin; y < ymax - 15; y += 16) {
>>
>> Looks like a job for FFMAX or FFMIN to me.
>>
>
> Not sure i understand, can you explain a little bit more ?
> In my test, using FFMAX, and FFMIN, with "negative" unsigned doesn't fix
> the problem
>
> for example with ymin = 1 and ymax = 1
> FFMIN(ymin, ymax-15) return 1
>
>
> And after tests, both dimensions need to be test
>
> the previous patch, doesn't fix this :
> ./ffmpeg -lavfi testsrc2=s=2x600 -vframes 3 -f null -
>
> so i propose something like this (but feel free to post a better approach)
>
> /* bottom right: checker with random noise */
> {
> int xmin = av_rescale(5, s->w, 8);//<== unsigned -> int
> int xmax = av_rescale(7, s->w, 8);//<== unsigned -> int
> int ymin = av_rescale(5, s->h, 8);//<== unsigned -> int
> int ymax = av_rescale(7, s->h, 8);//<== unsigned -> int
> unsigned i, r;
> int x, y;//<== unsigned -> int
> uint8_t alpha[256];
>
> r = s->pts;
> for (y = ymin; y < ymax - 15; y += 16) {//can hang
> for (x = xmin; x < xmax - 15; x += 16) {//can hang
> if ((x ^ y) & 16)
> continue;
> for (i = 0; i < 256; i++) {
> r = r * 1664525 + 1013904223;
> alpha[i] = r >> 24;
> }
> set_color(s, , 0xFF00FF80);
> ff_blend_mask(>draw, , frame->data,
> frame->linesize,
>frame->width, frame->height,
>alpha, 16, 16, 16, 3, 0, x, y);
> }
> }
> }
>
> Martin
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Welcome to endless bikeshed.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Martin Vignali]

2017-10-28 18:57 GMT+02:00 Nicolas George :

> Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit :
> > Don't know if there is a better way to fix it
> > but if the variable stay unsigned
> > this for loop create the problem
> > for (y = ymin; y < ymax - 15; y += 16) {
>
> Looks like a job for FFMAX or FFMIN to me.
>

Not sure i understand, can you explain a little bit more ?
In my test, using FFMAX, and FFMIN, with "negative" unsigned doesn't fix
the problem

for example with ymin = 1 and ymax = 1
FFMIN(ymin, ymax-15) return 1


And after tests, both dimensions need to be test

the previous patch, doesn't fix this :
./ffmpeg -lavfi testsrc2=s=2x600 -vframes 3 -f null -

so i propose something like this (but feel free to post a better approach)

/* bottom right: checker with random noise */
{
int xmin = av_rescale(5, s->w, 8);//<== unsigned -> int
int xmax = av_rescale(7, s->w, 8);//<== unsigned -> int
int ymin = av_rescale(5, s->h, 8);//<== unsigned -> int
int ymax = av_rescale(7, s->h, 8);//<== unsigned -> int
unsigned i, r;
int x, y;//<== unsigned -> int
uint8_t alpha[256];

r = s->pts;
for (y = ymin; y < ymax - 15; y += 16) {//can hang
for (x = xmin; x < xmax - 15; x += 16) {//can hang
if ((x ^ y) & 16)
continue;
for (i = 0; i < 256; i++) {
r = r * 1664525 + 1013904223;
alpha[i] = r >> 24;
}
set_color(s, , 0xFF00FF80);
ff_blend_mask(>draw, , frame->data,
frame->linesize,
   frame->width, frame->height,
   alpha, 16, 16, 16, 3, 0, x, y);
}
}
}

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [BUMP][PATCH] avfilter/zscale: fix memory leak

[Dxfhgwet]

Sent with [ProtonMail](https://protonmail.com) Secure Email.

0001-avfilter-zscale-fix-memory-leak.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library error

[Dxfhgwet]

> Original Message 
>Subject: Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library 
>error
>Local Time: October 28, 2017 1:26 AM
>UTC Time: October 28, 2017 8:26 AM
>From: one...@gmail.com
>To: FFmpeg development discussions and patches 
>
>On 10/28/17, Dxfhgwet dxfhg...@protonmail.com wrote:
>>Sent with ProtonMail Secure Email.
>>
>> I do not like how you changed return type of function to void.
>>
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
>

Sent with ProtonMail Secure Email.

0001-avfilter-zscale-fix-segfault-on-library-error.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> You still have not provided valid reason to block it.
>
> Your first patch was wrong. I have observed a possible flaw in the
> second one. I thought I had a test case to show it, maybe I was wrong. I
> need to check and test.
>
> Now, I might add, if you were not so antagonistic all the time, I might
> have wasted less time in these useless exchanges and had more time to
> actually examine the patch. Right now I do not have time. So you will
> just have to wait.
>
> But do not dare push the patch as is.

I already posted another version which I will push shortly.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavfilter/tests/filtfmts : remove warning

[Martin Vignali]

Hello,

In attach patch to fix a warning (clang os X)

libavfilter/tests/filtfmts.c:145:9: warning: ignoring return value of
function declared with 'warn_unused_result'
  attribute [-Wunused-result]
ff_default_query_formats(filter_ctx);


can be test with
make fate-filter-pixfmts-copy

Martin


0004-libavfilter-tests-filtfmts-remove-warning-warn_unuse.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit :
> Don't know if there is a better way to fix it
> but if the variable stay unsigned
> this for loop create the problem
> for (y = ymin; y < ymax - 15; y += 16) {

Looks like a job for FFMAX or FFMIN to me.

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Martin Vignali]

2017-10-28 18:49 GMT+02:00 Nicolas George :

> Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit :
> > Hello,
> >
> > Following another discussion,
> > the testsrc2 filter can hang with small size
> >
> > Possible fix in attach
> >
> > Martin
>
> > From 3eaa767833647ab8ce270e091925557543ae5d35 Mon Sep 17 00:00:00 2001
> > From: Martin Vignali 
> > Date: Sat, 28 Oct 2017 18:33:26 +0200
> > Subject: [PATCH 2/3] libavfilter/vsrc_testsrc : fix hang with testsrc2
> and
> >  small size
> >
> > ---
> >  libavfilter/vsrc_testsrc.c | 7 ---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c
> > index fe0d50aa41..81e8ce2e69 100644
> > --- a/libavfilter/vsrc_testsrc.c
> > +++ b/libavfilter/vsrc_testsrc.c
> > @@ -851,9 +851,10 @@ static void test2_fill_picture(AVFilterContext
> *ctx, AVFrame *frame)
> >  {
> >  unsigned xmin = av_rescale(5, s->w, 8);
> >  unsigned xmax = av_rescale(7, s->w, 8);
>
> > -unsigned ymin = av_rescale(5, s->h, 8);
> > -unsigned ymax = av_rescale(7, s->h, 8);
> > -unsigned x, y, i, r;
> > +int ymin = av_rescale(5, s->h, 8);
> > +int ymax = av_rescale(7, s->h, 8);
> > +unsigned x, i, r;
> > +int y;
>
> I cannot peruse the source code for now, but I do not think that making
> signed variables that are semantically unsigned can be a correct fix. At
> the very least the commit message would need to explain why it changes a
> thing.
>
>
Don't know if there is a better way to fix it
but if the variable stay unsigned
this for loop create the problem
for (y = ymin; y < ymax - 15; y += 16) {

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit :
> Hello,
> 
> Following another discussion,
> the testsrc2 filter can hang with small size
> 
> Possible fix in attach
> 
> Martin

> From 3eaa767833647ab8ce270e091925557543ae5d35 Mon Sep 17 00:00:00 2001
> From: Martin Vignali 
> Date: Sat, 28 Oct 2017 18:33:26 +0200
> Subject: [PATCH 2/3] libavfilter/vsrc_testsrc : fix hang with testsrc2 and
>  small size
> 
> ---
>  libavfilter/vsrc_testsrc.c | 7 ---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c
> index fe0d50aa41..81e8ce2e69 100644
> --- a/libavfilter/vsrc_testsrc.c
> +++ b/libavfilter/vsrc_testsrc.c
> @@ -851,9 +851,10 @@ static void test2_fill_picture(AVFilterContext *ctx, 
> AVFrame *frame)
>  {
>  unsigned xmin = av_rescale(5, s->w, 8);
>  unsigned xmax = av_rescale(7, s->w, 8);

> -unsigned ymin = av_rescale(5, s->h, 8);
> -unsigned ymax = av_rescale(7, s->h, 8);
> -unsigned x, y, i, r;
> +int ymin = av_rescale(5, s->h, 8);
> +int ymax = av_rescale(7, s->h, 8);
> +unsigned x, i, r;
> +int y;

I cannot peruse the source code for now, but I do not think that making
signed variables that are semantically unsigned can be a correct fix. At
the very least the commit message would need to explain why it changes a
thing.

>  uint8_t alpha[256];
>  
>  r = s->pts;

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] fate/vsrc_testsrc : add fate test for testsrc2 and small size

[Martin Vignali]

Hello,

Fate test for testsrc2 with small size

Need to be apply after patch in discussion :
libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size


Martin


0003-fate-vsrc_testsrc-add-test-for-testsrc2-s-2x2.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

[Martin Vignali]

Hello,

Following another discussion,
the testsrc2 filter can hang with small size

Possible fix in attach

Martin


0002-libavfilter-vsrc_testsrc-fix-hang-with-testsrc2-and-.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> You still have not provided valid reason to block it.

Your first patch was wrong. I have observed a possible flaw in the
second one. I thought I had a test case to show it, maybe I was wrong. I
need to check and test.

Now, I might add, if you were not so antagonistic all the time, I might
have wasted less time in these useless exchanges and had more time to
actually examine the patch. Right now I do not have time. So you will
just have to wait.

But do not dare push the patch as is.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

Signed-off-by: Paul B Mahol 
---
 libavfilter/vf_tile.c | 12 +++-
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c
index 87e0b940cf..5752ca080e 100644
--- a/libavfilter/vf_tile.c
+++ b/libavfilter/vf_tile.c
@@ -23,6 +23,7 @@
  * tile video filter
  */
 
+#include "libavutil/imgutils.h"
 #include "libavutil/opt.h"
 #include "libavutil/pixdesc.h"
 #include "avfilter.h"
@@ -44,8 +45,6 @@ typedef struct TileContext {
 uint8_t rgba_color[4];
 } TileContext;
 
-#define REASONABLE_SIZE 1024
-
 #define OFFSET(x) offsetof(TileContext, x)
 #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
 
@@ -68,12 +67,6 @@ static av_cold int init(AVFilterContext *ctx)
 {
 TileContext *tile = ctx->priv;
 
-if (tile->w > REASONABLE_SIZE || tile->h > REASONABLE_SIZE) {
-av_log(ctx, AV_LOG_ERROR, "Tile size %ux%u is insane.\n",
-   tile->w, tile->h);
-return AVERROR(EINVAL);
-}
-
 if (tile->nb_frames == 0) {
 tile->nb_frames = tile->w * tile->h;
 } else if (tile->nb_frames > tile->w * tile->h) {
@@ -116,7 +109,7 @@ static int config_props(AVFilterLink *outlink)
 ff_draw_init(>draw, inlink->format, 0);
 ff_draw_color(>draw, >blank, tile->rgba_color);
 
-return 0;
+return av_image_check_size2(outlink->w, outlink->h, INT64_MAX, 
inlink->format, 0, ctx);
 }
 
 static void get_current_tile_pos(AVFilterContext *ctx, unsigned *x, unsigned 
*y)
@@ -142,6 +135,7 @@ static void draw_blank_frame(AVFilterContext *ctx, AVFrame 
*out_buf)
   x0, y0, inlink->w, inlink->h);
 tile->current++;
 }
+
 static int end_last_frame(AVFilterContext *ctx)
 {
 TileContext *tile = ctx->priv;
-- 
2.11.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> No.
>
> Yes. Sixteen hours is unacceptable.

When you will retire?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Gonna apply this patch soonTM because of no valid reasons to block it.
>
> No, you will not.

You still have not provided valid reason to block it.

testsrc2 filter hang is unrelated to my change.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Gonna apply this patch soonTM because of no valid reasons to block it.

No, you will not.

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

[Martin Vignali]

> >>
> > For this, i follow Henrik Gramner's code, in the discussion
> > libavcodec/exr : add x86 SIMD for predictor.
>
> That's fine.  I will look at that on my own time.  I don't want to hold
> up applying the patch.  Would you like me to push it for you?
>
>
> Yes please push it if you can.
Thanks !

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/utvideodec : remove step arg for decode plane

[Paul B Mahol]

On 10/28/17, Martin Vignali  wrote:
> Hello,
>
> In attach a patch to remove the step arg for the decode plane func
>
> decode_plane and decode_plane10 are only call with step = 1
>
>
> Martin
>

lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

[James Darnley]

On 2017-10-28 16:14, Martin Vignali wrote:
> 2017-10-28 15:47 GMT+02:00 James Darnley :
> 
>> On 2017-10-22 19:14, Martin Vignali wrote:
>>> @@ -86,16 +101,20 @@ SECTION .text
>>>
>>>  ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w);
>>>  %macro BSWAP32_BUF 0
>>> -%if cpuflag(ssse3)
>>> +%if cpuflag(ssse3)||cpuflag(avx2)
>>>  cglobal bswap32_buf, 3,4,3
>>>  mov  r3, r1
>>> +%if cpuflag(avx2)
>>> +vbroadcasti128  m2, [pb_bswap32]
>>> +%else
>>>  mova m2, [pb_bswap32]
>>> +%endif
>>
>> Why don't you increase the size of the constant?  You wouldn't need a
>> preprocessor condition.
>>
>> I do admit I have never considered using a broadact-128 instruction in
>> similar circumstances so I have no idea which might be "better".
>>
>>
> For this, i follow Henrik Gramner's code, in the discussion
> libavcodec/exr : add x86 SIMD for predictor.

That's fine.  I will look at that on my own time.  I don't want to hold
up applying the patch.  Would you like me to push it for you?




signature.asc
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavcodec/utvideodec : remove step arg for decode plane

[Martin Vignali]

Hello,

In attach a patch to remove the step arg for the decode plane func

decode_plane and decode_plane10 are only call with step = 1


Martin


0002-libavcodec-utvideo-simplify-decode_plane.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi/paletteuse: fix to support transparency

[Clément Bœsch]

On Mon, Oct 23, 2017 at 07:12:57PM -0400, Bjorn Roche wrote:
> This patch enables paletteuse to identify the transparency in incoming
> video and tag transparent pixels on outgoing video with the correct
> index from the palette.
> 
> This requires tracking the transparency index in the palette,
> establishing an alpha threshold below which a pixel is considered
> transparent and above which the pixel is considered opaque, and
> additional changes to track the alpha value throughout the conversion
> process.
> 
> This change is a partial fix for https://trac.ffmpeg.org/ticket/4443
> However, animated GIFs are still output incorrectly due to a bug
> in gif optimization which does not correctly handle transparency.
> ---
>  doc/filters.texi|   7 ++
>  libavfilter/vf_paletteuse.c | 195 
> 

patch applied. I took the liberty to make the following changes before
pushing:

- fix spacing issues around () you forgot to fix
- rename "threshold" into "alpha_threshold"
- move the option documentation in the appropriate place (it was between
  diff_mode and one of its constant)

Thanks for the patch, and sorry about the delay.

Regards,

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Paul B Mahol  wrote:
> On 10/28/17, Clement Boesch  wrote:
>> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
>>> On 10/28/17, Clement Boesch  wrote:
>>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>>> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>>> >> > Signed-off-by: Paul B Mahol 
>>> >> > ---
>>> >> >  libavfilter/vf_tile.c | 8 
>>> >> >  1 file changed, 8 deletions(-)
>>> >>
>>> >> Nack.
>>> >>
>>> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>>> >> framecrc -
>>> >>
>>> >> hangs instead of returning a proper error.
>>> >>
>>> >
>>> > In case there is confusion with what Paul said: `ffmpeg -lavfi
>>> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the
>>> > hang
>>> > you're reporting is likely unrelated to this patch. Instead, it looks
>>> > like
>>> > a
>>> > problem related to the 2x2 size being too small for testsrc2 (testsrc
>>> > supports 2x2, testsrc2 doesn't).
>>> >
>>> > (Not saying the current patch is correct though)
>>>
>>> I don't remmember I hired lawyer. Did I?
>>
>> I'm not defending you, I'm explaining a potential misunderstanding
>> between
>> Nicolas and you, giving information you should probably have provided
>> yourself to ease the communication to prevent pointless escalation.
>
> I already provided it. The problem is people forgot to read.
>

Gonna apply this patch soonTM because of no valid reasons to block it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

[Martin Vignali]

2017-10-28 15:47 GMT+02:00 James Darnley :

> On 2017-10-22 19:14, Martin Vignali wrote:
> > @@ -86,16 +101,20 @@ SECTION .text
> >
> >  ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w);
> >  %macro BSWAP32_BUF 0
> > -%if cpuflag(ssse3)
> > +%if cpuflag(ssse3)||cpuflag(avx2)
> >  cglobal bswap32_buf, 3,4,3
> >  mov  r3, r1
> > +%if cpuflag(avx2)
> > +vbroadcasti128  m2, [pb_bswap32]
> > +%else
> >  mova m2, [pb_bswap32]
> > +%endif
>
> Why don't you increase the size of the constant?  You wouldn't need a
> preprocessor condition.
>
> I do admit I have never considered using a broadact-128 instruction in
> similar circumstances so I have no idea which might be "better".
>
>
> For this, i follow Henrik Gramner's code, in the discussion
libavcodec/exr : add x86 SIMD for predictor.

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

[James Darnley]

On 2017-10-22 19:14, Martin Vignali wrote:
> @@ -86,16 +101,20 @@ SECTION .text
>  
>  ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w);
>  %macro BSWAP32_BUF 0
> -%if cpuflag(ssse3)
> +%if cpuflag(ssse3)||cpuflag(avx2)
>  cglobal bswap32_buf, 3,4,3
>  mov  r3, r1
> +%if cpuflag(avx2)
> +vbroadcasti128  m2, [pb_bswap32]
> +%else
>  mova m2, [pb_bswap32]
> +%endif

Why don't you increase the size of the constant?  You wouldn't need a
preprocessor condition.

I do admit I have never considered using a broadact-128 instruction in
similar circumstances so I have no idea which might be "better".




signature.asc
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Clement Boesch  wrote:
> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
>> On 10/28/17, Clement Boesch  wrote:
>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> >> > Signed-off-by: Paul B Mahol 
>> >> > ---
>> >> >  libavfilter/vf_tile.c | 8 
>> >> >  1 file changed, 8 deletions(-)
>> >>
>> >> Nack.
>> >>
>> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>> >> framecrc -
>> >>
>> >> hangs instead of returning a proper error.
>> >>
>> >
>> > In case there is confusion with what Paul said: `ffmpeg -lavfi
>> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the
>> > hang
>> > you're reporting is likely unrelated to this patch. Instead, it looks
>> > like
>> > a
>> > problem related to the 2x2 size being too small for testsrc2 (testsrc
>> > supports 2x2, testsrc2 doesn't).
>> >
>> > (Not saying the current patch is correct though)
>>
>> I don't remmember I hired lawyer. Did I?
>
> I'm not defending you, I'm explaining a potential misunderstanding between
> Nicolas and you, giving information you should probably have provided
> yourself to ease the communication to prevent pointless escalation.

I already provided it. The problem is people forgot to read.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Clément Bœsch]

On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
> On 10/28/17, Clement Boesch  wrote:
> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
> >> > Signed-off-by: Paul B Mahol 
> >> > ---
> >> >  libavfilter/vf_tile.c | 8 
> >> >  1 file changed, 8 deletions(-)
> >>
> >> Nack.
> >>
> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
> >> framecrc -
> >>
> >> hangs instead of returning a proper error.
> >>
> >
> > In case there is confusion with what Paul said: `ffmpeg -lavfi
> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
> > you're reporting is likely unrelated to this patch. Instead, it looks like
> > a
> > problem related to the 2x2 size being too small for testsrc2 (testsrc
> > supports 2x2, testsrc2 doesn't).
> >
> > (Not saying the current patch is correct though)
> 
> I don't remmember I hired lawyer. Did I?

I'm not defending you, I'm explaining a potential misunderstanding between
Nicolas and you, giving information you should probably have provided
yourself to ease the communication to prevent pointless escalation.

Regards,

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Clement Boesch  wrote:
> On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> > Signed-off-by: Paul B Mahol 
>> > ---
>> >  libavfilter/vf_tile.c | 8 
>> >  1 file changed, 8 deletions(-)
>>
>> Nack.
>>
>> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>> framecrc -
>>
>> hangs instead of returning a proper error.
>>
>
> In case there is confusion with what Paul said: `ffmpeg -lavfi
> testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
> you're reporting is likely unrelated to this patch. Instead, it looks like
> a
> problem related to the 2x2 size being too small for testsrc2 (testsrc
> supports 2x2, testsrc2 doesn't).
>
> (Not saying the current patch is correct though)

I don't remmember I hired lawyer. Did I?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Clément Bœsch]

On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit :
> > Signed-off-by: Paul B Mahol 
> > ---
> >  libavfilter/vf_tile.c | 8 
> >  1 file changed, 8 deletions(-)
> 
> Nack.
> 
> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f framecrc 
> -
> 
> hangs instead of returning a proper error.
> 

In case there is confusion with what Paul said: `ffmpeg -lavfi
testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
you're reporting is likely unrelated to this patch. Instead, it looks like a
problem related to the 2x2 size being too small for testsrc2 (testsrc
supports 2x2, testsrc2 doesn't).

(Not saying the current patch is correct though)

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/blockdsp : fix comment

[Martin Vignali]

2017-10-21 22:20 GMT+02:00 Ronald S. Bultje :

> Hi,
>
> On Sat, Oct 21, 2017 at 1:30 PM, Martin Vignali 
> wrote:
>
> > Hello,
> >
> > in attach patch to fix comment in blockdsp
> >
> > the dsp need align 32 now.
> >
>
> lgtm.
>
>
>
> ping for apply
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

[Martin Vignali]

2017-10-25 9:39 GMT+02:00 Paul B Mahol :

> On 10/22/17, Martin Vignali  wrote:
> > Hello,
> >
> > In attach patch in order to add an AVX2 version for bswap_buf
> > (swap uint32 in a buffer)
> >
> > Checkasm result (Kaby Lake 10.12)
> > bswap_buf_c: 122.8
> > bswap_buf_sse2: 67.8
> > bswap_buf_ssse3: 34.3
> > bswap_buf_avx2: 21.0
> >
> >
> > Pass checkasm and fate test for me
> >
> >
> > Martin
> > Jokyo Images
> >
>
> probably ok
>
>
ping for apply
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

[Martin Vignali]

2017-10-25 22:54 GMT+02:00 Paul B Mahol :

> On 10/25/17, Martin Vignali  wrote:
> > 2017-10-25 22:08 GMT+02:00 Paul B Mahol :
> >
> >> On 10/25/17, Martin Vignali  wrote:
> >> > 2017-10-25 21:53 GMT+02:00 Paul B Mahol :
> >> >
> >> >> On 10/25/17, Martin Vignali  wrote:
> >> >> > 2017-10-25 9:43 GMT+02:00 Paul B Mahol :
> >> >> >
> >> >> >> On 10/21/17, Martin Vignali  wrote:
> >> >> >> > Hello,
> >> >> >> >
> >> >> >> > In attach patch to add AVX2 version for add_bytes
> >> >> >> >
> >> >> >> > 0001-libavcodec-lossless_videodsp-add-add_bytes-avx2-vers :
> >> >> >> > add AVX2 version
> >> >> >> >
> >> >> >> > pass fate-test for me (os 10.12, x86_64)
> >> >> >> >
> >> >> >> > checkasm result : (Kaby Lake) (run 10 times, and i took the
> >> >> >> > fastest
> >> >> >> > version)
> >> >> >> > checkasm: all 2 tests passed
> >> >> >> > add_bytes_c: 108.7
> >> >> >> > add_bytes_sse2: 26.5
> >> >> >> > add_bytes_avx2: 15.5
> >> >> >> >
> >> >> >> >
> >> >> >> > 0002-libavcodec-lossless_video_dsp-cosmetic-add-better-se:
> >> >> >> > only cosmetic
> >> >> >> > like the ref c function declaration in asm file is not
> consistent
> >> >> >> > between
> >> >> >> > each asm file
> >> >> >> > i think a better separator for each function make the file
> easier
> >> to
> >> >> >> > read
> >> >> >> >
> >> >> >> > also add the c declaration for add bytes in comment
> >> >> >> >
> >> >> >> >
> >> >> >> > Martin
> >> >> >> >
> >> >> >>
> >> >> >> Are you sure 32bit alignment is actually enforced?
> >> >> >>
> >> >> >>
> >> >> > Hello,
> >> >> >
> >> >> > I think, data used by add_bytes is always aligned
> >> >> > because dst and src, are start of a line of an AvFrame
> >> >>
> >> >> Yes, but try width thats not multiple of 32.
> >> >> ___
> >> >>
> >> >>
> >> > Sorry, not sure i understand.
> >> > following the doc, AVFrame->linesize, is multiple of max alignment
> >> >
> >> > and in the asm, loop will be repeat until, val < width
> >> >
> >> > Can you indicate me, the part, where you think, it's not ok ?
> >>
> >> I dunno. You should test it with widths not divisible by 32.
> >>
> >
> > Tested with the fate sample : vsynth3-huffyuvbgra.avi (34x34)
> > ./ffmpeg -i ./tests/data/fate/vsynth3-huffyuvbgra.avi -f framecrc -
> >
> > generate same crc than
> > ./ffmpeg -i ./tests/data/fate/vsynth3-huffyuvbgra.avi -f framecrc -
> > -cpuflags 0
> >
> >
> >>
> >> also try encoding cropped video.
> >>
> >
> > Are you sure, encoding cropped video, have a link to the decoding dsp
> func ?
> >
> > these patch only take care about the decoding func
> >
> >
> > And the encoding func of huffyuvenc (in huffyuv add add/diff_bytes16 AVX2
> > discussion)
> > and losslessencdsp (not made for now), have a test for alignment of dst
> and
> > src
> >
> >
> > Martin
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
>
>
> ok then
> 
>

Ping for apply
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] fate/utvideo add test for decoding and encoding V2

[Martin Vignali]

Hello,

New patch in attach, with more samples, in order to test most of the not
covered case

Sample can be found here
https://we.tl/EV2lBmOXk0

And need to be put inside ./fate-suite/utvideo

Decoding test add :
- interlace median/gradient (YUV420, YUV422, YUV444, RGB)
- gradient (YUV420, YUV422, YUV444, RGB)
- median, Left (YUV 444) : (other pred already have test)

Samples have been generate using the UTVideoSuite on windows


Encoding test add :
- YUV 444 (median, left, none)

can be test with

make fate-utvideoenc
make fate-utvideo SAMPLES=fate-suite/

Tested on os X (X86_64)

Martin


0001-fate-utvideo-add-test-for-decoding-and-encoding.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Why?
>
> Because it is wrong. I wrote the test case by looking at your changes
> and finding a flaw in them.

No, your test is flawed. I have no longer obligations to communicate with you.

Simply said, testsrc2 hangs on its own, and its not tile flaw, or my patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

[Ronald S. Bultje]

Hi,

On Fri, Oct 27, 2017 at 10:14 PM, Michael Niedermayer <
mich...@niedermayer.cc> wrote:

> On Fri, Oct 27, 2017 at 10:03:54PM +0200, Paul B Mahol wrote:
> > Signed-off-by: Paul B Mahol 
> > ---
> >  libavcodec/mpegvideo.c |  10 +
> >  libavfilter/vf_codecview.c | 105 ++
> +++
> >  libavutil/frame.h  |   4 ++
> >  3 files changed, 119 insertions(+)
>
> First, thanks for working on this.
>
>
> [...]
>
> > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > index fef558ea2f..8481dc080b 100644
> > --- a/libavutil/frame.h
> > +++ b/libavutil/frame.h
> > @@ -141,6 +141,10 @@ enum AVFrameSideDataType {
> >   * metadata key entry "name".
> >   */
> >  AV_FRAME_DATA_ICC_PROFILE,
> > +/**
> > + * Macroblock types exported by some codecs.
> > + */
> > +AV_FRAME_DATA_MACROBLOCK_TYPES,
> >  };
> >
>
> This makes the internal data of the decoder part of the ABI and API of
> libavcodec and libavfilter
> and its undocumented
>
> do people prefer to make the internal data part of the ABI, document
> it and ensure it does not change till the next bump
>
[..]

> or is there some other option iam missing ?
>

I noted this on IRC also. A third option is to not document it and consider
it codec-specific.

(Codec-specific implies "ABI/API unstable" and subject to change - "don't
mix versions".)

> or design a new interface, document it and convert to it?

I think we'd all prefer this, but this requires someone to do the work.
Exciting!

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Why?

Because it is wrong. I wrote the test case by looking at your changes
and finding a flaw in them.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> No.

Yes. Sixteen hours is unacceptable.

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Signed-off-by: Paul B Mahol 
>> ---
>>  libavfilter/avfilter.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Give me more time to review this change.

No.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] order T-shirts

[Thilo Borgmann]

Hi,

> Am 24.10.17 um 02:43 schrieb Lou Logan:
>> On Sat, Oct 21, 2017, at 07:53 AM, Lou Logan wrote:
>>> I'll attach the SVG file when I get back home on Monday or Tuesday.
>>
>> SVG attached. Let me know if you need changes or if the printer needs a
>> different format.
> 
> then we are talking about a completely different design.
> 
> 
>> These shirts will be silk screened, right? If so, the green is intended
>> to be "PMS 354C Spring Green Pantone Solid Coated" which is a little
>> brighter than the original green color so it stands out more from the
>> black shirt.
> 
> No. They offer different techniques, though.
> 
> 
>> The black part is of course just there so the lettering is visible. If
>> they prefer a false white for the letters I can do that.
>>
>> I envisioned the design to be horizontally centered on the front of the
>> shirt, chest high, design width of 15-18 cm, back of shirt plain. Mockup
>> attached.
> 
> I'll do go there and get an offer for that design and ask about possible 
> print techniques.
> 
> Depending on that, we should decide what to order. 
> I'd appreciate to hear more opinions about the design question in the mean 
> time.

I got a sample of both, the updated Thomas' design (front/back in white) and 
Lou's design (green/white on front). The photos are updated:
https://photos.app.goo.gl/54h3WaruCTEKsJOc2

Both designs come for 12€ each! Lou's design doesn't have a printing on the 
neck. I'd choosen the green for our logo by their color chart - it looks good 
color-wise to me.

My suggestion would be, that we could order Thomas' design for all the 
developers and requests I've recieved by now and that we take Lou's for our 
stock for give-aways during conferences. Just my thinking...

Except for Nicolas, nobody shared his opinion about the design. I'd like to 
order next week, so comments on this are welcome!

-Thilo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> testsrc2 hangs here.
>
> So please rework your patch.

Why? When it hangs without using tile filter at all.

Do I need to write things out of blue moon now?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

[Nicolas George]

Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/avfilter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Give me more time to review this change.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Nicolas George]

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> testsrc2 hangs here.

So please rework your patch.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library error

[Paul B Mahol]

On 10/28/17, Dxfhgwet  wrote:
> Sent with [ProtonMail](https://protonmail.com) Secure Email.

I do not like how you changed return type of function to void.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

[Paul B Mahol]

On 10/27/17, Paul B Mahol  wrote:
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/avfilter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index bc9e60bb85..b98b32bacb 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -1532,7 +1532,7 @@ int ff_inlink_consume_samples(AVFilterLink *link,
> unsigned min, unsigned max,
>  return 0;
>  if (link->status_in)
>  min = FFMIN(min, ff_framequeue_queued_samples(>fifo));
> -ret = take_samples(link, min, link->max_samples, );
> +ret = take_samples(link, min, max, );
>  if (ret < 0)
>  return ret;
>  consume_update(link, frame);
> --
> 2.11.0
>
>

Will push patchset soon as it fixes serious bug.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/frame: deprecate getters and setters for AVFrame fields

[Paul B Mahol]

On 10/28/17, James Almer  wrote:
> On 10/23/2017 11:13 AM, James Almer wrote:
>> The fields can be accessed directly, so these are not needed anymore.
>>
>> Signed-off-by: James Almer 
>> ---
>>  libavutil/frame.c   |  2 ++
>>  libavutil/frame.h   | 26 ++
>>  libavutil/version.h |  3 +++
>>  3 files changed, 31 insertions(+)
>>
>> diff --git a/libavutil/frame.c b/libavutil/frame.c
>> index 09dd98a6b5..982fbb5c81 100644
>> --- a/libavutil/frame.c
>> +++ b/libavutil/frame.c
>> @@ -31,6 +31,7 @@ static AVFrameSideData *frame_new_side_data(AVFrame
>> *frame,
>>  enum AVFrameSideDataType
>> type,
>>  AVBufferRef *buf);
>>
>> +#if FF_API_FRAME_GET_SET
>>  MAKE_ACCESSORS(AVFrame, frame, int64_t, best_effort_timestamp)
>>  MAKE_ACCESSORS(AVFrame, frame, int64_t, pkt_duration)
>>  MAKE_ACCESSORS(AVFrame, frame, int64_t, pkt_pos)
>> @@ -42,6 +43,7 @@ MAKE_ACCESSORS(AVFrame, frame, int,
>> decode_error_flags)
>>  MAKE_ACCESSORS(AVFrame, frame, int, pkt_size)
>>  MAKE_ACCESSORS(AVFrame, frame, enum AVColorSpace, colorspace)
>>  MAKE_ACCESSORS(AVFrame, frame, enum AVColorRange, color_range)
>> +#endif
>>
>>  #define CHECK_CHANNELS_CONSISTENCY(frame) \
>>  av_assert2(!(frame)->channel_layout || \
>> diff --git a/libavutil/frame.h b/libavutil/frame.h
>> index fef558ea2f..0c6aab1c02 100644
>> --- a/libavutil/frame.h
>> +++ b/libavutil/frame.h
>> @@ -565,36 +565,62 @@ typedef struct AVFrame {
>>   */
>>  } AVFrame;
>>
>> +#if FF_API_FRAME_GET_SET
>>  /**
>>   * Accessors for some AVFrame fields. These used to be provided for ABI
>>   * compatibility, and do not need to be used anymore.
>>   */
>> +attribute_deprecated
>>  int64_t av_frame_get_best_effort_timestamp(const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_best_effort_timestamp(AVFrame *frame, int64_t val);
>> +attribute_deprecated
>>  int64_t av_frame_get_pkt_duration (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_pkt_duration (AVFrame *frame, int64_t val);
>> +attribute_deprecated
>>  int64_t av_frame_get_pkt_pos  (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_pkt_pos  (AVFrame *frame, int64_t val);
>> +attribute_deprecated
>>  int64_t av_frame_get_channel_layout   (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_channel_layout   (AVFrame *frame, int64_t val);
>> +attribute_deprecated
>>  int av_frame_get_channels (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_channels (AVFrame *frame, int val);
>> +attribute_deprecated
>>  int av_frame_get_sample_rate  (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_sample_rate  (AVFrame *frame, int val);
>> +attribute_deprecated
>>  AVDictionary *av_frame_get_metadata   (const AVFrame *frame);
>> +attribute_deprecated
>>  void  av_frame_set_metadata   (AVFrame *frame, AVDictionary
>> *val);
>> +attribute_deprecated
>>  int av_frame_get_decode_error_flags   (const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_decode_error_flags   (AVFrame *frame, int val);
>> +attribute_deprecated
>>  int av_frame_get_pkt_size(const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_pkt_size(AVFrame *frame, int val);
>>  #if FF_API_FRAME_QP
>> +attribute_deprecated
>>  int8_t *av_frame_get_qp_table(AVFrame *f, int *stride, int *type);
>> +attribute_deprecated
>>  int av_frame_set_qp_table(AVFrame *f, AVBufferRef *buf, int stride, int
>> type);
>>  #endif
>> +attribute_deprecated
>>  enum AVColorSpace av_frame_get_colorspace(const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_colorspace(AVFrame *frame, enum AVColorSpace val);
>> +attribute_deprecated
>>  enum AVColorRange av_frame_get_color_range(const AVFrame *frame);
>> +attribute_deprecated
>>  voidav_frame_set_color_range(AVFrame *frame, enum AVColorRange val);
>> +#endif
>>
>>  /**
>>   * Get the name of a colorspace.
>> diff --git a/libavutil/version.h b/libavutil/version.h
>> index aa56ad2fbd..7b4ae9beab 100644
>> --- a/libavutil/version.h
>> +++ b/libavutil/version.h
>> @@ -136,6 +136,9 @@
>>  #ifndef FF_API_CRYPTO_SIZE_T
>>  #define FF_API_CRYPTO_SIZE_T(LIBAVUTIL_VERSION_MAJOR < 57)
>>  #endif
>> +#ifndef FF_API_FRAME_GET_SET
>> +#define FF_API_FRAME_GET_SET(LIBAVUTIL_VERSION_MAJOR < 57)
>> +#endif
>>
>>
>>  /**
>
> Ping.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

[Paul B Mahol]

On 10/27/17, Nicolas George  wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Signed-off-by: Paul B Mahol 
>> ---
>>  libavfilter/vf_tile.c | 8 
>>  1 file changed, 8 deletions(-)
>
> Nack.
>
> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
> framecrc -
>
> hangs instead of returning a proper error.

testsrc2 hangs here.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avformat: move public AVStream fields up in the struct

[Paul B Mahol]

On 10/23/17, James Almer  wrote:
> Remove the silly second notice.
>
> Signed-off-by: James Almer 
> ---
>  libavformat/avformat.h | 65
> ++
>  1 file changed, 28 insertions(+), 37 deletions(-)
>
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index ece1b179f3..7594277f06 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -980,6 +980,34 @@ typedef struct AVStream {
>  int event_flags;
>  #define AVSTREAM_EVENT_FLAG_METADATA_UPDATED 0x0001 ///< The call resulted
> in updated metadata.
>
> +/**
> + * Real base framerate of the stream.
> + * This is the lowest framerate with which all timestamps can be
> + * represented accurately (it is the least common multiple of all
> + * framerates in the stream). Note, this value is just a guess!
> + * For example, if the time base is 1/9 and all frames have either
> + * approximately 3600 or 1800 timer ticks, then r_frame_rate will be
> 50/1.
> + */
> +AVRational r_frame_rate;
> +
> +/**
> + * String containing paris of key and values describing recommended
> encoder configuration.
> + * Paris are separated by ','.

Pairs

> + * Keys are separated from values by '='.
> + */
> +char *recommended_encoder_configuration;
> +
> +/**
> + * Codec parameters associated with this stream. Allocated and freed by
> + * libavformat in avformat_new_stream() and avformat_free_context()
> + * respectively.
> + *
> + * - demuxing: filled by libavformat on stream creation or in
> + * avformat_find_stream_info()
> + * - muxing: filled by the caller before avformat_write_header()
> + */
> +AVCodecParameters *codecpar;
> +
>  /*
>   * All fields below this line are not part of the public API. They
>   * may not be used outside of libavformat and can be changed and
> @@ -1064,19 +1092,6 @@ typedef struct AVStream {
>  int nb_index_entries;
>  unsigned int index_entries_allocated_size;
>
> -/**
> - * Real base framerate of the stream.
> - * This is the lowest framerate with which all timestamps can be
> - * represented accurately (it is the least common multiple of all
> - * framerates in the stream). Note, this value is just a guess!
> - * For example, if the time base is 1/9 and all frames have either
> - * approximately 3600 or 1800 timer ticks, then r_frame_rate will be
> 50/1.
> - *
> - * Code outside avformat should access this field using:
> - * av_stream_get/set_r_frame_rate(stream)
> - */
> -AVRational r_frame_rate;
> -
>  /**
>   * Stream Identifier
>   * This is the MPEG-TS stream identifier +1
> @@ -1182,19 +1197,6 @@ typedef struct AVStream {
>   */
>  int inject_global_side_data;
>
> -/*
> - * All fields above this line are not part of the public API.
> - * Fields below are part of the public API and ABI again.
> - *
> - */
> -
> -/**
> - * String containing paris of key and values describing recommended
> encoder configuration.
> - * Paris are separated by ','.
> - * Keys are separated from values by '='.
> - */
> -char *recommended_encoder_configuration;
> -
>  /**
>   * display aspect ratio (0 if unknown)
>   * - encoding: unused
> @@ -1209,17 +1211,6 @@ typedef struct AVStream {
>   * Must not be accessed in any way by callers.
>   */
>  AVStreamInternal *internal;
> -
> -/*
> - * Codec parameters associated with this stream. Allocated and freed by
> - * libavformat in avformat_new_stream() and avformat_free_context()
> - * respectively.
> - *
> - * - demuxing: filled by libavformat on stream creation or in
> - * avformat_find_stream_info()
> - * - muxing: filled by the caller before avformat_write_header()
> - */
> -AVCodecParameters *codecpar;
>  } AVStream;
>
>  AVRational av_stream_get_r_frame_rate(const AVStream *s);
> --
> 2.14.2
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel