Re: [FFmpeg-devel] Patchwork attribution
On Fri, Apr 19, 2019, at 2:15 PM, Hendrik Leppkes wrote: > > The first mail like that arrived, and handling of it of course > depends on the mail client in question. But at least Patchwork doesn't > seem to like it much, it quite simply still attributes it to the > "shared" mail. > Not sure if there is some way to get Patchwork to improve in that regard. I changed ffmpeg-devel back to the original "accept" setting. Trades one issue for another. I left the other mailing lists as "munge". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Fri, Apr 19, 2019 at 8:23 PM Lou Logan wrote: > > On Thu, 18 Apr 2019 18:01:27 -0400 > "Lou Logan" wrote: > > > > But we can certainly give it a try if you like. I'm not sure how patchwork > > will handle it. > > (Didn't realize my webmail client wasn't actually wrapping my text > although it was doing it in the window at the expected lengths.) > > I just changed it from "munge" to "wrap" (only on ffmpeg-devel for > now). If it doesn't work out then I'll just go back to the original > setting of "accept" until if/when we find a better solution. We will > lose some subscribers but the current patch author mangling is not > worth the trouble in my opinion. The first mail like that arrived, and handling of it of course depends on the mail client in question. But at least Patchwork doesn't seem to like it much, it quite simply still attributes it to the "shared" mail. Not sure if there is some way to get Patchwork to improve in that regard. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, 18 Apr 2019 18:01:27 -0400 "Lou Logan" wrote: > > But we can certainly give it a try if you like. I'm not sure how patchwork > will handle it. (Didn't realize my webmail client wasn't actually wrapping my text although it was doing it in the window at the expected lengths.) I just changed it from "munge" to "wrap" (only on ffmpeg-devel for now). If it doesn't work out then I'll just go back to the original setting of "accept" until if/when we find a better solution. We will lose some subscribers but the current patch author mangling is not worth the trouble in my opinion. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Fri, 19 Apr 2019 00:05:00 + Andreas Rheinhardt wrote: > But now I am unsure whether I should resend my patchsets? At this point I suggest resending as it will allow the commiter to avoid having to adjust the author and will help avoid mistakes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
Hello, Gyan: > > Patchwork can incorrectly assign ownership. See > https://patchwork.ffmpeg.org/patch/12680/ > > The author is Sam John as identified by Message ID as well as the From > field in the headers, yet Patchwork attributes this patch to "Oliver > Collyer via ffmpeg-devel", a name which appears nowhere in the headers > or in the submitted patch. The downloaded mbox patch shows the same > wrong attribution. Does anyone know what's going on? > > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". I just saw that I was affected by this: One of my commits (18a851aca766ff8c7199c9e0c37d8fa642e41920) has a "via ffmpeg-devel" author and the majority of patches attributed to Oliver Collyer via ffmpeg-devel on patchwork are actually from me. I have now found out that gmail.com and googlemail.com -- despite behaving as aliases in lots of ways -- actually have different DMARC policies: v=DMARC1; p=none; sp=quarantine; rua=mailto:mailauth-repo...@google.com for gmail.com vs. v=DMARC1; p=quarantine; sp=quarantine; rua=mailto:mailauth-repo...@google.com for googlemail.com and have therefore switched my account to gmail.com. Will hopefully work fine now. But now I am unsure whether I should resend my patchsets? - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019, at 1:25 PM, Hendrik Leppkes wrote: > > Did you try the "wrap" option? As I understand it, it would preserve > the original mail entirely, and rely on the mail client of the > recipient (ie. us) to properly unwrap the MIME container. > We've had various problems of authorship in patches getting mangled by > this, so if that could prevent it, that would be useful. I did not. At the time it seemed more problematic than munge, but I did not foresee the patchwork issue with munge. But we can certainly give it a try if you like. I'm not sure how patchwork will handle it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019 at 9:04 PM Lou Logan wrote: > > On Thu, Apr 18, 2019, at 4:51 AM, Hendrik Leppkes wrote: > > > > Whoever setup this ML sender rewriting thing should probably look into > > options to also re-write the patch content and add a "From:" line in > > there with the original name and email to avoid issues. > > I enabled this due DMARC as Timo correctly pointed out. This was due to the > seemingly increasing number of rejected/bounced messages from certain domains > resulting in the recipient being automatically unsubscribed from the list. I > changed this relatively recently (last month?). I was unaware of the > patchwork issue. > > This was implemented with the "dmarc_moderation_action" option within > Mailman. It is currently set to "Munge from" and was previously set to > "Accept". More info: > > https://wiki.list.org/DEV/DMARC > Did you try the "wrap" option? As I understand it, it would preserve the original mail entirely, and rely on the mail client of the recipient (ie. us) to properly unwrap the MIME container. We've had various problems of authorship in patches getting mangled by this, so if that could prevent it, that would be useful. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019 at 03:03:44PM -0400, Lou Logan wrote: > On Thu, Apr 18, 2019, at 4:51 AM, Hendrik Leppkes wrote: > > > > Whoever setup this ML sender rewriting thing should probably look into > > options to also re-write the patch content and add a "From:" line in > > there with the original name and email to avoid issues. > > I enabled this due DMARC as Timo correctly pointed out. This was due to the > seemingly increasing number of rejected/bounced messages from certain domains > resulting in the recipient being automatically unsubscribed from the list. I > changed this relatively recently (last month?). I was unaware of the > patchwork issue. > > This was implemented with the "dmarc_moderation_action" option within > Mailman. It is currently set to "Munge from" and was previously set to > "Accept". More info: > > https://wiki.list.org/DEV/DMARC > > There is no perfect solution to the DMARC situation as far as I know. There may be, but not trivial 0. Understand the problem -> This appears that DMARC ignored the mailing list use case 1. decide on a way to do mailing lists in DMARC 2. get the RFCs updated 3. get the implementations updated OR 1. decide on a way to do mailing lists around DMARC 2. write a spec 3. update relevant implementations to follow this spec For example, one way that would mitigate the issue would be to A. include the original "FROM:" in a new header or something (patch in mailman) B. have the receiving side detect subscribed mailing lists do a maxumum of validity checks and undo the FROM change (patch in git, patchwork, MUAs or some other component that can undo the mess) Iam sure there are issues and its more complex than this, but i dont think it has to be as bad as it is currently if theres some crazy volunteer. PS: also i did not look into existing efforts to resolve this, so quite likely others have spend much more time on this and have found more thought through redesigns ... I primarly just think that there is some way that is better than what has to be done currently ... Thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart then the original author, trying to rewrite it will not make it better. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019, at 4:51 AM, Hendrik Leppkes wrote: > > Whoever setup this ML sender rewriting thing should probably look into > options to also re-write the patch content and add a "From:" line in > there with the original name and email to avoid issues. I enabled this due DMARC as Timo correctly pointed out. This was due to the seemingly increasing number of rejected/bounced messages from certain domains resulting in the recipient being automatically unsubscribed from the list. I changed this relatively recently (last month?). I was unaware of the patchwork issue. This was implemented with the "dmarc_moderation_action" option within Mailman. It is currently set to "Munge from" and was previously set to "Accept". More info: https://wiki.list.org/DEV/DMARC There is no perfect solution to the DMARC situation as far as I know. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On 18-04-2019 07:03 PM, Hendrik Leppkes wrote: On Thu, Apr 18, 2019 at 3:31 PM Gyan wrote: On 18-04-2019 06:13 PM, Hendrik Leppkes wrote: All of those patches with re-written senders are send from the same email, ffmpeg-devel@ffmpeg.org Presumably patchwork only sends the email itself, not the name, and as such assumes this is the same person. In git master of patchwork, I see that if a different name is provided for the same email, this new name is updated in the Person db object and used. See https://github.com/getpatchwork/patchwork/blob/c4eca471a4a2cc3a2438e3ee6061df8988a251a6/patchwork/parser.py#L365 Introduced in v2.1.1. Which version are we using? This is still not tracked on a per-patch basis, but one global name per email address, so it wouldn't really solve anything. It just changes from first person to send a patch to latest person to do so - altering all previously send patches as well. Unfortunate. Need to be vigilant about patch headers now. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019 at 3:31 PM Gyan wrote: > > > > On 18-04-2019 06:13 PM, Hendrik Leppkes wrote: > > On Thu, Apr 18, 2019 at 12:41 PM Gyan wrote: > >> Ok. Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? > >> It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly > >> substituted here. > >> This looks like a parser failure in Patchwork. > >> > > All of those patches with re-written senders are send from the same > > email, ffmpeg-devel@ffmpeg.org > > Presumably patchwork only sends the email itself, not the name, and as > > such assumes this is the same person. > > > > In git master of patchwork, I see that if a different name is provided > for the same email, this new name is updated in the Person db object and > used. > > See > https://github.com/getpatchwork/patchwork/blob/c4eca471a4a2cc3a2438e3ee6061df8988a251a6/patchwork/parser.py#L365 > > Introduced in v2.1.1. Which version are we using? > This is still not tracked on a per-patch basis, but one global name per email address, so it wouldn't really solve anything. It just changes from first person to send a patch to latest person to do so - altering all previously send patches as well. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On 18-04-2019 06:13 PM, Hendrik Leppkes wrote: On Thu, Apr 18, 2019 at 12:41 PM Gyan wrote: Ok. Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly substituted here. This looks like a parser failure in Patchwork. All of those patches with re-written senders are send from the same email, ffmpeg-devel@ffmpeg.org Presumably patchwork only sends the email itself, not the name, and as such assumes this is the same person. In git master of patchwork, I see that if a different name is provided for the same email, this new name is updated in the Person db object and used. See https://github.com/getpatchwork/patchwork/blob/c4eca471a4a2cc3a2438e3ee6061df8988a251a6/patchwork/parser.py#L365 Introduced in v2.1.1. Which version are we using? Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On Thu, Apr 18, 2019 at 12:41 PM Gyan wrote: > > > > On 18-04-2019 03:25 PM, Timo Rothenpieler wrote: > > On 18/04/2019 09:49, Gyan wrote: > >> > >> Patchwork can incorrectly assign ownership. See > >> https://patchwork.ffmpeg.org/patch/12680/ > >> > >> The author is Sam John as identified by Message ID as well as the > >> From field in the headers, yet Patchwork attributes this patch to > >> "Oliver Collyer via ffmpeg-devel", a name which appears nowhere in > >> the headers or in the submitted patch. The downloaded mbox patch > >> shows the same wrong attribution. Does anyone know what's going on? > >> > >> Gyan > >> ___ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > > > This happens due to Mailman having to rewrite peoples E-Mail addresses > > if they have strong DKIM/DMARC configured on their sending Domain. > > If that is the case, only the server of the actual Domain who owns the > > right private key can send E-Mails under the name of that Domain. > > > > So for mailing lists to be able to send on the messages, they are > > forced to change the sender address. > > In the case of this list: > > Sam John > > gets translated to. > > Sam John via ffmpeg-devel > > > > Ok. Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? > It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly > substituted here. > This looks like a parser failure in Patchwork. > All of those patches with re-written senders are send from the same email, ffmpeg-devel@ffmpeg.org Presumably patchwork only sends the email itself, not the name, and as such assumes this is the same person. Whoever setup this ML sender rewriting thing should probably look into options to also re-write the patch content and add a "From:" line in there with the original name and email to avoid issues. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
Ok. Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly substituted here. This looks like a parser failure in Patchwork. Gyan If the patch is sent with git send-email, the From: header of the E-Mail is where git puts the Author. So patchwork has no chance to correct this. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On 18-04-2019 03:25 PM, Timo Rothenpieler wrote: On 18/04/2019 09:49, Gyan wrote: Patchwork can incorrectly assign ownership. See https://patchwork.ffmpeg.org/patch/12680/ The author is Sam John as identified by Message ID as well as the From field in the headers, yet Patchwork attributes this patch to "Oliver Collyer via ffmpeg-devel", a name which appears nowhere in the headers or in the submitted patch. The downloaded mbox patch shows the same wrong attribution. Does anyone know what's going on? Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". This happens due to Mailman having to rewrite peoples E-Mail addresses if they have strong DKIM/DMARC configured on their sending Domain. If that is the case, only the server of the actual Domain who owns the right private key can send E-Mails under the name of that Domain. So for mailing lists to be able to send on the messages, they are forced to change the sender address. In the case of this list: Sam John gets translated to. Sam John via ffmpeg-devel Ok. Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly substituted here. This looks like a parser failure in Patchwork. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Patchwork attribution
On 18/04/2019 09:49, Gyan wrote: Patchwork can incorrectly assign ownership. See https://patchwork.ffmpeg.org/patch/12680/ The author is Sam John as identified by Message ID as well as the From field in the headers, yet Patchwork attributes this patch to "Oliver Collyer via ffmpeg-devel", a name which appears nowhere in the headers or in the submitted patch. The downloaded mbox patch shows the same wrong attribution. Does anyone know what's going on? Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". This happens due to Mailman having to rewrite peoples E-Mail addresses if they have strong DKIM/DMARC configured on their sending Domain. If that is the case, only the server of the actual Domain who owns the right private key can send E-Mails under the name of that Domain. So for mailing lists to be able to send on the messages, they are forced to change the sender address. In the case of this list: Sam John gets translated to. Sam John via ffmpeg-devel Nothing can be sensibly done about this, cause the alternative would be the message getting rejected by the majority of Mailservers. It's unfortunate that this also messes with the patches. People who are affected should probably attach patches instead of using send-email. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] Patchwork attribution
Patchwork can incorrectly assign ownership. See https://patchwork.ffmpeg.org/patch/12680/ The author is Sam John as identified by Message ID as well as the From field in the headers, yet Patchwork attributes this patch to "Oliver Collyer via ffmpeg-devel", a name which appears nowhere in the headers or in the submitted patch. The downloaded mbox patch shows the same wrong attribution. Does anyone know what's going on? Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
