RE: (Victor) RE: import statements
Glen Mazza wrote: Your IDE tool created another .* invalid import at http://cvs.apache.org/viewcvs.cgi/xml-fop/src/java/org/apache/fop/ fo/extensions/svg/SVGElementMapping.java?rev=1.1content-type=text /vnd.viewcvs-markup. Please fix it up--the Batik team is requesting changes to this file. Yes, I am trying to get to all of this. When I have moved classes in the past, I just do a file-wide add search-and-replace on import statements so that no invalid imports need be created. You would be correct if you were to presume that this takes 5 mins. vs. perhaps 3 seconds for your nice IDE class-moving tool--problem is, trying to retroactively figure out which classes are in which file takes far more effort than the 4:57 saved. I found a setting in the IDE that should change this behavior. If you don't feel this way, fine, go ahead and retroactively fit all classes you created w/invalid imports to our coding standards, but from now on please make the changes *before* checking the file in. It is important that the time involved in this retrofitting be part of the calculations in your decision to use the IDE refactoring tool. Just leaving the code invalid and hiding in the tall grass--to use your phrase--should not be considered an option, as it would result in disasterous overuse of that IDE function. No hiding going on here. I am responsible for fixing it, and I apologize for the inconvenience. It is clear that we have different priorities here, and I'll do my best to accommodate yours better. Victor Mote
cvs commit: xml-fop/src/java/org/apache/fop/fo/extensions/svg SVGElementMapping.java
vmote 2003/09/08 09:32:01
Modified:src/java/org/apache/fop/fo/extensions/svg
SVGElementMapping.java
Log:
remove extraneous import statement
Revision ChangesPath
1.2 +12 -14
xml-fop/src/java/org/apache/fop/fo/extensions/svg/SVGElementMapping.java
Index: SVGElementMapping.java
===
RCS file:
/home/cvs/xml-fop/src/java/org/apache/fop/fo/extensions/svg/SVGElementMapping.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SVGElementMapping.java28 Aug 2003 19:49:44 - 1.1
+++ SVGElementMapping.java8 Sep 2003 16:32:01 - 1.2
@@ -3,34 +3,34 @@
*
*The Apache Software License, Version 1.1
*
- *
+ *
* Copyright (C) 1999-2003 The Apache Software Foundation. All rights reserved.
- *
+ *
* Redistribution and use in source and binary forms, with or without modifica-
* tion, are permitted provided that the following conditions are met:
- *
+ *
* 1. Redistributions of source code must retain the above copyright notice,
*this list of conditions and the following disclaimer.
- *
+ *
* 2. Redistributions in binary form must reproduce the above copyright notice,
*this list of conditions and the following disclaimer in the documentation
*and/or other materials provided with the distribution.
- *
+ *
* 3. The end-user documentation included with the redistribution, if any, must
*include the following acknowledgment: This product includes software
*developed by the Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowledgment may appear in the software itself, if
*and wherever such third-party acknowledgments normally appear.
- *
+ *
* 4. The names FOP and Apache Software Foundation must not be used to
*endorse or promote products derived from this software without prior
*written permission. For written permission, please contact
*[EMAIL PROTECTED]
- *
+ *
* 5. Products derived from this software may not be called Apache, nor may
*Apache appear in their name, without prior written permission of the
*Apache Software Foundation.
- *
+ *
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
@@ -42,12 +42,12 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
- *
+ *
* This software consists of voluntary contributions made by many individuals
* on behalf of the Apache Software Foundation and was originally created by
* James Tauber [EMAIL PROTECTED]. For more information on the Apache
* Software Foundation, please see http://www.apache.org/.
- */
+ */
package org.apache.fop.fo.extensions.svg;
import java.util.HashMap;
@@ -59,8 +59,6 @@
import org.apache.batik.util.XMLResourceDescriptor;
import org.apache.batik.dom.svg.SVGDOMImplementation;
-import org.apache.fop.svg.*;
-
/**
* Setup the SVG element mapping.
* This adds the svg element mappings used to create the objects
@@ -81,7 +79,7 @@
try {
XMLResourceDescriptor.setXMLParserClassName(
FOFileHandler.getParserClassName());
-
+
foObjs = new HashMap();
foObjs.put(svg, new SE());
foObjs.put(DEFAULT, new SVGMaker());
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: (Victor) RE: import statements
Victor Mote wrote: Glen Mazza wrote: Your IDE tool created another .* invalid import at http://cvs.apache.org/viewcvs.cgi/xml-fop/src/java/org/apache/fop/ fo/extensions/svg/SVGElementMapping.java?rev=1.1content-type=text /vnd.viewcvs-markup. Please fix it up--the Batik team is requesting changes to this file. Yes, I am trying to get to all of this. I have committed a change for this specific instance, and am cleaning up the remaining items right now. Victor Mote
RE: (Victor) RE: import statements
Victor Mote wrote: I have committed a change for this specific instance, and am cleaning up the remaining items right now. All of the global imports are now gone. Again, I apologize for the inconvenience. Victor Mote
Re: Batik Extension/FOP problem
Thomas, Two concerns on making this change in our production version: 1.) We do not have plans anytime soon for making a new release of maintenance--so, if I made the change, the new pdftranscoder.jar could be based only on a nightly build--is that OK with you? 2.) I checked out xml-batik and ran ant dist-zip--it created many jar files, but no single batik.jar file that FOP currently relies on: http://cvs.apache.org/viewcvs.cgi/xml-fop/lib/batik.jar How do I obtain a single batik.jar for me to compile the changed application against? What does an official batik.jar include? Thanks, Glen __ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com
cvs commit: xml-fop/src/org/apache/fop/apps Driver.java
gmazza 2003/09/08 15:15:28
Modified:src/org/apache/fop/apps Tag: fop-0_20_2-maintain Driver.java
Log:
Commented out logger not set error message to allow for quiet running of FOP
without hardcoding Avalon into user's application.
Revision ChangesPath
No revision
No revision
1.36.2.11 +2 -2 xml-fop/src/org/apache/fop/apps/Attic/Driver.java
Index: Driver.java
===
RCS file: /home/cvs/xml-fop/src/org/apache/fop/apps/Attic/Driver.java,v
retrieving revision 1.36.2.10
retrieving revision 1.36.2.11
diff -u -r1.36.2.10 -r1.36.2.11
--- Driver.java 25 Feb 2003 10:18:32 - 1.36.2.10
+++ Driver.java 8 Sep 2003 22:15:27 - 1.36.2.11
@@ -235,7 +235,7 @@
private Logger getLogger() {
if(log == null) {
log = new ConsoleLogger(ConsoleLogger.LEVEL_INFO);
-log.error(Logger not set);
+// log.error(Logger not set);
}
return log;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: FOP error log idea
May be a good idea. Xalan has something similar (it's the only other class in the package that has its main Process class, I believe.) Glen --- Clay Leeds [EMAIL PROTECTED] wrote: Would it be possible and/or would it make sense to output the following information at the top of the ERROR/Log? - fop version - jdk version - platform on which error occurred (or where FOP is being run) I don't know if there's any other information (total RAM; RAM in use by FOP/Java, etc.; RAM available; hard drive space available)... Just a thought! Web Maestro Clay - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com
