RE: Question on protected Logger member in some classes

[Andrejus Chaliapinas]

> If anyone else can do that in the meantime, that would be great. There
> are other patches also waiting to be processed.

Probably you are the only man who could do that. There were no responses for
last 4 hours. Hopefully tomorrow.

Andrejus

DO NOT REPLY [Bug 40667] - Change protected Loggers to private

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40667





--- Additional Comments From [EMAIL PROTECTED]  2006-10-03 07:03 ---
Created an attachment (id=18956)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18956&action=view)
Corrects Logger in several LM classes

Corrects (adds where missed) Logger from protected to private in these classes:

LineLayoutManager, TableCellLayoutManager, TableLayoutManager,
BreakingAlgorithm, PageBreakingAlgorithm

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

Re: Question on protected Logger member in some classes

[Jeremias Maerki]

As soon as I have time and write access to the SVN repo. Here at the
Cocoon GetTogether we're having some problems accessing SVN over HTTPS.
If anyone else can do that in the meantime, that would be great. There
are other patches also waiting to be processed.

On 03.10.2006 16:05:48 Andrejus Chaliapinas wrote:
> > You're right. These protected variables are sometimes not ideal. If you
> > change anything to private while you work on the code, that's fine for
> > me.
> 
> Could you apply this patch to trunk?
> http://issues.apache.org/bugzilla/attachment.cgi?id=18956
> 
> Andrejus



Jeremias Maerki

RE: Question on protected Logger member in some classes

[Andrejus Chaliapinas]

> You're right. These protected variables are sometimes not ideal. If you
> change anything to private while you work on the code, that's fine for
> me.

Could you apply this patch to trunk?
http://issues.apache.org/bugzilla/attachment.cgi?id=18956

Andrejus

Re: [Xmlgraphics-fop Wiki] Update of "ReleasePlanning" by JeremiasMaerki

[vhennebert]

Hi All,

>
>   === To be done before a possible 0.93 release ===
>
> +  * Apply the ToUnicode CMAP patch
([http://issues.apache.org/bugzilla/show_bug.cgi?id=5335 Bugzilla
#5335])

Among the many discussions we're having during the hackathon, and given that:
- this is a feature many users have been asking for for long;
- Victor recently gave his agreement for integrating his code back into Fop;
we decided to apply the long-standing patch for ToUnicode support to the
Trunk, so that it works in the next release. That's a temporary solution
until the FOrayFont stuff gets integrated into the Trunk.

Hoping that's ok for everybody.

Cheers from Amsterdam!
Vincent

DO NOT REPLY [Bug 40667] New: - Change protected Loggers to private

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40667

   Summary: Change protected Loggers to private
   Product: Fop
   Version: 0.92
  Platform: PC
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

Re: Question on protected Logger member in some classes

[Jeremias Maerki]

You're right. These protected variables are sometimes not ideal. If you
change anything to private while you work on the code, that's fine for
me.

On 03.10.2006 15:02:28 Andrejus Chaliapinas wrote:
> Hi,
> 
> While trying to debug some changes I've made wtih layout managers I've
> noticed that some classes have Logger as protected but not private member?
> What is the rationale here - just easy later inheritance of logger or
> anything else? For me it seems that logger purpose is to exactly identify
> the class, which makes some output and thus shown by name and not see some
> parent class name in output. What do you think? How about changing that
> current protected to private?
> 
> Thank you,
> Andrejus



Jeremias Maerki

Question on protected Logger member in some classes

[Andrejus Chaliapinas]

Hi,

While trying to debug some changes I've made wtih layout managers I've
noticed that some classes have Logger as protected but not private member?
What is the rationale here - just easy later inheritance of logger or
anything else? For me it seems that logger purpose is to exactly identify
the class, which makes some output and thus shown by name and not see some
parent class name in output. What do you think? How about changing that
current protected to private?

Thank you,
Andrejus

Re: Hi from the Cocoon GetTogether in Amsterdam

[Bertrand Delacretaz]

On 10/3/06, Jeremias Maerki <[EMAIL PROTECTED]> wrote:


...Big thanks to the Cocoon community
for letting us take part in their event...


With my Cocoonista hat on: thanks to you FOP guys for being here,
there are definitely synergies between our projects and it's good to
see that happen IRL as well.

-Bertrand

Hi from the Cocoon GetTogether in Amsterdam

[Jeremias Maerki]

Vincent Hennebert, Simon Pepping, Bertrand Delacrétaz and I sit together
here at the Cocoon GetTogether discussing all sorts of things about FOP.
Topics so far were: letting line and page breaking interact for more
layout functionality, general discussions about the Knuth-based layout
approach including Simon's generalized approach, the font system
(ToUnicode CMAPs, OpenType support, FOrayFont...), page-number-citations,
minimum JDK requirements, the next FOP release, etc. etc.

No decisions, of course, just exchanging information, finding out stuff...

Yesterday, Lars Trieloff and I have implemented a new Cocoon Block for
FOP 0.92beta and later. The patch has already been committed to the
Cocoon 2.2.x repo. It was nice to see how the new API paid off, reducing
the number of lines necessary for the integration and adding support for
URI resolution which was a huge problem for Cocoon with FOP 0.20.5.

Generally, this event is a great opportunity to get to know each other
and to discuss in a different way. Big thanks to the Cocoon community
for letting us take part in their event. The location and food is very
good and we enjoy this very much. It would have been cool to have even
more team members here.

Some photos from the event (more photos being added as the event
progresses...): http://www.flickr.com/search/?q=cocoongt2006

Jeremias Maerki
from Amsterdam, NL