Re: Want to contribute

2011-05-03 Thread Pascal Sancho
Hi,

FOP is an open source project, and everybody can contribute in his own
way, so you can reopen closed issues as you want if needed, and submit
patches as you want.

That said, IMHO, apart in a company quality context, testing closed
issues will not help very much (typically, an issue is closed after
developer's checks, and it is often monitored by the opener who reopen
it if needed)
But:
you can check old opened issues against FOP TRUNK, since there is no
systematic checks for opened issues after each commit.
You can find fixed issues that haven't been closed.

Le 01/05/2011 02:25, darshan a écrit :
 Dear All,
 
 I am a post graduate student at the Australian National University 
 taking a course on Free and Open Source Software Development. Part of 
 the course requirement is to study an open source project of my choice, 
 make a contribution and write a report by the end of May 2011.
 
 I have been going through the fop site and documents and from the 'How 
 you can help' topic on the page 
 http://xmlgraphics.apache.org/fop/dev/index.html
 I thought the best way I could contribute is  by testing newly-closed 
 issues to make sure they are truly closed. By doing this I can gradually 
 understand how the system works and hopefully start make more 
 contributions like submitting bug reports and patches.
 
 Can I start from the most recent fix form the page 
 http://xmlgraphics.apache.org/fop/changes.html#Code_FOP%20Trunk ? please 
 guide me as to what would be the best way of doing it and also I would 
 be really glad if you could suggest me any other way to contribute that 
 would help the project better.
 
 Best regards,
 Darshan Pradhan
 u4729...@anu.edu.au

-- 
Pascal


Re: Want to contribute

2011-05-03 Thread Glenn Adams
Actually, I would encourage testing closed issues, or at least those issues
that were resolved without creating a test data set that demonstrates both
the bug and the fix, and maintains non-regression.

I have noticed a number of issues fixed without adding such tests, which
should be the norm, not the exception.

G.

On Tue, May 3, 2011 at 1:24 AM, Pascal Sancho pascal.san...@takoma.frwrote:

 Hi,

 FOP is an open source project, and everybody can contribute in his own
 way, so you can reopen closed issues as you want if needed, and submit
 patches as you want.

 That said, IMHO, apart in a company quality context, testing closed
 issues will not help very much (typically, an issue is closed after
 developer's checks, and it is often monitored by the opener who reopen
 it if needed)
 But:
 you can check old opened issues against FOP TRUNK, since there is no
 systematic checks for opened issues after each commit.
 You can find fixed issues that haven't been closed.

 Le 01/05/2011 02:25, darshan a écrit :
  Dear All,
 
  I am a post graduate student at the Australian National University
  taking a course on Free and Open Source Software Development. Part of
  the course requirement is to study an open source project of my choice,
  make a contribution and write a report by the end of May 2011.
 
  I have been going through the fop site and documents and from the 'How
  you can help' topic on the page
  http://xmlgraphics.apache.org/fop/dev/index.html
  I thought the best way I could contribute is  by testing newly-closed
  issues to make sure they are truly closed. By doing this I can gradually
  understand how the system works and hopefully start make more
  contributions like submitting bug reports and patches.
 
  Can I start from the most recent fix form the page
  http://xmlgraphics.apache.org/fop/changes.html#Code_FOP%20Trunk ? please
  guide me as to what would be the best way of doing it and also I would
  be really glad if you could suggest me any other way to contribute that
  would help the project better.
 
  Best regards,
  Darshan Pradhan
  u4729...@anu.edu.au

 --
 Pascal



DO NOT REPLY [Bug 18801] [PATCH] visibility property is not implemented

2011-05-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18801

Chris Bowditch bowditch_ch...@hotmail.com changed:

   What|Removed |Added

Summary|visibility property is|[PATCH] visibility
   |not implemented |property is not implemented

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 51144] New: ToUnicode table for subset font contains invalid entries

2011-05-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51144

 Bug #: 51144
   Summary: ToUnicode table for subset font contains invalid
entries
   Product: Fop
   Version: 1.0
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: fonts
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: r.grosm...@gmail.com
Classification: Unclassified


In the ToUnicode table that maps character codes from a subset font to unicode
characters, the first three entries map to unicode . The first one is the
.notdef glyph, so this is OK, but the following two might be incorrect.

This is the beginning of such a table:

21 beginbfchar
 
0001 
0002 
0003 002d
0004 0031

I posted a question on the fop-users mailing list on 2 may 2011.  Mehdi
Houshmand replied on 3 may 2011:


Yes this is a bug, which has been fixed in my patch, but since I
didn't think anyone else had bumped into it I didn't want to put it
into trunk since I also made some code improvements to the class and
was weary that it could cause merge issues when/if the branches are
merged.

The issue is that in most fonts the first 3 glyphs are set to .notdef,
and this was implemented in FOP. However, the spec says only the first
glyph is reserved for .notdef, and what happens in MOST fonts doesn't
happen in ALL fonts.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 51144] ToUnicode table for subset font contains invalid entries

2011-05-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51144

--- Comment #1 from Mehdi Houshmand med1...@gmail.com 2011-05-03 12:35:04 UTC 
---
Created attachment 26954
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=26954
Removed 2 reserved glyphs from the CIDSubset

This patch seeks to address the fact that the first 3 glyphs are being
reserved, where as only the first glyph should be reserved for .notdef.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.