Re: Fixing marks layering
On 24.10.2008 13:19:13 Vincent Hennebert wrote: > Hi, > > Tacio Naja Domingos wrote: > > Thanks for your reply. In that you believe the Antenna House formatter > > implementation is correct, do you know how I would, in theory, be able to > > get the table-cell border displayed below the block-container (current Fop > > behaviour)? > > In theory, I guess you should play with the z-index property, setting > a higher value on the absolutely positioned block-container than on the > surrounding table. But z-index is not implemented in FOP, and I didn’t > manage to get it working with XSL Formatter either, even if they claim > to support z-index. So I’m not sure. Right, z-index might (theoretically) help. > FWIW, the example below renders quite badly with FOP: the yellow > background extends down to outside of the table (see attached pdf). > Apparently the absolutely positioned block is creating trouble, since > the rendering is ok when removing it. Does anyone have a quick idea of > what’s wrong or do I create a bug report for this? Already fixed the problem: http://svn.apache.org/viewvc?rev=707631&view=rev It seems I didn't catch all possibilities when I fixed bug #36391. > > Vincent > > > > - Original Message > > From: Jeremias Maerki <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > Cc: Tacio Naja Domingos <[EMAIL PROTECTED]>; fop-dev@xmlgraphics.apache.org > > Sent: Monday, October 20, 2008 6:09:14 PM > > Subject: Re: > > > > > > As much as it hurts to admit it (being a FOP developer), Antenna House > > is right, I believe. The section in the spec that defines the layering > > is this: > > http://www.w3.org/TR/xsl11/#rend-layer > > > > I guess that slipped through the cracks and we'll need to see to it that > > this gets fixed. Thanks for bringing this up. > > > > On 20.10.2008 12:20:53 Tacio Naja Domingos wrote: > >> I am running the below peace of code in both Fop 0.94 and Antenna house > >> formatter, but get a rather different behaviour. I was hoping someone > >> could point out which implementation is correct by directing me to the > >> correct sentence in the FO spec. > >> > >> In Fop the table border is drawn below the block-container. In Antenna > >> house formatter, the table-cell border is above the block-container but > >> the table-cell contents are below the block-container. > >> > >> The code is: > >> > >> > >> > >> > >> >> border-width="1pt"> > >> Below > >> >> top="0.15cm" left="0.25cm"> > >> > >> > >> >> keep-together="always">Above > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> Thanks for your help in advance. > >> > >> Tacio > >> > > > > > > > > Jeremias Maerki Jeremias Maerki
Re: Fixing marks layering
Hi, Tacio Naja Domingos wrote: > Thanks for your reply. In that you believe the Antenna House formatter > implementation is correct, do you know how I would, in theory, be able to get > the table-cell border displayed below the block-container (current Fop > behaviour)? In theory, I guess you should play with the z-index property, setting a higher value on the absolutely positioned block-container than on the surrounding table. But z-index is not implemented in FOP, and I didn’t manage to get it working with XSL Formatter either, even if they claim to support z-index. So I’m not sure. FWIW, the example below renders quite badly with FOP: the yellow background extends down to outside of the table (see attached pdf). Apparently the absolutely positioned block is creating trouble, since the rendering is ok when removing it. Does anyone have a quick idea of what’s wrong or do I create a bug report for this? Vincent > - Original Message > From: Jeremias Maerki <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: Tacio Naja Domingos <[EMAIL PROTECTED]>; fop-dev@xmlgraphics.apache.org > Sent: Monday, October 20, 2008 6:09:14 PM > Subject: Re: > > > As much as it hurts to admit it (being a FOP developer), Antenna House > is right, I believe. The section in the spec that defines the layering > is this: > http://www.w3.org/TR/xsl11/#rend-layer > > I guess that slipped through the cracks and we'll need to see to it that > this gets fixed. Thanks for bringing this up. > > On 20.10.2008 12:20:53 Tacio Naja Domingos wrote: >> I am running the below peace of code in both Fop 0.94 and Antenna house >> formatter, but get a rather different behaviour. I was hoping someone could >> point out which implementation is correct by directing me to the correct >> sentence in the FO spec. >> >> In Fop the table border is drawn below the block-container. In Antenna house >> formatter, the table-cell border is above the block-container but the >> table-cell contents are below the block-container. >> >> The code is: >> >> >> >> >> > border-width="1pt"> >> Below >> > top="0.15cm" left="0.25cm"> >> >> > keep-together="always">Above >> >> >> >> >> >> >> >> >> >> Thanks for your help in advance. >> >> Tacio >> > > > > Jeremias Maerki res.pdf Description: Adobe PDF document
Re: Fixing marks layering
Hmm, it doesn't look like an 5-minute fix since we have stuff like drawBackAndBorders(). This will need to be taken apart into drawBackground() and drawBorders(). Similarly, handle*Traits() methods need to be split. And then lots of testing. I don't think we need to care about breaking external renderers in this case, since we're clearly talking about a bug here. I believe that someone who maintains a private renderer will be interested to fix that problem, too. If there's a reason for not breaking compatibility, please speak up ASAP. Since I'm working in the renderer area anyway (with the new intermediate format), I'll volunteer to fix this. On 20.10.2008 19:09:14 Jeremias Maerki wrote: > As much as it hurts to admit it (being a FOP developer), Antenna House > is right, I believe. The section in the spec that defines the layering > is this: > http://www.w3.org/TR/xsl11/#rend-layer > > I guess that slipped through the cracks and we'll need to see to it that > this gets fixed. Thanks for bringing this up. > > On 20.10.2008 12:20:53 Tacio Naja Domingos wrote: > > > > I am running the below peace of code in both Fop 0.94 and Antenna house > > formatter, but get a rather different behaviour. I was hoping someone could > > point out which implementation is correct by directing me to the correct > > sentence in the FO spec. > > > > In Fop the table border is drawn below the block-container. In Antenna > > house formatter, the table-cell border is above the block-container but the > > table-cell contents are below the block-container. > > > > The code is: > > > > > > > > > > > border-width="1pt"> > > Below > > > top="0.15cm" left="0.25cm"> > > > > > keep-together="always">Above > > > > > > > > > > > > > > > > > > > > Thanks for your help in advance. > > > > Tacio > > > > > > Jeremias Maerki > Jeremias Maerki