RE: Area tree format improvements

[Jan Tosovsky]

On 2016-08-05 Glenn Adams wrote:
> On 2016-08-04 Jan Tosovsky wrote:
> >
> > when implementing change bars I encountered problem with 
> > proper storing the change bar info using the current Area Tree 
> > vocabulary: https://issues.apache.org/jira/browse/FOP-2640
> > 
> > Is it Ok to extend the curent element set?
>
> Firstly, the AT (area tree) output format is really only used 
> for testing these days...
> 

I've implemented a new element named inlineBlock extending InlineParent which 
wraps the standard Block element. It is parsed without errors and still 
generates a proper IF format.

However, as it can be tested on change bar element only, not yet in the trunk, 
I prefer incorporating this change to change bar patch
https://issues.apache.org/jira/browse/FOP-1760 (the current patch without this 
change will fail anyway when tests are properly run).

Is it Ok?

Jan

[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation

[JIRA]

 [ 
https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Tošovský updated FOP-1760:
--
Attachment: patch_against_rev_1755460_2016-08-07.patch

Updating patch to the current trunk (maven based). Incorporating fix for 
failing tests.

> [PATCH] FOP doesn't support change bar generation
> -
>
> Key: FOP-1760
> URL: https://issues.apache.org/jira/browse/FOP-1760
> Project: FOP
>  Issue Type: Bug
>  Components: unqualified
>Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
>Reporter: Stephan Thesing
> Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, 
> changebar_20110308.diff, changebars.fo, changebars.pdf, 
> changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, 
> fop_20120507.diff, fop_changebars_20120506.diff, 
> patch_against_rev_1686494_2015-06-19.patch, 
> patch_against_rev_1690781_2015-07-19.patch, 
> patch_against_rev_1755460_2016-08-07.patch, test.fo, test.pdf
>
>
> In order to produce change bars along the columns for changed contents,
> FO supports the fo:change-bar-begin and fo:change-bar-end elements.
> These are not supported by FOP.
> Support for change bars should be added.
> Effort needed
>  - add parsing and validation of fo: elements
>  - determine fo elements under influence of one or more change bars
>  - when creating areas from such affected fo elements, create additional areas
> representing the change bars as defined in the FO standard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Area tree format improvements

[Glenn Adams]

On Sun, Aug 7, 2016 at 12:40 PM, Jan Tosovsky  wrote:

> On 2016-08-05 Glenn Adams wrote:
> > On 2016-08-04 Jan Tosovsky wrote:
> > >
> > > when implementing change bars I encountered problem with
> > > proper storing the change bar info using the current Area Tree
> > > vocabulary: https://issues.apache.org/jira/browse/FOP-2640
> > >
> > > Is it Ok to extend the curent element set?
> >
> > Firstly, the AT (area tree) output format is really only used
> > for testing these days...
> >
>
> I've implemented a new element named inlineBlock extending InlineParent
> which wraps the standard Block element. It is parsed without errors and
> still generates a proper IF format.
>
> However, as it can be tested on change bar element only, not yet in the
> trunk, I prefer incorporating this change to change bar patch
> https://issues.apache.org/jira/browse/FOP-1760 (the current patch without
> this change will fail anyway when tests are properly run).
>
> Is it Ok?
>

You would need to submit the patch as an attachment, then it will require
an FOP committer to evaluate it.


>
> Jan
>
>
>
>
>