Re: [foreman-dev] The road to Rails 5.1

2017-12-04 Thread Ohad Levy
On Mon, Dec 4, 2017 at 9:57 PM, Eric D Helms  wrote:

>
>
> On Thu, Nov 30, 2017 at 5:52 PM, Michael Moll  wrote:
>
>> Hi,
>>
>> On Thu, Nov 30, 2017 at 02:20:09PM -0500, Eric D Helms wrote:
>> >  * Rails 5 SCL initial builds minus turbolinks exist [1]
>> >  * Turobolinks 2.4.5 is being released that will have Rails 5
>> compatability
>> >  * Work is progressing to test rebuild Foreman stack against SCL, this
>> will
>> >be followed up runtime tests
>> >
>> > Would someone with more knowledge on the code side of the Rails 5 mind
>> > sending along an update of the path we see for getting to 5.1?
>>
>> We're currently blocked by two external dependencies:
>> - https://github.com/turbolinks/turbolinks-classic/pull/679 (already
>>   merged, we're only waiting for the gem release)
>> - https://github.com/oauth-xx/oauth-ruby/pull/150
>
>
> Are these requires for 5.0 or 5.1?
>
>
>>
>>
>> Once there are gem releases out, I'd open PRs to raise the lower version
>> boundary of these in core and after these got in, I'd ask
>> https://github.com/theforeman/foreman/pull/4867
>> to get merged (BTW, Eric, please see the comment at the bottom).
>>
>> At that state, core would be using Rails 5.0 only and I'd open one PR
>> including the 5.0 only parts of
>> https://github.com/theforeman/foreman/pull/4836
>>
>> After that one got merged, core would be using Rails 5.0 and be
>> incompatible with Rails 4.2.
>>
>> Plugin authors should start updating their plugins to Rails 5.0
>> standards at that point.
>>
>> Then I'd open a PR with the switch from Rails 5.0 to 5.1 and
>> https://github.com/theforeman/foreman/pull/5026
>>
>> After that one got merged, core is using Rails 5.1 (and probably not
>> even Rails 5.0 compatible) and the RPM work can start. DEBs should just
>> work fine without modifications.
>>
>> Plugin authors should check if anything is missing for Rails 5.1 and
>> update, if needed.
>>
>> After that, the remaining deprecation notices with Rails 5.1 should get
>> fixed and once this is done, Rails 5.2 is probably already released.
>>
>
> Generally speaking, now that we've done the up front work to get the start
> of an SCL built, ran basic tests I am OK unblocking migrating core to 5.0
> based on the plan above. We'll have a week or three of brokenness but if
> we've planned on that and are communicating status routinely then I think
> that is the best approach possible to move the code base and fix packaging.
>
>
If rails 5.1 SCL is ready for testing, major kudos and +1 to merge 5.0 (and
even 5.1) now so we can start seeing the issues.

thanks!
Ohad

> Eric
>
>
>>
>> Regards
>> --
>> Michael Moll
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] The road to Rails 5.1

2017-12-04 Thread Eric D Helms
On Thu, Nov 30, 2017 at 5:52 PM, Michael Moll  wrote:

> Hi,
>
> On Thu, Nov 30, 2017 at 02:20:09PM -0500, Eric D Helms wrote:
> >  * Rails 5 SCL initial builds minus turbolinks exist [1]
> >  * Turobolinks 2.4.5 is being released that will have Rails 5
> compatability
> >  * Work is progressing to test rebuild Foreman stack against SCL, this
> will
> >be followed up runtime tests
> >
> > Would someone with more knowledge on the code side of the Rails 5 mind
> > sending along an update of the path we see for getting to 5.1?
>
> We're currently blocked by two external dependencies:
> - https://github.com/turbolinks/turbolinks-classic/pull/679 (already
>   merged, we're only waiting for the gem release)
> - https://github.com/oauth-xx/oauth-ruby/pull/150


Are these requires for 5.0 or 5.1?


>
>
> Once there are gem releases out, I'd open PRs to raise the lower version
> boundary of these in core and after these got in, I'd ask
> https://github.com/theforeman/foreman/pull/4867
> to get merged (BTW, Eric, please see the comment at the bottom).
>
> At that state, core would be using Rails 5.0 only and I'd open one PR
> including the 5.0 only parts of
> https://github.com/theforeman/foreman/pull/4836
>
> After that one got merged, core would be using Rails 5.0 and be
> incompatible with Rails 4.2.
>
> Plugin authors should start updating their plugins to Rails 5.0
> standards at that point.
>
> Then I'd open a PR with the switch from Rails 5.0 to 5.1 and
> https://github.com/theforeman/foreman/pull/5026
>
> After that one got merged, core is using Rails 5.1 (and probably not
> even Rails 5.0 compatible) and the RPM work can start. DEBs should just
> work fine without modifications.
>
> Plugin authors should check if anything is missing for Rails 5.1 and
> update, if needed.
>
> After that, the remaining deprecation notices with Rails 5.1 should get
> fixed and once this is done, Rails 5.2 is probably already released.
>

Generally speaking, now that we've done the up front work to get the start
of an SCL built, ran basic tests I am OK unblocking migrating core to 5.0
based on the plan above. We'll have a week or three of brokenness but if
we've planned on that and are communicating status routinely then I think
that is the best approach possible to move the code base and fix packaging.

Eric


>
> Regards
> --
> Michael Moll
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Koji Space on /

2017-12-04 Thread Eric D Helms
Today Koji filled up its root partition which is designed to be small. In
part, there was 2.0 GB of httpd logs due to the API intensive use of Koji.
These logs are currently rotated and not compressed in anyway.

How should we handle this? A few ideas for discussion:

 1) Modify logrotate configuration to try to compress the logs
 2) Setup a cron job to compress the rotated logs
 3) Rotate the logs less

We also noticed about 850MB of mrepo cache.

-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Request to Releasers: Please pull in translations and merge strings

2017-12-04 Thread Lukas Zapletal
Thanks for reminder, I am so bad in this.

To github.com:theforeman/foreman_discovery.git
   d44e91f..40f44dc  develop -> develop

LZ

On Sat, Dec 2, 2017 at 5:54 PM, Bryan Kearney  wrote:
> This is a request for folks who release plugins, either foreman or hammer.
>
> As part of your release process, please make sure that you are doing the
> following:
> 1) Pulling in the latest translations from transifex
> 2) Extracting strings from your code, and merging in those translations
>
> Almost all the plugins have a Makefile which will do this for you. If
> you got a pull request from me on 1 December, I likely added one or
> fixed it. I am happy to answer questions on how to use it, and to help
> folks in getting their stuff into transifex (/me is looking at you
> foreman-maintain folks).
>
> I have a process which will take translations from downstream and put
> them into transifex. This process ensures the community gets the value
> of the downstream translators. But, it requires that each time a release
> is done the builder refreshes their strings and pulls in the latest
> translations.
>
> -- bk
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.