On Mon, Dec 4, 2017 at 9:57 PM, Eric D Helms <[email protected]> wrote:
> > > On Thu, Nov 30, 2017 at 5:52 PM, Michael Moll <[email protected]> wrote: > >> Hi, >> >> On Thu, Nov 30, 2017 at 02:20:09PM -0500, Eric D Helms wrote: >> > * Rails 5 SCL initial builds minus turbolinks exist [1] >> > * Turobolinks 2.4.5 is being released that will have Rails 5 >> compatability >> > * Work is progressing to test rebuild Foreman stack against SCL, this >> will >> > be followed up runtime tests >> > >> > Would someone with more knowledge on the code side of the Rails 5 mind >> > sending along an update of the path we see for getting to 5.1? >> >> We're currently blocked by two external dependencies: >> - https://github.com/turbolinks/turbolinks-classic/pull/679 (already >> merged, we're only waiting for the gem release) >> - https://github.com/oauth-xx/oauth-ruby/pull/150 > > > Are these requires for 5.0 or 5.1? > > >> >> >> Once there are gem releases out, I'd open PRs to raise the lower version >> boundary of these in core and after these got in, I'd ask >> https://github.com/theforeman/foreman/pull/4867 >> to get merged (BTW, Eric, please see the comment at the bottom). >> >> At that state, core would be using Rails 5.0 only and I'd open one PR >> including the 5.0 only parts of >> https://github.com/theforeman/foreman/pull/4836 >> >> After that one got merged, core would be using Rails 5.0 and be >> incompatible with Rails 4.2. >> >> Plugin authors should start updating their plugins to Rails 5.0 >> standards at that point. >> >> Then I'd open a PR with the switch from Rails 5.0 to 5.1 and >> https://github.com/theforeman/foreman/pull/5026 >> >> After that one got merged, core is using Rails 5.1 (and probably not >> even Rails 5.0 compatible) and the RPM work can start. DEBs should just >> work fine without modifications. >> >> Plugin authors should check if anything is missing for Rails 5.1 and >> update, if needed. >> >> After that, the remaining deprecation notices with Rails 5.1 should get >> fixed and once this is done, Rails 5.2 is probably already released. >> > > Generally speaking, now that we've done the up front work to get the start > of an SCL built, ran basic tests I am OK unblocking migrating core to 5.0 > based on the plan above. We'll have a week or three of brokenness but if > we've planned on that and are communicating status routinely then I think > that is the best approach possible to move the code base and fix packaging. > > If rails 5.1 SCL is ready for testing, major kudos and +1 to merge 5.0 (and even 5.1) now so we can start seeing the issues. thanks! Ohad > Eric > > >> >> Regards >> -- >> Michael Moll >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Eric D. Helms > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
