Re: [foreman-dev] Discourse summary week 2 (ish)

2017-11-15 Thread John Mitsch
Also a +1 from me. Among other things, I like the categories, markdown
support, and tags.

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Wed, Nov 15, 2017 at 9:59 AM, Sebastian Gräßl <sebast...@validcode.me>
wrote:

> I am one of the (silent) +1 voices Greg mentioned.
>
> Discourse would be a very welcomed move for me, there are a number of
> reasons, which Greg already mentioned as well.
>
> For me the one key reason is the possibility to have multiple categories
> to have discussions and share information in a proper context.
>
>
> On Wednesday, November 15, 2017 at 3:46:01 PM UTC+1, Greg Sutcliffe wrote:
>>
>> On 15/11/17 13:58, Lukas Zapletal wrote:
>> > I AM STRONGLY AGAINST *MIGRATING* OUR MAILING LISTS TO ANY KIND OF
>> > FORUM.
>>
>> I have included your opinion in both summaries. As a long standing
>> member of the community, your vote does carry some weight - but shouting
>> doesn't get you an extra one, and makes it appear like you're trying to
>> drown out the debate (which I'm sure you don't intend).
>>
>> If however you feel you've been misrepresented in either of my summaries
>> in some way, please let me know so I can correct that.
>>
>> > You do not have blessing. You gathered how many opinions? Two dozens?
>> > How many of us are subscribed here?
>>
>> No one decides "blessing" or lack of it unilaterally, not me, or you.
>> The community decides, and current feedback suggests far more in
>> *cautious* favour than against - certainly enough to continue the
>> discussion.
>>
>> One thing I have not yet done is post how I see the migration actually
>> happening *if* we choose to do it. That may help alleviate fears for
>> some, so I will try to get that posted shortly. My view of that process
>> won't include a side-by-side site for reasons I already expressed to
>> Ivan earlier. Again, this is all very much *if*, please don't assume
>> this is already decided.
>>
>> > You gathered how many opinions? Two dozens? How many of us are
>> > subscribed here?
>>
>> 670 addresses according to Google Groups, but I know that's not what you
>> mean :)
>>
>> As with all our discussions, we can only count the opinions that have
>> actually been stated. We don't wait forever on any decision, and we
>> frequently take action on 5 votes or less.
>>
>> As with other large debates we've had in the past, I'm being quite
>> reserved with pacing this debate, *precisely* because I know how
>> intrusive it is. I'm spending some of my time trying to convince those
>> who haven't said anything yet to contribute (even if they give it a -1)
>> so that we can be more sure of our final decision, but for sure we
>> *will* have to take a decision at some point.
>>
>> It's worth saying again, no final decisions have been taken, this is
>> still a consultation for now - but we *do* need to consult with the
>> users too. It's a far larger community, and I hope we'll get a nice
>> collection of opinions from them to look through.
>>
>> Greg
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Heads up - hound rubocop version updated

2017-10-26 Thread John Mitsch
This was fixed on katello by https://github.com/Katello/katello/pull/7036

If you have an open PR on katello, you may want to re-kick off Jenkins

-John

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Wed, Oct 25, 2017 at 1:18 PM, Andrew Kofink <akof...@redhat.com> wrote:

> I created an issue in Katello [1] to track the changes there. We may
> assign someone [who isn't there] during today's triage.
>
> [1] http://projects.theforeman.org/issues/21468
>
> On Wed, Oct 25, 2017 at 7:32 AM, Tomer Brisker <tbris...@redhat.com>
> wrote:
>
>> Hi,
>>
>> Hound have updated their version of rubocop to 0.51 which includes some
>> rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
>> latest version and updated the todo file.
>> All plugins using rubocop should make sure their .rubocop.yaml is
>> compatible with the new version.
>>
>> Hound ignores the rubocop version specified in the gemfile, which means
>> that it will start barking on every PR in repos that use it if the settings
>> are incompatible, and once the PR is merged into foreman core, those
>> plugins depending on core and running rubocop on jenkins will start failing.
>>
>> ​The changes to rubocop's rule names can be foun in their changelog [2],
>> or by manually running rubocop version 0.51 with your current configuration
>> and looking out for errors.​ In case the errors are in the
>> .rubocop_todo.yaml file, it can be automatically regenerated by running
>> `rubucop --auto-gen-config` (but keep in mind this will disable any
>> currently failing cops).​
>>
>>
>> ​[1] https://github.com/theforeman/foreman/pull/4949
>> [2] ​https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md
>>
>> --
>> Have a nice day,
>> Tomer Brisker
>> Red Hat Engineering
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Found In Version Katello Redmine custom field

2017-10-16 Thread John Mitsch
+1

If we do this, we should clarify that the current "version" field is used
for releases by calling it "target version" or something similar.

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Mon, Oct 16, 2017 at 10:18 AM, Andrew Kofink <akof...@redhat.com> wrote:

> RFC:
>
> Because Katello is a nested project under Foreman in Redmine, we can only
> see Foreman versions in the "version" field. It would be great to have a
> custom text box field "Found In Version" that bug reporters can provide the
> exact RPM they installed to see the issue.
>
> Let me know if you would find this useful.
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Associate Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] [Infra] Jenkins Job Naming Conventions

2017-09-01 Thread John Mitsch
Another vote for #2 as you can scan quickly and group by project.

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Fri, Sep 1, 2017 at 8:56 AM, Justin Sherrill <jsher...@redhat.com> wrote:

> My vote would be #2, as it groups things by entity a bit nicer.  I don't
> normally care to look at the release job across all projects, but would
> want to look at all jobs across a particular project.
>
> On 09/01/2017 08:43 AM, Eric D Helms wrote:
>
> Howdy,
>
> This is a bit of bike shedding perhaps, but as I start to re-write some of
> our jobs into Jenkins pipeline in my spare time I'd like to establish and
> follow some conventions along the way since this is a bit of a fresh start.
> Two example PRs for those curious are at [1] [2].
>
> The topic for this question is around job naming conventions. I see it as
> two options:
>
>  1) functionality - entity
>-- test-katello
>-- test-foreman
>-- release-katello
>-- test-foreman-pull-request
>-- test-foreman-tasks
>  2) entity - functionality
>-- katello-test
>-- katello-release
>-- foreman-test
>-- foreman-release
>-- foreman-pull-request-test
>-- foreman-tasks-test
>
>
> [1] https://github.com/theforeman/foreman-infra/pull/321
> [2] https://github.com/theforeman/foreman-infra/pull/323
>
>
> --
> Eric D. Helms
> Red Hat Engineering
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Request to join Katello Installer team in Katello Org

2017-08-02 Thread John Mitsch
+1 from me as well, Chris has been working in the installer for a while now.

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Tue, Aug 1, 2017 at 3:04 PM, Eric D Helms <ericdhe...@gmail.com> wrote:

> +1 from me, Chris has been very involved and adding value to both puppet
> and installer itself.
>
> On Tue, Jul 25, 2017 at 6:54 PM, <chrob...@redhat.com> wrote:
>
>> Hi,
>>
>> Since my last request almost a year ago I have been making quite a lot of
>> commits and they have gone from being pretty awful to alot better and
>> through that I have been understanding Puppet and Ruby alot better thanks
>> to people like Stephen Benjamin, Ekohl, and Justin.
>>
>> My commits started out as some basic Ruby but went on to more advanced
>> Ruby and bigger Puppet commits.
>>
>> I have also been doing reviews of Puppet PRS mostly from Ekohl.
>>
>> Here are some of my PR's both in the Ruby and Puppet:
>>
>> https://github.com/Katello/katello-installer/pull/518
>>
>> https://github.com/Katello/puppet-katello/pull/175
>>
>> https://github.com/Katello/puppet-qpid/pull/51
>>
>> https://github.com/Katello/puppet-katello/pull/168/files
>>
>> https://github.com/Katello/puppet-qpid/pull/65
>>
>> https://github.com/Katello/puppet-qpid/pull/62
>>
>> https://github.com/Katello/puppet-pulp/pull/189
>>
>> https://github.com/Katello/puppet-katello/pull/162
>>
>> https://github.com/Katello/katello-installer/pull/472
>>
>> Here are some of the ones I have reviewed around puppet/Ruby recently:
>>
>> https://github.com/Katello/puppet-qpid/pull/60
>>
>> https://github.com/Katello/puppet-katello/pull/190
>>
>> https://github.com/Katello/puppet-katello/pull/198
>>
>> Thanks,
>>
>> Chris Roberts
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread John Mitsch
+1 You've made a lot of good contributions to forklift!

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Wed, Aug 2, 2017 at 8:57 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:
>
>> I would like to request write access to forklift.
>>
>
> Big +1 Evgeni has shown great insight in details with his reviews and high
> quality PRs.
>
> I have 19 merged PRs [1] resulting in 19 commits [2].
>> If I count it right, I also somehow reviewed 7 PRs [3].
>>
>> TIA
>> Evgeni
>>
>> [1] https://github.com/theforeman/forklift/pulls?page=1=is%3Ap
>> r+author%3Aevgeni=%E2%9C%93
>> [2] https://github.com/theforeman/forklift/commits?author=evgeni
>> [3] https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93;
>> q=involves%3Aevgeni%20is%3Apr%20
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Nomination for an additional GitHub org owner

2017-06-26 Thread John Mitsch
+1 from me!

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Mon, Jun 26, 2017 at 8:50 AM, Andrew Kofink <akof...@redhat.com> wrote:

> +1 for Eric!
>
> On Mon, Jun 26, 2017 at 4:12 AM, Ivan Necas <ine...@redhat.com> wrote:
>
>> Marek Hulán <mhu...@redhat.com> writes:
>>
>> > +1
>>
>> +1
>>
>> >
>> > On pondělí 26. června 2017 7:41:18 CEST Ondrej Prazak wrote:
>> >> +1 from me
>> >>
>> >> On Mon, Jun 26, 2017 at 3:16 AM, Tom McKay <thomasmc...@redhat.com>
>> wrote:
>> >> > +1 for @ehelms
>> >> >
>> >> > On Fri, Jun 23, 2017 at 9:05 AM, Neil Hanlon <nhan...@kayak.com>
>> wrote:
>> >> >> +1 from me :)
>> >> >>
>> >> >> On Fri, Jun 23, 2017 at 8:44 AM Greg Sutcliffe <
>> greg.sutcli...@gmail.com>
>> >> >>
>> >> >> wrote:
>> >> >>> Hi all,
>> >> >>>
>> >> >>> Slightly different to our usual "nominate a new commiter" process,
>> but
>> >> >>> I'm wondering if we need to appoint a new owner on our GitHub
>> >> >>> organisation?
>> >> >>>
>> >> >>> Currently, only Dominic and Ohad are owners, and they are both
>> >> >>> frequently busy with other things, which leads to some delays when
>> >> >>> adding in new repos or moving things about. 2 people is also a
>> fairly
>> >> >>> high bus factor. I think it's time we added a third name to the
>> owners
>> >> >>> - we don't have an official process for this, but I'm treating like
>> >> >>> commit access, so here's a nomination email.
>> >> >>>
>> >> >>> Obviously, this is mainly a role for maintenance - creating/forking
>> >> >>> repos, moving them, creating new teams, etc. rather than about
>> merging
>> >> >>> code. I think a we have a few people that would be a good fit - my
>> >> >>> suggestion would be Eric Helms. He's experienced both in our
>> structure
>> >> >>> & in GitHub-y stuff, and is in a different timezone, which helps if
>> >> >>> something comes up out of European hours.
>> >> >>>
>> >> >>> Any comments/concerns/upvotes? :)
>> >> >>>
>> >> >>> Cheers
>> >> >>> Greg
>> >> >>>
>> >> >>> --
>> >> >>> You received this message because you are subscribed to the Google
>> >> >>> Groups "foreman-dev" group.
>> >> >>> To unsubscribe from this group and stop receiving emails from it,
>> send
>> >> >>> an email to foreman-dev+unsubscr...@googlegroups.com.
>> >> >>> For more options, visit https://groups.google.com/d/optout.
>> >> >>
>> >> >> --
>> >> >> You received this message because you are subscribed to the Google
>> Groups
>> >> >> "foreman-dev" group.
>> >> >> To unsubscribe from this group and stop receiving emails from it,
>> send an
>> >> >> email to foreman-dev+unsubscr...@googlegroups.com.
>> >> >> For more options, visit https://groups.google.com/d/optout.
>> >> >
>> >> > --
>> >> > You received this message because you are subscribed to the Google
>> Groups
>> >> > "foreman-dev" group.
>> >> > To unsubscribe from this group and stop receiving emails from it,
>> send an
>> >> > email to foreman-dev+unsubscr...@googlegroups.com.
>> >> > For more options, visit https://groups.google.com/d/optout.
>> >
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "foreman-dev" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to foreman-dev+unsubscr...@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Associate Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-07 Thread John Mitsch
The greasmonkey script works great! Really helpful, thanks for sharing. For
those who are wondering (like I was), it requires the greasemonkey browser
plugin:

https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/ or

ttps://
chrome.google.com/webstore/detail/tampermonkey/dhdgffkkebhmkfjojejmpbldmpobfkfo?hl=en


That being said, I don't think we should have developers relying on a
 script to have links to issues on a PR, I think we should have a way of
making that link available to everyone like Andrew suggested.

-John

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Fri, Apr 7, 2017 at 4:17 AM, Ivan Necas <ine...@redhat.com> wrote:

> Ivan Necas <ine...@redhat.com> writes:
>
> > Walden Raines <wrai...@redhat.com> writes:
> >
> >> I do it manually although I probably should just write a commit hook to
> do
> >> it.
> >>
> >> I put it in the message itself because I think it's useful to have
> there in
> >> case anyone is browsing the git log or in case we ever move away from
> >> github.
> >
> > Interesting idea. Before it gets in (+ idea for other places outside of
> > prprocessor scope), I'm using Tomas's grease monkey script and has been
> > very helpful in past :)
>
> Forgot to put a link:
> https://gist.github.com/tstrachota/012d1518a08d5a9d441f
>
> -- Ivan
>
> >
> > -- Ivan
> >
> >>
> >> Walden
> >>
> >> On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink <akof...@redhat.com>
> wrote:
> >>
> >>> Walden, you have a script that adds it, or do you do it manually for
> every
> >>> issue? If the latter, then wouldn't this save you some time? ;)
> >>>
> >>> On Thu, Apr 6, 2017 at 5:24 PM, Walden Raines <wrai...@redhat.com>
> wrote:
> >>>
> >>>> I like it although I include the links to the issues in my actual
> commit
> >>>> message so it will be doubled up in my case.
> >>>>
> >>>>
> >>>>
> >>>> On Thu, Apr 6, 2017 at 4:18 PM, John Mitsch <jomit...@redhat.com>
> wrote:
> >>>>
> >>>>> +1 from me :)
> >>>>>
> >>>>> John Mitsch
> >>>>> Red Hat Engineering
> >>>>> (860)-967-7285 <(860)%20967-7285>
> >>>>> irc: jomitsch
> >>>>>
> >>>>> On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink <akof...@redhat.com>
> >>>>> wrote:
> >>>>>
> >>>>>> I find myself copying/pasting issue numbers from GitHub PRs to a
> >>>>>> redmine url way too much every day. It takes a bit of time, and it's
> >>>>>> annoying as well as easy to fix.
> >>>>>>
> >>>>>> I've submitted this PR to comment on a newly submitted PR with
> links to
> >>>>>> the associated issues in redmine: https://github.com/th
> >>>>>> eforeman/prprocessor/pull/59 I'd like to hear your thoughts if you
> >>>>>> have something to say about it.
> >>>>>>
> >>>>>> - Andrew
> >>>>>>
> >>>>>> --
> >>>>>> Andrew Kofink
> >>>>>> akof...@redhat.com
> >>>>>> IRC: akofink
> >>>>>> Associate Software Engineer
> >>>>>> Red Hat Satellite
> >>>>>>
> >>>>>> --
> >>>>>> You received this message because you are subscribed to the Google
> >>>>>> Groups "foreman-dev" group.
> >>>>>> To unsubscribe from this group and stop receiving emails from it,
> send
> >>>>>> an email to foreman-dev+unsubscr...@googlegroups.com.
> >>>>>> For more options, visit https://groups.google.com/d/optout.
> >>>>>>
> >>>>>
> >>>>> --
> >>>>> You received this message because you are subscribed to the Google
> >>>>> Groups "foreman-dev" group.
> >>>>> To unsubscribe from this group and stop receiving emails from it,
> send
> >>>>> an email to foreman-dev+unsubscr...@googlegroups.com.
> >>>>> For more options, visit https://groups.google.com/d/optout.
> >>>>>
> >>>>
> >>>> --
> >>>> You received this message because you are subscribed to the Google
> Groups
> >>>&

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-06 Thread John Mitsch
+1 from me :)

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink <akof...@redhat.com> wrote:

> I find myself copying/pasting issue numbers from GitHub PRs to a redmine
> url way too much every day. It takes a bit of time, and it's annoying as
> well as easy to fix.
>
> I've submitted this PR to comment on a newly submitted PR with links to
> the associated issues in redmine: https://github.com/
> theforeman/prprocessor/pull/59 I'd like to hear your thoughts if you have
> something to say about it.
>
> - Andrew
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Associate Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Katello Repository STI refactoring

2017-03-15 Thread John Mitsch
Hello all,

I wanted to share the plan for refactoring the Katello Repositories model
and get some feedback.

We have been wanting to break up repositories for some time. The
repositories table has a field "content_type", which is used to handle yum,
file, docker, ostree, and puppet repos. In addition to this, there is a
"Content View Puppet Environment" model, which inherits repository methods.
[1]

Some reasons to refactor repositories are:
- The repository model is large and monolithic
- Multiple exceptions have to be made for different content_types i.e [2]
- Its easy to introduce bugs in this area
- the complexity is blocking or making it harder to design new features
around repositories
- Its the first step to implementing content type plugins - original design
here [3]

The plan is to use Single Table Inheritance on the repositories table, and
move the content_type column to the  type column. Each content type will be
its own class and can have its own methods.

The API will likely stay the same or have minimal changes, The rabl files
would  just need updating. Any additional API changes can happen after the
refactoring (with proper deprecation warnings)

This would be broken into small changes, which will look something like
this:
- add STI to repositories model, but keep old logic
- setup classes for each content type
- remove content_type field and update logic that uses that field to know
use type field
- move content based on functionality (in individual commits)
- remove content view puppet environment and use "puppet" type repository
in its place

Let me know if you have any questions, looking forward to hearing
everyone's opinions.

[1]
https://github.com/Katello/katello/blob/master/app/models/katello/content_view_puppet_environment.rb#L6
[2]
https://github.com/Katello/katello/blob/937ca0da561347f94a22aae87aa52ab345eb1238/app/models/katello/glue/pulp/repo.rb#L154-L175
[3] http://projects.theforeman.org/projects/katello/wiki/ContentPlugins

Thanks,
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Re: Automated capsule install in development added to Forklift

2016-09-22 Thread John Mitsch
Just an update that Katello clients have also been added to forklift, so
you can now 'vagrant up' one.

Instructions can be found in this PR to the Forklift docs


John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Fri, Sep 9, 2016 at 10:45 AM, John Mitsch <jomit...@redhat.com> wrote:

> Hello all,
>
> Using Eric's existing work for automated capsule installs for production
> environments in Forklift, I have added automated capsule installs for
> development environments.[1]
>
> Instructions on how to use this functionality can be found in the PR and
> commit message, also there is an example capsule is in boxes.yaml.example
> file.
>
> Let me know if you have any questions or if I can make the instructions
> clearer.
>
> [1] https://github.com/Katello/forklift/pull/233
>
> Thanks,
> John Mitsch
> Red Hat Engineering
> (860)-967-7285
> irc: jomitsch
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Re: Katello 3.2 (Malt Liquor) branching delayed

2016-09-09 Thread John Mitsch
Just an update that Katello was branched for 3.2 today

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Tue, Sep 6, 2016 at 3:29 PM, John Mitsch <jomit...@redhat.com> wrote:

> Hello all,
>
> We are going to delay branching Katello 3.2(Malt Liquor[1]) for a day or
> two in order to get some Puppet 4 changes in. As of right now, we will
> branch Thursday(9/8).
>
> This also gives everyone time to get any open PRs merged, please take a
> look at the state of the 3.2 issues assigned to you here [2].
>
> [1] https://en.wikipedia.org/wiki/Malt_liquor
> [2] http://bit.ly/2c8ofY7
>
> John Mitsch
> Red Hat Engineering
> (860)-967-7285
> irc: jomitsch
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Automated capsule install in development added to Forklift

2016-09-09 Thread John Mitsch
Hello all,

Using Eric's existing work for automated capsule installs for production
environments in Forklift, I have added automated capsule installs for
development environments.[1]

Instructions on how to use this functionality can be found in the PR and
commit message, also there is an example capsule is in boxes.yaml.example
file.

Let me know if you have any questions or if I can make the instructions
clearer.

[1] https://github.com/Katello/forklift/pull/233

Thanks,
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Forklift and networking

2016-09-07 Thread John Mitsch
David,

Not sure if this will work in your exact situation, but many of us use this
script [1] to set up proxies with internal IP addresses. So if your VM had
an IP of 192.168.121.12 you would go to :50012 and you
can access your VM. I am not sure if this can be tweaked for bridged
networking, but figured I would share.

[1] https://gist.github.com/johnpmitsch/a69c904d9af358834907427fa697edbe



John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Wed, Sep 7, 2016 at 1:21 PM, David Davis <davidda...@redhat.com> wrote:

> Is anyone connecting to their vagrant VMs directly from another machine,
> one other than the box running vagrant? I have a desktop I am using to spin
> up vagrant VMs but I do most of my work on my laptop.
>
> Currently, I am using bridged networking on the hypervisor to give the VM
> a network IP that I can access directly. However, provisioning from my dev
> environment doesn’t seem to work and some of the playbooks in forklift that
> involve one VM connecting to another don’t seem to work either.
>
> I know I could also forward ports using my desktop’s firewall but having
> to add those rules every time I spin up a VM doesn’t seem ideal. Are there
> any other options I am missing?
>
> Thanks.
>
> David
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.