Re: [foreman-users] Deleting smart class parameters when deleting a puppetclass
Hi I don't see any point in keeping them for historical purposes. We don't do that for any other object so it isn't expected behaviour - the place to look for historical information is in the Audits, and anyways restoring them isn't a simple action. As far as preventing accidental deletion, the only thing I can think of is a warning when deleting a puppet class that has smart parameters (both when directly deleting and when deleting using the importer). On Thu, Dec 8, 2016 at 10:31 PM, 'Jason B. Nance' via Foreman users < foreman-users@googlegroups.com> wrote: > +1 for delete them given that no where else I can recall in TFM is there > any sort of "undelete" or configuration version history (though I'd love to > see the latter so that we can compare changes/rollback/etc). > > j > > > -- > *From: *"Greg Sutcliffe" <greg.sutcli...@gmail.com> > *To: *"Foreman users" <foreman-users@googlegroups.com> > *Sent: *Thursday, December 8, 2016 10:50:45 AM > *Subject: *Re: [foreman-users] Deleting smart class parameters when > deleting a puppetclass > > Tricky question. I agree they're not so useful without a record of what > class they were tied to, and worse, if you upload a new class of the same > name, it may no longer accept those parameters, so it's questionable if > they can be restored smoothly anyway. > > My gut feeling is to drop them - but before we go there, let me ask a UI > question. Given the current import page already shows quite a lot of > information, is there a good way to also show what parameter overrides will > be deleted? > > Greg > > -- > You received this message because you are subscribed to the Google Groups > "Foreman users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-users+unsubscr...@googlegroups.com. > To post to this group, send email to foreman-users@googlegroups.com. > Visit this group at https://groups.google.com/group/foreman-users. > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Foreman users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-users+unsubscr...@googlegroups.com. > To post to this group, send email to foreman-users@googlegroups.com. > Visit this group at https://groups.google.com/group/foreman-users. > For more options, visit https://groups.google.com/d/optout. > -- Have a nice day, Tomer Brisker Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-users+unsubscr...@googlegroups.com. To post to this group, send email to foreman-users@googlegroups.com. Visit this group at https://groups.google.com/group/foreman-users. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-users] Deleting smart class parameters when deleting a puppetclass
+1 for delete them given that no where else I can recall in TFM is there any sort of "undelete" or configuration version history (though I'd love to see the latter so that we can compare changes/rollback/etc). j From: "Greg Sutcliffe" <greg.sutcli...@gmail.com> To: "Foreman users" <foreman-users@googlegroups.com> Sent: Thursday, December 8, 2016 10:50:45 AM Subject: Re: [foreman-users] Deleting smart class parameters when deleting a puppetclass Tricky question. I agree they're not so useful without a record of what class they were tied to, and worse, if you upload a new class of the same name, it may no longer accept those parameters, so it's questionable if they can be restored smoothly anyway. My gut feeling is to drop them - but before we go there, let me ask a UI question. Given the current import page already shows quite a lot of information, is there a good way to also show what parameter overrides will be deleted? Greg -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [ mailto:foreman-users+unsubscr...@googlegroups.com | foreman-users+unsubscr...@googlegroups.com ] . To post to this group, send email to [ mailto:foreman-users@googlegroups.com | foreman-users@googlegroups.com ] . Visit this group at [ https://groups.google.com/group/foreman-users | https://groups.google.com/group/foreman-users ] . For more options, visit [ https://groups.google.com/d/optout | https://groups.google.com/d/optout ] . -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-users+unsubscr...@googlegroups.com. To post to this group, send email to foreman-users@googlegroups.com. Visit this group at https://groups.google.com/group/foreman-users. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-users] Deleting smart class parameters when deleting a puppetclass
Tricky question. I agree they're not so useful without a record of what class they were tied to, and worse, if you upload a new class of the same name, it may no longer accept those parameters, so it's questionable if they can be restored smoothly anyway. My gut feeling is to drop them - but before we go there, let me ask a UI question. Given the current import page already shows quite a lot of information, is there a good way to also show what parameter overrides will be deleted? Greg -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-users+unsubscr...@googlegroups.com. To post to this group, send email to foreman-users@googlegroups.com. Visit this group at https://groups.google.com/group/foreman-users. For more options, visit https://groups.google.com/d/optout.
[foreman-users] Deleting smart class parameters when deleting a puppetclass
TL;DR: should we still keep smart class parameters when deleting the class? When a puppet class is deleted it's smart class parameters are kept as historical records. If a puppet class is accidentally deleted or someone wants to see the overrides a parameter used to have it's easy to see from the smart class parameter that was preserved. This is much simpler then searching for the parameter's previous state in the audit log and might be useful in creating parameter versions. These smart class parameters show up in the index page with no connection to a puppet class. There has been some confusion around the issue when duplicate records of the same parameter appear. Originally a bug was opened about it and rejected because this is intentional: http://projects.theforeman.org/issues/17076. After another issue was opened and it came up a few times on IRC it seemed better to hide these parameters in the ui: http://projects. theforeman.org/issues/17548. The api wouldn't return them even before the change and if needed they can be tracked in the db so we still have historical records but there is no more confusion. The reasons for keeping the smart class parameters are still valid (accidental delete, easier then audit log, maybe possible to use as first step towards versioning), but we don't save the puppetclass they were connected to (so right now not so good for versioning), the api doesn't return them and using them means manually coping every detail. Should we still keep them? -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-users+unsubscr...@googlegroups.com. To post to this group, send email to foreman-users@googlegroups.com. Visit this group at https://groups.google.com/group/foreman-users. For more options, visit https://groups.google.com/d/optout.
