[fossil-users] Numbered list syntax?
Hello, I am looking at the source and see that enumerated lists are defined by: 1. Hello 2. Goodbye i.e. a two spaces, a number, a period, two spaces, text. Why was it decided to use that syntax instead of the common # syntax? This means that if I have a list of ten things and want to add in an item after position 4, I have to reorder the entire list. In the fossil docs for the rationale of the wiki markup, I read: The wiki markup used by fossil, though limited, is common to most other wiki engines, is intuitive, and is sufficient for 90% of all formatting tasks. I've used a lot of wiki's and have not seen the numbered list syntax of above and it does not seem intuitive either. I made the change to fossil to support # Hello # Goodbye can I commit the change drh? The 1. Hello 2. Goodbye syntax is intact and unchanged. Jeremy ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] feature proposal for anonymous login
Hi, all! i've just added a feature which is highly arguable and therefore i want to check the general opinion on the topic before i commit it: When logging in as the anonymous user, it is painful to not be able to copy/paste the captcha into the login field. In my experience a simple text-based captcha works as well as a graphic if the captcha text is muddled with text a user won't see but a bot would, e.g. a captcha of ABCD can be rendered from javascript one letter at a time, and a bot won't be able to figure out that it creates a readable captcha string. So i added a button to the login screen called Auto-fill Password, which copies the captcha hex code into the password field and fills out the user name as anonymous. The captcha's value _is_ stored in the HTML code for the button, but a bot would literally need to simulate a click on the button, followed by the Login button, to get by it. Few, if any, bots process javascript, and those who do would have to know the order to click the buttons to get logged in. i.e. the chances are near 0 that the captcha could be bot-abused even though it's stored as a plain string within the HTML form code. If there are no strong feelings _against_ this, i'll go ahead and commit it. This feature can currently be seen in action over at: http://fossil.wanderinghorse.net -- - stephan beal http://wanderinghorse.net/home/stephan/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] feature proposal for anonymous login
On Mon, Dec 07, 2009 at 08:33:12PM +0100, Stephan Beal wrote: Hi, all! i've just added a feature which is highly arguable and therefore i want to check the general opinion on the topic before i commit it: When logging in as the anonymous user, it is painful to not be able to copy/paste the captcha into the login field. In my experience a simple I'd say no, I wouldn't want this feature is it makes bots trivial to implement. The point of a captcha is to make it slightly painful, and since this is a tool designed for developers I don't see much of a problem with the current captcha. However, if it were an optional setting then there'd be nothing wrong with it being there. Those who need simpler user input could turn it on, and those who need more spam/bot blocking can turn it off. -- Zed A. Shaw http://zedshaw.com/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] feature proposal for anonymous login
On Mon, 2009-12-07 at 20:33 +0100, Stephan Beal wrote: So i added a button to the login screen called Auto-fill Password, which copies the captcha hex code into the password field and fills out the user name as anonymous. The captcha's value _is_ stored in the HTML code for the button, but a bot would literally need to simulate a click on the button, followed by the Login button, to get by it. So a general-purpose stupid-bot probably won't get through. But it would only take a few minutes to write a fossil repo-scraping bot if this were implemented. Granted that the existing captcha provides little protection and shouldn't be relied upon for security, I still wouldn't want to poke holes in the condom here. -- Joshua Paine LetterBlock: Web applications built with joy http://letterblock.com/ 301-576-1920 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] feature proposal for anonymous login
On Dec 7, 2009, at 2:48 PM, Zed A. Shaw wrote: On Mon, Dec 07, 2009 at 08:33:12PM +0100, Stephan Beal wrote: Hi, all! i've just added a feature which is highly arguable and therefore i want to check the general opinion on the topic before i commit it: When logging in as the anonymous user, it is painful to not be able to copy/paste the captcha into the login field. In my experience a simple I'd say no, I wouldn't want this feature is it makes bots trivial to implement. The point of a captcha is to make it slightly painful, and since this is a tool designed for developers I don't see much of a problem with the current captcha. However, if it were an optional setting then there'd be nothing wrong with it being there. Those who need simpler user input could turn it on, and those who need more spam/bot blocking can turn it off. I was going to suggest the same thing, but Zed beat me to it Another thing that would be really cool: Add a feature to the Setup menu that gives the administrator a choice of several skins for Fossil using a single button click. Leave the current look as the default, but make the wonderinghorse.net skin one of the preferred options. D. Richard Hipp d...@hwaci.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] feature proposal for anonymous login
On Mon, Dec 7, 2009 at 9:07 PM, D. Richard Hipp d...@hwaci.com wrote: On Dec 7, 2009, at 2:48 PM, Zed A. Shaw wrote: I'd say no, I wouldn't want this feature is it makes bots trivial to ... However, if it were an optional setting then there'd be nothing wrong with it being there. Those who need simpler user input could turn it on, and those who need more spam/bot blocking can turn it off. I was going to suggest the same thing, but Zed beat me to it Thank you Richard, Zed, and Joshua, for the input. i agree that any feature as arguable as this needs a toggle (if it needs to be added at all). i'll see what needs to be done on the setup page for this, and then scramble the underlying JS code to make it unparseable to a bot (e.g. 1234567 becomes '1'+'2'+'3'+'4'+..., which no bot in the world would know what to do with). Another thing that would be really cool: Add a feature to the Setup menu that gives the administrator a choice of several skins for Fossil using a single button click. That's a larger task i'll have to punt on at the moment, but this would be a nice feature. If we had a separate skins table which contain the css/header/footer/etc for skin sets, we could copy that over the current config on demand. Which parts would need to be stored for each skin definition? e.g. CSS, header, footer... what else? -- - stephan beal http://wanderinghorse.net/home/stephan/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] invalid placement of P tags in wiki lists
On Mon, Dec 7, 2009 at 7:44 PM, Stephan Beal sgb...@googlemail.com wrote: - The UL lists created by the wiki have a strangely-placed P tag in them. Thanks, Jeremy, for that quick fix (commit 6f0df6c741). But doesn't the same need to be applied to endAutoParagraph() as well? If it's not, UL/OL will have a closer but no opener (if i understood the code properly). http://www.fossil-scm.org/index.html/vinfo/6f0df6c741887ef251d89224bc7c14894d489aed -- - stephan beal http://wanderinghorse.net/home/stephan/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] feature proposal for anonymous login
On Dec 7, 2009, at 2:48 PM, Zed A. Shaw wrote: I'd say no, I wouldn't want this feature is it makes bots trivial to ... However, if it were an optional setting then there'd be nothing wrong with it being there. Those who need simpler user input could turn it on, and those who need more spam/bot blocking can turn it off. i'm not happy with the configuration option's name (anon-login-enable-captcha-filler), but it's in there. To set it via the UI, go to Admin - Users - anonymous, and it's down by his password field. It does not appear in the editors for non-anon users. http://www.fossil-scm.org/index.html/vinfo/00b778bd585d92646741bca9755cbe6fa7cf4567 -- - stephan beal http://wanderinghorse.net/home/stephan/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] invalid placement of P tags in wiki lists
On Mon, Dec 7, 2009 at 7:44 PM, Stephan Beal sgb...@googlemail.com wrote:
- The UL lists created by the wiki have a strangely-placed P tag in them.
Thanks, Jeremy, for that quick fix (commit 6f0df6c741). But doesn't the same
need to be applied to endAutoParagraph() as well? If it's not, UL/OL will
have a closer but no opener (if i understood the code properly).
http://www.fossil-scm.org/index.html/vinfo/6f0df6c741887ef251d89224bc7c14894d489aed
Stephen, sorry for the problems with my mail client. This one should go to the
list.
No. The reason is that the paragraph is never pushed onto the stack, thus when
closing the tags out, there is not a paragraph to pop off (close).
I saw a commit where the code was duplicated into the endAutoParagraph. I don't
think it's necessary. Did you have a test case where it's not working?
The code in startAutoParagraph reads:
static void startAutoParagraph(Renderer *p){
if( p-wantAutoParagraph==0 || p-wikiList==MARKUP_OL ||
p-wikiList==MARKUP_UL ) return;
blob_appendf(p-pOut, p, -1);
pushStack(p, MARKUP_P);
p-wantAutoParagraph = 0;
p-inAutoParagraph = 1;
}
i.e. if we are in a MARKUP_OL or MARKUP_UL, then it returns from the function.
If not, it continues and sets p-inAutoParagraph = 1;
Then in the endAutoParagraph, the test for p-inAutoParagraph is first...
static void endAutoParagraph(Renderer *p){
if( p-inAutoParagraph ){
popStackToTag(p, MARKUP_P);
p-inAutoParagraph = 0;
}
}
Your change, I believe, is unnecessary and may actually cause some unforseen
problems.
Jeremy
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
